foreman_openscap 8.0.2 → 9.0.1

data/webpack/routes/OvalPolicies/OvalPoliciesIndex/__tests__/OvalPoliciesIndex.fixtures.js

@@ -1,111 +0,0 @@
-import policiesQuery from '../../../../graphql/queries/ovalPolicies.gql';
-import { ovalPoliciesPath } from '../../../../helpers/pathsHelper';
-import {
-  mockFactory,
-  admin,
-  intruder,
-  userFactory,
-} from '../../../../testHelper';
-
-const policiesMockFactory = mockFactory('ovalPolicies', policiesQuery);
-
-export const pushMock = jest.fn();
-
-export const pageParamsHistoryMock = {
-  location: {
-    search: '?page=2&perPage=5',
-    pathname: ovalPoliciesPath,
-  },
-  push: pushMock,
-};
-
-const viewer = userFactory('viewer', [
-  {
-    __typename: 'Permission',
-    id: 'MDE6UGVybWlzc2lvbi0yOTY=',
-    name: 'view_oval_policies',
-  },
-]);
-
-const firstPolicy = (meta = { canDestroy: true }) => ({
-  __typename: 'ForemanOpenscap::OvalPolicy',
-  id: 'MDE6Rm9yZW1hbk9wZW5zY2FwOjpPdmFsUG9saWN5LTE=',
-  name: 'first policy',
-  meta,
-  ovalContent: { name: 'first content' },
-});
-const secondPolicy = (meta = { canDestroy: true }) => ({
-  __typename: 'ForemanOpenscap::OvalPolicy',
-  id: 'MDE6Rm9yZW1hbk9wZW5zY2FwOjpPdmFsUG9saWN5LTQw',
-  name: 'second policy',
-  meta,
-  ovalContent: { name: 'second content' },
-});
-const policiesData = {
-  totalCount: 2,
-  nodes: [firstPolicy(), secondPolicy()],
-};
-
-export const mocks = policiesMockFactory(
-  { first: 20, last: 20 },
-  policiesData,
-  { currentUser: admin }
-);
-export const pageParamsMocks = policiesMockFactory(
-  { first: 10, last: 5 },
-  {
-    totalCount: 7,
-    nodes: [
-      {
-        __typename: 'ForemanOpenscap::OvalPolicy',
-        id: 'MDE6Rm9yZW1hbk9wZW5zY2FwOjpPdmFsUG9saWN5LTQx',
-        name: 'sixth policy',
-        meta: { canDestroy: true },
-        ovalContent: { name: 'sixth content' },
-      },
-      {
-        __typename: 'ForemanOpenscap::OvalPolicy',
-        id: 'MDE6Rm9yZW1hbk9wZW5zY2FwOjpPdmFsUG9saWN5LTQy',
-        name: 'seventh policy',
-        meta: { canDestroy: true },
-        ovalContent: { name: 'seventh content' },
-      },
-    ],
-  },
-  { currentUser: admin }
-);
-
-export const emptyMocks = policiesMockFactory(
-  { first: 20, last: 20 },
-  { totalCount: 0, nodes: [] },
-  { currentUser: admin }
-);
-export const errorMocks = policiesMockFactory(
-  { first: 20, last: 20 },
-  { totalCount: 0, nodes: [] },
-  {
-    errors: [{ message: 'Something very bad happened.', path: 'base' }],
-    currentUser: admin,
-  }
-);
-export const viewerMocks = policiesMockFactory(
-  { first: 20, last: 20 },
-  policiesData,
-  { currentUser: viewer }
-);
-export const unauthorizedMocks = policiesMockFactory(
-  { first: 20, last: 20 },
-  policiesData,
-  { currentUser: intruder }
-);
-export const noDeleteMocks = policiesMockFactory(
-  { first: 20, last: 20 },
-  {
-    totalCount: 2,
-    nodes: [
-      firstPolicy({ canDestroy: false }),
-      secondPolicy({ canDestroy: false }),
-    ],
-  },
-  { currentUser: admin }
-);

data/webpack/routes/OvalPolicies/OvalPoliciesIndex/__tests__/OvalPoliciesIndex.test.js

@@ -1,81 +0,0 @@
-import React from 'react';
-import { render, screen, waitFor } from '@testing-library/react';
-import '@testing-library/jest-dom';
-
-import {
-  withMockedProvider,
-  withRouter,
-  withRedux,
-  tick,
-  historyMock,
-} from '../../../../testHelper';
-
-import {
-  mocks,
-  emptyMocks,
-  errorMocks,
-  viewerMocks,
-  unauthorizedMocks,
-} from './OvalPoliciesIndex.fixtures';
-
-import OvalPoliciesIndex from '../index';
-
-const TestComponent = withRouter(
-  withRedux(withMockedProvider(OvalPoliciesIndex))
-);
-
-describe('OvalPoliciesIndex', () => {
-  it('should load page', async () => {
-    render(<TestComponent history={historyMock} mocks={mocks} />);
-    expect(screen.getByText('Loading')).toBeInTheDocument();
-    await waitFor(tick);
-    expect(screen.getByText('first policy')).toBeInTheDocument();
-    expect(screen.getByText('second policy')).toBeInTheDocument();
-    expect(screen.getByText('first content')).toBeInTheDocument();
-    expect(screen.getByText('second content')).toBeInTheDocument();
-
-    expect(screen.getByText('first policy').closest('a')).toHaveAttribute(
-      'href',
-      '/experimental/compliance/oval_policies/1'
-    );
-    expect(screen.getByText('second policy').closest('a')).toHaveAttribute(
-      'href',
-      '/experimental/compliance/oval_policies/40'
-    );
-  });
-  it('should show empty state', async () => {
-    render(<TestComponent history={historyMock} mocks={emptyMocks} />);
-    expect(screen.getByText('Loading')).toBeInTheDocument();
-    await waitFor(tick);
-    expect(screen.queryByText('Loading')).not.toBeInTheDocument();
-    expect(screen.getByText('No OVAL Policies found')).toBeInTheDocument();
-  });
-  it('should show errors', async () => {
-    render(<TestComponent history={historyMock} mocks={errorMocks} />);
-    expect(screen.getByText('Loading')).toBeInTheDocument();
-    await waitFor(tick);
-    expect(screen.queryByText('Loading')).not.toBeInTheDocument();
-    expect(
-      screen.getByText('Something very bad happened.')
-    ).toBeInTheDocument();
-    expect(screen.getByText('Error!')).toBeInTheDocument();
-  });
-  it('should load page for user with permissions', async () => {
-    render(<TestComponent history={historyMock} mocks={viewerMocks} />);
-    await waitFor(tick);
-    expect(screen.queryByText('Loading')).not.toBeInTheDocument();
-    expect(screen.getByText('first policy')).toBeInTheDocument();
-  });
-  it('should not load page for user without permissions', async () => {
-    render(<TestComponent history={historyMock} mocks={unauthorizedMocks} />);
-    await waitFor(tick);
-    expect(screen.queryByText('Loading')).not.toBeInTheDocument();
-    expect(screen.queryByText('first policy')).not.toBeInTheDocument();
-    expect(
-      screen.getByText(
-        'You are not authorized to view the page. Request the following permissions from administrator: view_oval_policies.'
-      )
-    ).toBeInTheDocument();
-    expect(screen.getByText('Permission denied')).toBeInTheDocument();
-  });
-});

data/webpack/routes/OvalPolicies/OvalPoliciesIndex/index.js

@@ -1,13 +0,0 @@
-import React from 'react';
-import { useDispatch } from 'react-redux';
-import { showToast } from '../../../helpers/toastHelper';
-
-import OvalPoliciesIndex from './OvalPoliciesIndex';
-
-const WrappedOvalPoliciesIndex = props => {
-  const dispatch = useDispatch();
-
-  return <OvalPoliciesIndex {...props} showToast={showToast(dispatch)} />;
-};
-
-export default WrappedOvalPoliciesIndex;

data/webpack/routes/OvalPolicies/OvalPoliciesNew/HostgroupSelect.js

@@ -1,135 +0,0 @@
-import React, { useState } from 'react';
-import PropTypes from 'prop-types';
-import { useLazyQuery } from '@apollo/client';
-import { translate as __, sprintf } from 'foremanReact/common/I18n';
-import {
-  Select,
-  SelectOption,
-  SelectVariant,
-  FormGroup,
-} from '@patternfly/react-core';
-import { ExclamationCircleIcon } from '@patternfly/react-icons';
-import hostgroupsQuery from '../../../graphql/queries/hostgroups.gql';
-
-const HostgroupSelect = ({
-  selected,
-  setSelected,
-  hgsError,
-  showError,
-  setShowError,
-}) => {
-  const [isOpen, setIsOpen] = useState(false);
-
-  const [typingTimeout, setTypingTimeout] = useState(null);
-
-  const [fetchHostgroups, { loading, data, error }] = useLazyQuery(
-    hostgroupsQuery
-  );
-  const results = data?.hostgroups?.nodes ? data.hostgroups.nodes : [];
-
-  const onSelect = (event, selection) => {
-    if (selected.find(item => item.name === selection)) {
-      setSelected(selected.filter(item => item.name !== selection));
-    } else {
-      const hg = results.find(item => item.name === selection);
-      setSelected([...selected, hg]);
-    }
-  };
-
-  const onClear = () => {
-    if (showError) {
-      setShowError(false);
-    }
-    setSelected([]);
-  };
-
-  const onInputChange = value => {
-    if (showError) {
-      setShowError(false);
-    }
-    if (typingTimeout) {
-      clearTimeout(typingTimeout);
-    }
-    const variables = { search: `name ~ ${value}` };
-    setTypingTimeout(setTimeout(() => fetchHostgroups({ variables }), 500));
-  };
-
-  const shouldValidate = (err, shouldShowError) => {
-    if (shouldShowError) {
-      return err ? 'error' : 'success';
-    }
-    return 'noval';
-  };
-
-  const prepareOptions = fetchedResults => {
-    if (loading) {
-      return [
-        <SelectOption isDisabled key={0}>
-          {__('Loading...')}
-        </SelectOption>,
-      ];
-    }
-
-    if (error) {
-      return [
-        <SelectOption isDisabled key={0}>
-          {sprintf('Failed to fetch hostgroups, cause: %s', error.message)}
-        </SelectOption>,
-      ];
-    }
-
-    if (fetchedResults.length > 20) {
-      return [
-        <SelectOption isDisabled key={0}>
-          {sprintf(
-            'You have %s hostgroups to display. Please refine your search.',
-            fetchedResults.length
-          )}
-        </SelectOption>,
-      ];
-    }
-
-    return fetchedResults.map((hg, idx) => (
-      <SelectOption key={hg.id} value={hg.name} />
-    ));
-  };
-
-  return (
-    <FormGroup
-      label={__('Hostgroups')}
-      helperTextInvalidIcon={<ExclamationCircleIcon />}
-      helperTextInvalid={showError && hgsError}
-      validated={shouldValidate(hgsError, showError)}
-    >
-      <Select
-        variant={SelectVariant.typeaheadMulti}
-        typeAheadAriaLabel="Select a hostgroup"
-        placeholderText={__('Type a hostgroup name...')}
-        onToggle={() => setIsOpen(!isOpen)}
-        onSelect={onSelect}
-        onClear={onClear}
-        selections={selected.map(item => item.name)}
-        isOpen={isOpen}
-        onTypeaheadInputChanged={onInputChange}
-        validated={shouldValidate(hgsError, showError)}
-      >
-        {prepareOptions(results)}
-      </Select>
-    </FormGroup>
-  );
-};
-
-HostgroupSelect.propTypes = {
-  selected: PropTypes.array,
-  setSelected: PropTypes.func.isRequired,
-  hgsError: PropTypes.string,
-  showError: PropTypes.bool.isRequired,
-  setShowError: PropTypes.func.isRequired,
-};
-
-HostgroupSelect.defaultProps = {
-  selected: [],
-  hgsError: '',
-};
-
-export default HostgroupSelect;

data/webpack/routes/OvalPolicies/OvalPoliciesNew/NewOvalPolicyForm.js

@@ -1,119 +0,0 @@
-import React, { useState } from 'react';
-import PropTypes from 'prop-types';
-import { Formik, Field as FormikField } from 'formik';
-import { useMutation } from '@apollo/client';
-import { translate as __ } from 'foremanReact/common/I18n';
-import { Button, Form as PfForm, ActionGroup } from '@patternfly/react-core';
-
-import createOvalPolicy from '../../../graphql/mutations/createOvalPolicy.gql';
-
-import {
-  TextField,
-  TextAreaField,
-  SelectField,
-} from '../../../helpers/formFieldsHelper';
-import HostgroupSelect from './HostgroupSelect';
-import withLoading from '../../../components/withLoading';
-
-import { ovalPoliciesPath } from '../../../helpers/pathsHelper';
-import LinkButton from '../../../components/LinkButton';
-
-import {
-  createValidationSchema,
-  onSubmit,
-  initialValues,
-} from './NewOvalPolicyFormHelpers';
-
-const NewOvalPolicyForm = ({ history, showToast, ovalContents }) => {
-  const [callMutation] = useMutation(createOvalPolicy);
-
-  const [assignedHgs, setAssignedHgs] = useState([]);
-  const [hgsShowError, setHgsShowError] = useState(false);
-  const [hgsError, setHgsError] = useState('');
-
-  const onHgsError = error => {
-    setHgsShowError(true);
-    setHgsError(error);
-  };
-
-  return (
-    <Formik
-      onSubmit={onSubmit(
-        history,
-        showToast,
-        callMutation,
-        assignedHgs,
-        onHgsError
-      )}
-      initialValues={initialValues}
-      validationSchema={createValidationSchema()}
-    >
-      {formProps => (
-        <PfForm>
-          <FormikField
-            name="name"
-            component={TextField}
-            label={__('Name')}
-            isRequired
-          />
-          <FormikField
-            name="description"
-            component={TextAreaField}
-            label={__('Description')}
-          />
-          <FormikField
-            name="cronLine"
-            component={TextField}
-            label={__('Schedule')}
-            isRequired
-          />
-          <FormikField
-            name="ovalContentId"
-            component={SelectField}
-            selectItems={ovalContents}
-            label={__('OVAL Content')}
-            isRequired
-            blankLabel={__('Choose OVAL Content')}
-          />
-          <HostgroupSelect
-            selected={assignedHgs}
-            setSelected={setAssignedHgs}
-            showError={hgsShowError}
-            setShowError={setHgsShowError}
-            hgsError={hgsError}
-            isDisabled={formProps.isSubmitting}
-          />
-          <ActionGroup>
-            <Button
-              variant="primary"
-              onClick={formProps.handleSubmit}
-              isDisabled={
-                !formProps.isValid ||
-                formProps.isSubmitting ||
-                (hgsShowError && hgsError)
-              }
-              aria-label="submit"
-            >
-              {__('Submit')}
-            </Button>
-            <LinkButton
-              path={ovalPoliciesPath}
-              btnVariant="link"
-              btnText={__('Cancel')}
-              btnAriaLabel="cancel"
-              isDisabled={formProps.isSubmitting}
-            />
-          </ActionGroup>
-        </PfForm>
-      )}
-    </Formik>
-  );
-};
-
-NewOvalPolicyForm.propTypes = {
-  history: PropTypes.object.isRequired,
-  showToast: PropTypes.func.isRequired,
-  ovalContents: PropTypes.array.isRequired,
-};
-
-export default withLoading(NewOvalPolicyForm);

data/webpack/routes/OvalPolicies/OvalPoliciesNew/NewOvalPolicyFormHelpers.js

@@ -1,107 +0,0 @@
-import * as Yup from 'yup';
-import { translate as __, sprintf } from 'foremanReact/common/I18n';
-
-import { ovalPoliciesPath } from '../../../helpers/pathsHelper';
-import { decodeId, decodeModelId } from '../../../helpers/globalIdHelper';
-
-export const createValidationSchema = () => {
-  const cantBeBlank = __("can't be blank");
-
-  return Yup.object().shape({
-    name: Yup.string().required(cantBeBlank),
-    ovalContentId: Yup.string().required(cantBeBlank),
-    cronLine: Yup.string().test(
-      'is-cron',
-      __('is not a valid cronline'),
-      value => value && value.trim().split(' ').length === 5
-    ),
-  });
-};
-
-const partitionById = (array, name) => {
-  const res = array.reduce(
-    (memo, item) => {
-      if (item.id === name) {
-        memo.left.push(item);
-      } else {
-        memo.right.push(item);
-      }
-      return memo;
-    },
-    { left: [], right: [] }
-  );
-  return [res.left, res.right];
-};
-
-const checksToMessage = checks =>
-  checks.reduce((memo, check) => [...memo, check.failMsg], []).join(' ');
-
-export const onSubmit = (
-  history,
-  showToast,
-  callMutation,
-  assignedHgs,
-  setHgsError
-) => (values, actions) => {
-  const onCompleted = response => {
-    const failedChecks = response.data.createOvalPolicy.checkCollection.filter(
-      check => check.result === 'fail'
-    );
-    if (failedChecks.length === 0) {
-      history.push(ovalPoliciesPath);
-      showToast({
-        type: 'success',
-        message: __('OVAL Policy succesfully created.'),
-      });
-    } else {
-      actions.setSubmitting(false);
-
-      const [validationChecks, withoutValidationChecks] = partitionById(
-        failedChecks,
-        'oval_policy_errors'
-      );
-
-      const [hgChecks, remainingChecks] = partitionById(
-        withoutValidationChecks,
-        'hostgroups_without_proxy'
-      );
-      if (validationChecks.length === 1) {
-        actions.setErrors(validationChecks[0].errors);
-      }
-      if (hgChecks.length > 0) {
-        setHgsError(checksToMessage(hgChecks));
-      }
-      if (remainingChecks.length > 0) {
-        showToast({
-          type: 'error',
-          message: checksToMessage(remainingChecks),
-        });
-      }
-    }
-  };
-
-  const onError = response => {
-    showToast({
-      type: 'error',
-      message: sprintf(__('Failed to create OVAL Policy: %s'), response.error),
-    });
-    actions.setSubmitting(false);
-  };
-
-  const hostgroupIds = assignedHgs.map(decodeModelId);
-  const variables = {
-    ...values,
-    ovalContentId: decodeId(values.ovalContentId),
-    period: 'custom',
-    hostgroupIds,
-  };
-  // eslint-disable-next-line promise/prefer-await-to-then
-  callMutation({ variables }).then(onCompleted, onError);
-};
-
-export const initialValues = {
-  name: '',
-  description: '',
-  ovalContentId: '',
-  cronLine: '',
-};

data/webpack/routes/OvalPolicies/OvalPoliciesNew/OvalPoliciesNew.js

@@ -1,32 +0,0 @@
-import React from 'react';
-import { useQuery } from '@apollo/client';
-import { translate as __ } from 'foremanReact/common/I18n';
-import IndexLayout from '../../../components/IndexLayout';
-
-import ovalContentsQuery from '../../../graphql/queries/ovalContents.gql';
-import NewOvalPolicyForm from './NewOvalPolicyForm';
-
-const OvalPoliciesNew = props => {
-  const useFetchFn = () => useQuery(ovalContentsQuery);
-
-  const renameData = data => ({
-    ovalContents: data.ovalContents.nodes,
-  });
-
-  return (
-    <IndexLayout pageTitle={__('Create OVAL Policy')}>
-      <NewOvalPolicyForm
-        fetchFn={useFetchFn}
-        renameData={renameData}
-        resultPath="ovalContents.nodes"
-        emptyStateTitle={__('No OVAL Content found')}
-        emptyStateBody={__(
-          'OVAL Content is required to create OVAL Policy. Please create one before proceeding.'
-        )}
-        {...props}
-      />
-    </IndexLayout>
-  );
-};
-
-export default OvalPoliciesNew;