foreman_omaha 3.0.0 → 4.0.0

data/test/graphql/queries/omaha_reports_query_test.rb

@@ -0,0 +1,47 @@
+# frozen_string_literal: true
+
+require 'test_plugin_helper'
+
+module Queries
+  class OmahaReportsQueryTest < GraphQLQueryTestCase
+    let(:query) do
+      <<-GRAPHQL
+      query omahaReportsQuery {
+        omahaReports {
+          totalCount
+          pageInfo {
+            startCursor
+            endCursor
+            hasNextPage
+            hasPreviousPage
+          }
+          edges {
+            cursor
+            node {
+              id
+              status
+              omahaVersion
+            }
+          }
+        }
+      }
+      GRAPHQL
+    end
+
+    let(:data) { result['data']['omahaReports'] }
+
+    setup do
+      FactoryBot.create_list(:omaha_report, 2)
+    end
+
+    test 'fetching omaha reports attributes' do
+      assert_empty result['errors']
+
+      expected_count = ForemanOmaha::OmahaReport.count
+
+      assert_not_equal 0, expected_count
+      assert_equal expected_count, data['totalCount']
+      assert_equal expected_count, data['edges'].count
+    end
+  end
+end

data/test/test_plugin_helper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # This calls the main test_helper in Foreman-core
 require 'test_helper'
 require 'database_cleaner'

data/test/unit/charts/oem_distribution_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_plugin_helper'
 
 module ForemanOmaha

data/test/unit/charts/status_distribution_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_plugin_helper'
 
 module ForemanOmaha

data/test/unit/charts/version_distribution_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_plugin_helper'
 
 module ForemanOmaha

data/test/unit/group_version_breakdown_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_plugin_helper'
 
 class CurrentVersionBreakdownTest < ActiveSupport::TestCase

data/test/unit/host_status/omaha_status_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_plugin_helper'
 
 class OmahaStatusTest < ActiveSupport::TestCase
@@ -10,10 +12,10 @@ class OmahaStatusTest < ActiveSupport::TestCase
   end
 
   test '#relevant? is only for hosts with an omaha facet' do
-    assert_equal true, status.relevant?
+    assert status.relevant?
 
     status.host = FactoryBot.build_stubbed(:host)
 
-    assert_equal false, status.relevant?
+    assert_not status.relevant?
   end
 end

data/test/unit/host_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_plugin_helper'
 
 class HostTest < ActiveSupport::TestCase

data/test/unit/omaha_fact_parser_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_helper'
 
 class OmahaFactsParserTest < ActiveSupport::TestCase
@@ -19,7 +21,8 @@ class OmahaFactsParserTest < ActiveSupport::TestCase
       'osminor' => '9.0',
       'ipaddress' => '127.0.0.1',
       'ipaddress6' => '',
-      'hostname' => 'client.example.com'
+      'hostname' => 'client.example.com',
+      'distribution' => 'coreos'
     }
   end
   let(:importer) { ::ForemanOmaha::FactParser.new(facts) }
@@ -36,16 +39,47 @@ class OmahaFactsParserTest < ActiveSupport::TestCase
   context '#operatingsystem' do
     let(:os) { importer.operatingsystem }
 
-    test 'should return an OS with correct params' do
-      assert_kind_of Operatingsystem, os
-      assert_equal '1068', os.major
-      assert_equal '9.0', os.minor
-      assert_equal 'CoreOS', os.name
-      assert_equal 'CoreOS 1068.9.0', os.description
-      assert_equal 'stable', os.release_name
-      assert_empty os.ptables
-      assert_empty os.media
-      assert_empty os.os_default_templates
+    context 'without distribution fact' do
+      setup do
+        facts.delete('distribution')
+      end
+
+      test 'should return an OS with correct params' do
+        assert_equal 'CoreOS', os.name
+        assert_equal 'CoreOS 1068.9.0', os.description
+      end
+    end
+
+    context 'CoreOS' do
+      test 'should return an OS with correct params' do
+        assert_kind_of Operatingsystem, os
+        assert_equal '1068', os.major
+        assert_equal '9.0', os.minor
+        assert_equal 'CoreOS', os.name
+        assert_equal 'CoreOS 1068.9.0', os.description
+        assert_equal 'stable', os.release_name
+        assert_empty os.ptables
+        assert_empty os.media
+        assert_empty os.os_default_templates
+      end
+    end
+
+    context 'Flatcar' do
+      setup do
+        facts['distribution'] = 'flatcar'
+      end
+
+      test 'should return an OS with correct params' do
+        assert_kind_of Operatingsystem, os
+        assert_equal '1068', os.major
+        assert_equal '9.0', os.minor
+        assert_equal 'Flatcar', os.name
+        assert_equal 'Flatcar 1068.9.0', os.description
+        assert_equal 'stable', os.release_name
+        assert_empty os.ptables
+        assert_empty os.media
+        assert_empty os.os_default_templates
+      end
     end
 
     context 'with old versions' do

data/test/unit/omaha_report_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_plugin_helper'
 
 class OmahaReportTest < ActiveSupport::TestCase

data/test/unit/renderer_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_plugin_helper'
 
 module ForemanOmaha

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: foreman_omaha
 version: !ruby/object:Gem::Version
-  version: 3.0.0
+  version: 4.0.0
 platform: ruby
 authors:
 - Timo Goebel
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-11-29 00:00:00.000000000 Z
+date: 2020-04-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: jquery-matchheight-rails
@@ -42,16 +42,58 @@ dependencies:
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.59.2
+        version: 0.80.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.59.2
+        version: 0.80.0
+- !ruby/object:Gem::Dependency
+  name: rubocop-minitest
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.7.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.7.0
+- !ruby/object:Gem::Dependency
+  name: rubocop-performance
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.5.2
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.5.2
+- !ruby/object:Gem::Dependency
+  name: rubocop-rails
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 2.4.2
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 2.4.2
 description: This plug-in adds support for the Omaha procotol to The Foreman. It allows
   you to better manage and update your CoreOS servers.
 email:
@@ -71,6 +113,9 @@ files:
 - app/controllers/omaha_groups_controller.rb
 - app/controllers/omaha_hosts_controller.rb
 - app/controllers/omaha_reports_controller.rb
+- app/graphql/types/omaha_group.rb
+- app/graphql/types/omaha_report.rb
+- app/graphql/types/omaha_report_status_enum.rb
 - app/helpers/concerns/foreman_omaha/hosts_helper_extensions.rb
 - app/helpers/foreman_omaha/application_helper.rb
 - app/helpers/foreman_omaha/omaha_groups_helper.rb
@@ -139,6 +184,11 @@ files:
 - test/functional/omaha_groups_controller_test.rb
 - test/functional/omaha_hosts_controller_test.rb
 - test/functional/omaha_reports_controller_test.rb
+- test/graphql/queries/host_query_extensions_test.rb
+- test/graphql/queries/omaha_group_query_test.rb
+- test/graphql/queries/omaha_groups_query_test.rb
+- test/graphql/queries/omaha_report_query_test.rb
+- test/graphql/queries/omaha_reports_query_test.rb
 - test/test_plugin_helper.rb
 - test/unit/charts/oem_distribution_test.rb
 - test/unit/charts/status_distribution_test.rb
@@ -169,7 +219,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.7.3
+rubygems_version: 2.7.6.2
 signing_key: 
 specification_version: 4
 summary: This plug-in adds support for the Omaha procotol to The Foreman.
@@ -183,6 +233,11 @@ test_files:
 - test/unit/host_status/omaha_status_test.rb
 - test/unit/renderer_test.rb
 - test/unit/omaha_report_test.rb
+- test/graphql/queries/omaha_group_query_test.rb
+- test/graphql/queries/omaha_report_query_test.rb
+- test/graphql/queries/omaha_groups_query_test.rb
+- test/graphql/queries/omaha_reports_query_test.rb
+- test/graphql/queries/host_query_extensions_test.rb
 - test/factories/smart_proxy.rb
 - test/factories/feature.rb
 - test/factories/host.rb