foreman_omaha 3.0.0 → 4.0.0

data/db/migrate/20160812083100_add_omaha_fields_to_reports.foreman_omaha.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class AddOmahaFieldsToReports < ActiveRecord::Migration[4.2]
   def change
     add_column :reports, :omaha_version, :string

data/db/migrate/20171101204100_create_omaha_facets.foreman_omaha.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class CreateOmahaFacets < ActiveRecord::Migration[4.2]
   def change
     create_table :omaha_groups do |t|

data/db/seeds.d/200_omaha_groups.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 default_groups = %w[Alpha Beta Stable]
 
 default_groups.each do |group|

data/db/seeds.d/60_omaha_proxy_feature.rb

@@ -1,2 +1,4 @@
+# frozen_string_literal: true
+
 f = Feature.where(:name => 'Omaha').first_or_create
 raise "Unable to create proxy feature: #{format_errors f}" if f.nil? || f.errors.any?

data/lib/foreman_omaha.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'foreman_omaha/engine'
 
 module ForemanOmaha

data/lib/foreman_omaha/engine.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'jquery-matchheight-rails'
 
 module ForemanOmaha
@@ -9,6 +11,7 @@ module ForemanOmaha
     config.autoload_paths += Dir["#{config.root}/app/models/concerns"]
     config.autoload_paths += Dir["#{config.root}/app/services"]
     config.autoload_paths += Dir["#{config.root}/app/lib"]
+    config.autoload_paths += Dir["#{config.root}/app/graphql"]
 
     # Add any db migrations
     initializer 'foreman_omaha.load_app_instance_data' do |app|
@@ -19,7 +22,7 @@ module ForemanOmaha
 
     initializer 'foreman_omaha.register_plugin', :before => :finisher_hook do |_app|
       Foreman::Plugin.register :foreman_omaha do
-        requires_foreman '>= 1.20'
+        requires_foreman '>= 1.24'
 
         apipie_documented_controllers ["#{ForemanOmaha::Engine.root}/app/controllers/api/v2/*.rb"]
 
@@ -49,9 +52,11 @@ module ForemanOmaha
         end
 
         role 'Omaha reports viewer',
-             [:view_omaha_reports]
+             [:view_omaha_reports],
+             'Role granting permissions to view Omaha reports.'
         role 'Omaha reports manager',
-             [:view_omaha_reports, :destroy_omaha_reports, :upload_omaha_reports]
+             [:view_omaha_reports, :destroy_omaha_reports, :upload_omaha_reports],
+             'Role granting permissions to manage Omaha reports.'
 
         # add menu entry
         menu :top_menu, :omaha_reports,
@@ -87,10 +92,21 @@ module ForemanOmaha
                               :onlyif => proc { |host| host.omaha_facet }
         end
 
-        add_controller_action_scope(HostsController, :index) { |base_scope| base_scope.includes(:omaha_facet) }
+        add_controller_action_scope('HostsController', :index) { |base_scope| base_scope.includes(:omaha_facet) }
 
         # add renderer extensions
         allowed_template_helpers :transpile_container_linux_config
+
+        # graphql extensions
+        extend_graphql_type type: Types::Host do
+          has_many :omaha_reports, Types::OmahaReport
+        end
+
+        register_graphql_query_field :omaha_group, '::Types::OmahaGroup', :record_field
+        register_graphql_query_field :omaha_groups, '::Types::OmahaGroup', :collection_field
+
+        register_graphql_query_field :omaha_report, '::Types::OmahaReport', :record_field
+        register_graphql_query_field :omaha_reports, '::Types::OmahaReport', :collection_field
       end
 
       # Extend built in permissions
@@ -106,10 +122,10 @@ module ForemanOmaha
         ::FactImporter.register_fact_importer(:foreman_omaha, ForemanOmaha::FactImporter)
         ::FactParser.register_fact_parser(:foreman_omaha, ForemanOmaha::FactParser)
 
-        Host::Managed.send(:include, ForemanOmaha::HostExtensions)
-        Host::Managed.send(:include, ForemanOmaha::OmahaFacetHostExtensions)
-        HostsHelper.send(:include, ForemanOmaha::HostsHelperExtensions)
-        Foreman::Renderer::Scope::Base.send(:include, ForemanOmaha::Renderer::Scope::Macros::Omaha)
+        ::Host::Managed.include(ForemanOmaha::HostExtensions)
+        ::Host::Managed.include(ForemanOmaha::OmahaFacetHostExtensions)
+        ::HostsHelper.include(ForemanOmaha::HostsHelperExtensions)
+        ::Foreman::Renderer::Scope::Base.include(ForemanOmaha::Renderer::Scope::Macros::Omaha)
       rescue StandardError => e
         Rails.logger.warn "ForemanOmaha: skipping engine hook (#{e})"
       end

data/lib/foreman_omaha/version.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ForemanOmaha
-  VERSION = '3.0.0'.freeze
+  VERSION = '4.0.0'
 end

data/lib/tasks/foreman_omaha_tasks.rake

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Tasks
 namespace :foreman_omaha do
   namespace :example do

data/locale/gemspec.rb

@@ -1,2 +1,4 @@
+# frozen_string_literal: true
+
 # Matches foreman_omaha.gemspec
 _('This plug-in adds support for the Omaha procotol to The Foreman. It allows you to better manage and update your CoreOS servers.')

data/test/factories/feature.rb

@@ -1,7 +1,9 @@
+# frozen_string_literal: true
+
 FactoryBot.modify do
   factory :feature do
     trait :omaha do
-      name 'Omaha'
+      name { 'Omaha' }
     end
   end
 end

data/test/factories/foreman_omaha_factories.rb

@@ -1,18 +1,20 @@
+# frozen_string_literal: true
+
 FactoryBot.define do
   factory :omaha_report, :class => 'ForemanOmaha::OmahaReport' do
     host
     sequence(:reported_at) { |n| n.minutes.ago }
-    status 1
-    omaha_version '1068.9.0'
-    type 'ForemanOmaha::OmahaReport'
+    status { 1 }
+    omaha_version { '1068.9.0' }
+    type { 'ForemanOmaha::OmahaReport' }
   end
 
   factory :omaha_facet, :class => 'ForemanOmaha::OmahaFacet' do
     sequence(:last_report) { |n| n.minutes.ago }
-    version '1068.9.0'
-    oem 'rackspace'
+    version { '1068.9.0' }
+    oem { 'rackspace' }
     sequence(:machineid) { SecureRandom.hex }
-    status 1
+    status { 1 }
     host
     omaha_group
   end

data/test/factories/host.rb

@@ -1,13 +1,15 @@
+# frozen_string_literal: true
+
 FactoryBot.modify do
   factory :host do
     trait :with_omaha_facet do
       association :omaha_facet, :factory => :omaha_facet, :strategy => :build
 
       transient do
-        omaha_status 1
-        omaha_version '1068.9.0'
-        omaha_oem 'rackspace'
-        omaha_group nil
+        omaha_status { 1 }
+        omaha_version { '1068.9.0' }
+        omaha_oem { 'rackspace' }
+        omaha_group { nil }
       end
 
       after(:build) do |host, evaluator|
@@ -17,5 +19,18 @@ FactoryBot.modify do
         host.omaha_facet.omaha_group = evaluator.omaha_group if evaluator.omaha_group.present?
       end
     end
+
+    trait :with_omaha_reports do
+      with_omaha_facet
+      transient do
+        omaha_report_count { 5 }
+      end
+      after(:create) do |host, evaluator|
+        evaluator.omaha_report_count.times do |i|
+          FactoryBot.create(:omaha_report, host: host, reported_at: (evaluator.omaha_report_count - i).minutes.ago)
+        end
+        host.omaha_facet.update_attribute(:last_report, host.omaha_reports.last.reported_at) # rubocop:disable Rails/SkipsModelValidations
+      end
+    end
   end
 end

data/test/factories/smart_proxy.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 FactoryBot.modify do
   factory :smart_proxy do
     trait :omaha do

data/test/functional/api/v2/omaha_groups_controller_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_plugin_helper'
 
 class Api::V2::OmahaGroupsControllerTest < ActionController::TestCase

data/test/functional/api/v2/omaha_reports_controller_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_helper'
 
 class Api::V2::OmahaReportsControllerTest < ActionController::TestCase
@@ -53,7 +55,7 @@ class Api::V2::OmahaReportsControllerTest < ActionController::TestCase
     assert_response :success
     assert_not_nil assigns(:omaha_reports)
     reports = ActiveSupport::JSON.decode(@response.body)
-    assert reports['results'].empty?
+    assert_empty reports['results']
     assert_equal 0, reports['results'].count
   end
 

data/test/functional/omaha_groups_controller_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_plugin_helper'
 
 class OmahaGroupsControllerTest < ActionController::TestCase

data/test/functional/omaha_hosts_controller_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_plugin_helper'
 
 class OmahaHostsControllerTest < ActionController::TestCase

data/test/functional/omaha_reports_controller_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_plugin_helper'
 
 class OmahaReportsControllerTest < ActionController::TestCase

data/test/graphql/queries/host_query_extensions_test.rb

@@ -0,0 +1,41 @@
+# frozen_string_literal: true
+
+require 'test_plugin_helper'
+
+module Queries
+  class HostQueryExtensionsTest < GraphQLQueryTestCase
+    let(:query) do
+      <<-GRAPHQL
+      query (
+        $id: String!
+      ) {
+        host(id: $id) {
+          id
+          omahaReports {
+            totalCount
+            edges {
+              node {
+                id
+              }
+            }
+          }
+        }
+      }
+      GRAPHQL
+    end
+
+    let(:host) do
+      FactoryBot.create(:host, :managed, :with_omaha_reports)
+    end
+    let(:global_id) { Foreman::GlobalId.encode('Host', host.id) }
+    let(:variables) { { id: Foreman::GlobalId.encode('Host', host.id) } }
+    let(:data) { result['data']['host'] }
+
+    test 'fetching host attributes with omaha extensions' do
+      assert_empty result['errors']
+      assert_equal global_id, data['id']
+
+      assert_collection host.omaha_reports, data['omahaReports']
+    end
+  end
+end

data/test/graphql/queries/omaha_group_query_test.rb

@@ -0,0 +1,51 @@
+# frozen_string_literal: true
+
+require 'test_plugin_helper'
+
+module Queries
+  class OmahaGroupQueryTest < GraphQLQueryTestCase
+    let(:query) do
+      <<-GRAPHQL
+      query omahaGroupQuery (
+        $id: String!
+      ) {
+        omahaGroup(id: $id) {
+          id
+          name
+          uuid
+          createdAt
+          updatedAt
+          hosts {
+            totalCount
+            edges {
+              node {
+                id
+              }
+            }
+          }
+        }
+      }
+      GRAPHQL
+    end
+
+    let(:omaha_group) { FactoryBot.create(:omaha_group) }
+    let(:global_id) { Foreman::GlobalId.for(omaha_group) }
+    let(:variables) { { id: global_id } }
+    let(:data) { result['data']['omahaGroup'] }
+
+    test 'fetching omaha group attributes' do
+      FactoryBot.create(:host, :managed, :with_omaha_facet, omaha_group: omaha_group)
+
+      assert_empty result['errors']
+      assert_not_nil data
+
+      assert_equal global_id, data['id']
+      assert_equal omaha_group.created_at.utc.iso8601, data['createdAt']
+      assert_equal omaha_group.updated_at.utc.iso8601, data['updatedAt']
+      assert_equal omaha_group.name, data['name']
+      assert_equal omaha_group.uuid, data['uuid']
+
+      assert_collection omaha_group.hosts, data['hosts'], type_name: 'Host'
+    end
+  end
+end

data/test/graphql/queries/omaha_groups_query_test.rb

@@ -0,0 +1,47 @@
+# frozen_string_literal: true
+
+require 'test_plugin_helper'
+
+module Queries
+  class OmahaGroupsQueryTest < GraphQLQueryTestCase
+    let(:query) do
+      <<-GRAPHQL
+      query omahaGroupsQuery {
+        omahaGroups {
+          totalCount
+          pageInfo {
+            startCursor
+            endCursor
+            hasNextPage
+            hasPreviousPage
+          }
+          edges {
+            cursor
+            node {
+              id
+              name
+              uuid
+            }
+          }
+        }
+      }
+      GRAPHQL
+    end
+
+    let(:data) { result['data']['omahaGroups'] }
+
+    setup do
+      FactoryBot.create_list(:omaha_group, 2)
+    end
+
+    test 'fetching models attributes' do
+      assert_empty result['errors']
+
+      expected_count = ForemanOmaha::OmahaGroup.count
+
+      assert_not_equal 0, expected_count
+      assert_equal expected_count, data['totalCount']
+      assert_equal expected_count, data['edges'].count
+    end
+  end
+end

data/test/graphql/queries/omaha_report_query_test.rb

@@ -0,0 +1,44 @@
+# frozen_string_literal: true
+
+require 'test_plugin_helper'
+
+module Queries
+  class OmahaReportQueryTest < GraphQLQueryTestCase
+    let(:query) do
+      <<-GRAPHQL
+      query omahaReportQuery (
+        $id: String!
+      ) {
+        omahaReport(id: $id) {
+          id
+          status
+          omahaVersion
+          createdAt
+          updatedAt
+          host {
+            id
+          }
+        }
+      }
+      GRAPHQL
+    end
+
+    let(:omaha_report) { FactoryBot.create(:omaha_report) }
+    let(:global_id) { Foreman::GlobalId.for(omaha_report) }
+    let(:variables) { { id: global_id } }
+    let(:data) { result['data']['omahaReport'] }
+
+    test 'fetching omaha report attributes' do
+      assert_empty result['errors']
+      assert_not_nil data
+
+      assert_equal global_id, data['id']
+      assert_equal omaha_report.created_at.utc.iso8601, data['createdAt']
+      assert_equal omaha_report.updated_at.utc.iso8601, data['updatedAt']
+      assert_equal omaha_report.status, data['status']
+      assert_equal omaha_report.omaha_version, data['omahaVersion']
+
+      assert_record omaha_report.host, data['host']
+    end
+  end
+end