foreman_netbox 1.0.2 → 1.1.0

data/test/interactors/foreman_netbox/sync_host/sync_device/update_test.rb

@@ -12,7 +12,8 @@ class UpdateDeviceTest < ActiveSupport::TestCase
       device_type: device_type,
       site: site,
       tenant: tenant,
-      ip_addresses: ip_addresses
+      ip_addresses: ip_addresses,
+      tags: default_tags
     )
   end
 
@@ -44,7 +45,7 @@ class UpdateDeviceTest < ActiveSupport::TestCase
     end
   end
   let(:device_name) { 'name.example.com' }
-  let(:device_tags) { ['tag'] }
+  let(:device_tags) { [] }
   let(:device_data) { device.instance_variable_get(:@data).deep_symbolize_keys }
   let(:device_role) { OpenStruct.new(id: device_data.dig(:device_role, :id)) }
   let(:device_type) { OpenStruct.new(id: device_data.dig(:device_type, :id)) }
@@ -96,9 +97,22 @@ class UpdateDeviceTest < ActiveSupport::TestCase
   end
 
   context 'if the host has not been updated since the last synchronization' do
-    let(:device_tags) { ForemanNetbox::NetboxParameters::DEFAULT_TAGS }
+    let(:device_tags) do
+      default_tags.map { |t| { 'id' => t.id, 'name' => t.name, 'slug' => t.slug } }
+    end
 
     it 'does not update device' do
+      device_tags.each do |t|
+        stub_request(:get, "#{Setting[:netbox_url]}/api/extras/tags/#{t['id']}.json")
+          .to_return(
+            status: 200, headers: { 'Content-Type': 'application/json' },
+            body: {
+              id: t['id'],
+              name: t['name'],
+              slug: t['slug']
+            }.to_json
+          )
+      end
       stub_patch = stub_request(:patch, "#{Setting[:netbox_url]}/api/dcim/devices/#{device.id}.json")
 
       assert_equal device, subject.device
@@ -149,7 +163,7 @@ class UpdateDeviceTest < ActiveSupport::TestCase
           site: site.id,
           tenant: tenant.id,
           serial: serialnumber,
-          tags: device_tags | ForemanNetbox::NetboxParameters::DEFAULT_TAGS
+          tags: default_tags.map(&:id)
         }.to_json
       ).to_return(
         status: 200, headers: { 'Content-Type': 'application/json' },
@@ -173,7 +187,7 @@ class UpdateDeviceTest < ActiveSupport::TestCase
             primary_ip6: primary_ip6.id,
             site: site.id,
             tenant: tenant.id,
-            tags: device_tags | ForemanNetbox::NetboxParameters::DEFAULT_TAGS
+            tags: default_tags.map(&:id)
           }.to_json
         ).to_return(
           status: 200, headers: { 'Content-Type': 'application/json' },

data/test/interactors/foreman_netbox/sync_host/sync_tenant/create_test.rb

@@ -5,7 +5,7 @@ require 'test_plugin_helper'
 class CreateTenantTest < ActiveSupport::TestCase
   subject do
     ForemanNetbox::SyncHost::SyncTenant::Create.call(
-      host: host, tenant: tenant, netbox_params: host.netbox_facet.netbox_params
+      host: host, tenant: tenant, netbox_params: host.netbox_facet.netbox_params, tags: default_tags
     )
   end
 
@@ -28,7 +28,7 @@ class CreateTenantTest < ActiveSupport::TestCase
         body: {
           name: host.owner.name,
           slug: host.owner.name.parameterize,
-          tags: ForemanNetbox::NetboxParameters::DEFAULT_TAGS
+          tags: default_tags.map(&:id)
         }.to_json
       ).to_return(
         status: 201, headers: { 'Content-Type': 'application/json' },

data/test/interactors/foreman_netbox/sync_host/sync_tenant/update_test.rb

@@ -5,7 +5,7 @@ require 'test_plugin_helper'
 class UpdateTenantTest < ActiveSupport::TestCase
   subject do
     ForemanNetbox::SyncHost::SyncTenant::Update.call(
-      host: host, tenant: tenant, netbox_params: host.netbox_facet.netbox_params
+      host: host, tenant: tenant, netbox_params: host.netbox_facet.netbox_params, tags: default_tags
     )
   end
 
@@ -34,7 +34,7 @@ class UpdateTenantTest < ActiveSupport::TestCase
     it 'updates tenant' do
       stub_patch = stub_request(:patch, "#{Setting[:netbox_url]}/api/tenancy/tenants/1.json").with(
         body: {
-          tags: ForemanNetbox::NetboxParameters::DEFAULT_TAGS
+          tags: default_tags.map(&:id)
         }.to_json
       ).to_return(
         status: 200, headers: { 'Content-Type': 'application/json' },
@@ -47,7 +47,9 @@ class UpdateTenantTest < ActiveSupport::TestCase
   end
 
   context 'when unchanged' do
-    let(:tenant_tags) { ForemanNetbox::NetboxParameters::DEFAULT_TAGS }
+    let(:tenant_tags) do
+      default_tags.map { |t| { 'id' => t.id, 'name' => t.name, 'slug' => t.slug } }
+    end
 
     it 'does not update tenant' do
       stub_patch = stub_request(:patch, "#{Setting[:netbox_url]}/api/tenancy/tenants/1.json")

data/test/interactors/foreman_netbox/sync_host/sync_virtual_machine/create_test.rb

@@ -9,7 +9,8 @@ class CreateVirtualMachineTest < ActiveSupport::TestCase
       netbox_params: host.netbox_facet.netbox_params,
       virtual_machine: virtual_machine,
       cluster: cluster,
-      tenant: tenant
+      tenant: tenant,
+      tags: default_tags
     )
   end
 
@@ -50,9 +51,9 @@ class CreateVirtualMachineTest < ActiveSupport::TestCase
           memory: netbox_virtual_machine_params[:memory],
           disk: netbox_virtual_machine_params[:disk],
           name: netbox_virtual_machine_params[:name],
-          tags: netbox_virtual_machine_params[:tags],
           cluster: cluster.id,
-          tenant: tenant.id
+          tenant: tenant.id,
+          tags: default_tags.map(&:id)
         }.to_json
       ).to_return(
         status: 201, headers: { 'Content-Type': 'application/json' },

data/test/interactors/foreman_netbox/sync_host/sync_virtual_machine/sync_cluster/create_test.rb

@@ -5,7 +5,11 @@ require 'test_plugin_helper'
 class CreateClusterTest < ActiveSupport::TestCase
   subject do
     ForemanNetbox::SyncHost::SyncVirtualMachine::SyncCluster::Create.call(
-      host: host, cluster_type: cluster_type, cluster: cluster, netbox_params: host.netbox_facet.netbox_params
+      host: host,
+      cluster_type: cluster_type,
+      cluster: cluster,
+      netbox_params: host.netbox_facet.netbox_params,
+      tags: default_tags
     )
   end
 
@@ -31,8 +35,8 @@ class CreateClusterTest < ActiveSupport::TestCase
       stub_post = stub_request(:post, "#{Setting[:netbox_url]}/api/virtualization/clusters/").with(
         body: {
           name: host.netbox_facet.netbox_params.dig(:cluster, :name),
-          tags: host.netbox_facet.netbox_params.dig(:cluster, :tags),
-          type: cluster_type.id
+          type: cluster_type.id,
+          tags: default_tags.map(&:id)
         }.to_json
       ).to_return(
         status: 201, headers: { 'Content-Type': 'application/json' },

data/test/interactors/foreman_netbox/sync_host/sync_virtual_machine/sync_cluster/update_test.rb

@@ -5,7 +5,7 @@ require 'test_plugin_helper'
 class UpdateClusterTest < ActiveSupport::TestCase
   subject do
     ForemanNetbox::SyncHost::SyncVirtualMachine::SyncCluster::Update.call(
-      host: host, cluster: cluster, netbox_params: host.netbox_facet.netbox_params
+      host: host, cluster: cluster, netbox_params: host.netbox_facet.netbox_params, tags: default_tags
     )
   end
 
@@ -29,7 +29,7 @@ class UpdateClusterTest < ActiveSupport::TestCase
     it 'updates cluster' do
       stub_patch = stub_request(:patch, "#{Setting[:netbox_url]}/api/virtualization/clusters/1.json").with(
         body: {
-          tags: host.netbox_facet.netbox_params.dig(:cluster, :tags)
+          tags: default_tags.map(&:id)
         }.to_json
       ).to_return(
         status: 200, headers: { 'Content-Type': 'application/json' },
@@ -42,7 +42,9 @@ class UpdateClusterTest < ActiveSupport::TestCase
   end
 
   context 'when unchanged' do
-    let(:cluster_tags) { host.netbox_facet.netbox_params.dig(:cluster, :tags) }
+    let(:cluster_tags) do
+      default_tags.map { |t| { 'id' => t.id, 'name' => t.name, 'slug' => t.slug } }
+    end
 
     it 'does not update cluster' do
       stub_patch = stub_request(:patch, "#{Setting[:netbox_url]}/api/virtualization/clusters/1.json")

data/test/interactors/foreman_netbox/sync_host/sync_virtual_machine/sync_interfaces/create_test.rb

@@ -8,7 +8,8 @@ class CreateVirtualMachineInterfacesTest < ActiveSupport::TestCase
       host: host,
       netbox_params: host.netbox_facet.netbox_params,
       virtual_machine: virtual_machine,
-      interfaces: interfaces
+      interfaces: interfaces,
+      tags: default_tags
     )
   end
 
@@ -35,9 +36,9 @@ class CreateVirtualMachineInterfacesTest < ActiveSupport::TestCase
     stub_post = stub_request(:post, "#{Setting[:netbox_url]}/api/virtualization/interfaces/").with(
       body: {
         name: host.interfaces.first.netbox_name,
-        mac_address: host.interfaces.first.mac,
-        tags: ForemanNetbox::NetboxParameters::DEFAULT_TAGS,
-        virtual_machine: virtual_machine.id
+        mac_address: host.interfaces.first.mac.upcase,
+        virtual_machine: virtual_machine.id,
+        tags: default_tags.map(&:id)
       }.to_json
     ).to_return(
       status: 201, headers: { 'Content-Type': 'application/json' },

data/test/interactors/foreman_netbox/sync_host/sync_virtual_machine/sync_interfaces/sync_ip_addresses/create_test.rb

@@ -5,7 +5,7 @@ require 'test_plugin_helper'
 class CreateVirtualMachineIpAddressesTest < ActiveSupport::TestCase
   subject do
     ForemanNetbox::SyncHost::SyncVirtualMachine::SyncInterfaces::SyncIpAddresses::Create.call(
-      host: host, interfaces: interfaces, netbox_params: host.netbox_facet.netbox_params
+      host: host, interfaces: interfaces, netbox_params: host.netbox_facet.netbox_params, tags: default_tags
     )
   end
 
@@ -31,7 +31,7 @@ class CreateVirtualMachineIpAddressesTest < ActiveSupport::TestCase
   setup do
     setup_default_netbox_settings
     stub_request(:get, "#{Setting[:netbox_url]}/api/ipam/ip-addresses.json").with(
-      query: { limit: 50, interface_id: interfaces.first.id, address: host.interfaces.first.netbox_ip }
+      query: { limit: 50, vminterface_id: interfaces.first.id, address: host.interfaces.first.netbox_ip }
     ).to_return(
       status: 200, headers: { 'Content-Type': 'application/json' },
       body: {
@@ -40,7 +40,7 @@ class CreateVirtualMachineIpAddressesTest < ActiveSupport::TestCase
       }.to_json
     )
     stub_request(:get, "#{Setting[:netbox_url]}/api/ipam/ip-addresses.json").with(
-      query: { limit: 50, interface_id: interfaces.first.id, address: host.interfaces.first.netbox_ip6 }
+      query: { limit: 50, vminterface_id: interfaces.first.id, address: host.interfaces.first.netbox_ip6 }
     ).to_return(
       status: 200, headers: { 'Content-Type': 'application/json' },
       body: {
@@ -54,8 +54,9 @@ class CreateVirtualMachineIpAddressesTest < ActiveSupport::TestCase
     stub_post_ip_address_v4 = stub_request(:post, "#{Setting[:netbox_url]}/api/ipam/ip-addresses/").with(
       body: {
         address: host.interfaces.first.netbox_ip,
-        tags: ForemanNetbox::NetboxParameters::DEFAULT_TAGS,
-        interface: interfaces.first.id
+        assigned_object_type: 'virtualization.vminterface',
+        assigned_object_id: interfaces.first.id,
+        tags: default_tags.map(&:id)
       }.to_json
     ).to_return(
       status: 201, headers: { 'Content-Type': 'application/json' },
@@ -65,8 +66,9 @@ class CreateVirtualMachineIpAddressesTest < ActiveSupport::TestCase
     stub_post_ip_address_v6 = stub_request(:post, "#{Setting[:netbox_url]}/api/ipam/ip-addresses/").with(
       body: {
         address: host.interfaces.first.netbox_ip6,
-        tags: ForemanNetbox::NetboxParameters::DEFAULT_TAGS,
-        interface: interfaces.first.id
+        assigned_object_type: 'virtualization.vminterface',
+        assigned_object_id: interfaces.first.id,
+        tags: default_tags.map(&:id)
       }.to_json
     ).to_return(
       status: 201, headers: { 'Content-Type': 'application/json' },

data/test/interactors/foreman_netbox/sync_host/sync_virtual_machine/sync_interfaces/sync_ip_addresses/delete_test.rb

@@ -51,8 +51,8 @@ class DeleteVirtualMachineIpAddressesTest < ActiveSupport::TestCase
       body: {
         count: 2,
         results: [
-          { id: ip_addresses_v4_id, address: ip_addresses_v4, interface: { id: interface_id } },
-          { id: ip_addresses_v6_id, address: ip_addresses_v6, interface: { id: interface_id } }
+          { id: ip_addresses_v4_id, address: ip_addresses_v4, assigned_object_type: 'virtualization.vminterface', assigned_object_id: interface_id },
+          { id: ip_addresses_v6_id, address: ip_addresses_v6, assigned_object_type: 'virtualization.vminterface', assigned_object_id: interface_id }
         ]
       }.to_json
     )

data/test/interactors/foreman_netbox/sync_host/sync_virtual_machine/sync_interfaces/sync_ip_addresses/update_test.rb

@@ -6,15 +6,24 @@ class UpdateVirtualMachineIpAddressesTest < ActiveSupport::TestCase
   subject do
     ForemanNetbox::SyncHost::SyncVirtualMachine::SyncInterfaces::SyncIpAddresses::Update.call(
       ip_addresses: ip_addresses,
-      netbox_params: host.netbox_facet.netbox_params
+      netbox_params: host.netbox_facet.netbox_params,
+      tags: default_tags
     )
   end
 
   let(:ip_addresses) { ForemanNetbox::API.client.ipam.ip_addresses.filter(virtual_machine_id: 1) }
   let(:ip_addresses_data) do
     [
-      { id: 1, address: host.netbox_facet.netbox_params[:ip_addresses].first[:address], tags: ForemanNetbox::NetboxParameters::DEFAULT_TAGS },
-      { id: 2, address: host.netbox_facet.netbox_params[:ip_addresses].second[:address], tags: [] }
+      {
+        id: 1,
+        address: host.netbox_facet.netbox_params[:ip_addresses].first[:address],
+        tags: default_tags.map { |t| { id: t.id, name: t.name, slug: t.slug } }
+      },
+      {
+        id: 2,
+        address: host.netbox_facet.netbox_params[:ip_addresses].second[:address],
+        tags: []
+      }
     ]
   end
   let(:host) do
@@ -50,7 +59,7 @@ class UpdateVirtualMachineIpAddressesTest < ActiveSupport::TestCase
     stub_unexpected_patch = stub_request(:patch, "#{Setting[:netbox_url]}/api/ipam/ip-addresses/#{ip_addresses_data.first[:id]}.json")
     stub_expected_patch = stub_request(:patch, "#{Setting[:netbox_url]}/api/ipam/ip-addresses/#{ip_addresses_data.second[:id]}.json").with(
       body: {
-        tags: ForemanNetbox::NetboxParameters::DEFAULT_TAGS
+        tags: default_tags.map(&:id)
       }.to_json
     ).to_return(
       status: 200, headers: { 'Content-Type': 'application/json' },

data/test/interactors/foreman_netbox/sync_host/sync_virtual_machine/sync_interfaces/update_test.rb

@@ -7,7 +7,8 @@ class UpdateVirtualMachineInterfacesTest < ActiveSupport::TestCase
     ForemanNetbox::SyncHost::SyncVirtualMachine::SyncInterfaces::Update.call(
       interfaces: interfaces,
       host: host,
-      netbox_params: host.netbox_facet.netbox_params
+      netbox_params: host.netbox_facet.netbox_params,
+      tags: default_tags
     )
   end
 
@@ -48,8 +49,8 @@ class UpdateVirtualMachineInterfacesTest < ActiveSupport::TestCase
       )
       stub_patch = stub_request(:patch, "#{Setting[:netbox_url]}/api/virtualization/interfaces/1.json").with(
         body: {
-          mac_address: host.interfaces.first.mac,
-          tags: ForemanNetbox::NetboxParameters::DEFAULT_TAGS
+          mac_address: host.interfaces.first.mac.upcase,
+          tags: default_tags.map(&:id)
         }.to_json
       ).to_return(
         status: 200, headers: { 'Content-Type': 'application/json' },
@@ -75,14 +76,18 @@ class UpdateVirtualMachineInterfacesTest < ActiveSupport::TestCase
               id: 1,
               name: host.interfaces.first.netbox_name,
               mac_address: old_mac,
-              tags: ForemanNetbox::NetboxParameters::DEFAULT_TAGS
+              tags: default_tags.map do |tag|
+                { id: tag.id }
+              end
             }
           ]
         }.to_json
       )
+      stub_patch = stub_request(:patch, "#{Setting[:netbox_url]}/api/virtualization/interfaces/1.json")
 
       subject
       assert_requested(get_stub)
+      assert_not_requested(stub_patch)
     end
   end
 end

data/test/interactors/foreman_netbox/sync_host/sync_virtual_machine/update_test.rb

@@ -10,7 +10,8 @@ class UpdateVirtualMachineTest < ActiveSupport::TestCase
       netbox_params: host.netbox_facet.netbox_params,
       cluster: cluster,
       tenant: tenant,
-      ip_addresses: ip_addresses
+      ip_addresses: ip_addresses,
+      tags: default_tags
     )
   end
 
@@ -43,7 +44,7 @@ class UpdateVirtualMachineTest < ActiveSupport::TestCase
   end
 
   let(:virtual_machine_name) { 'name.example.com' }
-  let(:virtual_machine_tags) { ['tag'] }
+  let(:virtual_machine_tags) { [{ 'id' => 987_654_321, 'name' => 'tag', 'slug' => 'tag' }] }
   let(:virtual_machine_data) { virtual_machine.instance_variable_get(:@data).deep_symbolize_keys }
   let(:cluster) { OpenStruct.new(id: virtual_machine_data.dig(:cluster, :id)) }
   let(:tenant) { OpenStruct.new(id: virtual_machine_data.dig(:tenant, :id)) }
@@ -101,7 +102,9 @@ class UpdateVirtualMachineTest < ActiveSupport::TestCase
   end
 
   context 'if the host has not been updated since the last synchronization' do
-    let(:virtual_machine_tags) { ForemanNetbox::NetboxParameters::DEFAULT_TAGS }
+    let(:virtual_machine_tags) do
+      default_tags.map { |t| { 'id' => t.id, 'name' => t.name, 'slug' => t.slug } }
+    end
 
     it 'does not update virtual_machine' do
       assert_equal virtual_machine, subject.virtual_machine
@@ -157,7 +160,7 @@ class UpdateVirtualMachineTest < ActiveSupport::TestCase
           primary_ip6: primary_ip6.id,
           tenant: tenant.id,
           vcpus: host.compute_object.cpus,
-          tags: virtual_machine_tags | ForemanNetbox::NetboxParameters::DEFAULT_TAGS
+          tags: virtual_machine_tags.map { |t| t['id'] } | default_tags.map(&:id)
         }.to_json
       ).to_return(
         status: 200, headers: { 'Content-Type': 'application/json' },

data/test/models/foreman_netbox/usergroup_test.rb

@@ -7,13 +7,13 @@ module ForemanNetbox
     describe '#netbox_tenant_name' do
       let(:usergroup) { FactoryBot.build_stubbed(:usergroup, id: 1, name: usergroup_name) }
 
-      context 'when name is longer than 30' do
-        let(:usergroup_name) { SecureRandom.hex(16) }
+      context 'when name is longer than 100' do
+        let(:usergroup_name) { SecureRandom.hex(64) }
 
-        it { assert_equal "#{usergroup.name.truncate(28, omission: '')}-#{usergroup.id}", usergroup.netbox_tenant_name }
+        it { assert_equal "#{usergroup.name.truncate(98, omission: '')}-#{usergroup.id}", usergroup.netbox_tenant_name }
       end
 
-      context 'when name is shorter than 30' do
+      context 'when name is shorter than 100' do
         let(:usergroup_name) { 'Name' }
 
         it { assert_equal usergroup.name, usergroup.netbox_tenant_name }

data/test/services/foreman_netbox/netbox_attributes_test.rb

@@ -16,8 +16,7 @@ module ForemanNetbox
       let(:expected) do
         {
           name: 'Tenant Name',
-          slug: 'tenant-name',
-          tags: ForemanNetbox::NetboxParameters::DEFAULT_TAGS
+          slug: 'tenant-name'
         }
       end
 
@@ -34,8 +33,7 @@ module ForemanNetbox
       let(:expected) do
         {
           name: 'device_name',
-          serial: 'abc123',
-          tags: ForemanNetbox::NetboxParameters::DEFAULT_TAGS
+          serial: 'abc123'
         }
       end
 
@@ -64,8 +62,7 @@ module ForemanNetbox
       let(:expected) do
         {
           model: 'Product Name',
-          slug: 'product-name',
-          tags: ForemanNetbox::NetboxParameters::DEFAULT_TAGS
+          slug: 'product-name'
         }
       end
 
@@ -77,8 +74,7 @@ module ForemanNetbox
         let(:expected) do
           {
             model: 'Unknown',
-            slug: 'unknown',
-            tags: ForemanNetbox::NetboxParameters::DEFAULT_TAGS
+            slug: 'unknown'
           }
         end
 
@@ -124,8 +120,7 @@ module ForemanNetbox
       let(:expected) do
         {
           name: 'Site Name',
-          slug: 'site-name',
-          tags: ForemanNetbox::NetboxParameters::DEFAULT_TAGS
+          slug: 'site-name'
         }
       end
 
@@ -153,8 +148,7 @@ module ForemanNetbox
           mac_address: 'FE:13:C6:44:29:24',
           type: {
             value: 'virtual'
-          },
-          tags: ForemanNetbox::NetboxParameters::DEFAULT_TAGS
+          }
         ]
       end
 
@@ -195,15 +189,13 @@ module ForemanNetbox
             address: '10.0.0.1/24',
             interface: {
               name: 'eth1'
-            },
-            tags: ForemanNetbox::NetboxParameters::DEFAULT_TAGS
+            }
           },
           {
             address: '1500:0:2d0:201::1/64',
             interface: {
               name: 'eth2'
-            },
-            tags: ForemanNetbox::NetboxParameters::DEFAULT_TAGS
+            }
           }
         ]
       end
@@ -233,8 +225,7 @@ module ForemanNetbox
           name: 'virtual_machine_name',
           vcpus: 2,
           memory: 128,
-          disk: 20,
-          tags: ForemanNetbox::NetboxParameters::DEFAULT_TAGS
+          disk: 20
         }
       end
 
@@ -252,7 +243,7 @@ module ForemanNetbox
       end
 
       let(:expected) do
-        { name: 'Cluster Name', tags: ForemanNetbox::NetboxParameters::DEFAULT_TAGS }
+        { name: 'Cluster Name' }
       end
 
       it { assert_equal expected, host.netbox_facet.netbox_params.fetch(:cluster) }

data/test/services/foreman_netbox/netbox_parameters_comparator_test.rb

@@ -10,8 +10,7 @@ module ForemanNetbox
       let(:my_hash) do
         {
           device: {
-            name: 'My device',
-            tags: ['foreman']
+            name: 'My device'
           }
         }
       end
@@ -26,15 +25,13 @@ module ForemanNetbox
       let(:old_hash) do
         {
           device: {
-            name: 'Old name',
-            tags: ['custom']
+            name: 'Old name'
           },
           device_role: {
             name: 'SERVER'
           },
           manufacturer: {
-            name: 'Manufacturer',
-            tags: %w[Synced foreman]
+            name: 'Manufacturer'
           },
           interfaces: [
             {
@@ -58,7 +55,6 @@ module ForemanNetbox
             {
               name: 'eth4',
               mac_address: '00:50:56:84:6D:84',
-              tags: ['foreman'],
               type: {
                 value: 'virtual'
               }
@@ -70,15 +66,13 @@ module ForemanNetbox
       let(:new_hash) do
         {
           device: {
-            name: 'New name',
-            tags: ['foreman']
+            name: 'New name'
           },
           device_type: {
             model: 'Model name'
           },
           manufacturer: {
-            name: 'Manufacturer',
-            tags: %w[foreman]
+            name: 'Manufacturer'
           },
           interfaces: [
             {
@@ -104,8 +98,7 @@ module ForemanNetbox
               mac_address: '00:50:56:84:6D:84',
               type: {
                 value: 'virtual'
-              },
-              tags: ['foreman']
+              }
             }
           ]
         }
@@ -118,9 +111,6 @@ module ForemanNetbox
           device: {
             name: {
               old: old_hash.dig(:device, :name), new: new_hash.dig(:device, :name)
-            },
-            tags: {
-              added: ['foreman'], removed: []
             }
           },
           interfaces: {

data/test/test_plugin_helper.rb

@@ -10,9 +10,15 @@ FactoryBot.definition_file_paths << File.join(File.dirname(__FILE__), 'factories
 FactoryBot.reload
 
 def setup_default_netbox_settings(netbox_url: 'https://netbox.example.com', netbox_api_token: 'api_key')
-  FactoryBot.create(:setting, name: 'netbox_url', value: netbox_url, category: 'Setting::Netbox')
-  FactoryBot.create(:setting, name: 'netbox_api_token', value: netbox_api_token, category: 'Setting::Netbox')
-  FactoryBot.create(:setting, name: 'netbox_orchestration_enabled', value: true, category: 'Setting::Netbox')
+  if Gem::Version.new(SETTINGS[:version].notag) < Gem::Version.new('2.6')
+    FactoryBot.create(:setting, name: 'netbox_url', value: netbox_url, category: 'Setting::Netbox')
+    FactoryBot.create(:setting, name: 'netbox_api_token', value: netbox_api_token, category: 'Setting::Netbox')
+    FactoryBot.create(:setting, name: 'netbox_orchestration_enabled', value: true, category: 'Setting::Netbox')
+  else
+    Setting[:netbox_url] = netbox_url
+    Setting[:netbox_api_token] = netbox_api_token
+    Setting[:netbox_orchestration_enabled] = true
+  end
 end
 
 def setup_netbox_integration_test
@@ -23,3 +29,9 @@ def setup_netbox_integration_test
     netbox_api_token: ENV['FOREMAN_NETBOX_TOKEN']
   )
 end
+
+def default_tags
+  ForemanNetbox::SyncHost::SyncTags::Organizer::DEFAULT_TAGS.map.with_index(1) do |tag, id|
+    ForemanNetbox::API.client::Extras::Tag.new(id: id, name: tag[:name], slug: tag[:slug])
+  end
+end