foreman_netbox 1.0.2 → 1.1.0

data/app/models/concerns/foreman_netbox/user_usergroup_common_extensions.rb

@@ -2,7 +2,7 @@
 
 module ForemanNetbox
   module UserUsergroupCommonExtensions
-    NETBOX_TENANT_MAX_LENGTH = 30
+    NETBOX_TENANT_MAX_LENGTH = 100
 
     def netbox_tenant_name
       return name unless name.length > NETBOX_TENANT_MAX_LENGTH

data/app/models/orchestration/netbox.rb

@@ -30,6 +30,9 @@ module Orchestration
     def queue_netbox_destroy
       return unless errors.empty? && managed?
 
+      ::Foreman::Logging.logger('foreman_netbox/import')
+                        .info("Queued delete of #{name} from Netbox.")
+
       queue.create(name: _('Delete host %s from Netbox') % self, priority: 60,
                    action: [self, :del_netbox])
     end

data/app/services/foreman_netbox/cached_netbox_parameters.rb

@@ -28,7 +28,7 @@ module ForemanNetbox
       return unless data.keys.include?(:interfaces)
 
       result[:interfaces] = data.fetch(:interfaces, {}).fetch(:results, []).map do |interface|
-        interface.slice(:name, :mac_address, :tags)
+        interface.slice(:name, :mac_address)
                  .merge(type: interface.fetch(:type, {}).slice(:value))
                  .compact
       end
@@ -38,7 +38,7 @@ module ForemanNetbox
       return unless data.keys.include?(:ip_addresses)
 
       result[:ip_addresses] = data.fetch(:ip_addresses, {}).fetch(:results, []).map do |ip_address|
-        ip_address.slice(:address, :tags)
+        ip_address.slice(:address)
                   .merge(interface: ip_address.fetch(:interface, {}).slice(:name))
       end
     end
@@ -46,19 +46,19 @@ module ForemanNetbox
     def read_virtual_machine
       return unless data.keys.include?(:virtual_machine)
 
-      result[:virtual_machine] = data.fetch(:virtual_machine, {}).slice(:name, :vcpus, :memory, :disk, :tags)
+      result[:virtual_machine] = data.fetch(:virtual_machine, {}).slice(:name, :vcpus, :memory, :disk)
     end
 
     def read_tenant
       return unless data.keys.include?(:tenant)
 
-      result[:tenant] = data.fetch(:tenant, {}).slice(:name, :slug, :tags)
+      result[:tenant] = data.fetch(:tenant, {}).slice(:name, :slug)
     end
 
     def read_cluster
       return unless data.keys.include?(:cluster)
 
-      result[:cluster] = data.fetch(:cluster, {}).slice(:name, :tags)
+      result[:cluster] = data.fetch(:cluster, {}).slice(:name)
     end
 
     def read_cluster_type
@@ -71,7 +71,7 @@ module ForemanNetbox
       return unless data.keys.include?(:device)
 
       result[:device] = data.fetch(:device, {})
-                            .slice(:name, :serial, :tags)
+                            .slice(:name, :serial)
                             .compact
                             .reject { |k, v| k == :serial && v.blank? }
     end
@@ -85,7 +85,7 @@ module ForemanNetbox
     def read_device_type
       return unless data.keys.include?(:device_type)
 
-      result[:device_type] = data.fetch(:device_type, {}).slice(:model, :slug, :tags)
+      result[:device_type] = data.fetch(:device_type, {}).slice(:model, :slug)
     end
 
     def read_manufacturer
@@ -97,7 +97,7 @@ module ForemanNetbox
     def read_site
       return unless data.keys.include?(:site)
 
-      result[:site] = data.fetch(:site, {}).slice(:name, :slug, :tags)
+      result[:site] = data.fetch(:site, {}).slice(:name, :slug)
     end
   end
 end

data/app/services/foreman_netbox/netbox_parameters.rb

@@ -4,7 +4,6 @@ module ForemanNetbox
   # rubocop:disable Metrics/ClassLength
   class NetboxParameters
     UNKNOWN = 'Unknown'
-    DEFAULT_TAGS = ['foreman'].freeze
     DEFAULT_INTERFACE_TYPE = 'virtual'
     CLUSTER_TYPES = {
       :'Foreman::Model::Vmware' => {
@@ -56,8 +55,7 @@ module ForemanNetbox
       {
         tenant: {
           name: host.owner&.netbox_tenant_name,
-          slug: host.owner&.netbox_tenant_slug,
-          tags: DEFAULT_TAGS
+          slug: host.owner&.netbox_tenant_slug
         }
       }
     end
@@ -66,8 +64,7 @@ module ForemanNetbox
       {
         device: {
           name: host.name,
-          serial: host.facts.deep_symbolize_keys[:serialnumber],
-          tags: DEFAULT_TAGS
+          serial: host.facts.deep_symbolize_keys[:serialnumber]
         }
       }
     end
@@ -84,8 +81,7 @@ module ForemanNetbox
       {
         device_type: {
           model: model,
-          slug: model.parameterize,
-          tags: DEFAULT_TAGS
+          slug: model.parameterize
         }
       }
     end
@@ -105,8 +101,7 @@ module ForemanNetbox
       {
         site: {
           name: host.location&.netbox_site_name,
-          slug: host.location&.netbox_site_slug,
-          tags: DEFAULT_TAGS
+          slug: host.location&.netbox_site_slug
         }
       }
     end
@@ -122,8 +117,7 @@ module ForemanNetbox
             mac_address: mac_address,
             type: {
               value: DEFAULT_INTERFACE_TYPE
-            },
-            tags: DEFAULT_TAGS
+            }
           }
         end
       }
@@ -144,8 +138,7 @@ module ForemanNetbox
               address: ip_address,
               interface: {
                 name: identifier || (mac_address && "Interface #{mac_address}")
-              },
-              tags: DEFAULT_TAGS
+              }
             }
           end
         end.flatten
@@ -158,8 +151,7 @@ module ForemanNetbox
         virtual_machine: netbox_compute_attributes.slice(
           :vcpus, :memory, :disk
         ).merge(
-          name: host.name,
-          tags: DEFAULT_TAGS
+          name: host.name
         )
       }
     end
@@ -167,8 +159,7 @@ module ForemanNetbox
     def cluster
       {
         cluster: {
-          name: netbox_compute_attributes[:cluster],
-          tags: DEFAULT_TAGS
+          name: netbox_compute_attributes[:cluster]
         }.compact
       }
     end

data/app/services/foreman_netbox/netbox_parameters_comparator.rb

@@ -48,7 +48,7 @@ module ForemanNetbox
 
           memo[key] = diff
         elsif old_value.is_a?(Array)
-          next unless !new_hash[key] && key != :tags
+          next if new_hash[key]
 
           memo[key] = { added: [], removed: old_value }
         else
@@ -77,7 +77,7 @@ module ForemanNetbox
         elsif new_value.is_a?(Array)
           old_value = old_hash.fetch(key, [])
           added = new_value.reject { |item| old_value.find { |x| x == item } }
-          removed = key == :tags ? [] : old_value.reject { |item| new_value.find { |x| x == item } }
+          removed = old_value.reject { |item| new_value.find { |x| x == item } }
 
           next unless added.any? || removed.any?
 

data/lib/foreman_netbox/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ForemanNetbox
-  VERSION = '1.0.2'
+  VERSION = '1.1.0'
 end

data/test/integration/foreman_netbox/sync_k8s_physical_host_test.rb

@@ -62,20 +62,24 @@ class SyncK8sPhysicalHostTest < ActiveSupport::TestCase
       assert nx_interface.present?
 
       h_interface.netbox_ips.each do |h_ip|
-        assert subject.ip_addresses.find { |nx_ip| nx_ip.interface.id == nx_interface.id && nx_ip.address == IPAddress.parse(h_ip) }.present?
+        assert subject.ip_addresses.find do |nx_ip|
+          nx_ip.interface.assigned_object_type == 'dcim.interface' &&
+            nx_ip.interface.assigned_object_id == nx_interface.id &&
+            nx_ip.address == IPAddress.parse(h_ip)
+        end.present?
       end
     end
 
-    expected_tags = ForemanNetbox::NetboxParameters::DEFAULT_TAGS
-    assert_equal expected_tags, subject.device.tags
-    assert_equal expected_tags, subject.device_type.tags
-    assert_equal expected_tags, subject.site.tags
-    assert_equal expected_tags, subject.tenant.tags
+    expected_tag_ids = subject.tags.pluck('id')
+    assert (expected_tag_ids - subject.device.tags.pluck('id')).empty?
+    assert (expected_tag_ids - subject.device_type.tags.pluck('id')).empty?
+    assert (expected_tag_ids - subject.site.tags.pluck('id')).empty?
+    assert (expected_tag_ids - subject.tenant.tags.pluck('id')).empty?
     subject.interfaces.reload.each do |interface|
-      assert_equal expected_tags, interface.tags
+      assert (expected_tag_ids - interface.tags.pluck('id')).empty?
     end
     subject.ip_addresses.reload.each do |interface|
-      assert_equal expected_tags, interface.tags
+      assert (expected_tag_ids - interface.tags.pluck('id')).empty?
     end
   end
 end

data/test/integration/foreman_netbox/sync_rhel_physical_host_test.rb

@@ -62,20 +62,24 @@ class SyncRhelPhysicalHostTest < ActiveSupport::TestCase
       assert nx_interface.present?
 
       h_interface.netbox_ips.each do |h_ip|
-        assert subject.ip_addresses.find { |nx_ip| nx_ip.interface.id == nx_interface.id && nx_ip.address == IPAddress.parse(h_ip) }.present?
+        assert subject.ip_addresses.find do |nx_ip|
+          nx_ip.interface.assigned_object_type == 'dcim.interface' &&
+            nx_ip.interface.assigned_object_id == nx_interface.id &&
+            nx_ip.address == IPAddress.parse(h_ip)
+        end.present?
       end
     end
 
-    expected_tags = ForemanNetbox::NetboxParameters::DEFAULT_TAGS
-    assert_equal expected_tags, subject.device.tags
-    assert_equal expected_tags, subject.device_type.tags
-    assert_equal expected_tags, subject.site.tags
-    assert_equal expected_tags, subject.tenant.tags
+    expected_tag_ids = subject.tags.pluck('id')
+    assert (expected_tag_ids - subject.device.tags.pluck('id')).empty?
+    assert (expected_tag_ids - subject.device_type.tags.pluck('id')).empty?
+    assert (expected_tag_ids - subject.site.tags.pluck('id')).empty?
+    assert (expected_tag_ids - subject.tenant.tags.pluck('id')).empty?
     subject.interfaces.reload.each do |interface|
-      assert_equal expected_tags, interface.tags
+      assert (expected_tag_ids - interface.tags.pluck('id')).empty?
     end
     subject.ip_addresses.reload.each do |interface|
-      assert_equal expected_tags, interface.tags
+      assert (expected_tag_ids - interface.tags.pluck('id')).empty?
     end
   end
 end

data/test/integration/foreman_netbox/sync_rhel_virtual_host_test.rb

@@ -61,7 +61,7 @@ class SyncRhelVirtualHostTest < ActiveSupport::TestCase
 
     assert_equal host.name,                                 subject.virtual_machine.name
     assert_equal host.owner.netbox_tenant_name,             subject.virtual_machine.tenant.name
-    assert_equal host.compute_object.cpus,                  subject.virtual_machine.vcpus
+    assert_equal format('%.2f', host.compute_object.cpus),  subject.virtual_machine.vcpus
     assert_equal host.compute_object.memory_mb,             subject.virtual_machine.memory
     assert_equal host.compute_object.volumes.first.size_gb, subject.virtual_machine.disk
     assert_equal host.compute_object.cluster,               subject.virtual_machine.cluster.name
@@ -75,19 +75,23 @@ class SyncRhelVirtualHostTest < ActiveSupport::TestCase
       assert nx_interface.present?
 
       h_interface.netbox_ips.each do |h_ip|
-        assert subject.ip_addresses.find { |nx_ip| nx_ip.interface.id == nx_interface.id && nx_ip.address == IPAddress.parse(h_ip) }.present?
+        assert subject.ip_addresses.find do |nx_ip|
+          nx_ip.interface.assigned_object_type == 'virtualization.vminterface' &&
+            nx_ip.interface.assigned_object_id == nx_interface.id &&
+            nx_ip.address == IPAddress.parse(h_ip)
+        end.present?
       end
     end
 
-    expected_tags = ForemanNetbox::NetboxParameters::DEFAULT_TAGS
-    assert_equal expected_tags, subject.virtual_machine.tags
-    assert_equal expected_tags, subject.tenant.tags
-    assert_equal expected_tags, subject.cluster.tags
+    expected_tag_ids = subject.tags.pluck('id')
+    assert (expected_tag_ids - subject.virtual_machine.tags.pluck('id')).empty?
+    assert (expected_tag_ids - subject.tenant.tags.pluck('id')).empty?
+    assert (expected_tag_ids - subject.cluster.tags.pluck('id')).empty?
     subject.interfaces.reload.each do |interface|
-      assert_equal expected_tags, interface.tags
+      assert (expected_tag_ids - interface.tags.pluck('id')).empty?
     end
     subject.ip_addresses.reload.each do |interface|
-      assert_equal expected_tags, interface.tags
+      assert (expected_tag_ids - interface.tags.pluck('id')).empty?
     end
   end
 end

data/test/interactors/foreman_netbox/sync_host/organizer_test.rb

@@ -3,7 +3,7 @@
 require 'test_plugin_helper'
 
 class SyncHostOrganizerTest < ActiveSupport::TestCase
-  subject { ForemanNetbox::SyncHost::Organizer.call(host: host) }
+  subject { ForemanNetbox::SyncHost::Organizer.call(host: host, tags: default_tags) }
 
   let(:host) do
     FactoryBot.create(:host).tap do |host|
@@ -11,11 +11,27 @@ class SyncHostOrganizerTest < ActiveSupport::TestCase
       host.stubs(:facts).returns({ serialnumber: 'abc123' })
     end
   end
-  let(:tags) { ForemanNetbox::NetboxParameters::DEFAULT_TAGS }
+  let(:tags) do
+    default_tags.map { |t| { 'id' => t.id, 'name' => t.name, 'slug' => t.slug } }
+  end
 
   setup do
     setup_default_netbox_settings
     # rubocop:disable Layout/FirstArrayElementIndentation
+    default_tags.each do |tag|
+      stub_get_netbox_request("extras/tags.json?limit=50&slug=#{tag.slug}", results: [
+        { id: tag.id, name: tag.name, slug: tag.slug }
+      ])
+      stub_request(:get, "#{Setting[:netbox_url]}/api/extras/tags/#{tag.id}.json")
+        .to_return(
+          status: 200, headers: { 'Content-Type': 'application/json' },
+          body: {
+            id: tag.id,
+            name: tag.name,
+            slug: tag.slug
+          }.to_json
+        )
+    end
     stub_get_netbox_request('tenancy/tenants.json?limit=50&slug=admin-user', results: [
       { id: 1, name: host.owner.name, slug: host.owner.name.parameterize, tags: tags }
     ])

data/test/interactors/foreman_netbox/sync_host/sync_device/create_test.rb

@@ -11,7 +11,8 @@ class CreateDeviceTest < ActiveSupport::TestCase
       device_role: device_role,
       site: site,
       tenant: tenant,
-      device: device
+      device: device,
+      tags: tags
     )
   end
 
@@ -26,6 +27,7 @@ class CreateDeviceTest < ActiveSupport::TestCase
   let(:site) { OpenStruct.new(id: 1) }
   let(:tenant) { OpenStruct.new(id: 1) }
   let(:netbox_device_params) { host.netbox_facet.netbox_params.fetch(:device) }
+  let(:tags) { [ForemanNetbox::API.client::Extras::Tag.new(id: 1, name: 'foreman', slug: 'foreman')] }
 
   setup do
     setup_default_netbox_settings
@@ -39,11 +41,11 @@ class CreateDeviceTest < ActiveSupport::TestCase
         body: {
           name: netbox_device_params[:name],
           serial: netbox_device_params[:serial],
-          tags: netbox_device_params[:tags],
           device_type: device_type.id,
           device_role: device_role.id,
           site: site.id,
-          tenant: tenant.id
+          tenant: tenant.id,
+          tags: tags.map(&:id)
         }.to_json
       ).to_return(
         status: 201, headers: { 'Content-Type': 'application/json' },

data/test/interactors/foreman_netbox/sync_host/sync_device/sync_device_type/create_test.rb

@@ -8,7 +8,8 @@ class CreateDeviceTypeTest < ActiveSupport::TestCase
       netbox_params: host.netbox_facet.netbox_params,
       device_type: device_type,
       manufacturer: manufacturer,
-      host: host
+      host: host,
+      tags: default_tags
     )
   end
 
@@ -32,8 +33,8 @@ class CreateDeviceTypeTest < ActiveSupport::TestCase
         body: {
           model: host.netbox_facet.netbox_params.dig(:device_type, :model),
           slug: host.netbox_facet.netbox_params.dig(:device_type, :slug),
-          tags: host.netbox_facet.netbox_params.dig(:device_type, :tags),
-          manufacturer: manufacturer.id
+          manufacturer: manufacturer.id,
+          tags: default_tags.map(&:id)
         }.to_json
       ).to_return(
         status: 201, headers: { 'Content-Type': 'application/json' },

data/test/interactors/foreman_netbox/sync_host/sync_device/sync_device_type/update_test.rb

@@ -5,7 +5,10 @@ require 'test_plugin_helper'
 class UpdateDeviceTypeTest < ActiveSupport::TestCase
   subject do
     ForemanNetbox::SyncHost::SyncDevice::SyncDeviceType::Update.call(
-      host: host, device_type: device_type, netbox_params: host.netbox_facet.netbox_params
+      host: host,
+      device_type: device_type,
+      netbox_params: host.netbox_facet.netbox_params,
+      tags: default_tags
     )
   end
 
@@ -29,7 +32,7 @@ class UpdateDeviceTypeTest < ActiveSupport::TestCase
     it 'updates device type' do
       stub_patch = stub_request(:patch, "#{Setting[:netbox_url]}/api/dcim/device-types/1.json").with(
         body: {
-          tags: host.netbox_facet.netbox_params.dig(:device_type, :tags)
+          tags: default_tags.map(&:id)
         }.to_json
       ).to_return(
         status: 200, headers: { 'Content-Type': 'application/json' },
@@ -42,7 +45,9 @@ class UpdateDeviceTypeTest < ActiveSupport::TestCase
   end
 
   context 'when unchanged' do
-    let(:device_type_tags) { host.netbox_facet.netbox_params.dig(:device_type, :tags) }
+    let(:device_type_tags) do
+      default_tags.map { |t| { 'id' => t.id, 'name' => t.name, 'slug' => t.slug } }
+    end
 
     it 'does not update device type' do
       stub_patch = stub_request(:patch, "#{Setting[:netbox_url]}/api/dcim/device-types/1.json")

data/test/interactors/foreman_netbox/sync_host/sync_device/sync_interfaces/create_test.rb

@@ -5,7 +5,11 @@ require 'test_plugin_helper'
 class CreateDeviceInterfacesTest < ActiveSupport::TestCase
   subject do
     ForemanNetbox::SyncHost::SyncDevice::SyncInterfaces::Create.call(
-      host: host, netbox_params: host.netbox_facet.netbox_params, device: device, interfaces: interfaces
+      host: host,
+      netbox_params: host.netbox_facet.netbox_params,
+      device: device,
+      interfaces: interfaces,
+      tags: default_tags
     )
   end
 
@@ -32,10 +36,10 @@ class CreateDeviceInterfacesTest < ActiveSupport::TestCase
     stub_post = stub_request(:post, "#{Setting[:netbox_url]}/api/dcim/interfaces/").with(
       body: {
         name: host.interfaces.first.netbox_name,
-        mac_address: host.interfaces.first.mac,
-        tags: ForemanNetbox::NetboxParameters::DEFAULT_TAGS,
+        mac_address: host.interfaces.first.mac.upcase,
         type: ForemanNetbox::NetboxParameters::DEFAULT_INTERFACE_TYPE,
-        device: device.id
+        device: device.id,
+        tags: default_tags.map(&:id)
       }.to_json
     ).to_return(
       status: 201, headers: { 'Content-Type': 'application/json' },

data/test/interactors/foreman_netbox/sync_host/sync_device/sync_interfaces/sync_ip_addresses/create_test.rb

@@ -5,7 +5,10 @@ require 'test_plugin_helper'
 class CreateDeviceIpAddressesTest < ActiveSupport::TestCase
   subject do
     ForemanNetbox::SyncHost::SyncDevice::SyncInterfaces::SyncIpAddresses::Create.call(
-      host: host, interfaces: interfaces, netbox_params: host.netbox_facet.netbox_params
+      host: host,
+      interfaces: interfaces,
+      netbox_params: host.netbox_facet.netbox_params,
+      tags: default_tags
     )
   end
 
@@ -54,8 +57,9 @@ class CreateDeviceIpAddressesTest < ActiveSupport::TestCase
     stub_post_ip_address_v4 = stub_request(:post, "#{Setting[:netbox_url]}/api/ipam/ip-addresses/").with(
       body: {
         address: host.interfaces.first.netbox_ip,
-        tags: ForemanNetbox::NetboxParameters::DEFAULT_TAGS,
-        interface: interfaces.first.id
+        assigned_object_type: 'dcim.interface',
+        assigned_object_id: interfaces.first.id,
+        tags: default_tags.map(&:id)
       }.to_json
     ).to_return(
       status: 201, headers: { 'Content-Type': 'application/json' },
@@ -65,8 +69,9 @@ class CreateDeviceIpAddressesTest < ActiveSupport::TestCase
     stub_post_ip_address_v6 = stub_request(:post, "#{Setting[:netbox_url]}/api/ipam/ip-addresses/").with(
       body: {
         address: host.interfaces.first.netbox_ip6,
-        tags: ForemanNetbox::NetboxParameters::DEFAULT_TAGS,
-        interface: interfaces.first.id
+        assigned_object_type: 'dcim.interface',
+        assigned_object_id: interfaces.first.id,
+        tags: default_tags.map(&:id)
       }.to_json
     ).to_return(
       status: 201, headers: { 'Content-Type': 'application/json' },

data/test/interactors/foreman_netbox/sync_host/sync_device/sync_interfaces/sync_ip_addresses/delete_test.rb

@@ -50,8 +50,8 @@ class DeleteDeviceIpAddressesTest < ActiveSupport::TestCase
       body: {
         count: 2,
         results: [
-          { id: ip_addresses_v4_id, address: ip_addresses_v4, interface: { id: interface_id } },
-          { id: ip_addresses_v6_id, address: ip_addresses_v6, interface: { id: interface_id } }
+          { id: ip_addresses_v4_id, address: ip_addresses_v4, assigned_object_type: 'dcim.interface', assigned_object_id: interface_id },
+          { id: ip_addresses_v6_id, address: ip_addresses_v6, assigned_object_type: 'dcim.interface', assigned_object_id: interface_id }
         ]
       }.to_json
     )

data/test/interactors/foreman_netbox/sync_host/sync_device/sync_interfaces/sync_ip_addresses/update_test.rb

@@ -6,14 +6,16 @@ class UpdateDeviceIpAddressesTest < ActiveSupport::TestCase
   subject do
     ForemanNetbox::SyncHost::SyncDevice::SyncInterfaces::SyncIpAddresses::Update.call(
       ip_addresses: ip_addresses,
-      netbox_params: host.netbox_facet.netbox_params
+      netbox_params: host.netbox_facet.netbox_params,
+      tags: default_tags
     )
   end
 
   let(:ip_addresses) { ForemanNetbox::API.client.ipam.ip_addresses.filter(device_id: 1) }
+  let(:tags_data) { default_tags.map { |t| { id: t.id, name: t.name, slug: t.slug } } }
   let(:ip_addresses_data) do
     [
-      { id: 1, address: host.netbox_facet.netbox_params[:ip_addresses].first[:address], tags: ForemanNetbox::NetboxParameters::DEFAULT_TAGS },
+      { id: 1, address: host.netbox_facet.netbox_params[:ip_addresses].first[:address], tags: tags_data },
       { id: 2, address: host.netbox_facet.netbox_params[:ip_addresses].second[:address], tags: [] }
     ]
   end
@@ -50,7 +52,7 @@ class UpdateDeviceIpAddressesTest < ActiveSupport::TestCase
     stub_unexpected_patch = stub_request(:patch, "#{Setting[:netbox_url]}/api/ipam/ip-addresses/#{ip_addresses_data.first[:id]}.json")
     stub_expected_patch = stub_request(:patch, "#{Setting[:netbox_url]}/api/ipam/ip-addresses/#{ip_addresses_data.second[:id]}.json").with(
       body: {
-        tags: ForemanNetbox::NetboxParameters::DEFAULT_TAGS
+        tags: default_tags.map(&:id)
       }.to_json
     ).to_return(
       status: 200, headers: { 'Content-Type': 'application/json' },

data/test/interactors/foreman_netbox/sync_host/sync_device/sync_interfaces/update_test.rb

@@ -7,11 +7,13 @@ class UpdateDeviceInterfacesTest < ActiveSupport::TestCase
     ForemanNetbox::SyncHost::SyncDevice::SyncInterfaces::Update.call(
       interfaces: interfaces,
       host: host,
-      netbox_params: host.netbox_facet.netbox_params
+      netbox_params: host.netbox_facet.netbox_params,
+      tags: tags
     )
   end
 
   let(:interfaces) { ForemanNetbox::API.client::DCIM::Interfaces.new }
+  let(:tags) { [ForemanNetbox::API.client::Extras::Tag.new(id: 1, name: 'foreman', slug: 'foreman')] }
   let(:old_mac) { 'FE:13:C6:44:29:22' }
   let(:host) do
     FactoryBot.build_stubbed(
@@ -44,7 +46,7 @@ class UpdateDeviceInterfacesTest < ActiveSupport::TestCase
             {
               id: 1,
               name: host.interfaces.first.netbox_name,
-              mac_address: new_mac,
+              mac_address: new_mac.upcase,
               tags: []
             }
           ]
@@ -52,8 +54,8 @@ class UpdateDeviceInterfacesTest < ActiveSupport::TestCase
       )
       stub_patch = stub_request(:patch, "#{Setting[:netbox_url]}/api/dcim/interfaces/1.json").with(
         body: {
-          mac_address: host.interfaces.first.mac,
-          tags: ForemanNetbox::NetboxParameters::DEFAULT_TAGS
+          mac_address: host.interfaces.first.mac.upcase,
+          tags: tags.map(&:id)
         }.to_json
       ).to_return(
         status: 200, headers: { 'Content-Type': 'application/json' },
@@ -79,7 +81,7 @@ class UpdateDeviceInterfacesTest < ActiveSupport::TestCase
               id: 1,
               name: host.interfaces.first.netbox_name,
               mac_address: old_mac,
-              tags: ForemanNetbox::NetboxParameters::DEFAULT_TAGS
+              tags: tags.map { |t| { id: t.id, name: t.name, slug: t.slug } }
             }
           ]
         }.to_json

data/test/interactors/foreman_netbox/sync_host/sync_device/sync_site/create_test.rb

@@ -5,7 +5,7 @@ require 'test_plugin_helper'
 class CreateSiteTest < ActiveSupport::TestCase
   subject do
     ForemanNetbox::SyncHost::SyncDevice::SyncSite::Create.call(
-      host: host, site: site, netbox_params: host.netbox_facet.netbox_params
+      host: host, site: site, netbox_params: host.netbox_facet.netbox_params, tags: default_tags
     )
   end
 
@@ -29,7 +29,7 @@ class CreateSiteTest < ActiveSupport::TestCase
         body: {
           name: host.location.netbox_site_name,
           slug: host.location.netbox_site_slug,
-          tags: ForemanNetbox::NetboxParameters::DEFAULT_TAGS
+          tags: default_tags.map(&:id)
         }.to_json
       ).to_return(
         status: 201, headers: { 'Content-Type': 'application/json' },

data/test/interactors/foreman_netbox/sync_host/sync_device/sync_site/update_test.rb

@@ -5,11 +5,12 @@ require 'test_plugin_helper'
 class UpdateSiteTest < ActiveSupport::TestCase
   subject do
     ForemanNetbox::SyncHost::SyncDevice::SyncSite::Update.call(
-      host: host, site: site, netbox_params: host.netbox_facet.netbox_params
+      host: host, site: site, netbox_params: host.netbox_facet.netbox_params, tags: default_tags
     )
   end
 
   let(:host) { FactoryBot.build_stubbed(:host) }
+  # let(:tags) { [ForemanNetbox::API.client::Extras::Tag.new(id: 1, name: 'foreman', slug: 'foreman')] }
   let(:site) do
     ForemanNetbox::API.client::DCIM::Site.new(id: 1).tap do |site|
       site.instance_variable_set(
@@ -29,7 +30,7 @@ class UpdateSiteTest < ActiveSupport::TestCase
     it 'updates site' do
       stub_patch = stub_request(:patch, "#{Setting[:netbox_url]}/api/dcim/sites/1.json").with(
         body: {
-          tags: host.netbox_facet.netbox_params.dig(:site, :tags)
+          tags: default_tags.map(&:id)
         }.to_json
       ).to_return(
         status: 200, headers: { 'Content-Type': 'application/json' },
@@ -42,7 +43,7 @@ class UpdateSiteTest < ActiveSupport::TestCase
   end
 
   context 'when unchanged' do
-    let(:site_tags) { host.netbox_facet.netbox_params.dig(:site, :tags) }
+    let(:site_tags) { default_tags.map { |t| { 'id' => t.id, 'name' => t.name, 'slug' => t.slug } } }
 
     it 'does not update site' do
       stub_patch = stub_request(:patch, "#{Setting[:netbox_url]}/api/dcim/sites/1.json")