foreman_fog_proxmox 0.8.0 → 0.8.2

data/test/unit/foreman_fog_proxmox/proxmox_vm_commands_test.rb

@@ -0,0 +1,43 @@
+# frozen_string_literal: true
+
+# Copyright 2018 Tristan Robert
+
+# This file is part of ForemanFogProxmox.
+
+# ForemanFogProxmox is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+
+# ForemanFogProxmox is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+
+# You should have received a copy of the GNU General Public License
+# along with ForemanFogProxmox. If not, see <http://www.gnu.org/licenses/>.
+
+require 'test_plugin_helper'
+require 'models/compute_resources/compute_resource_test_helpers'
+require 'factories/foreman_fog_proxmox/proxmox_node_mock_factory'
+require 'factories/foreman_fog_proxmox/proxmox_server_mock_factory'
+require 'factories/foreman_fog_proxmox/proxmox_container_mock_factory'
+require 'active_support/core_ext/hash/indifferent_access'
+
+module ForemanFogProxmox
+  class ProxmoxVmCommandsServerTest < ActiveSupport::TestCase
+    include ComputeResourceTestHelpers
+    include ProxmoxNodeMockFactory
+    include ProxmoxServerMockFactory
+    include ProxmoxContainerMockFactory
+    include ProxmoxVmHelper
+
+    describe 'destroy_vm' do
+      it 'handles situation when vm is not present' do
+        cr = mock_cr_servers(ForemanFogProxmox::Proxmox.new, empty_servers)
+        cr.expects(:find_vm_by_uuid).raises(ActiveRecord::RecordNotFound)
+        assert cr.destroy_vm('abc')
+      end
+    end
+  end
+end

data/test/unit/foreman_fog_proxmox/proxmox_vm_new_test.rb

@@ -0,0 +1,71 @@
+# frozen_string_literal: true
+
+# Copyright 2018 Tristan Robert
+
+# This file is part of ForemanFogProxmox.
+
+# ForemanFogProxmox is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+
+# ForemanFogProxmox is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+
+# You should have received a copy of the GNU General Public License
+# along with ForemanFogProxmox. If not, see <http://www.gnu.org/licenses/>.
+
+require 'test_plugin_helper'
+require 'models/compute_resources/compute_resource_test_helpers'
+require 'factories/foreman_fog_proxmox/proxmox_node_mock_factory'
+require 'factories/foreman_fog_proxmox/proxmox_server_mock_factory'
+require 'factories/foreman_fog_proxmox/proxmox_container_mock_factory'
+require 'active_support/core_ext/hash/indifferent_access'
+
+module ForemanFogProxmox
+  class ProxmoxVmNewTest < ActiveSupport::TestCase
+    include ComputeResourceTestHelpers
+    include ProxmoxNodeMockFactory
+    include ProxmoxServerMockFactory
+    include ProxmoxContainerMockFactory
+    include ProxmoxVmHelper
+
+    describe 'new_vm' do
+      before do
+        @cr = FactoryBot.build_stubbed(:proxmox_cr)
+      end
+
+      it 'new server with attr empty' do
+        attr = {}
+        vm = mock('vm')
+        config = mock('config')
+        config.stubs(:inspect).returns('config')
+        vm.stubs(:config).returns(config)
+        @cr.stubs(:new_server_vm).with(attr).returns(vm)
+        assert_equal vm, @cr.new_vm(attr)
+      end
+
+      it 'new server with attr not empty' do
+        attr = { 'type' => 'qemu' }
+        vm = mock('vm')
+        config = mock('config')
+        config.stubs(:inspect).returns('config')
+        vm.stubs(:config).returns(config)
+        @cr.stubs(:new_server_vm).with(attr).returns(vm)
+        assert_equal vm, @cr.new_vm(attr)
+      end
+
+      it 'new container with attr not empty' do
+        attr = { 'type' => 'lxc' }
+        vm = mock('vm')
+        config = mock('config')
+        config.stubs(:inspect).returns('config')
+        vm.stubs(:config).returns(config)
+        @cr.stubs(:new_container_vm).with(attr).returns(vm)
+        assert_equal vm, @cr.new_vm(attr)
+      end
+    end
+  end
+end

data/test/unit/foreman_fog_proxmox/proxmox_vm_queries_test.rb

@@ -0,0 +1,63 @@
+# frozen_string_literal: true
+
+# Copyright 2018 Tristan Robert
+
+# This file is part of ForemanFogProxmox.
+
+# ForemanFogProxmox is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+
+# ForemanFogProxmox is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+
+# You should have received a copy of the GNU General Public License
+# along with ForemanFogProxmox. If not, see <http://www.gnu.org/licenses/>.
+
+require 'test_plugin_helper'
+require 'models/compute_resources/compute_resource_test_helpers'
+require 'factories/foreman_fog_proxmox/proxmox_node_mock_factory'
+require 'factories/foreman_fog_proxmox/proxmox_server_mock_factory'
+require 'factories/foreman_fog_proxmox/proxmox_container_mock_factory'
+require 'active_support/core_ext/hash/indifferent_access'
+
+module ForemanFogProxmox
+  class ProxmoxVmQueriesTest < ActiveSupport::TestCase
+    include ComputeResourceTestHelpers
+    include ProxmoxNodeMockFactory
+    include ProxmoxServerMockFactory
+    include ProxmoxContainerMockFactory
+    include ProxmoxVmHelper
+
+    describe 'find_vm_by_uuid' do
+      it 'returns nil when the uuid does not match' do
+        cr = mock_node_servers_containers(ForemanFogProxmox::Proxmox.new, empty_servers, empty_servers)
+        assert cr.find_vm_by_uuid('100').nil?
+      end
+
+      it 'raises RecordNotFound when the compute raises error' do
+        exception = Fog::Errors::Error.new
+        cr = mock_node_servers(ForemanFogProxmox::Proxmox.new, servers_raising_exception(exception))
+        assert_raises ActiveRecord::RecordNotFound do
+          cr.find_vm_by_uuid('100')
+        end
+      end
+
+      it 'finds vm on other node in cluster' do
+        args = { vmid: '100', type: 'qemu' }
+        servers = mock('servers')
+        servers.stubs(:id_valid?).returns(true)
+        servers.stubs(:get).with(args[:vmid]).returns(args)
+        cr = mock_cluster_nodes_servers_containers(
+          ForemanFogProxmox::Proxmox.new,
+          empty_servers, empty_servers, # node1
+          servers, empty_servers        # node2
+        )
+        assert_equal args, cr.find_vm_by_uuid(args[:vmid])
+      end
+    end
+  end
+end

data/test/unit/foreman_fog_proxmox/semver_test.rb

@@ -20,60 +20,74 @@
 require 'foreman_fog_proxmox/semver'
 
 module ForemanFogProxmox
-    class SemverTest < ActiveSupport::TestCase
-        describe 'is_semver?' do
-            it '#5.3.2 returns true' do            
-                assert ForemanFogProxmox::Semver.is_semver?("5.3.2")
-            end  
-            it '#5.3beta returns false' do            
-                assert !ForemanFogProxmox::Semver.is_semver?("5.3beta")
-            end  
+  class SemverTest < ActiveSupport::TestCase
+    describe 'semver?' do
+      it '#5.3.2 returns true' do
+        assert ForemanFogProxmox::Semver.semver?('5.3.2')
+      end
+      it '#6.0-6 returns true' do
+        assert ForemanFogProxmox::Semver.semver?('6.0-6')
+      end
+      it '#5.3beta returns false' do
+        assert_not ForemanFogProxmox::Semver.semver?('5.3beta')
+      end
+    end
+    describe 'to_semver' do
+      it '#5.3.2 returns SemverClass' do
+        semver = ForemanFogProxmox::Semver.to_semver('5.3.2')
+        assert_not_nil semver
+        assert semver.is_a?(ForemanFogProxmox::Semver::SemverClass)
+        assert_equal 5, semver.major
+        assert_equal 3, semver.minor
+        assert_equal 2, semver.patch
+        assert_equal '', semver.qualifier
+      end
+      it '#6.0-6 returns SemverClass' do
+        semver = ForemanFogProxmox::Semver.to_semver('6.0-6')
+        assert_not_nil semver
+        assert semver.is_a?(ForemanFogProxmox::Semver::SemverClass)
+        assert_equal 6, semver.major
+        assert_equal 0, semver.minor
+        assert_equal 0, semver.patch
+        assert_equal '6', semver.qualifier
+      end
+      it '#5.3beta raises ArgumentError' do
+        assert_raises ArgumentError do
+          ForemanFogProxmox::Semver.to_semver('5.3beta')
         end
-        describe 'to_semver' do
-            it '#5.3.2 returns SemverClass' do    
-                semver = ForemanFogProxmox::Semver.to_semver("5.3.2")        
-                assert_not_nil semver
-                assert semver.is_a?(ForemanFogProxmox::Semver::SemverClass)
-                assert_equal 5, semver.major
-                assert_equal 3, semver.minor
-                assert_equal 2, semver.patch
-                assert_equal '', semver.qualifier
-            end  
-            it '#5.3beta raises ArgumentError' do            
-                assert_raises ArgumentError do
-                    ForemanFogProxmox::Semver.to_semver("5.3beta")
-                end
-            end  
+      end
+    end
+    # rubocop:disable Lint/UselessComparison
+    describe 'semverclass comparators' do
+      it '#5.3.0 <= 5.4.0 returns true' do
+        assert ForemanFogProxmox::Semver.to_semver('5.3.0') <= ForemanFogProxmox::Semver.to_semver('5.4.0')
+      end
+      it '#2.4.0 >= 1.3.0 returns true' do
+        assert ForemanFogProxmox::Semver.to_semver('2.4.0') >= ForemanFogProxmox::Semver.to_semver('1.3.0')
+      end
+      it '#1.0.10 <= 1.0.20 returns true' do
+        assert ForemanFogProxmox::Semver.to_semver('1.0.10') <= ForemanFogProxmox::Semver.to_semver('1.0.20')
+      end
+      it '#1.2.3-beta == 1.2.3-beta returns true' do
+        assert ForemanFogProxmox::Semver.to_semver('1.2.3-beta') == ForemanFogProxmox::Semver.to_semver('1.2.3-beta')
+      end
+      it '#1.2.3-beta >= 1.-beta raises ArgumentError' do
+        assert_raises ArgumentError do
+          ForemanFogProxmox::Semver.to_semver('1.2.3-beta') >= ForemanFogProxmox::Semver.to_semver('1.-beta')
         end
-        describe 'semverclass comparators' do
-            it '#5.3.0 <= 5.4.0 returns true' do        
-                assert ForemanFogProxmox::Semver.to_semver("5.3.0")<=ForemanFogProxmox::Semver.to_semver("5.4.0")
-            end  
-            it '#2.4.0 >= 1.3.0 returns true' do        
-                assert ForemanFogProxmox::Semver.to_semver("2.4.0")>=ForemanFogProxmox::Semver.to_semver("1.3.0")
-            end  
-            it '#1.0.10 <= 1.0.20 returns true' do        
-                assert ForemanFogProxmox::Semver.to_semver("1.0.10")<=ForemanFogProxmox::Semver.to_semver("1.0.20")
-            end  
-            it '#1.2.3-beta == 1.2.3-beta returns true' do        
-                assert ForemanFogProxmox::Semver.to_semver("1.2.3-beta")==ForemanFogProxmox::Semver.to_semver("1.2.3-beta")
-            end   
-            it '#1.2.3-beta >= 1.-beta raises ArgumentError' do            
-                assert_raises ArgumentError do    
-                    ForemanFogProxmox::Semver.to_semver("1.2.3-beta")>=ForemanFogProxmox::Semver.to_semver("1.-beta")
-                end
-            end    
-            it '#SemverClass(1.2.3-beta) >= String(1.-beta) raises TypeError' do            
-                assert_raises TypeError do    
-                    ForemanFogProxmox::Semver.to_semver("1.2.3-beta")>="1.-beta"
-                end
-            end   
-            it '#1.10.2 < 1.20.0 returns true' do        
-                assert ForemanFogProxmox::Semver.to_semver("1.10.2")<ForemanFogProxmox::Semver.to_semver("1.20.0")
-            end 
-            it '#0.10.2 < 1.20.0 returns true' do        
-                assert ForemanFogProxmox::Semver.to_semver("0.10.2")<ForemanFogProxmox::Semver.to_semver("1.20.0")
-            end 
+      end
+      it '#SemverClass(1.2.3-beta) >= String(1.-beta) raises TypeError' do
+        assert_raises TypeError do
+          ForemanFogProxmox::Semver.to_semver('1.2.3-beta') >= '1.-beta'
         end
+      end
+      it '#1.10.2 < 1.20.0 returns true' do
+        assert ForemanFogProxmox::Semver.to_semver('1.10.2') < ForemanFogProxmox::Semver.to_semver('1.20.0')
+      end
+      it '#0.10.2 < 1.20.0 returns true' do
+        assert ForemanFogProxmox::Semver.to_semver('0.10.2') < ForemanFogProxmox::Semver.to_semver('1.20.0')
+      end
     end
-end
+    # rubocop:enable Lint/UselessComparison
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: foreman_fog_proxmox
 version: !ruby/object:Gem::Version
-  version: 0.8.0
+  version: 0.8.2
 platform: ruby
 authors:
 - Tristan Robert
@@ -9,36 +9,36 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-05-10 00:00:00.000000000 Z
+date: 2019-11-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: fog-proxmox
+  name: deface
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '0.8'
+        version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '0.8'
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: deface
+  name: fog-proxmox
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.8'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.8'
 - !ruby/object:Gem::Dependency
   name: rdoc
   requirement: !ruby/object:Gem::Requirement
@@ -115,6 +115,18 @@ files:
 - app/models/concerns/orchestration/proxmox/compute.rb
 - app/models/foreman_fog_proxmox/options_select.rb
 - app/models/foreman_fog_proxmox/proxmox.rb
+- app/models/foreman_fog_proxmox/proxmox_compute_attributes.rb
+- app/models/foreman_fog_proxmox/proxmox_connection.rb
+- app/models/foreman_fog_proxmox/proxmox_console.rb
+- app/models/foreman_fog_proxmox/proxmox_images.rb
+- app/models/foreman_fog_proxmox/proxmox_interfaces.rb
+- app/models/foreman_fog_proxmox/proxmox_operating_systems.rb
+- app/models/foreman_fog_proxmox/proxmox_token_expiration.rb
+- app/models/foreman_fog_proxmox/proxmox_version.rb
+- app/models/foreman_fog_proxmox/proxmox_vm_commands.rb
+- app/models/foreman_fog_proxmox/proxmox_vm_new.rb
+- app/models/foreman_fog_proxmox/proxmox_vm_queries.rb
+- app/models/foreman_fog_proxmox/proxmox_volumes.rb
 - app/overrides/compute_resources_vms/form/add_clone_to_new_vm_compute_detail.rb
 - app/overrides/compute_resources_vms/form/add_from_profile_to_compute_attributes_form.rb
 - app/overrides/compute_resources_vms/form/add_vm_type_to_networks_form.rb
@@ -159,18 +171,33 @@ files:
 - lib/foreman_fog_proxmox/version.rb
 - lib/tasks/foreman_fog_proxmox_tasks.rake
 - locale/Makefile
+- locale/en/foreman_fog_proxmox.edit.po
 - locale/en/foreman_fog_proxmox.po
+- locale/en/foreman_fog_proxmox.po.time_stamp
 - locale/foreman_fog_proxmox.pot
+- locale/fr/foreman_fog_proxmox.edit.po
 - locale/fr/foreman_fog_proxmox.po
+- locale/fr/foreman_fog_proxmox.po.time_stamp
 - locale/gemspec.rb
+- test/factories/foreman_fog_proxmox/proxmox_container_mock_factory.rb
+- test/factories/foreman_fog_proxmox/proxmox_node_mock_factory.rb
+- test/factories/foreman_fog_proxmox/proxmox_server_mock_factory.rb
 - test/factories/proxmox_factory.rb
 - test/functional/compute_resources_controller_test.rb
 - test/test_plugin_helper.rb
 - test/unit/foreman_fog_proxmox/helpers/proxmox_container_helper_test.rb
 - test/unit/foreman_fog_proxmox/helpers/proxmox_server_helper_test.rb
 - test/unit/foreman_fog_proxmox/helpers/proxmox_vm_helper_test.rb
+- test/unit/foreman_fog_proxmox/proxmox_compute_attributes_test.rb
+- test/unit/foreman_fog_proxmox/proxmox_interfaces_test.rb
 - test/unit/foreman_fog_proxmox/proxmox_test.rb
-- test/unit/foreman_fog_proxmox/proxmox_test_helpers.rb
+- test/unit/foreman_fog_proxmox/proxmox_version_test.rb
+- test/unit/foreman_fog_proxmox/proxmox_vm_commands_container_test.rb
+- test/unit/foreman_fog_proxmox/proxmox_vm_commands_server_create_test.rb
+- test/unit/foreman_fog_proxmox/proxmox_vm_commands_server_update_test.rb
+- test/unit/foreman_fog_proxmox/proxmox_vm_commands_test.rb
+- test/unit/foreman_fog_proxmox/proxmox_vm_new_test.rb
+- test/unit/foreman_fog_proxmox/proxmox_vm_queries_test.rb
 - test/unit/foreman_fog_proxmox/semver_test.rb
 homepage: https://github.com/theforeman/foreman_fog_proxmox
 licenses:
@@ -197,11 +224,22 @@ specification_version: 4
 summary: Foreman plugin that adds Proxmox VE compute resource using fog-proxmox
 test_files:
 - test/functional/compute_resources_controller_test.rb
+- test/unit/foreman_fog_proxmox/proxmox_vm_new_test.rb
 - test/unit/foreman_fog_proxmox/semver_test.rb
+- test/unit/foreman_fog_proxmox/proxmox_vm_queries_test.rb
 - test/unit/foreman_fog_proxmox/proxmox_test.rb
-- test/unit/foreman_fog_proxmox/proxmox_test_helpers.rb
+- test/unit/foreman_fog_proxmox/proxmox_vm_commands_container_test.rb
+- test/unit/foreman_fog_proxmox/proxmox_vm_commands_test.rb
+- test/unit/foreman_fog_proxmox/proxmox_vm_commands_server_create_test.rb
+- test/unit/foreman_fog_proxmox/proxmox_compute_attributes_test.rb
 - test/unit/foreman_fog_proxmox/helpers/proxmox_container_helper_test.rb
 - test/unit/foreman_fog_proxmox/helpers/proxmox_vm_helper_test.rb
 - test/unit/foreman_fog_proxmox/helpers/proxmox_server_helper_test.rb
+- test/unit/foreman_fog_proxmox/proxmox_vm_commands_server_update_test.rb
+- test/unit/foreman_fog_proxmox/proxmox_interfaces_test.rb
+- test/unit/foreman_fog_proxmox/proxmox_version_test.rb
 - test/factories/proxmox_factory.rb
+- test/factories/foreman_fog_proxmox/proxmox_node_mock_factory.rb
+- test/factories/foreman_fog_proxmox/proxmox_container_mock_factory.rb
+- test/factories/foreman_fog_proxmox/proxmox_server_mock_factory.rb
 - test/test_plugin_helper.rb