foreman_fog_proxmox 0.8.0 → 0.8.2

data/test/unit/foreman_fog_proxmox/proxmox_version_test.rb

@@ -0,0 +1,82 @@
+# frozen_string_literal: true
+
+# Copyright 2018 Tristan Robert
+
+# This file is part of ForemanFogProxmox.
+
+# ForemanFogProxmox is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+
+# ForemanFogProxmox is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+
+# You should have received a copy of the GNU General Public License
+# along with ForemanFogProxmox. If not, see <http://www.gnu.org/licenses/>.
+
+require 'test_plugin_helper'
+require 'models/compute_resources/compute_resource_test_helpers'
+require 'active_support/core_ext/hash/indifferent_access'
+
+module ForemanFogProxmox
+  class ProxmoxVersionTest < ActiveSupport::TestCase
+    include ComputeResourceTestHelpers
+    include ProxmoxVmHelper
+
+    wrong_version = { version: '5.a', release: '1' }.with_indifferent_access
+    supported_version = { version: '5.4', release: '3' }.with_indifferent_access
+    unsupported_version = { version: '6.0', release: '1' }.with_indifferent_access
+
+    describe 'version' do
+      before do
+        @cr = FactoryBot.build_stubbed(:proxmox_cr)
+        @identity_client = mock('identity_client')
+        @cr.stubs(:identity_client).returns(@identity_client)
+      end
+
+      it 'returns 5.a.1 with 5.a-1' do
+        @identity_client.stubs(:read_version).returns(wrong_version)
+        assert_equal '5.a.1', @cr.version
+      end
+
+      it 'returns 5.4.3 with 5.4-3' do
+        @identity_client.stubs(:read_version).returns(supported_version)
+        assert_equal '5.4.3', @cr.version
+      end
+
+      it 'returns 6.0.1 with 6.0-1' do
+        @identity_client.stubs(:read_version).returns(unsupported_version)
+        assert_equal '6.0.1', @cr.version
+      end
+    end
+
+    describe 'version_suitable?' do
+      before do
+        @cr = FactoryBot.build_stubbed(:proxmox_cr)
+        @identity_client = mock('identity_client')
+        @cr.stubs(:identity_client).returns(@identity_client)
+      end
+
+      it 'raises error with 5.a.1' do
+        @identity_client.stubs(:read_version).returns(wrong_version)
+        err = assert_raises Foreman::Exception do
+          @cr.version_suitable?
+        end
+        assert err.message.end_with?('Proxmox version 5.a.1 is not semver suitable')
+      end
+
+      it 'is true with 5.4-3' do
+        @identity_client.stubs(:read_version).returns(supported_version)
+        assert_equal true, @cr.version_suitable?
+      end
+
+      it 'is false with 6.0-1' do
+        @identity_client.stubs(:read_version).returns(unsupported_version)
+        assert_equal false, @cr.version_suitable?
+      end
+    end
+  end
+end

data/test/unit/foreman_fog_proxmox/proxmox_vm_commands_container_test.rb

@@ -0,0 +1,207 @@
+# frozen_string_literal: true
+
+# Copyright 2018 Tristan Robert
+
+# This file is part of ForemanFogProxmox.
+
+# ForemanFogProxmox is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+
+# ForemanFogProxmox is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+
+# You should have received a copy of the GNU General Public License
+# along with ForemanFogProxmox. If not, see <http://www.gnu.org/licenses/>.
+
+require 'test_plugin_helper'
+require 'models/compute_resources/compute_resource_test_helpers'
+require 'factories/foreman_fog_proxmox/proxmox_node_mock_factory'
+require 'factories/foreman_fog_proxmox/proxmox_container_mock_factory'
+require 'active_support/core_ext/hash/indifferent_access'
+
+module ForemanFogProxmox
+  class ProxmoxVmCommandsContainerTest < ActiveSupport::TestCase
+    include ComputeResourceTestHelpers
+    include ProxmoxNodeMockFactory
+    include ProxmoxContainerMockFactory
+    include ProxmoxVmHelper
+
+    describe 'save_vm' do
+      before do
+        @cr = FactoryBot.build_stubbed(:proxmox_cr)
+      end
+
+      it 'saves modified container config' do
+        uuid = '100'
+        config = mock('config')
+        config.stubs(:attributes).returns(:cores => '')
+        vm = mock('vm')
+        vm.stubs(:config).returns(config)
+        vm.stubs(:container?).returns(true)
+        vm.stubs(:type).returns('lxc')
+        @cr.stubs(:find_vm_by_uuid).returns(vm)
+        attr = { 'templated' => '0', 'config_attributes' => { 'cores' => '1', 'cpulimit' => '1', 'onboot' => '0' } }.with_indifferent_access
+        @cr.stubs(:parse_container_vm).returns('vmid' => '100', 'type' => 'lxc', 'cores' => '1', 'cpulimit' => '1')
+        expected_attr = { :cores => '1', :cpulimit => '1' }
+        vm.expects(:update, expected_attr)
+        @cr.save_vm(uuid, attr)
+      end
+
+      it 'saves modified container config with added volumes' do
+        uuid = '100'
+        config = mock('config')
+        disks = mock('disks')
+        disk = mock('disk')
+        disk.stubs(:size).returns(1_073_741_824)
+        disk.stubs(:storage).returns('local-lvm')
+        disk.stubs(:id).returns('mp0')
+        disks.stubs(:get).returns
+        config.stubs(:disks).returns(disks)
+        config.stubs(:attributes).returns(:cores => '')
+        vm = mock('vm')
+        vm.stubs(:config).returns(config)
+        vm.stubs(:container?).returns(true)
+        vm.stubs(:type).returns('lxc')
+        @cr.stubs(:find_vm_by_uuid).returns(vm)
+        new_attributes = {
+          'templated' => '0',
+          'config_attributes' => {
+            'cores' => '1',
+            'cpulimit' => '1'
+          },
+          'volumes_attributes' => {
+            '0' => {
+              'id' => 'mp0',
+              '_delete' => '',
+              'device' => '0',
+              'storage' => 'local-lvm',
+              'size' => '2147483648',
+              'cache' => 'none',
+              'mp' => '/opt/path'
+            }
+          }
+        }.with_indifferent_access
+        @cr.stubs(:parse_container_vm).returns('vmid' => '100', 'type' => 'lxc', 'cores' => '1', 'cpulimit' => '1')
+        expected_config_attr = { :cores => '1', :cpulimit => '1' }
+        expected_volume_attr =
+          [
+            {
+              id: 'mp0',
+              storage: 'local:lvm',
+              size: (2_147_483_648 / GIGA).to_s
+            },
+            {
+              mp: '/opt/path'
+            }
+          ]
+        vm.expects(:attach, expected_volume_attr)
+        vm.expects(:update, expected_config_attr)
+        @cr.save_vm(uuid, new_attributes)
+      end
+
+      it 'saves modified container config with resized volumes' do
+        uuid = '100'
+        config = mock('config')
+        disks = mock('disks')
+        disk = mock('disk')
+        disk.stubs(:size).returns(1_073_741_824)
+        disk.stubs(:storage).returns('local-lvm')
+        disk.stubs(:id).returns('rootfs')
+        disks.stubs(:get).returns(disk)
+        config.stubs(:disks).returns(disks)
+        config.stubs(:attributes).returns(:cores => '')
+        vm = mock('vm')
+        vm.stubs(:config).returns(config)
+        vm.stubs(:container?).returns(true)
+        vm.stubs(:type).returns('lxc')
+        @cr.stubs(:find_vm_by_uuid).returns(vm)
+        new_attributes =
+          {
+            'templated' => '0',
+            'config_attributes' => {
+              'cores' => '1',
+              'cpulimit' => '1',
+              'onboot' => '0'
+            },
+            'volumes_attributes' => {
+              '0' => {
+                'id' => 'rootfs',
+                '_delete' => '',
+                'volid' => 'local-lvm:1073741824',
+                'device' => '0',
+                'storage' => 'local-lvm',
+                'size' => '2147483648',
+                'cache' => 'none'
+              }
+            }
+          }.with_indifferent_access
+        @cr.stubs(:parse_container_vm).returns(
+          'vmid' => '100',
+          'type' => 'lxc',
+          'cores' => '1',
+          'cpulimit' => '1'
+        )
+        expected_config_attr = { :cores => '1', :cpulimit => '1' }
+        expected_volume_attr = ['rootfs', '+1G']
+        vm.expects(:extend, expected_volume_attr)
+        vm.expects(:update, expected_config_attr)
+        @cr.save_vm(uuid, new_attributes)
+      end
+    end
+
+    describe 'create_vm' do
+      it 'creates container without bootstart' do
+        args = { vmid: '100', type: 'lxc', config_attributes: { onboot: '0' } }
+        servers = mock('servers')
+        servers.stubs(:id_valid?).returns(true)
+        containers = mock('containers')
+        containers.stubs(:create).with(vmid: 100, type: 'lxc', config_attributes: { onboot: '0' })
+        cr = mock_node_servers_containers(ForemanFogProxmox::Proxmox.new, servers, containers)
+        cr.stubs(:convert_sizes).with(args)
+        cr.stubs(:parse_container_vm).with(args).returns(args)
+        vm = mock('vm')
+        cr.stubs(:find_vm_by_uuid).with((args[:vmid]).to_s).returns(vm)
+        cr.create_vm(args)
+      end
+
+      it 'creates container with bootstart' do
+        args = { vmid: '100', type: 'lxc', config_attributes: { onboot: '0' } }
+        servers = mock('servers')
+        servers.stubs(:id_valid?).returns(true)
+        containers = mock('containers')
+        vm = mock('vm')
+        containers.stubs(:create).with(vmid: 100, type: 'lxc', config_attributes: { onboot: '0' }).returns(vm)
+        cr = mock_node_servers_containers(ForemanFogProxmox::Proxmox.new, servers, containers)
+        cr.stubs(:convert_sizes).with(args)
+        cr.stubs(:parse_container_vm).with(args).returns(args)
+        cr.stubs(:find_vm_by_uuid).with((args[:vmid]).to_s).returns(vm)
+        cr.stubs(:start_on_boot).with(vm, args).returns(vm)
+        cr.create_vm(args)
+      end
+
+      it 'clones container' do
+        args = { vmid: '100', type: 'lxc', image_id: '999', name: 'name' }
+        servers = mock('servers')
+        servers.stubs(:id_valid?).returns(true)
+        containers = mock('containers')
+        containers.stubs(:create).with(vmid: 100, type: 'lxc')
+        image = mock('image')
+        clone = mock('clone')
+        image.stubs(:clone).with(100)
+        servers.stubs(:get).with(100).returns(clone)
+        servers.stubs(:get).with('999').returns(image)
+        clone.stubs(:update).with(name: 'name')
+        cr = mock_node_servers_containers(ForemanFogProxmox::Proxmox.new, servers, containers)
+        cr.stubs(:convert_sizes).with(args)
+        cr.stubs(:parse_container_vm).with(args).returns(args)
+        vm = mock('vm')
+        cr.stubs(:find_vm_by_uuid).with((args[:vmid]).to_s).returns(vm)
+        cr.create_vm(args)
+      end
+    end
+  end
+end

data/test/unit/foreman_fog_proxmox/proxmox_vm_commands_server_create_test.rb

@@ -0,0 +1,92 @@
+# frozen_string_literal: true
+
+# Copyright 2018 Tristan Robert
+
+# This file is part of ForemanFogProxmox.
+
+# ForemanFogProxmox is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+
+# ForemanFogProxmox is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+
+# You should have received a copy of the GNU General Public License
+# along with ForemanFogProxmox. If not, see <http://www.gnu.org/licenses/>.
+
+require 'test_plugin_helper'
+require 'models/compute_resources/compute_resource_test_helpers'
+require 'factories/foreman_fog_proxmox/proxmox_node_mock_factory'
+require 'factories/foreman_fog_proxmox/proxmox_server_mock_factory'
+require 'active_support/core_ext/hash/indifferent_access'
+
+module ForemanFogProxmox
+  class ProxmoxVmCommandsServerCreateTest < ActiveSupport::TestCase
+    include ComputeResourceTestHelpers
+    include ProxmoxNodeMockFactory
+    include ProxmoxServerMockFactory
+    include ProxmoxVmHelper
+
+    describe 'create_vm' do
+      it 'raises Foreman::Exception when vmid is invalid' do
+        args = { vmid: '100' }
+        servers = mock('servers')
+        servers.stubs(:id_valid?).returns(false)
+        cr = mock_node_servers(ForemanFogProxmox::Proxmox.new, servers)
+        err = assert_raises Foreman::Exception do
+          cr.create_vm(args)
+        end
+        assert err.message.end_with?('invalid vmid=100')
+      end
+
+      it 'creates server without bootstart' do
+        args = { vmid: '100', type: 'qemu', config_attributes: { onboot: '0' } }
+        servers = mock('servers')
+        servers.stubs(:id_valid?).returns(true)
+        cr = mock_node_servers(ForemanFogProxmox::Proxmox.new, servers)
+        cr.stubs(:convert_sizes).with(args)
+        cr.stubs(:parse_server_vm).with(args).returns(args)
+        servers.stubs(:create).with(args)
+        vm = mock('vm')
+        cr.stubs(:find_vm_by_uuid).with((args[:vmid]).to_s).returns(vm)
+        cr.create_vm(args)
+      end
+
+      it 'creates server with bootstart' do
+        args = { vmid: '100', type: 'qemu', config_attributes: { onboot: '1' } }
+        servers = mock('servers')
+        servers.stubs(:id_valid?).returns(true)
+        cr = mock_node_servers(ForemanFogProxmox::Proxmox.new, servers)
+        cr.stubs(:convert_sizes).with(args)
+        cr.stubs(:parse_server_vm).with(args).returns(args)
+        vm = mock('vm')
+        servers.stubs(:create).with(args).returns(vm)
+        cr.stubs(:find_vm_by_uuid).with((args[:vmid]).to_s).returns(vm)
+        cr.stubs(:start_on_boot).with(vm, args).returns(vm)
+        cr.create_vm(args)
+      end
+
+      it 'clones server' do
+        args = { vmid: '100', type: 'qemu', image_id: '999', name: 'name' }
+        servers = mock('servers')
+        servers.stubs(:id_valid?).returns(true)
+        cr = mock_node_servers(ForemanFogProxmox::Proxmox.new, servers)
+        cr.stubs(:convert_sizes).with(args)
+        cr.stubs(:parse_server_vm).with(args).returns(args)
+        servers.stubs(:create).with(args)
+        image = mock('image')
+        clone = mock('clone')
+        image.stubs(:clone).with(100)
+        servers.stubs(:get).with(100).returns(clone)
+        servers.stubs(:get).with('999').returns(image)
+        clone.stubs(:update).with(name: 'name')
+        vm = mock('vm')
+        cr.stubs(:find_vm_by_uuid).with((args[:vmid]).to_s).returns(vm)
+        cr.create_vm(args)
+      end
+    end
+  end
+end

data/test/unit/foreman_fog_proxmox/proxmox_vm_commands_server_update_test.rb

@@ -0,0 +1,324 @@
+# frozen_string_literal: true
+
+# Copyright 2018 Tristan Robert
+
+# This file is part of ForemanFogProxmox.
+
+# ForemanFogProxmox is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+
+# ForemanFogProxmox is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+
+# You should have received a copy of the GNU General Public License
+# along with ForemanFogProxmox. If not, see <http://www.gnu.org/licenses/>.
+
+require 'test_plugin_helper'
+require 'models/compute_resources/compute_resource_test_helpers'
+require 'factories/foreman_fog_proxmox/proxmox_node_mock_factory'
+require 'factories/foreman_fog_proxmox/proxmox_server_mock_factory'
+require 'active_support/core_ext/hash/indifferent_access'
+
+module ForemanFogProxmox
+  class ProxmoxVmCommandsServerUpdateTest < ActiveSupport::TestCase
+    include ComputeResourceTestHelpers
+    include ProxmoxNodeMockFactory
+    include ProxmoxServerMockFactory
+    include ProxmoxVmHelper
+
+    describe 'save_vm' do
+      before do
+        @cr = FactoryBot.build_stubbed(:proxmox_cr)
+      end
+
+      it 'saves modified server config with same volumes' do
+        uuid = '100'
+        config = mock('config')
+        config.stubs(:attributes).returns(:cores => '')
+        vm = mock('vm')
+        vm.stubs(:config).returns(config)
+        vm.stubs(:container?).returns(false)
+        vm.stubs(:templated?).returns(false)
+        vm.stubs(:type).returns('qemu')
+        @cr.stubs(:find_vm_by_uuid).returns(vm)
+        attr = { 'templated' => '0', 'config_attributes' => { 'cores' => '1', 'cpulimit' => '1', 'onboot' => '0' } }.with_indifferent_access
+        @cr.stubs(:parse_server_vm).returns('vmid' => '100', 'type' => 'qemu', 'cores' => '1', 'cpulimit' => '1', 'onboot' => '0')
+        expected_attr = { :cores => '1', :cpulimit => '1' }.with_indifferent_access
+        vm.expects(:update, expected_attr)
+        @cr.save_vm(uuid, attr)
+      end
+
+      it 'saves server as template' do
+        uuid = '100'
+        config = mock('config')
+        config.stubs(:attributes).returns(:cores => '')
+        vm = mock('vm')
+        vm.stubs(:config).returns(config)
+        vm.stubs(:container?).returns(false)
+        vm.stubs(:templated?).returns(false)
+        vm.stubs(:type).returns('qemu')
+        @cr.stubs(:find_vm_by_uuid).returns(vm)
+        attr = { 'templated' => '1' }
+        vm.expects(:create_template)
+        @cr.save_vm(uuid, attr)
+      end
+
+      it 'saves modified server config with added volumes' do
+        uuid = '100'
+        config = mock('config')
+        disks = mock('disks')
+        disk = mock('disk')
+        disk.stubs(:size).returns(1_073_741_824)
+        disk.stubs(:storage).returns('local-lvm')
+        disk.stubs(:id).returns('scsi0')
+        disks.stubs(:get).returns
+        config.stubs(:disks).returns(disks)
+        config.stubs(:attributes).returns(:cores => '')
+        vm = mock('vm')
+        vm.stubs(:config).returns(config)
+        vm.stubs(:container?).returns(false)
+        vm.stubs(:type).returns('qemu')
+        @cr.stubs(:find_vm_by_uuid).returns(vm)
+        new_attributes = {
+          'templated' => '0',
+          'config_attributes' => {
+            'cores' => '1',
+            'cpulimit' => '1'
+          },
+          'volumes_attributes' => {
+            '0' => {
+              'id' => 'scsi0',
+              '_delete' => '',
+              'device' => '0',
+              'controller' => 'scsi',
+              'storage' => 'local-lvm',
+              'size' => '2147483648',
+              'cache' => 'none'
+            }
+          }
+        }.with_indifferent_access
+        @cr.stubs(:parse_server_vm).returns('vmid' => '100', 'type' => 'qemu', 'cores' => '1', 'cpulimit' => '1', 'onboot' => '0')
+        expected_config_attr = { :cores => '1', :cpulimit => '1' }
+        expected_volume_attr = { id: 'scsi0', storage: 'local:lvm', size: (2_147_483_648 / GIGA).to_s }
+        vm.expects(:attach, expected_volume_attr)
+        vm.expects(:update, expected_config_attr)
+        @cr.save_vm(uuid, new_attributes)
+      end
+
+      it 'saves modified server config with removed volumes' do
+        uuid = '100'
+        config = mock('config')
+        disks = mock('disks')
+        disk = mock('disk')
+        disk.stubs(:size).returns(1_073_741_824)
+        disk.stubs(:storage).returns('local-lvm')
+        disk.stubs(:id).returns('virtio0')
+        disks.stubs(:get).returns(disk)
+        config.stubs(:disks).returns(disks)
+        config.stubs(:attributes).returns(:cores => '')
+        vm = mock('vm')
+        vm.stubs(:config).returns(config)
+        vm.stubs(:container?).returns(false)
+        vm.stubs(:templated?).returns(false)
+        vm.stubs(:type).returns('qemu')
+        @cr.stubs(:find_vm_by_uuid).returns(vm)
+        new_attributes = {
+          'templated' => '0',
+          'config_attributes' => {
+            'cores' => '1',
+            'cpulimit' => '1'
+          },
+          'volumes_attributes' => {
+            '0' => {
+              '_delete' => '1',
+              'id' => 'scsi0',
+              'volid' => 'local-lvm:vm-100-disk-0',
+              'device' => '0',
+              'controller' => 'scsi',
+              'storage' => 'local-lvm',
+              'size' => '2147483648',
+              'cache' => 'none'
+            }
+          }
+        }.with_indifferent_access
+        @cr.stubs(:parse_server_vm).returns('vmid' => '100', 'type' => 'qemu', 'cores' => '1', 'cpulimit' => '1', 'config_attributes' => { 'onboot' => '0' })
+        expected_config_attr = { :cores => '1', :cpulimit => '1' }
+        expected_volume_attr = 'scsi0'
+        vm.expects(:detach, expected_volume_attr)
+        vm.expects(:detach, 'unused0')
+        vm.expects(:update, expected_config_attr)
+        @cr.save_vm(uuid, new_attributes)
+      end
+
+      it 'saves modified server config with removed interfaces' do
+        uuid = '100'
+        config = mock('config')
+        interfaces = mock('interfaces')
+        interface = mock('interface')
+        interface.stubs(:id).returns('net0')
+        interfaces.stubs(:get).returns(interface)
+        config.stubs(:interfaces).returns(interfaces)
+        config.stubs(:attributes).returns(:cores => '')
+        vm = mock('vm')
+        vm.stubs(:config).returns(config)
+        vm.stubs(:container?).returns(false)
+        vm.stubs(:type).returns('qemu')
+        @cr.stubs(:find_vm_by_uuid).returns(vm)
+        new_attributes = {
+          'templated' => '0',
+          'config_attributes' => {
+            'cores' => '1',
+            'cpulimit' => '1'
+          },
+          'interfaces_attributes' => {
+            '0' => {
+              '_delete' => '1',
+              'id' => 'net0'
+            }
+          }
+        }.with_indifferent_access
+        @cr.stubs(:parse_server_vm).returns(
+          'vmid' => '100',
+          'type' => 'qemu',
+          'cores' => '1',
+          'cpulimit' => '1',
+          'delete' => 'net0',
+          'onboot' => '0'
+        )
+        expected_config_attr = { :cores => '1', :cpulimit => '1', :delete => 'net0' }
+        vm.expects(:update, expected_config_attr)
+        @cr.save_vm(uuid, new_attributes)
+      end
+
+      it 'saves modified server config with resized volumes' do
+        uuid = '100'
+        config = mock('config')
+        disks = mock('disks')
+        disk = mock('disk')
+        disk.stubs(:size).returns(1_073_741_824)
+        disk.stubs(:storage).returns('local-lvm')
+        disks.stubs(:get).returns(disk)
+        config.stubs(:disks).returns(disks)
+        config.stubs(:attributes).returns(:cores => '')
+        vm = mock('vm')
+        vm.stubs(:config).returns(config)
+        vm.stubs(:container?).returns(false)
+        vm.stubs(:templated?).returns(false)
+        vm.stubs(:type).returns('qemu')
+        @cr.stubs(:find_vm_by_uuid).returns(vm)
+        new_attributes = {
+          'templated' => '0',
+          'config_attributes' => {
+            'cores' => '1',
+            'cpulimit' => '1'
+          },
+          'volumes_attributes' => {
+            '0' => {
+              'id' => 'scsi0',
+              '_delete' => '',
+              'volid' => 'local-lvm:vm-100-disk-0',
+              'device' => '0',
+              'controller' => 'scsi',
+              'storage' => 'local-lvm',
+              'size' => '2147483648',
+              'cache' => 'none'
+            }
+          }
+        }.with_indifferent_access
+        @cr.stubs(:parse_server_vm).returns('vmid' => '100', 'type' => 'qemu', 'cores' => '1', 'cpulimit' => '1')
+        expected_config_attr = { :cores => '1', :cpulimit => '1' }
+        expected_volume_attr = ['scsi0', '+1G']
+        vm.expects(:extend, expected_volume_attr)
+        vm.expects(:update, expected_config_attr)
+        @cr.save_vm(uuid, new_attributes)
+      end
+
+      it 'raises error unable to shrink volumes' do
+        uuid = '100'
+        config = mock('config')
+        disks = mock('disks')
+        disk = mock('disk')
+        disk.stubs(:size).returns(1_073_741_824)
+        disk.stubs(:storage).returns('local-lvm')
+        disks.stubs(:get).returns(disk)
+        config.stubs(:disks).returns(disks)
+        config.stubs(:attributes).returns(:cores => '')
+        vm = mock('vm')
+        vm.stubs(:config).returns(config)
+        vm.stubs(:container?).returns(false)
+        vm.stubs(:type).returns('qemu')
+        @cr.stubs(:find_vm_by_uuid).returns(vm)
+        new_attributes = {
+          'templated' => '0',
+          'config_attributes' => {
+            'cores' => '1',
+            'cpulimit' => '1'
+          },
+          'volumes_attributes' => {
+            '0' => {
+              'id' => 'scsi0',
+              '_delete' => '',
+              'volid' => 'local-lvm:vm-100-disk-0',
+              'device' => '0',
+              'controller' => 'scsi',
+              'storage' => 'local-lvm',
+              'size' => '2',
+              'cache' => 'none'
+            }
+          }
+        }.with_indifferent_access
+        @cr.stubs(:parse_server_vm).returns('vmid' => '100', 'type' => 'qemu', 'cores' => '1', 'cpulimit' => '1')
+        err = assert_raises Foreman::Exception do
+          @cr.save_vm(uuid, new_attributes)
+        end
+        assert err.message.end_with?('Unable to shrink scsi0 size. Proxmox allows only increasing size.')
+      end
+
+      it 'saves modified server config with moved volumes' do
+        uuid = '100'
+        config = mock('config')
+        disks = mock('disks')
+        disk = mock('disk')
+        disk.stubs(:size).returns(1_073_741_824)
+        disk.stubs(:storage).returns('local-lvm')
+        disks.stubs(:get).returns(disk)
+        config.stubs(:disks).returns(disks)
+        config.stubs(:attributes).returns(:cores => '')
+        vm = mock('vm')
+        vm.stubs(:config).returns(config)
+        vm.stubs(:container?).returns(false)
+        vm.stubs(:type).returns('qemu')
+        @cr.stubs(:find_vm_by_uuid).returns(vm)
+        new_attributes = {
+          'templated' => '0',
+          'config_attributes' => {
+            'cores' => '1',
+            'cpulimit' => '1'
+          },
+          'volumes_attributes' => {
+            '0' => {
+              'id' => 'scsi0',
+              '_delete' => '',
+              'volid' => 'local-lvm:vm-100-disk-0',
+              'device' => '0',
+              'controller' => 'scsi',
+              'storage' => 'local-lvm2',
+              'size' => '1073741824',
+              'cache' => 'none'
+            }
+          }
+        }.with_indifferent_access
+        @cr.stubs(:parse_server_vm).returns('vmid' => '100', 'type' => 'qemu', 'cores' => '1', 'cpulimit' => '1')
+        expected_config_attr = { :cores => '1', :cpulimit => '1' }
+        expected_volume_attr = ['scsi0', 'local-lvm2']
+        vm.expects(:move, expected_volume_attr)
+        vm.expects(:update, expected_config_attr)
+        @cr.save_vm(uuid, new_attributes)
+      end
+    end
+  end
+end