foreman_ansible 2.2.14 → 2.3.0

data/test/unit/services/roles_importer_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_plugin_helper'
 # unit tests for RolesImporter
 class RolesImporterTest < ActiveSupport::TestCase

data/test/unit/services/structured_fact_importer_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_plugin_helper'
 
 module ForemanAnsible

data/test/unit/services/ui_roles_importer_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_plugin_helper'
 # unit tests for UiRolesImporter
 class UiRolesImporterTest < ActiveSupport::TestCase

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: foreman_ansible
 version: !ruby/object:Gem::Version
-  version: 2.2.14
+  version: 2.3.0
 platform: ruby
 authors:
 - Daniel Lobato Garcia
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-03-27 00:00:00.000000000 Z
+date: 2018-11-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -25,54 +25,54 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0.52'
 - !ruby/object:Gem::Dependency
-  name: deface
+  name: foreman_ansible_core
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "<"
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '2.0'
-  type: :runtime
+  type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "<"
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '2.0'
 - !ruby/object:Gem::Dependency
-  name: foreman-tasks
+  name: deface
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - "<"
       - !ruby/object:Gem::Version
-        version: '0.8'
+        version: '2.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - "<"
       - !ruby/object:Gem::Version
-        version: '0.8'
+        version: '2.0'
 - !ruby/object:Gem::Dependency
-  name: foreman_ansible_core
+  name: foreman-tasks
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '0.8'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '0.8'
 - !ruby/object:Gem::Dependency
   name: foreman_remote_execution
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.5.6
+        version: 1.6.3
     - - "<"
       - !ruby/object:Gem::Version
         version: '2.0'
@@ -82,7 +82,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.5.6
+        version: 1.6.3
     - - "<"
       - !ruby/object:Gem::Version
         version: '2.0'
@@ -119,13 +119,17 @@ files:
 - app/assets/images/foreman_ansible/Ansible.png
 - app/assets/stylesheets/foreman_ansible/foreman-ansible.css
 - app/controllers/ansible_roles_controller.rb
+- app/controllers/ansible_variables_controller.rb
 - app/controllers/api/v2/ansible_roles_controller.rb
+- app/controllers/api/v2/ansible_variables_controller.rb
+- app/controllers/concerns/foreman/controller/parameters/ansible_variable.rb
 - app/controllers/foreman_ansible/api/v2/hostgroups_controller_extensions.rb
 - app/controllers/foreman_ansible/api/v2/hostgroups_param_group_extensions.rb
 - app/controllers/foreman_ansible/api/v2/hosts_controller_extensions.rb
 - app/controllers/foreman_ansible/api/v2/hosts_param_group_extensions.rb
 - app/controllers/foreman_ansible/concerns/hostgroups_controller_extensions.rb
 - app/controllers/foreman_ansible/concerns/hosts_controller_extensions.rb
+- app/controllers/foreman_ansible/concerns/import_controller_helper.rb
 - app/controllers/foreman_ansible/concerns/job_invocation_helper.rb
 - app/helpers/foreman_ansible/ansible_plugin_helper.rb
 - app/helpers/foreman_ansible/ansible_reports_helper.rb
@@ -135,6 +139,7 @@ files:
 - app/lib/actions/foreman_ansible/helpers/play_roles_description.rb
 - app/lib/proxy_api/ansible.rb
 - app/models/ansible_role.rb
+- app/models/ansible_variable.rb
 - app/models/concerns/foreman_ansible/host_managed_extensions.rb
 - app/models/concerns/foreman_ansible/hostgroup_extensions.rb
 - app/models/foreman_ansible/ansible_provider.rb
@@ -143,6 +148,7 @@ files:
 - app/models/hostgroup_ansible_role.rb
 - app/models/setting/ansible.rb
 - app/overrides/ansible_roles_tab.rb
+- app/overrides/ansible_variables_edit.rb
 - app/overrides/hostgroup_ansible_roles_tab.rb
 - app/overrides/hostgroup_play_roles.rb
 - app/overrides/report_output.rb
@@ -157,17 +163,28 @@ files:
 - app/services/foreman_ansible/inventory_creator.rb
 - app/services/foreman_ansible/operating_system_parser.rb
 - app/services/foreman_ansible/playbook_creator.rb
+- app/services/foreman_ansible/proxy_api.rb
 - app/services/foreman_ansible/renderer_methods.rb
 - app/services/foreman_ansible/roles_importer.rb
 - app/services/foreman_ansible/structured_fact_importer.rb
 - app/services/foreman_ansible/ui_roles_importer.rb
+- app/services/foreman_ansible/variables_importer.rb
 - app/views/ansible_roles/import.html.erb
 - app/views/ansible_roles/index.html.erb
 - app/views/ansible_roles/welcome.html.erb
+- app/views/ansible_variables/_ansible_roles_list.html.erb
+- app/views/ansible_variables/_validator_text.html.erb
+- app/views/ansible_variables/edit.html.erb
+- app/views/ansible_variables/import.html.erb
+- app/views/ansible_variables/index.html.erb
 - app/views/api/v2/ansible_roles/import.json.rabl
 - app/views/api/v2/ansible_roles/index.json.rabl
 - app/views/api/v2/ansible_roles/obsolete.json.rabl
 - app/views/api/v2/ansible_roles/show.json.rabl
+- app/views/api/v2/ansible_variables/import.json.rabl
+- app/views/api/v2/ansible_variables/index.json.rabl
+- app/views/api/v2/ansible_variables/obsolete.json.rabl
+- app/views/api/v2/ansible_variables/show.json.rabl
 - app/views/api/v2/hostgroups/ansible_roles.json.rabl
 - app/views/api/v2/hosts/ansible_roles.json.rabl
 - app/views/foreman_ansible/ansible_roles/_hostgroup_ansible_roles_button.erb
@@ -198,6 +215,7 @@ files:
 - db/migrate/20160805094233_add_primary_key_hostgroup_ansible_roles.rb
 - db/migrate/20161122154057_automatically_set_role_timestamps.rb
 - db/migrate/20180410125416_rename_ansible_job_categories.rb
+- db/migrate/20180628125416_add_ansible_role_id_to_lookup_keys.rb
 - db/seeds.d/62_ansible_proxy_feature.rb
 - db/seeds.d/75_job_templates.rb
 - db/seeds.d/90_notification_blueprints.rb
@@ -208,27 +226,63 @@ files:
 - lib/foreman_ansible/version.rb
 - locale/Makefile
 - locale/action_names.rb
+- locale/de/LC_MESSAGES/foreman_ansible.mo
+- locale/de/foreman_ansible.edit.po
 - locale/de/foreman_ansible.po
+- locale/de/foreman_ansible.po.time_stamp
+- locale/en/LC_MESSAGES/foreman_ansible.mo
+- locale/en/foreman_ansible.edit.po
 - locale/en/foreman_ansible.po
+- locale/en/foreman_ansible.po.time_stamp
+- locale/es/LC_MESSAGES/foreman_ansible.mo
+- locale/es/foreman_ansible.edit.po
 - locale/es/foreman_ansible.po
+- locale/es/foreman_ansible.po.time_stamp
 - locale/foreman_ansible.pot
+- locale/fr/LC_MESSAGES/foreman_ansible.mo
+- locale/fr/foreman_ansible.edit.po
 - locale/fr/foreman_ansible.po
+- locale/fr/foreman_ansible.po.time_stamp
 - locale/gemspec.rb
+- locale/it/LC_MESSAGES/foreman_ansible.mo
+- locale/it/foreman_ansible.edit.po
 - locale/it/foreman_ansible.po
+- locale/it/foreman_ansible.po.time_stamp
+- locale/ja/LC_MESSAGES/foreman_ansible.mo
+- locale/ja/foreman_ansible.edit.po
 - locale/ja/foreman_ansible.po
+- locale/ja/foreman_ansible.po.time_stamp
+- locale/ko/LC_MESSAGES/foreman_ansible.mo
+- locale/ko/foreman_ansible.edit.po
 - locale/ko/foreman_ansible.po
+- locale/ko/foreman_ansible.po.time_stamp
+- locale/pt_BR/LC_MESSAGES/foreman_ansible.mo
+- locale/pt_BR/foreman_ansible.edit.po
 - locale/pt_BR/foreman_ansible.po
+- locale/pt_BR/foreman_ansible.po.time_stamp
+- locale/ru/LC_MESSAGES/foreman_ansible.mo
+- locale/ru/foreman_ansible.edit.po
 - locale/ru/foreman_ansible.po
+- locale/ru/foreman_ansible.po.time_stamp
+- locale/zh_CN/LC_MESSAGES/foreman_ansible.mo
+- locale/zh_CN/foreman_ansible.edit.po
 - locale/zh_CN/foreman_ansible.po
+- locale/zh_CN/foreman_ansible.po.time_stamp
+- locale/zh_TW/LC_MESSAGES/foreman_ansible.mo
+- locale/zh_TW/foreman_ansible.edit.po
 - locale/zh_TW/foreman_ansible.po
+- locale/zh_TW/foreman_ansible.po.time_stamp
 - package.json
 - test/factories/ansible_proxy.rb
 - test/factories/ansible_roles.rb
+- test/factories/ansible_variables.rb
 - test/fixtures/insights_playbook.yaml
 - test/fixtures/report.json
 - test/fixtures/sample_facts.json
 - test/functional/ansible_roles_controller_test.rb
+- test/functional/ansible_variables_controller_test.rb
 - test/functional/api/v2/ansible_roles_controller_test.rb
+- test/functional/api/v2/ansible_variables_controller_test.rb
 - test/functional/api/v2/hostgroups_controller_test.rb
 - test/functional/api/v2/hosts_controller_test.rb
 - test/functional/hosts_controller_test.rb
@@ -237,6 +291,7 @@ files:
 - test/unit/actions/run_proxy_ansible_command_test.rb
 - test/unit/ansible_provider_test.rb
 - test/unit/ansible_role_test.rb
+- test/unit/ansible_variable_test.rb
 - test/unit/concerns/config_reports_extensions_test.rb
 - test/unit/concerns/host_managed_extensions_test.rb
 - test/unit/concerns/hostgroup_extensions_test.rb
@@ -245,9 +300,9 @@ files:
 - test/unit/hostgroup_ansible_role_test.rb
 - test/unit/lib/foreman_ansible_core/command_creator_test.rb
 - test/unit/lib/foreman_ansible_core/playbook_runner_test.rb
-- test/unit/lib/foreman_ansible_core/roles_reader_test.rb
 - test/unit/lib/proxy_api/ansible_test.rb
 - test/unit/services/ansible_report_importer_test.rb
+- test/unit/services/ansible_variables_importer_test.rb
 - test/unit/services/api_roles_importer_test.rb
 - test/unit/services/fact_importer_test.rb
 - test/unit/services/fact_parser_test.rb
@@ -279,43 +334,47 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.14
+rubygems_version: 2.6.8
 signing_key: 
 specification_version: 4
 summary: Ansible integration with Foreman (theforeman.org)
 test_files:
-- test/factories/ansible_proxy.rb
-- test/factories/ansible_roles.rb
-- test/fixtures/insights_playbook.yaml
-- test/fixtures/report.json
-- test/fixtures/sample_facts.json
-- test/functional/api/v2/ansible_roles_controller_test.rb
-- test/functional/api/v2/hostgroups_controller_test.rb
-- test/functional/api/v2/hosts_controller_test.rb
-- test/functional/ansible_roles_controller_test.rb
-- test/functional/hosts_controller_test.rb
-- test/unit/actions/run_ansible_job_test.rb
-- test/unit/actions/run_proxy_ansible_command_test.rb
+- test/unit/host_ansible_role_test.rb
+- test/unit/helpers/ansible_reports_helper_test.rb
+- test/unit/ansible_role_test.rb
 - test/unit/concerns/config_reports_extensions_test.rb
 - test/unit/concerns/host_managed_extensions_test.rb
 - test/unit/concerns/hostgroup_extensions_test.rb
-- test/unit/helpers/ansible_reports_helper_test.rb
 - test/unit/lib/foreman_ansible_core/command_creator_test.rb
 - test/unit/lib/foreman_ansible_core/playbook_runner_test.rb
-- test/unit/lib/foreman_ansible_core/roles_reader_test.rb
 - test/unit/lib/proxy_api/ansible_test.rb
-- test/unit/services/ansible_report_importer_test.rb
-- test/unit/services/api_roles_importer_test.rb
+- test/unit/ansible_provider_test.rb
+- test/unit/ansible_variable_test.rb
+- test/unit/hostgroup_ansible_role_test.rb
 - test/unit/services/fact_importer_test.rb
-- test/unit/services/fact_parser_test.rb
-- test/unit/services/fact_sparser_test.rb
-- test/unit/services/insights_plan_runner_test.rb
+- test/unit/services/ui_roles_importer_test.rb
 - test/unit/services/inventory_creator_test.rb
 - test/unit/services/roles_importer_test.rb
+- test/unit/services/insights_plan_runner_test.rb
+- test/unit/services/fact_parser_test.rb
+- test/unit/services/ansible_variables_importer_test.rb
+- test/unit/services/api_roles_importer_test.rb
 - test/unit/services/structured_fact_importer_test.rb
-- test/unit/services/ui_roles_importer_test.rb
-- test/unit/ansible_provider_test.rb
-- test/unit/ansible_role_test.rb
-- test/unit/host_ansible_role_test.rb
-- test/unit/hostgroup_ansible_role_test.rb
+- test/unit/services/fact_sparser_test.rb
+- test/unit/services/ansible_report_importer_test.rb
+- test/unit/actions/run_proxy_ansible_command_test.rb
+- test/unit/actions/run_ansible_job_test.rb
 - test/test_plugin_helper.rb
+- test/functional/hosts_controller_test.rb
+- test/functional/api/v2/hosts_controller_test.rb
+- test/functional/api/v2/ansible_roles_controller_test.rb
+- test/functional/api/v2/ansible_variables_controller_test.rb
+- test/functional/api/v2/hostgroups_controller_test.rb
+- test/functional/ansible_roles_controller_test.rb
+- test/functional/ansible_variables_controller_test.rb
+- test/factories/ansible_roles.rb
+- test/factories/ansible_proxy.rb
+- test/factories/ansible_variables.rb
+- test/fixtures/report.json
+- test/fixtures/sample_facts.json
+- test/fixtures/insights_playbook.yaml

data/test/unit/lib/foreman_ansible_core/roles_reader_test.rb

@@ -1,92 +0,0 @@
-require 'test_plugin_helper'
-
-# Tests for the Roles Reader service of ansible core,
-# this class simply reads roles from its path in ansible.cfg
-class RolesReaderTest < ActiveSupport::TestCase
-  CONFIG_PATH = '/etc/ansible/ansible.cfg'.freeze
-  ROLES_PATH = '/etc/ansible/roles'.freeze
-
-  describe '#roles_path' do
-    test 'detects commented roles_path' do
-      expect_content_config ['#roles_path = thisiscommented!']
-      assert_equal(ROLES_PATH,
-                   ForemanAnsibleCore::RolesReader.roles_path)
-    end
-
-    test 'returns default path if no roles_path defined' do
-      expect_content_config ['norolepath!']
-      assert_equal(ROLES_PATH,
-                   ForemanAnsibleCore::RolesReader.roles_path)
-    end
-
-    test 'returns roles_path if one is defined' do
-      expect_content_config ['roles_path = /mycustom/ansibleroles/path']
-      assert_equal('/mycustom/ansibleroles/path',
-                   ForemanAnsibleCore::RolesReader.roles_path)
-    end
-  end
-
-  describe '#list_roles' do
-    test 'reads roles from paths' do
-      expect_content_config ["roles_path = #{ROLES_PATH}"]
-      ForemanAnsibleCore::RolesReader.expects(:read_roles).with(ROLES_PATH)
-      ForemanAnsibleCore::RolesReader.list_roles
-    end
-
-    test 'reads roles from paths' do
-      roles_paths = ['/mycustom/roles/path', '/another/path']
-      roles_paths.each do |path|
-        ForemanAnsibleCore::RolesReader.expects(:read_roles).with(path)
-      end
-      expect_content_config ["roles_path = #{roles_paths.join(':')}"]
-      ForemanAnsibleCore::RolesReader.list_roles
-    end
-
-    context 'with unreadable roles path' do
-      setup do
-        expect_content_config ["roles_path = #{ROLES_PATH}"]
-      end
-
-      test 'handles "No such file or dir" with exception' do
-        Dir.expects(:glob).with("#{ROLES_PATH}/*").raises(Errno::ENOENT)
-        ex = assert_raises(ForemanAnsibleCore::ReadRolesException) do
-          ForemanAnsibleCore::RolesReader.list_roles
-        end
-        assert_match(/Could not read Ansible roles/, ex.message)
-      end
-
-      test 'raises error if the roles path is not readable' do
-        Dir.expects(:glob).with("#{ROLES_PATH}/*").raises(Errno::EACCES)
-        ex = assert_raises(ForemanAnsibleCore::ReadRolesException) do
-          ForemanAnsibleCore::RolesReader.list_roles
-        end
-        assert_match(/Could not read Ansible roles/, ex.message)
-      end
-    end
-
-    context 'with unreadable config' do
-      test 'handles "No such file or dir" with exception' do
-        File.expects(:readlines).with(CONFIG_PATH).raises(Errno::ENOENT)
-        ex = assert_raises(ForemanAnsibleCore::ReadConfigFileException) do
-          ForemanAnsibleCore::RolesReader.list_roles
-        end
-        assert_match(/Could not read Ansible config file/, ex.message)
-      end
-
-      test 'raises error if the roles path is not readable' do
-        File.expects(:readlines).with(CONFIG_PATH).raises(Errno::EACCES)
-        ex = assert_raises(ForemanAnsibleCore::ReadConfigFileException) do
-          ForemanAnsibleCore::RolesReader.list_roles
-        end
-        assert_match(/Could not read Ansible config file/, ex.message)
-      end
-    end
-  end
-
-  private
-
-  def expect_content_config(ansible_cfg_content)
-    ForemanAnsibleCore::RolesReader.expects(:roles_path_from_config).
-      returns(ansible_cfg_content)
-  end
-end