foreman_ansible 2.2.14 → 2.3.0

data/test/factories/ansible_proxy.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 FactoryBot.modify do
   factory :smart_proxy do
     trait :with_ansible do

data/test/factories/ansible_roles.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 FactoryBot.define do
   factory :ansible_role do
     sequence(:name) { |n| "ansible_role_#{n}" }

data/test/factories/ansible_variables.rb

@@ -0,0 +1,8 @@
+# frozen_string_literal: true
+
+FactoryBot.define do
+  factory :ansible_variable do
+    sequence(:key) { |n| "ansible_variable_#{n}" }
+    ansible_role
+  end
+end

data/test/functional/ansible_roles_controller_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_plugin_helper'
 # functional tests for AnsibleRolesController
 class AnsibleRolesControllerTest < ActionController::TestCase

data/test/functional/ansible_variables_controller_test.rb

@@ -0,0 +1,36 @@
+# frozen_string_literal: true
+
+require 'test_plugin_helper'
+# functional tests for AnsibleVariablesController
+class AnsibleVariablesControllerTest < ActionController::TestCase
+  setup do
+    @model = FactoryBot.create(:ansible_variable)
+  end
+
+  basic_index_test
+  basic_edit_test @variable
+  basic_pagination_per_page_test
+  basic_pagination_rendered_test
+
+  test 'should destroy variable' do
+    assert_difference('AnsibleVariable.count', -1) do
+      delete :destroy,
+             :params => { :id => @model.id },
+             :session => set_session_user
+    end
+    assert_redirected_to ansible_variables_url
+  end
+
+  test 'there are no problems when the import hash is empty' do
+    ForemanAnsible::VariablesImporter.any_instance.
+      expects(:import_variable_names).returns({})
+    ForemanAnsible::UiRolesImporter.any_instance.
+      expects(:import_role_names).returns({})
+
+    proxy = FactoryBot.create(:smart_proxy, :with_ansible)
+    get :import,
+        :params => { :proxy => proxy.id },
+        :session => set_session_user
+    assert_response :success
+  end
+end

data/test/functional/api/v2/ansible_roles_controller_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_plugin_helper'
 
 module Api
@@ -23,16 +25,26 @@ module Api
         refute AnsibleRole.exists?(@role.id)
       end
 
-      test 'should import' do
-        put :import,
-            :session => set_session_user
-        assert_response :success
-      end
+      context 'proxy API calls' do
+        setup do
+          roles = ['some_role.some_author', 'test_role.test_author']
+          ProxyAPI::Ansible.any_instance.expects(:roles).returns(roles)
+          @proxy = FactoryBot.create(:smart_proxy, :with_ansible)
+        end
 
-      test 'should obsolete' do
-        put :obsolete,
-            :session => set_session_user
-        assert_response :success
+        test 'should import' do
+          put :import, :params => {
+            :proxy_id => @proxy.id
+          }, :session => set_session_user
+          assert_response :success
+        end
+
+        test 'should obsolete' do
+          put :obsolete, :params => {
+            :proxy_id => @proxy.id
+          }, :session => set_session_user
+          assert_response :success
+        end
       end
 
       test 'should fetch' do

data/test/functional/api/v2/ansible_variables_controller_test.rb

@@ -0,0 +1,41 @@
+# frozen_string_literal: true
+
+require 'test_plugin_helper'
+
+module Api
+  module V2
+    # Tests for the controller to CRUD Ansible Variables
+    class AnsibleVariablesControllerTest < ActionController::TestCase
+      setup do
+        @variable = FactoryBot.create(:ansible_variable)
+      end
+
+      test 'should get index' do
+        get :index, :session => set_session_user
+        response = JSON.parse(@response.body)
+        refute_empty response['results']
+        assert_response :success
+      end
+
+      test 'should destroy' do
+        delete :destroy,
+               :params => { :id => @variable.id },
+               :session => set_session_user
+        assert_response :ok
+        refute AnsibleVariable.exists?(@variable.id)
+      end
+
+      test 'should import' do
+        put :import,
+            :session => set_session_user
+        assert_response :success
+      end
+
+      test 'should obsolete' do
+        put :obsolete,
+            :session => set_session_user
+        assert_response :success
+      end
+    end
+  end
+end

data/test/functional/api/v2/hostgroups_controller_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_plugin_helper'
 require 'dynflow/testing'
 

data/test/functional/api/v2/hosts_controller_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_plugin_helper'
 
 module Api

data/test/functional/hosts_controller_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_plugin_helper'
 require 'dynflow/testing'
 Mocha::Mock.send :include, Dynflow::Testing::Mimic

data/test/test_plugin_helper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_helper'
 require 'facets'
 

data/test/unit/ansible_provider_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_plugin_helper'
 
 # Tests for the behavior of Ansible Role, currently only validations

data/test/unit/ansible_role_test.rb

@@ -1,12 +1,8 @@
+# frozen_string_literal: true
+
 require 'test_plugin_helper'
 
-# Tests for the behavior of Ansible Role, currently only validations
-class AnsibleRoleTest < ActiveSupport::TestCase
-  should have_many(:host_ansible_roles)
-  should have_many(:hosts).through(:host_ansible_roles).dependent(:destroy)
-  should validate_presence_of(:name)
-  context 'with new role' do
-    subject { AnsibleRole.new(:name => 'foo') }
-    should validate_uniqueness_of(:name)
-  end
+# Tests for the behavior of Ansible Variable, currently only validations
+class AnsibleVariableTest < ActiveSupport::TestCase
+  should belong_to(:ansible_role)
 end

data/test/unit/ansible_variable_test.rb

@@ -0,0 +1,14 @@
+# frozen_string_literal: true
+
+require 'test_plugin_helper'
+
+# Tests for the behavior of Ansible Role, currently only validations
+class AnsibleRoleTest < ActiveSupport::TestCase
+  should have_many(:host_ansible_roles)
+  should have_many(:hosts).through(:host_ansible_roles).dependent(:destroy)
+  should validate_presence_of(:name)
+  context 'with new role' do
+    subject { AnsibleRole.new(:name => 'foo') }
+    should validate_uniqueness_of(:name)
+  end
+end

data/test/unit/concerns/config_reports_extensions_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_plugin_helper'
 
 # Tests for the behavior of Host with roles, checks inheritance, etc

data/test/unit/concerns/host_managed_extensions_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: false
+
 require 'test_plugin_helper'
 
 # Tests for the behavior of Host with roles, checks inheritance, etc

data/test/unit/concerns/hostgroup_extensions_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_plugin_helper'
 
 # Tests for the behavior of Hostgroup with roles, checks inheritance, etc

data/test/unit/helpers/ansible_reports_helper_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_plugin_helper'
 
 class AnsibleReportsHelperTest < ActiveSupport::TestCase

data/test/unit/host_ansible_role_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_plugin_helper'
 
 # Tests for validators and such of the join model between Host and

data/test/unit/hostgroup_ansible_role_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_plugin_helper'
 
 # Tests for validators and such of the join model between Hostgroup and

data/test/unit/lib/foreman_ansible_core/command_creator_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_helper'
 
 class CommandCreatorTest < ActiveSupport::TestCase

data/test/unit/lib/foreman_ansible_core/playbook_runner_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_helper'
 
 # Playbook Runner - this class uses foreman_tasks_core

data/test/unit/lib/proxy_api/ansible_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_helper'
 # unit tests for ProxyAPI::Ansible
 class AnsibleTest < ActiveSupport::TestCase

data/test/unit/services/ansible_report_importer_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_plugin_helper'
 # Unit tests for AnsibleReportImporter
 # This class is just meant to capture the config reports coming
@@ -18,4 +20,17 @@ class AnsibleReportImporterTest < ActiveSupport::TestCase
     ForemanAnsible::AnsibleReportScanner.expects(:ansible_report?).returns(true)
     assert @importer.host.new_record?
   end
+
+  test 'finds host when given partially qualified name' do
+    host = ::FactoryBot.create(:host, :hostname => 'ansible-host.example.com')
+    ForemanAnsible::AnsibleReportScanner.expects(:ansible_report?).returns(true)
+    assert_equal host, ::ConfigReportImporter.new({ 'host' => 'ansible-host' }).host
+  end
+
+  test 'creates a new host when multiple hosts for partially qualified name are found' do
+    ::FactoryBot.create(:host, :hostname => 'ansible-host.example.com')
+    ::FactoryBot.create(:host, :hostname => 'ansible-host.dummy.org')
+    ForemanAnsible::AnsibleReportScanner.expects(:ansible_report?).returns(true)
+    assert ::ConfigReportImporter.new({ 'host' => 'ansible-host' }).host.new_record?
+  end
 end

data/test/unit/services/ansible_variables_importer_test.rb

@@ -0,0 +1,39 @@
+# frozen_string_literal: true
+
+require 'test_plugin_helper'
+# Unit tests for importing variables
+# This service is meant to take in essentially a string coming from
+# the proxy API, and parse that into AnsibleVariables.
+class AnsibleVariablesImporterTest < ActiveSupport::TestCase
+  setup do
+    @importer = ForemanAnsible::VariablesImporter.new
+  end
+  test 'does not reimport already existing variables' do
+    already_existing = FactoryBot.create(:ansible_variable)
+    new_role = FactoryBot.create(:ansible_role)
+    api_response = {
+      new_role.name => ['new_var'],
+      already_existing.ansible_role.name => [already_existing.key]
+    }
+    changes = @importer.import_variables(api_response, [new_role.name])
+    assert_not_empty changes['new']
+    assert_equal 'new_var', changes['new'].first.key
+    assert_equal new_role, changes['new'].first.ansible_role
+  end
+
+  test "variables attempts to remove variables that don't exist anymore" do
+    obsolete_variable = FactoryBot.create(:ansible_variable)
+    changes = @importer.import_variables({}, [])
+    assert_not_empty changes['obsolete']
+    assert_equal obsolete_variable.key, changes['obsolete'].first.key
+    assert_equal(
+      obsolete_variable.ansible_role,
+      changes['obsolete'].first.ansible_role
+    )
+  end
+
+  test 'does not do anything if response is empty' do
+    changes = @importer.import_variables({}, [])
+    assert_equal({ 'new' => [], 'obsolete' => [] }, changes)
+  end
+end

data/test/unit/services/api_roles_importer_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_plugin_helper'
 # unit tests for ApiRolesImporter
 class ApiRolesImporterTest < ActiveSupport::TestCase

data/test/unit/services/fact_importer_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ForemanAnsible
   # Test for the facts importer - only verify that given
   # a set of facts it's able to import them

data/test/unit/services/fact_parser_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ForemanAnsible
   # Checks sample Ansible facts to see if it can assign them to
   # Host properties
@@ -58,6 +60,51 @@ module ForemanAnsible
     end
   end
 
+  # Tests for Network parser
+  class NetworkFactParserTest < ActiveSupport::TestCase
+    setup do
+      @facts_parser = ForemanAnsible::FactParser.new(
+        HashWithIndifferentAccess.new(
+          '_type' => 'ansible',
+          '_timestamp' => '2018-10-29 20:01:51 +0100',
+          'ansible_facts' =>
+          {
+            'ansible_interfaces' => [
+                'eth0'
+            ],
+            'ansible_eth0' => {
+              'active' => true,
+              'device' => 'eth0',
+              "macaddress" => '52:54:00:04:55:37',
+              'ipv4' => {
+                  'address' => '10.10.0.10',
+                  'netmask' => '255.255.0.0',
+                  'network' => '10.10.0.0'
+              },
+              'ipv6' => [
+                  {
+                      'address' => 'fd00::5054:00ff:fe04:5537',
+                      'prefix' => '64',
+                      'scope' => 'host'
+                  }
+              ],
+              'mtu' => 1500,
+              'promisc' => false,
+              'type' => 'ether'
+            }
+          }
+        )
+      )
+    end
+
+    test 'Parses IPv4 & IPv6 addresses correctly' do
+      iut = 'eth0'.dup
+      interface = @facts_parser.get_facts_for_interface(iut)
+      assert_equal '10.10.0.10', interface['ipaddress']
+      assert_equal 'fd00::5054:00ff:fe04:5537', interface['ipaddress6']
+    end
+  end
+
   # Tests for Debian parser
   class DebianFactParserTest < ActiveSupport::TestCase
     setup do

data/test/unit/services/fact_sparser_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ForemanAnsible
   # Tests for checking if FactSparser can sparse a hash and unsparse it
   class FactSparserTest < ActiveSupport::TestCase

data/test/unit/services/insights_plan_runner_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_plugin_helper'
 
 if defined? RedhatAccess

data/test/unit/services/inventory_creator_test.rb

@@ -10,8 +10,7 @@ module ForemanAnsible
     setup do
       @host = FactoryBot.build(:host)
       @template_invocation = OpenStruct.new(
-        :job_invocation => OpenStruct.new(:password => 'foobar',
-					 :sudo_password => 'foobar'),
+        :job_invocation => OpenStruct.new(:password => 'foobar'),
         :effective_user => 'foobar'
       )
     end
@@ -42,8 +41,6 @@ module ForemanAnsible
         returns('root').at_least_once
       Setting.expects(:[]).with('remote_execution_ssh_password').
         returns('asafepassword').at_least_once
-      Setting.expects(:[]).with('remote_execution_sudo_password').
-        returns('foobar').at_least_once
       Setting.expects(:[]).with('ansible_winrm_server_cert_validation').
         returns(true).at_least_once
       Setting.expects(:[]).with('ansible_connection').
@@ -72,8 +69,6 @@ module ForemanAnsible
                    connection_params['ansible_port']
       assert_equal Setting['remote_execution_ssh_password'],
                    connection_params['ansible_ssh_pass']
-      assert_equal Setting['remote_execution_sudo_password'],
-                   connection_params['ansible_sudo_pass']
       assert_equal Setting['ansible_winrm_server_cert_validation'],
                    connection_params['ansible_winrm_server_cert_validation']
     end
@@ -85,13 +80,6 @@ module ForemanAnsible
                    inventory.rex_ssh_password(@host))
     end
 
-    test 'job invocation sudo password is passed when available' do
-      inventory = ForemanAnsible::InventoryCreator.new(@host,
-                                                       @template_invocation)
-      assert_equal(@template_invocation.job_invocation.sudo_password,
-                   inventory.rex_sudo_password(@host))
-    end
-
     test 'ssh private key is passed when available' do
       host = FactoryBot.build(:host)
       path_to_key = '/path/to/private/key'