foodcritic 11.1.0 → 11.2.0

data/spec/functional/fc059_spec.rb

@@ -0,0 +1,27 @@
+require "spec_helper"
+
+describe "FC059" do
+  context "with a cookbook with LWRP not using use_inline_resources" do
+    provider_file <<-EOF
+    action :create do
+      template "/etc/something.conf" do
+        notifies :restart, "service[something]"
+      end
+    end
+    EOF
+    it { is_expected.to violate_rule }
+  end
+
+  context "with a cookbook with LWRP using use_inline_resources" do
+    provider_file <<-EOF
+    use_inline_resources
+
+    action :create do
+      template "/etc/something.conf" do
+        notifies :restart, "service[something]"
+      end
+    end
+    EOF
+    it { is_expected.not_to violate_rule }
+  end
+end

data/spec/functional/fc060_spec.rb

@@ -0,0 +1,45 @@
+require "spec_helper"
+
+describe "FC060" do
+  context "with a cookbook with LWRP with use_inline_resources and with bad action_create" do
+    provider_file <<-EOF
+    use_inline_resources
+
+    def action_create
+      cookbook_file "/etc/something.conf"
+    end
+    EOF
+    it { is_expected.to violate_rule }
+  end
+
+  context "with a cookbook with LWRP without use_inline_resources and with bad action_create" do
+    provider_file <<-EOF
+    def action_create
+      cookbook_file "/etc/something.conf"
+    end
+    EOF
+    it { is_expected.not_to violate_rule }
+  end
+
+  context "with a cookbook with LWRP without use_inline_resources" do
+    provider_file <<-EOF
+    action :create do
+      cookbook_file "/etc/something.conf"
+    end
+    EOF
+    it { is_expected.not_to violate_rule }
+  end
+
+  context "with a cookbook with LWRP using use_inline_resources" do
+    provider_file <<-EOF
+    use_inline_resources
+
+    action :create do
+      template "/etc/something.conf" do
+        notifies :restart, "service[something]"
+      end
+    end
+    EOF
+    it { is_expected.not_to violate_rule }
+  end
+end

data/spec/functional/fc061_spec.rb

@@ -3,46 +3,46 @@ require "spec_helper"
 describe "FC061" do
   context "with a cookbook with metadata that includes the version keyword and a valid version string" do
     metadata_file("version '1.2.3'")
-    it { is_expected.not_to violate_rule("FC061") }
+    it { is_expected.not_to violate_rule }
   end
 
   context "with a cookbook with metadata that includes the version keyword and a valid version string with double quotes" do
     metadata_file('version "1.2.3"')
-    it { is_expected.not_to violate_rule("FC061") }
+    it { is_expected.not_to violate_rule }
   end
 
   context "with a cookbook with metadata that includes the version keyword and a valid x.y version string" do
     metadata_file("version '1.2'")
-    it { is_expected.not_to violate_rule("FC061") }
+    it { is_expected.not_to violate_rule }
   end
 
   context "with a cookbook with metadata that does not include a version keyword" do
     metadata_file("name 'something'")
-    it { is_expected.not_to violate_rule("FC061") }
+    it { is_expected.not_to violate_rule }
   end
 
   context "with a cookbook with metadata that includes the version keyword and an invalid version string" do
     metadata_file("version 'one'")
-    it { is_expected.to violate_rule("FC061") }
+    it { is_expected.to violate_rule }
   end
 
   context "with a cookbook metadata that includes the version keyword and an invalid single digit version string" do
     metadata_file("version '1'")
-    it { is_expected.to violate_rule("FC061") }
+    it { is_expected.to violate_rule }
   end
 
   context "with a cookbook metadata that includes the version keyword and an invalid four digit version string" do
     metadata_file("version '1.2.3.4'")
-    it { is_expected.to violate_rule("FC061") }
+    it { is_expected.to violate_rule }
   end
 
   context "with a cookbook metadata that includes the version keyword that uses string interpolation" do
     metadata_file('patch = 3\nversion "1.2.#{patch}"')
-    it { is_expected.not_to violate_rule("FC061") }
+    it { is_expected.not_to violate_rule }
   end
 
   context "with a cookbook metadata that includes the version keyword that is not a string literal" do
     metadata_file('v = "1.2.3"\nversion v')
-    it { is_expected.not_to violate_rule("FC061") }
+    it { is_expected.not_to violate_rule }
   end
 end

data/spec/functional/fc062_spec.rb

@@ -3,11 +3,11 @@ require "spec_helper"
 describe "FC062" do
   context "with a cookbook with metadata that includes the version keyword and a valid version string" do
     metadata_file("version '1.2.3'")
-    it { is_expected.not_to violate_rule("FC062") }
+    it { is_expected.not_to violate_rule }
   end
 
   context "with a cookbook with metadata that does not include a version keyword" do
     metadata_file
-    it { is_expected.to violate_rule("FC062") }
+    it { is_expected.to violate_rule }
   end
 end

data/spec/functional/fc063_spec.rb

@@ -3,16 +3,16 @@ require "spec_helper"
 describe "FC063" do
   context "with a cookbook with a metadata file that depends on itself" do
     metadata_file "name 'something'\ndepends 'something'"
-    it { is_expected.to violate_rule("FC063") }
+    it { is_expected.to violate_rule }
   end
 
   context "with a cookbook with a metadata file that depends on a cookbook, but not itself" do
     metadata_file "name 'something'\ndepends 'another_thing'"
-    it { is_expected.to_not violate_rule("FC063") }
+    it { is_expected.to_not violate_rule }
   end
 
   context "with a cookbook with a metadata file that doesn't depend on any cookbooks" do
     metadata_file "name 'something'"
-    it { is_expected.to_not violate_rule("FC063") }
+    it { is_expected.to_not violate_rule }
   end
 end

data/spec/functional/fc064_spec.rb

@@ -3,11 +3,11 @@ require "spec_helper"
 describe "FC064" do
   context "with a cookbook with a metadata file that does not specify issues_url" do
     metadata_file
-    it { is_expected.to violate_rule("FC064") }
+    it { is_expected.to violate_rule }
   end
 
   context "with a cookbook with a metadata file that specifies a issues_url" do
     metadata_file "issues_url 'http://wwww.something.com/'"
-    it { is_expected.to_not violate_rule("FC064") }
+    it { is_expected.to_not violate_rule }
   end
 end

data/spec/functional/fc065_spec.rb

@@ -3,11 +3,11 @@ require "spec_helper"
 describe "FC065" do
   context "with a cookbook with a metadata file that does not specify source_url" do
     metadata_file
-    it { is_expected.to violate_rule("FC065") }
+    it { is_expected.to violate_rule }
   end
 
   context "with a cookbook with a metadata file that specifies a source_url" do
     metadata_file "source_url 'http://wwww.something.com/'"
-    it { is_expected.to_not violate_rule("FC065") }
+    it { is_expected.to_not violate_rule }
   end
 end

data/spec/functional/fc066_spec.rb

@@ -3,31 +3,31 @@ require "spec_helper"
 describe "FC066" do
   context "with a cookbook with a metadata file that does not specify chef_version" do
     metadata_file "name 'my_cookbook'"
-    it { is_expected.to violate_rule("FC066") }
+    it { is_expected.to violate_rule }
   end
 
   context "with a cookbook with a metadata file that specifies a chef_version" do
     metadata_file "chef_version '>= 12.1'"
-    it { is_expected.to_not violate_rule("FC066") }
+    it { is_expected.to_not violate_rule }
   end
 
   context "with a cookbook with a metadata file that specifies a chef_version with a guard" do
     metadata_file "chef_version '>= 12.1' if defined?(chef_version)"
-    it { is_expected.to_not violate_rule("FC066") }
+    it { is_expected.to_not violate_rule }
   end
 
   context "with a cookbook with a metadata file that specifies a chef_version with parens" do
     metadata_file "chef_version('>= 12.1')"
-    it { is_expected.to_not violate_rule("FC066") }
+    it { is_expected.to_not violate_rule }
   end
 
   context "with a cookbook with a metadata file that specifies a chef_version with multiple arguments" do
     metadata_file "chef_version '>= 12.1', '< 14'"
-    it { is_expected.to_not violate_rule("FC066") }
+    it { is_expected.to_not violate_rule }
   end
 
   context "with a cookbook with a metadata file that specifies a chef_version with a splat" do
     metadata_file "chef_version(*['>= 12.1', '< 14'])"
-    it { is_expected.to_not violate_rule("FC066") }
+    it { is_expected.to_not violate_rule }
   end
 end

data/spec/functional/fc067_spec.rb

@@ -3,11 +3,11 @@ require "spec_helper"
 describe "FC067" do
   context "with a cookbook with a metadata file that does not specify supports" do
     metadata_file "name 'my_cookbook'"
-    it { is_expected.to violate_rule("FC067") }
+    it { is_expected.to violate_rule }
   end
 
   context "with a cookbook with a metadata file that specifies a supported platform (anything)" do
     metadata_file "supports 'some_os'"
-    it { is_expected.to_not violate_rule("FC067") }
+    it { is_expected.to_not violate_rule }
   end
 end

data/spec/functional/fc068_spec.rb

@@ -3,11 +3,11 @@ require "spec_helper"
 describe "FC068" do
   context "with a cookbook with a metadata file that does not specify the license" do
     metadata_file "name 'my_cookbook'"
-    it { is_expected.to violate_rule("FC068") }
+    it { is_expected.to violate_rule }
   end
 
   context "with a cookbook with a metadata file that specifies a license (anything)" do
     metadata_file "license 'My Super Cool License'"
-    it { is_expected.to_not violate_rule("FC068") }
+    it { is_expected.to_not violate_rule }
   end
 end

data/spec/functional/fc069_spec.rb

@@ -3,27 +3,27 @@ require "spec_helper"
 describe "FC069" do
   context "with a cookbook with a metadata file that specifies a license generated by knife cookbook create" do
     metadata_file "license 'Apache 2.0'"
-    it { is_expected.to violate_rule("FC069") }
+    it { is_expected.to violate_rule }
   end
 
   context "with a cookbook with a metadata file that specifies a license generated by chef generate cookbook" do
     metadata_file "license 'apache_2'"
-    it { is_expected.to violate_rule("FC069") }
+    it { is_expected.to violate_rule }
   end
 
   context "with a cookbook with a metadata file that specifies a valid SPDX license" do
     metadata_file "license 'Apache-2.0'"
-    it { is_expected.to_not violate_rule("FC069") }
+    it { is_expected.to_not violate_rule }
   end
 
   context "with a cookbook with a metadata file that specifies ChefDK's non-SPDX all rights reserved string" do
     metadata_file "license 'All Rights Reserved'"
-    it { is_expected.to_not violate_rule("FC069") }
+    it { is_expected.to_not violate_rule }
   end
 
   context "with a cookbook with a metadata file that specifies ChefDK's non-SPDX all rights reserved string with a different casing" do
     metadata_file "license 'All rights reserved'"
-    it { is_expected.to_not violate_rule("FC069") }
+    it { is_expected.to_not violate_rule }
   end
 
   context "with a cookbook with a metadata file that specifies a license with parens" do

data/spec/functional/fc070_spec.rb

@@ -3,37 +3,37 @@ require "spec_helper"
 describe "FC070" do
   context "with a cookbook with a metadata file specifying a single valid supports statement" do
     metadata_file "supports 'ubuntu'"
-    it { is_expected.to_not violate_rule("FC070") }
+    it { is_expected.to_not violate_rule }
   end
 
   context "with a cookbook with a metadata file specifying multiple valid supports statements" do
     metadata_file "%w(ubuntu debian fedora).each do |plat|\nsupports plat\nend"
-    it { is_expected.to_not violate_rule("FC070") }
+    it { is_expected.to_not violate_rule }
   end
 
   context "with a cookbook with a metadata file specifying a single invalid supports statement" do
     metadata_file "supports 'aws'"
-    it { is_expected.to violate_rule("FC070") }
+    it { is_expected.to violate_rule }
   end
 
   context "with a cookbook with a metadata file specifying multiple invalid supports statements" do
     metadata_file "%w(aws oel rhel).each do |plat|\nsupports plat\nend"
-    it { is_expected.to violate_rule("FC070") }
+    it { is_expected.to violate_rule }
   end
 
   context "with a cookbook with a metadata file specifying a mix of valid and invalid supports statements" do
     metadata_file "%w(aws oracle scientific).each do |plat|\nsupports plat\nend"
-    it { is_expected.to violate_rule("FC070") }
+    it { is_expected.to violate_rule }
   end
 
   context "with a cookbook with a metadata file specifying a valid supports platform, but uppercase" do
     metadata_file "supports 'UBUNTU'"
-    it { is_expected.to violate_rule("FC070") }
+    it { is_expected.to violate_rule }
   end
 
   context "with a cookbook with a metadata file specifying a valid supports platform, but with a version string" do
     metadata_file "supports 'ubuntu >= 16.04'"
-    it { is_expected.to violate_rule("FC070") }
+    it { is_expected.to violate_rule }
   end
 
   context "with a cookbook with a metadata file specifying valid platforms from an array with leading whitespace" do
@@ -51,7 +51,7 @@ describe "FC070" do
       supports os
     end
     EOH
-    it { is_expected.to_not violate_rule("FC070") }
+    it { is_expected.to_not violate_rule }
   end
 
   context "with a word list and a version constraint" do
@@ -60,6 +60,6 @@ describe "FC070" do
         supports os, ">= 5.0"
       end
     EOH
-    it { is_expected.to_not violate_rule("FC070") }
+    it { is_expected.to_not violate_rule }
   end
 end

data/spec/functional/fc071_spec.rb

@@ -4,33 +4,33 @@ describe "FC071" do
   context "with a cookbook with a LICENSE file" do
     metadata_file "name 'mycookbook'"
     file("LICENSE")
-    it { is_expected.not_to violate_rule("FC071") }
+    it { is_expected.not_to violate_rule }
   end
 
   context "with a cookbook without a LICENSE file" do
     metadata_file "name 'mycookbook'"
-    it { is_expected.to violate_rule("FC071") }
+    it { is_expected.to violate_rule }
   end
 
   context "with a cookbook without a LICENSE file but with license of 'All Rights Reserved'" do
     metadata_file "license 'All Rights Reserved'"
-    it { is_expected.not_to violate_rule("FC071") }
+    it { is_expected.not_to violate_rule }
   end
 
   context "with a cookbook without a LICENSE file but with license of 'all rights reserved'" do
     metadata_file "license 'all rights reserved'"
-    it { is_expected.not_to violate_rule("FC071") }
+    it { is_expected.not_to violate_rule }
   end
 
   context "with a cookbook without a LICENSE file, using a sub folder" do
     subject { foodcritic_command("--no-progress", "mycookbook/") }
     file "mycookbook/metadata.rb"
-    it { is_expected.to violate_rule("FC071") }
+    it { is_expected.to violate_rule }
   end
 
   context "with a cookbook without a LICENSE file but with license of 'All Rights Reserved', using a sub folder" do
     subject { foodcritic_command("--no-progress", "mycookbook/") }
     file "mycookbook/metadata.rb", "license 'All Rights Reserved'"
-    it { is_expected.not_to violate_rule("FC071") }
+    it { is_expected.not_to violate_rule }
   end
 end

data/spec/functional/fc072_spec.rb

@@ -3,11 +3,11 @@ require "spec_helper"
 describe "FC072" do
   context "with a cookbook with a metadata file that contains an attribute keyword" do
     metadata_file "attribute 'something/something',\n    display_name: 'something tuneable',\n    description: 'This tunes something',\n    default: 'none'"
-    it { is_expected.to violate_rule("FC072") }
+    it { is_expected.to violate_rule }
   end
 
   context "with a cookbook with a metadata file that doesn't contain an attribute keyword" do
     metadata_file
-    it { is_expected.not_to violate_rule("FC072") }
+    it { is_expected.not_to violate_rule }
   end
 end

data/spec/functional/fc073_spec.rb

@@ -3,45 +3,45 @@ require "spec_helper"
 describe "FC073" do
   context "with an empty cookbook" do
     metadata_file
-    it { is_expected.to_not violate_rule("FC073") }
+    it { is_expected.to_not violate_rule }
   end
 
   context "with only attributes/default.rb" do
     metadata_file
     attributes_file
-    it { is_expected.to_not violate_rule("FC073") }
+    it { is_expected.to_not violate_rule }
   end
 
   context "with only attributes.rb" do
     metadata_file
     file "attributes.rb"
-    it { is_expected.to_not violate_rule("FC073") }
+    it { is_expected.to_not violate_rule }
   end
 
   context "with both attributes.rb and attributes/default.rb" do
     metadata_file
     file "attributes.rb"
     attributes_file
-    it { is_expected.to violate_rule("FC073").in("attributes/default.rb") }
+    it { is_expected.to violate_rule.in("attributes/default.rb") }
   end
 
   context "with only recipes/default.rb" do
     metadata_file
     recipe_file
-    it { is_expected.to_not violate_rule("FC073") }
+    it { is_expected.to_not violate_rule }
   end
 
   context "with only recipe.rb" do
     metadata_file
     file "recipe.rb"
-    it { is_expected.to_not violate_rule("FC073") }
+    it { is_expected.to_not violate_rule }
   end
 
   context "with both recipe.rb and recipes/default.rb" do
     metadata_file
     file "recipe.rb"
     recipe_file
-    it { is_expected.to violate_rule("FC073").in("recipes/default.rb") }
+    it { is_expected.to violate_rule.in("recipes/default.rb") }
   end
 
   context "with all four" do
@@ -50,7 +50,7 @@ describe "FC073" do
     file "recipe.rb"
     attributes_file
     recipe_file
-    it { is_expected.to violate_rule("FC073").in("attributes/default.rb") }
-    it { is_expected.to violate_rule("FC073").in("recipes/default.rb") }
+    it { is_expected.to violate_rule.in("attributes/default.rb") }
+    it { is_expected.to violate_rule.in("recipes/default.rb") }
   end
 end