foodcritic 11.1.0 → 11.2.0

data/spec/functional/fc016_spec.rb

@@ -9,7 +9,7 @@ describe "FC016" do
 
       attribute :name, String, name_attribute: true
     EOH
-    it { is_expected.to_not violate_rule("FC016") }
+    it { is_expected.to_not violate_rule }
   end
 
   context "with a cookbook with a LWRP that includes a non-DSL default_action" do
@@ -23,7 +23,7 @@ describe "FC016" do
 
       attribute :name, String, name_attribute: true
     EOH
-    it { is_expected.to_not violate_rule("FC016") }
+    it { is_expected.to_not violate_rule }
   end
 
   context "with a cookbook with a LWRP that does not include a default_action" do
@@ -32,7 +32,7 @@ describe "FC016" do
 
       attribute :name, String, name_attribute: true
     EOH
-    it { is_expected.to violate_rule("FC016") }
+    it { is_expected.to violate_rule }
   end
 
   context "with a custom resource that includes a property" do
@@ -43,7 +43,7 @@ describe "FC016" do
         cookbook_file "/etc/something"
       end
     EOH
-    it { is_expected.to_not violate_rule("FC016") }
+    it { is_expected.to_not violate_rule }
   end
 
   context "with a custom resource that includes only an action" do
@@ -52,6 +52,6 @@ describe "FC016" do
         cookbook_file "/etc/something"
       end
     EOH
-    it { is_expected.to_not violate_rule("FC016") }
+    it { is_expected.to_not violate_rule }
   end
 end

data/spec/functional/fc028_spec.rb

@@ -3,91 +3,91 @@ require "spec_helper"
 describe "FC028" do
   context "with a cookbook with a single recipe that calls platform? without parentheses for a single platform" do
     recipe_file "platform? 'ubuntu'"
-    it { is_expected.not_to violate_rule("FC028") }
+    it { is_expected.not_to violate_rule }
   end
 
   context "with a cookbook with a single recipe that calls platform? without parentheses for two platforms" do
     recipe_file "platform?('ubuntu','windows')"
-    it { is_expected.not_to violate_rule("FC028") }
+    it { is_expected.not_to violate_rule }
   end
 
   context "with a cookbook with a single recipe that calls platform? with parentheses for a single platform" do
     recipe_file "platform?('ubuntu')"
-    it { is_expected.not_to violate_rule("FC028") }
+    it { is_expected.not_to violate_rule }
   end
 
   context "with a cookbook with a single recipe that calls platform? with parentheses for two platforms" do
     recipe_file "platform?('ubuntu', 'windows')"
-    it { is_expected.not_to violate_rule("FC028") }
+    it { is_expected.not_to violate_rule }
   end
 
   context "with a cookbook with a single recipe that compares a value against node.platform" do
     recipe_file "node.platform == 'ubuntu'"
-    it { is_expected.not_to violate_rule("FC028") }
+    it { is_expected.not_to violate_rule }
   end
 
   context "with a cookbook with a single recipe that uses checks a value against node.platform" do
     recipe_file "node.platform == 'ubuntu'"
-    it { is_expected.not_to violate_rule("FC028") }
+    it { is_expected.not_to violate_rule }
   end
 
   context "with a cookbook with a single recipe that calls node.platform? without a parentheses" do
     recipe_file "node.platform? 'ubuntu'"
-    it { is_expected.to violate_rule("FC028") }
+    it { is_expected.to violate_rule }
   end
 
   context "with a cookbook with a single recipe that calls node.platform? with a parentheses" do
     recipe_file "node.platform?('ubuntu')"
-    it { is_expected.to violate_rule("FC028") }
+    it { is_expected.to violate_rule }
   end
 
   context "with a cookbook with a single recipe that calls node.platform? with a parentheses for 2 platforms" do
     recipe_file "node.platform?('ubuntu', 'windows')"
-    it { is_expected.to violate_rule("FC028") }
+    it { is_expected.to violate_rule }
   end
 
   context "with a cookbook with a single recipe that calls platform_family? without parentheses for a single platform family" do
     recipe_file "platform_family? 'debian'"
-    it { is_expected.not_to violate_rule("FC028") }
+    it { is_expected.not_to violate_rule }
   end
 
   context "with a cookbook with a single recipe that calls platform_family? without parentheses for two plaform families" do
     recipe_file "platform_family?('debian','windows')"
-    it { is_expected.not_to violate_rule("FC028") }
+    it { is_expected.not_to violate_rule }
   end
 
   context "with a cookbook with a single recipe that calls platform_family? with parentheses for a single plaform family" do
     recipe_file "platform_family?('debian')"
-    it { is_expected.not_to violate_rule("FC028") }
+    it { is_expected.not_to violate_rule }
   end
 
   context "with a cookbook with a single recipe that calls platform_family? with parentheses for two plaform families" do
     recipe_file "platform_family?('debian', 'windows')"
-    it { is_expected.not_to violate_rule("FC028") }
+    it { is_expected.not_to violate_rule }
   end
 
   context "with a cookbook with a single recipe that compares a value against node.platform_family" do
     recipe_file "node.platform_family == 'debian'"
-    it { is_expected.not_to violate_rule("FC028") }
+    it { is_expected.not_to violate_rule }
   end
 
   context "with a cookbook with a single recipe that uses checks a value against node.platform_family" do
     recipe_file "node.platform_family == 'debian'"
-    it { is_expected.not_to violate_rule("FC028") }
+    it { is_expected.not_to violate_rule }
   end
 
   context "with a cookbook with a single recipe that calls node.platform_family? without a parentheses" do
     recipe_file "node.platform_family? 'debian'"
-    it { is_expected.to violate_rule("FC028") }
+    it { is_expected.to violate_rule }
   end
 
   context "with a cookbook with a single recipe that calls node.platform_family? with a parentheses" do
     recipe_file "node.platform_family?('debian')"
-    it { is_expected.to violate_rule("FC028") }
+    it { is_expected.to violate_rule }
   end
 
   context "with a cookbook with a single recipe that calls node.platform_family? with a parentheses for 2 plaform families" do
     recipe_file "node.platform_family?('debian', 'windows')"
-    it { is_expected.to violate_rule("FC028") }
+    it { is_expected.to violate_rule }
   end
 end

data/spec/functional/fc029_spec.rb

@@ -3,31 +3,31 @@ require "spec_helper"
 describe "FC029" do
   context "with a cookbook with a metadata file that doesn't contain the recipe keyword" do
     metadata_file("name 'example'")
-    it { is_expected.not_to violate_rule("FC029") }
+    it { is_expected.not_to violate_rule }
   end
 
   context "with a cookbook with a metadata file that contains contain the recipe keyword with the cookbook name only" do
     metadata_file("name 'example'\nrecipe 'example', 'Installs Example'")
-    it { is_expected.not_to violate_rule("FC029") }
+    it { is_expected.not_to violate_rule }
   end
 
   context "with a cookbook with a metadata file that contains the recipe keyword with the cookbook::recipe format name" do
     metadata_file("name 'example'\nrecipe 'example::default', 'Installs Example'")
-    it { is_expected.not_to violate_rule("FC029") }
+    it { is_expected.not_to violate_rule }
   end
 
   context "with a cookbook with a metadata file that contains the recipe keyword and lacks the cookbook name" do
     metadata_file("name 'example'\nrecipe 'default', 'Installs Example'")
-    it { is_expected.to violate_rule("FC029") }
+    it { is_expected.to violate_rule }
   end
 
   context "with a cookbook with a metadata file that contains the recipe keyword and stores full recipe name as a var" do
     metadata_file("name 'example'\nvar = 'example::default'\nrecipe my_var, 'Installs Example'")
-    it { is_expected.not_to violate_rule("FC029") }
+    it { is_expected.not_to violate_rule }
   end
 
   context "with a cookbook with a metadata file that contains the recipe keyword and stores part of the recipe name as a var" do
     metadata_file('name "example"\nvar = "example"\nrecipe "#{my_var}::default", "Installs Example"')
-    it { is_expected.not_to violate_rule("FC029") }
+    it { is_expected.not_to violate_rule }
   end
 end

data/spec/functional/fc031_spec.rb

@@ -4,11 +4,11 @@ describe "FC031" do
   context "with a cookbook with a metadata file" do
     metadata_file
     recipe_file
-    it { is_expected.to_not violate_rule("FC031") }
+    it { is_expected.to_not violate_rule }
   end
 
   context "with a cookbook without a metadata file" do
     recipe_file
-    it { is_expected.to violate_rule("FC031") }
+    it { is_expected.to violate_rule }
   end
 end

data/spec/functional/fc038_spec.rb

@@ -0,0 +1,23 @@
+require "spec_helper"
+
+describe "FC038" do
+  context "on chef 12.16.42 with a cookbook that locks an apt_package" do
+    foodcritic_command("--chef-version", "12.16.42", "--no-progress", ".")
+    recipe_file <<-EOH
+    apt_package 'foo' do
+      action :lock
+    end
+    EOH
+    it { is_expected.not_to violate_rule }
+  end
+
+  context "on chef 12.15.19 with a cookbook that locks an apt_package" do
+    foodcritic_command("--chef-version", "12.15.19", "--no-progress", ".")
+    recipe_file <<-EOH
+    apt_package 'foo' do
+      action :lock
+    end
+    EOH
+    it { is_expected.to violate_rule }
+  end
+end

data/spec/functional/fc042_spec.rb

@@ -3,11 +3,11 @@ require "spec_helper"
 describe "FC042" do
   context "with a cookbook with a single recipe that uses require_recipe" do
     recipe_file "require_recipe 'my_recipe::default'"
-    it { is_expected.to violate_rule("FC042") }
+    it { is_expected.to violate_rule }
   end
 
   context "with a cookbook with a single recipe that uses include_recipe" do
     recipe_file "include_recipe 'my_recipe::default'"
-    it { is_expected.not_to violate_rule("FC042") }
+    it { is_expected.not_to violate_rule }
   end
 end

data/spec/functional/fc043_spec.rb

@@ -0,0 +1,28 @@
+require "spec_helper"
+
+describe "FC043" do
+  context "with a cookbook that has no notifications" do
+    recipe_file <<-EOH
+      cookbook_file "something"
+    EOH
+    it { is_expected.not_to violate_rule }
+  end
+
+  context "with a cookbook with a resource that notifies a service to restart" do
+    recipe_file <<-EOH
+    template "/etc/apache.conf" do
+      notifies :start, "service[apache]"
+    end
+    EOH
+    it { is_expected.not_to violate_rule }
+  end
+
+  context "with a cookbook with a resource that uses the old notification syntax" do
+    recipe_file <<-EOH
+    template "/etc/www/configures-apache.conf" do
+      notifies :restart, resources(:service => "apache")
+    end
+    EOH
+    it { is_expected.to violate_rule }
+  end
+end

data/spec/functional/fc045_spec.rb

@@ -3,16 +3,16 @@ require "spec_helper"
 describe "FC045" do
   context "with a cookbook with a metadata file that includes the name keyword" do
     metadata_file "name 'food'"
-    it { is_expected.to_not violate_rule("FC045") }
+    it { is_expected.to_not violate_rule }
   end
 
   context "with a cookbook with a metadata file that doesn't include the name keyword" do
     metadata_file
-    it { is_expected.to violate_rule("FC045") }
+    it { is_expected.to violate_rule }
   end
 
   context "with a cookbook without a metadata file" do
     recipe_file
-    it { is_expected.to_not violate_rule("FC045") }
+    it { is_expected.to_not violate_rule }
   end
 end

data/spec/functional/fc052_spec.rb

@@ -3,11 +3,11 @@ require "spec_helper"
 describe "FC052" do
   context "with a cookbook with a metadata file that does contain the suggests keyword" do
     metadata_file "suggests 'runit'"
-    it { is_expected.to violate_rule("FC052") }
+    it { is_expected.to violate_rule }
   end
 
   context "with a cookbook with a metadata file that does not contain the suggests keyword" do
     metadata_file
-    it { is_expected.to_not violate_rule("FC052") }
+    it { is_expected.to_not violate_rule }
   end
 end

data/spec/functional/fc053_spec.rb

@@ -3,11 +3,11 @@ require "spec_helper"
 describe "FC053" do
   context "with a cookbook with a metadata file that does contain the recommends keyword" do
     metadata_file "recommends 'runit'"
-    it { is_expected.to violate_rule("FC053") }
+    it { is_expected.to violate_rule }
   end
 
   context "with a cookbook with a metadata file that does not contain the recommends keyword" do
     metadata_file
-    it { is_expected.to_not violate_rule("FC053") }
+    it { is_expected.to_not violate_rule }
   end
 end

data/spec/functional/fc055_spec.rb

@@ -3,16 +3,16 @@ require "spec_helper"
 describe "FC055" do
   context "with a cookbook with a metadata file that does not specify a maintainer" do
     metadata_file "name 'my_cookbook'"
-    it { is_expected.to violate_rule("FC055") }
+    it { is_expected.to violate_rule }
   end
 
   context "with a cookbook with a metadata file that specifies a maintainer" do
     metadata_file "maintainer 'Some Person'"
-    it { is_expected.to_not violate_rule("FC055") }
+    it { is_expected.to_not violate_rule }
   end
 
   context "with a cookbook with a metadata file that specifies a maintainer as an expression" do
     metadata_file("maintainer an(expression)")
-    it { is_expected.to_not violate_rule("FC055") }
+    it { is_expected.to_not violate_rule }
   end
 end

data/spec/functional/fc056_spec.rb

@@ -3,16 +3,16 @@ require "spec_helper"
 describe "FC056" do
   context "with a cookbook with a metadata file that does not specify a maintainer_email" do
     metadata_file
-    it { is_expected.to violate_rule("FC056") }
+    it { is_expected.to violate_rule }
   end
 
   context "with a cookbook with a metadata file that specifies a maintainer_email" do
     metadata_file "maintainer_email 'foo@example.com'"
-    it { is_expected.to_not violate_rule("FC056") }
+    it { is_expected.to_not violate_rule }
   end
 
   context "with a cookbook with a metadata file that specifies a maintainer_email as an expression" do
     metadata_file("maintainer_email an(expression)")
-    it { is_expected.to_not violate_rule("FC056") }
+    it { is_expected.to_not violate_rule }
   end
 end

data/spec/functional/fc057_spec.rb

@@ -0,0 +1,62 @@
+require "spec_helper"
+
+describe "FC057" do
+  context "with a cookbook with a library provider with use_inline_resources" do
+    library_file <<-EOF
+    class MyResources
+      class Site < Chef::Resource::LWRPBase
+        provides :site
+        resource_name :site
+        actions :create
+        attribute :name, :kind_of => String, :name_attribute => true
+      end
+    end
+
+    class MyProviders
+      class Site < Chef::Provider::LWRPBase
+        provides :site
+
+        use_inline_resources
+
+        action :create do
+          file "/tmp/foo.txt"
+        end
+      end
+    end
+    EOF
+    it { is_expected.not_to violate_rule }
+  end
+
+  context "with a cookbook with a library provider without use_inline_resources" do
+    library_file <<-EOF
+    class MyResources
+      class Site < Chef::Resource::LWRPBase
+        provides :site
+        resource_name :site
+        actions :create
+        attribute :name, :kind_of => String, :name_attribute => true
+      end
+    end
+
+    class MyProviders
+      class Site < Chef::Provider::LWRPBase
+        provides :site
+
+        action :create do
+          file "/tmp/foo.txt"
+        end
+      end
+    end
+    EOF
+    it { is_expected.to violate_rule }
+  end
+
+  context "with a cookbook with plain old library file" do
+    library_file <<-EOF
+    def something
+      puts "I'm just a method"
+    end
+    EOF
+    it { is_expected.not_to violate_rule }
+  end
+end

data/spec/functional/fc058_spec.rb

@@ -0,0 +1,102 @@
+require "spec_helper"
+
+describe "FC058" do
+  context "with a cookbook with a library provider with use_inline_resources and uses def action_create" do
+    library_file <<-EOF
+    class MyResources
+      class Site < Chef::Resource::LWRPBase
+        provides :site
+        resource_name :site
+        actions :create
+        attribute :name, :kind_of => String, :name_attribute => true
+      end
+    end
+
+    class MyProviders
+      class Site < Chef::Provider::LWRPBase
+        provides :site
+
+        use_inline_resources
+
+        def action_create
+          file "/tmp/foo.txt"
+        end
+      end
+    end
+    EOF
+    it { is_expected.to violate_rule }
+  end
+
+  context "with a cookbook with a library provider without use_inline_resources and uses def action_create" do
+    library_file <<-EOF
+    class MyResources
+      class Site < Chef::Resource::LWRPBase
+        provides :site
+        resource_name :site
+        actions :create
+        attribute :name, :kind_of => String, :name_attribute => true
+      end
+    end
+
+    class MyProviders
+      class Site < Chef::Provider::LWRPBase
+        provides :site
+
+        def action_create
+          file "/tmp/foo.txt"
+        end
+      end
+    end
+    EOF
+    it { is_expected.to_not violate_rule }
+  end
+
+  context "with a cookbook with a cookbook that contains a library provider with use_inline_resources" do
+    library_file <<-EOF
+    class MyResources
+      class Site < Chef::Resource::LWRPBase
+        provides :site
+        resource_name :site
+        actions :create
+        attribute :name, :kind_of => String, :name_attribute => true
+      end
+    end
+
+    class MyProviders
+      class Site < Chef::Provider::LWRPBase
+        provides :site
+        use_inline_resources
+
+        action :create do
+          file "/tmp/foo.txt"
+        end
+      end
+    end
+    EOF
+    it { is_expected.not_to violate_rule }
+  end
+
+  context "with a cookbook with a library provider without use_inline_resources" do
+    library_file <<-EOF
+    class MyResources
+      class Site < Chef::Resource::LWRPBase
+        provides :site
+        resource_name :site
+        actions :create
+        attribute :name, :kind_of => String, :name_attribute => true
+      end
+    end
+
+    class MyProviders
+      class Site < Chef::Provider::LWRPBase
+        provides :site
+
+        action :create do
+          file "/tmp/foo.txt"
+        end
+      end
+    end
+    EOF
+    it { is_expected.not_to violate_rule }
+  end
+end