foodcritic 11.0.0 → 11.1.0

data/spec/regression/expected/dynect.txt

@@ -28,3 +28,7 @@ FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
 FC067: Ensure at least one platform supported in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
 FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1
+FC085: Resource using new_resource.updated_by_last_action to converge resource: ./providers/rr.rb:54
+FC085: Resource using new_resource.updated_by_last_action to converge resource: ./providers/rr.rb:75
+FC085: Resource using new_resource.updated_by_last_action to converge resource: ./providers/rr.rb:90
+FC085: Resource using new_resource.updated_by_last_action to converge resource: ./providers/rr.rb:98

data/spec/regression/expected/firewall.txt

@@ -11,3 +11,6 @@ FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
 FC074: LWRP should use DSL to define resource's default action: ./resources/default.rb:1
 FC074: LWRP should use DSL to define resource's default action: ./resources/rule.rb:1
 FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1
+FC085: Resource using new_resource.updated_by_last_action to converge resource: ./providers/rule_ufw.rb:78
+FC085: Resource using new_resource.updated_by_last_action to converge resource: ./providers/ufw.rb:31
+FC085: Resource using new_resource.updated_by_last_action to converge resource: ./providers/ufw.rb:41

data/spec/regression/expected/gunicorn.txt

@@ -8,3 +8,6 @@ FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
 FC074: LWRP should use DSL to define resource's default action: ./resources/config.rb:1
 FC074: LWRP should use DSL to define resource's default action: ./resources/install.rb:1
 FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1
+FC085: Resource using new_resource.updated_by_last_action to converge resource: ./providers/config.rb:48
+FC085: Resource using new_resource.updated_by_last_action to converge resource: ./providers/config.rb:56
+FC085: Resource using new_resource.updated_by_last_action to converge resource: ./providers/install.rb:31

data/spec/regression/expected/homebrew.txt

@@ -7,3 +7,4 @@ FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
 FC074: LWRP should use DSL to define resource's default action: ./resources/tap.rb:1
 FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1
+FC087: Library maps provider with deprecated Chef::Platform.set: ./libraries/homebrew_package.rb:82

data/spec/regression/expected/jetty.txt

@@ -10,4 +10,4 @@ FC065: Ensure source_url is set in metadata: ./metadata.rb:1
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
 FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1
-FC082: node.set or node.set_unless used to set node attributes: ./recipes/cargo.rb:38
+FC082: Deprecated node.set or node.set_unless used to set node attributes: ./recipes/cargo.rb:38

data/spec/regression/expected/libarchive.txt

@@ -4,3 +4,4 @@ FC065: Ensure source_url is set in metadata: ./metadata.rb:1
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
 FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1
+FC085: Resource using new_resource.updated_by_last_action to converge resource: ./providers/file.rb:25

data/spec/regression/expected/maven.txt

@@ -8,3 +8,4 @@ FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
 FC074: LWRP should use DSL to define resource's default action: ./resources/default.rb:1
 FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1
+FC085: Resource using new_resource.updated_by_last_action to converge resource: ./providers/default.rb:56

data/spec/regression/expected/mysql.txt

@@ -12,7 +12,7 @@ FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
 FC072: Metadata should not contain "attribute" keyword: ./metadata.rb:1
 FC075: Cookbook uses node.save to save partial node data to the chef-server mid-run: ./recipes/server.rb:42
 FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1
-FC082: node.set or node.set_unless used to set node attributes: ./recipes/ruby.rb:28
-FC082: node.set or node.set_unless used to set node attributes: ./recipes/server.rb:39
-FC082: node.set or node.set_unless used to set node attributes: ./recipes/server.rb:40
-FC082: node.set or node.set_unless used to set node attributes: ./recipes/server.rb:41
+FC082: Deprecated node.set or node.set_unless used to set node attributes: ./recipes/ruby.rb:28
+FC082: Deprecated node.set or node.set_unless used to set node attributes: ./recipes/server.rb:39
+FC082: Deprecated node.set or node.set_unless used to set node attributes: ./recipes/server.rb:40
+FC082: Deprecated node.set or node.set_unless used to set node attributes: ./recipes/server.rb:41

data/spec/regression/expected/openssh.txt

@@ -3,4 +3,4 @@ FC065: Ensure source_url is set in metadata: ./metadata.rb:1
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
 FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1
-FC082: node.set or node.set_unless used to set node attributes: ./recipes/default.rb:63
+FC082: Deprecated node.set or node.set_unless used to set node attributes: ./recipes/default.rb:63

data/spec/regression/expected/partial_search.txt

@@ -4,3 +4,4 @@ FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
 FC067: Ensure at least one platform supported in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
 FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1
+FC084: Deprecated Chef::REST class used: ./libraries/partial_search.rb:36

data/spec/regression/expected/perl.txt

@@ -10,3 +10,4 @@ FC065: Ensure source_url is set in metadata: ./metadata.rb:1
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
 FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1
+FC083: Execute resource using deprecated 'path' property: ./definitions/cpan_module.rb:31

data/spec/regression/expected/postfix.txt

@@ -5,4 +5,4 @@ FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
 FC072: Metadata should not contain "attribute" keyword: ./metadata.rb:1
 FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1
-FC082: node.set or node.set_unless used to set node attributes: ./recipes/client.rb:40
+FC082: Deprecated node.set or node.set_unless used to set node attributes: ./recipes/client.rb:40

data/spec/regression/expected/rsync.txt

@@ -9,3 +9,4 @@ FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
 FC071: Missing LICENSE file: examples/LICENSE:1
 FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1
+FC085: Resource using new_resource.updated_by_last_action to converge resource: ./providers/serve.rb:62

data/spec/regression/expected/rsyslog.txt

@@ -8,4 +8,4 @@ FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
 FC072: Metadata should not contain "attribute" keyword: ./metadata.rb:1
 FC075: Cookbook uses node.save to save partial node data to the chef-server mid-run: ./recipes/server.rb:23
 FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1
-FC082: node.set or node.set_unless used to set node attributes: ./recipes/server.rb:22
+FC082: Deprecated node.set or node.set_unless used to set node attributes: ./recipes/server.rb:22

data/spec/regression/expected/smokeping.txt

@@ -2,4 +2,6 @@ FC059: LWRP provider does not declare use_inline_resources: ./providers/target.r
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
 FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1
-FC082: node.set or node.set_unless used to set node attributes: ./recipes/example_slave.rb:19
+FC082: Deprecated node.set or node.set_unless used to set node attributes: ./recipes/example_slave.rb:19
+FC085: Resource using new_resource.updated_by_last_action to converge resource: ./providers/target.rb:53
+FC085: Resource using new_resource.updated_by_last_action to converge resource: ./providers/target.rb:63

data/spec/regression/expected/sql_server.txt

@@ -4,4 +4,4 @@ FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
 FC075: Cookbook uses node.save to save partial node data to the chef-server mid-run: ./recipes/server.rb:28
 FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1
-FC082: node.set or node.set_unless used to set node attributes: ./recipes/server.rb:26
+FC082: Deprecated node.set or node.set_unless used to set node attributes: ./recipes/server.rb:26

data/spec/regression/expected/sudo.txt

@@ -7,3 +7,5 @@ FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
 FC072: Metadata should not contain "attribute" keyword: ./metadata.rb:1
 FC074: LWRP should use DSL to define resource's default action: ./resources/default.rb:1
 FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1
+FC085: Resource using new_resource.updated_by_last_action to converge resource: ./providers/default.rb:98
+FC085: Resource using new_resource.updated_by_last_action to converge resource: ./providers/default.rb:112

data/spec/regression/expected/transmission.txt

@@ -9,3 +9,5 @@ FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
 FC067: Ensure at least one platform supported in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
 FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1
+FC085: Resource using new_resource.updated_by_last_action to converge resource: ./providers/torrent_file.rb:53
+FC085: Resource using new_resource.updated_by_last_action to converge resource: ./providers/torrent_file.rb:58

data/spec/regression/expected/ufw.txt

@@ -8,4 +8,4 @@ FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
 FC072: Metadata should not contain "attribute" keyword: ./metadata.rb:1
 FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1
-FC082: node.set or node.set_unless used to set node attributes: ./recipes/default.rb:34
+FC082: Deprecated node.set or node.set_unless used to set node attributes: ./recipes/default.rb:34

data/spec/regression/expected/users.txt

@@ -6,5 +6,7 @@ FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
 FC074: LWRP should use DSL to define resource's default action: ./resources/manage.rb:1
 FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1
-FC080: User resource uses supports property: ./providers/manage.rb:87
-FC080: User resource uses supports property: ./providers/manage.rb:89
+FC080: User resource uses deprecated supports property: ./providers/manage.rb:87
+FC080: User resource uses deprecated supports property: ./providers/manage.rb:89
+FC085: Resource using new_resource.updated_by_last_action to converge resource: ./providers/manage.rb:39
+FC085: Resource using new_resource.updated_by_last_action to converge resource: ./providers/manage.rb:143

data/spec/regression/expected/xml.txt

@@ -3,4 +3,4 @@ FC065: Ensure source_url is set in metadata: ./metadata.rb:1
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
 FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1
-FC082: node.set or node.set_unless used to set node attributes: ./recipes/ruby.rb:27
+FC082: Deprecated node.set or node.set_unless used to set node attributes: ./recipes/ruby.rb:27

data/spec/regression/expected/yum.txt

@@ -15,3 +15,5 @@ FC072: Metadata should not contain "attribute" keyword: ./metadata.rb:1
 FC074: LWRP should use DSL to define resource's default action: ./resources/key.rb:1
 FC074: LWRP should use DSL to define resource's default action: ./resources/repository.rb:1
 FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1
+FC085: Resource using new_resource.updated_by_last_action to converge resource: ./providers/key.rb:76
+FC085: Resource using new_resource.updated_by_last_action to converge resource: ./providers/repository.rb:41

data/spec/unit/command_line_spec.rb

@@ -119,4 +119,18 @@ describe FoodCritic::CommandLine do
       expect(FoodCritic::CommandLine.new(["--no-context", "."]).show_context?).to be_falsey
     end
   end
+
+  describe ":rule_file" do
+    it "is unset if -r/--rule-file is not specified" do
+      expect(FoodCritic::CommandLine.new(["."]).options[:rule_file].nil?).to be_truthy
+    end
+
+    it "is equal to the provided path if -r is set and path is specified" do
+      expect(FoodCritic::CommandLine.new(["-r", "example", "."]).options[:rule_file]).to eq "example"
+    end
+
+    it "is equal to the provided path if --rule-file is set and path is specified" do
+      expect(FoodCritic::CommandLine.new(["--rule-file", "example", "."]).options[:rule_file]).to eq "example"
+    end
+  end
 end

data/spec/unit/linter_spec.rb

@@ -12,7 +12,7 @@ describe FoodCritic::Linter do
 
   describe "chef version" do
     it "should be the latest stable version of Chef" do
-      expect(FoodCritic::Linter::DEFAULT_CHEF_VERSION).to eq "12.19.36"
+      expect(FoodCritic::Linter::DEFAULT_CHEF_VERSION).to eq "12.20.3"
     end
   end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: foodcritic
 version: !ruby/object:Gem::Version
-  version: 11.0.0
+  version: 11.1.0
 platform: ruby
 authors:
 - Andrew Crump
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-04-24 00:00:00.000000000 Z
+date: 2017-05-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: cucumber-core
@@ -179,6 +179,7 @@ files:
 - chef_dsl_metadata/chef_12.17.44.json
 - chef_dsl_metadata/chef_12.18.31.json
 - chef_dsl_metadata/chef_12.19.36.json
+- chef_dsl_metadata/chef_12.20.3.json
 - chef_dsl_metadata/chef_12.6.0.json
 - chef_dsl_metadata/chef_12.7.2.json
 - chef_dsl_metadata/chef_12.8.1.json
@@ -330,6 +331,10 @@ files:
 - lib/foodcritic/rules/fc083.rb
 - lib/foodcritic/rules/fc084.rb
 - lib/foodcritic/rules/fc085.rb
+- lib/foodcritic/rules/fc086.rb
+- lib/foodcritic/rules/fc087.rb
+- lib/foodcritic/rules/fc088.rb
+- lib/foodcritic/rules/fc089.rb
 - lib/foodcritic/template.rb
 - lib/foodcritic/version.rb
 - lib/foodcritic/xml.rb
@@ -378,6 +383,10 @@ files:
 - spec/functional/fc083_spec.rb
 - spec/functional/fc084_spec.rb
 - spec/functional/fc085_spec.rb
+- spec/functional/fc086_spec.rb
+- spec/functional/fc087_spec.rb
+- spec/functional/fc088_spec.rb
+- spec/functional/fc089_spec.rb
 - spec/functional/root_aliases_spec.rb
 - spec/regression/cookbooks.txt
 - spec/regression/expected/activemq.txt
@@ -494,5 +503,5 @@ rubyforge_project:
 rubygems_version: 2.6.11
 signing_key: 
 specification_version: 4
-summary: foodcritic-11.0.0
+summary: foodcritic-11.1.0
 test_files: []