foodcritic 11.0.0 → 11.1.0

data/lib/foodcritic/command_line.rb

@@ -46,6 +46,10 @@ module FoodCritic
                 "of Chef.") do |c|
           @options[:chef_version] = c
         end
+        opts.on("-r", "--rule-file PATH",
+                "Specify file with rules to be used or ignored ") do |c|
+          @options[:rule_file] = c
+        end
         opts.on("-B", "--cookbook-path PATH",
                 "Cookbook path(s) to check.") do |b|
           @options[:cookbook_paths] << b

data/lib/foodcritic/linter.rb

@@ -9,7 +9,7 @@ module FoodCritic
 
     # The default version that will be used to determine relevant rules. This
     # can be over-ridden at the command line with the `--chef-version` option.
-    DEFAULT_CHEF_VERSION = "12.19.36"
+    DEFAULT_CHEF_VERSION = "12.20.3"
     attr_reader :chef_version
 
     # Perform a lint check. This method is intended for use by the command-line
@@ -201,7 +201,7 @@ module FoodCritic
 
     def cookbook_tags(file)
       tags = []
-      fc_file = "#{cookbook_dir(file)}/.foodcritic"
+      fc_file = @options[:rule_file] || "#{cookbook_dir(file)}/.foodcritic"
       if File.exist? fc_file
         begin
           tag_text = File.read fc_file

data/lib/foodcritic/rules/fc080.rb

@@ -1,4 +1,4 @@
-rule "FC080", "User resource uses supports property" do
+rule "FC080", "User resource uses deprecated supports property" do
   tags %w{deprecated chef13}
   recipe do |ast|
     find_resources(ast, type: "user").xpath(%q{descendant::fcall[ident/@value='supports']|descendant::command[ident/@value='supports']})

data/lib/foodcritic/rules/fc081.rb

@@ -1,5 +1,5 @@
-rule "FC081", "Cookbook depends on the partial_search cookbook" do
-  tags %w{chef12}
+rule "FC081", "Cookbook depends on the deprecated partial_search cookbook" do
+  tags %w{chef12 deprecated}
   metadata do |ast, filename|
     [file_match(filename)] if declared_dependencies(ast).include?("partial_search")
   end

data/lib/foodcritic/rules/fc082.rb

@@ -1,4 +1,4 @@
-rule "FC082", "node.set or node.set_unless used to set node attributes" do
+rule "FC082", "Deprecated node.set or node.set_unless used to set node attributes" do
   tags %w{chef14 deprecated}
   def node_sets(ast)
     ast.xpath('//call[(vcall|var_ref)/ident/@value="node"]

data/lib/foodcritic/rules/fc083.rb

@@ -1,4 +1,4 @@
-rule "FC083", "Execute resource using 'path' property" do
+rule "FC083", "Execute resource using deprecated 'path' property" do
   tags %w{deprecated chef12}
   recipe do |ast|
     find_resources(ast, type: "execute").xpath('(.//command|.//fcall)[ident/@value="path"]')

data/lib/foodcritic/rules/fc086.rb

@@ -0,0 +1,10 @@
+rule "FC086", "Use databag helper methods to load data bag items" do
+  tags %w{style}
+  def old_dbag(ast)
+    ast.xpath('//const_path_ref/const[@value="EncryptedDataBagItem" or @value="DataBagItem"]/..//const[@value="Chef"]/../../..')
+  end
+
+  resource { |ast| old_dbag(ast) }
+  recipe { |ast| old_dbag(ast) }
+  library { |ast| old_dbag(ast) }
+end

data/lib/foodcritic/rules/fc087.rb

@@ -0,0 +1,7 @@
+rule "FC087", "Library maps provider with deprecated Chef::Platform.set" do
+  tags %w{chef13 deprecated}
+
+  library do |ast|
+    ast.xpath('//const_path_ref/const[@value="Platform"]/..//const[@value="Chef"]/../../../ident[@value="set"]')
+  end
+end

data/lib/foodcritic/rules/fc088.rb

@@ -0,0 +1,11 @@
+rule "FC088", "Prefer Mixlib::Shellout over deprecated Chef::Mixin::Command" do
+  tags %w{chef13 deprecated}
+
+  def includes_command(ast)
+    ast.xpath('//const_path_ref/const[@value="Command"]/..//const[@value="Mixin"]/..//const[@value="Chef"]')
+  end
+
+  resource { |ast| includes_command(ast) }
+  recipe { |ast| includes_command(ast) }
+  library { |ast| includes_command(ast) }
+end

data/lib/foodcritic/rules/fc089.rb

@@ -0,0 +1,11 @@
+rule "FC089", "Prefer Mixlib::Shellout over deprecated Chef::ShellOut" do
+  tags %w{chef13 deprecated}
+
+  def old_shellout(ast)
+    ast.xpath('//const_path_ref[var_ref/const[@value="Chef"]]/const[@value="ShellOut"]')
+  end
+
+  resource { |ast| old_shellout(ast) }
+  recipe { |ast| old_shellout(ast) }
+  library { |ast| old_shellout(ast) }
+end

data/lib/foodcritic/version.rb

@@ -1,4 +1,4 @@
 module FoodCritic
   # The current version of foodcritic
-  VERSION = "11.0.0"
+  VERSION = "11.1.0"
 end

data/spec/functional/fc086_spec.rb

@@ -0,0 +1,36 @@
+require "spec_helper"
+
+describe "FC086" do
+  context "with a cookbook with a recipe that uses Chef::EncryptedDataBagItem.load_secret" do
+    recipe_file 'Chef::EncryptedDataBagItem.load("users", "tsmith", key)'
+    it { is_expected.to violate_rule }
+  end
+
+  context "with a cookbook with a recipe that uses Chef::DataBagItem.load" do
+    recipe_file 'Chef::DataBagItem.load("users", "tsmith")'
+    it { is_expected.to violate_rule }
+  end
+
+  context "with a cookbook with a resource that uses Chef::EncryptedDataBagItem.load_secret" do
+    resource_file <<-EOF
+      action :create do
+        data = Chef::EncryptedDataBagItem.load("users", "tsmith", key)
+      end
+    EOF
+    it { is_expected.to violate_rule }
+  end
+
+  context "with a cookbook with a resource that uses Chef::EncryptedDataBagItem.load_secret" do
+    resource_file <<-EOF
+      action :create do
+        data = Chef::DataBagItem.load("users", "tsmith")
+      end
+    EOF
+    it { is_expected.to violate_rule }
+  end
+
+  context "with a cookbook with a resource that uses data_bag_item" do
+    recipe_file "data_bag_item('bag', 'item', IO.read('secret_file'))"
+    it { is_expected.not_to violate_rule }
+  end
+end

data/spec/functional/fc087_spec.rb

@@ -0,0 +1,29 @@
+require "spec_helper"
+
+describe "FC087" do
+  context "with a cookbook with a library that maps platforms with Chef::Platform.set" do
+    library_file <<-EOF
+    Chef::Platform.set platform: :amazon, resource: :mysql_chef_gem, provider: Chef::Provider::MysqlChefGem::Mysql
+    Chef::Platform.set platform: :centos, version: '< 7.0', resource: :mysql_chef_gem, provider: Chef::Provider::MysqlChefGem::Mysql
+    EOF
+    it { is_expected.to violate_rule }
+  end
+
+  context "with a cookbook with a library that includes Chef::Platform.foo" do
+    library_file <<-EOF
+    module AuditD
+      module Helper
+        def auditd_package_name_for(platform_family)
+          case platform_family
+          when 'rhel', 'fedora'
+            'audit'
+          else
+            'auditd'
+          end
+        end
+      end
+    end
+    EOF
+    it { is_expected.to_not violate_rule }
+  end
+end

data/spec/functional/fc088_spec.rb

@@ -0,0 +1,18 @@
+require "spec_helper"
+
+describe "FC088" do
+  context "with a cookbook with a library that uses Chef::Mixin::Command" do
+    library_file "include Chef::Mixin::Command"
+    it { is_expected.to violate_rule }
+  end
+
+  context "with a cookbook with a resource that uses Chef::Mixin::Command" do
+    resource_file "include Chef::Mixin::Command"
+    it { is_expected.to violate_rule }
+  end
+
+  context "with a cookbook with a resource that uses Bob::Mixin::Command" do
+    resource_file "include Bob::Mixin::Command"
+    it { is_expected.not_to violate_rule }
+  end
+end

data/spec/functional/fc089_spec.rb

@@ -0,0 +1,23 @@
+require "spec_helper"
+
+describe "FC089" do
+  context "with a cookbook with a library that uses Chef::ShellOut" do
+    library_file "include Chef::ShellOut"
+    it { is_expected.to violate_rule }
+  end
+
+  context "with a cookbook with a resource that uses Chef::ShellOut" do
+    resource_file "include Chef::ShellOut"
+    it { is_expected.to violate_rule }
+  end
+
+  context "with a cookbook with a resource that uses Miblib::Shellout" do
+    resource_file "include Mixlib::Shellout"
+    it { is_expected.not_to violate_rule }
+  end
+
+  context "with a cookbook with a resource that uses Chef::Mixin::ShellOut" do
+    resource_file "include Chef::Mixin::ShellOut"
+    it { is_expected.not_to violate_rule }
+  end
+end

data/spec/regression/expected/aix.txt

@@ -1,3 +1,3 @@
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
 FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1
-FC080: User resource uses supports property: ./recipes/default.rb:8
+FC080: User resource uses deprecated supports property: ./recipes/default.rb:8

data/spec/regression/expected/apt.txt

@@ -11,3 +11,7 @@ FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
 FC074: LWRP should use DSL to define resource's default action: ./resources/preference.rb:1
 FC074: LWRP should use DSL to define resource's default action: ./resources/repository.rb:1
 FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1
+FC085: Resource using new_resource.updated_by_last_action to converge resource: ./providers/preference.rb:26
+FC085: Resource using new_resource.updated_by_last_action to converge resource: ./providers/preference.rb:59
+FC085: Resource using new_resource.updated_by_last_action to converge resource: ./providers/repository.rb:87
+FC085: Resource using new_resource.updated_by_last_action to converge resource: ./providers/repository.rb:121

data/spec/regression/expected/aws.txt

@@ -15,6 +15,6 @@ FC075: Cookbook uses node.save to save partial node data to the chef-server mid-
 FC075: Cookbook uses node.save to save partial node data to the chef-server mid-run: ./providers/ebs_volume.rb:40
 FC075: Cookbook uses node.save to save partial node data to the chef-server mid-run: ./providers/ebs_volume.rb:60
 FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1
-FC082: node.set or node.set_unless used to set node attributes: ./providers/ebs_volume.rb:32
-FC082: node.set or node.set_unless used to set node attributes: ./providers/ebs_volume.rb:39
-FC082: node.set or node.set_unless used to set node attributes: ./providers/ebs_volume.rb:59
+FC082: Deprecated node.set or node.set_unless used to set node attributes: ./providers/ebs_volume.rb:32
+FC082: Deprecated node.set or node.set_unless used to set node attributes: ./providers/ebs_volume.rb:39
+FC082: Deprecated node.set or node.set_unless used to set node attributes: ./providers/ebs_volume.rb:59

data/spec/regression/expected/bluepill.txt

@@ -5,3 +5,9 @@ FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
 FC067: Ensure at least one platform supported in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
 FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1
+FC085: Resource using new_resource.updated_by_last_action to converge resource: ./providers/service.rb:52
+FC085: Resource using new_resource.updated_by_last_action to converge resource: ./providers/service.rb:59
+FC085: Resource using new_resource.updated_by_last_action to converge resource: ./providers/service.rb:66
+FC085: Resource using new_resource.updated_by_last_action to converge resource: ./providers/service.rb:78
+FC085: Resource using new_resource.updated_by_last_action to converge resource: ./providers/service.rb:85
+FC085: Resource using new_resource.updated_by_last_action to converge resource: ./providers/service.rb:93

data/spec/regression/expected/chef-client.txt

@@ -12,5 +12,5 @@ FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
 FC070: Ensure supports metadata defines valid platforms: ./metadata.rb:1
 FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1
-FC082: node.set or node.set_unless used to set node attributes: ./recipes/service.rb:59
-FC082: node.set or node.set_unless used to set node attributes: ./recipes/task.rb:49
+FC082: Deprecated node.set or node.set_unless used to set node attributes: ./recipes/service.rb:59
+FC082: Deprecated node.set or node.set_unless used to set node attributes: ./recipes/task.rb:49

data/spec/regression/expected/chef-vault.txt

@@ -2,3 +2,5 @@ FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
 FC067: Ensure at least one platform supported in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
 FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1
+FC085: Resource using new_resource.updated_by_last_action to converge resource: ./libraries/chef_vault_secret.rb:92
+FC086: Use databag helper methods to load data bag items: ./libraries/helpers.rb:39

data/spec/regression/expected/chef.txt

@@ -35,70 +35,70 @@ FC065: Ensure source_url is set in metadata: ./metadata.rb:1
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
 FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1
-FC082: node.set or node.set_unless used to set node attributes: ./recipes/bootstrap_server.rb:27
-FC082: node.set or node.set_unless used to set node attributes: ./recipes/bootstrap_server.rb:28
-FC082: node.set or node.set_unless used to set node attributes: ./recipes/bootstrap_server.rb:29
-FC082: node.set or node.set_unless used to set node attributes: ./recipes/bootstrap_server.rb:30
-FC082: node.set or node.set_unless used to set node attributes: ./recipes/bootstrap_server.rb:31
-FC082: node.set or node.set_unless used to set node attributes: ./recipes/bootstrap_server.rb:32
-FC082: node.set or node.set_unless used to set node attributes: ./recipes/bootstrap_server.rb:33
-FC082: node.set or node.set_unless used to set node attributes: ./recipes/bootstrap_server.rb:34
-FC082: node.set or node.set_unless used to set node attributes: ./recipes/bootstrap_server.rb:35
-FC082: node.set or node.set_unless used to set node attributes: ./recipes/bootstrap_server.rb:36
-FC082: node.set or node.set_unless used to set node attributes: ./recipes/bootstrap_server.rb:37
-FC082: node.set or node.set_unless used to set node attributes: ./recipes/bootstrap_server.rb:38
-FC082: node.set or node.set_unless used to set node attributes: ./recipes/bootstrap_server.rb:39
-FC082: node.set or node.set_unless used to set node attributes: ./recipes/client.rb:25
-FC082: node.set or node.set_unless used to set node attributes: ./recipes/client.rb:26
-FC082: node.set or node.set_unless used to set node attributes: ./recipes/client.rb:27
-FC082: node.set or node.set_unless used to set node attributes: ./recipes/client.rb:28
-FC082: node.set or node.set_unless used to set node attributes: ./recipes/client.rb:29
-FC082: node.set or node.set_unless used to set node attributes: ./recipes/client.rb:30
-FC082: node.set or node.set_unless used to set node attributes: ./recipes/client.rb:31
-FC082: node.set or node.set_unless used to set node attributes: ./recipes/client.rb:32
-FC082: node.set or node.set_unless used to set node attributes: ./recipes/client.rb:33
-FC082: node.set or node.set_unless used to set node attributes: ./recipes/client.rb:34
-FC082: node.set or node.set_unless used to set node attributes: ./recipes/client.rb:35
-FC082: node.set or node.set_unless used to set node attributes: ./recipes/client_service.rb:24
-FC082: node.set or node.set_unless used to set node attributes: ./recipes/client_service.rb:25
-FC082: node.set or node.set_unless used to set node attributes: ./recipes/client_service.rb:26
-FC082: node.set or node.set_unless used to set node attributes: ./recipes/client_service.rb:27
-FC082: node.set or node.set_unless used to set node attributes: ./recipes/client_service.rb:28
-FC082: node.set or node.set_unless used to set node attributes: ./recipes/client_service.rb:29
-FC082: node.set or node.set_unless used to set node attributes: ./recipes/client_service.rb:30
-FC082: node.set or node.set_unless used to set node attributes: ./recipes/client_service.rb:31
-FC082: node.set or node.set_unless used to set node attributes: ./recipes/client_service.rb:32
-FC082: node.set or node.set_unless used to set node attributes: ./recipes/client_service.rb:33
-FC082: node.set or node.set_unless used to set node attributes: ./recipes/client_service.rb:34
-FC082: node.set or node.set_unless used to set node attributes: ./recipes/server.rb:25
-FC082: node.set or node.set_unless used to set node attributes: ./recipes/server.rb:26
-FC082: node.set or node.set_unless used to set node attributes: ./recipes/server.rb:27
-FC082: node.set or node.set_unless used to set node attributes: ./recipes/server.rb:28
-FC082: node.set or node.set_unless used to set node attributes: ./recipes/server.rb:29
-FC082: node.set or node.set_unless used to set node attributes: ./recipes/server.rb:30
-FC082: node.set or node.set_unless used to set node attributes: ./recipes/server.rb:31
-FC082: node.set or node.set_unless used to set node attributes: ./recipes/server.rb:32
-FC082: node.set or node.set_unless used to set node attributes: ./recipes/server.rb:33
-FC082: node.set or node.set_unless used to set node attributes: ./recipes/server.rb:34
-FC082: node.set or node.set_unless used to set node attributes: ./recipes/server.rb:35
-FC082: node.set or node.set_unless used to set node attributes: ./recipes/server.rb:36
-FC082: node.set or node.set_unless used to set node attributes: ./recipes/server.rb:37
-FC082: node.set or node.set_unless used to set node attributes: ./recipes/server.rb:38
-FC082: node.set or node.set_unless used to set node attributes: ./recipes/server.rb:39
-FC082: node.set or node.set_unless used to set node attributes: ./recipes/server_proxy.rb:23
-FC082: node.set or node.set_unless used to set node attributes: ./recipes/server_proxy.rb:24
-FC082: node.set or node.set_unless used to set node attributes: ./recipes/server_proxy.rb:25
-FC082: node.set or node.set_unless used to set node attributes: ./recipes/server_proxy.rb:26
-FC082: node.set or node.set_unless used to set node attributes: ./recipes/server_proxy.rb:27
-FC082: node.set or node.set_unless used to set node attributes: ./recipes/server_proxy.rb:28
-FC082: node.set or node.set_unless used to set node attributes: ./recipes/server_proxy.rb:29
-FC082: node.set or node.set_unless used to set node attributes: ./recipes/server_proxy.rb:30
-FC082: node.set or node.set_unless used to set node attributes: ./recipes/server_proxy.rb:31
-FC082: node.set or node.set_unless used to set node attributes: ./recipes/server_proxy.rb:32
-FC082: node.set or node.set_unless used to set node attributes: ./recipes/server_proxy.rb:33
-FC082: node.set or node.set_unless used to set node attributes: ./recipes/server_proxy.rb:34
-FC082: node.set or node.set_unless used to set node attributes: ./recipes/server_proxy.rb:35
-FC082: node.set or node.set_unless used to set node attributes: ./recipes/server_proxy.rb:36
-FC082: node.set or node.set_unless used to set node attributes: ./recipes/server_proxy.rb:37
-FC082: node.set or node.set_unless used to set node attributes: ./recipes/server_proxy.rb:38
-FC082: node.set or node.set_unless used to set node attributes: ./recipes/server_proxy.rb:39
+FC082: Deprecated node.set or node.set_unless used to set node attributes: ./recipes/bootstrap_server.rb:27
+FC082: Deprecated node.set or node.set_unless used to set node attributes: ./recipes/bootstrap_server.rb:28
+FC082: Deprecated node.set or node.set_unless used to set node attributes: ./recipes/bootstrap_server.rb:29
+FC082: Deprecated node.set or node.set_unless used to set node attributes: ./recipes/bootstrap_server.rb:30
+FC082: Deprecated node.set or node.set_unless used to set node attributes: ./recipes/bootstrap_server.rb:31
+FC082: Deprecated node.set or node.set_unless used to set node attributes: ./recipes/bootstrap_server.rb:32
+FC082: Deprecated node.set or node.set_unless used to set node attributes: ./recipes/bootstrap_server.rb:33
+FC082: Deprecated node.set or node.set_unless used to set node attributes: ./recipes/bootstrap_server.rb:34
+FC082: Deprecated node.set or node.set_unless used to set node attributes: ./recipes/bootstrap_server.rb:35
+FC082: Deprecated node.set or node.set_unless used to set node attributes: ./recipes/bootstrap_server.rb:36
+FC082: Deprecated node.set or node.set_unless used to set node attributes: ./recipes/bootstrap_server.rb:37
+FC082: Deprecated node.set or node.set_unless used to set node attributes: ./recipes/bootstrap_server.rb:38
+FC082: Deprecated node.set or node.set_unless used to set node attributes: ./recipes/bootstrap_server.rb:39
+FC082: Deprecated node.set or node.set_unless used to set node attributes: ./recipes/client.rb:25
+FC082: Deprecated node.set or node.set_unless used to set node attributes: ./recipes/client.rb:26
+FC082: Deprecated node.set or node.set_unless used to set node attributes: ./recipes/client.rb:27
+FC082: Deprecated node.set or node.set_unless used to set node attributes: ./recipes/client.rb:28
+FC082: Deprecated node.set or node.set_unless used to set node attributes: ./recipes/client.rb:29
+FC082: Deprecated node.set or node.set_unless used to set node attributes: ./recipes/client.rb:30
+FC082: Deprecated node.set or node.set_unless used to set node attributes: ./recipes/client.rb:31
+FC082: Deprecated node.set or node.set_unless used to set node attributes: ./recipes/client.rb:32
+FC082: Deprecated node.set or node.set_unless used to set node attributes: ./recipes/client.rb:33
+FC082: Deprecated node.set or node.set_unless used to set node attributes: ./recipes/client.rb:34
+FC082: Deprecated node.set or node.set_unless used to set node attributes: ./recipes/client.rb:35
+FC082: Deprecated node.set or node.set_unless used to set node attributes: ./recipes/client_service.rb:24
+FC082: Deprecated node.set or node.set_unless used to set node attributes: ./recipes/client_service.rb:25
+FC082: Deprecated node.set or node.set_unless used to set node attributes: ./recipes/client_service.rb:26
+FC082: Deprecated node.set or node.set_unless used to set node attributes: ./recipes/client_service.rb:27
+FC082: Deprecated node.set or node.set_unless used to set node attributes: ./recipes/client_service.rb:28
+FC082: Deprecated node.set or node.set_unless used to set node attributes: ./recipes/client_service.rb:29
+FC082: Deprecated node.set or node.set_unless used to set node attributes: ./recipes/client_service.rb:30
+FC082: Deprecated node.set or node.set_unless used to set node attributes: ./recipes/client_service.rb:31
+FC082: Deprecated node.set or node.set_unless used to set node attributes: ./recipes/client_service.rb:32
+FC082: Deprecated node.set or node.set_unless used to set node attributes: ./recipes/client_service.rb:33
+FC082: Deprecated node.set or node.set_unless used to set node attributes: ./recipes/client_service.rb:34
+FC082: Deprecated node.set or node.set_unless used to set node attributes: ./recipes/server.rb:25
+FC082: Deprecated node.set or node.set_unless used to set node attributes: ./recipes/server.rb:26
+FC082: Deprecated node.set or node.set_unless used to set node attributes: ./recipes/server.rb:27
+FC082: Deprecated node.set or node.set_unless used to set node attributes: ./recipes/server.rb:28
+FC082: Deprecated node.set or node.set_unless used to set node attributes: ./recipes/server.rb:29
+FC082: Deprecated node.set or node.set_unless used to set node attributes: ./recipes/server.rb:30
+FC082: Deprecated node.set or node.set_unless used to set node attributes: ./recipes/server.rb:31
+FC082: Deprecated node.set or node.set_unless used to set node attributes: ./recipes/server.rb:32
+FC082: Deprecated node.set or node.set_unless used to set node attributes: ./recipes/server.rb:33
+FC082: Deprecated node.set or node.set_unless used to set node attributes: ./recipes/server.rb:34
+FC082: Deprecated node.set or node.set_unless used to set node attributes: ./recipes/server.rb:35
+FC082: Deprecated node.set or node.set_unless used to set node attributes: ./recipes/server.rb:36
+FC082: Deprecated node.set or node.set_unless used to set node attributes: ./recipes/server.rb:37
+FC082: Deprecated node.set or node.set_unless used to set node attributes: ./recipes/server.rb:38
+FC082: Deprecated node.set or node.set_unless used to set node attributes: ./recipes/server.rb:39
+FC082: Deprecated node.set or node.set_unless used to set node attributes: ./recipes/server_proxy.rb:23
+FC082: Deprecated node.set or node.set_unless used to set node attributes: ./recipes/server_proxy.rb:24
+FC082: Deprecated node.set or node.set_unless used to set node attributes: ./recipes/server_proxy.rb:25
+FC082: Deprecated node.set or node.set_unless used to set node attributes: ./recipes/server_proxy.rb:26
+FC082: Deprecated node.set or node.set_unless used to set node attributes: ./recipes/server_proxy.rb:27
+FC082: Deprecated node.set or node.set_unless used to set node attributes: ./recipes/server_proxy.rb:28
+FC082: Deprecated node.set or node.set_unless used to set node attributes: ./recipes/server_proxy.rb:29
+FC082: Deprecated node.set or node.set_unless used to set node attributes: ./recipes/server_proxy.rb:30
+FC082: Deprecated node.set or node.set_unless used to set node attributes: ./recipes/server_proxy.rb:31
+FC082: Deprecated node.set or node.set_unless used to set node attributes: ./recipes/server_proxy.rb:32
+FC082: Deprecated node.set or node.set_unless used to set node attributes: ./recipes/server_proxy.rb:33
+FC082: Deprecated node.set or node.set_unless used to set node attributes: ./recipes/server_proxy.rb:34
+FC082: Deprecated node.set or node.set_unless used to set node attributes: ./recipes/server_proxy.rb:35
+FC082: Deprecated node.set or node.set_unless used to set node attributes: ./recipes/server_proxy.rb:36
+FC082: Deprecated node.set or node.set_unless used to set node attributes: ./recipes/server_proxy.rb:37
+FC082: Deprecated node.set or node.set_unless used to set node attributes: ./recipes/server_proxy.rb:38
+FC082: Deprecated node.set or node.set_unless used to set node attributes: ./recipes/server_proxy.rb:39

data/spec/regression/expected/cron.txt

@@ -6,3 +6,4 @@ FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
 FC074: LWRP should use DSL to define resource's default action: ./resources/d.rb:1
 FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1
+FC085: Resource using new_resource.updated_by_last_action to converge resource: ./providers/d.rb:31

data/spec/regression/expected/database.txt

@@ -13,4 +13,10 @@ FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
 FC075: Cookbook uses node.save to save partial node data to the chef-server mid-run: ./recipes/master.rb:37
 FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1
-FC082: node.set or node.set_unless used to set node attributes: ./recipes/master.rb:36
+FC082: Deprecated node.set or node.set_unless used to set node attributes: ./recipes/master.rb:36
+FC086: Use databag helper methods to load data bag items: ./recipes/ebs_backup.rb:22
+FC086: Use databag helper methods to load data bag items: ./recipes/ebs_backup.rb:38
+FC086: Use databag helper methods to load data bag items: ./recipes/ebs_volume.rb:27
+FC086: Use databag helper methods to load data bag items: ./recipes/ebs_volume.rb:70
+FC086: Use databag helper methods to load data bag items: ./recipes/ebs_volume.rb:78
+FC086: Use databag helper methods to load data bag items: ./recipes/ebs_volume.rb:94

data/spec/regression/expected/drbd.txt

@@ -25,4 +25,4 @@ FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
 FC075: Cookbook uses node.save to save partial node data to the chef-server mid-run: ./recipes/default.rb:21
 FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1
-FC082: node.set or node.set_unless used to set node attributes: ./recipes/pair.rb:87
+FC082: Deprecated node.set or node.set_unless used to set node attributes: ./recipes/pair.rb:87