foodcritic 10.4.0 → 10.4.1

data/spec/regression/expected/lvm.txt

@@ -10,3 +10,4 @@ FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
 FC074: LWRP should use DSL to define resource's default action: ./resources/logical_volume.rb:1
 FC074: LWRP should use DSL to define resource's default action: ./resources/physical_volume.rb:1
 FC074: LWRP should use DSL to define resource's default action: ./resources/volume_group.rb:1
+FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1

data/spec/regression/expected/maradns.txt

@@ -11,3 +11,4 @@ FC065: Ensure source_url is set in metadata: ./metadata.rb:1
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
 FC072: Metadata should not contain "attribute" keyword: ./metadata.rb:1
+FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1

data/spec/regression/expected/maven.txt

@@ -7,3 +7,4 @@ FC065: Ensure source_url is set in metadata: ./metadata.rb:1
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
 FC074: LWRP should use DSL to define resource's default action: ./resources/default.rb:1
+FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1

data/spec/regression/expected/memcached.txt

@@ -28,3 +28,4 @@ FC065: Ensure source_url is set in metadata: ./metadata.rb:1
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
 FC072: Metadata should not contain "attribute" keyword: ./metadata.rb:1
+FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1

data/spec/regression/expected/motd-tail.txt

@@ -2,3 +2,4 @@ FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
 FC065: Ensure source_url is set in metadata: ./metadata.rb:1
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
+FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1

data/spec/regression/expected/mysql.txt

@@ -10,3 +10,5 @@ FC065: Ensure source_url is set in metadata: ./metadata.rb:1
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
 FC072: Metadata should not contain "attribute" keyword: ./metadata.rb:1
+FC075: Cookbook uses node.save to save partial node data to the chef-server mid-run: ./recipes/server.rb:42
+FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1

data/spec/regression/expected/ohai.txt

@@ -4,3 +4,4 @@ FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
 FC067: Ensure at least one platform supported in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
 FC072: Metadata should not contain "attribute" keyword: ./metadata.rb:1
+FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1

data/spec/regression/expected/openldap.txt

@@ -8,3 +8,5 @@ FC065: Ensure source_url is set in metadata: ./metadata.rb:1
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
 FC072: Metadata should not contain "attribute" keyword: ./metadata.rb:1
+FC075: Cookbook uses node.save to save partial node data to the chef-server mid-run: ./recipes/slave.rb:28
+FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1

data/spec/regression/expected/openssh.txt

@@ -2,3 +2,4 @@ FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
 FC065: Ensure source_url is set in metadata: ./metadata.rb:1
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
+FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1

data/spec/regression/expected/openssl.txt

@@ -3,3 +3,4 @@ FC065: Ensure source_url is set in metadata: ./metadata.rb:1
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
 FC067: Ensure at least one platform supported in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
+FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1

data/spec/regression/expected/partial_search.txt

@@ -3,3 +3,4 @@ FC065: Ensure source_url is set in metadata: ./metadata.rb:1
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
 FC067: Ensure at least one platform supported in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
+FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1

data/spec/regression/expected/passenger_apache2.txt

@@ -27,3 +27,4 @@ FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
 FC065: Ensure source_url is set in metadata: ./metadata.rb:1
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
+FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1

data/spec/regression/expected/perl.txt

@@ -9,3 +9,4 @@ FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
 FC065: Ensure source_url is set in metadata: ./metadata.rb:1
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
+FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1

data/spec/regression/expected/php.txt

@@ -7,3 +7,4 @@ FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
 FC065: Ensure source_url is set in metadata: ./metadata.rb:1
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
+FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1

data/spec/regression/expected/postfix.txt

@@ -4,3 +4,4 @@ FC065: Ensure source_url is set in metadata: ./metadata.rb:1
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
 FC072: Metadata should not contain "attribute" keyword: ./metadata.rb:1
+FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1

data/spec/regression/expected/powershell.txt

@@ -6,3 +6,4 @@ FC065: Ensure source_url is set in metadata: ./metadata.rb:1
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
 FC074: LWRP should use DSL to define resource's default action: ./resources/default.rb:1
+FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1

data/spec/regression/expected/resolver.txt

@@ -4,3 +4,4 @@ FC065: Ensure source_url is set in metadata: ./metadata.rb:1
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
 FC072: Metadata should not contain "attribute" keyword: ./metadata.rb:1
+FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1

data/spec/regression/expected/rsync.txt

@@ -8,3 +8,4 @@ FC065: Ensure source_url is set in metadata: ./metadata.rb:1
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
 FC071: Missing LICENSE file: examples/LICENSE:1
+FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1

data/spec/regression/expected/rsyslog.txt

@@ -6,3 +6,5 @@ FC065: Ensure source_url is set in metadata: ./metadata.rb:1
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
 FC072: Metadata should not contain "attribute" keyword: ./metadata.rb:1
+FC075: Cookbook uses node.save to save partial node data to the chef-server mid-run: ./recipes/server.rb:23
+FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1

data/spec/regression/expected/runit.txt

@@ -1,2 +1,3 @@
 FC004: Use a service resource to start and stop services: ./recipes/default.rb:24
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
+FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1

data/spec/regression/expected/smokeping.txt

@@ -1,3 +1,4 @@
 FC059: LWRP provider does not declare use_inline_resources: ./providers/target.rb:1
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
+FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1

data/spec/regression/expected/sql_server.txt

@@ -2,3 +2,5 @@ FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
 FC065: Ensure source_url is set in metadata: ./metadata.rb:1
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
+FC075: Cookbook uses node.save to save partial node data to the chef-server mid-run: ./recipes/server.rb:28
+FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1

data/spec/regression/expected/ssh_known_hosts.txt

@@ -3,3 +3,4 @@ FC065: Ensure source_url is set in metadata: ./metadata.rb:1
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
 FC067: Ensure at least one platform supported in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
+FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1

data/spec/regression/expected/stompserver.txt

@@ -3,3 +3,4 @@ FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
 FC065: Ensure source_url is set in metadata: ./metadata.rb:1
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
+FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1

data/spec/regression/expected/subversion.txt

@@ -3,3 +3,4 @@ FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
 FC065: Ensure source_url is set in metadata: ./metadata.rb:1
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
+FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1

data/spec/regression/expected/sudo.txt

@@ -6,3 +6,4 @@ FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
 FC072: Metadata should not contain "attribute" keyword: ./metadata.rb:1
 FC074: LWRP should use DSL to define resource's default action: ./resources/default.rb:1
+FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1

data/spec/regression/expected/tar.txt

@@ -5,3 +5,4 @@ FC067: Ensure at least one platform supported in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
 FC071: Missing LICENSE file: ./LICENSE:1
 FC074: LWRP should use DSL to define resource's default action: ./resources/package.rb:1
+FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1

data/spec/regression/expected/tftp.txt

@@ -3,3 +3,4 @@ FC065: Ensure source_url is set in metadata: ./metadata.rb:1
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
 FC072: Metadata should not contain "attribute" keyword: ./metadata.rb:1
+FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1

data/spec/regression/expected/tomcat.txt

@@ -1 +1,2 @@
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
+FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1

data/spec/regression/expected/transmission.txt

@@ -8,3 +8,4 @@ FC065: Ensure source_url is set in metadata: ./metadata.rb:1
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
 FC067: Ensure at least one platform supported in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
+FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1

data/spec/regression/expected/ubuntu.txt

@@ -2,3 +2,4 @@ FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
 FC065: Ensure source_url is set in metadata: ./metadata.rb:1
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
+FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1

data/spec/regression/expected/ufw.txt

@@ -7,3 +7,4 @@ FC065: Ensure source_url is set in metadata: ./metadata.rb:1
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
 FC072: Metadata should not contain "attribute" keyword: ./metadata.rb:1
+FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1

data/spec/regression/expected/unicorn.txt

@@ -4,3 +4,4 @@ FC065: Ensure source_url is set in metadata: ./metadata.rb:1
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
 FC067: Ensure at least one platform supported in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
+FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1

data/spec/regression/expected/users.txt

@@ -5,3 +5,4 @@ FC065: Ensure source_url is set in metadata: ./metadata.rb:1
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
 FC074: LWRP should use DSL to define resource's default action: ./resources/manage.rb:1
+FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1

data/spec/regression/expected/vcruntime.txt

@@ -5,3 +5,4 @@ FC009: Resource attribute not recognised: ./recipes/vc14.rb:24
 FC009: Resource attribute not recognised: ./recipes/vc6.rb:24
 FC009: Resource attribute not recognised: ./recipes/vc9.rb:24
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
+FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1

data/spec/regression/expected/vim.txt

@@ -4,3 +4,4 @@ FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
 FC065: Ensure source_url is set in metadata: ./metadata.rb:1
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
+FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1

data/spec/regression/expected/webpi.txt

@@ -5,3 +5,4 @@ FC065: Ensure source_url is set in metadata: ./metadata.rb:1
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
 FC074: LWRP should use DSL to define resource's default action: ./resources/product.rb:1
+FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1

data/spec/regression/expected/whitelist-node-attrs.txt

@@ -4,3 +4,4 @@ FC065: Ensure source_url is set in metadata: ./metadata.rb:1
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
 FC067: Ensure at least one platform supported in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
+FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1

data/spec/regression/expected/windows.txt

@@ -55,3 +55,4 @@ FC074: LWRP should use DSL to define resource's default action: ./resources/regi
 FC074: LWRP should use DSL to define resource's default action: ./resources/shortcut.rb:1
 FC074: LWRP should use DSL to define resource's default action: ./resources/task.rb:1
 FC074: LWRP should use DSL to define resource's default action: ./resources/zipfile.rb:1
+FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1

data/spec/regression/expected/wix.txt

@@ -2,3 +2,4 @@ FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
 FC065: Ensure source_url is set in metadata: ./metadata.rb:1
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
+FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1

data/spec/regression/expected/xml.txt

@@ -2,3 +2,4 @@ FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
 FC065: Ensure source_url is set in metadata: ./metadata.rb:1
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
+FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1

data/spec/regression/expected/yum.txt

@@ -15,3 +15,4 @@ FC070: Ensure supports metadata defines valid platforms: ./metadata.rb:1
 FC072: Metadata should not contain "attribute" keyword: ./metadata.rb:1
 FC074: LWRP should use DSL to define resource's default action: ./resources/key.rb:1
 FC074: LWRP should use DSL to define resource's default action: ./resources/repository.rb:1
+FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1

data/spec/unit/api_spec.rb

@@ -1880,6 +1880,17 @@ describe FoodCritic::Api do
                  { :platform => "fedora", :versions => [] },
                  { :platform => "redhat", :versions => [] }]
     end
+    it "handles support declarations from arrays that include whitespace" do
+      expect(supports(%q{
+        %w(
+          amazon
+          ubuntu
+        ).each do |os|
+          supports os
+        end
+      })).to eq [{ :platform => "amazon", :versions => [] },
+                 { :platform => "ubuntu", :versions => [] }]
+    end
   end
 
   describe "#templates_included" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: foodcritic
 version: !ruby/object:Gem::Version
-  version: 10.4.0
+  version: 10.4.1
 platform: ruby
 authors:
 - Andrew Crump
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-04-13 00:00:00.000000000 Z
+date: 2017-04-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: cucumber-core
@@ -191,7 +191,6 @@ files:
 - features/007_check_for_undeclared_recipe_dependencies.feature
 - features/009_check_for_unrecognised_resource_attributes.feature
 - features/010_check_search_syntax.feature
-- features/013_check_for_hardcoded_tmpdir.feature
 - features/014_check_for_long_ruby_blocks.feature
 - features/015_check_for_definitions.feature
 - features/017_check_for_no_lwrp_notifications.feature
@@ -362,6 +361,7 @@ files:
 - spec/functional/fc008_spec.rb
 - spec/functional/fc011_spec.rb
 - spec/functional/fc012_spec.rb
+- spec/functional/fc013_spec.rb
 - spec/functional/fc016_spec.rb
 - spec/functional/fc028_spec.rb
 - spec/functional/fc029_spec.rb
@@ -506,5 +506,5 @@ rubyforge_project:
 rubygems_version: 2.6.11
 signing_key: 
 specification_version: 4
-summary: foodcritic-10.4.0
+summary: foodcritic-10.4.1
 test_files: []

data/features/013_check_for_hardcoded_tmpdir.feature

@@ -1,25 +0,0 @@
-Feature: Check for hard-coded temp directory
-
-  In order to ensure that my cookbook works on a server that may have limited /tmp space
-  As a developer
-  I want to identify if my cookbook is hard-coding references to /tmp rather than using the Chef file cache path
-
-  Scenario: Download to hard-coded temp directory
-    Given a cookbook that downloads a file to /tmp
-    When I check the cookbook
-    Then the hard-coded temp directory warning 013 should be displayed
-
-  Scenario: Download to hard-coded temp directory (expression)
-    Given a cookbook that downloads a file to /tmp with an expression
-    When I check the cookbook
-    Then the hard-coded temp directory warning 013 should be displayed
-
-  Scenario: Download to Chef file cache
-    Given a cookbook that downloads a file to the Chef file cache
-    When I check the cookbook
-    Then the hard-coded temp directory warning 013 should not be displayed
-
-  Scenario: Download to anywhere else
-    Given a cookbook that downloads a file to a users home directory
-    When I check the cookbook
-    Then the hard-coded temp directory warning 013 should not be displayed