foodcritic 10.4.0 → 10.4.1

data/lib/foodcritic/rules/fc018.rb

@@ -1,5 +1,5 @@
 rule "FC018", "LWRP uses deprecated notification syntax" do
-  tags %w{correctness lwrp deprecated}
+  tags %w{correctness lwrp deprecated chef13}
   provider do |ast|
     ast.xpath("//assign/var_field/ivar[@value='@updated']").map do |class_var|
       match(class_var)

data/lib/foodcritic/rules/fc028.rb

@@ -1,8 +1,8 @@
-rule "FC028", "Incorrect #platform? usage" do
-  tags %w{correctness}
+rule "FC028", "Use platform? and platform_family? not node.platform? and node.platform_family?" do
+  tags %w{style}
   recipe do |ast|
     ast.xpath(%q{//*[self::call | self::command_call]
       [(var_ref|vcall)/ident/@value='node']
-      [ident/@value="platform?"]})
+      [ident/@value="platform?" or ident/@value="platform_family?"]})
   end
 end

data/lib/foodcritic/rules/fc071.rb

@@ -1,7 +1,7 @@
 rule "FC071", "Missing LICENSE file" do
   tags %w{style license}
   cookbook do |path|
-    unless ::File.exist?("metadata.rb") && field_value(read_ast("metadata.rb"), "license") == "All Rights Reserved"
+    unless ::File.exist?(::File.join(path, "metadata.rb")) && field_value(read_ast(::File.join(path, "metadata.rb")), "license").to_s.casecmp("All Rights Reserved") == 0
       ensure_file_exists(path, "LICENSE")
     end
   end

data/lib/foodcritic/version.rb

@@ -1,4 +1,4 @@
 module FoodCritic
   # The current version of foodcritic
-  VERSION = "10.4.0"
+  VERSION = "10.4.1"
 end

data/spec/functional/fc013_spec.rb

@@ -0,0 +1,39 @@
+require "spec_helper"
+
+describe "FC013" do
+  context "with a cookbook that downloads a file to /tmp" do
+    recipe_file <<-EOH
+      remote_file "/tmp/large-file.tar.gz" do
+        source "http://www.example.org/large-file.tar.gz"
+      end
+    EOH
+    it { is_expected.to violate_rule("FC013") }
+  end
+
+  context "with a cookbook that downloads a file to /tmp with an expression" do
+    recipe_file <<-'EOH'
+      remote_file "/tmp/#{the_file}" do
+        source "http://www.example.org/large-file.tar.gz"
+      end
+    EOH
+    it { is_expected.to violate_rule("FC013") }
+  end
+
+  context "with a cookbook that downloads a file to a users home directory" do
+    recipe_file <<-EOH
+      remote_file "/home/ernie/large-file.tar.gz" do
+        source "http://www.example.org/large-file.tar.gz"
+      end
+    EOH
+    it { is_expected.not_to violate_rule("FC013") }
+  end
+
+  context "with a cookbook that downloads a file to the Chef file cache" do
+    recipe_file <<-'EOH'
+      remote_file '#{Chef::Config[:file_cache_path]}/large-file.tar.gz' do
+        source "http://www.example.org/large-file.tar.gz"
+      end
+    EOH
+    it { is_expected.not_to violate_rule("FC013") }
+  end
+end

data/spec/functional/fc016_spec.rb

@@ -35,7 +35,7 @@ describe "FC016" do
     it { is_expected.to violate_rule("FC016") }
   end
 
-  context "with a custom resource" do
+  context "with a custom resource that includes a property" do
     resource_file <<-EOH
       property :name, String, name_property: true
 
@@ -45,4 +45,13 @@ describe "FC016" do
     EOH
     it { is_expected.to_not violate_rule("FC016") }
   end
+
+  context "with a custom resource that includes only an action" do
+    resource_file <<-EOH
+      action :create do
+        cookbook_file "/etc/something"
+      end
+    EOH
+    it { is_expected.to_not violate_rule("FC016") }
+  end
 end

data/spec/functional/fc028_spec.rb

@@ -45,4 +45,49 @@ describe "FC028" do
     recipe_file "node.platform?('ubuntu', 'windows')"
     it { is_expected.to violate_rule("FC028") }
   end
+
+  context "with a cookbook with a single recipe that calls platform_family? without parentheses for a single platform family" do
+    recipe_file "platform_family? 'debian'"
+    it { is_expected.not_to violate_rule("FC028") }
+  end
+
+  context "with a cookbook with a single recipe that calls platform_family? without parentheses for two plaform families" do
+    recipe_file "platform_family?('debian','windows')"
+    it { is_expected.not_to violate_rule("FC028") }
+  end
+
+  context "with a cookbook with a single recipe that calls platform_family? with parentheses for a single plaform family" do
+    recipe_file "platform_family?('debian')"
+    it { is_expected.not_to violate_rule("FC028") }
+  end
+
+  context "with a cookbook with a single recipe that calls platform_family? with parentheses for two plaform families" do
+    recipe_file "platform_family?('debian', 'windows')"
+    it { is_expected.not_to violate_rule("FC028") }
+  end
+
+  context "with a cookbook with a single recipe that compares a value against node.platform_family" do
+    recipe_file "node.platform_family == 'debian'"
+    it { is_expected.not_to violate_rule("FC028") }
+  end
+
+  context "with a cookbook with a single recipe that uses checks a value against node.platform_family" do
+    recipe_file "node.platform_family == 'debian'"
+    it { is_expected.not_to violate_rule("FC028") }
+  end
+
+  context "with a cookbook with a single recipe that calls node.platform_family? without a parentheses" do
+    recipe_file "node.platform_family? 'debian'"
+    it { is_expected.to violate_rule("FC028") }
+  end
+
+  context "with a cookbook with a single recipe that calls node.platform_family? with a parentheses" do
+    recipe_file "node.platform_family?('debian')"
+    it { is_expected.to violate_rule("FC028") }
+  end
+
+  context "with a cookbook with a single recipe that calls node.platform_family? with a parentheses for 2 plaform families" do
+    recipe_file "node.platform_family?('debian', 'windows')"
+    it { is_expected.to violate_rule("FC028") }
+  end
 end

data/spec/functional/fc070_spec.rb

@@ -35,4 +35,22 @@ describe "FC070" do
     metadata_file "supports 'ubuntu >= 16.04'"
     it { is_expected.to violate_rule("FC070") }
   end
+
+  context "with a cookbook with a metadata file specifying valid platforms from an array with leading whitespace" do
+    metadata_file <<-'EOH'
+    %w(
+      amazon
+      centos
+      debian
+      fedora
+      redhat
+      scientific
+      oracle
+      ubuntu
+    ).each do |os|
+      supports os
+    end
+    EOH
+    it { is_expected.to_not violate_rule("FC070") }
+  end
 end

data/spec/functional/fc071_spec.rb

@@ -16,4 +16,21 @@ describe "FC071" do
     metadata_file "license 'All Rights Reserved'"
     it { is_expected.not_to violate_rule("FC071") }
   end
+
+  context "with a cookbook without a LICENSE file but with license of 'all rights reserved'" do
+    metadata_file "license 'all rights reserved'"
+    it { is_expected.not_to violate_rule("FC071") }
+  end
+
+  context "with a cookbook without a LICENSE file, using a sub folder" do
+    subject { foodcritic_command("--no-progress", "mycookbook/") }
+    file "mycookbook/metadata.rb"
+    it { is_expected.to violate_rule("FC071") }
+  end
+
+  context "with a cookbook without a LICENSE file but with license of 'All Rights Reserved', using a sub folder" do
+    subject { foodcritic_command("--no-progress", "mycookbook/") }
+    file "mycookbook/metadata.rb", "license 'All Rights Reserved'"
+    it { is_expected.not_to violate_rule("FC071") }
+  end
 end

data/spec/regression/expected/activemq.txt

@@ -3,3 +3,4 @@ FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
 FC065: Ensure source_url is set in metadata: ./metadata.rb:1
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
+FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1

data/spec/regression/expected/aix.txt

@@ -1 +1,2 @@
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
+FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1

data/spec/regression/expected/apparmor.txt

@@ -6,3 +6,4 @@ FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
 FC065: Ensure source_url is set in metadata: ./metadata.rb:1
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
+FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1

data/spec/regression/expected/apt.txt

@@ -10,3 +10,4 @@ FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
 FC074: LWRP should use DSL to define resource's default action: ./resources/preference.rb:1
 FC074: LWRP should use DSL to define resource's default action: ./resources/repository.rb:1
+FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1

data/spec/regression/expected/ark.txt

@@ -1 +1,2 @@
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
+FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1

data/spec/regression/expected/auditd.txt

@@ -3,3 +3,4 @@ FC017: LWRP does not notify when updated: ./providers/ruleset.rb:21
 FC059: LWRP provider does not declare use_inline_resources: ./providers/builtins.rb:1
 FC059: LWRP provider does not declare use_inline_resources: ./providers/ruleset.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
+FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1

data/spec/regression/expected/aws.txt

@@ -11,3 +11,7 @@ FC074: LWRP should use DSL to define resource's default action: ./resources/ebs_
 FC074: LWRP should use DSL to define resource's default action: ./resources/elastic_ip.rb:1
 FC074: LWRP should use DSL to define resource's default action: ./resources/elastic_lb.rb:1
 FC074: LWRP should use DSL to define resource's default action: ./resources/resource_tag.rb:1
+FC075: Cookbook uses node.save to save partial node data to the chef-server mid-run: ./providers/ebs_volume.rb:33
+FC075: Cookbook uses node.save to save partial node data to the chef-server mid-run: ./providers/ebs_volume.rb:40
+FC075: Cookbook uses node.save to save partial node data to the chef-server mid-run: ./providers/ebs_volume.rb:60
+FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1

data/spec/regression/expected/bluepill.txt

@@ -4,3 +4,4 @@ FC065: Ensure source_url is set in metadata: ./metadata.rb:1
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
 FC067: Ensure at least one platform supported in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
+FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1

data/spec/regression/expected/boost.txt

@@ -4,3 +4,4 @@ FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
 FC065: Ensure source_url is set in metadata: ./metadata.rb:1
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
+FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1

data/spec/regression/expected/build-essential.txt

@@ -4,3 +4,4 @@ FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
 FC065: Ensure source_url is set in metadata: ./metadata.rb:1
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
+FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1

data/spec/regression/expected/chef-client.txt

@@ -11,3 +11,4 @@ FC065: Ensure source_url is set in metadata: ./metadata.rb:1
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
 FC070: Ensure supports metadata defines valid platforms: ./metadata.rb:1
+FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1

data/spec/regression/expected/chef-ingredient.txt

@@ -1,2 +1,3 @@
 FC067: Ensure at least one platform supported in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
+FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1

data/spec/regression/expected/chef-server.txt

@@ -10,3 +10,4 @@ FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
 FC065: Ensure source_url is set in metadata: ./metadata.rb:1
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
+FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1

data/spec/regression/expected/chef-vault.txt

@@ -1,3 +1,4 @@
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
 FC067: Ensure at least one platform supported in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
+FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1

data/spec/regression/expected/chef.txt

@@ -34,3 +34,4 @@ FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
 FC065: Ensure source_url is set in metadata: ./metadata.rb:1
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
+FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1

data/spec/regression/expected/chef_handler.txt

@@ -5,3 +5,4 @@ FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
 FC067: Ensure at least one platform supported in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
 FC074: LWRP should use DSL to define resource's default action: ./resources/default.rb:1
+FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1

data/spec/regression/expected/chef_hostname.txt

@@ -1,2 +1,3 @@
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
 FC070: Ensure supports metadata defines valid platforms: ./metadata.rb:1
+FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1

data/spec/regression/expected/chef_nginx.txt

@@ -1,2 +1,3 @@
 FC015: Consider converting definition to a Custom Resource: ./definitions/nginx_site.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
+FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1

data/spec/regression/expected/cron.txt

@@ -5,3 +5,4 @@ FC065: Ensure source_url is set in metadata: ./metadata.rb:1
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
 FC074: LWRP should use DSL to define resource's default action: ./resources/d.rb:1
+FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1

data/spec/regression/expected/database.txt

@@ -11,3 +11,5 @@ FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
 FC065: Ensure source_url is set in metadata: ./metadata.rb:1
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
+FC075: Cookbook uses node.save to save partial node data to the chef-server mid-run: ./recipes/master.rb:37
+FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1

data/spec/regression/expected/dmg.txt

@@ -10,3 +10,4 @@ FC065: Ensure source_url is set in metadata: ./metadata.rb:1
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
 FC074: LWRP should use DSL to define resource's default action: ./resources/package.rb:1
+FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1

data/spec/regression/expected/docker.txt

@@ -1,2 +1,3 @@
 FC005: Avoid repetition of resource declarations: ./libraries/docker_service_manager_sysvinit_debian.rb:5
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
+FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1

data/spec/regression/expected/drbd.txt

@@ -23,3 +23,5 @@ FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
 FC065: Ensure source_url is set in metadata: ./metadata.rb:1
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
+FC075: Cookbook uses node.save to save partial node data to the chef-server mid-run: ./recipes/default.rb:21
+FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1

data/spec/regression/expected/dynect.txt

@@ -27,3 +27,4 @@ FC065: Ensure source_url is set in metadata: ./metadata.rb:1
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
 FC067: Ensure at least one platform supported in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
+FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1

data/spec/regression/expected/erlang.txt

@@ -2,3 +2,4 @@ FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
 FC065: Ensure source_url is set in metadata: ./metadata.rb:1
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
+FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1

data/spec/regression/expected/fail2ban.txt

@@ -2,3 +2,4 @@ FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
 FC065: Ensure source_url is set in metadata: ./metadata.rb:1
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
+FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1

data/spec/regression/expected/firewall.txt

@@ -10,3 +10,4 @@ FC067: Ensure at least one platform supported in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
 FC074: LWRP should use DSL to define resource's default action: ./resources/default.rb:1
 FC074: LWRP should use DSL to define resource's default action: ./resources/rule.rb:1
+FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1

data/spec/regression/expected/gecode.txt

@@ -6,3 +6,4 @@ FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
 FC065: Ensure source_url is set in metadata: ./metadata.rb:1
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
+FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1

data/spec/regression/expected/gems.txt

@@ -29,3 +29,4 @@ FC065: Ensure source_url is set in metadata: ./metadata.rb:1
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
 FC072: Metadata should not contain "attribute" keyword: ./metadata.rb:1
+FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1

data/spec/regression/expected/gunicorn.txt

@@ -7,3 +7,4 @@ FC067: Ensure at least one platform supported in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
 FC074: LWRP should use DSL to define resource's default action: ./resources/config.rb:1
 FC074: LWRP should use DSL to define resource's default action: ./resources/install.rb:1
+FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1

data/spec/regression/expected/heartbeat.txt

@@ -6,3 +6,4 @@ FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
 FC065: Ensure source_url is set in metadata: ./metadata.rb:1
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
+FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1

data/spec/regression/expected/homebrew.txt

@@ -6,3 +6,4 @@ FC065: Ensure source_url is set in metadata: ./metadata.rb:1
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
 FC074: LWRP should use DSL to define resource's default action: ./resources/tap.rb:1
+FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1

data/spec/regression/expected/iis.txt

@@ -28,3 +28,4 @@ FC074: LWRP should use DSL to define resource's default action: ./resources/app.
 FC074: LWRP should use DSL to define resource's default action: ./resources/config.rb:1
 FC074: LWRP should use DSL to define resource's default action: ./resources/pool.rb:1
 FC074: LWRP should use DSL to define resource's default action: ./resources/site.rb:1
+FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1

data/spec/regression/expected/iptables.txt

@@ -6,3 +6,4 @@ FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
 FC065: Ensure source_url is set in metadata: ./metadata.rb:1
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
+FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1

data/spec/regression/expected/jetty.txt

@@ -9,3 +9,4 @@ FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
 FC065: Ensure source_url is set in metadata: ./metadata.rb:1
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
+FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1

data/spec/regression/expected/jpackage.txt

@@ -6,3 +6,4 @@ FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
 FC065: Ensure source_url is set in metadata: ./metadata.rb:1
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
+FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1

data/spec/regression/expected/keepalived.txt

@@ -1,2 +1,3 @@
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
+FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1

data/spec/regression/expected/kickstart.txt

@@ -12,3 +12,4 @@ FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
 FC065: Ensure source_url is set in metadata: ./metadata.rb:1
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
+FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1

data/spec/regression/expected/libarchive.txt

@@ -3,3 +3,4 @@ FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
 FC065: Ensure source_url is set in metadata: ./metadata.rb:1
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
+FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1

data/spec/regression/expected/logwatch.txt

@@ -2,3 +2,4 @@ FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
 FC065: Ensure source_url is set in metadata: ./metadata.rb:1
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
+FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1