foobara 0.0.115 → 0.0.117

data/projects/entity/src/sensitive_value_removers/entity.rb

@@ -4,22 +4,15 @@ module Foobara
       class Entity < DetachedEntity::SensitiveValueRemovers::DetachedEntity
         def transform(record)
           if record.loaded? || record.created?
-            sanitized_record = super
-
-            sanitized_record.is_loaded = record.loaded?
-            sanitized_record.is_persisted = record.persisted?
-
-            sanitized_record
+            super
           elsif record.persisted?
             # We will assume that we do not need to clean up the primary key itself as
             # we will assume we don't allow sensitive primary keys for now.
-            sanitized_record = to_type.target_class.build(record.class.primary_key_attribute => record.primary_key)
-
-            sanitized_record.is_persisted = true
-            sanitized_record.is_loaded = false
-            sanitized_record.is_built = false
-
-            sanitized_record
+            # We use .new because the target_class should be a detached entity
+            to_type.target_class.new(
+              { record.class.primary_key_attribute => record.primary_key },
+              { mutable: false, skip_validations: true }
+            )
           else
             # :nocov:
             raise "Not sure what to do with a record that isn't loaded, created, or persisted"
@@ -28,7 +21,14 @@ module Foobara
         end
 
         def build_method
-          :build
+          if to_type.extends?(:entity)
+            # TODO: test this code path
+            # :nocov:
+            :build
+            # :nocov:
+          else
+            :new
+          end
         end
       end
     end

data/projects/enumerated/src/values.rb

@@ -125,7 +125,7 @@ module Foobara
         mod = Module.new
         enumerated = self
 
-        %i[all all_names all_values value?].each do |method_name|
+        [:all, :all_names, :all_values, :value?].each do |method_name|
           mod.singleton_class.define_method method_name do |*args, **opts, &block|
             enumerated.send(method_name, *args, **opts, &block)
           end

data/projects/foobara/lib/foobara/all.rb

@@ -30,9 +30,10 @@ module Foobara
              "detached_entity",
              "entity",
              "model_attribute_helpers",
+             "nested_transactionable",
              "command",
              "domain_mapper",
-             "persistence",
+             "persistence", # Feels like this would be loaded before command?
              "in_memory_crud_driver_minimal",
              "in_memory_crud_driver",
              "manifest"

data/projects/manifest/src/foobara/manifest/base_manifest.rb

@@ -103,11 +103,11 @@ module Foobara
       end
 
       def global_domain
-        Domain.new(root_manifest, %i[domain global_organization::global_domain])
+        Domain.new(root_manifest, [:domain, :"global_organization::global_domain"])
       end
 
       def global_organization
-        Organization.new(root_manifest, %i[organization global_organization])
+        Organization.new(root_manifest, [:organization, :global_organization])
       end
 
       def method_missing(method_name, *, &)

data/projects/manifest/src/foobara/manifest/root_manifest.rb

@@ -102,7 +102,7 @@ module Foobara
       end
 
       def lookup(reference)
-        prioritized_categories = %i[command type error domain organization processor processor_class]
+        prioritized_categories = [:command, :type, :error, :domain, :organization, :processor, :processor_class]
 
         prioritized_categories.each do |category|
           path = [category, reference]

data/projects/model/src/concerns/types.rb

@@ -64,8 +64,9 @@ module Foobara
 
               if model_type
                 unless Foobara::TypeDeclarations.declarations_equal?(declaration, model_type.declaration_data)
+                  type_domain = domain
                   self.model_type = nil
-                  domain.foobara_type_from_declaration(declaration)
+                  type_domain.foobara_type_from_declaration(declaration)
                 end
               else
                 domain.foobara_type_from_declaration(declaration)
@@ -198,7 +199,7 @@ module Foobara
             delegates[attribute_name] = delegate_manifest
 
             delegated_type_declaration = model_type.type_at_path(data_path).reference_or_declaration_data
-            attributes attribute_name => delegated_type_declaration
+            attributes(type: :attributes, element_type_declarations: { attribute_name => delegated_type_declaration })
 
             define_method attribute_name do
               data_path.value_at(self)

data/projects/model/src/extensions/builtin_types/model/validators/model_instance_is_valid.rb

@@ -13,8 +13,8 @@ module Foobara
             end
           end
 
-          def always_applicable?
-            true
+          def applicable?(model_instance)
+            !model_instance.skip_validations
           end
 
           def process_value(model_instance)

data/projects/model/src/extensions/type_declarations/handlers/extend_model_type_declaration/delegates_desugarizer.rb

@@ -8,8 +8,8 @@ module Foobara
           end
 
           def desugarize(sugary_type_declaration)
-            desugarized = Util.deep_dup(sugary_type_declaration)
-            delegates = desugarized[:delegates]
+            desugarized = sugary_type_declaration.dup
+            delegates = Util.deep_symbolize_keys(desugarized[:delegates])
 
             if delegates.empty?
               desugarized.delete(:delegates)

data/projects/model/src/extensions/type_declarations/handlers/extend_model_type_declaration/delegates_validator.rb

@@ -21,7 +21,7 @@ module Foobara
               )
             end
 
-            allowed_keys = %i[data_path writer]
+            allowed_keys = [:data_path, :writer]
 
             delegates.each_pair do |attribute_name, delegate_hash|
               invalid_keys = delegate_hash.keys - allowed_keys

data/projects/model/src/extensions/type_declarations/handlers/extend_model_type_declaration/model_class_desugarizer.rb

@@ -17,6 +17,8 @@ module Foobara
 
           # TODO: consider splitting this up into multiple desugarizers
           def desugarize(strictish_type_declaration)
+            strictish_type_declaration = strictish_type_declaration.dup
+
             if strictish_type_declaration.key?(:model_module)
               model_module = strictish_type_declaration[:model_module]
 
@@ -47,7 +49,7 @@ module Foobara
                                      end
                                    end
 
-                                   strictish_type_declaration[:model_base_class] = model_class.superclass.name
+                                   strictish_type_declaration[:model_base_class] ||= model_class.superclass.name
 
                                    model_class.name
                                  elsif klass.is_a?(::String)

data/projects/model/src/model.rb

@@ -169,18 +169,21 @@ module Foobara
 
     abstract
 
-    attr_accessor :mutable
+    attr_accessor :mutable, :skip_validations
+
+    ALLOWED_OPTIONS = [:validate, :mutable, :ignore_unexpected_attributes, :skip_validations].freeze
 
     def initialize(attributes = nil, options = {})
-      allowed_options = %i[validate mutable ignore_unexpected_attributes]
-      invalid_options = options.keys - allowed_options
+      invalid_options = options.keys - ALLOWED_OPTIONS
 
       unless invalid_options.empty?
         # :nocov:
-        raise ArgumentError, "Invalid options #{invalid_options} expected only #{allowed_options}"
+        raise ArgumentError, "Invalid options #{invalid_options} expected only #{ALLOWED_OPTIONS}"
         # :nocov:
       end
 
+      self.skip_validations = options[:skip_validations]
+
       if options[:ignore_unexpected_attributes]
         Thread.with_inheritable_thread_local_var(:foobara_ignore_unexpected_attributes, true) do
           initialize(attributes, options.except(:ignore_unexpected_attributes))
@@ -226,7 +229,7 @@ module Foobara
                        mutable
                      end
 
-      validate! if validate
+      validate! if validate # TODO: test this code path
     end
 
     foobara_delegate :model_name, :valid_attribute_name?, :validate_attribute_name!, to: :class

data/projects/model_attribute_helpers/src/attribute_helper_aliases.rb

@@ -7,17 +7,17 @@ module Foobara
         include Foobara::Concern
 
         module ClassMethods
-          %i[
-            attributes_for_update
-            type_from_foobara_model_class
-            attributes_type_from_foobara_model_class
-            primary_key_attribute_from_foobara_model_class
-            foobara_model_class_has_primary_key
-            attributes_for_create
-            attributes_for_aggregate_update
-            attributes_for_atom_update
-            attributes_for_find_by
-            type_declaration_value_at
+          [
+            :attributes_for_update,
+            :type_from_foobara_model_class,
+            :attributes_type_from_foobara_model_class,
+            :primary_key_attribute_from_foobara_model_class,
+            :foobara_model_class_has_primary_key,
+            :attributes_for_create,
+            :attributes_for_aggregate_update,
+            :attributes_for_atom_update,
+            :attributes_for_find_by,
+            :type_declaration_value_at
           ].each do |method_name|
             define_method method_name do |*args, **opts, &block|
               send("foobara_#{method_name}", *args, **opts, &block)

data/projects/monorepo/lib/foobara/monorepo/project.rb

@@ -26,7 +26,10 @@ module Foobara
 
       def load
         require require_path
-        Util.require_directory("#{project_path}/src")
+        src_dir = "#{project_path}/src"
+        if Dir.exist?(src_dir)
+          Util.require_directory(src_dir)
+        end
       end
 
       def install!

data/projects/nested_transactionable/lib/foobara/nested_transactionable.rb

@@ -0,0 +1,95 @@
+module Foobara
+  module NestedTransactionable
+    include Concern
+
+    class << self
+      def relevant_entity_classes_for_type(type)
+        entity_classes = []
+        entity_classes += Entity.construct_associations(type).values.map(&:target_class)
+
+        if type.extends?(BuiltinTypes[:entity])
+          entity_classes << type.target_class
+        end
+
+        entity_classes.uniq.each do |entity_class|
+          entity_classes += entity_class.deep_associations.values.map(&:target_class)
+        end
+
+        entity_classes.uniq
+      end
+    end
+
+    def relevant_entity_classes_for_type(type)
+      NestedTransactionable.relevant_entity_classes_for_type(type)
+    end
+
+    def relevant_entity_classes
+      # :nocov:
+      raise "subclass responsibility"
+      # :nocov:
+    end
+
+    def transactions
+      @transactions ||= []
+    end
+
+    def opened_transactions
+      @opened_transactions ||= []
+    end
+
+    def auto_detect_current_transactions
+      classes = relevant_entity_classes
+      return if classes.nil? || classes.empty?
+
+      bases = classes.map(&:entity_base).uniq
+
+      bases.each do |base|
+        tx = base.current_transaction
+        transactions << tx if tx
+      end
+    end
+
+    def open_transaction
+      auto_detect_current_transactions
+
+      bases_not_needing_transaction = transactions.map(&:entity_base)
+
+      bases_needing_transaction = relevant_entity_classes.map(&:entity_base).uniq - bases_not_needing_transaction
+
+      bases_needing_transaction.each do |entity_base|
+        transaction = entity_base.transaction
+        transaction.open!
+        opened_transactions << transaction
+        transactions << transaction
+      end
+    end
+
+    def rollback_transaction
+      opened_transactions.reverse.each do |transaction|
+        if transaction.currently_open?
+          # Hard to test this because halting and other exceptions rollback the transactions via
+          # block form but to be safe keeping this
+          # :nocov:
+          transaction.rollback!
+          # :nocov:
+        end
+      end
+    end
+
+    def commit_transaction
+      opened_transactions.reverse.each(&:commit!)
+    end
+
+    def commit_transaction_if_open
+      opened_transactions.reverse.each do |tx|
+        if tx.currently_open?
+          tx.commit!
+        end
+      end
+    end
+
+    def use_transaction(&)
+      Persistence::EntityBase.using_transactions(transactions, &)
+    end
+  end
+end

data/projects/persistence/src/entity_base/transaction_table/concerns/record_tracking.rb

@@ -95,11 +95,11 @@ module Foobara
               marked_created.clear
             end
 
-            interesting_record_states = %i[
-              updated
-              hard_deleted
-              created
-              loading
+            interesting_record_states = [
+              :updated,
+              :hard_deleted,
+              :created,
+              :loading
             ]
 
             interesting_record_states.each do |state|

data/projects/type_declarations/lib/foobara/type_declarations.rb

@@ -17,10 +17,10 @@ module Foobara
           end
         end
 
-        %w[
-          foobara_children
-          foobara_registry
-          foobara_type_builder
+        [
+          "foobara_children",
+          "foobara_registry",
+          "foobara_type_builder"
         ].each do |var_name|
           var_name = "@#{var_name}"
 

data/projects/type_declarations/src/handlers/extend_array_type_declaration/type_set_to_array_desugarizer.rb

@@ -8,7 +8,7 @@ module Foobara
         class TypeSetToArrayDesugarizer < ArrayDesugarizer
           def applicable?(sugary_type_declaration)
             if sugary_type_declaration.is_a?(::Hash) && sugary_type_declaration.key?(:type)
-              extra_keys = sugary_type_declaration.keys - %i[type description sensitive sensitive_exposed]
+              extra_keys = sugary_type_declaration.keys - [:type, :description, :sensitive, :sensitive_exposed]
 
               return false if extra_keys.any?
 

data/projects/type_declarations/src/handlers/extend_registered_type_declaration/to_type_transformer.rb

@@ -74,7 +74,7 @@ module Foobara
           end
 
           def non_processor_keys
-            %i[type _desugarized description sensitive sensitive_exposed]
+            [:type, :_desugarized, :description, :sensitive, :sensitive_exposed]
           end
         end
       end

data/projects/type_declarations/src/type_declarations.rb

@@ -96,8 +96,8 @@ module Foobara
         Thread.inheritable_thread_local_var_get("foobara_manifest_context")
       end
 
-      allowed_context_keys = %i[detached to_include mode remove_sensitive]
-      booleans = %i[detached remove_sensitive]
+      allowed_context_keys = [:detached, :to_include, :mode, :remove_sensitive]
+      booleans = [:detached, :remove_sensitive]
 
       booleans.each do |context_item|
         define_method "foobara_manifest_context_#{context_item}?" do

data/projects/value/src/caster.rb

@@ -16,8 +16,8 @@ module Foobara
         end
 
         def subclass(name: nil, **options)
-          arity_zero = %i[name applies_message]
-          arity_one = %i[applicable? cast]
+          arity_zero = [:name, :applies_message]
+          arity_one = [:applicable?, :cast]
           allowed = arity_zero + arity_one
 
           invalid_options = options.keys - allowed

data/projects/value/src/processor.rb

@@ -48,7 +48,7 @@ module Foobara
         end
 
         def new_with_agnostic_args(**rest)
-          allowed_keys = %i[declaration_data parent_declaration_data]
+          allowed_keys = [:declaration_data, :parent_declaration_data]
 
           invalid_keys = rest.keys - allowed_keys
 
@@ -283,7 +283,7 @@ module Foobara
       end
 
       def dup_processor(**opts)
-        valid_opts = %i[declaration_data parent_declaration_data]
+        valid_opts = [:declaration_data, :parent_declaration_data]
 
         invalid_opts = opts.keys - valid_opts
 

data/projects/value/src/transformer.rb

@@ -24,8 +24,8 @@ module Foobara
 
         # TODO: make transform the first argument for convenience
         def subclass(name: nil, **options)
-          arity_zero = %i[always_applicable? priority]
-          arity_one = %i[applicable? transform]
+          arity_zero = [:always_applicable?, :priority]
+          arity_one = [:applicable?, :transform]
           allowed = arity_zero + arity_one
 
           invalid_options = options.keys - allowed

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: foobara
 version: !ruby/object:Gem::Version
-  version: 0.0.115
+  version: 0.0.117
 platform: ruby
 authors:
 - Miles Georgi
 bindir: bin
 cert_chain: []
-date: 2025-05-01 00:00:00.000000000 Z
+date: 2025-05-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bigdecimal
@@ -179,7 +179,6 @@ files:
 - projects/command/src/command_pattern_implementation/concerns/subcommands.rb
 - projects/command/src/command_pattern_implementation/concerns/transactions.rb
 - projects/command/src/state_machine.rb
-- projects/command/src/transformed_command.rb
 - projects/command_connectors/lib/foobara/command_connectors.rb
 - projects/command_connectors/src/authenticator.rb
 - projects/command_connectors/src/authenticator_selector.rb
@@ -216,6 +215,7 @@ files:
 - projects/command_connectors/src/serializers/record_store_serializer.rb
 - projects/command_connectors/src/serializers/success_serializer.rb
 - projects/command_connectors/src/serializers/yaml_serializer.rb
+- projects/command_connectors/src/transformed_command.rb
 - projects/command_connectors/src/transformers/auth_errors_transformer.rb
 - projects/command_connectors/src/transformers/load_aggregates_pre_commit_transformer.rb
 - projects/command_connectors/src/transformers/load_delegated_attributes_entities_pre_commit_transformer.rb
@@ -234,7 +234,10 @@ files:
 - projects/detached_entity/lib/foobara/detached_entity.rb
 - projects/detached_entity/src/concerns/aliases.rb
 - projects/detached_entity/src/concerns/associations.rb
+- projects/detached_entity/src/concerns/attributes.rb
 - projects/detached_entity/src/concerns/equality.rb
+- projects/detached_entity/src/concerns/initialization.rb
+- projects/detached_entity/src/concerns/persistence.rb
 - projects/detached_entity/src/concerns/primary_key.rb
 - projects/detached_entity/src/concerns/reflection.rb
 - projects/detached_entity/src/concerns/serialize.rb
@@ -243,6 +246,7 @@ files:
 - projects/detached_entity/src/detached_entity_type.rb
 - projects/detached_entity/src/extensions/builtin_types/detached_entity.rb
 - projects/detached_entity/src/extensions/builtin_types/detached_entity/casters/hash.rb
+- projects/detached_entity/src/extensions/builtin_types/detached_entity/casters/primary_key.rb
 - projects/detached_entity/src/extensions/builtin_types/detached_entity/validators/model_instance_is_valid.rb
 - projects/detached_entity/src/extensions/type_declarations/handlers/extend_detached_entity_type_declaration.rb
 - projects/detached_entity/src/extensions/type_declarations/handlers/extend_detached_entity_type_declaration/attributes_handler_desugarizer.rb
@@ -369,6 +373,7 @@ files:
 - projects/namespace/src/prefixless_registry.rb
 - projects/namespace/src/scoped.rb
 - projects/namespace/src/unambiguous_registry.rb
+- projects/nested_transactionable/lib/foobara/nested_transactionable.rb
 - projects/persistence/lib/foobara/persistence.rb
 - projects/persistence/src/entity_attributes_crud_driver.rb
 - projects/persistence/src/entity_base.rb
@@ -492,6 +497,7 @@ require_paths:
 - "./projects/model_attribute_helpers/lib"
 - "./projects/monorepo/lib"
 - "./projects/namespace/lib"
+- "./projects/nested_transactionable/lib"
 - "./projects/persistence/lib"
 - "./projects/state_machine/lib"
 - "./projects/type_declarations/lib"