foobara 0.0.115 → 0.0.117

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 94baacc7205e4b750c59df65dede92b2c95f15053144ba8d8324c81eb80da770
-  data.tar.gz: 696db0d2d875c8f2c40ed9d916019518c3f2ffcc0829015a0333109c83a1e8ef
+  metadata.gz: 3baedff1b00683e94d063e4a3c3453e89f9d8383aac79fd63a7b80590b7ac2ab
+  data.tar.gz: db340140596337684becb59db82ef8c9f64970195eace6d2cb0032d6e209eb88
 SHA512:
-  metadata.gz: 5b5cd5e50eee5c8f652d24107027eaf9115128742b57f8964010667d0e12da2a5bc1087d87870c507c9bd0cc6016eaa0248e9707d567c96c4193794863bebb6a
-  data.tar.gz: 356150abc278d32b253ddc08ed1f4932ac4432a25f9ed4797518191b9a86fc01c06986df8e314aa5a6fc64b44441adc89946a6b6f49daac42d424a73d41e2589
+  metadata.gz: a9cfde792ff8303519b9b98ca46062a7e0dc4209799e00bd64bf3d5674112e685eb8cce621eb50cda6680c54f76084076007d3c18125baefe14eb052566f9038
+  data.tar.gz: db3398f6804081f01a44ac188a0597831db3b3ffa0dfa81ffb99de75c01685e33d21d4d91dbefae6e7d601bae29676e60c778e7be59cb3120bfde7dd7ba1b19a

data/CHANGELOG.md

@@ -1,3 +1,22 @@
+# [0.0.117] - 2025-05-05
+
+- Make sure we do not apply an authenticator unless it is applicable
+- Move loaded/unloaded concept up into DetachedEntity from Entity
+  - This allows us to deal with serialization of detached entities as their primary keys
+- Fix bugs preventing connecting/importing types with delegated attributes
+
+# [0.0.116] - 2025-05-03
+
+- Add automatic transaction support to requests, cover in/out mutators/transformers
+  - This makes it so that authenticators and allowed rules can more cleanly be
+    expressed when they have the same entity bases needed by the transformed command
+- Move #authenticated_user from TransformedCommand to Request
+- Add a Request#authenticated_credential
+- Provide a way to skip validations for models
+- A type without sensitive types derived from an entity type will now be registered as a
+  detached entity
+- Fix model type re-registering bug
+
 # [0.0.115] - 2025-05-01
 
 - Make sure Authenticator#authenticate hits #applicable?

data/projects/builtin_types/src/date/casters/hash.rb

@@ -4,7 +4,7 @@ module Foobara
       module Casters
         class Hash < Value::Caster
           def applicable?(hash)
-            hash.is_a?(::Hash) && hash.keys.size == 3 && (hash.keys.map(&:to_s).sort == %w[day month year])
+            hash.is_a?(::Hash) && hash.keys.size == 3 && (hash.keys.map(&:to_s).sort == ["day", "month", "year"])
           end
 
           def applies_message

data/projects/callback/src/block.rb

@@ -56,7 +56,7 @@ module Foobara
       end
 
       def has_keyword_args?
-        @has_keyword_args ||= param_types.any? { |type| %i[keyreq keyrest].include?(type) }
+        @has_keyword_args ||= param_types.any? { |type| [:keyreq, :keyrest].include?(type) }
       end
 
       def has_positional_args?

data/projects/command/src/command_pattern_implementation/concerns/callbacks.rb

@@ -28,7 +28,7 @@ module Foobara
           self.subclass_defined_callbacks ||= Foobara::Callback::Registry::SingleAction.new
 
           [self, singleton_class].each do |target|
-            %i[before after].each do |type|
+            [:before, :after].each do |type|
               target.define_method "#{type}_any_transition" do |&block|
                 callback_state_machine_target.register_transition_callback(type) do |state_machine:, **args|
                   block.call(command: state_machine.owner, **args)
@@ -61,7 +61,7 @@ module Foobara
 
           Foobara::Command::StateMachine.transitions.each do |transition|
             [self, singleton_class].each do |target|
-              %i[before after].each do |type|
+              [:before, :after].each do |type|
                 target.define_method "#{type}_#{transition}" do |&block|
                   callback_state_machine_target.register_transition_callback(
                     type, transition:

data/projects/command/src/command_pattern_implementation/concerns/runtime.rb

@@ -27,13 +27,13 @@ module Foobara
           Foobara::Namespace.use self.class do
             invoke_with_callbacks_and_transition(:open_transaction)
 
-            invoke_with_callbacks_and_transition_in_transaction(%i[
-                                                                  cast_and_validate_inputs
-                                                                  load_records
-                                                                  validate_records
-                                                                  validate
-                                                                  run_execute
-                                                                  commit_transaction
+            invoke_with_callbacks_and_transition_in_transaction([
+                                                                  :cast_and_validate_inputs,
+                                                                  :load_records,
+                                                                  :validate_records,
+                                                                  :validate,
+                                                                  :run_execute,
+                                                                  :commit_transaction
                                                                 ])
 
             invoke_with_callbacks_and_transition(:succeed)

data/projects/command/src/command_pattern_implementation/concerns/transactions.rb

@@ -3,81 +3,22 @@ module Foobara
     module Concerns
       module Transactions
         include Concern
-
-        def transactions
-          @transactions ||= []
-        end
-
-        def opened_transactions
-          @opened_transactions ||= []
-        end
-
-        def auto_detect_current_transactions
-          bases = relevant_entity_classes.map(&:entity_base).uniq
-
-          bases.each do |base|
-            tx = base.current_transaction
-            transactions << tx if tx
-          end
-        end
+        include NestedTransactionable
 
         def relevant_entity_classes
-          @relevant_entity_classes ||= begin
-            entity_classes = if inputs_type
-                               Entity.construct_associations(
-                                 inputs_type
-                               ).values.uniq.map(&:target_class)
-                             else
-                               []
-                             end
-
-            if result_type
-              entity_classes += Entity.construct_associations(
-                result_type
-              ).values.uniq.map(&:target_class)
-
-              if result_type.extends?(BuiltinTypes[:entity])
-                entity_classes << result_type.target_class
-              end
-            end
+          return @relevant_entity_classes if defined?(@relevant_entity_classes)
 
-            entity_classes += entity_classes.uniq.map do |entity_class|
-              entity_class.deep_associations.values
-            end.flatten.uniq.map(&:target_class)
+          entity_classes = if inputs_type
+                             relevant_entity_classes_for_type(inputs_type)
+                           else
+                             []
+                           end
 
-            [*entity_classes, *self.class.depends_on_entities].uniq
+          if result_type
+            entity_classes += relevant_entity_classes_for_type(result_type)
           end
-        end
-
-        def open_transaction
-          auto_detect_current_transactions
-
-          bases_not_needing_transaction = transactions.map(&:entity_base)
-
-          bases_needing_transaction = relevant_entity_classes.map(&:entity_base).uniq - bases_not_needing_transaction
-
-          bases_needing_transaction.each do |entity_base|
-            transaction = entity_base.transaction
-            transaction.open!
-            opened_transactions << transaction
-            transactions << transaction
-          end
-        end
-
-        def rollback_transaction
-          opened_transactions.reverse.each do |transaction|
-            if transaction.currently_open?
-              # Hard to test this because halting and other exceptions rollback the transactions via
-              # block form but to be safe keeping this
-              # :nocov:
-              transaction.rollback!
-              # :nocov:
-            end
-          end
-        end
 
-        def commit_transaction
-          opened_transactions.reverse.each(&:commit!)
+          @relevant_entity_classes = [*entity_classes, *self.class.depends_on_entities].uniq
         end
       end
     end

data/projects/command/src/state_machine.rb

@@ -1,31 +1,31 @@
 module Foobara
   class Command
     class StateMachine < Foobara::StateMachine
-      transitions = %i[
-        open_transaction
-        cast_and_validate_inputs
-        load_records
-        validate_records
-        validate
-        run_execute
-        commit_transaction
-        succeed
-        error
-        fail
-        reset
+      transitions = [
+        :open_transaction,
+        :cast_and_validate_inputs,
+        :load_records,
+        :validate_records,
+        :validate,
+        :run_execute,
+        :commit_transaction,
+        :succeed,
+        :error,
+        :fail,
+        :reset
       ]
 
-      terminal_states = %i[succeeded errored failed]
+      terminal_states = [:succeeded, :errored, :failed]
 
-      states = %i[
-        initialized
-        transaction_opened
-        inputs_casted_and_validated
-        loaded_records
-        validated_records
-        validated_execution
-        executing
-        transaction_committed
+      states = [
+        :initialized,
+        :transaction_opened,
+        :inputs_casted_and_validated,
+        :loaded_records,
+        :validated_records,
+        :validated_execution,
+        :executing,
+        :transaction_committed
       ] + terminal_states
 
       can_fail_states = states - terminal_states

data/projects/command_connectors/src/authenticator.rb

@@ -13,6 +13,10 @@ module Foobara
         @block = block
       end
 
+      def relevant_entity_classes(_request)
+        nil
+      end
+
       def symbol
         declaration_data[:symbol]
       end
@@ -26,7 +30,9 @@ module Foobara
       end
 
       def authenticate(request)
-        process_value!(request)
+        if applicable?(request)
+          process_value!(request)
+        end
       end
 
       def to_proc

data/projects/command_connectors/src/authenticator_selector.rb

@@ -24,6 +24,14 @@ module Foobara
       def authenticate(request)
         selector.process_value!(request)
       end
+
+      def relevant_entity_classes(request)
+        outcome = selector.processor_for(request)
+
+        if outcome.success?
+          outcome.result&.relevant_entity_classes(request)
+        end
+      end
     end
   end
 end

data/projects/command_connectors/src/command_connector/command_connector_error.rb

@@ -3,7 +3,7 @@ module Foobara
     class CommandConnectorError < Foobara::RuntimeError
       context({})
 
-      def initialize(message:, context: {})
+      def initialize(message:, symbol: nil, context: {})
         super
       end
     end

data/projects/command_connectors/src/command_connector/request.rb

@@ -2,9 +2,11 @@ module Foobara
   class CommandConnector
     class Request
       include TruncatedInspect
+      include NestedTransactionable
 
       # TODO: this feels like a smell of some sort...
       attr_accessor :command,
+                    :command_class,
                     :error,
                     :command_connector,
                     # Why aren't there serializers on the response?
@@ -12,12 +14,12 @@ module Foobara
                     :inputs,
                     :full_command_name,
                     :action,
-                    :response
-
-      attr_reader :command_class
+                    :response,
+                    :authenticated_user,
+                    :authenticated_credential
 
       def initialize(**opts)
-        valid_keys = %i[inputs full_command_name action serializers]
+        valid_keys = [:inputs, :full_command_name, :action, :serializers]
 
         invalid_keys = opts.keys - valid_keys
 
@@ -33,8 +35,8 @@ module Foobara
         self.serializers = Util.array(opts[:serializers]) if opts.key?(:serializers)
       end
 
-      def command_class=(klass)
-        @command_class = klass
+      def mutate_request
+        return if error
 
         # TODO: we really need to revisit these interfaces. Something is wrong.
         if command_class.respond_to?(:mutate_request)
@@ -42,6 +44,25 @@ module Foobara
         end
       end
 
+      def authenticate
+        return if error
+        return unless command_class.respond_to?(:requires_authentication) && command_class.requires_authentication
+
+        authenticated_user, authenticated_credential = authenticator.authenticate(self)
+
+        # TODO: why are these on the command instead of the request??
+        self.authenticated_user = authenticated_user
+        self.authenticated_credential = authenticated_credential
+
+        unless authenticated_user
+          self.error = CommandConnector::UnauthenticatedError.new
+        end
+      end
+
+      def authenticator
+        command_class.authenticator
+      end
+
       def serializer
         return @serializer if defined?(@serializer)
 
@@ -77,12 +98,10 @@ module Foobara
       end
 
       def outcome
-        outcome = command&.outcome
-
-        if outcome
-          outcome
-        elsif error
+        if error
           Outcome.error(error)
+        else
+          command&.outcome
         end
       end
 
@@ -94,8 +113,34 @@ module Foobara
         outcome.error_collection
       end
 
+      def relevant_entity_classes
+        if command_class.is_a?(::Class) && command_class < TransformedCommand
+          entity_classes = authenticator&.relevant_entity_classes(self)
+          [*entity_classes, *relevant_entity_classes_from_inputs_transformer]
+        end || []
+      end
+
       private
 
+      def relevant_entity_classes_from_inputs_transformer(
+        object = [*command_class.inputs_transformer, *command_class.result_transformer]
+      )
+        case object
+        when TypeDeclarations::TypedTransformer
+          relevant_entity_classes_from_inputs_transformer([*object.from_type, *object.to_type])
+        when Types::Type
+          relevant_entity_classes_for_type(object)
+        when ::Array
+          object.map do |o|
+            relevant_entity_classes_from_inputs_transformer(o)
+          end.flatten
+        when Value::Processor::Pipeline
+          relevant_entity_classes_from_inputs_transformer(object.processors)
+        else
+          []
+        end
+      end
+
       def objects_to_serializers(objects)
         objects.map do |object|
           case object

data/projects/command_connectors/src/command_connector/response.rb

@@ -22,6 +22,10 @@ module Foobara
       def success?
         request.success?
       end
+
+      def outcome
+        request.outcome
+      end
     end
   end
 end