fog-google 1.12.1 → 1.16.0

data/lib/fog/compute/google/models/network.rb

@@ -27,7 +27,7 @@ module Fog
         alias_method :ipv4_range, :i_pv4_range
 
         def save
-          requires :identity, :ipv4_range
+          requires :identity
 
           data = service.insert_network(identity, attributes)
           operation = Fog::Compute::Google::Operations.new(:service => service)

data/lib/fog/compute/google/models/operations.rb

@@ -14,11 +14,11 @@ module Fog
           }
 
           if zone
-            data = service.list_zone_operations(zone, opts).to_h[:items]
+            data = service.list_zone_operations(zone, **opts).to_h[:items]
           elsif region
-            data = service.list_region_operations(region, opts).to_h[:items]
+            data = service.list_region_operations(region, **opts).to_h[:items]
           else
-            data = service.list_global_operations(opts).to_h[:items]
+            data = service.list_global_operations(**opts).to_h[:items]
           end
 
           load(data || [])

data/lib/fog/compute/google/models/servers.rb

@@ -14,10 +14,10 @@ module Fog
           }
 
           if zone
-            data = service.list_servers(zone, opts).to_h[:items] || []
+            data = service.list_servers(zone, **opts).to_h[:items] || []
           else
             data = []
-            service.list_aggregated_servers(opts).items.each_value do |scoped_lst|
+            service.list_aggregated_servers(**opts).items.each_value do |scoped_lst|
               if scoped_lst && scoped_lst.instances
                 data.concat(scoped_lst.instances.map(&:to_h))
               end
@@ -57,7 +57,7 @@ module Fog
               :zone_name => zone_name,
               :source_image => source_img.self_link
             }
-            disk = service.disks.create(disk_defaults.merge(opts))
+            disk = service.disks.create(**disk_defaults.merge(opts))
             disk.wait_for { disk.ready? }
 
             disks = [disk]
@@ -84,7 +84,10 @@ module Fog
           server.wait_for { ready? }
 
           # Set the disk to be autodeleted
-          server.set_disk_auto_delete(true)
+          # true - autodelete setting
+          # nil - device name (not needed if there's only one disk)
+          # false - set async to false so set the property synchronously
+          server.set_disk_auto_delete(true, nil, false)
 
           server
         end

data/lib/fog/compute/google/models/subnetworks.rb

@@ -13,10 +13,10 @@ module Fog
           }
 
           if region
-            data = service.list_subnetworks(region, filters).to_h[:items] || []
+            data = service.list_subnetworks(region, **filters).to_h[:items] || []
           else
             data = []
-            service.list_aggregated_subnetworks(filters).to_h[:items].each_value do |region_obj|
+            service.list_aggregated_subnetworks(**filters).to_h[:items].each_value do |region_obj|
               data.concat(region_obj[:subnetworks]) if region_obj[:subnetworks]
             end
           end

data/lib/fog/compute/google/models/target_instances.rb

@@ -14,10 +14,10 @@ module Fog
           }
 
           if zone
-            data = service.list_target_instances(zone, opts).to_h[:items] || []
+            data = service.list_target_instances(zone, **opts).to_h[:items] || []
           else
             data = []
-            service.list_aggregated_target_instances(opts).items.each_value do |scoped_list|
+            service.list_aggregated_target_instances(**opts).items.each_value do |scoped_list|
               unless scoped_list.nil? || scoped_list.target_instances.nil?
                 data += scoped_list.target_instances.map(&:to_h)
               end

data/lib/fog/compute/google/models/target_pools.rb

@@ -13,13 +13,13 @@ module Fog
           }
           if region.nil?
             data = []
-            service.list_aggregated_target_pools(opts).items.each_value do |lst|
+            service.list_aggregated_target_pools(**opts).items.each_value do |lst|
               unless lst.nil? || lst.target_pools.nil?
                 data += lst.to_h[:target_pools]
               end
             end
           else
-            data = service.list_target_pools(region, opts).to_h[:items]
+            data = service.list_target_pools(region, **opts).to_h[:items]
           end
           load(data)
         end

data/lib/fog/compute/google/models/url_maps.rb

@@ -12,7 +12,7 @@ module Fog
         def get(identity)
           if identity
             url_map = service.get_url_map(identity).to_h
-            return new(url_map)
+            return new(**url_map)
           end
         rescue ::Google::Apis::ClientError => e
           raise e unless e.status_code == 404

data/lib/fog/compute/google/requests/abandon_instances.rb

@@ -12,7 +12,7 @@ module Fog
       class Real
         def abandon_instances(instance_group_manager, instances)
           request = ::Google::Apis::ComputeV1::InstanceGroupManagersAbandonInstancesRequest.new(
-            :instances => instances.map{ |i| i.class == String ? i : i.self_link }
+            instances: instances.map{ |i| i.class == String ? i : i.self_link }
           )
           if instance_group_manager.zone
             zone = instance_group_manager.zone.split("/")[-1]

data/lib/fog/compute/google/requests/add_instance_group_instances.rb

@@ -13,16 +13,16 @@ module Fog
         def add_instance_group_instances(group_name, zone, instances)
           instances.map! do |instance|
             if instance.start_with?("https:")
-              ::Google::Apis::ComputeV1::InstanceReference.new(:instance => instance)
+              ::Google::Apis::ComputeV1::InstanceReference.new(instance: instance)
             else
               ::Google::Apis::ComputeV1::InstanceReference.new(
-                :instance => "https://www.googleapis.com/compute/#{api_version}/projects/#{@project}/zones/#{zone}/instances/#{instance}\n"
+                instance: "https://www.googleapis.com/compute/#{api_version}/projects/#{@project}/zones/#{zone}/instances/#{instance}\n"
               )
             end
           end
 
           request = ::Google::Apis::ComputeV1::InstanceGroupsAddInstancesRequest.new(
-            :instances => instances
+            instances: instances
           )
           @compute.add_instance_group_instances(
             @project,

data/lib/fog/compute/google/requests/add_server_access_config.rb

@@ -20,9 +20,9 @@ module Fog
             identity,
             network_interface,
             ::Google::Apis::ComputeV1::AccessConfig.new(
-              :name => access_config_name,
-              :nat_ip => nat_ip,
-              :type => "ONE_TO_ONE_NAT"
+              name: access_config_name,
+              nat_ip: nat_ip,
+              type: "ONE_TO_ONE_NAT"
             )
           )
         end

data/lib/fog/compute/google/requests/add_target_pool_health_checks.rb

@@ -13,7 +13,7 @@ module Fog
         def add_target_pool_health_checks(target_pool, region, health_checks)
           check_list = health_checks.map do |health_check|
             ::Google::Apis::ComputeV1::HealthCheckReference.new(
-              :health_check => health_check
+              health_check: health_check
             )
           end
 
@@ -22,7 +22,7 @@ module Fog
             region.split("/")[-1],
             target_pool,
             ::Google::Apis::ComputeV1::AddTargetPoolsHealthCheckRequest.new(
-              :health_checks => check_list
+              health_checks: check_list
             )
           )
         end

data/lib/fog/compute/google/requests/add_target_pool_instances.rb

@@ -12,7 +12,7 @@ module Fog
       class Real
         def add_target_pool_instances(target_pool, region, instances)
           instances_lst = instances.map do |instance|
-            ::Google::Apis::ComputeV1::InstanceReference.new(:instance => instance)
+            ::Google::Apis::ComputeV1::InstanceReference.new(instance: instance)
           end
 
           @compute.add_target_pool_instance(
@@ -20,7 +20,7 @@ module Fog
             region.split("/")[-1],
             target_pool,
             ::Google::Apis::ComputeV1::AddTargetPoolsInstanceRequest.new(
-              :instances => instances_lst
+              instances: instances_lst
             )
           )
         end

data/lib/fog/compute/google/requests/attach_disk.rb

@@ -13,7 +13,7 @@ module Fog
         def attach_disk(instance, zone, disk = {})
           @compute.attach_disk(
             @project, zone.split("/")[-1], instance,
-            ::Google::Apis::ComputeV1::AttachedDisk.new(disk)
+            ::Google::Apis::ComputeV1::AttachedDisk.new(**disk)
           )
         end
       end

data/lib/fog/compute/google/requests/create_disk_snapshot.rb

@@ -14,7 +14,7 @@ module Fog
           @compute.create_disk_snapshot(
             @project, zone, disk,
             ::Google::Apis::ComputeV1::Snapshot.new(
-              snapshot.merge(:name => snapshot_name)
+              **snapshot.merge(name: snapshot_name)
             )
           )
         end

data/lib/fog/compute/google/requests/expand_subnetwork_ip_cidr_range.rb

@@ -28,7 +28,7 @@ module Fog
           @compute.expand_subnetwork_ip_cidr_range(
             @project, region, subnetwork,
             ::Google::Apis::ComputeV1::SubnetworksExpandIpCidrRangeRequest.new(
-              :ip_cidr_range => ip_cidr_range
+              ip_cidr_range: ip_cidr_range
             )
           )
         end

data/lib/fog/compute/google/requests/get_backend_service_health.rb

@@ -12,7 +12,7 @@ module Fog
       class Real
         def get_backend_service_health(backend_service)
           health_results = backend_service.backends.map do |backend|
-            group = ::Google::Apis::ComputeV1::ResourceGroupReference.new(:group => backend[:group])
+            group = ::Google::Apis::ComputeV1::ResourceGroupReference.new(group: backend[:group])
             resp = @compute.get_backend_service_health(@project, backend_service.name, group)
             [backend[:group], resp.health_status]
           end

data/lib/fog/compute/google/requests/get_server_serial_port_output.rb

@@ -28,8 +28,8 @@ module Fog
             @project,
             zone.split("/")[-1],
             identity,
-            :port => port,
-            :start => start
+            port: port,
+            start: start
           )
         end
       end

data/lib/fog/compute/google/requests/get_target_pool_health.rb

@@ -14,7 +14,7 @@ module Fog
           @compute.get_target_pool_health(
             @project, region.split("/")[-1], target_pool,
             ::Google::Apis::ComputeV1::InstanceReference.new(
-              :instance => instance
+              instance: instance
             )
           )
         end

data/lib/fog/compute/google/requests/insert_address.rb

@@ -19,8 +19,8 @@ module Fog
         # @option options [String] :description Description of resource
         def insert_address(address_name, region_name, options = {})
           address = ::Google::Apis::ComputeV1::Address.new(
-            :name => address_name,
-            :description => options[:description]
+            name: address_name,
+            description: options[:description]
           )
           @compute.insert_address(@project, region_name, address)
         end

data/lib/fog/compute/google/requests/insert_backend_service.rb

@@ -14,7 +14,7 @@ module Fog
           options = opts.reject { |_k, v| v.nil? }
                         .merge(:name => backend_service_name)
 
-          be_service = ::Google::Apis::ComputeV1::BackendService.new(options)
+          be_service = ::Google::Apis::ComputeV1::BackendService.new(**options)
           @compute.insert_backend_service(@project, be_service)
         end
       end

data/lib/fog/compute/google/requests/insert_disk.rb

@@ -39,7 +39,7 @@ module Fog
             :source_image => source_image
           }
           disk_opts[:labels] = labels if labels
-          disk = ::Google::Apis::ComputeV1::Disk.new(disk_opts)
+          disk = ::Google::Apis::ComputeV1::Disk.new(**disk_opts)
           @compute.insert_disk(@project, zone.split("/")[-1], disk)
         end
       end

data/lib/fog/compute/google/requests/insert_firewall.rb

@@ -56,7 +56,7 @@ module Fog
                      .merge(:name => firewall_name)
 
           @compute.insert_firewall(
-            @project, ::Google::Apis::ComputeV1::Firewall.new(opts)
+            @project, ::Google::Apis::ComputeV1::Firewall.new(**opts)
           )
         end
       end

data/lib/fog/compute/google/requests/insert_forwarding_rule.rb

@@ -19,7 +19,7 @@ module Fog
           @compute.insert_forwarding_rule(
             @project, region,
             ::Google::Apis::ComputeV1::ForwardingRule.new(
-              opts.merge(:name => rule_name)
+              **opts.merge(:name => rule_name)
             )
           )
         end

data/lib/fog/compute/google/requests/insert_global_address.rb

@@ -16,7 +16,7 @@ module Fog
           opts = options.select { |k, _| INSERTABLE_ADDRESS_FIELDS.include? k }
                         .merge(:name => address_name)
           @compute.insert_global_address(
-            @project, ::Google::Apis::ComputeV1::Address.new(opts)
+            @project, ::Google::Apis::ComputeV1::Address.new(**opts)
           )
         end
       end

data/lib/fog/compute/google/requests/insert_global_forwarding_rule.rb

@@ -17,7 +17,7 @@ module Fog
         def insert_global_forwarding_rule(rule_name, opts = {})
           opts = opts.merge(:name => rule_name)
           @compute.insert_global_forwarding_rule(
-            @project, ::Google::Apis::ComputeV1::ForwardingRule.new(opts)
+            @project, ::Google::Apis::ComputeV1::ForwardingRule.new(**opts)
           )
         end
       end

data/lib/fog/compute/google/requests/insert_http_health_check.rb

@@ -14,7 +14,7 @@ module Fog
           @compute.insert_http_health_check(
             @project,
             ::Google::Apis::ComputeV1::HttpHealthCheck.new(
-              opts.merge(:name => check_name)
+              **opts.merge(:name => check_name)
             )
           )
         end

data/lib/fog/compute/google/requests/insert_image.rb

@@ -14,7 +14,7 @@ module Fog
           image = image.merge(:name => image_name)
           @compute.insert_image(
             project,
-            ::Google::Apis::ComputeV1::Image.new(image)
+            ::Google::Apis::ComputeV1::Image.new(**image)
           )
         end
       end

data/lib/fog/compute/google/requests/insert_instance_group.rb

@@ -18,9 +18,9 @@ module Fog
           end
 
           instance_group = ::Google::Apis::ComputeV1::InstanceGroup.new(
-            :description => options["description"],
-            :name => group_name,
-            :network => "https://www.googleapis.com/compute/#{api_version}/projects/#{@project}/global/networks/#{network_name}"
+            description: options["description"],
+            name: group_name,
+            network: "https://www.googleapis.com/compute/#{api_version}/projects/#{@project}/global/networks/#{network_name}"
           )
 
           @compute.insert_instance_group(@project,

data/lib/fog/compute/google/requests/insert_instance_group_manager.rb

@@ -14,13 +14,13 @@ module Fog
         def insert_instance_group_manager(name, zone, instance_template, base_instance_name,
                                           target_size, target_pools, named_ports, description)
           instance_group_manager = ::Google::Apis::ComputeV1::InstanceGroupManager.new(
-            :description => description,
-            :name => name,
-            :instance_template => instance_template.self_link,
-            :base_instance_name => base_instance_name,
-            :target_size => target_size,
-            :named_ports => named_ports || [],
-            :target_pools => target_pools || [],
+            description: description,
+            name: name,
+            instance_template: instance_template.self_link,
+            base_instance_name: base_instance_name,
+            target_size: target_size,
+            named_ports: named_ports || [],
+            target_pools: target_pools || [],
           )
 
           @compute.insert_instance_group_manager(@project, zone, instance_group_manager)

data/lib/fog/compute/google/requests/insert_instance_template.rb

@@ -25,9 +25,9 @@ module Fog
         #   response object that represents the insertion operation.
         def insert_instance_template(name, properties, description)
           instance_template = ::Google::Apis::ComputeV1::InstanceTemplate.new(
-            :description => description,
-            :name => name,
-            :properties => properties,
+            description: description,
+            name: name,
+            properties: properties,
           )
 
           @compute.insert_instance_template(@project, instance_template)

data/lib/fog/compute/google/requests/insert_network.rb

@@ -10,22 +10,12 @@ module Fog
       end
 
       class Real
-        INSERTABLE_NETWORK_FIELDS = %i{
-          auto_create_subnetworks
-          description
-          gateway_i_pv4
-          i_pv4_range
-          name
-          routing_config
-        }.freeze
-
         def insert_network(network_name, opts = {})
-          opts = opts.select { |k, _| INSERTABLE_NETWORK_FIELDS.include? k }
-                     .merge(:name => network_name)
+          opts = opts.merge(:name => network_name)
 
           @compute.insert_network(
             @project,
-            ::Google::Apis::ComputeV1::Network.new(opts)
+            ::Google::Apis::ComputeV1::Network.new(**opts)
           )
         end
       end

data/lib/fog/compute/google/requests/insert_route.rb

@@ -15,16 +15,16 @@ module Fog
         # @see https://cloud.google.com/compute/docs/reference/latest/routes/insert
         def insert_route(route_name, network, dest_range, priority, options = {})
           route = ::Google::Apis::ComputeV1::Route.new(
-            :name => route_name,
-            :network => network,
-            :dest_range => dest_range,
-            :priority => priority,
-            :tags => options[:tags] || [],
-            :next_hop_instance => options[:next_hop_instance],
-            :next_hop_gateway => options[:next_hop_gateway],
-            :next_hop_ip => options[:next_hop_ip],
-            :next_hop_vpn_tunnel => options[:next_hop_vpn_tunnel],
-            :description => options[:description]
+            name: route_name,
+            network: network,
+            dest_range: dest_range,
+            priority: priority,
+            tags: options[:tags] || [],
+            next_hop_instance: options[:next_hop_instance],
+            next_hop_gateway: options[:next_hop_gateway],
+            next_hop_ip: options[:next_hop_ip],
+            next_hop_vpn_tunnel: options[:next_hop_vpn_tunnel],
+            description: options[:description]
           )
 
           @compute.insert_route(@project, route)

data/lib/fog/compute/google/requests/insert_server.rb

@@ -21,7 +21,7 @@ module Fog
 
           disk_lst = disks.map do |d|
             d = d.attached_disk_obj if d.is_a? Disk
-            ::Google::Apis::ComputeV1::AttachedDisk.new(d)
+            ::Google::Apis::ComputeV1::AttachedDisk.new(**d)
           end
           disk_lst.first.boot = true
           disk_lst
@@ -32,7 +32,7 @@ module Fog
             network_interfaces = [default_network_interface]
           end
           network_interfaces.map do |network|
-            ::Google::Apis::ComputeV1::NetworkInterface.new(network)
+            ::Google::Apis::ComputeV1::NetworkInterface.new(**network)
           end
         end
 
@@ -88,32 +88,32 @@ module Fog
           # Optional subclassed attributes
           if data[:guest_accelerators]
             data[:guest_accelerators] = data[:guest_accelerators].map do |acc_config|
-              ::Google::Apis::ComputeV1::AcceleratorConfig.new(acc_config)
+              ::Google::Apis::ComputeV1::AcceleratorConfig.new(**acc_config)
             end
           end
 
           if data[:metadata]
-            data[:metadata] = ::Google::Apis::ComputeV1::Metadata.new(options[:metadata])
+            data[:metadata] = ::Google::Apis::ComputeV1::Metadata.new(**options[:metadata])
           end
 
           if data[:scheduling]
-            data[:scheduling] = ::Google::Apis::ComputeV1::Scheduling.new(options[:scheduling])
+            data[:scheduling] = ::Google::Apis::ComputeV1::Scheduling.new(**options[:scheduling])
           end
 
           if data[:shielded_instance_config]
-            data[:shielded_instance_config] = ::Google::Apis::ComputeV1::ShieldedInstanceConfig.new(options[:shielded_instance_config])
+            data[:shielded_instance_config] = ::Google::Apis::ComputeV1::ShieldedInstanceConfig.new(**options[:shielded_instance_config])
           end
 
           if data[:tags]
             if options[:tags].is_a?(Array)
               # Process classic tag notation, i.e. ["fog"]
-              data[:tags] = ::Google::Apis::ComputeV1::Tags.new({ :items => options[:tags] })
+              data[:tags] = ::Google::Apis::ComputeV1::Tags.new(items: options[:tags])
             else
-              data[:tags] = ::Google::Apis::ComputeV1::Tags.new(options[:tags])
+              data[:tags] = ::Google::Apis::ComputeV1::Tags.new(**options[:tags])
             end
           end
 
-          instance = ::Google::Apis::ComputeV1::Instance.new(data)
+          instance = ::Google::Apis::ComputeV1::Instance.new(**data)
           @compute.insert_instance(@project, zone, instance)
         end
       end

data/lib/fog/compute/google/requests/insert_ssl_certificate.rb

@@ -14,10 +14,10 @@ module Fog
           @compute.insert_ssl_certificate(
             @project,
             ::Google::Apis::ComputeV1::SslCertificate.new(
-              :certificate => certificate,
-              :name => certificate_name,
-              :private_key => private_key,
-              :description => description
+              certificate: certificate,
+              name: certificate_name,
+              private_key: private_key,
+              description: description
             )
           )
         end

data/lib/fog/compute/google/requests/insert_subnetwork.rb

@@ -52,7 +52,7 @@ module Fog
             data
           end
 
-          subnetwork = ::Google::Apis::ComputeV1::Subnetwork.new(params)
+          subnetwork = ::Google::Apis::ComputeV1::Subnetwork.new(**params)
           @compute.insert_subnetwork(@project, region_name, subnetwork)
         end
       end

data/lib/fog/compute/google/requests/insert_target_http_proxy.rb

@@ -14,9 +14,9 @@ module Fog
           @compute.insert_target_http_proxy(
             @project,
             ::Google::Apis::ComputeV1::TargetHttpProxy.new(
-              :name => proxy_name,
-              :description => description,
-              :url_map => url_map
+              name: proxy_name,
+              description: description,
+              url_map: url_map
             )
           )
         end

data/lib/fog/compute/google/requests/insert_target_https_proxy.rb

@@ -16,10 +16,10 @@ module Fog
           @compute.insert_target_https_proxy(
             @project,
             ::Google::Apis::ComputeV1::TargetHttpsProxy.new(
-              :name => proxy_name,
-              :description => description,
-              :url_map => url_map,
-              :ssl_certificates => ssl_certificates
+              name: proxy_name,
+              description: description,
+              url_map: url_map,
+              ssl_certificates: ssl_certificates
             )
           )
         end

data/lib/fog/compute/google/requests/insert_target_instance.rb

@@ -15,7 +15,7 @@ module Fog
           @compute.insert_target_instance(
             @project, zone,
             ::Google::Apis::ComputeV1::TargetInstance.new(
-              target_instance.merge(:name => target_name)
+              **target_instance.merge(name: target_name)
             )
           )
         end

data/lib/fog/compute/google/requests/insert_target_pool.rb

@@ -12,7 +12,7 @@ module Fog
       class Real
         def insert_target_pool(target_pool_name, region, target_pool = {})
           pool_obj = ::Google::Apis::ComputeV1::TargetPool.new(
-            target_pool.merge(:name => target_pool_name)
+            **target_pool.merge(name: target_pool_name)
           )
           @compute.insert_target_pool(@project, region.split("/")[-1], pool_obj)
         end

data/lib/fog/compute/google/requests/insert_url_map.rb

@@ -16,7 +16,7 @@ module Fog
           url_map[:tests] = url_map[:tests] || []
 
           url_map_obj = ::Google::Apis::ComputeV1::UrlMap.new(
-            url_map.merge(:name => url_map_name)
+            **url_map.merge(:name => url_map_name)
           )
           # HACK: Currently URL map insert may fail even though the backend
           # service operation is done. Retriable is not used to not add another

data/lib/fog/compute/google/requests/invalidate_url_map_cache.rb

@@ -14,7 +14,7 @@ module Fog
           @compute.invalidate_url_map_cache(
             @project, url_map_name,
             ::Google::Apis::ComputeV1::CacheInvalidationRule.new(
-              :path => path, :host => host
+              path: path, host: host
             )
           )
         end