fog-google 1.12.1 → 1.16.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9cc4ba9bf8fde22a71d31839ce62dd6240461eef907a35a391aa09533526255d
-  data.tar.gz: 0b169c4358550f92aaba6069d5c152f4b56f0548e5b9fbd62fc9c0f695d312cb
+  metadata.gz: 3c2a96b4bd15024461fec8eef7f06eec40e0f3ea0ac38c4fe076a321f90af2d9
+  data.tar.gz: f05c9185882395140713d9ad79c10d6807c3e987ffac1e7b8b9852cf690671ab
 SHA512:
-  metadata.gz: cd4332084eb98372966c1be4d7ec259e1d89f2cc0d15022610519865126bbd2d821997a1183e083e87e0be18615d354430d0a2539c62b1473cceb28a1aabfdc9
-  data.tar.gz: 97b0ba463466505603f3903d3c21e8fd7cf43807488e4c0a0f5de55a6fc01850a165113dbf6714057f52e82bbf71cd9e2838d356fed36e73fac0dba53a6536fc
+  metadata.gz: 2aab3e033028612e70daa467b0bd8f3701f3e4ffc5ced7c8a773d2d8766b3d100d0ec8f9d36d11d6b346241e4958c42d36c0a43bdcb32c6058aae296399439a3
+  data.tar.gz: 03b82d1bdeee36bbce9fcf9c73a001bd7364d8885e975ad323d71cab3d1cf0fbdace93cee9509edcdb2fc5e058bd604e6d7d8befaaea356943337f5d159e63de

data/.github/dependabot.yml

@@ -0,0 +1,10 @@
+version: 2
+updates:
+  - package-ecosystem: "bundler"
+    directory: "/"
+    schedule:
+      interval: "daily"
+  - package-ecosystem: "github-actions"
+    directory: "/"
+    schedule:
+      interval: "daily"

data/.github/scripts/setup_creds.sh

@@ -0,0 +1,10 @@
+#!/bin/bash
+
+GOOGLE_PROJECT=$(curl "http://metadata.google.internal/computeMetadata/v1/project/project-id" -H "Metadata-Flavor: Google")
+
+# fog needs the google project to be specified even if it uses application-default creds
+cat >~/.fog <<EOL
+test:
+  google_project: ${GOOGLE_PROJECT}
+  google_application_default: true
+EOL

data/.github/workflows/integration.yml

@@ -0,0 +1,225 @@
+name: integration-tests
+
+on:
+  push:
+    branches: [ master ]
+  pull_request:
+    branches: [ master ]
+    types: [ assigned, opened, synchronize, reopened, labeled ]
+
+jobs:
+  test-compute-core:
+    runs-on: self-hosted
+    strategy:
+      matrix:
+        ruby-version: [ '2.7', '3.0' ]
+      # Integration tests from the same task cannot run in parallel yet due to cleanup
+      max-parallel: 1
+
+    steps:
+      - uses: actions/checkout@v2.3.4
+      - name: Set up Ruby
+        uses: ruby/setup-ruby@v1
+        env:
+          # Needs to be set up for self-hosted runners, see:
+          # https://github.com/ruby/setup-ruby#using-self-hosted-runners
+          # Image used in runners: summerwind/actions-runner
+          ImageOS: ubuntu20
+        with:
+          ruby-version: ${{ matrix.ruby-version }}
+          bundler-cache: true # runs 'bundle install' and caches installed gems automatically
+      - name: Install dependencies
+        run: bundle install
+      - name: Run tests
+        run: >-
+          ./.github/scripts/setup_creds.sh &&
+          bundle exec rake test:compute-core_compute
+
+  test-compute-networking:
+    runs-on: self-hosted
+    strategy:
+      matrix:
+        ruby-version: [ '2.7', '3.0' ]
+      # Integration tests from the same task cannot run in parallel yet due to cleanup
+      max-parallel: 1
+
+    steps:
+      - uses: actions/checkout@v2.3.4
+      - name: Set up Ruby
+        uses: ruby/setup-ruby@v1
+        env:
+          # Needs to be set up for self-hosted runners, see:
+          # https://github.com/ruby/setup-ruby#using-self-hosted-runners
+          # Image used in runners: summerwind/actions-runner
+          ImageOS: ubuntu20
+        with:
+          ruby-version: ${{ matrix.ruby-version }}
+          bundler-cache: true # runs 'bundle install' and caches installed gems automatically
+      - name: Install dependencies
+        run: bundle install
+      - name: Run tests
+        run: >-
+          ./.github/scripts/setup_creds.sh &&
+          bundle exec rake test:compute-core_networking
+
+  test-compute-instance_groups:
+    runs-on: self-hosted
+    strategy:
+      matrix:
+        ruby-version: [ '2.7', '3.0' ]
+      # Integration tests from the same task cannot run in parallel yet due to cleanup
+      max-parallel: 1
+
+    steps:
+      - uses: actions/checkout@v2.3.4
+      - name: Set up Ruby
+        uses: ruby/setup-ruby@v1
+        env:
+          # Needs to be set up for self-hosted runners, see:
+          # https://github.com/ruby/setup-ruby#using-self-hosted-runners
+          # Image used in runners: summerwind/actions-runner
+          ImageOS: ubuntu20
+        with:
+          ruby-version: ${{ matrix.ruby-version }}
+          bundler-cache: true # runs 'bundle install' and caches installed gems automatically
+      - name: Install dependencies
+        run: bundle install
+      - name: Run tests
+        run: >-
+          ./.github/scripts/setup_creds.sh &&
+          bundle exec rake test:compute-instance_groups
+
+  test-compute-loadbalancing:
+    runs-on: self-hosted
+    strategy:
+      matrix:
+        ruby-version: [ '2.7', '3.0' ]
+      # Integration tests from the same task cannot run in parallel yet due to cleanup
+      max-parallel: 1
+
+    steps:
+      - uses: actions/checkout@v2.3.4
+      - name: Set up Ruby
+        uses: ruby/setup-ruby@v1
+        env:
+          # Needs to be set up for self-hosted runners, see:
+          # https://github.com/ruby/setup-ruby#using-self-hosted-runners
+          # Image used in runners: summerwind/actions-runner
+          ImageOS: ubuntu20
+        with:
+          ruby-version: ${{ matrix.ruby-version }}
+          bundler-cache: true # runs 'bundle install' and caches installed gems automatically
+      - name: Install dependencies
+        run: bundle install
+      - name: Run tests
+        run: >-
+          ./.github/scripts/setup_creds.sh &&
+          bundle exec rake test:compute-loadbalancing
+
+  test-monitoring:
+    runs-on: self-hosted
+    strategy:
+      matrix:
+        ruby-version: [ '2.7', '3.0' ]
+      # Integration tests from the same task cannot run in parallel yet due to cleanup
+      max-parallel: 1
+
+    steps:
+      - uses: actions/checkout@v2.3.4
+      - name: Set up Ruby
+        uses: ruby/setup-ruby@v1
+        env:
+          # Needs to be set up for self-hosted runners, see:
+          # https://github.com/ruby/setup-ruby#using-self-hosted-runners
+          # Image used in runners: summerwind/actions-runner
+          ImageOS: ubuntu20
+        with:
+          ruby-version: ${{ matrix.ruby-version }}
+          bundler-cache: true # runs 'bundle install' and caches installed gems automatically
+      - name: Install dependencies
+        run: bundle install
+      - name: Run tests
+        run: >-
+          ./.github/scripts/setup_creds.sh &&
+          bundle exec rake test:monitoring
+
+  test-storage:
+    runs-on: self-hosted
+    strategy:
+      matrix:
+        ruby-version: [ '2.7', '3.0' ]
+      # Integration tests from the same task cannot run in parallel yet due to cleanup
+      max-parallel: 1
+
+    steps:
+      - uses: actions/checkout@v2.3.4
+      - name: Set up Ruby
+        uses: ruby/setup-ruby@v1
+        env:
+          # Needs to be set up for self-hosted runners, see:
+          # https://github.com/ruby/setup-ruby#using-self-hosted-runners
+          # Image used in runners: summerwind/actions-runner
+          ImageOS: ubuntu20
+        with:
+          ruby-version: ${{ matrix.ruby-version }}
+          bundler-cache: true # runs 'bundle install' and caches installed gems automatically
+      - name: Install dependencies
+        run: bundle install
+      - name: Run tests
+        run: >-
+          ./.github/scripts/setup_creds.sh &&
+          bundle exec rake test:storage
+
+  test-pubsub:
+    runs-on: self-hosted
+    strategy:
+      matrix:
+        ruby-version: [ '2.7', '3.0' ]
+      # Integration tests from the same task cannot run in parallel yet due to cleanup
+      max-parallel: 1
+
+    steps:
+      - uses: actions/checkout@v2.3.4
+      - name: Set up Ruby
+        uses: ruby/setup-ruby@v1
+        env:
+          # Needs to be set up for self-hosted runners, see:
+          # https://github.com/ruby/setup-ruby#using-self-hosted-runners
+          # Image used in runners: summerwind/actions-runner
+          ImageOS: ubuntu20
+        with:
+          ruby-version: ${{ matrix.ruby-version }}
+          bundler-cache: true # runs 'bundle install' and caches installed gems automatically
+      - name: Install dependencies
+        run: bundle install
+      - name: Run tests
+        run: >-
+          ./.github/scripts/setup_creds.sh &&
+          bundle exec rake test:pubsub
+
+  test-sql:
+    runs-on: self-hosted
+    strategy:
+      matrix:
+        ruby-version: [ '2.7', '3.0' ]
+      # Integration tests from the same task cannot run in parallel yet due to cleanup
+      max-parallel: 1
+
+    steps:
+      - uses: actions/checkout@v2.3.4
+      - name: Set up Ruby
+        uses: ruby/setup-ruby@v1
+        env:
+          # Needs to be set up for self-hosted runners, see:
+          # https://github.com/ruby/setup-ruby#using-self-hosted-runners
+          # Image used in runners: summerwind/actions-runner
+          ImageOS: ubuntu20
+        with:
+          ruby-version: ${{ matrix.ruby-version }}
+          bundler-cache: true # runs 'bundle install' and caches installed gems automatically
+      - name: Install dependencies
+        run: bundle install
+      - name: Run tests
+        run: >-
+          ./.github/scripts/setup_creds.sh &&
+          bundle exec rake test:sql

data/.github/workflows/stale.yml

@@ -0,0 +1,23 @@
+name: Mark stale issues and pull requests
+
+on:
+  schedule:
+  - cron: "30 1 * * *"
+
+jobs:
+  stale:
+
+    runs-on: ubuntu-latest
+
+    steps:
+    - uses: actions/stale@v4
+      with:
+        repo-token: ${{ secrets.GITHUB_TOKEN }}
+        days-before-stale: 60
+        days-before-close: 7
+        exempt-issue-labels: 'pinned,security'
+        exempt-pr-labels: 'pinned,security'
+        stale-issue-message: 'This issue has been marked inactive and will be closed if no further activity occurs.'
+        stale-pr-message: 'This pr has been marked inactive and will be closed if no further activity occurs.'
+        stale-issue-label: 'no-issue-activity'
+        stale-pr-label: 'no-pr-activity'

data/.github/workflows/unit.yml

@@ -0,0 +1,26 @@
+name: unit-tests
+
+on:
+  push:
+    branches: [ master ]
+  pull_request:
+    branches: [ master ]
+
+jobs:
+  test-unit:
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        ruby-version: ['2.5', '2.6', '2.7', '3.0', 'head', 'truffleruby-head']
+
+    steps:
+      - uses: actions/checkout@v2.3.4
+      - name: Set up Ruby
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby-version }}
+          bundler-cache: true # runs 'bundle install' and caches installed gems automatically
+      - name: Install dependencies
+        run: bundle install
+      - name: Run tests
+        run: bundle exec rake

data/CHANGELOG.md

@@ -6,6 +6,70 @@ This project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html
 
 ## Next
 
+## 1.16.0
+
+### User-facing
+
+#### Fixed
+
+- \#540 Bring back integration tests for Fog-Google and fix an array of small bugs/regressions [temikus]
+
+### Development changes
+
+#### Added
+
+- \#532 Add Truffleruby head to CI [gogainda]
+
+## 1.15.0
+
+### User-facing
+
+#### Fixed
+
+- \#534 Fix get_object not working with binary files [stanhu]
+
+## 1.14.0
+
+### User-facing
+
+#### Added
+
+- \#520 Support passing object properties to #copy_object [mshibuya]
+
+#### Fixed
+
+- \#530 Unescape slashes in urls [krokodaxl]
+
+- \#528 Fix Ruby 3.0 kwargs error in `#copy_object` [deeeki]
+
+- \#521 Unlink file temp file immediately [stanhu]
+
+- \#527 \#523 Fix Ruby 3.0 kwargs failures [stanhu]
+
+### Development changes
+
+#### Fixed
+
+- \#525 - Bump actions/checkout from 2 to 2.3.4
+
+- \#524 - Bump actions/stale from 3 to 3.0.18
+
+
+## 1.13.0
+
+### User-facing
+
+### Fixed
+
+fix deprecated URI.escape usage to support Ruby 3.0
+fix apply_client_options def to support Ruby 3.0
+
+### Development Changes
+
+Add github actions config and dependabot
+Drop travis usage
+
+### Added
 
 ## 1.12.1
 
@@ -447,4 +511,4 @@ We encourage people using 0.5.1 to upgrade.
 
 #### Added
 
-#### Fixed
+#### Fixed

data/README.md

@@ -1,6 +1,6 @@
 # Fog::Google
 
-[![Gem Version](https://badge.fury.io/rb/fog-google.svg)](http://badge.fury.io/rb/fog-google) [![Build Status](https://travis-ci.org/fog/fog-google.svg?branch=master)](https://travis-ci.org/fog/fog-google) [![codecov](https://codecov.io/gh/fog/fog-google/branch/master/graph/badge.svg)](https://codecov.io/gh/fog/fog-google) [![Dependabot Status](https://api.dependabot.com/badges/status?host=github&repo=fog/fog-google)](https://dependabot.com) [![Doc coverage](https://inch-ci.org/github/fog/fog-google.svg?branch=master)](https://inch-ci.org/github/fog/fog-google)
+[![Gem Version](https://badge.fury.io/rb/fog-google.svg)](http://badge.fury.io/rb/fog-google) [![Build Status](https://github.com/fog/fog-google/actions/workflows/ruby.yml/badge.svg)](https://github.com/fog/fog-google/actions/workflows/ruby.yml) [![codecov](https://codecov.io/gh/fog/fog-google/branch/master/graph/badge.svg)](https://codecov.io/gh/fog/fog-google) [![Dependabot Status](https://api.dependabot.com/badges/status?host=github&repo=fog/fog-google)](https://dependabot.com) [![Doc coverage](https://inch-ci.org/github/fog/fog-google.svg?branch=master)](https://inch-ci.org/github/fog/fog-google)
 
 The main maintainers for the Google sections are @icco, @Temikus and @plribeiro3000. Please send pull requests to them.
 
@@ -12,6 +12,16 @@ The main maintainers for the Google sections are @icco, @Temikus and @plribeiro3
 
 See **[MIGRATING.md](MIGRATING.md)** for migration between major versions.
 
+# Sponsors
+
+We're proud to be sponsored by MeisterLabs who are generously funding our CI stack. A small message from them:
+
+<img align="right" width=100 height=100 src="https://user-images.githubusercontent.com/2083229/125146917-d965a680-e16b-11eb-8ad2-611b39056ca2.png">
+
+*"As extensive users of fog-google we are excited to help! Meister is the company behind the productivity tools [MindMeister](https://www.mindmeister.com/), [MeisterTask](https://www.meistertask.com), and [MeisterNote](https://www.meisternote.com/). We are based in Vienna, Austria and we have a very talented international team who build our products on top of Ruby on Rails, Elixir, React and Redux. We are constantly looking for great talent in Engineering, so If you feel like taking on a new Ruby or Elixir challenge. get in touch, open jobs can be found [here](https://www.meisterlabs.com/jobs/)."*
+
+# Usage
+
 ## Storage
 
 There are two ways to access [Google Cloud Storage](https://cloud.google.com/storage/). The old S3 API and the new JSON API. `Fog::Storage::Google` will automatically direct you to the appropriate API based on the credentials you provide it.

data/fog-google.gemspec

@@ -18,18 +18,27 @@ Gem::Specification.new do |spec|
   spec.require_paths = ["lib"]
 
   # As of 0.1.1
-  spec.required_ruby_version = "~> 2.0"
+  spec.required_ruby_version = ">= 2.0"
 
   # Locked until https://github.com/fog/fog-google/issues/417 is resolved
   spec.add_dependency "fog-core", "<= 2.1.0"
   spec.add_dependency "fog-json", "~> 1.2"
   spec.add_dependency "fog-xml", "~> 0.1.0"
 
-  spec.add_dependency "google-api-client", ">= 0.44.2", "< 0.51"
+  spec.add_dependency "google-apis-storage_v1", "~> 0.6"
+  spec.add_dependency "google-apis-iamcredentials_v1", "~> 0.6"
+  spec.add_dependency "google-apis-compute_v1", "~> 0.14"
+  spec.add_dependency "google-apis-monitoring_v3", "~> 0.12"
+  spec.add_dependency "google-apis-dns_v1", "~> 0.12"
+  spec.add_dependency "google-apis-pubsub_v1", "~> 0.7"
+  spec.add_dependency "google-apis-sqladmin_v1beta4", "~> 0.13"
+
   spec.add_dependency "google-cloud-env", "~> 1.2"
 
   # Debugger
-  spec.add_development_dependency "pry"
+  # Locked because pry-byebug is broken with 13+
+  # see: https://github.com/deivid-rodriguez/pry-byebug/issues/343
+  spec.add_development_dependency "pry", "= 0.13.0"
 
   # Testing gems
   spec.add_development_dependency "retriable"

data/lib/fog/compute/google/models/address.rb

@@ -38,7 +38,7 @@ module Fog
 
           data = service.insert_address(identity, region, attributes)
           operation = Fog::Compute::Google::Operations
-                      .new(:service => service)
+                      .new(service: service)
                       .get(data.name, nil, data.region)
           operation.wait_for { ready? }
           reload

data/lib/fog/compute/google/models/addresses.rb

@@ -13,10 +13,10 @@ module Fog
           }
 
           if region
-            data = service.list_addresses(region, opts).items || []
+            data = service.list_addresses(region, **opts).items || []
           else
             data = []
-            service.list_aggregated_addresses(opts).items.each_value do |scoped_list|
+            service.list_aggregated_addresses(**opts).items.each_value do |scoped_list|
               data.concat(scoped_list.addresses) if scoped_list && scoped_list.addresses
             end
           end
@@ -28,8 +28,8 @@ module Fog
             address = service.get_address(identity, region).to_h
             return new(address)
           elsif identity
-            response = all(:filter => "name eq #{identity}",
-                           :max_results => 1)
+            response = all(filter: "name eq #{identity}",
+                           max_results: 1)
             address = response.first unless response.empty?
             return address
           end
@@ -39,7 +39,7 @@ module Fog
         end
 
         def get_by_ip_address(ip_address)
-          addresses = service.list_aggregated_addresses(:filter => "address eq .*#{ip_address}").items
+          addresses = service.list_aggregated_addresses(filter: "address eq .*#{ip_address}").items
           address = addresses.each_value.select(&:addresses)
 
           return nil if address.empty?
@@ -47,7 +47,7 @@ module Fog
         end
 
         def get_by_name(ip_name)
-          names = service.list_aggregated_addresses(:filter => "name eq .*#{ip_name}").items
+          names = service.list_aggregated_addresses(filter: "name eq .*#{ip_name}").items
           name = names.each_value.select(&:addresses)
 
           return nil if name.empty?

data/lib/fog/compute/google/models/backend_service.rb

@@ -29,7 +29,7 @@ module Fog
             :timeout_sec => timeout_sec
           }
 
-          data = service.insert_backend_service(name, options)
+          data = service.insert_backend_service(name, **options)
           operation = Fog::Compute::Google::Operations.new(:service => service).get(data.name)
           operation.wait_for { ready? }
           reload

data/lib/fog/compute/google/models/disk.rb

@@ -51,8 +51,8 @@ module Fog
 
           # Request needs backward compatibility so source image is specified in
           # method arguments
-          data = service.insert_disk(name, zone, options[:source_image], options)
-          operation = Fog::Compute::Google::Operations.new(:service => service)
+          data = service.insert_disk(name, zone, options[:source_image], **options)
+          operation = Fog::Compute::Google::Operations.new(service: service)
                                                       .get(data.name, data.zone)
           operation.wait_for { ready? }
           reload
@@ -103,7 +103,7 @@ module Fog
         # @return [Hash] Attached disk configuration hash
         def attached_disk_obj(opts = {})
           requires :self_link
-          collection.attached_disk_obj(self_link, opts)
+          collection.attached_disk_obj(self_link, **opts)
         end
 
         # A legacy shorthand for attached_disk_obj

data/lib/fog/compute/google/models/disk_types.rb

@@ -13,10 +13,10 @@ module Fog
             :page_token => page_token
           }
           if zone
-            data = service.list_disk_types(zone, opts).items
+            data = service.list_disk_types(zone, **opts).items
           else
             data = []
-            service.list_aggregated_disk_types(opts).items.each_value do |scoped_lst|
+            service.list_aggregated_disk_types(**opts).items.each_value do |scoped_lst|
               data.concat(scoped_lst.disk_types) if scoped_lst && scoped_lst.disk_types
             end
           end

data/lib/fog/compute/google/models/disks.rb

@@ -13,10 +13,10 @@ module Fog
             :page_token => page_token
           }
           if zone
-            data = service.list_disks(zone, opts).items || []
+            data = service.list_disks(zone, **opts).items || []
           else
             data = []
-            service.list_aggregated_disks(opts).items.each_value do |scoped_list|
+            service.list_aggregated_disks(**opts).items.each_value do |scoped_list|
               data.concat(scoped_list.disks) if scoped_list.disks
             end
           end

data/lib/fog/compute/google/models/firewall.rb

@@ -53,7 +53,7 @@ module Fog
 
         def create
           data = service.insert_firewall(identity, attributes)
-          operation = Fog::Compute::Google::Operations.new(:service => service)
+          operation = Fog::Compute::Google::Operations.new(service: service)
                                                       .get(data.name)
           operation.wait_for { ready? }
           reload
@@ -63,7 +63,7 @@ module Fog
           requires :identity, :allowed, :network
 
           data = service.update_firewall(identity, attributes)
-          operation = Fog::Compute::Google::Operations.new(:service => service)
+          operation = Fog::Compute::Google::Operations.new(service: service)
                                                       .get(data.name)
           operation.wait_for { ready? }
           reload

data/lib/fog/compute/google/models/firewalls.rb

@@ -5,7 +5,7 @@ module Fog
         model Fog::Compute::Google::Firewall
 
         def all(opts = {})
-          data = service.list_firewalls(opts).to_h[:items]
+          data = service.list_firewalls(**opts).to_h[:items]
           load(data || [])
         end
 

data/lib/fog/compute/google/models/forwarding_rules.rb

@@ -13,10 +13,10 @@ module Fog
           }
 
           if region
-            data = service.list_forwarding_rules(region, opts).items || []
+            data = service.list_forwarding_rules(region, **opts).items || []
           else
             data = []
-            service.list_aggregated_forwarding_rules(opts).items
+            service.list_aggregated_forwarding_rules(**opts).items
                    .each_value do |scoped_list|
               if scoped_list && scoped_list.forwarding_rules
                 data.concat(scoped_list.forwarding_rules)

data/lib/fog/compute/google/models/global_addresses.rb

@@ -5,7 +5,7 @@ module Fog
         model Fog::Compute::Google::GlobalAddress
 
         def all(options = {})
-          data = service.list_global_addresses(options).to_h[:items] || []
+          data = service.list_global_addresses(**options).to_h[:items] || []
           load(data)
         end
 

data/lib/fog/compute/google/models/global_forwarding_rules.rb

@@ -5,7 +5,7 @@ module Fog
         model Fog::Compute::Google::GlobalForwardingRule
 
         def all(opts = {})
-          data = service.list_global_forwarding_rules(opts).to_h[:items] || []
+          data = service.list_global_forwarding_rules(**opts).to_h[:items] || []
           load(data)
         end
 

data/lib/fog/compute/google/models/http_health_check.rb

@@ -51,7 +51,7 @@ module Fog
           requires :name
 
           data = service.insert_http_health_check(name, opts)
-          operation = Fog::Compute::Google::Operations.new(:service => service)
+          operation = Fog::Compute::Google::Operations.new(service: service)
                                                       .get(data.name, data.zone)
           operation.wait_for { ready? }
           reload
@@ -60,7 +60,7 @@ module Fog
         def update(opts)
           requires :name
           data = service.update_http_health_check(name, opts)
-          operation = Fog::Compute::Google::Operations.new(:service => service)
+          operation = Fog::Compute::Google::Operations.new(service: service)
                                                       .get(data.name, data.zone)
           operation.wait_for { ready? }
           reload

data/lib/fog/compute/google/models/instance_group_managers.rb

@@ -14,10 +14,10 @@ module Fog
           }
 
           if zone
-            data = service.list_instance_group_managers(zone, opts).items || []
+            data = service.list_instance_group_managers(zone, **opts).items || []
           else
             data = []
-            service.list_aggregated_instance_group_managers(opts).items.each_value do |group|
+            service.list_aggregated_instance_group_managers(**opts).items.each_value do |group|
               data.concat(group.instance_group_managers) if group.instance_group_managers
             end
           end

data/lib/fog/compute/google/models/machine_types.rb

@@ -13,10 +13,10 @@ module Fog
           }
 
           if zone
-            data = service.list_machine_types(zone, opts).items
+            data = service.list_machine_types(zone, **opts).items
           else
             data = []
-            service.list_aggregated_machine_types(opts).items.each_value do |scoped_list|
+            service.list_aggregated_machine_types(**opts).items.each_value do |scoped_list|
               data.concat(scoped_list.machine_types) if scoped_list && scoped_list.machine_types
             end
           end