flipper 1.3.2 → 1.4.1

data/spec/flipper_integration_spec.rb

@@ -600,6 +600,139 @@ RSpec.describe Flipper do
     end
   end
 
+  context "for FeatureEnabled" do
+    before do
+      @original_instance = Flipper.instance
+      Flipper.instance = flipper
+    end
+
+    after do
+      Flipper.instance = @original_instance
+      Thread.current[:flipper_evaluating_features] = nil
+    end
+
+    it "returns true when referenced feature is enabled" do
+      flipper.enable(:search_beta)
+      feature.enable Flipper.feature_enabled(:search_beta)
+
+      expect(feature.enabled?).to be(true)
+    end
+
+    it "returns false when referenced feature is disabled" do
+      feature.enable Flipper.feature_enabled(:search_beta)
+
+      expect(feature.enabled?).to be(false)
+    end
+
+    it "passes actor through to referenced feature" do
+      flipper.enable_actor(:search_beta, pitt)
+      feature.enable Flipper.feature_enabled(:search_beta)
+
+      expect(feature.enabled?(pitt)).to be(true)
+      expect(feature.enabled?(clooney)).to be(false)
+    end
+
+    it "returns false on circular dependency" do
+      feature.enable Flipper.feature_enabled(:other)
+      flipper[:other].enable Flipper.feature_enabled(:search)
+
+      expect(feature.enabled?).to be(false)
+    end
+
+    it "returns false on self-reference" do
+      feature.enable Flipper.feature_enabled(:search)
+
+      expect(feature.enabled?).to be(false)
+    end
+
+    it "cleans up thread-local state after evaluation" do
+      flipper.enable(:search_beta)
+      feature.enable Flipper.feature_enabled(:search_beta)
+
+      feature.enabled?
+      evaluating = Thread.current[:flipper_evaluating_features]
+      expect(evaluating.nil? || evaluating.empty?).to be(true)
+    end
+
+    it "cleans up thread-local state after self-reference" do
+      feature.enable Flipper.feature_enabled(:search)
+
+      feature.enabled?
+      evaluating = Thread.current[:flipper_evaluating_features]
+      expect(evaluating.nil? || evaluating.empty?).to be(true)
+    end
+
+    it "cleans up thread-local state after circular dependency" do
+      feature.enable Flipper.feature_enabled(:other)
+      flipper[:other].enable Flipper.feature_enabled(:search)
+
+      feature.enabled?
+      evaluating = Thread.current[:flipper_evaluating_features]
+      expect(evaluating.nil? || evaluating.empty?).to be(true)
+    end
+  end
+
+  context "for FeatureDisabled" do
+    before do
+      @original_instance = Flipper.instance
+      Flipper.instance = flipper
+    end
+
+    after do
+      Flipper.instance = @original_instance
+      Thread.current[:flipper_evaluating_features] = nil
+    end
+
+    it "returns true when referenced feature is disabled" do
+      feature.enable Flipper.feature_disabled(:old_checkout)
+
+      expect(feature.enabled?).to be(true)
+    end
+
+    it "returns false when referenced feature is enabled" do
+      flipper.enable(:old_checkout)
+      feature.enable Flipper.feature_disabled(:old_checkout)
+
+      expect(feature.enabled?).to be(false)
+    end
+  end
+
+  context "for FeatureEnabled composed with other expressions" do
+    before do
+      @original_instance = Flipper.instance
+      Flipper.instance = flipper
+    end
+
+    after do
+      Flipper.instance = @original_instance
+      Thread.current[:flipper_evaluating_features] = nil
+    end
+
+    it "works with Any" do
+      feature.enable Flipper.any(
+        Flipper.feature_enabled(:beta_program),
+        Flipper.property(:plan).eq("basic")
+      )
+
+      expect(feature.enabled?(basic_plan_actor)).to be(true)
+      expect(feature.enabled?(premium_plan_actor)).to be(false)
+
+      flipper.enable(:beta_program)
+      expect(feature.enabled?(premium_plan_actor)).to be(true)
+    end
+
+    it "works with All" do
+      flipper.enable(:basic_search)
+      feature.enable Flipper.all(
+        Flipper.feature_enabled(:basic_search),
+        Flipper.property(:plan).eq("basic")
+      )
+
+      expect(feature.enabled?(basic_plan_actor)).to be(true)
+      expect(feature.enabled?(premium_plan_actor)).to be(false)
+    end
+  end
+
   context "for All" do
     it "works" do
       true_actor = Flipper::Actor.new("User;1", {

data/spec/flipper_spec.rb

@@ -218,6 +218,11 @@ RSpec.describe Flipper do
       expect(described_class.adapter).to eq(described_class.instance.adapter)
     end
 
+    it 'delegates adapter_stack to instance' do
+      expect(described_class.adapter_stack).to eq(described_class.instance.adapter_stack)
+      expect(described_class.adapter_stack).to eq("memoizable -> memory")
+    end
+
     it 'delegates memoize= to instance' do
       expect(described_class.adapter.memoizing?).to be(false)
       described_class.memoize = true
@@ -254,7 +259,7 @@ RSpec.describe Flipper do
       end
       described_class.sync
       expect(described_class.sync_secret).to eq("tasty")
-      expect(stub).to have_been_requested
+      expect(stub).to have_been_made.at_least_once
     end
   end
 
@@ -313,7 +318,7 @@ RSpec.describe Flipper do
 
   describe '.group_exists' do
     it 'returns true if the group is already created' do
-      group = described_class.register('admins', &:admin?)
+      described_class.register('admins', &:admin?)
       expect(described_class.group_exists?(:admins)).to eq(true)
     end
 

data/spec/spec_helper.rb

@@ -2,12 +2,14 @@ $LOAD_PATH.unshift(File.expand_path('../../lib', __FILE__))
 
 require 'pp'
 require 'pathname'
-FlipperRoot = Pathname(__FILE__).dirname.join('..').expand_path
-
-require 'rubygems'
-require 'bundler'
+require 'bundler/setup'
 
-Bundler.setup(:default)
+require 'warning'
+Warning.ignore(/lib\/statsd/)
+Warning.ignore(/lib\/debug\//)
+Warning.ignore(/lib\/ice_age\//)
+Warning.ignore(/lib\/moneta\//)
+Warning.ignore(/lib\/mongo\//)
 
 require 'debug'
 require 'statsd'
@@ -20,6 +22,7 @@ require 'flipper/spec/shared_adapter_specs'
 require 'flipper/ui'
 require 'flipper/test_help'
 
+FlipperRoot = Pathname(__FILE__).dirname.join('..').expand_path
 Dir[FlipperRoot.join('spec/support/**/*.rb')].sort.each { |f| require f }
 
 # Disable telemetry logging in specs.
@@ -36,6 +39,13 @@ RSpec.configure do |config|
     Flipper.configuration = nil
   end
 
+  config.after(:example) do
+    # Stop any pollers started during the test BEFORE WebMock clears stubs
+    # in its own after hook (RSpec runs after hooks in reverse registration
+    # order, so ours runs first since webmock/rspec was required before this).
+    Flipper::Poller.reset if defined?(Flipper::Poller)
+  end
+
   config.disable_monkey_patching!
 
   config.filter_run focus: true

data/test_rails/generators/flipper/setup_generator_test.rb

@@ -17,6 +17,11 @@ class SetupGeneratorTest < Rails::Generators::TestCase
     end
   end
 
+  test "generates an initializer" do
+    run_generator
+    assert_file 'config/initializers/flipper.rb', /Flipper\.configure/
+  end
+
   test "does not invoke flipper:active_record generator if ActiveRecord adapter not defined" do
     # Ensure adapter not defined
     Flipper::Adapters.send(:remove_const, :ActiveRecord) rescue nil

data/test_rails/generators/flipper/update_generator_test.rb

@@ -65,7 +65,7 @@ class UpdateGeneratorTest < Rails::Generators::TestCase
 
     assert_migration "db/migrate/create_flipper_tables.rb" do |migration|
       assert_method :up, migration do |up|
-        assert_match /text :value/, up
+        assert_match(/text :value/, up)
       end
     end
 

data/test_rails/helper.rb

@@ -4,6 +4,9 @@ require 'minitest/autorun'
 require 'rails'
 require 'rails/test_help'
 
+require 'warning'
+Warning.ignore(/lib\/capybara\//)
+
 begin
   ActiveSupport::TestCase.test_order = :random
 rescue NoMethodError

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: flipper
 version: !ruby/object:Gem::Version
-  version: 1.3.2
+  version: 1.4.1
 platform: ruby
 authors:
 - John Nunemaker
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2024-11-19 00:00:00.000000000 Z
+date: 2026-03-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: concurrent-ruby
@@ -36,7 +36,10 @@ files:
 - ".github/dependabot.yml"
 - ".github/workflows/ci.yml"
 - ".github/workflows/examples.yml"
+- ".github/workflows/release.yml"
 - ".rspec"
+- ".superset/config.json"
+- CLAUDE.md
 - CODE_OF_CONDUCT.md
 - Changelog.md
 - Dockerfile
@@ -64,6 +67,9 @@ files:
 - examples/cloud/cloud_setup.rb
 - examples/cloud/forked.rb
 - examples/cloud/import.rb
+- examples/cloud/poll_interval/README.md
+- examples/cloud/poll_interval/client.rb
+- examples/cloud/poll_interval/server.rb
 - examples/cloud/threaded.rb
 - examples/configuring_default.rb
 - examples/dsl.rb
@@ -118,6 +124,7 @@ files:
 - lib/flipper/cloud/dsl.rb
 - lib/flipper/cloud/message_verifier.rb
 - lib/flipper/cloud/middleware.rb
+- lib/flipper/cloud/migrate.rb
 - lib/flipper/cloud/routes.rb
 - lib/flipper/cloud/telemetry.rb
 - lib/flipper/cloud/telemetry/backoff_policy.rb
@@ -140,8 +147,8 @@ files:
 - lib/flipper/expressions/any.rb
 - lib/flipper/expressions/boolean.rb
 - lib/flipper/expressions/comparable.rb
-- lib/flipper/expressions/duration.rb
 - lib/flipper/expressions/equal.rb
+- lib/flipper/expressions/feature_enabled.rb
 - lib/flipper/expressions/greater_than.rb
 - lib/flipper/expressions/greater_than_or_equal_to.rb
 - lib/flipper/expressions/less_than.rb
@@ -193,6 +200,7 @@ files:
 - lib/flipper/types/percentage_of_time.rb
 - lib/flipper/version.rb
 - lib/generators/flipper/setup_generator.rb
+- lib/generators/flipper/templates/initializer.rb
 - lib/generators/flipper/templates/update/migrations/01_create_flipper_tables.rb.erb
 - lib/generators/flipper/templates/update/migrations/02_change_flipper_gates_value_to_text.rb.erb
 - lib/generators/flipper/update_generator.rb
@@ -214,6 +222,7 @@ files:
 - spec/flipper/adapters/memoizable_spec.rb
 - spec/flipper/adapters/memory_spec.rb
 - spec/flipper/adapters/operation_logger_spec.rb
+- spec/flipper/adapters/poll_spec.rb
 - spec/flipper/adapters/pstore_spec.rb
 - spec/flipper/adapters/read_only_spec.rb
 - spec/flipper/adapters/strict_spec.rb
@@ -226,6 +235,7 @@ files:
 - spec/flipper/cloud/dsl_spec.rb
 - spec/flipper/cloud/message_verifier_spec.rb
 - spec/flipper/cloud/middleware_spec.rb
+- spec/flipper/cloud/migrate_spec.rb
 - spec/flipper/cloud/telemetry/backoff_policy_spec.rb
 - spec/flipper/cloud/telemetry/metric_spec.rb
 - spec/flipper/cloud/telemetry/metric_storage_spec.rb
@@ -244,7 +254,6 @@ files:
 - spec/flipper/expressions/all_spec.rb
 - spec/flipper/expressions/any_spec.rb
 - spec/flipper/expressions/boolean_spec.rb
-- spec/flipper/expressions/duration_spec.rb
 - spec/flipper/expressions/equal_spec.rb
 - spec/flipper/expressions/greater_than_or_equal_to_spec.rb
 - spec/flipper/expressions/greater_than_spec.rb
@@ -314,7 +323,8 @@ metadata:
   homepage_uri: https://www.flippercloud.io
   source_code_uri: https://github.com/flippercloud/flipper
   bug_tracker_uri: https://github.com/flippercloud/flipper/issues
-  changelog_uri: https://github.com/flippercloud/flipper/releases/tag/v1.3.2
+  changelog_uri: https://github.com/flippercloud/flipper/releases/tag/v1.4.1
+  funding_uri: https://github.com/sponsors/flippercloud
 post_install_message:
 rdoc_options: []
 require_paths:
@@ -330,112 +340,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.23
+rubygems_version: 3.5.22
 signing_key:
 specification_version: 4
 summary: Beautiful, performant feature flags for Ruby and Rails.
-test_files:
-- spec/fixtures/environment.rb
-- spec/fixtures/feature.json
-- spec/fixtures/flipper_pstore_1679087600.json
-- spec/flipper/actor_spec.rb
-- spec/flipper/adapter_builder_spec.rb
-- spec/flipper/adapter_spec.rb
-- spec/flipper/adapters/actor_limit_spec.rb
-- spec/flipper/adapters/dual_write_spec.rb
-- spec/flipper/adapters/failover_spec.rb
-- spec/flipper/adapters/failsafe_spec.rb
-- spec/flipper/adapters/http/client_spec.rb
-- spec/flipper/adapters/http_spec.rb
-- spec/flipper/adapters/instrumented_spec.rb
-- spec/flipper/adapters/memoizable_spec.rb
-- spec/flipper/adapters/memory_spec.rb
-- spec/flipper/adapters/operation_logger_spec.rb
-- spec/flipper/adapters/pstore_spec.rb
-- spec/flipper/adapters/read_only_spec.rb
-- spec/flipper/adapters/strict_spec.rb
-- spec/flipper/adapters/sync/feature_synchronizer_spec.rb
-- spec/flipper/adapters/sync/interval_synchronizer_spec.rb
-- spec/flipper/adapters/sync/synchronizer_spec.rb
-- spec/flipper/adapters/sync_spec.rb
-- spec/flipper/cli_spec.rb
-- spec/flipper/cloud/configuration_spec.rb
-- spec/flipper/cloud/dsl_spec.rb
-- spec/flipper/cloud/message_verifier_spec.rb
-- spec/flipper/cloud/middleware_spec.rb
-- spec/flipper/cloud/telemetry/backoff_policy_spec.rb
-- spec/flipper/cloud/telemetry/metric_spec.rb
-- spec/flipper/cloud/telemetry/metric_storage_spec.rb
-- spec/flipper/cloud/telemetry/submitter_spec.rb
-- spec/flipper/cloud/telemetry_spec.rb
-- spec/flipper/cloud_spec.rb
-- spec/flipper/configuration_spec.rb
-- spec/flipper/dsl_spec.rb
-- spec/flipper/engine_spec.rb
-- spec/flipper/export_spec.rb
-- spec/flipper/exporter_spec.rb
-- spec/flipper/exporters/json/export_spec.rb
-- spec/flipper/exporters/json/v1_spec.rb
-- spec/flipper/expression/builder_spec.rb
-- spec/flipper/expression_spec.rb
-- spec/flipper/expressions/all_spec.rb
-- spec/flipper/expressions/any_spec.rb
-- spec/flipper/expressions/boolean_spec.rb
-- spec/flipper/expressions/duration_spec.rb
-- spec/flipper/expressions/equal_spec.rb
-- spec/flipper/expressions/greater_than_or_equal_to_spec.rb
-- spec/flipper/expressions/greater_than_spec.rb
-- spec/flipper/expressions/less_than_or_equal_to_spec.rb
-- spec/flipper/expressions/less_than_spec.rb
-- spec/flipper/expressions/not_equal_spec.rb
-- spec/flipper/expressions/now_spec.rb
-- spec/flipper/expressions/number_spec.rb
-- spec/flipper/expressions/percentage_of_actors_spec.rb
-- spec/flipper/expressions/percentage_spec.rb
-- spec/flipper/expressions/property_spec.rb
-- spec/flipper/expressions/random_spec.rb
-- spec/flipper/expressions/string_spec.rb
-- spec/flipper/expressions/time_spec.rb
-- spec/flipper/feature_check_context_spec.rb
-- spec/flipper/feature_spec.rb
-- spec/flipper/gate_spec.rb
-- spec/flipper/gate_values_spec.rb
-- spec/flipper/gates/actor_spec.rb
-- spec/flipper/gates/boolean_spec.rb
-- spec/flipper/gates/expression_spec.rb
-- spec/flipper/gates/group_spec.rb
-- spec/flipper/gates/percentage_of_actors_spec.rb
-- spec/flipper/gates/percentage_of_time_spec.rb
-- spec/flipper/identifier_spec.rb
-- spec/flipper/instrumentation/log_subscriber_spec.rb
-- spec/flipper/instrumentation/statsd_subscriber_spec.rb
-- spec/flipper/instrumenters/memory_spec.rb
-- spec/flipper/instrumenters/noop_spec.rb
-- spec/flipper/middleware/memoizer_spec.rb
-- spec/flipper/middleware/setup_env_spec.rb
-- spec/flipper/model/active_record_spec.rb
-- spec/flipper/poller_spec.rb
-- spec/flipper/registry_spec.rb
-- spec/flipper/serializers/gzip_spec.rb
-- spec/flipper/serializers/json_spec.rb
-- spec/flipper/typecast_spec.rb
-- spec/flipper/types/actor_spec.rb
-- spec/flipper/types/boolean_spec.rb
-- spec/flipper/types/group_spec.rb
-- spec/flipper/types/percentage_of_actors_spec.rb
-- spec/flipper/types/percentage_of_time_spec.rb
-- spec/flipper/types/percentage_spec.rb
-- spec/flipper_integration_spec.rb
-- spec/flipper_spec.rb
-- spec/spec_helper.rb
-- spec/support/actor_names.yml
-- spec/support/descriptions.yml
-- spec/support/fail_on_output.rb
-- spec/support/fake_backoff_policy.rb
-- spec/support/fake_udp_socket.rb
-- spec/support/skippable.rb
-- spec/support/spec_helpers.rb
-- test/adapters/actor_limit_test.rb
-- test/adapters/memory_test.rb
-- test/adapters/pstore_test.rb
-- test/test_helper.rb
+test_files: []

data/lib/flipper/expressions/duration.rb

@@ -1,28 +0,0 @@
-module Flipper
-  module Expressions
-    class Duration
-      SECONDS_PER = {
-        "second" => 1,
-        "minute" => 60,
-        "hour" => 3600,
-        "day" => 86400,
-        "week" => 604_800,
-        "month" => 2_629_746,  # 1/12 of a gregorian year
-        "year" => 31_556_952 # length of a gregorian year (365.2425 days)
-      }.freeze
-
-      def self.call(scalar, unit = 'second')
-        unit = unit.to_s.downcase.chomp("s")
-
-        unless scalar.is_a?(Numeric)
-          raise ArgumentError.new("Duration value must be a number but was #{scalar.inspect}")
-        end
-        unless SECONDS_PER[unit]
-          raise ArgumentError.new("Duration unit #{unit.inspect} must be one of: #{SECONDS_PER.keys.join(', ')}")
-        end
-
-        scalar * SECONDS_PER[unit]
-      end
-    end
-  end
-end

data/spec/flipper/expressions/duration_spec.rb

@@ -1,43 +0,0 @@
-RSpec.describe Flipper::Expressions::Duration do
-  describe "#call" do
-    it "raises error with invalid value" do
-      expect { described_class.call(false, 'minute') }.to raise_error(ArgumentError)
-    end
-
-    it "raises error with invalid unit" do
-      expect { described_class.call(4, 'score') }.to raise_error(ArgumentError)
-    end
-
-    it 'defaults unit to seconds' do
-      expect(described_class.call(10)).to eq(10)
-    end
-
-    it "evaluates seconds" do
-      expect(described_class.call(10, 'seconds')).to eq(10)
-    end
-
-    it "evaluates minutes" do
-      expect(described_class.call(2, 'minutes')).to eq(120)
-    end
-
-    it "evaluates hours" do
-      expect(described_class.call(2, 'hours')).to eq(7200)
-    end
-
-    it "evaluates days" do
-      expect(described_class.call(2, 'days')).to eq(172_800)
-    end
-
-    it "evaluates weeks" do
-      expect(described_class.call(2, 'weeks')).to eq(1_209_600)
-    end
-
-    it "evaluates months" do
-      expect(described_class.call(2, 'months')).to eq(5_259_492)
-    end
-
-    it "evaluates years" do
-      expect(described_class.call(2, 'years')).to eq(63_113_904)
-    end
-  end
-end