flipper 1.3.2 → 1.4.1

data/spec/flipper/cloud/dsl_spec.rb

@@ -5,6 +5,9 @@ require 'flipper/adapters/instrumented'
 
 RSpec.describe Flipper::Cloud::DSL do
   it 'delegates everything to flipper instance' do
+    # stub the initial sync of http to local
+    stub_request(:get, /flippercloud\.io/).to_return(status: 200, body: "{}")
+
     cloud_configuration = Flipper::Cloud::Configuration.new({
       token: "asdf",
       sync_secret: "tasty",
@@ -27,10 +30,13 @@ RSpec.describe Flipper::Cloud::DSL do
     })
     dsl = described_class.new(cloud_configuration)
     dsl.sync
-    expect(stub).to have_been_requested
+    expect(stub).to have_been_requested.at_least_once
   end
 
   it 'delegates sync_secret to cloud configuration' do
+    # stub the initial sync of http to local
+    stub_request(:get, /flippercloud\.io/).to_return(status: 200, body: "{}")
+
     cloud_configuration = Flipper::Cloud::Configuration.new({
       token: "asdf",
       sync_secret: "tasty",
@@ -45,7 +51,7 @@ RSpec.describe Flipper::Cloud::DSL do
     end
 
     let(:cloud_configuration) do
-      cloud_configuration = Flipper::Cloud::Configuration.new({
+      Flipper::Cloud::Configuration.new({
         token: "asdf",
         sync_secret: "tasty",
         local_adapter: local_adapter
@@ -53,13 +59,15 @@ RSpec.describe Flipper::Cloud::DSL do
     end
 
     subject do
+      # stub the initial sync of http to local
+      stub_request(:get, /flippercloud\.io/).to_return(status: 200, body: "{}")
       described_class.new(cloud_configuration)
     end
 
     it "sends reads to local adapter" do
       subject.features
       subject.enabled?(:foo)
-      expect(local_adapter.count(:features)).to be(1)
+      expect(local_adapter.count(:features)).to be(2)
       expect(local_adapter.count(:get)).to be(1)
     end
 

data/spec/flipper/cloud/middleware_spec.rb

@@ -62,7 +62,7 @@ RSpec.describe Flipper::Cloud::Middleware do
           {"name" => "premium"},
         ],
       })
-      expect(stub).to have_been_requested
+      expect(stub).to have_been_made.at_least_once
     end
   end
 
@@ -72,15 +72,17 @@ RSpec.describe Flipper::Cloud::Middleware do
       Flipper::Cloud::MessageVerifier.new(secret: "nope").generate(request_body, timestamp)
     }
 
-    it 'uses instance to sync' do
-      stub = stub_request_for_token('regular')
+    it 'does not perform webhook sync' do
+      webhook_regular_stub = stub_request_for_token('regular', from_webhook: true)
+      poll_regular_stub = stub_request_for_token('regular', from_webhook: false)
       env = {
         "HTTP_FLIPPER_CLOUD_SIGNATURE" => signature_header_value,
       }
       post '/', request_body, env
 
       expect(last_response.status).to eq(400)
-      expect(stub).not_to have_been_requested
+      expect(poll_regular_stub).to have_been_requested.at_least_once
+      expect(webhook_regular_stub).not_to have_been_requested
     end
   end
 
@@ -103,7 +105,7 @@ RSpec.describe Flipper::Cloud::Middleware do
       expect(last_response.status).to eq(402)
       expect(last_response.headers["flipper-cloud-response-error-class"]).to eq("Flipper::Adapters::Http::Error")
       expect(last_response.headers["flipper-cloud-response-error-message"]).to include("Failed with status: 402")
-      expect(stub).to have_been_requested
+      expect(stub).to have_been_made.at_least_once
     end
   end
 
@@ -126,7 +128,7 @@ RSpec.describe Flipper::Cloud::Middleware do
       expect(last_response.status).to eq(500)
       expect(last_response.headers["flipper-cloud-response-error-class"]).to eq("Flipper::Adapters::Http::Error")
       expect(last_response.headers["flipper-cloud-response-error-message"]).to include("Failed with status: 503")
-      expect(stub).to have_been_requested
+      expect(stub).to have_been_made.at_least_once
     end
   end
 
@@ -149,7 +151,7 @@ RSpec.describe Flipper::Cloud::Middleware do
       expect(last_response.status).to eq(500)
       expect(last_response.headers["flipper-cloud-response-error-class"]).to eq("Net::OpenTimeout")
       expect(last_response.headers["flipper-cloud-response-error-message"]).to eq("execution expired")
-      expect(stub).to have_been_requested
+      expect(stub).to have_been_made.at_least_once
     end
   end
 
@@ -160,7 +162,8 @@ RSpec.describe Flipper::Cloud::Middleware do
     }
 
     it 'uses env instance to sync' do
-      stub = stub_request_for_token('env')
+      regular_stub = stub_request_for_token('regular')
+      env_stub = stub_request_for_token('env')
       env = {
         "HTTP_FLIPPER_CLOUD_SIGNATURE" => signature_header_value,
         'flipper' => env_flipper,
@@ -168,7 +171,8 @@ RSpec.describe Flipper::Cloud::Middleware do
       post '/', request_body, env
 
       expect(last_response.status).to eq(200)
-      expect(stub).to have_been_requested
+      expect(regular_stub).to have_been_made.at_least_once
+      expect(env_stub).to have_been_made.at_least_once
     end
   end
 
@@ -187,7 +191,7 @@ RSpec.describe Flipper::Cloud::Middleware do
       post '/', request_body, env
 
       expect(last_response.status).to eq(200)
-      expect(stub).to have_been_requested
+      expect(stub).to have_been_made.at_least_once
     end
   end
 
@@ -198,7 +202,9 @@ RSpec.describe Flipper::Cloud::Middleware do
     }
 
     it 'uses provided env key instead of default' do
-      stub = stub_request_for_token('env')
+      regular_poll_stub = stub_request_for_token('regular')
+      env_poll_stub = stub_request_for_token('env')
+      env_webhook_stub = stub_request_for_token('env', from_webhook: true)
       env = {
         "HTTP_FLIPPER_CLOUD_SIGNATURE" => signature_header_value,
         'flipper' => flipper,
@@ -207,7 +213,9 @@ RSpec.describe Flipper::Cloud::Middleware do
       post '/', request_body, env
 
       expect(last_response.status).to eq(200)
-      expect(stub).to have_been_requested
+      expect(regular_poll_stub).to have_been_made.at_least_once
+      expect(env_poll_stub).to have_been_made.at_least_once
+      expect(env_webhook_stub).not_to have_been_requested
     end
   end
 
@@ -222,7 +230,7 @@ RSpec.describe Flipper::Cloud::Middleware do
       post '/', request_body, env
 
       expect(last_response.status).to eq(200)
-      expect(stub).to have_been_requested
+      expect(stub).to have_been_made.at_least_once
     end
   end
 
@@ -252,12 +260,13 @@ RSpec.describe Flipper::Cloud::Middleware do
           {"name" => "premium"},
         ],
       })
-      expect(stub).to have_been_requested
+      expect(stub).to have_been_made.at_least_once
     end
   end
 
   describe 'Request method unsupported' do
     it 'skips middleware' do
+      stub_request(:get, /flippercloud\.io/).to_return(status: 200, body: "{}")
       get '/'
       expect(last_response.status).to eq(404)
       expect(last_response.content_type).to eq("application/json")
@@ -267,14 +276,23 @@ RSpec.describe Flipper::Cloud::Middleware do
 
   describe 'Inspecting the built Rack app' do
     it 'returns a String' do
+      stub_request(:get, /flippercloud\.io/).to_return(status: 200, body: "{}")
       expect(Flipper::Cloud.app(flipper).inspect).to eq("Flipper::Cloud")
     end
   end
 
   private
 
-  def stub_request_for_token(token, status: 200)
-    stub = stub_request(:get, "https://www.flippercloud.io/adapter/features?exclude_gate_names=true").
+  def stub_request_for_token(token, status: 200, from_webhook: false)
+    if from_webhook
+      # Match URL with both exclude_gate_names=true and _cb=integer
+      url_pattern = %r{https://www\.flippercloud\.io/adapter/features\?.*exclude_gate_names=true.*&_cb=\d+}
+    else
+      # Match URL with just exclude_gate_names=true
+      url_pattern = %r{https://www\.flippercloud\.io/adapter/features\?.*exclude_gate_names=true}
+    end
+
+    stub = stub_request(:get, url_pattern).
       with({
         headers: {
           'flipper-cloud-token' => token,

data/spec/flipper/cloud/migrate_spec.rb

@@ -0,0 +1,160 @@
+require "flipper/cloud/migrate"
+require "flipper/typecast"
+require "webmock/rspec"
+
+RSpec.describe Flipper::Cloud, ".migrate" do
+  let(:flipper) { Flipper.new(Flipper::Adapters::Memory.new) }
+
+  before do
+    flipper.enable :search
+    flipper.disable :analytics
+    flipper.enable_percentage_of_actors :checkout, 50
+  end
+
+  around do |example|
+    original = ENV["FLIPPER_CLOUD_URL"]
+    ENV["FLIPPER_CLOUD_URL"] = "http://localhost:5555"
+    example.run
+  ensure
+    ENV["FLIPPER_CLOUD_URL"] = original
+  end
+
+  def decompress_request_body
+    raw = WebMock::RequestRegistry.instance.requested_signatures.hash.keys.last.body
+    JSON.parse(Flipper::Typecast.from_gzip(raw))
+  end
+
+  describe ".migrate" do
+    it "returns a MigrateResult with code and url on success" do
+      stub_request(:post, "http://localhost:5555/api/migrate")
+        .to_return(status: 200, body: '{"url":"http://localhost:5555/cloud/setup/abc123"}', headers: {"Content-Type" => "application/json"})
+
+      result = Flipper::Cloud.migrate(flipper)
+
+      expect(result).to be_a(Flipper::Cloud::MigrateResult)
+      expect(result.code).to eq(200)
+      expect(result.url).to eq("http://localhost:5555/cloud/setup/abc123")
+    end
+
+    it "sends export data and metadata in the request body" do
+      stub = stub_request(:post, "http://localhost:5555/api/migrate")
+        .to_return(status: 200, body: '{"url":"http://localhost:5555/cloud/setup/abc123"}')
+
+      Flipper::Cloud.migrate(flipper, app_name: "MyApp")
+
+      expect(stub).to have_been_requested
+      body = decompress_request_body
+      expect(body["metadata"]["app_name"]).to eq("MyApp")
+      expect(body["export"]["version"]).to eq(1)
+      expect(body["export"]["features"]).to have_key("search")
+    end
+
+    it "sends gzip-compressed request body" do
+      stub = stub_request(:post, "http://localhost:5555/api/migrate")
+        .with(headers: {"content-encoding" => "gzip"})
+        .to_return(status: 200, body: '{"url":"http://localhost:5555/cloud/setup/abc"}')
+
+      Flipper::Cloud.migrate(flipper)
+
+      expect(stub).to have_been_requested
+      body = decompress_request_body
+      expect(body["export"]["features"]).to have_key("search")
+    end
+
+    it "handles error responses" do
+      stub_request(:post, "http://localhost:5555/api/migrate")
+        .to_return(status: 500, body: '{"error":"Internal Server Error"}')
+
+      result = Flipper::Cloud.migrate(flipper)
+
+      expect(result.code).to eq(500)
+      expect(result.url).to be_nil
+    end
+
+    it "includes error message from response body" do
+      stub_request(:post, "http://localhost:5555/api/migrate")
+        .to_return(status: 422, body: '{"error":"Invalid export format"}')
+
+      result = Flipper::Cloud.migrate(flipper)
+
+      expect(result.code).to eq(422)
+      expect(result.message).to eq("Invalid export format")
+    end
+
+    it "uses FLIPPER_CLOUD_URL environment variable" do
+      stub = stub_request(:post, "http://localhost:5555/api/migrate")
+        .to_return(status: 200, body: '{"url":"http://localhost:5555/cloud/setup/abc"}')
+
+      Flipper::Cloud.migrate(flipper)
+
+      expect(stub).to have_been_requested
+    end
+
+    it "sends content-type and accept headers" do
+      stub = stub_request(:post, "http://localhost:5555/api/migrate")
+        .with(headers: {
+          "content-type" => "application/json",
+          "accept" => "application/json",
+        })
+        .to_return(status: 200, body: '{"url":"http://localhost:5555/cloud/setup/abc"}')
+
+      Flipper::Cloud.migrate(flipper)
+
+      expect(stub).to have_been_requested
+    end
+  end
+
+  describe ".push" do
+    it "returns a MigrateResult with code on success" do
+      stub_request(:post, "http://localhost:5555/adapter/import")
+        .to_return(status: 204, body: "")
+
+      result = Flipper::Cloud.push("test-token", flipper)
+
+      expect(result).to be_a(Flipper::Cloud::MigrateResult)
+      expect(result.code).to eq(204)
+    end
+
+    it "sends the token as a header" do
+      stub = stub_request(:post, "http://localhost:5555/adapter/import")
+        .with(headers: {"flipper-cloud-token" => "test-token"})
+        .to_return(status: 204, body: "")
+
+      Flipper::Cloud.push("test-token", flipper)
+
+      expect(stub).to have_been_requested
+    end
+
+    it "sends gzip-compressed export contents as the body" do
+      stub = stub_request(:post, "http://localhost:5555/adapter/import")
+        .with(headers: {"content-encoding" => "gzip"})
+        .to_return(status: 204, body: "")
+
+      Flipper::Cloud.push("test-token", flipper)
+
+      expect(stub).to have_been_requested
+      body = decompress_request_body
+      expect(body["version"]).to eq(1)
+      expect(body["features"]).to have_key("search")
+    end
+
+    it "handles error responses" do
+      stub_request(:post, "http://localhost:5555/adapter/import")
+        .to_return(status: 401, body: '{"error":"Unauthorized"}')
+
+      result = Flipper::Cloud.push("bad-token", flipper)
+
+      expect(result.code).to eq(401)
+    end
+
+    it "includes error message from response body" do
+      stub_request(:post, "http://localhost:5555/adapter/import")
+        .to_return(status: 401, body: '{"error":"Invalid token"}')
+
+      result = Flipper::Cloud.push("bad-token", flipper)
+
+      expect(result.code).to eq(401)
+      expect(result.message).to eq("Invalid token")
+    end
+  end
+end

data/spec/flipper/cloud/telemetry/backoff_policy_spec.rb

@@ -4,8 +4,8 @@ RSpec.describe Flipper::Cloud::Telemetry::BackoffPolicy do
   context "#initialize" do
     it "with no options" do
       policy = described_class.new
-      expect(policy.min_timeout_ms).to eq(1_000)
-      expect(policy.max_timeout_ms).to eq(30_000)
+      expect(policy.min_timeout_ms).to eq(30_000)
+      expect(policy.max_timeout_ms).to eq(120_000)
       expect(policy.multiplier).to eq(1.5)
       expect(policy.randomization_factor).to eq(0.5)
     end
@@ -87,7 +87,7 @@ RSpec.describe Flipper::Cloud::Telemetry::BackoffPolicy do
         randomization_factor: 0.5,
       })
       10.times { policy.next_interval }
-      expect(policy.next_interval).to eq(10_000)
+      expect(policy.next_interval).to be_within(10_000*0.1).of(10_000)
     end
   end
 

data/spec/flipper/cloud/telemetry/submitter_spec.rb

@@ -71,15 +71,15 @@ RSpec.describe Flipper::Cloud::Telemetry::Submitter do
         to_return(status: 429, body: "{}").
         to_return(status: 200, body: "{}")
       instance = described_class.new(cloud_configuration)
-      expect(instance.backoff_policy.min_timeout_ms).to eq(1_000)
-      expect(instance.backoff_policy.max_timeout_ms).to eq(30_000)
+      expect(instance.backoff_policy.min_timeout_ms).to eq(30_000)
+      expect(instance.backoff_policy.max_timeout_ms).to eq(120_000)
     end
 
     it "tries 10 times by default" do
       stub_request(:post, "https://www.flippercloud.io/adapter/telemetry").
         to_return(status: 500, body: "{}")
       subject.call(enabled_metrics)
-      expect(subject.backoff_policy.retries).to eq(9) # 9 retries + 1 initial attempt
+      expect(subject.backoff_policy.retries).to eq(4) # 4 retries + 1 initial attempt
     end
 
     [
@@ -105,7 +105,7 @@ RSpec.describe Flipper::Cloud::Telemetry::Submitter do
         stub_request(:post, "https://www.flippercloud.io/adapter/telemetry").
           to_raise(error_class)
         subject.call(enabled_metrics)
-        expect(subject.backoff_policy.retries).to eq(9)
+        expect(subject.backoff_policy.retries).to eq(4)
       end
     end
 

data/spec/flipper/cloud/telemetry_spec.rb

@@ -25,7 +25,7 @@ RSpec.describe Flipper::Cloud::Telemetry do
 
     expect(telemetry.interval).to eq(60)
     expect(telemetry.timer.execution_interval).to eq(60)
-    expect(stub).to have_been_requested
+    expect(stub).to have_been_requested.at_least_once
   end
 
   it "phones home and updates telemetry interval if present" do
@@ -45,7 +45,7 @@ RSpec.describe Flipper::Cloud::Telemetry do
 
     expect(telemetry.interval).to eq(120)
     expect(telemetry.timer.execution_interval).to eq(120)
-    expect(stub).to have_been_requested
+    expect(stub).to have_been_requested.at_least_once
   end
 
   it "phones home and requests shutdown if telemetry-shutdown header is true" do
@@ -67,7 +67,7 @@ RSpec.describe Flipper::Cloud::Telemetry do
       result: true,
     })
     telemetry.stop
-    expect(stub).to have_been_requested
+    expect(stub).to have_been_requested.at_least_once
     expect(output.string).to match(/action=telemetry_shutdown message=The server has requested that telemetry be shut down./)
   end
 
@@ -90,7 +90,7 @@ RSpec.describe Flipper::Cloud::Telemetry do
       result: true,
     })
     telemetry.stop
-    expect(stub).to have_been_requested
+    expect(stub).to have_been_requested.at_least_once
     expect(output.string).not_to match(/action=telemetry_shutdown message=The server has requested that telemetry be shut down./)
   end
 
@@ -122,7 +122,7 @@ RSpec.describe Flipper::Cloud::Telemetry do
     # Check the conig interval and the timer interval.
     expect(telemetry.interval).to eq(120)
     expect(telemetry.timer.execution_interval).to eq(120)
-    expect(stub).to have_been_requested.times(10)
+    expect(stub).to have_been_requested.at_least_times(5)
   end
 
   it "doesn't try to update telemetry interval from error if not response error" do
@@ -152,7 +152,7 @@ RSpec.describe Flipper::Cloud::Telemetry do
 
     expect(telemetry.interval).to eq(60)
     expect(telemetry.timer.execution_interval).to eq(60)
-    expect(stub).to have_been_requested.times(10)
+    expect(stub).to have_been_requested.times(5)
   end
 
   describe '#record' do

data/spec/flipper/cloud_spec.rb

@@ -43,6 +43,7 @@ RSpec.describe Flipper::Cloud do
 
   context 'initialize with token and options' do
     it 'sets correct url' do
+      stub_request(:any, %r{fakeflipper.com}).to_return(status: 200)
       instance = described_class.new(token: 'asdf', url: 'https://www.fakeflipper.com/sadpanda')
       # pardon the nesting...
       memoized = instance.adapter
@@ -78,27 +79,31 @@ RSpec.describe Flipper::Cloud do
   end
 
   it 'can set debug_output' do
+    instance = Flipper::Adapters::Http::Client.new(token: 'asdf', url: 'https://www.flippercloud.io/adapter')
     expect(Flipper::Adapters::Http::Client).to receive(:new)
-      .with(hash_including(debug_output: STDOUT)).at_least(:once)
+      .with(hash_including(debug_output: STDOUT)).at_least(:once).and_return(instance)
     described_class.new(token: 'asdf', debug_output: STDOUT)
   end
 
   it 'can set read_timeout' do
+    instance = Flipper::Adapters::Http::Client.new(token: 'asdf', url: 'https://www.flippercloud.io/adapter')
     expect(Flipper::Adapters::Http::Client).to receive(:new)
-      .with(hash_including(read_timeout: 1)).at_least(:once)
+      .with(hash_including(read_timeout: 1)).at_least(:once).and_return(instance)
     described_class.new(token: 'asdf', read_timeout: 1)
   end
 
   it 'can set open_timeout' do
+    instance = Flipper::Adapters::Http::Client.new(token: 'asdf', url: 'https://www.flippercloud.io/adapter')
     expect(Flipper::Adapters::Http::Client).to receive(:new)
-      .with(hash_including(open_timeout: 1)).at_least(:once)
+      .with(hash_including(open_timeout: 1)).at_least(:once).and_return(instance)
     described_class.new(token: 'asdf', open_timeout: 1)
   end
 
   if RUBY_VERSION >= '2.6.0'
     it 'can set write_timeout' do
+      instance = Flipper::Adapters::Http::Client.new(token: 'asdf', url: 'https://www.flippercloud.io/adapter')
       expect(Flipper::Adapters::Http::Client).to receive(:new)
-        .with(hash_including(open_timeout: 1)).at_least(:once)
+        .with(hash_including(open_timeout: 1)).at_least(:once).and_return(instance)
       described_class.new(token: 'asdf', open_timeout: 1)
     end
   end

data/spec/flipper/dsl_spec.rb

@@ -225,9 +225,6 @@ RSpec.describe Flipper::DSL do
 
   describe '#enable_group/disable_group' do
     it 'enables and disables the feature for group' do
-      actor = Flipper::Actor.new(5)
-      group = Flipper.register(:fives) { |actor| actor.flipper_id == 5 }
-
       expect(subject[:stats].groups_value).to be_empty
       subject.enable_group(:stats, :fives)
       expect(subject[:stats].groups_value).to eq(Set['fives'])

data/spec/flipper/engine_spec.rb

@@ -12,6 +12,7 @@ RSpec.describe Flipper::Engine do
   end
 
   before do
+    stub_request(:get, /flippercloud\.io/).to_return(status: 200, body: "{}")
     Rails.application = nil
     ActiveSupport::Dependencies.autoload_paths = ActiveSupport::Dependencies.autoload_paths.dup
     ActiveSupport::Dependencies.autoload_once_paths = ActiveSupport::Dependencies.autoload_once_paths.dup
@@ -262,10 +263,10 @@ RSpec.describe Flipper::Engine do
         Flipper::Cloud::MessageVerifier.new(secret: "").header(signature, timestamp)
       }
 
-      it "configures webhook app" do
+      it "configures webhook app and uses cache busting" do
         silence { application.initialize! }
 
-        stub = stub_request(:get, "https://www.flippercloud.io/adapter/features?exclude_gate_names=true").with({
+        stub = stub_request(:get, /https:\/\/www\.flippercloud\.io\/adapter\/features\?_cb=\d+&exclude_gate_names=true/).with({
           headers: { "flipper-cloud-token" => ENV["FLIPPER_CLOUD_TOKEN"] },
         }).to_return(status: 200, body: JSON.generate({ features: {} }), headers: {})
 

data/spec/flipper/expressions/time_spec.rb

@@ -9,5 +9,21 @@ RSpec.describe Flipper::Expressions::Time do
     it "returns time for #iso8601 format" do
       expect(described_class.call(time.iso8601)).to eq(time)
     end
+
+    it "returns time for epoch integer" do
+      expect(described_class.call(time.to_i)).to eq(Time.at(time.to_i).utc)
+    end
+
+    it "returns time for epoch float" do
+      expect(described_class.call(time.to_f)).to be_within(0.001).of(time)
+    end
+
+    it "returns utc for string input" do
+      expect(described_class.call(time.to_s).utc?).to be(true)
+    end
+
+    it "returns utc for numeric input" do
+      expect(described_class.call(time.to_i).utc?).to be(true)
+    end
   end
 end

data/spec/flipper/feature_spec.rb

@@ -76,6 +76,26 @@ RSpec.describe Flipper::Feature do
         expect(subject.enabled?(actors)).to be(false)
       end
     end
+
+    context "for an object that implements .nil? == true" do
+      let(:actor) { Flipper::Actor.new("User;1") }
+
+      before do
+        def actor.nil?
+          true
+        end
+      end
+
+      it 'returns true if feature is enabled' do
+        subject.enable
+        expect(subject.enabled?(actor)).to be(true)
+      end
+
+      it 'returns false if feature is disabled' do
+        subject.disable
+        expect(subject.enabled?(actor)).to be(false)
+      end
+    end
   end
 
   describe '#to_s' do
@@ -195,7 +215,7 @@ RSpec.describe Flipper::Feature do
 
     it 'is recorded for enable' do
       actor = Flipper::Types::Actor.new(Flipper::Actor.new('1'))
-      gate = subject.gate_for(actor)
+      subject.gate_for(actor)
 
       subject.enable(actor)
 
@@ -210,7 +230,7 @@ RSpec.describe Flipper::Feature do
 
     it 'always instruments flipper type instance for enable' do
       actor = Flipper::Actor.new('1')
-      gate = subject.gate_for(actor)
+      subject.gate_for(actor)
 
       subject.enable(actor)
 
@@ -221,7 +241,6 @@ RSpec.describe Flipper::Feature do
 
     it 'is recorded for disable' do
       thing = Flipper::Types::Boolean.new
-      gate = subject.gate_for(thing)
 
       subject.disable(thing)
 
@@ -266,7 +285,6 @@ RSpec.describe Flipper::Feature do
 
     it 'always instruments flipper type instance for disable' do
       actor = Flipper::Actor.new('1')
-      gate = subject.gate_for(actor)
 
       subject.disable(actor)
 
@@ -709,7 +727,6 @@ RSpec.describe Flipper::Feature do
     context "with expression instance" do
       it "updates gate values to equal expression or clears expression" do
         expression = Flipper.property(:plan).eq("basic")
-        other_expression = Flipper.property(:age).gte(21)
         expect(subject.gate_values.expression).to be(nil)
         subject.enable_expression(expression)
         expect(subject.gate_values.expression).to eq(expression.value)
@@ -721,7 +738,6 @@ RSpec.describe Flipper::Feature do
     context "with Hash" do
       it "updates gate values to equal expression or clears expression" do
         expression = Flipper.property(:plan).eq("basic")
-        other_expression = Flipper.property(:age).gte(21)
         expect(subject.gate_values.expression).to be(nil)
         subject.enable_expression(expression.value)
         expect(subject.gate_values.expression).to eq(expression.value)
@@ -1078,8 +1094,6 @@ RSpec.describe Flipper::Feature do
   describe '#enable_group/disable_group' do
     context 'with symbol group name' do
       it 'updates the gate values to include the group' do
-        actor = Flipper::Actor.new(5)
-        group = Flipper.register(:five_only) { |actor| actor.flipper_id == 5 }
         expect(subject.gate_values.groups).to be_empty
         subject.enable_group(:five_only)
         expect(subject.gate_values.groups).to eq(Set['five_only'])
@@ -1090,8 +1104,6 @@ RSpec.describe Flipper::Feature do
 
     context 'with string group name' do
       it 'updates the gate values to include the group' do
-        actor = Flipper::Actor.new(5)
-        group = Flipper.register(:five_only) { |actor| actor.flipper_id == 5 }
         expect(subject.gate_values.groups).to be_empty
         subject.enable_group('five_only')
         expect(subject.gate_values.groups).to eq(Set['five_only'])
@@ -1102,7 +1114,6 @@ RSpec.describe Flipper::Feature do
 
     context 'with group instance' do
       it 'updates the gate values for the group' do
-        actor = Flipper::Actor.new(5)
         group = Flipper.register(:five_only) { |actor| actor.flipper_id == 5 }
         expect(subject.gate_values.groups).to be_empty
         subject.enable_group(group)