flipper 0.7.1 → 0.7.2

data/spec/flipper/instrumenters/noop_spec.rb

@@ -1,13 +1,13 @@
 require 'helper'
 require 'flipper/instrumenters/noop'
 
-describe Flipper::Instrumenters::Noop do
+RSpec.describe Flipper::Instrumenters::Noop do
   describe ".instrument" do
     context "with name" do
       it "yields block" do
         yielded = false
         described_class.instrument(:foo) { yielded = true }
-        yielded.should eq(true)
+        expect(yielded).to eq(true)
       end
     end
 
@@ -15,7 +15,7 @@ describe Flipper::Instrumenters::Noop do
       it "yields block" do
         yielded = false
         described_class.instrument(:foo, {:pay => :load}) { yielded = true }
-        yielded.should eq(true)
+        expect(yielded).to eq(true)
       end
     end
   end

data/spec/flipper/middleware/memoizer_spec.rb

@@ -4,7 +4,7 @@ require 'flipper/middleware/memoizer'
 require 'flipper/adapters/operation_logger'
 require 'flipper/adapters/memory'
 
-describe Flipper::Middleware::Memoizer do
+RSpec.describe Flipper::Middleware::Memoizer do
   include Rack::Test::Methods
 
   let(:memory_adapter) { Flipper::Adapters::Memory.new }
@@ -26,7 +26,7 @@ describe Flipper::Middleware::Memoizer do
       }
       middleware = described_class.new app, flipper
       middleware.call({})
-      called.should eq(true)
+      expect(called).to eq(true)
     end
 
     it "disables local cache after body close" do
@@ -34,9 +34,9 @@ describe Flipper::Middleware::Memoizer do
       middleware = described_class.new app, flipper
       body = middleware.call({}).last
 
-      flipper.adapter.memoizing?.should eq(true)
+      expect(flipper.adapter.memoizing?).to eq(true)
       body.close
-      flipper.adapter.memoizing?.should eq(false)
+      expect(flipper.adapter.memoizing?).to eq(false)
     end
 
     it "clears local cache after body close" do
@@ -46,19 +46,19 @@ describe Flipper::Middleware::Memoizer do
 
       flipper.adapter.cache['hello'] = 'world'
       body.close
-      flipper.adapter.cache.should be_empty
+      expect(flipper.adapter.cache).to be_empty
     end
 
     it "clears the local cache with a successful request" do
       flipper.adapter.cache['hello'] = 'world'
       get '/'
-      flipper.adapter.cache.should be_empty
+      expect(flipper.adapter.cache).to be_empty
     end
 
     it "clears the local cache even when the request raises an error" do
       flipper.adapter.cache['hello'] = 'world'
       get '/fail' rescue nil
-      flipper.adapter.cache.should be_empty
+      expect(flipper.adapter.cache).to be_empty
     end
 
     it "caches getting a feature for duration of request" do
@@ -80,7 +80,7 @@ describe Flipper::Middleware::Memoizer do
       middleware = described_class.new app, flipper
       middleware.call({})
 
-      adapter.count(:get).should be(1)
+      expect(adapter.count(:get)).to be(1)
     end
   end
 

data/spec/flipper/registry_spec.rb

@@ -1,7 +1,7 @@
 require 'helper'
 require 'flipper/registry'
 
-describe Flipper::Registry do
+RSpec.describe Flipper::Registry do
   subject { Flipper::Registry.new(source) }
 
   let(:source) { {} }
@@ -10,13 +10,13 @@ describe Flipper::Registry do
     it "adds to source" do
       value = 'thing'
       subject.add(:admins, value)
-      source[:admins].should eq(value)
+      expect(source[:admins]).to eq(value)
     end
 
     it "converts key to symbol" do
       value = 'thing'
       subject.add('admins', value)
-      source[:admins].should eq(value)
+      expect(source[:admins]).to eq(value)
     end
 
     it "raises exception if key already registered" do
@@ -35,11 +35,11 @@ describe Flipper::Registry do
       end
 
       it "returns value" do
-        subject.get(:admins).should eq('thing')
+        expect(subject.get(:admins)).to eq('thing')
       end
 
       it "returns value if given string key" do
-        subject.get('admins').should eq('thing')
+        expect(subject.get('admins')).to eq('thing')
       end
     end
 
@@ -58,11 +58,11 @@ describe Flipper::Registry do
     end
 
     it "returns true if the key exists" do
-      subject.key?(:admins).should eq true
+      expect(subject.key?(:admins)).to eq true
     end
 
     it "returns false if the key does not exists" do
-      subject.key?(:unknown_key).should eq false
+      expect(subject.key?(:unknown_key)).to eq false
     end
   end
 
@@ -77,10 +77,10 @@ describe Flipper::Registry do
       subject.each do |key, value|
         results[key] = value
       end
-      results.should eq({
-        :admins => 'admins',
-        :devs => 'devs',
-      })
+      expect(results).to eq({
+              :admins => 'admins',
+              :devs => 'devs',
+            })
     end
   end
 
@@ -91,12 +91,12 @@ describe Flipper::Registry do
     end
 
     it "returns the keys" do
-      subject.keys.map(&:to_s).sort.should eq(['admins', 'devs'])
+      expect(subject.keys.map(&:to_s).sort).to eq(['admins', 'devs'])
     end
 
     it "returns the keys as symbols" do
       subject.keys.each do |key|
-        key.should be_instance_of(Symbol)
+        expect(key).to be_instance_of(Symbol)
       end
     end
   end
@@ -108,7 +108,7 @@ describe Flipper::Registry do
     end
 
     it "returns the values" do
-      subject.values.map(&:to_s).sort.should eq(['admins', 'devs'])
+      expect(subject.values.map(&:to_s).sort).to eq(['admins', 'devs'])
     end
   end
 
@@ -127,8 +127,8 @@ describe Flipper::Registry do
         values << value
       end
 
-      keys.map(&:to_s).sort.should eq(['admins', 'devs'])
-      values.sort.should eq(['admins', 'devs'])
+      expect(keys.map(&:to_s).sort).to eq(['admins', 'devs'])
+      expect(values.sort).to eq(['admins', 'devs'])
     end
   end
 
@@ -139,7 +139,7 @@ describe Flipper::Registry do
 
     it "clears the source" do
       subject.clear
-      source.should be_empty
+      expect(source).to be_empty
     end
   end
 end

data/spec/flipper/typecast_spec.rb

@@ -1,7 +1,7 @@
 require 'helper'
 require 'flipper/typecast'
 
-describe Flipper::Typecast do
+RSpec.describe Flipper::Typecast do
   {
     nil => false,
     "" => false,
@@ -16,7 +16,7 @@ describe Flipper::Typecast do
   }.each do |value, expected|
     context "#to_boolean for #{value.inspect}" do
       it "returns #{expected}" do
-        described_class.to_boolean(value).should be(expected)
+        expect(described_class.to_boolean(value)).to be(expected)
       end
     end
   end
@@ -31,7 +31,7 @@ describe Flipper::Typecast do
   }.each do |value, expected|
     context "#to_integer for #{value.inspect}" do
       it "returns #{expected}" do
-        described_class.to_integer(value).should be(expected)
+        expect(described_class.to_integer(value)).to be(expected)
       end
     end
   end
@@ -44,7 +44,7 @@ describe Flipper::Typecast do
   }.each do |value, expected|
     context "#to_set for #{value.inspect}" do
       it "returns #{expected}" do
-        described_class.to_set(value).should eq(expected)
+        expect(described_class.to_set(value)).to eq(expected)
       end
     end
   end

data/spec/flipper/types/actor_spec.rb

@@ -1,7 +1,7 @@
 require 'helper'
 require 'flipper/types/actor'
 
-describe Flipper::Types::Actor do
+RSpec.describe Flipper::Types::Actor do
   subject {
     thing = thing_class.new('2')
     described_class.new(thing)
@@ -25,16 +25,16 @@ describe Flipper::Types::Actor do
     it "returns true if actor" do
       thing = thing_class.new('1')
       actor = described_class.new(thing)
-      described_class.wrappable?(actor).should eq(true)
+      expect(described_class.wrappable?(actor)).to eq(true)
     end
 
     it "returns true if responds to flipper_id" do
       thing = thing_class.new(10)
-      described_class.wrappable?(thing).should eq(true)
+      expect(described_class.wrappable?(thing)).to eq(true)
     end
 
     it "returns false if nil" do
-      described_class.wrappable?(nil).should be(false)
+      expect(described_class.wrappable?(nil)).to be(false)
     end
   end
 
@@ -42,8 +42,8 @@ describe Flipper::Types::Actor do
     context "for actor" do
       it "returns actor" do
         actor = described_class.wrap(subject)
-        actor.should be_instance_of(described_class)
-        actor.should be(subject)
+        expect(actor).to be_instance_of(described_class)
+        expect(actor).to be(subject)
       end
     end
 
@@ -51,7 +51,7 @@ describe Flipper::Types::Actor do
       it "returns actor" do
         thing = thing_class.new('1')
         actor = described_class.wrap(thing)
-        actor.should be_instance_of(described_class)
+        expect(actor).to be_instance_of(described_class)
       end
     end
   end
@@ -59,7 +59,7 @@ describe Flipper::Types::Actor do
   it "initializes with thing that responds to id" do
     thing = thing_class.new('1')
     actor = described_class.new(thing)
-    actor.value.should eq('1')
+    expect(actor.value).to eq('1')
   end
 
   it "raises error when initialized with nil" do
@@ -78,38 +78,38 @@ describe Flipper::Types::Actor do
   it "converts id to string" do
     thing = thing_class.new(2)
     actor = described_class.new(thing)
-    actor.value.should eq('2')
+    expect(actor.value).to eq('2')
   end
 
   it "proxies everything to thing" do
     thing = thing_class.new(10)
     actor = described_class.new(thing)
-    actor.admin?.should eq(true)
+    expect(actor.admin?).to eq(true)
   end
 
   it "exposes thing" do
     thing = thing_class.new(10)
     actor = described_class.new(thing)
-    actor.thing.should be(thing)
+    expect(actor.thing).to be(thing)
   end
 
   describe "#respond_to?" do
     it "returns true if responds to method" do
       thing = thing_class.new('1')
       actor = described_class.new(thing)
-      actor.respond_to?(:value).should eq(true)
+      expect(actor.respond_to?(:value)).to eq(true)
     end
 
     it "returns true if thing responds to method" do
       thing = thing_class.new(10)
       actor = described_class.new(thing)
-      actor.respond_to?(:admin?).should eq(true)
+      expect(actor.respond_to?(:admin?)).to eq(true)
     end
 
     it "returns false if does not respond to method and thing does not respond to method" do
       thing = thing_class.new(10)
       actor = described_class.new(thing)
-      actor.respond_to?(:frankenstein).should eq(false)
+      expect(actor.respond_to?(:frankenstein)).to eq(false)
     end
   end
 end

data/spec/flipper/types/boolean_spec.rb

@@ -1,24 +1,24 @@
 require 'helper'
 require 'flipper/types/boolean'
 
-describe Flipper::Types::Boolean do
+RSpec.describe Flipper::Types::Boolean do
   it "defaults value to true" do
     boolean = Flipper::Types::Boolean.new
-    boolean.value.should be(true)
+    expect(boolean.value).to be(true)
   end
 
   it "allows overriding default value" do
     boolean = Flipper::Types::Boolean.new(false)
-    boolean.value.should be(false)
+    expect(boolean.value).to be(false)
   end
 
   it "returns true for nil value" do
     boolean = Flipper::Types::Boolean.new(nil)
-    boolean.value.should be(true)
+    expect(boolean.value).to be(true)
   end
 
   it "typecasts value" do
     boolean = Flipper::Types::Boolean.new(1)
-    boolean.value.should be(true)
+    expect(boolean.value).to be(true)
   end
 end

data/spec/flipper/types/group_spec.rb

@@ -1,7 +1,7 @@
 require 'helper'
 require 'flipper/types/group'
 
-describe Flipper::Types::Group do
+RSpec.describe Flipper::Types::Group do
   subject do
     Flipper.register(:admins) { |actor| actor.admin? }
   end
@@ -9,31 +9,31 @@ describe Flipper::Types::Group do
   describe ".wrap" do
     context "with group instance" do
       it "returns group instance" do
-        described_class.wrap(subject).should eq(subject)
+        expect(described_class.wrap(subject)).to eq(subject)
       end
     end
 
     context "with Symbol group name" do
       it "returns group instance" do
-        described_class.wrap(subject.name).should eq(subject)
+        expect(described_class.wrap(subject.name)).to eq(subject)
       end
     end
 
     context "with String group name" do
       it "returns group instance" do
-        described_class.wrap(subject.name.to_s).should eq(subject)
+        expect(described_class.wrap(subject.name.to_s)).to eq(subject)
       end
     end
   end
 
   it "initializes with name" do
     group = Flipper::Types::Group.new(:admins)
-    group.should be_instance_of(Flipper::Types::Group)
+    expect(group).to be_instance_of(Flipper::Types::Group)
   end
 
   describe "#name" do
     it "returns name" do
-      subject.name.should eq(:admins)
+      expect(subject.name).to eq(:admins)
     end
   end
 
@@ -42,11 +42,11 @@ describe Flipper::Types::Group do
     let(:non_admin_actor) { double('Actor', :admin? => false) }
 
     it "returns true if block matches" do
-      subject.match?(admin_actor).should eq(true)
+      expect(subject.match?(admin_actor)).to eq(true)
     end
 
     it "returns false if block does not match" do
-      subject.match?(non_admin_actor).should eq(false)
+      expect(subject.match?(non_admin_actor)).to eq(false)
     end
   end
 end

data/spec/flipper/types/percentage_of_actors_spec.rb

@@ -1,6 +1,6 @@
 require 'helper'
 require 'flipper/types/percentage_of_actors'
 
-describe Flipper::Types::PercentageOfActors do
+RSpec.describe Flipper::Types::PercentageOfActors do
   it_should_behave_like 'a percentage'
 end

data/spec/flipper/types/percentage_of_time_spec.rb

@@ -1,6 +1,6 @@
 require 'helper'
 require 'flipper/types/percentage_of_time'
 
-describe Flipper::Types::PercentageOfTime do
+RSpec.describe Flipper::Types::PercentageOfTime do
   it_should_behave_like 'a percentage'
 end

data/spec/flipper/types/percentage_spec.rb

@@ -1,7 +1,7 @@
 require 'helper'
 require 'flipper/types/percentage_of_actors'
 
-describe Flipper::Types::Percentage do
+RSpec.describe Flipper::Types::Percentage do
   subject {
     described_class.new(5)
   }
@@ -10,38 +10,38 @@ describe Flipper::Types::Percentage do
   describe ".wrap" do
     context "with percentage instance" do
       it "returns percentage instance" do
-        described_class.wrap(subject).should eq(subject)
+        expect(described_class.wrap(subject)).to eq(subject)
       end
     end
 
     context "with Integer" do
       it "returns percentage instance" do
-        described_class.wrap(subject.value).should eq(subject)
+        expect(described_class.wrap(subject.value)).to eq(subject)
       end
     end
 
     context "with String" do
       it "returns percentage instance" do
-        described_class.wrap(subject.value.to_s).should eq(subject)
+        expect(described_class.wrap(subject.value.to_s)).to eq(subject)
       end
     end
   end
 
   describe "#eql?" do
     it "returns true for same class and value" do
-      subject.eql?(described_class.new(subject.value)).should eq(true)
+      expect(subject.eql?(described_class.new(subject.value))).to eq(true)
     end
 
     it "returns false for different value" do
-      subject.eql?(described_class.new(subject.value + 1)).should eq(false)
+      expect(subject.eql?(described_class.new(subject.value + 1))).to eq(false)
     end
 
     it "returns false for different class" do
-      subject.eql?(Object.new).should eq(false)
+      expect(subject.eql?(Object.new)).to eq(false)
     end
 
     it "is aliased to ==" do
-      (subject == described_class.new(subject.value)).should eq(true)
+      expect((subject == described_class.new(subject.value))).to eq(true)
     end
   end
 end