flipper 0.7.1 → 0.7.2

data/spec/flipper/adapters/memoizable_spec.rb

@@ -3,7 +3,7 @@ require 'flipper/adapters/memoizable'
 require 'flipper/adapters/memory'
 require 'flipper/spec/shared_adapter_specs'
 
-describe Flipper::Adapters::Memoizable do
+RSpec.describe Flipper::Adapters::Memoizable do
   let(:features_key) { described_class::FeaturesKey }
   let(:adapter) { Flipper::Adapters::Memory.new }
   let(:flipper) { Flipper.new(adapter) }
@@ -16,28 +16,28 @@ describe Flipper::Adapters::Memoizable do
   describe "#memoize=" do
     it "sets value" do
       subject.memoize = true
-      subject.memoizing?.should eq(true)
+      expect(subject.memoizing?).to eq(true)
 
       subject.memoize = false
-      subject.memoizing?.should eq(false)
+      expect(subject.memoizing?).to eq(false)
     end
 
     it "clears the local cache" do
       subject.cache['some'] = 'thing'
       subject.memoize = true
-      subject.cache.should be_empty
+      expect(subject.cache).to be_empty
     end
   end
 
   describe "#memoizing?" do
     it "returns true if enabled" do
       subject.memoize = true
-      subject.memoizing?.should eq(true)
+      expect(subject.memoizing?).to eq(true)
     end
 
     it "returns false if disabled" do
       subject.memoize = false
-      subject.memoizing?.should eq(false)
+      expect(subject.memoizing?).to eq(false)
     end
   end
 
@@ -50,7 +50,7 @@ describe Flipper::Adapters::Memoizable do
       it "memoizes feature" do
         feature = flipper[:stats]
         result = subject.get(feature)
-        cache[feature].should be(result)
+        expect(cache[feature]).to be(result)
       end
     end
 
@@ -63,7 +63,7 @@ describe Flipper::Adapters::Memoizable do
         feature = flipper[:stats]
         result = subject.get(feature)
         adapter_result = adapter.get(feature)
-        result.should eq(adapter_result)
+        expect(result).to eq(adapter_result)
       end
     end
   end
@@ -79,7 +79,7 @@ describe Flipper::Adapters::Memoizable do
         gate = feature.gate(:boolean)
         cache[feature] = {:some => 'thing'}
         subject.enable(feature, gate, flipper.bool)
-        cache[feature].should be_nil
+        expect(cache[feature]).to be_nil
       end
     end
 
@@ -93,7 +93,7 @@ describe Flipper::Adapters::Memoizable do
         gate = feature.gate(:boolean)
         result = subject.enable(feature, gate, flipper.bool)
         adapter_result = adapter.enable(feature, gate, flipper.bool)
-        result.should eq(adapter_result)
+        expect(result).to eq(adapter_result)
       end
     end
   end
@@ -109,7 +109,7 @@ describe Flipper::Adapters::Memoizable do
         gate = feature.gate(:boolean)
         cache[feature] = {:some => 'thing'}
         subject.disable(feature, gate, flipper.bool)
-        cache[feature].should be_nil
+        expect(cache[feature]).to be_nil
       end
     end
 
@@ -123,7 +123,7 @@ describe Flipper::Adapters::Memoizable do
         gate = feature.gate(:boolean)
         result = subject.disable(feature, gate, flipper.bool)
         adapter_result = adapter.disable(feature, gate, flipper.bool)
-        result.should eq(adapter_result)
+        expect(result).to eq(adapter_result)
       end
     end
   end
@@ -138,7 +138,7 @@ describe Flipper::Adapters::Memoizable do
         flipper[:stats].enable
         flipper[:search].disable
         result = subject.features
-        cache[:flipper_features].should be(result)
+        expect(cache[:flipper_features]).to be(result)
       end
     end
 
@@ -148,7 +148,7 @@ describe Flipper::Adapters::Memoizable do
       end
 
       it "returns result" do
-        subject.features.should eq(adapter.features)
+        expect(subject.features).to eq(adapter.features)
       end
     end
   end
@@ -162,7 +162,7 @@ describe Flipper::Adapters::Memoizable do
       it "unmemoizes the known features" do
         cache[features_key] = {:some => 'thing'}
         subject.add(flipper[:stats])
-        cache.should be_empty
+        expect(cache).to be_empty
       end
     end
 
@@ -172,7 +172,7 @@ describe Flipper::Adapters::Memoizable do
       end
 
       it "returns result" do
-        subject.add(flipper[:stats]).should eq(adapter.add(flipper[:stats]))
+        expect(subject.add(flipper[:stats])).to eq(adapter.add(flipper[:stats]))
       end
     end
   end
@@ -186,14 +186,14 @@ describe Flipper::Adapters::Memoizable do
       it "unmemoizes the known features" do
         cache[features_key] = {:some => 'thing'}
         subject.remove(flipper[:stats])
-        cache.should be_empty
+        expect(cache).to be_empty
       end
 
       it "unmemoizes the feature" do
         feature = flipper[:stats]
         cache[feature] = {:some => 'thing'}
         subject.remove(feature)
-        cache[feature].should be_nil
+        expect(cache[feature]).to be_nil
       end
     end
 
@@ -203,7 +203,7 @@ describe Flipper::Adapters::Memoizable do
       end
 
       it "returns result" do
-        subject.remove(flipper[:stats]).should eq(adapter.remove(flipper[:stats]))
+        expect(subject.remove(flipper[:stats])).to eq(adapter.remove(flipper[:stats]))
       end
     end
   end
@@ -218,7 +218,7 @@ describe Flipper::Adapters::Memoizable do
         feature = flipper[:stats]
         cache[feature] = {:some => 'thing'}
         subject.clear(feature)
-        cache[feature].should be_nil
+        expect(cache[feature]).to be_nil
       end
     end
 
@@ -229,7 +229,7 @@ describe Flipper::Adapters::Memoizable do
 
       it "returns result" do
         feature = flipper[:stats]
-        subject.clear(feature).should eq(adapter.clear(feature))
+        expect(subject.clear(feature)).to eq(adapter.clear(feature))
       end
     end
   end

data/spec/flipper/adapters/memory_spec.rb

@@ -2,7 +2,7 @@ require 'helper'
 require 'flipper/adapters/memory'
 require 'flipper/spec/shared_adapter_specs'
 
-describe Flipper::Adapters::Memory do
+RSpec.describe Flipper::Adapters::Memory do
   subject { described_class.new }
 
   it_should_behave_like 'a flipper adapter'

data/spec/flipper/adapters/operation_logger_spec.rb

@@ -3,7 +3,7 @@ require 'flipper/adapters/operation_logger'
 require 'flipper/adapters/memory'
 require 'flipper/spec/shared_adapter_specs'
 
-describe Flipper::Adapters::OperationLogger do
+RSpec.describe Flipper::Adapters::OperationLogger do
   let(:operations) { [] }
   let(:adapter)    { Flipper::Adapters::Memory.new }
   let(:flipper)    { Flipper.new(adapter) }
@@ -19,11 +19,11 @@ describe Flipper::Adapters::OperationLogger do
     end
 
     it "logs operation" do
-      subject.count(:get).should be(1)
+      expect(subject.count(:get)).to be(1)
     end
 
     it "returns result" do
-      @result.should eq(adapter.get(@feature))
+      expect(@result).to eq(adapter.get(@feature))
     end
   end
 
@@ -36,11 +36,11 @@ describe Flipper::Adapters::OperationLogger do
     end
 
     it "logs operation" do
-      subject.count(:enable).should be(1)
+      expect(subject.count(:enable)).to be(1)
     end
 
     it "returns result" do
-      @result.should eq(adapter.enable(@feature, @gate, @thing))
+      expect(@result).to eq(adapter.enable(@feature, @gate, @thing))
     end
   end
 
@@ -53,11 +53,11 @@ describe Flipper::Adapters::OperationLogger do
     end
 
     it "logs operation" do
-      subject.count(:disable).should be(1)
+      expect(subject.count(:disable)).to be(1)
     end
 
     it "returns result" do
-      @result.should eq(adapter.disable(@feature, @gate, @thing))
+      expect(@result).to eq(adapter.disable(@feature, @gate, @thing))
     end
   end
 
@@ -68,11 +68,11 @@ describe Flipper::Adapters::OperationLogger do
     end
 
     it "logs operation" do
-      subject.count(:features).should be(1)
+      expect(subject.count(:features)).to be(1)
     end
 
     it "returns result" do
-      @result.should eq(adapter.features)
+      expect(@result).to eq(adapter.features)
     end
   end
 
@@ -83,11 +83,11 @@ describe Flipper::Adapters::OperationLogger do
     end
 
     it "logs operation" do
-      subject.count(:add).should be(1)
+      expect(subject.count(:add)).to be(1)
     end
 
     it "returns result" do
-      @result.should eq(adapter.add(@feature))
+      expect(@result).to eq(adapter.add(@feature))
     end
   end
 end

data/spec/flipper/adapters/pstore_spec.rb

@@ -2,7 +2,7 @@ require 'helper'
 require 'flipper/adapters/pstore'
 require 'flipper/spec/shared_adapter_specs'
 
-describe Flipper::Adapters::PStore do
+RSpec.describe Flipper::Adapters::PStore do
   subject {
     dir = FlipperRoot.join("tmp").tap { |d| d.mkpath }
     described_class.new(dir.join("flipper.pstore"))
@@ -11,6 +11,6 @@ describe Flipper::Adapters::PStore do
   it_should_behave_like 'a flipper adapter'
 
   it "defaults path to flipper.pstore" do
-    described_class.new.path.should eq("flipper.pstore")
+    expect(described_class.new.path).to eq("flipper.pstore")
   end
 end

data/spec/flipper/dsl_spec.rb

@@ -2,7 +2,7 @@ require 'helper'
 require 'flipper/dsl'
 require 'flipper/adapters/memory'
 
-describe Flipper::DSL do
+RSpec.describe Flipper::DSL do
   subject { Flipper::DSL.new(adapter) }
 
   let(:adapter) { Flipper::Adapters::Memory.new }
@@ -10,12 +10,12 @@ describe Flipper::DSL do
   describe "#initialize" do
     it "sets adapter" do
       dsl = described_class.new(adapter)
-      dsl.adapter.should_not be_nil
+      expect(dsl.adapter).not_to be_nil
     end
 
     it "defaults instrumenter to noop" do
       dsl = described_class.new(adapter)
-      dsl.instrumenter.should be(Flipper::Instrumenters::Noop)
+      expect(dsl.instrumenter).to be(Flipper::Instrumenters::Noop)
     end
 
     context "with overriden instrumenter" do
@@ -23,12 +23,12 @@ describe Flipper::DSL do
 
       it "overrides default instrumenter" do
         dsl = described_class.new(adapter, :instrumenter => instrumenter)
-        dsl.instrumenter.should be(instrumenter)
+        expect(dsl.instrumenter).to be(instrumenter)
       end
 
       it "passes overridden instrumenter to adapter wrapping" do
         dsl = described_class.new(adapter, :instrumenter => instrumenter)
-        dsl.adapter.instrumenter.should be(instrumenter)
+        expect(dsl.adapter.instrumenter).to be(instrumenter)
       end
     end
   end
@@ -70,11 +70,11 @@ describe Flipper::DSL do
       end
 
       it "returns group" do
-        subject.group(:admins).should eq(@group)
+        expect(subject.group(:admins)).to eq(@group)
       end
 
       it "always returns same instance for same name" do
-        subject.group(:admins).should equal(subject.group(:admins))
+        expect(subject.group(:admins)).to equal(subject.group(:admins))
       end
     end
 
@@ -92,8 +92,8 @@ describe Flipper::DSL do
       it "returns actor instance" do
         thing = Struct.new(:flipper_id).new(33)
         actor = subject.actor(thing)
-        actor.should be_instance_of(Flipper::Types::Actor)
-        actor.value.should eq('33')
+        expect(actor).to be_instance_of(Flipper::Types::Actor)
+        expect(actor.value).to eq('33')
       end
     end
 
@@ -120,15 +120,15 @@ describe Flipper::DSL do
     end
 
     it "returns percentage of time" do
-      @result.should be_instance_of(Flipper::Types::PercentageOfTime)
+      expect(@result).to be_instance_of(Flipper::Types::PercentageOfTime)
     end
 
     it "sets value" do
-      @result.value.should eq(5)
+      expect(@result.value).to eq(5)
     end
 
     it "is aliased to percentage_of_time" do
-      @result.should eq(subject.percentage_of_time(@result.value))
+      expect(@result).to eq(subject.percentage_of_time(@result.value))
     end
   end
 
@@ -138,22 +138,22 @@ describe Flipper::DSL do
     end
 
     it "returns percentage of actors" do
-      @result.should be_instance_of(Flipper::Types::PercentageOfActors)
+      expect(@result).to be_instance_of(Flipper::Types::PercentageOfActors)
     end
 
     it "sets value" do
-      @result.value.should eq(17)
+      expect(@result.value).to eq(17)
     end
 
     it "is aliased to percentage_of_actors" do
-      @result.should eq(subject.percentage_of_actors(@result.value))
+      expect(@result).to eq(subject.percentage_of_actors(@result.value))
     end
   end
 
   describe "#features" do
     context "with no features enabled/disabled" do
       it "defaults to empty set" do
-        subject.features.should eq(Set.new)
+        expect(subject.features).to eq(Set.new)
       end
     end
 
@@ -165,23 +165,23 @@ describe Flipper::DSL do
       end
 
       it "returns set of feature instances" do
-        subject.features.should be_instance_of(Set)
+        expect(subject.features).to be_instance_of(Set)
         subject.features.each do |feature|
-          feature.should be_instance_of(Flipper::Feature)
+          expect(feature).to be_instance_of(Flipper::Feature)
         end
-        subject.features.map(&:name).map(&:to_s).sort.should eq(['cache', 'search', 'stats'])
+        expect(subject.features.map(&:name).map(&:to_s).sort).to eq(['cache', 'search', 'stats'])
       end
     end
   end
 
   describe "#enable/disable" do
     it "enables and disables the feature" do
-      subject[:stats].boolean_value.should eq(false)
+      expect(subject[:stats].boolean_value).to eq(false)
       subject.enable(:stats)
-      subject[:stats].boolean_value.should eq(true)
+      expect(subject[:stats].boolean_value).to eq(true)
 
       subject.disable(:stats)
-      subject[:stats].boolean_value.should eq(false)
+      expect(subject[:stats].boolean_value).to eq(false)
     end
   end
 
@@ -189,12 +189,12 @@ describe Flipper::DSL do
     it "enables and disables the feature for actor" do
       actor = Struct.new(:flipper_id).new(5)
 
-      subject[:stats].actors_value.should be_empty
+      expect(subject[:stats].actors_value).to be_empty
       subject.enable_actor(:stats, actor)
-      subject[:stats].actors_value.should eq(Set["5"])
+      expect(subject[:stats].actors_value).to eq(Set["5"])
 
       subject.disable_actor(:stats, actor)
-      subject[:stats].actors_value.should be_empty
+      expect(subject[:stats].actors_value).to be_empty
     end
   end
 
@@ -203,34 +203,34 @@ describe Flipper::DSL do
       actor = Struct.new(:flipper_id).new(5)
       group = Flipper.register(:fives) { |actor| actor.flipper_id == 5 }
 
-      subject[:stats].groups_value.should be_empty
+      expect(subject[:stats].groups_value).to be_empty
       subject.enable_group(:stats, :fives)
-      subject[:stats].groups_value.should eq(Set["fives"])
+      expect(subject[:stats].groups_value).to eq(Set["fives"])
 
       subject.disable_group(:stats, :fives)
-      subject[:stats].groups_value.should be_empty
+      expect(subject[:stats].groups_value).to be_empty
     end
   end
 
   describe "#enable_percentage_of_time/disable_percentage_of_time" do
     it "enables and disables the feature for percentage of time" do
-      subject[:stats].percentage_of_time_value.should be(0)
+      expect(subject[:stats].percentage_of_time_value).to be(0)
       subject.enable_percentage_of_time(:stats, 6)
-      subject[:stats].percentage_of_time_value.should be(6)
+      expect(subject[:stats].percentage_of_time_value).to be(6)
 
       subject.disable_percentage_of_time(:stats)
-      subject[:stats].percentage_of_time_value.should be(0)
+      expect(subject[:stats].percentage_of_time_value).to be(0)
     end
   end
 
   describe "#enable_percentage_of_actors/disable_percentage_of_actors" do
     it "enables and disables the feature for percentage of time" do
-      subject[:stats].percentage_of_actors_value.should be(0)
+      expect(subject[:stats].percentage_of_actors_value).to be(0)
       subject.enable_percentage_of_actors(:stats, 6)
-      subject[:stats].percentage_of_actors_value.should be(6)
+      expect(subject[:stats].percentage_of_actors_value).to be(6)
 
       subject.disable_percentage_of_actors(:stats)
-      subject[:stats].percentage_of_actors_value.should be(0)
+      expect(subject[:stats].percentage_of_actors_value).to be(0)
     end
   end
 end