flipper 0.6.3 → 0.7.0.beta1

data/spec/flipper/typecast_spec.rb

@@ -0,0 +1,63 @@
+require 'helper'
+require 'flipper/typecast'
+
+describe Flipper::Typecast do
+  {
+    nil => false,
+    "" => false,
+    0 => false,
+    1 => true,
+    "0" => false,
+    "1" => true,
+    true => true,
+    false => false,
+    "true" => true,
+    "false" => false,
+  }.each do |value, expected|
+    context "#to_boolean for #{value.inspect}" do
+      it "returns #{expected}" do
+        described_class.to_boolean(value).should be(expected)
+      end
+    end
+  end
+
+  {
+    nil => 0,
+    "" => 0,
+    0 => 0,
+    1 => 1,
+    "1" => 1,
+    "99" => 99,
+  }.each do |value, expected|
+    context "#to_integer for #{value.inspect}" do
+      it "returns #{expected}" do
+        described_class.to_integer(value).should be(expected)
+      end
+    end
+  end
+
+  {
+    nil => Set.new,
+    "" => Set.new,
+    Set.new([1, 2]) => Set.new([1, 2]),
+    [1, 2] => Set.new([1, 2])
+  }.each do |value, expected|
+    context "#to_set for #{value.inspect}" do
+      it "returns #{expected}" do
+        described_class.to_set(value).should eq(expected)
+      end
+    end
+  end
+
+  it "raises argument error for integer value that cannot be converted to an integer" do
+    expect {
+      described_class.to_integer(["asdf"])
+    }.to raise_error(ArgumentError, %Q(["asdf"] cannot be converted to an integer))
+  end
+
+  it "raises argument error for set value that cannot be converted to a set" do
+    expect {
+      described_class.to_set("asdf")
+    }.to raise_error(ArgumentError, %Q("asdf" cannot be converted to a set))
+  end
+end

data/spec/flipper/types/group_spec.rb

@@ -3,7 +3,27 @@ require 'flipper/types/group'
 
 describe Flipper::Types::Group do
   subject do
-    Flipper::Types::Group.new(:admins) { |actor| actor.admin? }
+    Flipper.register(:admins) { |actor| actor.admin? }
+  end
+
+  describe ".wrap" do
+    context "with group instance" do
+      it "returns group instance" do
+        described_class.wrap(subject).should eq(subject)
+      end
+    end
+
+    context "with Symbol group name" do
+      it "returns group instance" do
+        described_class.wrap(subject.name).should eq(subject)
+      end
+    end
+
+    context "with String group name" do
+      it "returns group instance" do
+        described_class.wrap(subject.name.to_s).should eq(subject)
+      end
+    end
   end
 
   it "initializes with name" do

data/spec/flipper/types/percentage_of_time_spec.rb

@@ -0,0 +1,6 @@
+require 'helper'
+require 'flipper/types/percentage_of_time'
+
+describe Flipper::Types::PercentageOfTime do
+  it_should_behave_like 'a percentage'
+end

data/spec/flipper/types/percentage_spec.rb

@@ -7,6 +7,26 @@ describe Flipper::Types::Percentage do
   }
   it_should_behave_like 'a percentage'
 
+  describe ".wrap" do
+    context "with percentage instance" do
+      it "returns percentage instance" do
+        described_class.wrap(subject).should eq(subject)
+      end
+    end
+
+    context "with Integer" do
+      it "returns percentage instance" do
+        described_class.wrap(subject.value).should eq(subject)
+      end
+    end
+
+    context "with String" do
+      it "returns percentage instance" do
+        described_class.wrap(subject.value.to_s).should eq(subject)
+      end
+    end
+  end
+
   describe "#eql?" do
     it "returns true for same class and value" do
       subject.eql?(described_class.new(subject.value)).should eq(true)

data/spec/flipper_spec.rb

@@ -19,31 +19,31 @@ describe Flipper do
     end
   end
 
-  describe ".groups" do
+  describe ".groups_registry" do
     it "returns a registry instance" do
-      Flipper.groups.should be_instance_of(Flipper::Registry)
+      Flipper.groups_registry.should be_instance_of(Flipper::Registry)
     end
   end
 
-  describe ".groups=" do
-    it "sets groups registry" do
+  describe ".groups_registry=" do
+    it "sets groups_registry registry" do
       registry = Flipper::Registry.new
-      Flipper.groups = registry
-      Flipper.instance_variable_get("@groups").should eq(registry)
+      Flipper.groups_registry = registry
+      Flipper.instance_variable_get("@groups_registry").should eq(registry)
     end
   end
 
   describe ".register" do
     it "adds a group to the group_registry" do
       registry = Flipper::Registry.new
-      Flipper.groups = registry
+      Flipper.groups_registry = registry
       group = Flipper.register(:admins) { |actor| actor.admin? }
       registry.get(:admins).should eq(group)
     end
 
     it "adds a group to the group_registry for string name" do
       registry = Flipper::Registry.new
-      Flipper.groups = registry
+      Flipper.groups_registry = registry
       group = Flipper.register('admins') { |actor| actor.admin? }
       registry.get(:admins).should eq(group)
     end
@@ -59,7 +59,7 @@ describe Flipper do
 
   describe ".unregister_groups" do
     it "clear group registry" do
-      Flipper.groups.should_receive(:clear)
+      Flipper.groups_registry.should_receive(:clear)
       Flipper.unregister_groups
     end
   end
@@ -87,4 +87,26 @@ describe Flipper do
       end
     end
   end
+
+  describe ".groups" do
+    it "returns array of group instances" do
+      admins = Flipper.register(:admins) { |actor| actor.admin? }
+      preview_features = Flipper.register(:preview_features) { |actor| actor.preview_features? }
+      Flipper.groups.should eq(Set[
+        admins,
+        preview_features,
+      ])
+    end
+  end
+
+  describe ".group_names" do
+    it "returns array of group names" do
+      Flipper.register(:admins) { |actor| actor.admin? }
+      Flipper.register(:preview_features) { |actor| actor.preview_features? }
+      Flipper.group_names.should eq(Set[
+        :admins,
+        :preview_features,
+      ])
+    end
+  end
 end

data/spec/helper.rb

@@ -18,9 +18,7 @@ require 'flipper'
 Dir[root_path.join("spec/support/**/*.rb")].each { |f| require f }
 
 RSpec.configure do |config|
-  config.fail_fast = true
-
-  config.filter_run :focused => true
+  config.filter_run :focus => true
   config.alias_example_to :fit, :focused => true
   config.alias_example_to :xit, :pending => true
   config.run_all_when_everything_filtered = true

data/spec/integration_spec.rb

@@ -3,9 +3,7 @@ require 'flipper/feature'
 require 'flipper/adapters/memory'
 
 describe Flipper do
-  let(:source)      { {} }
-  let(:adapter)     { Flipper::Adapters::Memory.new(source) }
-
+  let(:adapter)     { Flipper::Adapters::Memory.new }
   let(:flipper)     { Flipper.new(adapter) }
   let(:feature)     { flipper[:search] }
 
@@ -21,7 +19,7 @@ describe Flipper do
   let(:clooney)     { actor_class.new(10) }
 
   let(:five_percent_of_actors) { flipper.actors(5) }
-  let(:five_percent_of_random) { flipper.random(5) }
+  let(:five_percent_of_time) { flipper.time(5) }
 
   before do
     Flipper.register(:admins) { |thing| thing.admin? }
@@ -126,10 +124,10 @@ describe Flipper do
       end
     end
 
-    context "with a percentage of random" do
+    context "with a percentage of time" do
       before do
-        @gate = feature.gate(:percentage_of_random)
-        @result = feature.enable(five_percent_of_random)
+        @gate = feature.gate(:percentage_of_time)
+        @result = feature.enable(five_percent_of_time)
       end
 
       it "returns true" do
@@ -164,19 +162,19 @@ describe Flipper do
   describe "#disable" do
     context "with no arguments" do
       before do
-        # ensures that random gate is stubbed with result that would be true for pitt
-        @gate = feature.gate(:percentage_of_random)
+        # ensures that time gate is stubbed with result that would be true for pitt
+        @gate = feature.gate(:percentage_of_time)
         @gate.stub(:rand => 0.04)
 
         feature.enable admin_group
         feature.enable pitt
         feature.enable five_percent_of_actors
-        feature.enable five_percent_of_random
+        feature.enable five_percent_of_time
         @result = feature.disable
       end
 
       it "returns true" do
-        @result.should be_true
+        @result.should be(true)
       end
 
       it "disables feature" do
@@ -200,7 +198,7 @@ describe Flipper do
         enabled.should be(0)
       end
 
-      it "disables percentage of random" do
+      it "disables percentage of time" do
         feature.enabled?(pitt).should eq(false)
       end
 
@@ -290,8 +288,8 @@ describe Flipper do
 
     context "with a percentage of time" do
       before do
-        @gate = feature.gate(:percentage_of_random)
-        @result = feature.disable(flipper.random(0))
+        @gate = feature.gate(:percentage_of_time)
+        @result = feature.disable(flipper.time(0))
       end
 
       it "returns true" do
@@ -379,13 +377,14 @@ describe Flipper do
       end
     end
 
-    context "during enabled percentage of time" do
+    context "for enabled percentage of time" do
       before do
-        # ensure percentage of random returns enabled percentage
-        @gate = feature.gate(:percentage_of_random)
+        # ensure percentage of time returns percentage that makes five percent
+        # of time true
+        @gate = feature.gate(:percentage_of_time)
         @gate.stub(:rand => 0.04)
 
-        feature.enable five_percent_of_random
+        feature.enable five_percent_of_time
       end
 
       it "returns true" do
@@ -396,13 +395,14 @@ describe Flipper do
       end
     end
 
-    context "during not enabled percentage of time" do
+    context "for not enabled percentage of time" do
       before do
-        # ensure percentage of random returns not enabled percentage
-        @gate = feature.gate(:percentage_of_random)
+        # ensure percentage of time returns percentage that makes five percent
+        # of time false
+        @gate = feature.gate(:percentage_of_time)
         @gate.stub(:rand => 0.10)
 
-        feature.enable five_percent_of_random
+        feature.enable five_percent_of_time
       end
 
       it "returns false" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: flipper
 version: !ruby/object:Gem::Version
-  version: 0.6.3
+  version: 0.7.0.beta1
 platform: ruby
 authors:
 - John Nunemaker
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-03-21 00:00:00.000000000 Z
+date: 2015-04-04 00:00:00.000000000 Z
 dependencies: []
 description: Feature flipper for any adapter
 email:
@@ -33,7 +33,7 @@ files:
 - examples/individual_actor.rb
 - examples/instrumentation.rb
 - examples/percentage_of_actors.rb
-- examples/percentage_of_random.rb
+- examples/percentage_of_time.rb
 - flipper.gemspec
 - lib/flipper.rb
 - lib/flipper/adapter.rb
@@ -47,11 +47,12 @@ files:
 - lib/flipper/errors.rb
 - lib/flipper/feature.rb
 - lib/flipper/gate.rb
+- lib/flipper/gate_values.rb
 - lib/flipper/gates/actor.rb
 - lib/flipper/gates/boolean.rb
 - lib/flipper/gates/group.rb
 - lib/flipper/gates/percentage_of_actors.rb
-- lib/flipper/gates/percentage_of_random.rb
+- lib/flipper/gates/percentage_of_time.rb
 - lib/flipper/instrumentation/log_subscriber.rb
 - lib/flipper/instrumentation/metriks.rb
 - lib/flipper/instrumentation/metriks_subscriber.rb
@@ -64,13 +65,18 @@ files:
 - lib/flipper/registry.rb
 - lib/flipper/spec/shared_adapter_specs.rb
 - lib/flipper/type.rb
+- lib/flipper/typecast.rb
 - lib/flipper/types/actor.rb
 - lib/flipper/types/boolean.rb
 - lib/flipper/types/group.rb
 - lib/flipper/types/percentage.rb
 - lib/flipper/types/percentage_of_actors.rb
-- lib/flipper/types/percentage_of_random.rb
+- lib/flipper/types/percentage_of_time.rb
 - lib/flipper/version.rb
+- script/bootstrap
+- script/guard
+- script/release
+- script/test
 - spec/flipper/adapters/instrumented_spec.rb
 - spec/flipper/adapters/memoizable_spec.rb
 - spec/flipper/adapters/memory_spec.rb
@@ -78,11 +84,12 @@ files:
 - spec/flipper/dsl_spec.rb
 - spec/flipper/feature_spec.rb
 - spec/flipper/gate_spec.rb
+- spec/flipper/gate_values_spec.rb
 - spec/flipper/gates/actor_spec.rb
 - spec/flipper/gates/boolean_spec.rb
 - spec/flipper/gates/group_spec.rb
 - spec/flipper/gates/percentage_of_actors_spec.rb
-- spec/flipper/gates/percentage_of_random_spec.rb
+- spec/flipper/gates/percentage_of_time_spec.rb
 - spec/flipper/instrumentation/log_subscriber_spec.rb
 - spec/flipper/instrumentation/metriks_subscriber_spec.rb
 - spec/flipper/instrumentation/statsd_subscriber_spec.rb
@@ -90,11 +97,12 @@ files:
 - spec/flipper/instrumenters/noop_spec.rb
 - spec/flipper/middleware/memoizer_spec.rb
 - spec/flipper/registry_spec.rb
+- spec/flipper/typecast_spec.rb
 - spec/flipper/types/actor_spec.rb
 - spec/flipper/types/boolean_spec.rb
 - spec/flipper/types/group_spec.rb
 - spec/flipper/types/percentage_of_actors_spec.rb
-- spec/flipper/types/percentage_of_random_spec.rb
+- spec/flipper/types/percentage_of_time_spec.rb
 - spec/flipper/types/percentage_spec.rb
 - spec/flipper_spec.rb
 - spec/helper.rb
@@ -114,9 +122,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ">"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
 rubyforge_project: 
 rubygems_version: 2.2.2
@@ -131,11 +139,12 @@ test_files:
 - spec/flipper/dsl_spec.rb
 - spec/flipper/feature_spec.rb
 - spec/flipper/gate_spec.rb
+- spec/flipper/gate_values_spec.rb
 - spec/flipper/gates/actor_spec.rb
 - spec/flipper/gates/boolean_spec.rb
 - spec/flipper/gates/group_spec.rb
 - spec/flipper/gates/percentage_of_actors_spec.rb
-- spec/flipper/gates/percentage_of_random_spec.rb
+- spec/flipper/gates/percentage_of_time_spec.rb
 - spec/flipper/instrumentation/log_subscriber_spec.rb
 - spec/flipper/instrumentation/metriks_subscriber_spec.rb
 - spec/flipper/instrumentation/statsd_subscriber_spec.rb
@@ -143,11 +152,12 @@ test_files:
 - spec/flipper/instrumenters/noop_spec.rb
 - spec/flipper/middleware/memoizer_spec.rb
 - spec/flipper/registry_spec.rb
+- spec/flipper/typecast_spec.rb
 - spec/flipper/types/actor_spec.rb
 - spec/flipper/types/boolean_spec.rb
 - spec/flipper/types/group_spec.rb
 - spec/flipper/types/percentage_of_actors_spec.rb
-- spec/flipper/types/percentage_of_random_spec.rb
+- spec/flipper/types/percentage_of_time_spec.rb
 - spec/flipper/types/percentage_spec.rb
 - spec/flipper_spec.rb
 - spec/helper.rb