flipper 0.6.3 → 0.7.0.beta1

data/spec/flipper/gate_spec.rb

@@ -4,32 +4,13 @@ describe Flipper::Gate do
   let(:feature_name) { :stats }
 
   subject {
-    described_class.new(feature_name)
+    described_class.new
   }
 
-  describe "#initialize" do
-    it "sets feature_name" do
-      gate = described_class.new(feature_name)
-      gate.feature_name.should be(feature_name)
-    end
-
-    it "defaults instrumenter" do
-      gate = described_class.new(feature_name)
-      gate.instrumenter.should be(Flipper::Instrumenters::Noop)
-    end
-
-    it "allows overriding instrumenter" do
-      instrumenter = double('Instrumentor')
-      gate = described_class.new(feature_name, :instrumenter => instrumenter)
-      gate.instrumenter.should be(instrumenter)
-    end
-  end
-
   describe "#inspect" do
     it "returns easy to read string representation" do
       string = subject.inspect
       string.should include('Flipper::Gate')
-      string.should include('feature_name=:stats')
     end
   end
 end

data/spec/flipper/gate_values_spec.rb

@@ -0,0 +1,134 @@
+require 'helper'
+require 'flipper/gate_values'
+
+describe Flipper::GateValues do
+  {
+    nil => false,
+    "" => false,
+    0 => false,
+    1 => true,
+    "0" => false,
+    "1" => true,
+    true => true,
+    false => false,
+    "true" => true,
+    "false" => false,
+  }.each do |value, expected|
+    context "with #{value.inspect} boolean" do
+      it "returns #{expected}" do
+        described_class.new(boolean: value).boolean.should be(expected)
+      end
+    end
+  end
+
+  {
+    nil => 0,
+    "" => 0,
+    0 => 0,
+    1 => 1,
+    "1" => 1,
+    "99" => 99,
+  }.each do |value, expected|
+    context "with #{value.inspect} percentage of time" do
+      it "returns #{expected}" do
+        described_class.new(percentage_of_time: value).percentage_of_time.should be(expected)
+      end
+    end
+  end
+
+  {
+    nil => 0,
+    "" => 0,
+    0 => 0,
+    1 => 1,
+    "1" => 1,
+    "99" => 99,
+  }.each do |value, expected|
+    context "with #{value.inspect} percentage of actors" do
+      it "returns #{expected}" do
+        described_class.new(percentage_of_actors: value).percentage_of_actors.should be(expected)
+      end
+    end
+  end
+
+  {
+    nil => Set.new,
+    "" => Set.new,
+    Set.new([1, 2]) => Set.new([1, 2]),
+    [1, 2] => Set.new([1, 2])
+  }.each do |value, expected|
+    context "with #{value.inspect} actors" do
+      it "returns #{expected}" do
+        described_class.new(actors: value).actors.should eq(expected)
+      end
+    end
+  end
+
+  {
+    nil => Set.new,
+    "" => Set.new,
+    Set.new([:admins, :preview_features]) => Set.new([:admins, :preview_features]),
+    [:admins, :preview_features] => Set.new([:admins, :preview_features])
+  }.each do |value, expected|
+    context "with #{value.inspect} groups" do
+      it "returns #{expected}" do
+        described_class.new(groups: value).groups.should eq(expected)
+      end
+    end
+  end
+
+  it "raises argument error for percentage of time value that cannot be converted to an integer" do
+    expect {
+      described_class.new(percentage_of_time: ["asdf"])
+    }.to raise_error(ArgumentError, %Q(["asdf"] cannot be converted to an integer))
+  end
+
+  it "raises argument error for percentage of actors value that cannot be converted to an integer" do
+    expect {
+      described_class.new(percentage_of_actors: ["asdf"])
+    }.to raise_error(ArgumentError, %Q(["asdf"] cannot be converted to an integer))
+  end
+
+  it "raises argument error for actors value that cannot be converted to a set" do
+    expect {
+      described_class.new(actors: "asdf")
+    }.to raise_error(ArgumentError, %Q("asdf" cannot be converted to a set))
+  end
+
+  it "raises argument error for groups value that cannot be converted to a set" do
+    expect {
+      described_class.new(groups: "asdf")
+    }.to raise_error(ArgumentError, %Q("asdf" cannot be converted to a set))
+  end
+
+  describe "#[]" do
+    it "can read the boolean value" do
+      described_class.new(boolean: true)[:boolean].should be(true)
+      described_class.new(boolean: true)["boolean"].should be(true)
+    end
+
+    it "can read the actors value" do
+      described_class.new(actors: Set[1, 2])[:actors].should eq(Set[1, 2])
+      described_class.new(actors: Set[1, 2])["actors"].should eq(Set[1, 2])
+    end
+
+    it "can read the groups value" do
+      described_class.new(groups: Set[:admins])[:groups].should eq(Set[:admins])
+      described_class.new(groups: Set[:admins])["groups"].should eq(Set[:admins])
+    end
+
+    it "can read the percentage of time value" do
+      described_class.new(percentage_of_time: 15)[:percentage_of_time].should eq(15)
+      described_class.new(percentage_of_time: 15)["percentage_of_time"].should eq(15)
+    end
+
+    it "can read the percentage of actors value" do
+      described_class.new(percentage_of_actors: 15)[:percentage_of_actors].should eq(15)
+      described_class.new(percentage_of_actors: 15)["percentage_of_actors"].should eq(15)
+    end
+
+    it "returns nil for value that is not present" do
+      described_class.new({})["not legit"].should be(nil)
+    end
+  end
+end

data/spec/flipper/gates/actor_spec.rb

@@ -1,32 +1,12 @@
 require 'helper'
-require 'flipper/instrumenters/memory'
 
 describe Flipper::Gates::Actor do
-  let(:instrumenter) { Flipper::Instrumenters::Memory.new }
   let(:feature_name) { :search }
 
   subject {
-    described_class.new(feature_name, :instrumenter => instrumenter)
+    described_class.new
   }
 
-  describe "instrumentation" do
-    it "is recorded for open" do
-      thing = Struct.new(:flipper_id).new('22')
-      subject.open?(thing, Set.new)
-
-      event = instrumenter.events.last
-      event.should_not be_nil
-      event.name.should eq('gate_operation.flipper')
-      event.payload.should eq({
-        :thing => thing,
-        :operation => :open?,
-        :result => false,
-        :gate_name => :actor,
-        :feature_name => :search,
-      })
-    end
-  end
-
   describe "#description" do
     context "with actors in set" do
       it "returns text" do

data/spec/flipper/gates/boolean_spec.rb

@@ -1,12 +1,10 @@
 require 'helper'
-require 'flipper/instrumenters/memory'
 
 describe Flipper::Gates::Boolean do
-  let(:instrumenter) { Flipper::Instrumenters::Memory.new }
   let(:feature_name) { :search }
 
   subject {
-    described_class.new(feature_name, :instrumenter => instrumenter)
+    described_class.new
   }
 
   describe "#description" do
@@ -35,85 +33,19 @@ describe Flipper::Gates::Boolean do
         subject.enabled?(false).should eq(false)
       end
     end
-
-    context "for nil value" do
-      it "returns false" do
-        subject.enabled?(nil).should eq(false)
-      end
-    end
-
-    context "for empty string value" do
-      it "returns false" do
-        subject.enabled?('').should eq(false)
-      end
-    end
-
-    context "for the string true value" do
-      it "returns true" do
-        subject.enabled?('true').should eq(true)
-      end
-    end
-
-    context "for the string false value" do
-      it "returns false" do
-        subject.enabled?('false').should eq(false)
-      end
-    end
   end
 
   describe "#open?" do
     context "for true value" do
       it "returns true" do
-        subject.open?(Object.new, true).should eq(true)
+        subject.open?(Object.new, true, feature_name: feature_name).should eq(true)
       end
     end
 
     context "for false value" do
       it "returns false" do
-        subject.open?(Object.new, false).should eq(false)
-      end
-    end
-
-    context "for nil value" do
-      it "returns false" do
-        subject.open?(Object.new, nil).should eq(false)
-      end
-    end
-
-    context "for string true value" do
-      it "returns true" do
-        subject.open?(Object.new, 'true').should eq(true)
-      end
-    end
-
-    context "for string false value" do
-      it "returns false" do
-        subject.open?(Object.new, 'false').should eq(false)
-      end
-    end
-
-    context "for an empty string value" do
-      it "returns false" do
-        subject.open?(Object.new, '').should eq(false)
+        subject.open?(Object.new, false, feature_name: feature_name).should eq(false)
       end
     end
   end
-
-  describe "instrumentation" do
-    it "is recorded for open" do
-      thing = nil
-      subject.open?(thing, false)
-
-      event = instrumenter.events.last
-      event.should_not be_nil
-      event.name.should eq('gate_operation.flipper')
-      event.payload.should eq({
-        :thing => thing,
-        :operation => :open?,
-        :result => false,
-        :gate_name => :boolean,
-        :feature_name => :search,
-      })
-    end
-  end
 end

data/spec/flipper/gates/group_spec.rb

@@ -1,32 +1,12 @@
 require 'helper'
-require 'flipper/instrumenters/memory'
 
 describe Flipper::Gates::Group do
-  let(:instrumenter) { Flipper::Instrumenters::Memory.new }
   let(:feature_name) { :search }
 
   subject {
-    described_class.new(feature_name, :instrumenter => instrumenter)
+    described_class.new
   }
 
-  describe "instrumentation" do
-    it "is recorded for open" do
-      thing = Struct.new(:flipper_id).new('22')
-      subject.open?(thing, Set.new)
-
-      event = instrumenter.events.last
-      event.should_not be_nil
-      event.name.should eq('gate_operation.flipper')
-      event.payload.should eq({
-        :thing => thing,
-        :operation => :open?,
-        :result => false,
-        :gate_name => :group,
-        :feature_name => :search,
-      })
-    end
-  end
-
   describe "#description" do
     context "with groups in set" do
       it "returns text" do
@@ -50,7 +30,7 @@ describe Flipper::Gates::Group do
 
       it "ignores group" do
         thing = Struct.new(:flipper_id).new('5')
-        subject.open?(thing, Set[:newbs, :staff]).should eq(true)
+        subject.open?(thing, Set[:newbs, :staff], feature_name: feature_name).should eq(true)
       end
     end
 
@@ -61,7 +41,7 @@ describe Flipper::Gates::Group do
 
       it "raises error" do
         expect {
-          subject.open?(Object.new, Set[:stinkers])
+          subject.open?(Object.new, Set[:stinkers], feature_name: feature_name)
         }.to raise_error(NoMethodError)
       end
     end

data/spec/flipper/gates/percentage_of_actors_spec.rb

@@ -1,32 +1,12 @@
 require 'helper'
-require 'flipper/instrumenters/memory'
 
 describe Flipper::Gates::PercentageOfActors do
-  let(:instrumenter) { Flipper::Instrumenters::Memory.new }
   let(:feature_name) { :search }
 
   subject {
-    described_class.new(feature_name, :instrumenter => instrumenter)
+    described_class.new
   }
 
-  describe "instrumentation" do
-    it "is recorded for open" do
-      thing = Struct.new(:flipper_id).new('22')
-      subject.open?(thing, 0)
-
-      event = instrumenter.events.last
-      event.should_not be_nil
-      event.name.should eq('gate_operation.flipper')
-      event.payload.should eq({
-        :thing => thing,
-        :operation => :open?,
-        :result => false,
-        :gate_name => :percentage_of_actors,
-        :feature_name => :search,
-      })
-    end
-  end
-
   describe "#description" do
     context "when enabled" do
       it "returns text" do
@@ -36,7 +16,6 @@ describe Flipper::Gates::PercentageOfActors do
 
     context "when disabled" do
       it "returns disabled" do
-        subject.description(nil).should eq('disabled')
         subject.description(0).should eq('disabled')
       end
     end
@@ -53,13 +32,13 @@ describe Flipper::Gates::PercentageOfActors do
       }
 
       let(:feature_one_enabled_actors) do
-        gate = described_class.new(:name_one)
-        actors.select { |actor| gate.open? actor, percentage_as_integer }
+        gate = described_class.new
+        actors.select { |actor| gate.open? actor, percentage_as_integer, feature_name: :name_one }
       end
 
       let(:feature_two_enabled_actors) do
-        gate = described_class.new(:name_two)
-        actors.select { |actor| gate.open? actor, percentage_as_integer }
+        gate = described_class.new
+        actors.select { |actor| gate.open? actor, percentage_as_integer, feature_name: :name_two }
       end
 
       it "does not enable both features for same set of actors" do

data/spec/flipper/gates/percentage_of_time_spec.rb

@@ -0,0 +1,23 @@
+require 'helper'
+
+describe Flipper::Gates::PercentageOfTime do
+  let(:feature_name) { :search }
+
+  subject {
+    described_class.new
+  }
+
+  describe "#description" do
+    context "when enabled" do
+      it "returns text" do
+        subject.description(22).should eq('22% of the time')
+      end
+    end
+
+    context "when disabled" do
+      it "returns disabled" do
+        subject.description(0).should eq('disabled')
+      end
+    end
+  end
+end

data/spec/flipper/middleware/memoizer_spec.rb

@@ -7,8 +7,7 @@ require 'flipper/adapters/memory'
 describe Flipper::Middleware::Memoizer do
   include Rack::Test::Methods
 
-  let(:source)         { {} }
-  let(:memory_adapter) { Flipper::Adapters::Memory.new(source) }
+  let(:memory_adapter) { Flipper::Adapters::Memory.new }
   let(:adapter)        {
     Flipper::Adapters::OperationLogger.new(memory_adapter)
   }