flipper 0.4.0 → 0.5.0

data/spec/flipper/gate_spec.rb

@@ -1,33 +1,26 @@
 require 'helper'
 
 describe Flipper::Gate do
-  let(:adapter) { double('Adapter', :name => 'memory', :read => '22') }
-  let(:feature) { double('Feature', :name => :search, :adapter => adapter) }
+  let(:feature_name) { :stats }
 
   subject {
-    gate = described_class.new(feature)
-    # implemented in subclass
-    gate.stub({
-      :key => :actors,
-      :description => 'enabled',
-    })
-    gate
+    described_class.new(feature_name)
   }
 
   describe "#initialize" do
-    it "sets feature" do
-      gate = described_class.new(feature)
-      gate.feature.should be(feature)
+    it "sets feature_name" do
+      gate = described_class.new(feature_name)
+      gate.feature_name.should be(feature_name)
     end
 
     it "defaults instrumenter" do
-      gate = described_class.new(feature)
+      gate = described_class.new(feature_name)
       gate.instrumenter.should be(Flipper::Instrumenters::Noop)
     end
 
     it "allows overriding instrumenter" do
       instrumenter = double('Instrumentor')
-      gate = described_class.new(feature, :instrumenter => instrumenter)
+      gate = described_class.new(feature_name, :instrumenter => instrumenter)
       gate.instrumenter.should be(instrumenter)
     end
   end
@@ -36,12 +29,7 @@ describe Flipper::Gate do
     it "returns easy to read string representation" do
       string = subject.inspect
       string.should include('Flipper::Gate')
-      string.should include('feature=:search')
-      string.should include('description="enabled"')
-      string.should include("adapter=#{subject.adapter.name.inspect}")
-      string.should include('adapter_key=#<Flipper::Key:')
-      string.should include('toggle_class=Flipper::Toggles::Value')
-      string.should include('toggle_value="22"')
+      string.should include('feature_name=:stats')
     end
   end
 end

data/spec/flipper/gates/actor_spec.rb

@@ -2,18 +2,17 @@ require 'helper'
 require 'flipper/instrumenters/memory'
 
 describe Flipper::Gates::Actor do
-  let(:adapter) { double('Adapter', :set_members => []) }
-  let(:feature) { double('Feature', :name => :search, :adapter => adapter) }
   let(:instrumenter) { Flipper::Instrumenters::Memory.new }
+  let(:feature_name) { :search }
 
   subject {
-    described_class.new(feature, :instrumenter => instrumenter)
+    described_class.new(feature_name, :instrumenter => instrumenter)
   }
 
   describe "instrumentation" do
     it "is recorded for open" do
       thing = Struct.new(:flipper_id).new('22')
-      subject.open?(thing)
+      subject.open?(thing, Set.new)
 
       event = instrumenter.events.last
       event.should_not be_nil
@@ -30,22 +29,15 @@ describe Flipper::Gates::Actor do
 
   describe "#description" do
     context "with actors in set" do
-      before do
-        adapter.stub(:set_members => Set['bacon', 'ham'])
-      end
-
       it "returns text" do
-        subject.description.should eq("actors (bacon, ham)")
+        values = Set['bacon', 'ham']
+        subject.description(values).should eq('actors ("bacon", "ham")')
       end
     end
 
     context "with no actors in set" do
-      before do
-        adapter.stub(:set_members => Set.new)
-      end
-
       it "returns disabled" do
-        subject.description.should eq('disabled')
+        subject.description(Set.new).should eq('disabled')
       end
     end
   end

data/spec/flipper/gates/boolean_spec.rb

@@ -2,32 +2,99 @@ require 'helper'
 require 'flipper/instrumenters/memory'
 
 describe Flipper::Gates::Boolean do
-  let(:adapter) { double('Adapter', :read => nil) }
-  let(:feature) { double('Feature', :name => :search, :adapter => adapter) }
   let(:instrumenter) { Flipper::Instrumenters::Memory.new }
+  let(:feature_name) { :search }
 
   subject {
-    described_class.new(feature, :instrumenter => instrumenter)
+    described_class.new(feature_name, :instrumenter => instrumenter)
   }
 
   describe "#description" do
     context "for enabled" do
-      before do
-        subject.stub(:enabled? => true)
-      end
-
       it "returns Enabled" do
-        subject.description.should eq('Enabled')
+        subject.description(true).should eq('Enabled')
       end
     end
 
     context "for disabled" do
-      before do
-        subject.stub(:enabled? => false)
+      it "returns Disabled" do
+        subject.description(false).should eq('Disabled')
+      end
+    end
+  end
+
+  describe "#enabled?" do
+    context "for true value" do
+      it "returns true" do
+        subject.enabled?(true).should be_true
       end
+    end
 
-      it "returns Disabled" do
-        subject.description.should eq('Disabled')
+    context "for false value" do
+      it "returns false" do
+        subject.enabled?(false).should be_false
+      end
+    end
+
+    context "for nil value" do
+      it "returns false" do
+        subject.enabled?(nil).should be_false
+      end
+    end
+
+    context "for empty string value" do
+      it "returns false" do
+        subject.enabled?('').should be_false
+      end
+    end
+
+    context "for the string true value" do
+      it "returns true" do
+        subject.enabled?('true').should be_true
+      end
+    end
+
+    context "for the string false value" do
+      it "returns false" do
+        subject.enabled?('false').should be_false
+      end
+    end
+  end
+
+  describe "#open?" do
+    context "for true value" do
+      it "returns true" do
+        subject.open?(Object.new, true).should be_true
+      end
+    end
+
+    context "for false value" do
+      it "returns false" do
+        subject.open?(Object.new, false).should be_false
+      end
+    end
+
+    context "for nil value" do
+      it "returns false" do
+        subject.open?(Object.new, nil).should be_false
+      end
+    end
+
+    context "for string true value" do
+      it "returns true" do
+        subject.open?(Object.new, 'true').should be_true
+      end
+    end
+
+    context "for string false value" do
+      it "returns false" do
+        subject.open?(Object.new, 'false').should be_false
+      end
+    end
+
+    context "for an empty string value" do
+      it "returns false" do
+        subject.open?(Object.new, '').should be_false
       end
     end
   end
@@ -35,7 +102,7 @@ describe Flipper::Gates::Boolean do
   describe "instrumentation" do
     it "is recorded for open" do
       thing = nil
-      subject.open?(thing)
+      subject.open?(thing, false)
 
       event = instrumenter.events.last
       event.should_not be_nil

data/spec/flipper/gates/group_spec.rb

@@ -2,18 +2,17 @@ require 'helper'
 require 'flipper/instrumenters/memory'
 
 describe Flipper::Gates::Group do
-  let(:adapter) { double('Adapter', :set_members => []) }
-  let(:feature) { double('Feature', :name => :search, :adapter => adapter) }
   let(:instrumenter) { Flipper::Instrumenters::Memory.new }
+  let(:feature_name) { :search }
 
   subject {
-    described_class.new(feature, :instrumenter => instrumenter)
+    described_class.new(feature_name, :instrumenter => instrumenter)
   }
 
   describe "instrumentation" do
     it "is recorded for open" do
       thing = Struct.new(:flipper_id).new('22')
-      subject.open?(thing)
+      subject.open?(thing, Set.new)
 
       event = instrumenter.events.last
       event.should_not be_nil
@@ -30,22 +29,15 @@ describe Flipper::Gates::Group do
 
   describe "#description" do
     context "with groups in set" do
-      before do
-        adapter.stub(:set_members => Set['bacon', 'ham'])
-      end
-
       it "returns text" do
-        subject.description.should eq("groups (bacon, ham)")
+        values = Set['bacon', 'ham']
+        subject.description(values).should eq('groups (:bacon, :ham)')
       end
     end
 
     context "with no groups in set" do
-      before do
-        adapter.stub(:set_members => Set.new)
-      end
-
       it "returns disabled" do
-        subject.description.should eq('disabled')
+        subject.description(Set.new).should eq('disabled')
       end
     end
   end
@@ -54,24 +46,22 @@ describe Flipper::Gates::Group do
     context "with a group in adapter, but not registered" do
       before do
         Flipper.register(:staff) { |thing| true }
-        adapter.stub(:set_members => Set[:newbs, :staff])
       end
 
       it "ignores group" do
         thing = Struct.new(:flipper_id).new('5')
-        subject.open?(thing).should be_true
+        subject.open?(thing, Set[:newbs, :staff]).should be_true
       end
     end
 
     context "thing that does not respond to method in group block" do
       before do
         Flipper.register(:stinkers) { |thing| thing.stinker? }
-        adapter.stub(:set_members => Set[:stinkers])
       end
 
       it "raises error" do
         expect {
-          subject.open?(Object.new)
+          subject.open?(Object.new, Set[:stinkers])
         }.to raise_error(NoMethodError)
       end
     end

data/spec/flipper/gates/percentage_of_actors_spec.rb

@@ -2,18 +2,17 @@ require 'helper'
 require 'flipper/instrumenters/memory'
 
 describe Flipper::Gates::PercentageOfActors do
-  let(:adapter) { double('Adapter', :read => nil) }
-  let(:feature) { double('Feature', :name => :search, :adapter => adapter) }
   let(:instrumenter) { Flipper::Instrumenters::Memory.new }
+  let(:feature_name) { :search }
 
   subject {
-    described_class.new(feature, :instrumenter => instrumenter)
+    described_class.new(feature_name, :instrumenter => instrumenter)
   }
 
   describe "instrumentation" do
     it "is recorded for open" do
       thing = Struct.new(:flipper_id).new('22')
-      subject.open?(thing)
+      subject.open?(thing, 0)
 
       event = instrumenter.events.last
       event.should_not be_nil
@@ -30,22 +29,15 @@ describe Flipper::Gates::PercentageOfActors do
 
   describe "#description" do
     context "when enabled" do
-      before do
-        adapter.stub(:read => 22)
-      end
-
       it "returns text" do
-        subject.description.should eq('22% of actors')
+        subject.description(22).should eq('22% of actors')
       end
     end
 
     context "when disabled" do
-      before do
-        adapter.stub(:read => nil)
-      end
-
       it "returns disabled" do
-        subject.description.should eq('disabled')
+        subject.description(nil).should eq('disabled')
+        subject.description(0).should eq('disabled')
       end
     end
   end
@@ -53,29 +45,21 @@ describe Flipper::Gates::PercentageOfActors do
   describe "#open?" do
     context "when compared against two features" do
       let(:percentage) { 0.05 }
+      let(:percentage_as_integer) { percentage * 100 }
       let(:number_of_actors) { 100 }
 
       let(:actors) {
-        (1..number_of_actors).map { |n|
-          Struct.new(:flipper_id).new(n)
-        }
+        (1..number_of_actors).map { |n| Struct.new(:flipper_id).new(n) }
       }
 
       let(:feature_one_enabled_actors) do
-        feature_one = double('Feature', :name => :name_one, :adapter => adapter)
-        gate = described_class.new(feature_one)
-        actors.select { |actor| gate.open? actor }
+        gate = described_class.new(:name_one)
+        actors.select { |actor| gate.open? actor, percentage_as_integer }
       end
 
       let(:feature_two_enabled_actors) do
-        feature_two = double('Feature', :name => :name_two, :adapter => adapter)
-        gate = described_class.new(feature_two)
-        actors.select { |actor| gate.open? actor }
-      end
-
-      before do
-        percentage_as_integer = percentage * 100
-        adapter.stub(:read => percentage_as_integer)
+        gate = described_class.new(:name_two)
+        actors.select { |actor| gate.open? actor, percentage_as_integer }
       end
 
       it "does not enable both features for same set of actors" do

data/spec/flipper/gates/percentage_of_random_spec.rb

@@ -2,18 +2,17 @@ require 'helper'
 require 'flipper/instrumenters/memory'
 
 describe Flipper::Gates::PercentageOfRandom do
-  let(:adapter) { double('Adapter', :read => 5) }
-  let(:feature) { double('Feature', :name => :search, :adapter => adapter) }
   let(:instrumenter) { Flipper::Instrumenters::Memory.new }
+  let(:feature_name) { :search }
 
   subject {
-    described_class.new(feature, :instrumenter => instrumenter)
+    described_class.new(feature_name, :instrumenter => instrumenter)
   }
 
   describe "instrumentation" do
     it "is recorded for open" do
       thing = Struct.new(:flipper_id).new('22')
-      subject.open?(thing)
+      subject.open?(thing, 0)
 
       event = instrumenter.events.last
       event.should_not be_nil
@@ -32,22 +31,15 @@ describe Flipper::Gates::PercentageOfRandom do
 
   describe "#description" do
     context "when enabled" do
-      before do
-        adapter.stub(:read => 22)
-      end
-
       it "returns text" do
-        subject.description.should eq('22% of the time')
+        subject.description(22).should eq('22% of the time')
       end
     end
 
     context "when disabled" do
-      before do
-        adapter.stub(:read => nil)
-      end
-
       it "returns disabled" do
-        subject.description.should eq('disabled')
+        subject.description(nil).should eq('disabled')
+        subject.description(0).should eq('disabled')
       end
     end
   end

data/spec/flipper/instrumentation/log_subscriber_spec.rb

@@ -37,8 +37,9 @@ describe Flipper::Instrumentation::LogSubscriber do
     end
 
     it "logs adapter calls" do
-      adapter_line = find_line('Flipper feature(search) adapter(memory) read("search/boolean")')
-      adapter_line.should include('[ result=nil ]')
+      adapter_line = find_line('Flipper feature(search) adapter(memory) get')
+      adapter_line.should include('[ result={')
+      adapter_line.should include('} ]')
     end
 
     it "logs gate calls" do
@@ -80,14 +81,20 @@ describe Flipper::Instrumentation::LogSubscriber do
     end
 
     it "logs adapter value" do
-      adapter_line = find_line('Flipper feature(search) adapter(memory) set_add("search/actors")')
-      adapter_line.should include("value=#{user.flipper_id.to_s.inspect}")
+      adapter_line = find_line('Flipper feature(search) adapter(memory) enable')
+      adapter_line.should include("[ result=")
+    end
+  end
+
+  context "getting all the features from the adapter" do
+    before do
+      clear_logs
+      flipper.features
     end
 
-    it "logs adapter calls not related to a specific feature" do
-      adapter_line = find_line('Flipper adapter(memory) set_add("features")')
-      log.should_not include('Could not log')
-      log.should_not include('NoMethodError: undefined method')
+    it "logs adapter calls" do
+      adapter_line = find_line('Flipper adapter(memory) features')
+      adapter_line.should include('[ result=')
     end
   end