flipper 0.4.0 → 0.5.0

data/spec/flipper/adapters/memoizable_spec.rb

@@ -0,0 +1,184 @@
+require 'helper'
+require 'flipper/adapters/memoizable'
+require 'flipper/adapters/memory'
+require 'flipper/spec/shared_adapter_specs'
+
+describe Flipper::Adapters::Memoizable do
+  let(:features_key) { described_class::FeaturesKey }
+
+  let(:adapter) { Flipper::Adapters::Memory.new }
+  let(:flipper) { Flipper.new(adapter) }
+  let(:cache) { Thread.current[:flipper_memoize_cache] }
+
+  after do
+    described_class.memoize = nil
+  end
+
+  subject { described_class.new(adapter) }
+
+  it_should_behave_like 'a flipper adapter'
+
+  describe "#memoize=" do
+    it "sets value" do
+      subject.memoize = true
+      subject.memoizing?.should be_true
+
+      subject.memoize = false
+      subject.memoizing?.should be_false
+    end
+
+    it "clears the local cache" do
+      subject.cache['some'] = 'thing'
+      subject.memoize = true
+      subject.cache.should be_empty
+    end
+  end
+
+  describe "#memoizing?" do
+    it "returns true if enabled" do
+      subject.memoize = true
+      subject.memoizing?.should be_true
+    end
+
+    it "returns false if disabled" do
+      subject.memoize = false
+      subject.memoizing?.should be_false
+    end
+  end
+
+  describe "#get" do
+    context "with memoization enabled" do
+      before do
+        subject.memoize = true
+      end
+
+      it "memoizes feature" do
+        feature = flipper[:stats]
+        result = subject.get(feature)
+        cache[feature].should be(result)
+      end
+    end
+
+    context "with memoization disabled" do
+      before do
+        subject.memoize = false
+      end
+
+      it "returns result" do
+        feature = flipper[:stats]
+        result = subject.get(feature)
+        adapter_result = adapter.get(feature)
+        result.should eq(adapter_result)
+      end
+    end
+  end
+
+  describe "#enable" do
+    context "with memoization enabled" do
+      before do
+        subject.memoize = true
+      end
+
+      it "unmemoizes feature" do
+        feature = flipper[:stats]
+        gate = feature.gate(:boolean)
+        cache[feature] = {:some => 'thing'}
+        subject.enable(feature, gate, flipper.bool)
+        cache[feature].should be_nil
+      end
+    end
+
+    context "with memoization disabled" do
+      before do
+        subject.memoize = false
+      end
+
+      it "returns result" do
+        feature = flipper[:stats]
+        gate = feature.gate(:boolean)
+        result = subject.enable(feature, gate, flipper.bool)
+        adapter_result = adapter.enable(feature, gate, flipper.bool)
+        result.should eq(adapter_result)
+      end
+    end
+  end
+
+  describe "#disable" do
+    context "with memoization enabled" do
+      before do
+        subject.memoize = true
+      end
+
+      it "unmemoizes feature" do
+        feature = flipper[:stats]
+        gate = feature.gate(:boolean)
+        cache[feature] = {:some => 'thing'}
+        subject.disable(feature, gate, flipper.bool)
+        cache[feature].should be_nil
+      end
+    end
+
+    context "with memoization disabled" do
+      before do
+        subject.memoize = false
+      end
+
+      it "returns result" do
+        feature = flipper[:stats]
+        gate = feature.gate(:boolean)
+        result = subject.disable(feature, gate, flipper.bool)
+        adapter_result = adapter.disable(feature, gate, flipper.bool)
+        result.should eq(adapter_result)
+      end
+    end
+  end
+
+  describe "#features" do
+    context "with memoization enabled" do
+      before do
+        subject.memoize = true
+      end
+
+      it "memoizes features" do
+        flipper[:stats].enable
+        flipper[:search].disable
+        result = subject.features
+        cache[:flipper_features].should be(result)
+      end
+    end
+
+    context "with memoization disabled" do
+      before do
+        subject.memoize = false
+      end
+
+      it "returns result" do
+        subject.features.should eq(adapter.features)
+      end
+    end
+  end
+
+  describe "#add" do
+    context "with memoization enabled" do
+      before do
+        subject.memoize = true
+      end
+
+      it "unmemoizes features" do
+        cache[features_key] = {:some => 'thing'}
+        subject.add(flipper[:stats])
+        cache.should be_empty
+      end
+    end
+
+    context "with memoization disabled" do
+      before do
+        subject.memoize = false
+      end
+
+      it "returns result" do
+        subject.add(flipper[:stats]).should eq(adapter.add(flipper[:stats]))
+      end
+    end
+  end
+end

data/spec/flipper/adapters/memory_spec.rb

@@ -3,17 +3,7 @@ require 'flipper/adapters/memory'
 require 'flipper/spec/shared_adapter_specs'
 
 describe Flipper::Adapters::Memory do
-  let(:source) { {} }
-
-  subject { described_class.new(source) }
-
-  def read_key(key)
-    source[key.to_s]
-  end
-
-  def write_key(key, value)
-    source[key.to_s] = value
-  end
+  subject { described_class.new }
 
   it_should_behave_like 'a flipper adapter'
 end

data/spec/flipper/adapters/operation_logger_spec.rb

@@ -0,0 +1,93 @@
+require 'helper'
+require 'flipper/adapters/operation_logger'
+require 'flipper/adapters/memory'
+require 'flipper/spec/shared_adapter_specs'
+
+describe Flipper::Adapters::OperationLogger do
+  let(:operations) { [] }
+  let(:adapter)    { Flipper::Adapters::Memory.new }
+  let(:flipper)    { Flipper.new(adapter) }
+
+  subject { described_class.new(adapter, operations) }
+
+  it_should_behave_like 'a flipper adapter'
+
+  describe "#get" do
+    before do
+      @feature = flipper[:stats]
+      @result = subject.get(@feature)
+    end
+
+    it "logs operation" do
+      subject.count(:get).should be(1)
+    end
+
+    it "returns result" do
+      @result.should eq(adapter.get(@feature))
+    end
+  end
+
+  describe "#enable" do
+    before do
+      @feature = flipper[:stats]
+      @gate = @feature.gate(:boolean)
+      @thing = flipper.bool
+      @result = subject.enable(@feature, @gate, @thing)
+    end
+
+    it "logs operation" do
+      subject.count(:enable).should be(1)
+    end
+
+    it "returns result" do
+      @result.should eq(adapter.enable(@feature, @gate, @thing))
+    end
+  end
+
+  describe "#disable" do
+    before do
+      @feature = flipper[:stats]
+      @gate = @feature.gate(:boolean)
+      @thing = flipper.bool
+      @result = subject.disable(@feature, @gate, @thing)
+    end
+
+    it "logs operation" do
+      subject.count(:disable).should be(1)
+    end
+
+    it "returns result" do
+      @result.should eq(adapter.disable(@feature, @gate, @thing))
+    end
+  end
+
+  describe "#features" do
+    before do
+      flipper[:stats].enable
+      @result = subject.features
+    end
+
+    it "logs operation" do
+      subject.count(:features).should be(1)
+    end
+
+    it "returns result" do
+      @result.should eq(adapter.features)
+    end
+  end
+
+  describe "#add" do
+    before do
+      @feature = flipper[:stats]
+      @result = subject.add(@feature)
+    end
+
+    it "logs operation" do
+      subject.count(:add).should be(1)
+    end
+
+    it "returns result" do
+      @result.should eq(adapter.add(@feature))
+    end
+  end
+end

data/spec/flipper/dsl_spec.rb

@@ -8,13 +8,10 @@ describe Flipper::DSL do
   let(:source)  { {} }
   let(:adapter) { Flipper::Adapters::Memory.new(source) }
 
-  let(:admins_feature) { Flipper::Feature.new(:admins, adapter) }
-
   describe "#initialize" do
-    it "wraps adapter" do
+    it "sets adapter" do
       dsl = described_class.new(adapter)
-      dsl.adapter.should be_instance_of(Flipper::Adapter)
-      dsl.adapter.adapter.should eq(adapter)
+      dsl.adapter.should_not be_nil
     end
 
     it "defaults instrumenter to noop" do
@@ -37,58 +34,36 @@ describe Flipper::DSL do
     end
   end
 
-  describe "#enabled?" do
-    before do
-      subject.stub(:feature => admins_feature)
-    end
-
-    it "passes arguments to feature enabled check and returns result" do
-      admins_feature.should_receive(:enabled?).with(:foo).and_return(true)
-      subject.should_receive(:feature).with(:stats).and_return(admins_feature)
-      subject.enabled?(:stats, :foo).should be_true
-    end
-  end
-
-  describe "#enable" do
-    before do
-      subject.stub(:feature => admins_feature)
-    end
-
-    it "calls enable for feature with arguments" do
-      admins_feature.should_receive(:enable).with(:foo)
-      subject.should_receive(:feature).with(:stats).and_return(admins_feature)
-      subject.enable :stats, :foo
-    end
-  end
-
-  describe "#disable" do
-    before do
-      subject.stub(:feature => admins_feature)
-    end
-
-    it "calls disable for feature with arguments" do
-      admins_feature.should_receive(:disable).with(:foo)
-      subject.should_receive(:feature).with(:stats).and_return(admins_feature)
-      subject.disable :stats, :foo
-    end
-  end
-
   describe "#feature" do
     it_should_behave_like "a DSL feature" do
+      let(:method_name) { :feature }
       let(:instrumenter) { double('Instrumentor', :instrument => nil) }
-      let(:feature) { dsl.feature(:stats) }
+      let(:feature) { dsl.send(method_name, :stats) }
       let(:dsl) { Flipper::DSL.new(adapter, :instrumenter => instrumenter) }
     end
   end
 
   describe "#[]" do
     it_should_behave_like "a DSL feature" do
+      let(:method_name) { :[] }
       let(:instrumenter) { double('Instrumentor', :instrument => nil) }
-      let(:feature) { dsl[:stats] }
+      let(:feature) { dsl.send(method_name, :stats) }
       let(:dsl) { Flipper::DSL.new(adapter, :instrumenter => instrumenter) }
     end
   end
 
+  describe "#boolean" do
+    it_should_behave_like "a DSL boolean method" do
+      let(:method_name) { :boolean }
+    end
+  end
+
+  describe "#bool" do
+    it_should_behave_like "a DSL boolean method" do
+      let(:method_name) { :bool }
+    end
+  end
+
   describe "#group" do
     context "for registered group" do
       before do

data/spec/flipper/feature_spec.rb

@@ -17,7 +17,7 @@ describe Flipper::Feature do
 
     it "sets adapter" do
       feature = described_class.new(:search, adapter)
-      feature.adapter.should eq(Flipper::Adapter.wrap(adapter))
+      feature.adapter.should eq(adapter)
     end
 
     it "defaults instrumenter" do
@@ -34,13 +34,6 @@ describe Flipper::Feature do
         })
         feature.instrumenter.should be(instrumenter)
       end
-
-      it "passes overridden instrumenter to adapter wrapping" do
-        feature = described_class.new(:search, adapter, {
-          :instrumenter => instrumenter,
-        })
-        feature.adapter.instrumenter.should be(instrumenter)
-      end
     end
   end
 
@@ -67,12 +60,35 @@ describe Flipper::Feature do
     end
   end
 
+  describe "#gate" do
+    context "with symbol name" do
+      it "returns gate by name" do
+        boolean_gate = subject.gates.detect { |gate| gate.name == :boolean }
+        subject.gate(:boolean).should eq(boolean_gate)
+      end
+    end
+
+    context "with string name" do
+      it "returns gate by name" do
+        boolean_gate = subject.gates.detect { |gate| gate.name == :boolean }
+        subject.gate('boolean').should eq(boolean_gate)
+      end
+    end
+
+    context "with name that does not exist" do
+      it "returns nil" do
+        subject.gate(:poo).should be_nil
+      end
+    end
+  end
+
   describe "#inspect" do
     it "returns easy to read string representation" do
       string = subject.inspect
       string.should include('Flipper::Feature')
       string.should include('name=:search')
       string.should include('state=:off')
+      string.should include('description="Disabled"')
       string.should include("adapter=#{subject.adapter.name.inspect}")
     end
   end
@@ -191,7 +207,7 @@ describe Flipper::Feature do
       end
 
       it "returns text" do
-        subject.description.should eq('Enabled for actors (5), 5% of the time')
+        subject.description.should eq('Enabled for actors ("5"), 5% of the time')
       end
     end
   end