flipper 0.3.0 → 0.4.0

data/spec/integration_spec.rb

@@ -5,17 +5,19 @@ require 'flipper/adapters/memory'
 describe Flipper::Feature do
   subject           { described_class.new(:search, adapter) }
 
+  let(:actor_class) { Struct.new(:flipper_id) }
+
   let(:source)      { {} }
   let(:adapter)     { Flipper::Adapters::Memory.new(source) }
 
   let(:admin_group) { Flipper.group(:admins) }
   let(:dev_group)   { Flipper.group(:devs) }
 
-  let(:admin_thing) { double 'Non Flipper Thing', :identifier => 1,  :admin? => true, :dev? => false }
-  let(:dev_thing)   { double 'Non Flipper Thing', :identifier => 10, :admin? => false, :dev? => true }
+  let(:admin_thing) { double 'Non Flipper Thing', :flipper_id => 1,  :admin? => true, :dev? => false }
+  let(:dev_thing)   { double 'Non Flipper Thing', :flipper_id => 10, :admin? => false, :dev? => true }
 
-  let(:pitt)        { Flipper::Types::Actor.new(1) }
-  let(:clooney)     { Flipper::Types::Actor.new(10) }
+  let(:pitt)        { actor_class.new(1) }
+  let(:clooney)     { actor_class.new(10) }
 
   let(:five_percent_of_actors) { Flipper::Types::PercentageOfActors.new(5) }
   let(:five_percent_of_random) { Flipper::Types::PercentageOfRandom.new(5) }
@@ -25,36 +27,18 @@ describe Flipper::Feature do
     Flipper.register(:devs)   { |thing| thing.dev? }
   end
 
-  def enable_feature(feature)
-    key = Flipper::Key.new(subject.name, Flipper::Gates::Boolean::Key)
-    adapter.write key, true
-  end
-
-  def enable_group(group)
-    key = Flipper::Key.new(subject.name, Flipper::Gates::Group::Key)
-    name = group.respond_to?(:name) ? group.name : group
-    adapter.set_add key, name
-  end
-
-  def enable_actor(actor)
-    key = Flipper::Key.new(subject.name, Flipper::Gates::Actor::Key)
-    adapter.set_add key, actor.identifier
-  end
-
-  def enable_percentage_of_actors(percentage)
-    key = Flipper::Key.new(subject.name, Flipper::Gates::PercentageOfActors::Key)
-    adapter.write key, percentage.value
-  end
-
-  def enable_percentage_of_random(percentage)
-    key = Flipper::Key.new(subject.name, Flipper::Gates::PercentageOfRandom::Key)
-    adapter.write key, percentage.value
+  after do
+    Flipper.groups = nil
   end
 
   describe "#enable" do
     context "with no arguments" do
       before do
-        subject.enable
+        @result = subject.enable
+      end
+
+      it "returns true" do
+        @result.should be_true
       end
 
       it "enables feature for all" do
@@ -68,7 +52,11 @@ describe Flipper::Feature do
 
     context "with a group" do
       before do
-        subject.enable(admin_group)
+        @result = subject.enable(admin_group)
+      end
+
+      it "returns true" do
+        @result.should be_true
       end
 
       it "enables feature for non flipper thing in group" do
@@ -98,7 +86,11 @@ describe Flipper::Feature do
 
     context "with an actor" do
       before do
-        subject.enable(pitt)
+        @result = subject.enable(pitt)
+      end
+
+      it "returns true" do
+        @result.should be_true
       end
 
       it "enables feature for actor" do
@@ -116,11 +108,19 @@ describe Flipper::Feature do
 
     context "with a percentage of actors" do
       before do
-        subject.enable(five_percent_of_actors)
+        @result = subject.enable(five_percent_of_actors)
+      end
+
+      it "returns true" do
+        @result.should be_true
       end
 
       it "enables feature for actor within percentage" do
-        enabled = (1..100).select { |i| subject.enabled?(Flipper::Types::Actor.new(i)) }.length
+        enabled = (1..100).select { |i|
+          thing = actor_class.new(i)
+          subject.enabled?(thing)
+        }.size
+
         enabled.should be_within(2).of(5)
       end
 
@@ -133,7 +133,11 @@ describe Flipper::Feature do
       before do
         @gate = Flipper::Gates::PercentageOfRandom.new(subject)
         Flipper::Gates::PercentageOfRandom.should_receive(:new).and_return(@gate)
-        subject.enable(five_percent_of_random)
+        @result = subject.enable(five_percent_of_random)
+      end
+
+      it "returns true" do
+        @result.should be_true
       end
 
       it "enables feature for time within percentage" do
@@ -168,11 +172,15 @@ describe Flipper::Feature do
         @gate = Flipper::Gates::PercentageOfRandom.new(subject)
         @gate.stub(:rand => 0.04)
         Flipper::Gates::PercentageOfRandom.should_receive(:new).and_return(@gate)
-        enable_group admin_group
-        enable_actor pitt
-        enable_percentage_of_actors five_percent_of_actors
-        enable_percentage_of_random five_percent_of_random
-        subject.disable
+        subject.enable admin_group
+        subject.enable pitt
+        subject.enable five_percent_of_actors
+        subject.enable five_percent_of_random
+        @result = subject.disable
+      end
+
+      it "returns true" do
+        @result.should be_true
       end
 
       it "disables feature" do
@@ -188,7 +196,11 @@ describe Flipper::Feature do
       end
 
       it "disables actor in percentage of actors" do
-        enabled = (1..100).select { |i| subject.enabled?(Flipper::Types::Actor.new(i)) }.length
+        enabled = (1..100).select { |i|
+          thing = actor_class.new(i)
+          subject.enabled?(thing)
+        }.size
+
         enabled.should be(0)
       end
 
@@ -203,9 +215,13 @@ describe Flipper::Feature do
 
     context "with a group" do
       before do
-        enable_group dev_group
-        enable_group admin_group
-        subject.disable(admin_group)
+        subject.enable dev_group
+        subject.enable admin_group
+        @result = subject.disable(admin_group)
+      end
+
+      it "returns true" do
+        @result.should be_true
       end
 
       it "disables the feature for non flipper thing in the group" do
@@ -231,9 +247,13 @@ describe Flipper::Feature do
 
     context "with an actor" do
       before do
-        enable_actor pitt
-        enable_actor clooney
-        subject.disable(pitt)
+        subject.enable pitt
+        subject.enable clooney
+        @result = subject.disable(pitt)
+      end
+
+      it "returns true" do
+        @result.should be_true
       end
 
       it "disables feature for actor" do
@@ -251,11 +271,19 @@ describe Flipper::Feature do
 
     context "with a percentage of actors" do
       before do
-        subject.disable(five_percent_of_actors)
+        @result = subject.disable(five_percent_of_actors)
+      end
+
+      it "returns true" do
+        @result.should be_true
       end
 
       it "disables feature" do
-        enabled = (1..100).select { |i| subject.enabled?(Flipper::Types::Actor.new(i)) }.length
+        enabled = (1..100).select { |i|
+          thing = actor_class.new(i)
+          subject.enabled?(thing)
+        }.size
+
         enabled.should be(0)
       end
 
@@ -268,7 +296,11 @@ describe Flipper::Feature do
       before do
         @gate = Flipper::Gates::PercentageOfRandom.new(subject)
         Flipper::Gates::PercentageOfRandom.should_receive(:new).and_return(@gate)
-        subject.disable(five_percent_of_random)
+        @result = subject.disable(five_percent_of_random)
+      end
+
+      it "returns true" do
+        @result.should be_true
       end
 
       it "disables feature for time within percentage" do
@@ -305,7 +337,7 @@ describe Flipper::Feature do
 
     context "with no arguments, but boolean enabled" do
       before do
-        enable_feature subject
+        subject.enable
       end
 
       it "returns true" do
@@ -315,7 +347,7 @@ describe Flipper::Feature do
 
     context "for actor in enabled group" do
       before do
-        enable_group admin_group
+        subject.enable admin_group
       end
 
       it "returns true" do
@@ -331,7 +363,7 @@ describe Flipper::Feature do
 
     context "for enabled actor" do
       before do
-        enable_actor pitt
+        subject.enable pitt
       end
 
       it "returns true" do
@@ -345,7 +377,7 @@ describe Flipper::Feature do
       end
 
       it "returns true if boolean enabled" do
-        enable_feature subject
+        subject.enable
         subject.enabled?(clooney).should be_true
       end
     end
@@ -355,7 +387,7 @@ describe Flipper::Feature do
         @gate = Flipper::Gates::PercentageOfRandom.new(subject)
         @gate.stub(:rand => 0.04)
         Flipper::Gates::PercentageOfRandom.should_receive(:new).and_return(@gate)
-        enable_percentage_of_random five_percent_of_random
+        subject.enable five_percent_of_random
       end
 
       it "returns true" do
@@ -371,7 +403,7 @@ describe Flipper::Feature do
         @gate = Flipper::Gates::PercentageOfRandom.new(subject)
         @gate.stub(:rand => 0.10)
         Flipper::Gates::PercentageOfRandom.should_receive(:new).and_return(@gate)
-        enable_percentage_of_random five_percent_of_random
+        subject.enable five_percent_of_random
       end
 
       it "returns false" do
@@ -382,7 +414,7 @@ describe Flipper::Feature do
       end
 
       it "returns true if boolean enabled" do
-        enable_feature subject
+        subject.enable
         subject.enabled?.should be_true
         subject.enabled?(nil).should be_true
         subject.enabled?(pitt).should be_true
@@ -392,7 +424,7 @@ describe Flipper::Feature do
 
     context "for a non flipper thing" do
       before do
-        enable_group admin_group
+        subject.enable admin_group
       end
 
       it "returns true if in enabled group" do
@@ -404,36 +436,11 @@ describe Flipper::Feature do
       end
 
       it "returns true if boolean enabled" do
-        enable_feature subject
+        subject.enable
         subject.enabled?(admin_thing).should be_true
         subject.enabled?(dev_thing).should be_true
       end
     end
-
-    context "for a non flipper thing that does not respond to something in group block" do
-      let(:actor) { double('Actor') }
-
-      before do
-        boomboom = Flipper.register(:boomboom) { |actor| actor.boomboom? }
-        enable_group boomboom
-      end
-
-      it "returns false" do
-        expect { subject.enabled?(actor) }.to raise_error
-      end
-    end
-
-    context "for a non flipper thing when group in adapter, but not defined in code" do
-      let(:actor) { double('Actor') }
-
-      before do
-        enable_group :support
-      end
-
-      it "returns false" do
-        subject.enabled?(actor).should be_false
-      end
-    end
   end
 
   context "enabling multiple groups, disabling everything, then enabling one group" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: flipper
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.4.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-11-15 00:00:00.000000000 Z
+date: 2013-02-06 00:00:00.000000000 Z
 dependencies: []
 description: Feature flipper for any adapter
 email:
@@ -19,7 +19,9 @@ extensions: []
 extra_rdoc_files: []
 files:
 - .gitignore
+- .rspec
 - .travis.yml
+- Changelog.md
 - Gemfile
 - Guardfile
 - LICENSE
@@ -30,6 +32,7 @@ files:
 - examples/example_setup.rb
 - examples/group.rb
 - examples/individual_actor.rb
+- examples/instrumentation.rb
 - examples/percentage_of_actors.rb
 - examples/percentage_of_random.rb
 - flipper.gemspec
@@ -47,6 +50,11 @@ files:
 - lib/flipper/gates/group.rb
 - lib/flipper/gates/percentage_of_actors.rb
 - lib/flipper/gates/percentage_of_random.rb
+- lib/flipper/instrumentation/log_subscriber.rb
+- lib/flipper/instrumentation/metriks.rb
+- lib/flipper/instrumentation/metriks_subscriber.rb
+- lib/flipper/instrumenters/memory.rb
+- lib/flipper/instrumenters/noop.rb
 - lib/flipper/key.rb
 - lib/flipper/middleware/local_cache.rb
 - lib/flipper/registry.rb
@@ -68,9 +76,23 @@ files:
 - spec/flipper/adapters/memory_spec.rb
 - spec/flipper/dsl_spec.rb
 - spec/flipper/feature_spec.rb
+- spec/flipper/gate_spec.rb
+- spec/flipper/gates/actor_spec.rb
+- spec/flipper/gates/boolean_spec.rb
+- spec/flipper/gates/group_spec.rb
+- spec/flipper/gates/percentage_of_actors_spec.rb
+- spec/flipper/gates/percentage_of_random_spec.rb
+- spec/flipper/instrumentation/log_subscriber_spec.rb
+- spec/flipper/instrumentation/metriks_subscriber_spec.rb
+- spec/flipper/instrumenters/memory_spec.rb
+- spec/flipper/instrumenters/noop_spec.rb
 - spec/flipper/key_spec.rb
 - spec/flipper/middleware/local_cache_spec.rb
 - spec/flipper/registry_spec.rb
+- spec/flipper/toggle_spec.rb
+- spec/flipper/toggles/boolean_spec.rb
+- spec/flipper/toggles/set_spec.rb
+- spec/flipper/toggles/value_spec.rb
 - spec/flipper/types/actor_spec.rb
 - spec/flipper/types/boolean_spec.rb
 - spec/flipper/types/group_spec.rb
@@ -94,7 +116,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 505989874497348978
+      hash: 890771361704353632
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -103,7 +125,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 505989874497348978
+      hash: 890771361704353632
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.23
@@ -116,9 +138,23 @@ test_files:
 - spec/flipper/adapters/memory_spec.rb
 - spec/flipper/dsl_spec.rb
 - spec/flipper/feature_spec.rb
+- spec/flipper/gate_spec.rb
+- spec/flipper/gates/actor_spec.rb
+- spec/flipper/gates/boolean_spec.rb
+- spec/flipper/gates/group_spec.rb
+- spec/flipper/gates/percentage_of_actors_spec.rb
+- spec/flipper/gates/percentage_of_random_spec.rb
+- spec/flipper/instrumentation/log_subscriber_spec.rb
+- spec/flipper/instrumentation/metriks_subscriber_spec.rb
+- spec/flipper/instrumenters/memory_spec.rb
+- spec/flipper/instrumenters/noop_spec.rb
 - spec/flipper/key_spec.rb
 - spec/flipper/middleware/local_cache_spec.rb
 - spec/flipper/registry_spec.rb
+- spec/flipper/toggle_spec.rb
+- spec/flipper/toggles/boolean_spec.rb
+- spec/flipper/toggles/set_spec.rb
+- spec/flipper/toggles/value_spec.rb
 - spec/flipper/types/actor_spec.rb
 - spec/flipper/types/boolean_spec.rb
 - spec/flipper/types/group_spec.rb