flipper 0.3.0 → 0.4.0

data/spec/flipper/instrumenters/memory_spec.rb

@@ -0,0 +1,26 @@
+require 'helper'
+require 'flipper/instrumenters/memory'
+
+describe Flipper::Instrumenters::Memory do
+  describe "#initialize" do
+    it "sets events to empty array" do
+      instrumenter = described_class.new
+      instrumenter.events.should eq([])
+    end
+  end
+
+  describe "#instrument" do
+    it "adds to events" do
+      instrumenter = described_class.new
+      name         = 'user.signup'
+      payload      = {:email => 'john@doe.com'}
+      block_result = :yielded
+
+      result = instrumenter.instrument(name, payload) { block_result }
+      result.should eq(block_result)
+
+      event = described_class::Event.new(name, payload, block_result)
+      instrumenter.events.should eq([event])
+    end
+  end
+end

data/spec/flipper/instrumenters/noop_spec.rb

@@ -0,0 +1,22 @@
+require 'helper'
+require 'flipper/instrumenters/noop'
+
+describe Flipper::Instrumenters::Noop do
+  describe ".instrument" do
+    context "with name" do
+      it "yields block" do
+        yielded = false
+        described_class.instrument(:foo) { yielded = true }
+        yielded.should be_true
+      end
+    end
+
+    context "with name and payload" do
+      it "yields block" do
+        yielded = false
+        described_class.instrument(:foo, {:pay => :load}) { yielded = true }
+        yielded.should be_true
+      end
+    end
+  end
+end

data/spec/flipper/key_spec.rb

@@ -4,14 +4,20 @@ require 'flipper/key'
 describe Flipper::Key do
   subject { described_class.new(:foo, :bar) }
 
-  it "initializes with prefix and suffix" do
+  it "initializes with feature_name and gate_key" do
     key = described_class.new(:foo, :bar)
     key.should be_instance_of(described_class)
   end
 
   describe "#to_s" do
-    it "returns prefix and suffix joined by separator" do
+    it "returns feature_name and gate_key joined by separator" do
       subject.to_s.should eq("foo#{subject.separator}bar")
     end
   end
+
+  describe "#inspect" do
+    it "returns easy to read string representation" do
+      subject.inspect.should eq("#<Flipper::Key:#{subject.object_id} feature_name=:foo, gate_key=:bar>")
+    end
+  end
 end

data/spec/flipper/registry_spec.rb

@@ -13,11 +13,17 @@ describe Flipper::Registry do
       source[:admins].should eq(value)
     end
 
+    it "converts key to symbol" do
+      value = 'thing'
+      subject.add('admins', value)
+      source[:admins].should eq(value)
+    end
+
     it "raises exception if key already registered" do
       subject.add(:admins, 'thing')
 
       expect {
-        subject.add(:admins, 'again')
+        subject.add('admins', 'again')
       }.to raise_error(Flipper::Registry::DuplicateKey)
     end
   end
@@ -31,11 +37,17 @@ describe Flipper::Registry do
       it "returns value" do
         subject.get(:admins).should eq('thing')
       end
+
+      it "returns value if given string key" do
+        subject.get('admins').should eq('thing')
+      end
     end
 
     context "key not registered" do
       it "raises key not found" do
-        subject.get(:admins).should be_nil
+        expect {
+          subject.get(:admins)
+        }.to raise_error(Flipper::Registry::KeyNotFound)
       end
     end
   end
@@ -67,6 +79,12 @@ describe Flipper::Registry do
     it "returns the keys" do
       subject.keys.map(&:to_s).sort.should eq(['admins', 'devs'])
     end
+
+    it "returns the keys as symbols" do
+      subject.keys.each do |key|
+        key.should be_instance_of(Symbol)
+      end
+    end
   end
 
   describe "#values" do

data/spec/flipper/toggle_spec.rb

@@ -0,0 +1,22 @@
+require 'helper'
+
+describe Flipper::Toggle do
+  let(:key) { double('Key') }
+  let(:adapter) { double('Adapter', :read => '22') }
+  let(:gate) { double('Gate', :adapter => adapter, :key => key) }
+
+  subject {
+    toggle = Flipper::Toggle.new(gate)
+    toggle.stub(:value => '22') # implemented in subclass
+    toggle
+  }
+
+  describe "#inspect" do
+    it "returns easy to read string representation" do
+      string = subject.inspect
+      string.should match(/Flipper::Toggle/)
+      string.should match(/gate=/)
+      string.should match(/value=22/)
+    end
+  end
+end

data/spec/flipper/toggles/boolean_spec.rb

@@ -0,0 +1,40 @@
+require 'helper'
+
+describe Flipper::Toggles::Boolean do
+  let(:key) { double('Key') }
+  let(:adapter) { double('Adapter', :read => true) }
+  let(:gate) { double('Gate', :adapter => adapter, :key => key, :adapter_key => 'foo') }
+
+  subject {
+    described_class.new(gate)
+  }
+
+  describe "#value" do
+    described_class::TruthMap.each do |value, expected|
+      context "when adapter value set to #{value.inspect}" do
+        it "returns #{expected.inspect}" do
+          adapter.stub(:read => value)
+          subject.value.should be(expected)
+        end
+      end
+    end
+
+    context "for value not in truth map" do
+      it "returns false" do
+        adapter.stub(:read => 'jibberish')
+        subject.value.should be(false)
+      end
+    end
+  end
+
+  describe "#enabled?" do
+    described_class::TruthMap.each do |value, expected|
+      context "when adapter value set to #{value.inspect}" do
+        it "returns #{expected.inspect}" do
+          adapter.stub(:read => value)
+          subject.enabled?.should be(expected)
+        end
+      end
+    end
+  end
+end

data/spec/flipper/toggles/set_spec.rb

@@ -0,0 +1,35 @@
+require 'helper'
+
+describe Flipper::Toggles::Set do
+  let(:key) { double('Key') }
+  let(:adapter) { double('Adapter', :read => '22') }
+  let(:gate) { double('Gate', :adapter => adapter, :key => key) }
+
+  subject {
+    toggle = described_class.new(gate)
+    toggle.stub(:value => Set['bacon']) # implemented in subclass
+    toggle
+  }
+
+  describe "#enabled?" do
+    context "for empty set" do
+      before do
+        subject.stub(:value => Set.new)
+      end
+
+      it "returns false" do
+        subject.enabled?.should be_false
+      end
+    end
+
+    context "for non-empty set" do
+      before do
+        subject.stub(:value => Set['bacon'])
+      end
+
+      it "returns true" do
+        subject.enabled?.should be_true
+      end
+    end
+  end
+end

data/spec/flipper/toggles/value_spec.rb

@@ -0,0 +1,55 @@
+require 'helper'
+
+describe Flipper::Toggles::Value do
+  let(:key) { double('Key') }
+  let(:adapter) { double('Adapter', :read => '22') }
+  let(:gate) { double('Gate', :adapter => adapter, :key => key) }
+
+  subject {
+    toggle = described_class.new(gate)
+    toggle.stub(:value => 22)
+    toggle
+  }
+
+  describe "#enabled?" do
+    context "for nil value" do
+      before do
+        subject.stub(:value => nil)
+      end
+
+      it "returns false" do
+        subject.enabled?.should be_false
+      end
+    end
+
+    context "for integer" do
+      before do
+        subject.stub(:value => 22)
+      end
+
+      it "returns true" do
+        subject.enabled?.should be_true
+      end
+    end
+
+    context "for string integer" do
+      before do
+        subject.stub(:value => '22')
+      end
+
+      it "returns true" do
+        subject.enabled?.should be_true
+      end
+    end
+
+    context "for zero" do
+      before do
+        subject.stub(:value => 0)
+      end
+
+      it "returns false" do
+        subject.enabled?.should be_false
+      end
+    end
+  end
+end

data/spec/flipper/types/actor_spec.rb

@@ -3,15 +3,16 @@ require 'flipper/types/actor'
 
 describe Flipper::Types::Actor do
   subject {
-    described_class.new(2)
+    thing = thing_class.new('2')
+    described_class.new(thing)
   }
 
   let(:thing_class) {
     Class.new {
-      attr_reader :identifier
+      attr_reader :flipper_id
 
-      def initialize(identifier)
-        @identifier = identifier
+      def initialize(flipper_id)
+        @flipper_id = flipper_id
       end
 
       def admin?
@@ -22,22 +23,15 @@ describe Flipper::Types::Actor do
 
   describe ".wrappable?" do
     it "returns true if actor" do
-      thing = described_class.new(1)
-      described_class.wrappable?(thing).should be_true
+      thing = thing_class.new('1')
+      actor = described_class.new(thing)
+      described_class.wrappable?(actor).should be_true
     end
 
-    it "returns true if responds to identifier" do
-      thing = Struct.new(:identifier).new(10)
+    it "returns true if responds to id" do
+      thing = thing_class.new(10)
       described_class.wrappable?(thing).should be_true
     end
-
-    it "returns true if responds to to_i" do
-      described_class.wrappable?(1).should be_true
-    end
-
-    it "returns false if not actor and does not respond to identifier or to_i" do
-      described_class.wrappable?(Object.new).should be_false
-    end
   end
 
   describe ".wrap" do
@@ -51,21 +45,17 @@ describe Flipper::Types::Actor do
 
     context "for other thing" do
       it "returns actor" do
-        actor = described_class.wrap(1)
+        thing = thing_class.new('1')
+        actor = described_class.wrap(thing)
         actor.should be_instance_of(described_class)
       end
     end
   end
 
-  it "initializes with identifier" do
-    actor = described_class.new(2)
-    actor.should be_instance_of(described_class)
-  end
-
-  it "initializes with object that responds to identifier" do
-    thing = Struct.new(:identifier).new(1)
+  it "initializes with thing that responds to id" do
+    thing = thing_class.new('1')
     actor = described_class.new(thing)
-    actor.identifier.should be(1)
+    actor.value.should eq('1')
   end
 
   it "raises error when initialized with nil" do
@@ -74,14 +64,17 @@ describe Flipper::Types::Actor do
     }.to raise_error(ArgumentError)
   end
 
-  it "converts identifier to integer" do
-    actor = described_class.new('2')
-    actor.identifier.should eq(2)
+  it "raises error when initalized with non-wrappable object" do
+    unwrappable_thing = Struct.new(:id).new(1)
+    expect {
+      described_class.new(unwrappable_thing)
+    }.to raise_error(ArgumentError, "#{unwrappable_thing.inspect} must respond to flipper_id, but does not")
   end
 
-  it "has identifier" do
-    actor = described_class.new(2)
-    actor.identifier.should eq(2)
+  it "converts id to string" do
+    thing = thing_class.new(2)
+    actor = described_class.new(thing)
+    actor.value.should eq('2')
   end
 
   it "proxies everything to thing" do
@@ -92,7 +85,8 @@ describe Flipper::Types::Actor do
 
   describe "#respond_to?" do
     it "returns true if responds to method" do
-      actor = described_class.new(10)
+      thing = thing_class.new('1')
+      actor = described_class.new(thing)
       actor.respond_to?(:value).should be_true
     end
 
@@ -103,7 +97,8 @@ describe Flipper::Types::Actor do
     end
 
     it "returns false if does not respond to method and thing does not respond to method" do
-      actor = described_class.new(10)
+      thing = thing_class.new(10)
+      actor = described_class.new(thing)
       actor.respond_to?(:frankenstein).should be_false
     end
   end

data/spec/flipper_spec.rb

@@ -30,12 +30,19 @@ describe Flipper do
       registry.get(:admins).should eq(group)
     end
 
+    it "adds a group to the group_registry for string name" do
+      registry = Flipper::Registry.new
+      Flipper.groups = registry
+      group = Flipper.register('admins') { |actor| actor.admin? }
+      registry.get(:admins).should eq(group)
+    end
+
     it "raises exception if group already registered" do
       Flipper.register(:admins) { }
 
       expect {
         Flipper.register(:admins) { }
-      }.to raise_error(Flipper::DuplicateGroup)
+      }.to raise_error(Flipper::DuplicateGroup, "Group :admins has already been registered")
     end
   end
 
@@ -48,11 +55,17 @@ describe Flipper do
       it "returns group" do
         Flipper.group(:admins).should eq(@group)
       end
+
+      it "returns group with string key" do
+        Flipper.group('admins').should eq(@group)
+      end
     end
 
     context "for unregistered group" do
-      it "returns nil" do
-        Flipper.group(:cats).should be_nil
+      it "raises group not registered error" do
+        expect {
+          Flipper.group(:cats)
+        }.to raise_error(Flipper::GroupNotRegistered, 'Group :cats has not been registered')
       end
     end
   end

data/spec/helper.rb

@@ -11,13 +11,13 @@ log_path.mkpath
 require 'rubygems'
 require 'bundler'
 
-Bundler.require(:default, :test)
+Bundler.setup(:default)
 
 require 'flipper'
 
-Logger.new(log_path.join('test.log'))
-
 RSpec.configure do |config|
+  config.fail_fast = true
+
   config.filter_run :focused => true
   config.alias_example_to :fit, :focused => true
   config.alias_example_to :xit, :pending => true
@@ -43,4 +43,38 @@ shared_examples_for 'a percentage' do
     percentage = described_class.new(19)
     percentage.value.should eq(19)
   end
+
+  it "raises exception for value higher than 100" do
+    expect {
+      described_class.new(101)
+    }.to raise_error(ArgumentError, "value must be a positive number less than or equal to 100, but was 101")
+  end
+
+  it "raises exception for negative value" do
+    expect {
+      described_class.new(-1)
+    }.to raise_error(ArgumentError, "value must be a positive number less than or equal to 100, but was -1")
+  end
+end
+
+shared_examples_for 'a DSL feature' do
+  it "returns instance of feature" do
+    feature.should be_instance_of(Flipper::Feature)
+  end
+
+  it "sets name" do
+    feature.name.should eq(:stats)
+  end
+
+  it "sets adapter" do
+    feature.adapter.should eq(dsl.adapter)
+  end
+
+  it "sets instrumenter" do
+    feature.instrumenter.should eq(dsl.instrumenter)
+  end
+
+  it "memoizes the feature" do
+    dsl.feature(:stats).should equal(feature)
+  end
 end