flapjack 1.6.0 → 2.0.0b1

data/spec/lib/flapjack/gateways/jsonapi/methods/contact_links_spec.rb

@@ -0,0 +1,217 @@
+require 'spec_helper'
+require 'flapjack/gateways/jsonapi'
+
+describe 'Flapjack::Gateways::JSONAPI::Methods::ContactLinks', :sinatra => true, :logger => true, :pact_fixture => true do
+
+  include_context "jsonapi"
+
+  let(:contact)  { double(Flapjack::Data::Contact, :id => contact_data[:id]) }
+  let(:medium)   { double(Flapjack::Data::Medium, :id => email_data[:id]) }
+  let(:rule)     { double(Flapjack::Data::Rule, :id => rule_data[:id]) }
+  let(:tag)      { double(Flapjack::Data::Tag, :id => tag_data[:id]) }
+
+  let(:contact_media)  { double('contact_media') }
+  let(:contact_rules)  { double('contact_rules') }
+  let(:contact_tags)  { double('contact_tags') }
+
+  let(:meta) {
+    {
+      :pagination => {
+        :page        => 1,
+        :per_page    => 20,
+        :total_pages => 1,
+        :total_count => 1
+      }
+    }
+  }
+
+  it 'lists media for a contact' do
+    expect(Flapjack::Data::Contact).to receive(:lock).
+      with(Flapjack::Data::Medium).and_yield
+
+    sorted = double('sorted')
+    paged  = double('paged')
+    expect(paged).to receive(:ids).and_return([medium.id])
+    expect(sorted).to receive(:page).with(1, :per_page => 20).and_return(paged)
+    expect(sorted).to receive(:count).and_return(1)
+    expect(contact_media).to receive(:sort).with(:id => :asc).and_return(sorted)
+    expect(contact).to receive(:media).and_return(contact_media)
+
+    contacts = double('contacts', :all => [contact])
+    expect(contacts).to receive(:empty?).and_return(false)
+    expect(Flapjack::Data::Contact).to receive(:intersect).
+      with(:id => contact.id).and_return(contacts)
+
+    get "/contacts/#{contact.id}/media"
+    expect(last_response.status).to eq(200)
+    expect(last_response.body).to be_json_eql(Flapjack.dump_json(
+      :data  => [{:type => 'medium', :id => medium.id}],
+      :links => {
+        :self    => "http://example.org/contacts/#{contact.id}/relationships/media",
+        :related => "http://example.org/contacts/#{contact.id}/media",
+      },
+      :meta => meta
+    ))
+  end
+
+  it 'lists rules for a contact' do
+    expect(Flapjack::Data::Contact).to receive(:lock).
+      with(Flapjack::Data::Rule).and_yield
+
+    sorted = double('sorted')
+    paged  = double('paged')
+    expect(paged).to receive(:ids).and_return([rule.id])
+    expect(sorted).to receive(:page).with(1, :per_page => 20).and_return(paged)
+    expect(sorted).to receive(:count).and_return(1)
+    expect(contact_rules).to receive(:sort).with(:id => :asc).and_return(sorted)
+    expect(contact).to receive(:rules).and_return(contact_rules)
+
+    contacts = double('contacts', :all => [contact])
+    expect(contacts).to receive(:empty?).and_return(false)
+    expect(Flapjack::Data::Contact).to receive(:intersect).
+      with(:id => contact.id).and_return(contacts)
+
+    get "/contacts/#{contact.id}/rules"
+    expect(last_response.status).to eq(200)
+    expect(last_response.body).to be_json_eql(Flapjack.dump_json(
+      :data  => [{:type => 'rule', :id => rule.id}],
+      :links => {
+        :self    => "http://example.org/contacts/#{contact.id}/relationships/rules",
+        :related => "http://example.org/contacts/#{contact.id}/rules",
+      },
+      :meta => meta
+    ))
+  end
+
+  it 'adds tags to a contact' do
+    expect(Flapjack::Data::Contact).to receive(:lock).
+      with(Flapjack::Data::Tag).
+      and_yield
+
+    expect(Flapjack::Data::Contact).to receive(:find_by_id!).with(contact.id).
+      and_return(contact)
+
+    expect(contact_tags).to receive(:add_ids).with(tag.id)
+    expect(contact).to receive(:tags).and_return(contact_tags)
+
+    post "/contacts/#{contact.id}/relationships/tags", Flapjack.dump_json(:data => [{
+      :type => 'tag', :id => tag.id
+    }]), jsonapi_env
+    expect(last_response.status).to eq(204)
+  end
+
+  it 'lists tags for a contact' do
+    expect(Flapjack::Data::Contact).to receive(:lock).
+      with(Flapjack::Data::Tag).
+      and_yield
+
+    sorted = double('sorted')
+    paged  = double('paged')
+    expect(paged).to receive(:ids).and_return([tag.id])
+    expect(sorted).to receive(:page).with(1, :per_page => 20).and_return(paged)
+    expect(sorted).to receive(:count).and_return(1)
+    expect(contact_tags).to receive(:sort).with(:id => :asc).and_return(sorted)
+    expect(contact).to receive(:tags).and_return(contact_tags)
+
+    contacts = double('contacts', :all => [contact])
+    expect(contacts).to receive(:empty?).and_return(false)
+    expect(Flapjack::Data::Contact).to receive(:intersect).
+      with(:id => contact.id).and_return(contacts)
+
+    get "/contacts/#{contact.id}/tags"
+    expect(last_response.status).to eq(200)
+    expect(last_response.body).to be_json_eql(Flapjack.dump_json(
+      :data  => [{:type => 'tag', :id => tag.id}],
+      :links => {
+        :self    => "http://example.org/contacts/#{contact.id}/relationships/tags",
+        :related => "http://example.org/contacts/#{contact.id}/tags",
+      },
+      :meta => meta
+    ))
+  end
+
+  it 'lists tags for a contact, including tag data' do
+    expect(Flapjack::Data::Contact).to receive(:lock).
+      with(Flapjack::Data::Tag).
+      and_yield
+
+    sorted = double('sorted')
+    paged  = double('paged')
+    expect(paged).to receive(:ids).and_return([tag.id])
+    expect(sorted).to receive(:page).with(1, :per_page => 20).and_return(paged)
+    expect(sorted).to receive(:count).and_return(1)
+    expect(contact_tags).to receive(:sort).with(:id => :asc).and_return(sorted)
+    expect(contact).to receive(:tags).and_return(contact_tags)
+
+    full_tags = double('full_tags')
+    expect(full_tags).to receive(:collect) {|&arg| [arg.call(tag)] }
+
+    expect(Flapjack::Data::Tag).to receive(:intersect).
+      with(:id => [tag.id]).and_return(full_tags)
+
+    expect(tag).to receive(:as_json).with(:only => an_instance_of(Array)).
+      and_return(tag_data.merge(:id => tag.id))
+
+    contacts = double('contacts', :all => [contact])
+    expect(contacts).to receive(:empty?).and_return(false)
+    expect(contacts).to receive(:associated_ids_for).with(:tags).
+      and_return(contact.id => [tag.id])
+    expect(contacts).to receive(:ids).and_return(Set.new([contact.id]))
+    expect(Flapjack::Data::Contact).to receive(:intersect).
+      with(:id => Set.new([contact.id])).and_return(contacts)
+    expect(Flapjack::Data::Contact).to receive(:intersect).
+      with(:id => contact.id).and_return(contacts)
+
+    get "/contacts/#{contact.id}/tags?include=tags"
+    expect(last_response.status).to eq(200)
+    expect(last_response.body).to be_json_eql(Flapjack.dump_json(
+      :data  => [{:type => 'tag', :id => tag.id}],
+      :included => [{
+        :id => tag.id,
+        :type => 'tag',
+        :attributes => tag_data.reject {|k,v| :id.eql?(k) }
+      }],
+      :links => {
+        :self    => "http://example.org/contacts/#{contact.id}/relationships/tags",
+        :related => "http://example.org/contacts/#{contact.id}/tags",
+      },
+      :meta => meta
+    ))
+  end
+
+  it 'updates tags for a contact' do
+    expect(Flapjack::Data::Contact).to receive(:lock).
+      with(Flapjack::Data::Tag).
+      and_yield
+
+    expect(Flapjack::Data::Contact).to receive(:find_by_id!).with(contact.id).
+      and_return(contact)
+
+    expect(contact_tags).to receive(:ids).and_return([])
+    expect(contact_tags).to receive(:add_ids).with(tag.id)
+    expect(contact).to receive(:tags).twice.and_return(contact_tags)
+
+    patch "/contacts/#{contact.id}/relationships/tags", Flapjack.dump_json(:data => [{
+      :type => 'tag', :id => tag.id
+    }]), jsonapi_env
+    expect(last_response.status).to eq(204)
+  end
+
+  it 'deletes a tag from a contact' do
+    expect(Flapjack::Data::Contact).to receive(:lock).
+      with(Flapjack::Data::Tag).
+      and_yield
+
+    expect(Flapjack::Data::Contact).to receive(:find_by_id!).with(contact.id).
+      and_return(contact)
+
+    expect(contact_tags).to receive(:remove_ids).with(tag.id)
+    expect(contact).to receive(:tags).and_return(contact_tags)
+
+    delete "/contacts/#{contact.id}/relationships/tags", Flapjack.dump_json(:data => [{
+      :type => 'tag', :id => tag.id
+    }]), jsonapi_env
+    expect(last_response.status).to eq(204)
+  end
+
+end

data/spec/lib/flapjack/gateways/jsonapi/methods/contacts_spec.rb

@@ -0,0 +1,425 @@
+require 'spec_helper'
+require 'flapjack/gateways/jsonapi'
+
+describe 'Flapjack::Gateways::JSONAPI::Methods::Contacts', :sinatra => true, :logger => true, :pact_fixture => true do
+
+  include_context "jsonapi"
+
+  let(:contact)   { double(Flapjack::Data::Contact, :id => contact_data[:id]) }
+  let(:contact_2) { double(Flapjack::Data::Contact, :id => contact_2_data[:id]) }
+
+  let(:medium)    { double(Flapjack::Data::Medium, :id => email_data[:id]) }
+
+  it "creates a contact" do
+    expect(Flapjack::Data::Contact).to receive(:lock).
+      with(no_args).
+      and_yield
+
+    empty_ids = double('empty_ids')
+    expect(empty_ids).to receive(:ids).and_return([])
+    expect(Flapjack::Data::Contact).to receive(:intersect).
+      with(:id => [contact_data[:id]]).and_return(empty_ids)
+
+    expect(contact).to receive(:invalid?).and_return(false)
+    expect(contact).to receive(:save!).and_return(true)
+    expect(Flapjack::Data::Contact).to receive(:new).with(contact_data).
+      and_return(contact)
+
+    expect(contact).to receive(:as_json).with(:only => an_instance_of(Array)).
+      and_return(contact_data.reject {|k,v| :id.eql?(k)})
+
+    req_data  = contact_json(contact_data)
+    resp_data = req_data.merge(:relationships => contact_rel(contact_data))
+
+    post "/contacts", Flapjack.dump_json(:data => req_data), jsonapi_env
+    expect(last_response.status).to eq(201)
+    expect(last_response.body).to be_json_eql(Flapjack.dump_json(:data =>
+      resp_data))
+  end
+
+  it "does not create a contact if the data is improperly formatted" do
+    expect(Flapjack::Data::Contact).to receive(:lock).
+      with(no_args).
+      and_yield
+
+    empty_ids = double('empty_ids')
+    expect(empty_ids).to receive(:ids).and_return([])
+    expect(Flapjack::Data::Contact).to receive(:intersect).
+      with(:id => [contact_data[:id]]).and_return(empty_ids)
+
+    errors = double('errors', :full_messages => ['err'])
+    expect(contact).to receive(:errors).and_return(errors)
+
+    expect(contact).to receive(:invalid?).and_return(true)
+    expect(contact).not_to receive(:save!)
+    expect(Flapjack::Data::Contact).to receive(:new).with(contact_data).
+      and_return(contact)
+
+    req_data  = contact_json(contact_data)
+
+    post "/contacts", Flapjack.dump_json(:data => req_data), jsonapi_env
+    expect(last_response.status).to eq(403)
+  end
+
+  it "returns paginated contacts" do
+    expect(Flapjack::Data::Contact).to receive(:lock).
+      with(no_args).
+      and_yield
+
+    meta = {:pagination => {
+      :page        => 1,
+      :per_page    => 20,
+      :total_pages => 1,
+      :total_count => 1
+    }}
+
+    links = {
+      :self  => 'http://example.org/contacts',
+      :first => 'http://example.org/contacts?page=1',
+      :last  => 'http://example.org/contacts?page=1'
+    }
+
+    page = double('page')
+    expect(page).to receive(:empty?).and_return(false)
+    expect(page).to receive(:ids).and_return([contact.id])
+    expect(page).to receive(:collect) {|&arg| [arg.call(contact)] }
+    sorted = double('sorted')
+    expect(sorted).to receive(:page).with(1, :per_page => 20).
+      and_return(page)
+    expect(sorted).to receive(:count).and_return(1)
+    expect(Flapjack::Data::Contact).to receive(:sort).with(:id).
+      and_return(sorted)
+
+    expect(contact).to receive(:as_json).with(:only => an_instance_of(Array)).
+      and_return(contact_data.reject {|k,v| :id.eql?(k)})
+
+    resp_data = [contact_json(contact_data).merge(:relationships => contact_rel(contact_data))]
+
+    get '/contacts'
+    expect(last_response).to be_ok
+    expect(last_response.body).to be_json_eql(Flapjack.dump_json(:data =>
+      resp_data, :links => links, :meta => meta))
+  end
+
+  it "retrieves paginated contacts matching a filter" do
+    expect(Flapjack::Data::Contact).to receive(:lock).
+      with(no_args).
+      and_yield
+
+    meta = {
+      :pagination => {
+        :page        => 1,
+        :per_page    => 20,
+        :total_pages => 1,
+        :total_count => 1
+      }
+    }
+
+    links = {
+      :self  => 'http://example.org/contacts?filter%5B%5D=name%3AJim+Smith',
+      :first => 'http://example.org/contacts?filter%5B%5D=name%3AJim+Smith&page=1',
+      :last  => 'http://example.org/contacts?filter%5B%5D=name%3AJim+Smith&page=1'
+    }
+
+    filtered = double('filtered')
+    expect(Flapjack::Data::Contact).to receive(:intersect).with(:name => 'Jim Smith').
+      and_return(filtered)
+
+    page = double('page')
+    expect(page).to receive(:empty?).and_return(false)
+    expect(page).to receive(:ids).and_return([contact.id])
+    expect(page).to receive(:collect) {|&arg| [arg.call(contact)] }
+    sorted = double('sorted')
+    expect(sorted).to receive(:page).with(1, :per_page => 20).and_return(page)
+    expect(sorted).to receive(:count).and_return(1)
+    expect(filtered).to receive(:sort).with(:id).and_return(sorted)
+
+    expect(contact).to receive(:as_json).with(:only => an_instance_of(Array)).
+      and_return(contact_data.reject {|k,v| :id.eql?(k)})
+
+    resp_data = [contact_json(contact_data).merge(:relationships => contact_rel(contact_data))]
+
+    get '/contacts?filter=name%3AJim+Smith'
+    expect(last_response).to be_ok
+    expect(last_response.body).to be_json_eql(Flapjack.dump_json(:data =>
+      resp_data, :links => links, :meta => meta))
+  end
+
+  it "retrieves paginated contacts matching two filter values" do
+    expect(Flapjack::Data::Contact).to receive(:lock).
+      with(no_args).
+      and_yield
+
+    meta = {
+      :pagination => {
+        :page        => 1,
+        :per_page    => 20,
+        :total_pages => 1,
+        :total_count => 1
+      }
+    }
+
+    links = {
+      :self  => 'http://example.org/contacts?filter%5B%5D=name%3AJim+Smith&filter%5B%5D=timezone%3A%2FUTC%2F',
+      :first => 'http://example.org/contacts?filter%5B%5D=name%3AJim+Smith&filter%5B%5D=timezone%3A%2FUTC%2F&page=1',
+      :last  => 'http://example.org/contacts?filter%5B%5D=name%3AJim+Smith&filter%5B%5D=timezone%3A%2FUTC%2F&page=1'
+    }
+
+    filtered = double('filtered')
+    expect(Flapjack::Data::Contact).to receive(:intersect).with(:name => 'Jim Smith', :timezone => Regexp.new(/UTC/)).
+      and_return(filtered)
+
+    page = double('page')
+    expect(page).to receive(:empty?).and_return(false)
+    expect(page).to receive(:ids).and_return([contact.id])
+    expect(page).to receive(:collect) {|&arg| [arg.call(contact)] }
+    sorted = double('sorted')
+    expect(sorted).to receive(:page).with(1, :per_page => 20).and_return(page)
+    expect(sorted).to receive(:count).and_return(1)
+    expect(filtered).to receive(:sort).with(:id).and_return(sorted)
+
+    expect(contact).to receive(:as_json).with(:only => an_instance_of(Array)).
+      and_return(contact_data.reject {|k,v| :id.eql?(k)})
+
+    resp_data = [contact_json(contact_data).merge(:relationships => contact_rel(contact_data))]
+
+    get '/contacts?filter%5B%5D=name%3AJim+Smith&filter%5B%5D=timezone%3A%2FUTC%2F'
+    expect(last_response).to be_ok
+    expect(last_response.body).to be_json_eql(Flapjack.dump_json(:data =>
+      resp_data, :links => links, :meta => meta))
+  end
+
+  it "returns the second page of a multi-page contact list" do
+    expect(Flapjack::Data::Contact).to receive(:lock).
+      with(no_args).
+      and_yield
+
+    meta = {:pagination => {
+      :page        => 2,
+      :per_page    => 3,
+      :total_pages => 3,
+      :total_count => 8
+    }}
+
+    links = {
+      :self  => 'http://example.org/contacts?page=2&per_page=3',
+      :first => 'http://example.org/contacts?page=1&per_page=3',
+      :last  => 'http://example.org/contacts?page=3&per_page=3',
+      :next  => 'http://example.org/contacts?page=3&per_page=3',
+      :prev  => 'http://example.org/contacts?page=1&per_page=3'
+    }
+
+    contact_3_data = {:id => SecureRandom.uuid, :name => 'Bill Brown'}
+    contact_3 = double(Flapjack::Data::Contact, :id => contact_3_data[:id])
+
+    page = double('page')
+    expect(page).to receive(:empty?).and_return(false)
+    expect(page).to receive(:ids).and_return([contact.id, contact_2.id, contact_3.id])
+    expect(page).to receive(:collect) {|&arg| [
+      arg.call(contact), arg.call(contact_2), arg.call(contact_3)
+    ] }
+    sorted = double('sorted')
+    expect(sorted).to receive(:page).with(2, :per_page => 3).
+      and_return(page)
+    expect(sorted).to receive(:count).and_return(8)
+    expect(Flapjack::Data::Contact).to receive(:sort).with(:id).
+      and_return(sorted)
+
+    expect(contact).to receive(:as_json).with(:only => an_instance_of(Array)).
+      and_return(contact_data.reject {|k,v| :id.eql?(k)})
+    expect(contact_2).to receive(:as_json).with(:only => an_instance_of(Array)).
+      and_return(contact_2_data.reject {|k,v| :id.eql?(k)})
+    expect(contact_3).to receive(:as_json).with(:only => an_instance_of(Array)).
+      and_return(contact_3_data.reject {|k,v| :id.eql?(k)})
+
+    resp_data = [
+      contact_json(contact_data).merge(:relationships => contact_rel(contact_data)),
+      contact_json(contact_2_data).merge(:relationships => contact_rel(contact_2_data)),
+      contact_json(contact_3_data).merge(:relationships => contact_rel(contact_3_data)),
+    ]
+
+    get '/contacts?page=2&per_page=3'
+    expect(last_response).to be_ok
+
+    expect(last_response.body).to be_json_eql(Flapjack.dump_json(:data => resp_data,
+      :links => links, :meta => meta))
+  end
+
+  it "returns paginated sorted contacts" do
+    expect(Flapjack::Data::Contact).to receive(:lock).
+      with(no_args).
+      and_yield
+
+    meta = {:pagination => {
+      :page        => 1,
+      :per_page    => 20,
+      :total_pages => 1,
+      :total_count => 2
+    }}
+
+    links = {
+      :self  => 'http://example.org/contacts?sort=-name',
+      :first => 'http://example.org/contacts?page=1&sort=-name',
+      :last  => 'http://example.org/contacts?page=1&sort=-name'
+    }
+
+    page = double('page')
+    expect(page).to receive(:empty?).and_return(false)
+    expect(page).to receive(:ids).and_return([contact.id, contact_2.id])
+    expect(page).to receive(:collect) {|&arg| [
+      arg.call(contact_2), arg.call(contact)
+    ] }
+    sorted = double('sorted')
+    expect(sorted).to receive(:page).with(1, :per_page => 20).
+      and_return(page)
+    expect(sorted).to receive(:count).and_return(2)
+    expect(Flapjack::Data::Contact).to receive(:sort).with(:name => :desc).
+      and_return(sorted)
+
+    expect(contact_2).to receive(:as_json).with(:only => an_instance_of(Array)).
+      and_return(contact_2_data.reject {|k,v| :id.eql?(k)})
+    expect(contact).to receive(:as_json).with(:only => an_instance_of(Array)).
+      and_return(contact_data.reject {|k,v| :id.eql?(k)})
+
+    resp_data = [
+      contact_json(contact_2_data).merge(:relationships => contact_rel(contact_2_data)),
+      contact_json(contact_data).merge(:relationships => contact_rel(contact_data)),
+    ]
+
+    get '/contacts?sort=-name'
+    expect(last_response).to be_ok
+
+    expect(last_response.body).to be_json_eql(Flapjack.dump_json(:data => resp_data,
+      :links => links, :meta => meta))
+  end
+
+  it "does not return contacts if sort parameter is incorrectly specified" do
+    expect(Flapjack::Data::Contact).to receive(:lock).
+      with(no_args).
+      and_yield
+
+    expect(Flapjack::Data::Contact).not_to receive(:sort)
+
+    get '/contacts?sort=enabled'
+    expect(last_response.status).to eq(403)
+    # TODO error structure
+  end
+
+  it "returns a contact" do
+    expect(Flapjack::Data::Contact).to receive(:lock).
+      with(no_args).
+      and_yield
+
+    expect(Flapjack::Data::Contact).to receive(:intersect).
+      with(:id => Set.new([contact.id])).and_return([contact])
+
+    expect(contact).to receive(:as_json).with(:only => an_instance_of(Array)).
+      and_return(contact_data.reject {|k,v| :id.eql?(k)})
+
+    resp_data = contact_json(contact_data).merge(:relationships => contact_rel(contact_data))
+
+    get "/contacts/#{contact.id}"
+    expect(last_response).to be_ok
+    expect(last_response.body).to be_json_eql(Flapjack.dump_json(:data =>
+      resp_data, :links => {
+      :self  => "http://example.org/contacts/#{contact.id}",
+    }))
+  end
+
+  it "does not return a contact that does not exist" do
+    expect(Flapjack::Data::Contact).to receive(:lock).
+      with(no_args).
+      and_yield
+
+    no_contacts = double('no_contacts')
+    expect(no_contacts).to receive(:empty?).and_return(true)
+
+    expect(Flapjack::Data::Contact).to receive(:intersect).
+      with(:id => Set.new([contact.id])).and_return(no_contacts)
+
+    get "/contacts/#{contact.id}"
+    expect(last_response.status).to eq(404)
+  end
+
+  it 'returns a contact and the transport and address of its media records' do
+    expect(Flapjack::Data::Contact).to receive(:lock).
+      with(Flapjack::Data::Medium).
+      and_yield
+
+    contact_ids = Set.new([contact.id])
+
+    contacts = double('contacts')
+    expect(contacts).to receive(:empty?).and_return(false)
+    expect(contacts).to receive(:ids).and_return(contact_ids)
+    expect(contacts).to receive(:collect) {|&arg| [arg.call(contact)] }
+    expect(contacts).to receive(:associated_ids_for).with(:media).
+      and_return(contact.id => [medium.id])
+
+    full_media = double('full_media')
+    expect(full_media).to receive(:collect) {|&arg| [arg.call(medium)] }
+
+    expect(Flapjack::Data::Medium).to receive(:intersect).
+      with(:id => Set.new([medium.id])).and_return(full_media)
+
+    expect(medium).to receive(:as_json).with(:only => [:transport, :address]).
+      and_return(:transport => email_data[:transport], :address => email_data[:address])
+
+    expect(Flapjack::Data::Contact).to receive(:intersect).
+      with(:id => contact_ids).twice.and_return(contacts)
+
+    expect(contact).to receive(:as_json).with(:only => an_instance_of(Array)).
+      and_return(contact_data.reject {|k,v| :id.eql?(k)})
+
+    get "/contacts/#{contact.id}?fields[medium]=transport,address&include=media"
+    expect(last_response).to be_ok
+
+    resp_data = contact_json(contact_data).merge(:relationships => contact_rel(contact_data))
+    resp_data[:relationships][:media][:data] = [{:type => 'medium', :id => medium.id}]
+
+    resp_included = [medium_json(email_data)]
+    resp_included.first[:attributes].delete_if {|k, v| ![:transport, :address].include?(k)}
+
+    expect(last_response.body).to be_json_eql(Flapjack.dump_json(
+      :data => resp_data,
+      :included => resp_included,
+      :links => {
+        :self  => "http://example.org/contacts/#{contact.id}?fields%5Bmedium%5D=transport%2Caddress&include=media",
+      }))
+  end
+
+  it "updates a contact" do
+    expect(Flapjack::Data::Contact).to receive(:lock).
+      with(no_args).
+      and_yield
+
+    expect(Flapjack::Data::Contact).to receive(:find_by_id!).
+      with(contact.id).and_return(contact)
+
+    expect(contact).to receive(:name=).with('Elias Ericsson')
+    expect(contact).to receive(:invalid?).and_return(false)
+    expect(contact).to receive(:save!).and_return(true)
+
+    patch "/contacts/#{contact.id}",
+      Flapjack.dump_json(:data => {:id => contact.id,
+        :type => 'contact', :attributes => {:name => 'Elias Ericsson'}}),
+      jsonapi_env
+    expect(last_response.status).to eq(204)
+  end
+
+  it "deletes a contact" do
+    expect(Flapjack::Data::Contact).to receive(:lock).
+      with(Flapjack::Data::Check,
+           Flapjack::Data::Medium,
+           Flapjack::Data::Rule,
+           Flapjack::Data::Tag).
+      and_yield
+
+    expect(contact).to receive(:destroy)
+    expect(Flapjack::Data::Contact).to receive(:find_by_id!).
+      with(contact.id).and_return(contact)
+
+    delete "/contacts/#{contact.id}"
+    expect(last_response.status).to eq(204)
+  end
+
+end