flapjack 1.6.0 → 2.0.0b1

data/spec/lib/flapjack/gateways/jsonapi/methods/check_links_spec.rb

@@ -0,0 +1,155 @@
+require 'spec_helper'
+require 'flapjack/gateways/jsonapi'
+
+describe 'Flapjack::Gateways::JSONAPI::Methods::CheckLinks', :sinatra => true, :logger => true, :pact_fixture => true do
+
+  include_context "jsonapi"
+
+  let(:check) { double(Flapjack::Data::Check, :id => check_data[:id]) }
+  let(:tag)   { double(Flapjack::Data::Tag, :id => tag_data[:id]) }
+
+  let(:check_tags)  { double('check_tags') }
+
+  let(:meta) {
+    {
+      :pagination => {
+        :page        => 1,
+        :per_page    => 20,
+        :total_pages => 1,
+        :total_count => 1
+      }
+    }
+  }
+
+  it 'adds tags to a check' do
+    expect(Flapjack::Data::Check).to receive(:lock).
+      with(Flapjack::Data::Tag).
+      and_yield
+
+    expect(Flapjack::Data::Check).to receive(:find_by_id!).with(check.id).
+      and_return(check)
+
+    expect(check_tags).to receive(:add_ids).with(tag.id)
+    expect(check).to receive(:tags).and_return(check_tags)
+
+    post "/checks/#{check.id}/relationships/tags", Flapjack.dump_json(:data => [{
+      :type => 'tag', :id => tag.id
+    }]), jsonapi_env
+    expect(last_response.status).to eq(204)
+  end
+
+  it 'lists tags for a check' do
+    expect(Flapjack::Data::Check).to receive(:lock).
+      with(Flapjack::Data::Tag).
+      and_yield
+
+    sorted = double('sorted')
+    paged  = double('paged')
+    expect(paged).to receive(:ids).and_return([tag.id])
+    expect(sorted).to receive(:page).with(1, :per_page => 20).and_return(paged)
+    expect(sorted).to receive(:count).and_return(1)
+    expect(check_tags).to receive(:sort).with(:id => :asc).and_return(sorted)
+    expect(check).to receive(:tags).and_return(check_tags)
+
+    checks = double('checks', :all => [check])
+    expect(checks).to receive(:empty?).and_return(false)
+    expect(Flapjack::Data::Check).to receive(:intersect).
+      with(:id => check.id).and_return(checks)
+
+    get "/checks/#{check.id}/tags"
+    expect(last_response.status).to eq(200)
+    expect(last_response.body).to be_json_eql(Flapjack.dump_json(
+      :data  => [{:type => 'tag', :id => tag.id}],
+      :links => {
+        :self    => "http://example.org/checks/#{check.id}/relationships/tags",
+        :related => "http://example.org/checks/#{check.id}/tags",
+      },
+      :meta => meta
+    ))
+  end
+
+  it 'lists tags for a check, including tag data' do
+    expect(Flapjack::Data::Check).to receive(:lock).
+      with(Flapjack::Data::Tag).
+      and_yield
+
+    sorted = double('sorted')
+    paged  = double('paged')
+    expect(paged).to receive(:ids).and_return([tag.id])
+    expect(sorted).to receive(:page).with(1, :per_page => 20).and_return(paged)
+    expect(sorted).to receive(:count).and_return(1)
+    expect(check_tags).to receive(:sort).with(:id => :asc).and_return(sorted)
+    expect(check).to receive(:tags).and_return(check_tags)
+
+    full_tags = double('full_tags')
+    expect(full_tags).to receive(:collect) {|&arg| [arg.call(tag)] }
+
+    expect(Flapjack::Data::Tag).to receive(:intersect).
+      with(:id => [tag.id]).and_return(full_tags)
+
+    expect(tag).to receive(:as_json).with(:only => an_instance_of(Array)).
+      and_return(tag_data.merge(:id => tag.id))
+
+    checks = double('checks', :all => [check])
+    expect(checks).to receive(:empty?).and_return(false)
+    expect(checks).to receive(:associated_ids_for).with(:tags).
+      and_return(check.id => [tag.id])
+    expect(checks).to receive(:ids).and_return(Set.new([check.id]))
+    expect(Flapjack::Data::Check).to receive(:intersect).
+      with(:id => Set.new([check.id])).and_return(checks)
+    expect(Flapjack::Data::Check).to receive(:intersect).
+      with(:id => check.id).and_return(checks)
+
+    get "/checks/#{check.id}/tags?include=tags"
+    expect(last_response.status).to eq(200)
+    expect(last_response.body).to be_json_eql(Flapjack.dump_json(
+      :data  => [{:type => 'tag', :id => tag.id}],
+      :included => [{
+        :id => tag.id,
+        :type => 'tag',
+        :attributes => tag_data.reject {|k,v| :id.eql?(k) }
+      }],
+      :links => {
+        :self    => "http://example.org/checks/#{check.id}/relationships/tags",
+        :related => "http://example.org/checks/#{check.id}/tags",
+      },
+      :meta => meta
+    ))
+  end
+
+  it 'updates tags for a check' do
+    expect(Flapjack::Data::Check).to receive(:lock).
+      with(Flapjack::Data::Tag).
+      and_yield
+
+    expect(Flapjack::Data::Check).to receive(:find_by_id!).with(check.id).
+      and_return(check)
+
+    expect(check_tags).to receive(:ids).and_return([])
+    expect(check_tags).to receive(:add_ids).with(tag.id)
+    expect(check).to receive(:tags).twice.and_return(check_tags)
+
+    patch "/checks/#{check.id}/relationships/tags", Flapjack.dump_json(:data => [{
+      :type => 'tag', :id => tag.id
+    }]), jsonapi_env
+    expect(last_response.status).to eq(204)
+  end
+
+  it 'deletes a tag from a check' do
+    expect(Flapjack::Data::Check).to receive(:lock).
+      with(Flapjack::Data::Tag).
+      and_yield
+
+    expect(Flapjack::Data::Check).to receive(:find_by_id!).with(check.id).
+      and_return(check)
+
+    expect(check_tags).to receive(:remove_ids).with(tag.id)
+    expect(check).to receive(:tags).and_return(check_tags)
+
+    delete "/checks/#{check.id}/relationships/tags", Flapjack.dump_json(:data => [{
+      :type => 'tag', :id => tag.id
+    }]), jsonapi_env
+    expect(last_response.status).to eq(204)
+  end
+
+end

data/spec/lib/flapjack/gateways/jsonapi/methods/checks_spec.rb

@@ -0,0 +1,426 @@
+require 'spec_helper'
+require 'flapjack/gateways/jsonapi'
+
+describe 'Flapjack::Gateways::JSONAPI::Methods::Checks', :sinatra => true, :logger => true, :pact_fixture => true do
+
+  include_context "jsonapi"
+
+  let(:check)   { double(Flapjack::Data::Check, :id => check_data[:id]) }
+  let(:check_2) { double(Flapjack::Data::Check, :id => check_2_data[:id]) }
+  let(:tag)     { double(Flapjack::Data::Tag, :id => tag_data[:id]) }
+
+  it "creates a check" do
+    expect(Flapjack::Data::Check).to receive(:lock).
+      with(no_args).
+      and_yield
+
+    empty_ids = double('empty_ids')
+    expect(empty_ids).to receive(:ids).and_return([])
+    expect(Flapjack::Data::Check).to receive(:intersect).
+      with(:id => [check_data[:id]]).and_return(empty_ids)
+
+    expect(check).to receive(:invalid?).and_return(false)
+    expect(check).to receive(:save!).and_return(true)
+    expect(Flapjack::Data::Check).to receive(:new).with(check_data).
+      and_return(check)
+
+    expect(check).to receive(:as_json).with(:only => an_instance_of(Array)).
+      and_return(check_data.reject {|k,v| :id.eql?(k)})
+
+    req_data  = check_json(check_data)
+    resp_data = req_data.merge(:relationships => check_rel(check_data))
+
+    post "/checks", Flapjack.dump_json(:data => req_data), jsonapi_env
+    expect(last_response.status).to eq(201)
+
+    expect(last_response.body).to be_json_eql(Flapjack.dump_json(:data =>
+      resp_data))
+  end
+
+  it 'creates two checks' do
+    expect(Flapjack::Data::Check).to receive(:lock).
+      with(no_args).
+      and_yield
+
+    empty_ids = double('empty_ids')
+    expect(empty_ids).to receive(:ids).and_return([])
+    expect(Flapjack::Data::Check).to receive(:intersect).
+      with(:id => [check_data[:id], check_2_data[:id]]).and_return(empty_ids)
+
+    expect(check).to receive(:invalid?).and_return(false)
+    expect(check).to receive(:save!).and_return(true)
+    expect(Flapjack::Data::Check).to receive(:new).with(check_data).
+      and_return(check)
+
+    expect(check_2).to receive(:invalid?).and_return(false)
+    expect(check_2).to receive(:save!).and_return(true)
+    expect(Flapjack::Data::Check).to receive(:new).with(check_2_data).
+      and_return(check_2)
+
+    expect(check).to receive(:as_json).with(:only => an_instance_of(Array)).
+      and_return(check_data.reject {|k,v| :id.eql?(k)})
+
+    expect(check_2).to receive(:as_json).with(:only => an_instance_of(Array)).
+      and_return(check_2_data.reject {|k,v| :id.eql?(k)})
+
+    req_data = [check_json(check_data), check_json(check_2_data)]
+    resp_data = [
+      req_data[0].merge(:relationships => check_rel(check_data)),
+      req_data[1].merge(:relationships => check_rel(check_2_data))
+    ]
+
+    post "/checks", Flapjack.dump_json(:data => req_data), jsonapi_bulk_env
+    expect(last_response.status).to eq(201)
+
+    expect(last_response.body).to be_json_eql(Flapjack.dump_json(:data => resp_data))
+  end
+
+  it 'creates a link to a tag along with a check' do
+    expect(Flapjack::Data::Check).to receive(:lock).
+      with(Flapjack::Data::Tag).
+      and_yield
+
+    empty_ids = double('empty_ids')
+    expect(empty_ids).to receive(:ids).and_return([])
+    expect(Flapjack::Data::Check).to receive(:intersect).
+      with(:id => [check_data[:id]]).and_return(empty_ids)
+
+    expect(check).to receive(:invalid?).and_return(false)
+    expect(check).to receive(:save!).and_return(true)
+    expect(Flapjack::Data::Check).to receive(:new).with(check_data).
+      and_return(check)
+
+    expect(Flapjack::Data::Tag).to receive(:find_by_ids!).
+      with(tag.id).and_return([tag])
+
+    tags = double('tags')
+    expect(tags).to receive(:add).with(tag)
+    expect(check).to receive(:tags).and_return(tags)
+
+    expect(check).to receive(:as_json).with(:only => an_instance_of(Array)).
+      and_return(check_data.reject {|k,v| :id.eql?(k)})
+
+    req_data  = check_json(check_data).merge(
+      :relationships => {
+        :tags => {
+          :data => [{:type => 'tag', :id => tag_data[:id]}]
+        }
+      }
+    )
+    resp_data = req_data.merge(:relationships => check_rel(check_data))
+
+    post "/checks", Flapjack.dump_json(:data => req_data), jsonapi_env
+
+    expect(last_response.status).to eq(201)
+    expect(last_response.body).to be_json_eql(Flapjack.dump_json(:data => resp_data))
+  end
+
+  it 'rejects a request to create a check with an invalid bulk MIME type' do
+    req_data  = check_json(check_data)
+
+    post "/checks", Flapjack.dump_json(:data => req_data), jsonapi_bulk_env
+    expect(last_response.status).to eq(406)
+    expect(last_response.body).to be_json_eql(Flapjack.dump_json(
+      :errors => [{:detail => 'JSONAPI Bulk Extension was set in headers', :status => "406"}]
+    ))
+  end
+
+  it 'rejects a request to create two checks with an invalid bulk MIME type' do
+    req_data = [check_json(check_data), check_json(check_2_data)]
+
+    post "/checks", Flapjack.dump_json(:data => req_data), jsonapi_env
+    expect(last_response.status).to eq(406)
+    expect(last_response.body).to be_json_eql(Flapjack.dump_json(
+      :errors => [{:detail => 'JSONAPI Bulk Extension not set in headers', :status => "406"}]
+    ))
+  end
+
+  it "retrieves paginated checks" do
+    expect(Flapjack::Data::Check).to receive(:lock).
+      with(no_args).
+      and_yield
+
+    meta = {
+      :pagination => {
+        :page        => 1,
+        :per_page    => 20,
+        :total_pages => 1,
+        :total_count => 1
+      }
+    }
+
+    links = {
+      :self  => 'http://example.org/checks',
+      :first => 'http://example.org/checks?page=1',
+      :last  => 'http://example.org/checks?page=1'
+    }
+
+    page = double('page')
+    expect(page).to receive(:empty?).and_return(false)
+    expect(page).to receive(:ids).and_return([check.id])
+    expect(page).to receive(:collect) {|&arg| [arg.call(check)] }
+    sorted = double('sorted')
+    expect(sorted).to receive(:page).with(1, :per_page => 20).
+      and_return(page)
+    expect(sorted).to receive(:count).and_return(1)
+    expect(Flapjack::Data::Check).to receive(:sort).
+      with(:id).and_return(sorted)
+
+    expect(check).to receive(:as_json).with(:only => an_instance_of(Array)).
+      and_return(check_data.reject {|k,v| :id.eql?(k)})
+
+    resp_data = [check_json(check_data).merge(:relationships => check_rel(check_data))]
+
+    get '/checks'
+    expect(last_response).to be_ok
+    expect(last_response.body).to be_json_eql(Flapjack.dump_json(:data =>
+      resp_data, :links => links, :meta => meta))
+  end
+
+  it "retrieves paginated checks matching a filter" do
+    expect(Flapjack::Data::Check).to receive(:lock).
+      with(no_args).
+      and_yield
+
+    meta = {
+      :pagination => {
+        :page        => 1,
+        :per_page    => 20,
+        :total_pages => 1,
+        :total_count => 1
+      }
+    }
+
+    links = {
+      :self  => 'http://example.org/checks?filter%5B%5D=enabled%3At',
+      :first => 'http://example.org/checks?filter%5B%5D=enabled%3At&page=1',
+      :last  => 'http://example.org/checks?filter%5B%5D=enabled%3At&page=1'
+    }
+
+    filtered = double('filtered')
+    expect(Flapjack::Data::Check).to receive(:intersect).with(:enabled => true).
+      and_return(filtered)
+
+    page = double('page')
+    expect(page).to receive(:empty?).and_return(false)
+    expect(page).to receive(:ids).and_return([check.id])
+    expect(page).to receive(:collect) {|&arg| [arg.call(check)] }
+    sorted = double('sorted')
+    expect(sorted).to receive(:page).with(1, :per_page => 20).and_return(page)
+    expect(sorted).to receive(:count).and_return(1)
+    expect(filtered).to receive(:sort).with(:id).and_return(sorted)
+
+    expect(check).to receive(:as_json).with(:only => an_instance_of(Array)).
+      and_return(check_data.reject {|k,v| :id.eql?(k)})
+
+    resp_data = [check_json(check_data).merge(:relationships => check_rel(check_data))]
+
+    get '/checks?filter=enabled%3At'
+    expect(last_response).to be_ok
+    expect(last_response.body).to be_json_eql(Flapjack.dump_json(:data =>
+      resp_data, :links => links, :meta => meta))
+  end
+
+  it "retrieves one check" do
+    expect(Flapjack::Data::Check).to receive(:lock).
+      with(no_args).
+      and_yield
+
+    expect(Flapjack::Data::Check).to receive(:intersect).
+      with(:id => Set.new([check.id])).and_return([check])
+
+    expect(check).to receive(:as_json).with(:only => an_instance_of(Array)).
+      and_return(check_data.reject {|k,v| :id.eql?(k)})
+
+    resp_data = check_json(check_data).merge(:relationships => check_rel(check_data))
+
+    get "/checks/#{check.id}"
+    expect(last_response).to be_ok
+    expect(last_response.body).to be_json_eql(Flapjack.dump_json(
+      :data => resp_data,
+      :links => {:self => "http://example.org/checks/#{check.id}"}))
+  end
+
+  it "retrieves one check with a subset of fields" do
+    expect(Flapjack::Data::Check).to receive(:lock).
+      with(no_args).
+      and_yield
+
+    expect(Flapjack::Data::Check).to receive(:intersect).
+      with(:id => Set.new([check.id])).and_return([check])
+
+    expect(check).to receive(:as_json).with(:only => [:name, :enabled]).
+      and_return(:name => check_data[:name], :enabled => check_data[:enabled])
+
+    resp_data = check_json(check_data.select {|k, v| [:name, :enabled].include?(k)}).
+                  merge(:relationships => check_rel(check_data))
+
+    get "/checks/#{check.id}?fields[check]=name%2Cenabled"
+    expect(last_response).to be_ok
+
+    expect(last_response.body).to be_json_eql(Flapjack.dump_json(
+      :data => resp_data,
+      :links => {:self => "http://example.org/checks/#{check.id}?fields%5Bcheck%5D=name%2Cenabled"}))
+  end
+
+  it "retrieves one check and all its linked tag records" do
+    expect(Flapjack::Data::Check).to receive(:lock).
+      with(Flapjack::Data::Tag).
+      and_yield
+
+    checks = double('checks')
+    expect(checks).to receive(:empty?).and_return(false)
+    expect(checks).to receive(:collect) {|&arg| [arg.call(check)] }
+    expect(checks).to receive(:associated_ids_for).with(:tags).
+      and_return(check.id => [tag.id])
+    expect(checks).to receive(:ids).and_return(Set.new([check.id]))
+    expect(Flapjack::Data::Check).to receive(:intersect).
+      with(:id => Set.new([check.id])).twice.and_return(checks)
+
+    full_tags = double('full_tags')
+    expect(full_tags).to receive(:collect) {|&arg| [arg.call(tag)] }
+
+    expect(Flapjack::Data::Tag).to receive(:intersect).
+      with(:id => [tag.id]).and_return(full_tags)
+
+    expect(tag).to receive(:as_json).with(:only => an_instance_of(Array)).
+      and_return(tag_data)
+
+    expect(check).to receive(:as_json).with(:only => an_instance_of(Array)).
+      and_return(check_data.reject {|k,v| :id.eql?(k)})
+
+    get "/checks/#{check.id}?include=tags"
+    expect(last_response).to be_ok
+
+    resp_data = check_json(check_data).merge(:relationships => check_rel(check_data))
+    resp_data[:relationships][:tags][:data] = [{:type => 'tag', :id => tag.id}]
+
+    expect(last_response.body).to be_json_eql(Flapjack.dump_json(
+      :data => resp_data,
+      :included => [{
+        :id => tag.id,
+        :type => 'tag',
+        :attributes => tag_data.reject {|k,v| :id.eql?(k) }
+      }],
+      :links => {:self => "http://example.org/checks/#{check.id}?include=tags"}))
+  end
+
+  it 'retrieves two checks' do
+    expect(Flapjack::Data::Check).to receive(:lock).
+      with(no_args).
+      and_yield
+
+    meta = {
+      :pagination => {
+        :page        => 1,
+        :per_page    => 20,
+        :total_pages => 1,
+        :total_count => 2
+      }
+    }
+
+    links = {
+      :self  => "http://example.org/checks?filter%5B%5D=id%3A#{check.id}%7C#{check_2.id}",
+      :first => "http://example.org/checks?filter%5B%5D=id%3A#{check.id}%7C#{check_2.id}&page=1",
+      :last  => "http://example.org/checks?filter%5B%5D=id%3A#{check.id}%7C#{check_2.id}&page=1"
+    }
+
+    check_2 = double(Flapjack::Data::Check, :id => check_2_data[:id])
+
+    page = double('page')
+    expect(page).to receive(:empty?).and_return(false)
+    expect(page).to receive(:ids).and_return([check.id, check_2.id])
+    expect(page).to receive(:collect) {|&arg| [arg.call(check), arg.call(check_2)] }
+
+    sorted = double('sorted')
+    expect(sorted).to receive(:page).with(1, :per_page => 20).and_return(page)
+    expect(sorted).to receive(:count).and_return(2)
+
+    filtered = double('filtered')
+    expect(filtered).to receive(:sort).with(:id).and_return(sorted)
+    expect(Flapjack::Data::Check).to receive(:intersect).with(:id => [check.id, check_2.id]).
+      and_return(filtered)
+
+    expect(check).to receive(:as_json).with(:only => an_instance_of(Array)).
+      and_return(check_data.reject {|k,v| :id.eql?(k)})
+
+    expect(check_2).to receive(:as_json).with(:only => an_instance_of(Array)).
+      and_return(check_2_data.reject {|k,v| :id.eql?(k)})
+
+    resp_data = [
+      check_json(check_data).merge(:relationships => check_rel(check_data)),
+      check_json(check_2_data).merge(:relationships => check_rel(check_2_data))
+    ]
+
+    get "/checks?filter=id%3A#{check.id}%7C#{check_2.id}"
+    expect(last_response).to be_ok
+    expect(last_response.body).to be_json_eql(Flapjack.dump_json(
+      :data => resp_data, :links => links, :meta => meta))
+  end
+
+  it 'disables a check' do
+    expect(Flapjack::Data::Check).to receive(:lock).
+      with(no_args).
+      and_yield
+
+    expect(Flapjack::Data::Check).to receive(:find_by_id!).
+      with(check.id).and_return(check)
+
+    expect(check).to receive(:enabled=).with(false)
+    expect(check).to receive(:invalid?).and_return(false)
+    expect(check).to receive(:save!).and_return(true)
+
+    patch "/checks/#{check.id}",
+      Flapjack.dump_json(:data => {:id => check.id, :type => 'check', :attributes => {:enabled => false}}),
+      jsonapi_env
+    expect(last_response.status).to eq(204)
+  end
+
+  it 'disables two checks' do
+    expect(Flapjack::Data::Check).to receive(:lock).
+      with(no_args).
+      and_yield
+
+    expect(Flapjack::Data::Check).to receive(:find_by_ids!).
+      with(check.id, check_2.id).and_return([check, check_2])
+
+    expect(check).to receive(:enabled=).with(false)
+    expect(check).to receive(:invalid?).and_return(false)
+    expect(check).to receive(:save!).and_return(true)
+
+    expect(check_2).to receive(:enabled=).with(false)
+    expect(check_2).to receive(:invalid?).and_return(false)
+    expect(check_2).to receive(:save!).and_return(true)
+
+    patch "/checks",
+      Flapjack.dump_json(:data => [{:id => check.id, :type => 'check', :attributes => {:enabled => false}},
+                                   {:id => check_2.id, :type => 'check', :attributes => {:enabled => false}}]),
+      jsonapi_bulk_env
+    expect(last_response.status).to eq(204)
+  end
+
+  it "replaces the tags for a check" do
+    expect(Flapjack::Data::Check).to receive(:lock).
+      with(Flapjack::Data::Tag).
+      and_yield
+
+    expect(Flapjack::Data::Check).to receive(:find_by_id!).
+      with(check.id).and_return(check)
+
+    expect(check).to receive(:invalid?).and_return(false)
+    expect(check).to receive(:save!).and_return(true)
+
+    tags = double('tags', :ids => [])
+    expect(tags).to receive(:add).with(tag)
+    expect(check).to receive(:tags).twice.and_return(tags)
+
+    expect(Flapjack::Data::Tag).to receive(:find_by_ids!).with(tag.id).and_return([tag])
+
+    patch "/checks/#{check.id}",
+      Flapjack.dump_json(:data => {:id => check.id, :type => 'check', :relationships =>
+        {:tags => {:data => [{:type => 'tag', :id => tag.id}]}}}),
+      jsonapi_env
+    expect(last_response.status).to eq(204)
+  end
+
+end