fission 0.4.0 → 0.5.0.beta.1

data/spec/fission/cli_spec.rb

@@ -1,175 +1,50 @@
-require File.expand_path('../../spec_helper.rb', __FILE__)
+require 'spec_helper'
 
 describe Fission::CLI do
   before do
     @string_io = StringIO.new
-    Fission::CLI.stub!(:ui).and_return(Fission::UI.new(@string_io))
+    Fission::CLI.any_instance.stub(:ui).and_return(Fission::UI.new(@string_io))
+    @parser = mock 'parser'
+    @parser.stub :parse
+    @parser.stub :command
   end
 
-  describe 'self.commands' do
-    it 'should return the list of commands' do
-      Fission::CLI.commands.should == ['clone', 'delete', 'snapshot create',
-                                       'snapshot list', 'snapshot revert',
-                                       'start', 'status', 'stop', 'suspend']
-    end
-  end
-
-  describe 'execute' do
-    describe 'with no arguments' do
-      it 'should output the usage info' do
-        lambda { Fission::CLI.execute [] }.should raise_error SystemExit
+  describe 'initialize' do
+    it 'should create a parse object using ARGV' do
+      Fission::CommandLineParser.should_receive(:new).with(ARGV).
+                                                      and_return(@parser)
 
-        @string_io.string.should match /Usage/
-      end
+      Fission::CLI.new
     end
 
-    describe '-v or --version' do
-      ['-v', '--version'].each do |arg|
-        it "should output the version with #{arg}" do
-          lambda { Fission::CLI.execute [arg] }.should raise_error SystemExit
-
-          @string_io.string.should match /#{Fission::VERSION}/
-        end
-      end
-    end
+    it 'should create a parse object with the provided args' do
+      Fission::CommandLineParser.should_receive(:new).with(['foo']).
+                                                      and_return(@parser)
 
-    describe '-h or --help' do
-      ['-h', '--help'].each do |arg|
-        it "should output the usage info with #{arg}" do
-          lambda { Fission::CLI.execute [arg] }.should raise_error SystemExit
+      Fission::CLI.new ['foo']
 
-          @string_io.string.should match /Usage/
-        end
-      end
     end
 
-    describe 'with the sub command' do
-      before do
-        @cmd_mock = mock('cmd')
-        @cmd_mock.should_receive(:execute)
-      end
-
-      describe 'clone' do
-        it "should try to clone the vm" do
-          Fission::Command::Clone.stub!(:help).and_return('')
-          Fission::Command::Clone.should_receive(:new).with(['foo', 'bar']).
-                                                       and_return(@cmd_mock)
-          Fission::CLI.execute ['clone', 'foo', 'bar']
-        end
-
-        it 'should try to clone the vm and start it' do
-          Fission::Command::Clone.stub!(:help).and_return('')
-          Fission::Command::Clone.should_receive(:new).with(['foo', 'bar', '--start']).
-                                                       and_return(@cmd_mock)
-          Fission::CLI.execute ['clone', 'foo', 'bar', '--start']
-        end
-      end
-
-      describe 'snapshot create' do
-        it "should create a snapshot" do
-          Fission::Command::SnapshotCreate.stub!(:help).and_return('')
-          Fission::Command::SnapshotCreate.should_receive(:new).
-                                           with(['foo', 'snap1']).
-                                           and_return(@cmd_mock)
-          Fission::CLI.execute ['snapshot', 'create', 'foo', 'snap1']
-        end
-      end
-
-      describe 'snapshot list' do
-        it "should list the snapshots" do
-          Fission::Command::SnapshotList.stub!(:help).and_return('')
-          Fission::Command::SnapshotList.should_receive(:new).
-                                         with([]).
-                                         and_return(@cmd_mock)
-          Fission::CLI.execute ['snapshot', 'list']
-        end
-      end
-
-      describe 'snapshot revert' do
-        it "should revert to the snapshots" do
-          Fission::Command::SnapshotRevert.stub!(:help).and_return('')
-          Fission::Command::SnapshotRevert.should_receive(:new).
-                                           with(['foo', 'snap1']).
-                                           and_return(@cmd_mock)
-          Fission::CLI.execute ['snapshot', 'revert', 'foo', 'snap1']
-        end
-      end
-
-      describe 'start' do
-        it "should try to start the vm" do
-          Fission::Command::Start.stub!(:help).and_return('')
-          Fission::Command::Start.should_receive(:new).
-                                  with(['foo']).
-                                  and_return(@cmd_mock)
-          Fission::CLI.execute ['start', 'foo']
-        end
-
-        it 'should try to start the vm headless' do
-          Fission::Command::Start.stub!(:help).and_return('')
-          Fission::Command::Start.should_receive(:new).
-                                  with(['foo', '--headless']).
-                                  and_return(@cmd_mock)
-          Fission::CLI.execute ['start', 'foo', '--headless']
-
-        end
-      end
-
-      describe 'status' do
-        it "should try to get the status for all VMs" do
-          Fission::Command::Status.stub!(:help).and_return('')
-          Fission::Command::Status.should_receive(:new).
-                                   with([]).
-                                   and_return(@cmd_mock)
-          Fission::CLI.execute ['status']
-        end
-      end
-
-      describe 'stop' do
-        it "should try to stop the vm" do
-          Fission::Command::Stop.stub!(:help).and_return('')
-          Fission::Command::Stop.should_receive(:new).
-                                 with(['foo']).
-                                 and_return(@cmd_mock)
-          Fission::CLI.execute ['stop', 'foo']
-        end
-      end
-
-      describe 'suspend' do
-        it "should try to suspend the vm" do
-          Fission::Command::Suspend.stub!(:help).and_return('')
-          Fission::Command::Suspend.should_receive(:new).
-                                    with(['foo']).
-                                    and_return(@cmd_mock)
-          Fission::CLI.execute ['suspend', 'foo']
-        end
-
-        it 'should try to suspend all of vms' do
-          Fission::Command::Suspend.stub!(:help).and_return('')
-          Fission::Command::Suspend.should_receive(:new).
-                                    with(['--all']).
-                                    and_return(@cmd_mock)
-          Fission::CLI.execute ['suspend', '--all']
-        end
-      end
-
-      describe 'delete' do
-        it "should try to delete the vm" do
-          Fission::Command::Delete.stub!(:help).and_return('')
-          Fission::Command::Delete.should_receive(:new).
-                                   with(['foo']).
-                                   and_return(@cmd_mock)
-          Fission::CLI.execute ['delete', 'foo']
-        end
+    it 'should create a parse object using our parser' do
+      @parser.should_receive(:new).with(ARGV).and_return(@parser)
+      Fission::CLI.new nil, @parser
+    end
 
-        it 'should try to force delete the vm' do
-          Fission::Command::Delete.stub!(:help).and_return('')
-          Fission::Command::Delete.should_receive(:new).
-                                   with(['foo', '--force']).
-                                   and_return(@cmd_mock)
-          Fission::CLI.execute ['delete', 'foo', '--force']
-        end
-      end
+    it 'should parse the arguments using the parser' do
+      @parser.should_receive(:new).with(ARGV).and_return(@parser)
+      @parser.should_receive :parse
+      Fission::CLI.new nil, @parser
     end
+  end
 
+  describe 'execute' do
+    it 'should execute the parsed command' do
+      @cmd_mock = mock ('cmd')
+      @cmd_mock.should_receive :execute
+      @parser.stub(:new).and_return(@parser)
+      @parser.stub(:command).and_return(@cmd_mock)
+      Fission::CLI.new(nil, @parser).execute
+    end
   end
+
 end

data/spec/fission/command/clone_spec.rb

@@ -1,4 +1,4 @@
-require File.expand_path('../../../spec_helper.rb', __FILE__)
+require 'spec_helper'
 
 describe Fission::Command::Clone do
   include_context 'command_setup'
@@ -20,10 +20,16 @@ describe Fission::Command::Clone do
                              and_return(@clone_response_mock)
   end
 
+  describe 'command_name' do
+    it 'should return the pretty command name' do
+      Fission::Command::Clone.new.command_name.should == 'clone'
+    end
+  end
+
   describe 'execute' do
    subject { Fission::Command::Clone }
 
-    [ [], ['foo'] ].each do |args|
+    [ [], ['foo'], ['--bar'] ].each do |args|
       it_should_not_accept_arguments_of args, 'clone'
     end
 
@@ -80,7 +86,7 @@ describe Fission::Command::Clone do
     it 'should output info for this command' do
       output = Fission::Command::Clone.help
 
-      output.should match /clone source_vm target_vm.+--start/m
+      output.should match /fission clone SOURCE_VM TARGET_VM.+OPTIONS/m
     end
   end
 end

data/spec/fission/command/delete_spec.rb

@@ -1,4 +1,4 @@
-require File.expand_path('../../../spec_helper.rb', __FILE__)
+require 'spec_helper'
 
 describe Fission::Command::Delete do
   include_context 'command_setup'
@@ -16,10 +16,18 @@ describe Fission::Command::Delete do
     Fission::Fusion.stub(:running?).and_return(false)
   end
 
+  describe 'command_name' do
+    it 'should return the pretty command name' do
+      Fission::Command::Delete.new.command_name.should == 'delete'
+    end
+  end
+
   describe "execute" do
     subject { Fission::Command::Delete }
 
-    it_should_not_accept_arguments_of [], 'delete'
+    [ [], ['--bar'] ].each do |args|
+      it_should_not_accept_arguments_of args, 'delete'
+    end
 
     it "should try to delete the vm" do
       @delete_response_mock.stub_as_successful
@@ -115,7 +123,7 @@ describe Fission::Command::Delete do
     it 'should output info for this command' do
       output = Fission::Command::Delete.help
 
-      output.should match /delete vm_name \[--force\]/
+      output.should match /fission delete TARGET_VM \[OPTIONS\]/
       output.should match /--force/
     end
   end

data/spec/fission/command/info_spec.rb

@@ -0,0 +1,130 @@
+require 'spec_helper'
+
+describe Fission::Command::Info do
+  include_context 'command_setup'
+
+  before do
+    @target_vm = ['foo']
+    Fission::VM.stub!(:new).and_return(@vm_mock)
+
+    @network_info_response_mock = mock('network_info_response')
+    @hardware_info_response_mock = mock('hardware_info_response')
+    @guest_os_response_mock = mock('guest_os_response')
+
+    @vm_mock.stub(:name).and_return(@target_vm.first)
+  end
+
+  describe 'command_name' do
+    it 'should return the pretty command name' do
+      Fission::Command::Info.new.command_name.should == 'info'
+    end
+  end
+
+  describe 'execute' do
+    before do
+      @vm_mock.stub(:network_info).and_return(@network_info_response_mock)
+      @vm_mock.stub(:hardware_info).and_return(@hardware_info_response_mock)
+      @vm_mock.stub(:guestos).and_return(@guest_os_response_mock)
+      @network_info = { 'ethernet0' => { 'mac_address'  => '00:11:22:33:AA:BB',
+                                         'ip_address'   => '192.168.1.10' },
+                        'ethernet1' => { 'mac_address'  => '00:11:22:33:AA:BB',
+                                         'ip_address'   => '192.168.1.10' } }
+      @hardware_info_response_mock.stub_as_successful Hash.new
+      @network_info_response_mock.stub_as_successful Hash.new
+      @guest_os_response_mock.stub_as_successful 'debian5'
+    end
+
+    subject { Fission::Command::Info }
+
+    [ [], ['--bar'] ].each do |args|
+      it_should_not_accept_arguments_of args, 'info'
+    end
+
+    it 'should output the vm name' do
+      command = Fission::Command::Info.new @target_vm
+      command.execute
+
+      @string_io.string.should match /foo/
+    end
+
+    it 'should output the os' do
+      command = Fission::Command::Info.new @target_vm
+      command.execute
+
+      @string_io.string.should match /os: debian5/
+    end
+
+    it 'should output that the os is unknown if applicable' do
+      @guest_os_response_mock.stub_as_successful ''
+      command = Fission::Command::Info.new @target_vm
+      command.execute
+
+      @string_io.string.should match /os: unknown/
+    end
+
+    it 'should output an error and exit if there was an error getting the os info' do
+      @guest_os_response_mock.stub_as_unsuccessful
+
+      command = Fission::Command::Info.new @target_vm
+      lambda { command.execute }.should raise_error SystemExit
+
+      @string_io.string.should match /There was an error getting the OS info.+it blew up.+/m
+    end
+
+    it 'should output the number of cpus' do
+      hardware_info = { 'cpus' => 2}
+      @hardware_info_response_mock.stub_as_successful hardware_info
+
+      command = Fission::Command::Info.new @target_vm
+      command.execute
+
+      @string_io.string.should match /cpus\: 2/
+    end
+
+    it 'should output the amount of memory' do
+      hardware_info = { 'memory' => 2048}
+      @hardware_info_response_mock.stub_as_successful hardware_info
+
+      command = Fission::Command::Info.new @target_vm
+      command.execute
+
+      @string_io.string.should match /memory\: 2048/
+    end
+
+    it 'should output an error and exit if there was an error getting the hardware info' do
+      @hardware_info_response_mock.stub_as_unsuccessful
+
+      command = Fission::Command::Info.new @target_vm
+      lambda { command.execute }.should raise_error SystemExit
+
+      @string_io.string.should match /There was an error getting the hardware info.+it blew up.+/m
+    end
+
+    it 'should output the network info' do
+      @network_info_response_mock.stub_as_successful @network_info
+
+      command = Fission::Command::Info.new @target_vm
+      command.execute
+
+      @string_io.string.should match /ethernet0 mac address: 00:11:22:33:AA:BB/
+      @string_io.string.should match /ethernet0 ip address: 192\.168\.1\.10/
+    end
+
+    it 'should output an error and exit if there was an error getting the network info' do
+      @network_info_response_mock.stub_as_unsuccessful
+
+      command = Fission::Command::Info.new @target_vm
+      lambda { command.execute }.should raise_error SystemExit
+
+      @string_io.string.should match /There was an error getting the network info.+it blew up.+/m
+    end
+  end
+
+  describe 'help' do
+    it 'should output info for this command' do
+      output = Fission::Command::Info.help
+
+      output.should match /fission info TARGET_VM/
+    end
+  end
+end

data/spec/fission/command/snapshot_create_spec.rb

@@ -1,4 +1,4 @@
-require File.expand_path('../../../spec_helper.rb', __FILE__)
+require 'spec_helper'
 
 describe Fission::Command::SnapshotCreate do
   include_context 'command_setup'
@@ -12,10 +12,18 @@ describe Fission::Command::SnapshotCreate do
     @vm_mock.stub(:name).and_return(@target_vm.first)
   end
 
+  describe 'command_name' do
+    it 'should return the pretty command name' do
+      Fission::Command::SnapshotCreate.new.command_name.should == 'snapshot create'
+    end
+  end
+
   describe 'execute' do
     subject { Fission::Command::SnapshotCreate }
 
-    it_should_not_accept_arguments_of [], 'snapshot create'
+    [ [], ['foo'], ['--bar'] ].each do |args|
+      it_should_not_accept_arguments_of args, 'snapshot create'
+    end
 
     it "should output an error and the help when no snapshot name is passed in" do
       Fission::Command::SnapshotCreate.should_receive(:help)
@@ -60,7 +68,7 @@ describe Fission::Command::SnapshotCreate do
     it 'should output info for this command' do
       output = Fission::Command::SnapshotCreate.help
 
-      output.should match /snapshot create vm_name snapshot_1/
+      output.should match /fission snapshot create TARGET_VM SNAPSHOT_NAME/
     end
   end
 end

data/spec/fission/command/snapshot_delete_spec.rb

@@ -0,0 +1,74 @@
+require 'spec_helper'
+
+describe Fission::Command::SnapshotDelete do
+  include_context 'command_setup'
+
+  before do
+    @target_vm = ['foo']
+    Fission::VM.stub!(:new).and_return(@vm_mock)
+
+    @snap_delete_response_mock = mock('snap_delete_response')
+
+    @vm_mock.stub(:name).and_return(@target_vm.first)
+  end
+
+  describe 'command_name' do
+    it 'should return the pretty command name' do
+      Fission::Command::SnapshotDelete.new.command_name.should == 'snapshot delete'
+    end
+  end
+
+  describe 'execute' do
+    subject { Fission::Command::SnapshotDelete }
+
+    [ [], ['foo'], ['--bar'] ].each do |args|
+      it_should_not_accept_arguments_of args, 'snapshot delete'
+    end
+
+    it "should output an error and the help when no snapshot name is passed in" do
+      Fission::Command::SnapshotDelete.should_receive(:help)
+
+      command = Fission::Command::SnapshotDelete.new @target_vm
+      lambda { command.execute }.should raise_error SystemExit
+
+      @string_io.string.should match /Incorrect arguments for snapshot delete command/
+    end
+
+    it 'should delete a new snapshot with the provided name' do
+      @snap_delete_response_mock.stub_as_successful []
+
+      @vm_mock.should_receive(:delete_snapshot).
+               with('snap_1').
+               and_return(@snap_delete_response_mock)
+
+      command = Fission::Command::SnapshotDelete.new @target_vm << 'snap_1'
+      command.execute
+
+      @string_io.string.should match /Deleting snapshot/
+      @string_io.string.should match /Snapshot 'snap_1' deleted/
+    end
+
+    it 'should output an error and exit if there was an error creating the snapshot' do
+      @snap_delete_response_mock.stub_as_unsuccessful
+
+      @vm_mock.should_receive(:delete_snapshot).
+               with('snap_1').
+               and_return(@snap_delete_response_mock)
+
+      command = Fission::Command::SnapshotDelete.new @target_vm << 'snap_1'
+      lambda { command.execute }.should raise_error SystemExit
+
+      @string_io.string.should match /Deleting snapshot/
+      @string_io.string.should match /There was an error deleting the snapshot.+it blew up.+/m
+    end
+
+  end
+
+  describe 'help' do
+    it 'should output info for this command' do
+      output = Fission::Command::SnapshotDelete.help
+
+      output.should match /fission snapshot delete TARGET_VM SNAPSHOT_NAME/
+    end
+  end
+end