fission 0.4.0 → 0.5.0.beta.1

data/spec/fission/command_spec.rb

@@ -1,4 +1,4 @@
-require File.expand_path('../../spec_helper.rb', __FILE__)
+require 'spec_helper'
 
 describe Fission::Command do
   describe 'new' do
@@ -13,6 +13,13 @@ describe Fission::Command do
     end
   end
 
+  describe 'command_name' do
+    it 'should return the pretty command name' do
+      cmd = Fission::Command.new
+      cmd.command_name(Fission::Command::SnapshotList.new).should == 'snapshot list'
+    end
+  end
+
   describe 'help' do
     it 'should call option_parser on a new instance' do
       @new_instance_mock = mock('new_instance')
@@ -22,6 +29,14 @@ describe Fission::Command do
     end
   end
 
+  describe 'summary' do
+    it "should raise an exception that it's not implemented" do
+      lambda {
+        Fission::Command.new.summary
+      }.should raise_error NotImplementedError
+    end
+  end
+
   describe 'ui' do
     it 'should load a ui object' do
       Fission::Command.new.ui.should be_a Fission::UI

data/spec/fission/config_spec.rb

@@ -1,4 +1,4 @@
-require File.expand_path('../../spec_helper.rb', __FILE__)
+require 'spec_helper'
 
 describe Fission::Config do
   describe "init" do
@@ -49,7 +49,7 @@ describe Fission::Config do
 
     it 'should set vmrun_cmd' do
       @config = Fission::Config.new
-      @config.attributes['vmrun_cmd'].should == '/Library/Application\ Support/VMware\ Fusion/vmrun -T fusion'
+      @config.attributes['vmrun_cmd'].should == "'/Library/Application Support/VMware Fusion/vmrun' -T fusion"
     end
 
     it 'should set the vmrun_cmd correctly if there is a user specified vmrun bin' do
@@ -58,7 +58,7 @@ describe Fission::Config do
       end
 
       @config = Fission::Config.new
-      @config.attributes['vmrun_cmd'].should == '/var/tmp/vmrun_bin -T fusion'
+      @config.attributes['vmrun_cmd'].should == "'/var/tmp/vmrun_bin' -T fusion"
     end
 
     it 'should use the fusion default lease file' do

data/spec/fission/fusion_spec.rb

@@ -1,21 +1,26 @@
-require File.expand_path('../../spec_helper.rb', __FILE__)
+require 'spec_helper'
 
 describe Fission::Fusion do
   describe 'self.running?' do
     before do
       @cmd = "ps -ef | grep -v grep | "
-      @cmd << "grep -c #{Fission.config['gui_bin'].gsub(' ', '\ ')} 2>&1"
+      @cmd << "grep -c '#{Fission.config['gui_bin']}' 2>&1"
+      @executor = mock 'executor'
     end
 
     it 'should return a successful response and true if the fusion app is running' do
-      Fission::Fusion.should_receive(:`).with(@cmd).
-                                         and_return("1\n")
+      @executor.should_receive(:execute).and_return({'output' => "1\n"})
+      Fission::Action::ShellExecutor.should_receive(:new).
+                                     with(@cmd).
+                                     and_return(@executor)
       Fission::Fusion.running?.should == true
     end
 
     it 'should return a successful response and false if the fusion app is not running' do
-      Fission::Fusion.should_receive(:`).with(@cmd).
-                                         and_return("0\n")
+      @executor.should_receive(:execute).and_return({'output' => "0\n"})
+      Fission::Action::ShellExecutor.should_receive(:new).
+                                     with(@cmd).
+                                     and_return(@executor)
       Fission::Fusion.running?.should == false
     end
   end

data/spec/fission/lease_spec.rb

@@ -1,4 +1,4 @@
-require File.expand_path('../../spec_helper.rb', __FILE__)
+require 'spec_helper'
 
 describe Fission::Lease do
   before do
@@ -6,14 +6,22 @@ describe Fission::Lease do
                       :mac_address  => '00:0c:29:2b:af:50',
                       :start        => '2011/10/11 01:50:58',
                       :end          => '2011/10/11 02:20:58' },
+                    { :ip_address   => '172.16.248.170',
+                      :mac_address  => '00:0c:29:b3:63:d0',
+                      :start        => '2010/03/01 00:54:52',
+                      :end          => '2010/03/01 01:24:52' },
                     { :ip_address   => '172.16.248.132',
                       :mac_address  => '00:0c:29:10:23:57',
                       :start        => '2010/07/12 21:31:28',
                       :end          => '2010/07/12 22:01:28' },
-                    { :ip_address   => '172.16.248.130',
+                    { :ip_address   => '172.16.248.150',
                       :mac_address  => '00:0c:29:b3:63:d0',
                       :start        => '2010/05/27 00:54:52',
                       :end          => '2010/05/27 01:24:52' },
+                    { :ip_address   => '172.16.248.130',
+                      :mac_address  => '00:0c:29:b3:63:d0',
+                      :start        => '2010/04/15 00:54:52',
+                      :end          => '2010/04/15 01:24:52' },
                     { :ip_address   => '172.16.248.129',
                       :mac_address  => '00:0c:29:0a:e9:b3',
                       :start        => '2010/02/16 23:16:05',
@@ -26,16 +34,26 @@ lease 172.16.248.197 {
     ends 2 2011/10/11 02:20:58;
     hardware ethernet 00:0c:29:2b:af:50;
 }
+lease 172.16.248.170 {
+    starts 4 2010/03/01 00:54:52;
+    ends 4 2010/03/01 01:24:52;
+    hardware ethernet 00:0c:29:b3:63:d0;
+}
 lease 172.16.248.132 {
     starts 1 2010/07/12 21:31:28;
     ends 1 2010/07/12 22:01:28;
     hardware ethernet 00:0c:29:10:23:57;
 }
-lease 172.16.248.130 {
+lease 172.16.248.150 {
     starts 4 2010/05/27 00:54:52;
     ends 4 2010/05/27 01:24:52;
     hardware ethernet 00:0c:29:b3:63:d0;
 }
+lease 172.16.248.130 {
+    starts 4 2010/04/15 00:54:52;
+    ends 4 2010/04/15 01:24:52;
+    hardware ethernet 00:0c:29:b3:63:d0;
+}
 lease 172.16.248.129 {
     starts 2 2010/02/16 23:16:05;
     ends 2 2010/02/16 23:46:05;
@@ -44,10 +62,6 @@ lease 172.16.248.129 {
   end
 
   describe 'new' do
-    { :ip_address   => '127.0.0.1',
-      :mac_address  => '00:00:00:00:00:00',
-      :start        => '2004/07/25 17:18:00',
-      :end          => '2004/07/25 18:18:00' }
     it 'should set the ip address' do
       lease = Fission::Lease.new :ip_address => '127.0.0.1'
       lease.ip_address.should == '127.0.0.1'
@@ -84,52 +98,63 @@ lease 172.16.248.129 {
   end
 
   describe 'self.all' do
-    it 'should query the configured lease file' do
-      File.should_receive(:read).with(Fission.config['lease_file']).
-                                 and_return('')
-
-      Fission::Lease.all
-    end
 
-    it 'should return a successful response with the list of the found leases' do
-      File.should_receive(:read).with(Fission.config['lease_file']).
-                                 and_return(@lease_file_content)
+    context 'when the lease file exists' do
+      before do
+        File.should_receive(:file?).
+             with(Fission.config['lease_file']).
+             and_return(true)
+      end
 
-      example_leases = @lease_info.collect do |lease|
-        Fission::Lease.new :ip_address  => lease[:ip_address],
-                           :mac_address => lease[:mac_address],
-                           :start       => DateTime.parse(lease[:start]),
-                           :end         => DateTime.parse(lease[:end])
+      it 'returns a response with the list of the found leases' do
+        File.should_receive(:read).
+             with(Fission.config['lease_file']).
+             and_return(@lease_file_content)
 
-      end
+        example_leases = @lease_info.collect do |lease|
+          Fission::Lease.new :ip_address  => lease[:ip_address],
+                             :mac_address => lease[:mac_address],
+                             :start       => DateTime.parse(lease[:start]),
+                             :end         => DateTime.parse(lease[:end])
+        end
 
-      response = Fission::Lease.all
-      response.should be_a_successful_response
+        response = Fission::Lease.all
+        response.should be_a_successful_response
 
-      response.data.each do |lease|
-        example_lease = example_leases.select { |l| l.ip_address == lease.ip_address }
+        response.data.each do |lease|
+          example_lease = example_leases.select { |l| l.ip_address == lease.ip_address }
 
-        [:ip_address, :mac_address, :start, :end].each do |attrib|
-          lease.send(attrib).should == example_lease.first.send(attrib)
+          [:ip_address, :mac_address, :start, :end].each do |attrib|
+            lease.send(attrib).should == example_lease.first.send(attrib)
+          end
         end
+
       end
 
-    end
+      it 'a response with an empty list if there are no leases found' do
+        File.should_receive(:read).
+             with(Fission.config['lease_file']).
+             and_return('')
+        response = Fission::Lease.all
+        response.should be_a_successful_response
+        response.data.should == []
+      end
 
-    it 'should return a successful response with an empty list if there are no leases found' do
-      File.should_receive(:read).with(Fission.config['lease_file']).
-                                 and_return('')
-      response = Fission::Lease.all
-      response.should be_a_successful_response
-      response.data.should == []
     end
 
-    it 'should return an unsuccessful response if the configured lease file does not exist' do
-      File.should_receive(:file?).with(Fission.config['lease_file']).
-                                  and_return(false)
-      response = Fission::Lease.all
-      error_string = "Unable to find the lease file '#{Fission.config['lease_file']}'"
-      response.should be_an_unsuccessful_response(error_string)
+    context 'when the lease file does not exist' do
+      before do
+        File.should_receive(:file?).
+             with(Fission.config['lease_file']).
+             and_return(false)
+      end
+
+      it 'should return an unsuccessful response if the configured lease file does not exist' do
+        response = Fission::Lease.all
+        error_string = "Unable to find the lease file '#{Fission.config['lease_file']}'"
+        response.should be_an_unsuccessful_response(error_string)
+      end
+
     end
 
   end
@@ -137,16 +162,27 @@ lease 172.16.248.129 {
   describe 'self.find_by_mac_address' do
     describe 'when able to get all of the leases' do
       before do
-        File.should_receive(:read).with(Fission.config['lease_file']).
-                                   and_return(@lease_file_content)
+        File.stub(:file?).and_return(true)
+        File.stub(:read).and_return(@lease_file_content)
       end
 
-      it 'should return a response with the lease associated with the provided mac address' do
+      context 'when there are multiple leases for the mac address' do
+        it 'should return the lease with the latest expiration' do
+          response = Fission::Lease.find_by_mac_address '00:0c:29:b3:63:d0'
+
+          response.should be_a_successful_response
+
+          response.data.ip_address.should == '172.16.248.150'
+          response.data.mac_address.should == '00:0c:29:b3:63:d0'
+          response.data.start.should == DateTime.parse('2010/05/27 00:54:52')
+          response.data.end.should == DateTime.parse('2010/05/27 01:24:52')
+        end
+      end
 
+      it 'should return a response with the lease associated with the provided mac address' do
         response = Fission::Lease.find_by_mac_address '00:0c:29:10:23:57'
 
         response.should be_a_successful_response
-
         response.data.ip_address.should == '172.16.248.132'
         response.data.mac_address.should == '00:0c:29:10:23:57'
         response.data.start.should == DateTime.parse('2010/07/12 21:31:28')

data/spec/fission/metadata_spec.rb

@@ -1,4 +1,4 @@
-require File.expand_path('../../spec_helper.rb', __FILE__)
+require 'spec_helper'
 
 describe Fission::Metadata do
   before do
@@ -23,13 +23,16 @@ describe Fission::Metadata do
 
   describe 'delete_vm_restart_document' do
     before do
-      @data = { 'PLRestartDocumentPaths' => ['/vm/foo.vmwarevm', '/vm/bar.vmwarevm']}
+      vm_dir = Fission.config['vm_dir']
+      @foo_vm_dir = File.join vm_dir, 'foo.vmwarevm'
+      @bar_vm_dir = File.join vm_dir, 'bar.vmwarevm'
+      @data = { 'PLRestartDocumentPaths' => [@foo_vm_dir, @bar_vm_dir]}
       @metadata.content = @data
     end
 
     it 'should remove the vm item from the list if the vm path is in the list' do
       @metadata.delete_vm_restart_document(Fission::VM.new('foo').path)
-      @metadata.content.should == { 'PLRestartDocumentPaths' => ['/vm/bar.vmwarevm']}
+      @metadata.content.should == { 'PLRestartDocumentPaths' => [@bar_vm_dir]}
     end
 
     it 'should not doing anything if the vm is not in the list' do
@@ -47,7 +50,9 @@ describe Fission::Metadata do
 
   describe 'delete_vm_favorite_entry' do
     before do
-      @data = { 'VMFavoritesListDefaults2' => [{'path' => '/vm/foo.vmwarevm'}] }
+      foo_vm_dir = File.join Fission.config['vm_dir'], 'foo.vmwarevm'
+
+      @data = { 'VMFavoritesListDefaults2' => [{'path' => foo_vm_dir}] }
       @metadata.content = @data
     end
 
@@ -60,6 +65,22 @@ describe Fission::Metadata do
       @metadata.delete_vm_favorite_entry(Fission::VM.new('bar').path)
       @metadata.content.should == @data
     end
+
+    it 'should ignore VMFavoritesListDefaults2 in Fussion 5' do
+      data = {}
+      @metadata.content = data
+      @metadata.delete_vm_favorite_entry(Fission::VM.new('bar').path)
+      @metadata.content.should == data
+    end
+
+    it 'should remove the vm item from the list in Fussion 5' do
+      foo_vm_dir = File.join Fission.config['vm_dir'], 'foo.vmwarevm'
+      data = {"fusionInitialSessions" => [{"documentPath" => foo_vm_dir}]}
+
+      @metadata.content = data
+      @metadata.delete_vm_favorite_entry(Fission::VM.new('foo').path)
+      @metadata.content.should == { 'fusionInitialSessions' => []}
+    end
   end
 
   describe 'self.delete_vm_info' do
@@ -68,16 +89,18 @@ describe Fission::Metadata do
       @md_mock.should_receive(:load)
       @md_mock.should_receive(:save)
       Fission::Metadata.stub!(:new).and_return(@md_mock)
+
+      @foo_vm_dir = File.join Fission.config['vm_dir'], 'foo.vmwarevm'
     end
 
     it 'should remove the vm from the restart document list' do
-      @md_mock.should_receive(:delete_vm_restart_document).with('/vm/foo.vmwarevm')
+      @md_mock.should_receive(:delete_vm_restart_document).with(@foo_vm_dir)
       @md_mock.stub!(:delete_vm_favorite_entry)
       Fission::Metadata.delete_vm_info(Fission::VM.new('foo').path)
     end
 
     it 'should remove the vm from the favorite list' do
-      @md_mock.should_receive(:delete_vm_favorite_entry).with('/vm/foo.vmwarevm')
+      @md_mock.should_receive(:delete_vm_favorite_entry).with(@foo_vm_dir)
       @md_mock.stub!(:delete_vm_restart_document)
       Fission::Metadata.delete_vm_info(Fission::VM.new('foo').path)
     end

data/spec/fission/response_spec.rb

@@ -1,4 +1,4 @@
-require File.expand_path('../../spec_helper.rb', __FILE__)
+require 'spec_helper'
 
 describe Fission::Response do
   describe 'initialize' do
@@ -58,23 +58,34 @@ describe Fission::Response do
     end
   end
 
-  describe 'self.from_command' do
+  describe 'self.from_shell_executor' do
+    before do
+      @process_status = mock 'process status'
+    end
+
     it 'should return a response object' do
-      Fission::Response.from_command('').should be_a Fission::Response
+      @process_status.stub(:exitstatus).and_return(0)
+      executor = {'process_status' => @process_status}
+      Fission::Response.from_shell_executor(executor).should be_a Fission::Response
     end
 
     it 'should set the code to the exit status' do
-      $?.should_receive(:exitstatus).and_return(55)
-      Fission::Response.from_command('').code.should == 55
+      @process_status.stub(:exitstatus).and_return(55)
+      executor = {'process_status' => @process_status}
+      Fission::Response.from_shell_executor(executor).code.should == 55
     end
 
     it 'should set the message if the command was unsuccessful' do
-      $?.should_receive(:exitstatus).and_return(55)
-      Fission::Response.from_command('foo').message.should == 'foo'
+      @process_status.stub(:exitstatus).and_return(55)
+      executor = {'process_status' => @process_status,
+                  'output'         => 'foo'}
+      Fission::Response.from_shell_executor(executor).message.should == 'foo'
     end
     it 'should not set the message if the command was successful' do
-      $?.should_receive(:exitstatus).and_return(0)
-      Fission::Response.from_command('foo').message.should == ''
+      @process_status.stub(:exitstatus).and_return(0)
+      executor = {'process_status' => @process_status,
+                  'output'         => 'foo'}
+      Fission::Response.from_shell_executor(executor).message.should == ''
     end
 
   end

data/spec/fission/ui_spec.rb

@@ -1,4 +1,4 @@
-require File.expand_path('../../spec_helper.rb', __FILE__)
+require 'spec_helper'
 
 describe Fission::UI do
   before do

data/spec/fission/vm_configuration_spec.rb

@@ -0,0 +1,132 @@
+require 'spec_helper'
+
+describe Fission::VMConfiguration do
+  before do
+    @vm = Fission::VM.new 'foo'
+    @conf_file_response_mock = mock 'conf_file_response'
+    @conf_file_response_mock.stub_as_successful @conf_file_path
+  end
+
+  describe 'config_data' do
+    before do
+      @vm.stub(:exists?).and_return(true)
+      @vm_config = Fission::VMConfiguration.new @vm
+      @vm.stub(:conf_file).and_return(@conf_file_response_mock)
+    end
+
+    it "should return an unsuccessful response if the vm doesn't exist" do
+      @vm.stub(:exists?).and_return(false)
+      @vm_config.config_data.should be_an_unsuccessful_response 'VM does not exist'
+    end
+
+    it 'should return an unsuccessful response if unable to figure out the conf file' do
+      @conf_file_response_mock.stub_as_unsuccessful
+      @vm_config.config_data.should be_an_unsuccessful_response
+    end
+
+    context 'when the vm exists and the conf file can be found' do
+      before do
+        @conf_file_io = StringIO.new
+        vmx_content = '.encoding = "UTF-8"
+config.version = "8"
+virtualHW.version = "7"
+scsi0.present = "TRUE"
+scsi0.virtualDev = "lsilogic"
+memsize = "384"
+scsi0:0.present = "TRUE"
+scsi0:0.fileName = "u10_04-000001.vmdk"
+ethernet0.present = "TRUE"
+ethernet0.connectionType = "nat"
+ethernet0.wakeOnPcktRcv = "FALSE"
+ethernet0.addressType = "generated"
+ethernet0.linkStatePropagation.enable = "TRUE"
+ehci.present = "TRUE"
+pciBridge4.virtualDev = "pcieRootPort"
+pciBridge4.functions = "8"
+vmci0.present = "TRUE"
+roamingVM.exitBehavior = "go"
+tools.syncTime = "TRUE"
+displayName = "u10_04"
+guestOS = "ubuntu"
+nvram = "u10_04.nvram"
+virtualHW.productCompatibility = "hosted"
+tools.upgrade.policy = "upgradeAtPowerCycle"
+extendedConfigFile = "u10_04.vmxf"
+serial0.present = "FALSE"
+usb.present = "FALSE"
+checkpoint.vmState = "u10_04.vmss"
+ethernet0.generatedAddress = "00:0c:29:c4:94:22"
+uuid.location = "56 4d 4b e9 1a bb 22 3a-b0 91 06 4e b4 c4 94 22"
+uuid.bios = "56 4d 4b e9 1a bb 22 3a-b0 91 06 4e b4 c4 94 22"
+cleanShutdown = "TRUE"
+scsi0:0.redo = ""
+scsi0.pciSlotNumber = "16"
+ethernet0.pciSlotNumber = "32"
+ethernet0.generatedAddressOffset = "0"
+vmci0.id = "-1262185438"
+tools.remindInstall = "TRUE"'
+        @conf_file_io.string = vmx_content
+        File.should_receive(:readlines).with(@conf_file_path).
+                                         and_return(@conf_file_io.string.split(/$/))
+      end
+
+      it 'should return a successful response' do
+        @vm_config.config_data.should be_a_successful_response
+      end
+
+      it 'should return the data as a hash like object' do
+        config = @vm_config.config_data
+        config.data.should respond_to :keys
+        config.data.should respond_to :values
+        config.data.should respond_to :each_pair
+        config.data.should respond_to :[]
+      end
+
+      it 'should return accurate data' do
+        expected_data = { '.encoding' => 'UTF-8',
+                          'config.version' => '8',
+                          'virtualHW.version' => '7',
+                          'scsi0.present' => 'TRUE',
+                          'scsi0.virtualDev' => 'lsilogic',
+                          'memsize' => '384',
+                          'scsi0:0.present' => 'TRUE',
+                          'scsi0:0.fileName' => 'u10_04-000001.vmdk',
+                          'ethernet0.present' => 'TRUE',
+                          'ethernet0.connectionType' => 'nat',
+                          'ethernet0.wakeOnPcktRcv' => 'FALSE',
+                          'ethernet0.addressType' => 'generated',
+                          'ethernet0.linkStatePropagation.enable' => 'TRUE',
+                          'ehci.present' => 'TRUE',
+                          'pciBridge4.virtualDev' => 'pcieRootPort',
+                          'pciBridge4.functions' => '8',
+                          'vmci0.present' => 'TRUE',
+                          'roamingVM.exitBehavior' => 'go',
+                          'tools.syncTime' => 'TRUE',
+                          'displayName' => 'u10_04',
+                          'guestOS' => 'ubuntu',
+                          'nvram' => 'u10_04.nvram',
+                          'virtualHW.productCompatibility' => 'hosted',
+                          'tools.upgrade.policy' => 'upgradeAtPowerCycle',
+                          'extendedConfigFile' => 'u10_04.vmxf',
+                          'serial0.present' => 'FALSE',
+                          'usb.present' => 'FALSE',
+                          'checkpoint.vmState' => 'u10_04.vmss',
+                          'ethernet0.generatedAddress' => '00:0c:29:c4:94:22',
+                          'uuid.location' => '56 4d 4b e9 1a bb 22 3a-b0 91 06 4e b4 c4 94 22',
+                          'uuid.bios' => '56 4d 4b e9 1a bb 22 3a-b0 91 06 4e b4 c4 94 22',
+                          'cleanShutdown' => 'TRUE',
+                          'scsi0:0.redo' => '',
+                          'scsi0.pciSlotNumber' => '16',
+                          'ethernet0.pciSlotNumber' => '32',
+                          'ethernet0.generatedAddressOffset' => '0',
+                          'vmci0.id' => '-1262185438',
+                          'tools.remindInstall' => 'TRUE' }
+
+        config = @vm_config.config_data
+        config.data.should == expected_data
+      end
+
+    end
+  end
+
+end