feedjira 3.2.0 → 3.2.2

data/spec/feedjira/parser/atom_spec.rb

@@ -5,72 +5,72 @@ require "spec_helper"
 module Feedjira
   module Parser
     describe "#will_parse?" do
-      it "should return true for an atom feed" do
+      it "returns true for an atom feed" do
         expect(Atom).to be_able_to_parse(sample_atom_feed)
       end
 
-      it "should return false for an rdf feed" do
-        expect(Atom).to_not be_able_to_parse(sample_rdf_feed)
+      it "returns false for an rdf feed" do
+        expect(Atom).not_to be_able_to_parse(sample_rdf_feed)
       end
 
-      it "should return false for an rss feedburner feed" do
-        expect(Atom).to_not be_able_to_parse(sample_rss_feed_burner_feed)
+      it "returns false for an rss feedburner feed" do
+        expect(Atom).not_to be_able_to_parse(sample_rss_feed_burner_feed)
       end
 
-      it "should return true for an atom feed that has line breaks in between attributes in the <feed> node" do
+      it "returns true for an atom feed that has line breaks in between attributes in the <feed> node" do
         expect(Atom).to be_able_to_parse(sample_atom_feed_line_breaks)
       end
     end
 
     describe "parsing" do
-      before(:each) do
+      before do
         @feed = Atom.parse(sample_atom_feed)
       end
 
-      it "should parse the title" do
+      it "parses the title" do
         expect(@feed.title).to eq "Amazon Web Services Blog"
       end
 
-      it "should parse the description" do
+      it "parses the description" do
         description = "Amazon Web Services, Products, Tools, and Developer Information..."
         expect(@feed.description).to eq description
       end
 
-      it "should parse the icon url" do
+      it "parses the icon url" do
         feed_with_icon = Atom.parse(load_sample("SamRuby.xml"))
         expect(feed_with_icon.icon).to eq "../favicon.ico"
       end
 
-      it "should parse the url" do
+      it "parses the url" do
         expect(@feed.url).to eq "http://aws.typepad.com/aws/"
       end
 
-      it "should parse the url even when it doesn't have the type='text/html' attribute" do
+      it "parses the url even when it doesn't have the type='text/html' attribute" do
         xml = load_sample "atom_with_link_tag_for_url_unmarked.xml"
         feed = Atom.parse xml
         expect(feed.url).to eq "http://www.innoq.com/planet/"
       end
 
-      it "should parse the feed_url even when it doesn't have the type='application/atom+xml' attribute" do
+      it "parses the feed_url even when it doesn't have the type='application/atom+xml' attribute" do
         feed = Atom.parse(load_sample("atom_with_link_tag_for_url_unmarked.xml"))
         expect(feed.feed_url).to eq "http://www.innoq.com/planet/atom.xml"
       end
 
-      it "should parse the feed_url" do
+      it "parses the feed_url" do
         expect(@feed.feed_url).to eq "http://aws.typepad.com/aws/atom.xml"
       end
 
-      it "should parse no hub urls" do
+      it "parses no hub urls" do
         expect(@feed.hubs.count).to eq 0
       end
 
-      it "should parse the hub urls" do
+      it "parses the hub urls" do
         feed_with_hub = Atom.parse(load_sample("SamRuby.xml"))
         expect(feed_with_hub.hubs.count).to eq 1
         expect(feed_with_hub.hubs.first).to eq "http://pubsubhubbub.appspot.com/"
       end
 
-      it "should parse entries" do
+      it "parses entries" do
         expect(@feed.entries.size).to eq 10
       end
     end
@@ -89,7 +89,7 @@ module Feedjira
         expect(entry.content).to match(/\A<p/)
       end
 
-      it "should not duplicate content when there are divs in content" do
+      it "does not duplicate content when there are divs in content" do
         Atom.preprocess_xml = true
 
         feed = Atom.parse sample_duplicate_content_atom_feed
@@ -99,25 +99,25 @@ module Feedjira
     end
 
     describe "parsing url and feed_url" do
-      before :each do
+      before do
         @feed = Atom.parse(sample_atom_middleman_feed)
       end
 
-      it "should parse url" do
+      it "parses url" do
         expect(@feed.url).to eq "http://feedjira.com/blog"
       end
 
-      it "should parse feed_url" do
+      it "parses feed_url" do
         expect(@feed.feed_url).to eq "http://feedjira.com/blog/feed.xml"
       end
 
-      it "should not parse links without the rel='self' attribute as feed_url" do
+      it "does not parse links without the rel='self' attribute as feed_url" do
         xml = load_sample "atom_simple_single_entry.xml"
         feed = Atom.parse xml
         expect(feed.feed_url).to be_nil
       end
 
-      it "should not parse links with the rel='self' attribute as url" do
+      it "does not parse links with the rel='self' attribute as url" do
         xml = load_sample "atom_simple_single_entry_link_self.xml"
         feed = Atom.parse xml
         expect(feed.url).to be_nil

data/spec/feedjira/parser/atom_youtube_entry_spec.rb

@@ -9,79 +9,79 @@ describe Feedjira::Parser::AtomYoutubeEntry do
       @entry = @feed.entries.first
     end
 
-    it "should have the title" do
+    it "has the title" do
       expect(@entry.title).to eq "The Google app: Questions Title"
     end
 
-    it "should have the url" do
+    it "has the url" do
       expect(@entry.url).to eq "http://www.youtube.com/watch?v=5shykyfmb28"
     end
 
-    it "should have the entry id" do
+    it "has the entry id" do
       expect(@entry.entry_id).to eq "yt:video:5shykyfmb28"
     end
 
-    it "should have the published date" do
+    it "has the published date" do
       expect(@entry.published).to eq Time.parse_safely("2015-05-04T00:01:27+00:00")
     end
 
-    it "should have the updated date" do
+    it "has the updated date" do
       expect(@entry.updated).to eq Time.parse_safely("2015-05-13T17:38:30+00:00")
     end
 
-    it "should have the content populated from the media:description element" do
+    it "has the content populated from the media:description element" do
       expect(@entry.content).to eq "A question is the most powerful force in the world. It can start you on an adventure or spark a connection. See where a question can take you. The Google app is available on iOS and Android. Download the app here: http://www.google.com/search/about/download"
     end
 
-    it "should have the summary but blank" do
+    it "has the summary but blank" do
       expect(@entry.summary).to be_nil
     end
 
-    it "should have the custom youtube video id" do
+    it "has the custom youtube video id" do
       expect(@entry.youtube_video_id).to eq "5shykyfmb28"
     end
 
-    it "should have the custom media title" do
+    it "has the custom media title" do
       expect(@entry.media_title).to eq "The Google app: Questions"
     end
 
-    it "should have the custom media url" do
+    it "has the custom media url" do
       expect(@entry.media_url).to eq "https://www.youtube.com/v/5shykyfmb28?version=3"
     end
 
-    it "should have the custom media type" do
+    it "has the custom media type" do
       expect(@entry.media_type).to eq "application/x-shockwave-flash"
     end
 
-    it "should have the custom media width" do
+    it "has the custom media width" do
       expect(@entry.media_width).to eq "640"
     end
 
-    it "should have the custom media height" do
+    it "has the custom media height" do
       expect(@entry.media_height).to eq "390"
     end
 
-    it "should have the custom media thumbnail url" do
+    it "has the custom media thumbnail url" do
       expect(@entry.media_thumbnail_url).to eq "https://i2.ytimg.com/vi/5shykyfmb28/hqdefault.jpg"
     end
 
-    it "should have the custom media thumbnail width" do
+    it "has the custom media thumbnail width" do
       expect(@entry.media_thumbnail_width).to eq "480"
     end
 
-    it "should have the custom media thumbnail height" do
+    it "has the custom media thumbnail height" do
       expect(@entry.media_thumbnail_height).to eq "360"
     end
 
-    it "should have the custom media star count" do
+    it "has the custom media star count" do
       expect(@entry.media_star_count).to eq "3546"
     end
 
-    it "should have the custom media star average" do
+    it "has the custom media star average" do
       expect(@entry.media_star_average).to eq "4.79"
     end
 
-    it "should have the custom media views" do
+    it "has the custom media views" do
       expect(@entry.media_views).to eq "251497"
     end
   end

data/spec/feedjira/parser/atom_youtube_spec.rb

@@ -4,41 +4,41 @@ require File.join(File.dirname(__FILE__), %w[.. .. spec_helper])
 
 describe Feedjira::Parser::AtomYoutube do
   describe "#will_parse?" do
-    it "should return true for an atom youtube feed" do
-      expect(Feedjira::Parser::AtomYoutube).to be_able_to_parse(sample_youtube_atom_feed)
+    it "returns true for an atom youtube feed" do
+      expect(described_class).to be_able_to_parse(sample_youtube_atom_feed)
     end
 
-    it "should return fase for an atom feed" do
-      expect(Feedjira::Parser::AtomYoutube).to_not be_able_to_parse(sample_atom_feed)
+    it "returns fase for an atom feed" do
+      expect(described_class).not_to be_able_to_parse(sample_atom_feed)
     end
 
-    it "should return false for an rss feedburner feed" do
-      expect(Feedjira::Parser::AtomYoutube).to_not be_able_to_parse(sample_rss_feed_burner_feed)
+    it "returns false for an rss feedburner feed" do
+      expect(described_class).not_to be_able_to_parse(sample_rss_feed_burner_feed)
     end
   end
 
   describe "parsing" do
-    before(:each) do
-      @feed = Feedjira::Parser::AtomYoutube.parse(sample_youtube_atom_feed)
+    before do
+      @feed = described_class.parse(sample_youtube_atom_feed)
     end
 
-    it "should parse the title" do
+    it "parses the title" do
       expect(@feed.title).to eq "Google"
     end
 
-    it "should parse the author" do
+    it "parses the author" do
       expect(@feed.author).to eq "Google Author"
     end
 
-    it "should parse the url" do
+    it "parses the url" do
       expect(@feed.url).to eq "http://www.youtube.com/user/Google"
     end
 
-    it "should parse the feed_url" do
+    it "parses the feed_url" do
       expect(@feed.feed_url).to eq "http://www.youtube.com/feeds/videos.xml?user=google"
     end
 
-    it "should parse the YouTube channel id" do
+    it "parses the YouTube channel id" do
       expect(@feed.youtube_channel_id).to eq "UCK8sQmJBp8GCxrOtXWBpyEA"
     end
   end

data/spec/feedjira/parser/google_docs_atom_entry_spec.rb

@@ -10,15 +10,15 @@ describe Feedjira::Parser::GoogleDocsAtomEntry do
       @entry = @feed.entries.first
     end
 
-    it "should have the custom checksum element" do
+    it "has the custom checksum element" do
       expect(@entry.checksum).to eq "2b01142f7481c7b056c4b410d28f33cf"
     end
 
-    it "should have the custom filename element" do
+    it "has the custom filename element" do
       expect(@entry.original_filename).to eq "MyFile.pdf"
     end
 
-    it "should have the custom suggested filename element" do
+    it "has the custom suggested filename element" do
       expect(@entry.suggested_filename).to eq "TaxDocument.pdf"
     end
   end

data/spec/feedjira/parser/google_docs_atom_spec.rb

@@ -5,12 +5,12 @@ require "spec_helper"
 module Feedjira
   module Parser
     describe ".able_to_parser?" do
-      it "should return true for Google Docs feed" do
+      it "returns true for Google Docs feed" do
         expect(GoogleDocsAtom).to be_able_to_parse(sample_google_docs_list_feed)
       end
 
-      it "should not be able to parse another Atom feed" do
-        expect(GoogleDocsAtom).to_not be_able_to_parse(sample_atom_feed)
+      it "is not able to parse another Atom feed" do
+        expect(GoogleDocsAtom).not_to be_able_to_parse(sample_atom_feed)
       end
     end
 
@@ -19,15 +19,15 @@ module Feedjira
         @feed = GoogleDocsAtom.parse(sample_google_docs_list_feed)
       end
 
-      it "should return a bunch of objects" do
-        expect(@feed.entries).to_not be_empty
+      it "returns a bunch of objects" do
+        expect(@feed.entries).not_to be_empty
       end
 
-      it "should populate a title, interhited from the Atom entry" do
-        expect(@feed.title).to_not be_nil
+      it "populates a title, interhited from the Atom entry" do
+        expect(@feed.title).not_to be_nil
       end
 
-      it "should return a bunch of entries of type GoogleDocsAtomEntry" do
+      it "returns a bunch of entries of type GoogleDocsAtomEntry" do
         expect(@feed.entries.first).to be_a GoogleDocsAtomEntry
       end
     end

data/spec/feedjira/parser/{itunes_rss_item_spec.rb → i_tunes_rss_item_spec.rb}

@@ -3,82 +3,82 @@
 require "spec_helper"
 
 describe Feedjira::Parser::ITunesRSSItem do
-  before(:each) do
+  before do
     # I don't really like doing it this way because these unit test should only
     # rely on ITunesRssItem, but this is actually how it should work. You would
     # never just pass entry xml straight to the ITunesRssItem
     @item = Feedjira::Parser::ITunesRSS.parse(sample_itunes_feed).entries.first
   end
 
-  it "should parse the title" do
+  it "parses the title" do
     expect(@item.title).to eq "Shake Shake Shake Your Spices"
   end
 
-  it "should parse the itunes title" do
+  it "parses the itunes title" do
     expect(@item.itunes_title).to eq "Shake Shake Shake Your Spices"
   end
 
-  it "should parse the author" do
+  it "parses the author" do
     expect(@item.itunes_author).to eq "John Doe"
   end
 
-  it "should parse the subtitle" do
+  it "parses the subtitle" do
     expect(@item.itunes_subtitle).to eq "A short primer on table spices"
   end
 
-  it "should parse the summary" do
+  it "parses the summary" do
     summary = "This week we talk about salt and pepper shakers, comparing and contrasting pour rates, construction materials, and overall aesthetics. Come and join the party!"
     expect(@item.itunes_summary).to eq summary
   end
 
-  it "should parse the itunes season" do
+  it "parses the itunes season" do
     expect(@item.itunes_season).to eq "1"
   end
 
-  it "should parse the itunes episode number" do
+  it "parses the itunes episode number" do
     expect(@item.itunes_episode).to eq "3"
   end
 
-  it "should parse the itunes episode type" do
+  it "parses the itunes episode type" do
     expect(@item.itunes_episode_type).to eq "full"
   end
 
-  it "should parse the enclosure" do
+  it "parses the enclosure" do
     expect(@item.enclosure_length).to eq "8727310"
     expect(@item.enclosure_type).to eq "audio/x-m4a"
     expect(@item.enclosure_url).to eq "http://example.com/podcasts/everything/AllAboutEverythingEpisode3.m4a"
   end
 
-  it "should parse the guid as id" do
+  it "parses the guid as id" do
     expect(@item.id).to eq "http://example.com/podcasts/archive/aae20050615.m4a"
   end
 
-  it "should parse the published date" do
+  it "parses the published date" do
     published = Time.parse_safely "Wed Jun 15 19:00:00 UTC 2005"
     expect(@item.published).to eq published
   end
 
-  it "should parse the duration" do
+  it "parses the duration" do
     expect(@item.itunes_duration).to eq "7:04"
   end
 
-  it "should parse the keywords" do
+  it "parses the keywords" do
     expect(@item.itunes_keywords).to eq "salt, pepper, shaker, exciting"
   end
 
-  it "should parse the image" do
+  it "parses the image" do
     expect(@item.itunes_image).to eq "http://example.com/podcasts/everything/AllAboutEverything.jpg"
   end
 
-  it "should parse the order" do
+  it "parses the order" do
     expect(@item.itunes_order).to eq "12"
   end
 
-  it "should parse the closed captioned flag" do
+  it "parses the closed captioned flag" do
     expect(@item.itunes_closed_captioned).to eq "yes"
   end
 
-  it "should parse the encoded content" do
+  it "parses the encoded content" do
     content = "<p><strong>TOPIC</strong>: Gooseneck Options</p>"
     expect(@item.content).to eq content
   end

data/spec/feedjira/parser/{itunes_rss_owner_spec.rb → i_tunes_rss_owner_spec.rb}

@@ -3,7 +3,7 @@
 require "spec_helper"
 
 describe Feedjira::Parser::ITunesRSSOwner do
-  before(:each) do
+  before do
     # I don't really like doing it this way because these unit test should only
     # rely on RSSEntry, but this is actually how it should work. You would
     # never just pass entry xml straight to the ITunesRssOwner
@@ -11,11 +11,11 @@ describe Feedjira::Parser::ITunesRSSOwner do
     @owner = feed.itunes_owners.first
   end
 
-  it "should parse the name" do
+  it "parses the name" do
     expect(@owner.name).to eq "John Doe"
   end
 
-  it "should parse the email" do
+  it "parses the email" do
     expect(@owner.email).to eq "john.doe@example.com"
   end
 end

data/spec/feedjira/parser/itunes_rss_spec.rb

@@ -5,82 +5,82 @@ require "spec_helper"
 module Feedjira
   module Parser
     describe "#will_parse?" do
-      it "should return true for an itunes RSS feed" do
+      it "returns true for an itunes RSS feed" do
         expect(ITunesRSS).to be_able_to_parse(sample_itunes_feed)
       end
 
-      it "should return true for an itunes RSS feed with spaces between attribute names, equals sign, and values" do
+      it "returns true for an itunes RSS feed with spaces between attribute names, equals sign, and values" do
         expect(ITunesRSS).to be_able_to_parse(sample_itunes_feed_with_spaces)
       end
 
-      it "should return true for an itunes RSS feed with single-quoted attributes" do
+      it "returns true for an itunes RSS feed with single-quoted attributes" do
         expect(ITunesRSS).to be_able_to_parse(sample_itunes_feed_with_single_quotes)
       end
 
-      it "should return fase for an atom feed" do
-        expect(ITunesRSS).to_not be_able_to_parse(sample_atom_feed)
+      it "returns fase for an atom feed" do
+        expect(ITunesRSS).not_to be_able_to_parse(sample_atom_feed)
       end
 
-      it "should return false for an rss feedburner feed" do
-        expect(ITunesRSS).to_not be_able_to_parse(sample_rss_feed_burner_feed)
+      it "returns false for an rss feedburner feed" do
+        expect(ITunesRSS).not_to be_able_to_parse(sample_rss_feed_burner_feed)
       end
     end
 
     describe "parsing" do
-      before(:each) do
+      before do
         @feed = ITunesRSS.parse(sample_itunes_feed)
       end
 
-      it "should parse the ttl" do
+      it "parses the ttl" do
         expect(@feed.ttl).to eq "60"
       end
 
-      it "should parse the last build date" do
+      it "parses the last build date" do
         expect(@feed.last_built).to eq "Sat, 07 Sep 2002 09:42:31 GMT"
       end
 
-      it "should parse the subtitle" do
+      it "parses the subtitle" do
         expect(@feed.itunes_subtitle).to eq "A show about everything"
       end
 
-      it "should parse the author" do
+      it "parses the author" do
         expect(@feed.itunes_author).to eq "John Doe"
       end
 
-      it "should parse an owner" do
+      it "parses an owner" do
         expect(@feed.itunes_owners.size).to eq 1
       end
 
-      it "should parse an image" do
+      it "parses an image" do
         expect(@feed.itunes_image).to eq "http://example.com/podcasts/everything/AllAboutEverything.jpg"
       end
 
-      it "should parse the image url" do
+      it "parses the image url" do
         expect(@feed.image.url).to eq "http://example.com/podcasts/everything/AllAboutEverything.jpg"
       end
 
-      it "should parse the image title" do
+      it "parses the image title" do
         expect(@feed.image.title).to eq "All About Everything"
       end
 
-      it "should parse the image link" do
+      it "parses the image link" do
         expect(@feed.image.link).to eq "http://www.example.com/podcasts/everything/index.html"
       end
 
-      it "should parse the image width" do
+      it "parses the image width" do
         expect(@feed.image.width).to eq "88"
       end
 
-      it "should parse the image height" do
+      it "parses the image height" do
         expect(@feed.image.height).to eq "31"
       end
 
-      it "should parse the image description" do
+      it "parses the image description" do
         description = "All About Everything is a show about everything. Each week we dive into any subject known to man and talk about it as much as we can. Look for our Podcast in the iTunes Music Store"
         expect(@feed.image.description).to eq description
       end
 
-      it "should parse categories" do
+      it "parses categories" do
         expect(@feed.itunes_categories).to eq [
           "Technology",
           "Gadgets",
@@ -98,24 +98,24 @@ module Feedjira
         ]
       end
 
-      it "should parse the itunes type" do
+      it "parses the itunes type" do
         expect(@feed.itunes_type).to eq "episodic"
       end
 
-      it "should parse the summary" do
+      it "parses the summary" do
         summary = "All About Everything is a show about everything. Each week we dive into any subject known to man and talk about it as much as we can. Look for our Podcast in the iTunes Music Store"
         expect(@feed.itunes_summary).to eq summary
       end
 
-      it "should parse the complete tag" do
+      it "parses the complete tag" do
         expect(@feed.itunes_complete).to eq "yes"
       end
 
-      it "should parse entries" do
+      it "parses entries" do
         expect(@feed.entries.size).to eq 3
       end
 
-      it "should parse the new-feed-url" do
+      it "parses the new-feed-url" do
         expect(@feed.itunes_new_feed_url).to eq "http://example.com/new.xml"
       end
     end