feedjira 3.2.0 → 3.2.2

data/spec/feedjira/feed_utilities_spec.rb

@@ -3,7 +3,7 @@
 require "spec_helper"
 
 describe Feedjira::FeedUtilities do
-  before(:each) do
+  before do
     @klass = Class.new do
       include SAXMachine
       include Feedjira::FeedUtilities
@@ -14,22 +14,22 @@ describe Feedjira::FeedUtilities do
     context "when the flag is not set" do
       it "does not call the preprocessing method" do
         @klass.preprocess_xml = false
-        expect(@klass).to_not receive :preprocess
+        expect(@klass).not_to receive :preprocess
         @klass.parse sample_rss_feed
       end
     end
 
     context "when the flag is set" do
-      it "calls the preprocessing method" do
+      it "calls the preprocessing method" do # rubocop:todo RSpec/NoExpectationExample
         @klass.preprocess_xml = true
-        expect(@klass).to receive(:preprocess).and_return sample_rss_feed
+        allow(@klass).to receive(:preprocess).and_return sample_rss_feed
         @klass.parse sample_rss_feed
       end
     end
   end
 
-  describe "strip whitespace" do
-    context "strip_whitespace config is true" do
+  describe "when configured to strip whitespace" do
+    context "when strip_whitespace config is true" do
       it "strips all XML whitespace" do
         Feedjira.configure { |config| config.strip_whitespace = true }
 
@@ -39,7 +39,7 @@ describe Feedjira::FeedUtilities do
       end
     end
 
-    context "strip_whitespace config is false" do
+    context "when strip_whitespace is configured false" do
       it "lstrips XML whitespace" do
         expect(@klass.strip_whitespace("\nfoobar\n")).to eq("foobar\n")
       end
@@ -47,27 +47,27 @@ describe Feedjira::FeedUtilities do
   end
 
   describe "instance methods" do
-    it "should provide an updated? accessor" do
+    it "provides an updated? accessor" do
       feed = @klass.new
-      expect(feed).to_not be_updated
+      expect(feed).not_to be_updated
       feed.updated = true
       expect(feed).to be_updated
     end
 
-    it "should provide a new_entries accessor" do
+    it "provides a new_entries accessor" do
       feed = @klass.new
       expect(feed.new_entries).to eq []
       feed.new_entries = [:foo]
       expect(feed.new_entries).to eq [:foo]
     end
 
-    it "should provide an etag accessor" do
+    it "provides an etag accessor" do
       feed = @klass.new
       feed.etag = "foo"
       expect(feed.etag).to eq "foo"
     end
 
-    it "should provide a last_modified accessor" do
+    it "provides a last_modified accessor" do
       feed = @klass.new
       time = Time.now
       feed.last_modified = time
@@ -75,13 +75,13 @@ describe Feedjira::FeedUtilities do
       expect(feed.last_modified.class).to eq Time
     end
 
-    it "should return new_entries? as true when entries are put into new_entries" do
+    it "returns new_entries? as true when entries are put into new_entries" do
       feed = @klass.new
       feed.new_entries << :foo
-      expect(feed.new_entries?).to eq true
+      expect(feed.new_entries?).to be true
     end
 
-    it "should return a last_modified value from the entry with the most recent published date if the last_modified date hasn't been set" do
+    it "returns a last_modified value from the entry with the most recent published date if the last_modified date hasn't been set" do
       feed = Feedjira::Parser::Atom.new
       entry = Feedjira::Parser::AtomEntry.new
       entry.published = Time.now.to_s
@@ -89,7 +89,7 @@ describe Feedjira::FeedUtilities do
       expect(feed.last_modified).to eq entry.published
     end
 
-    it "should not throw an error if one of the entries has published date of nil" do
+    it "does not throw an error if one of the entries has published date of nil" do
       feed = Feedjira::Parser::Atom.new
       entry = Feedjira::Parser::AtomEntry.new
       entry.published = Time.now.to_s
@@ -101,7 +101,7 @@ describe Feedjira::FeedUtilities do
 
   describe "#update_from_feed" do
     describe "updating feed attributes" do
-      before(:each) do
+      before do
         # I'm using the Atom class when I know I should be using a different
         # one. However, this update_from_feed method would only be called
         # against a feed item.
@@ -113,44 +113,39 @@ describe Feedjira::FeedUtilities do
         @updated_feed = @feed.dup
       end
 
-      it "should update the title if changed" do
+      it "updates the title if changed" do
         @updated_feed.title = "new title"
         @feed.update_from_feed(@updated_feed)
         expect(@feed.title).to eq @updated_feed.title
         expect(@feed).to be_updated
       end
 
-      it "should not update the title if the same" do
+      it "does not update the title if the same" do
         @feed.update_from_feed(@updated_feed)
-        expect(@feed).to_not be_updated
+        expect(@feed).not_to be_updated
       end
 
-      it "should update the feed_url if changed" do
+      it "updates the feed_url if changed" do
         @updated_feed.feed_url = "a new feed url"
         @feed.update_from_feed(@updated_feed)
         expect(@feed.feed_url).to eq @updated_feed.feed_url
         expect(@feed).to be_updated
       end
 
-      it "should not update the feed_url if the same" do
-        @feed.update_from_feed(@updated_feed)
-        expect(@feed).to_not be_updated
-      end
-
-      it "should update the url if changed" do
+      it "updates the url if changed" do
         @updated_feed.url = "a new url"
         @feed.update_from_feed(@updated_feed)
         expect(@feed.url).to eq @updated_feed.url
       end
 
-      it "should not update the url if not changed" do
+      it "does not update the url if not changed" do
         @feed.update_from_feed(@updated_feed)
-        expect(@feed).to_not be_updated
+        expect(@feed).not_to be_updated
       end
     end
 
     describe "updating entries" do
-      before(:each) do
+      before do
         # I'm using the Atom class when I know I should be using a different
         # one. However, this update_from_feed method would only be called
         # against a feed item.
@@ -173,17 +168,17 @@ describe Feedjira::FeedUtilities do
         @updated_feed.entries << @old_entry
       end
 
-      it "should update last-modified from the latest entry date" do
+      it "updates last-modified from the latest entry date" do
         @feed.update_from_feed(@updated_feed)
         expect(@feed.last_modified).to eq @new_entry.published
       end
 
-      it "should put new entries into new_entries" do
+      it "puts new entries into new_entries" do
         @feed.update_from_feed(@updated_feed)
         expect(@feed.new_entries).to eq [@new_entry]
       end
 
-      it "should also put new entries into the entries collection" do
+      it "alsoes put new entries into the entries collection" do
         @feed.update_from_feed(@updated_feed)
         expect(@feed.entries).to include(@new_entry)
         expect(@feed.entries).to include(@old_entry)
@@ -194,7 +189,7 @@ describe Feedjira::FeedUtilities do
       let(:recent_entry_id) { "entry_id" }
       let(:old_entry_id) { nil }
 
-      before(:each) do
+      before do
         # I'm using the Atom class when I know I should be using a different
         # one. However, this update_from_feed method would only be called
         # against a feed item.
@@ -226,26 +221,26 @@ describe Feedjira::FeedUtilities do
         @updated_feed.entries << @old_entry
       end
 
-      context "changing the url of an existing entry" do
-        it "should not put the complete feed into new_entries" do
+      context "when changing the url of an existing entry" do
+        it "does not put the complete feed into new_entries" do
           @feed.update_from_feed(@updated_feed)
-          expect(@feed.new_entries).to_not include(@entry_changed_url)
-          expect(@feed.new_entries).to_not include(@old_entry)
+          expect(@feed.new_entries).not_to include(@entry_changed_url)
+          expect(@feed.new_entries).not_to include(@old_entry)
           expect(@feed.new_entries.size).to eq 0
-          expect(@feed.new_entries.size).to_not eq 2
+          expect(@feed.new_entries.size).not_to eq 2
         end
       end
 
-      context "feed not have entry id and only difference is a url" do
+      context "when feed does not have entry id and only difference is a url" do
         let(:recent_entry_id) { nil }
         let(:old_entry_id) { nil }
 
-        it "should put the complete feed into new_entries" do
+        it "puts the complete feed into new_entries" do
           @feed.update_from_feed(@updated_feed)
           expect(@feed.new_entries).to include(@entry_changed_url)
           expect(@feed.new_entries).to include(@old_entry)
           expect(@feed.new_entries.size).to eq 2
-          expect(@feed.new_entries.size).to_not eq 0
+          expect(@feed.new_entries.size).not_to eq 0
         end
       end
     end

data/spec/feedjira/parser/atom_entry_spec.rb

@@ -3,64 +3,64 @@
 require "spec_helper"
 
 describe Feedjira::Parser::AtomEntry do
-  before(:each) do
+  before do
     # I don't really like doing it this way because these unit test should only
     # rely on AtomEntry, but this is actually how it should work. You would
     # never just pass entry xml straight to the AtomEnry
     @entry = Feedjira::Parser::Atom.parse(sample_atom_feed).entries.first
   end
 
-  it "should parse the title" do
+  it "parses the title" do
     title = "AWS Job: Architect & Designer Position in Turkey"
     expect(@entry.title).to eq title
   end
 
-  it "should parse the url" do
+  it "parses the url" do
     expect(@entry.url).to eq "http://aws.typepad.com/aws/2009/01/aws-job-architect-designer-position-in-turkey.html"
   end
 
-  it "should parse the url even when" do
+  it "parses the url even when" do
     xml = load_sample("atom_with_link_tag_for_url_unmarked.xml")
     entries = Feedjira::Parser::Atom.parse(xml).entries
     expect(entries.first.url).to eq "http://www.innoq.com/blog/phaus/2009/07/ja.html"
   end
 
-  it "should parse the author" do
+  it "parses the author" do
     expect(@entry.author).to eq "AWS Editor"
   end
 
-  it "should parse the content" do
+  it "parses the content" do
     expect(@entry.content).to eq sample_atom_entry_content
   end
 
-  it "should provide a summary" do
+  it "provides a summary" do
     summary = "Late last year an entrepreneur from Turkey visited me at Amazon HQ in Seattle. We talked about his plans to use AWS as part of his new social video portal startup. I won't spill any beans before he's ready to..."
     expect(@entry.summary).to eq summary
   end
 
-  it "should parse the published date" do
+  it "parses the published date" do
     published = Time.parse_safely "Fri Jan 16 18:21:00 UTC 2009"
     expect(@entry.published).to eq published
   end
 
-  it "should parse the categories" do
+  it "parses the categories" do
     expect(@entry.categories).to eq %w[Turkey Seattle]
   end
 
-  it "should parse the updated date" do
+  it "parses the updated date" do
     updated = Time.parse_safely "Fri Jan 16 18:21:00 UTC 2009"
     expect(@entry.updated).to eq updated
   end
 
-  it "should parse the id" do
+  it "parses the id" do
     expect(@entry.id).to eq "tag:typepad.com,2003:post-61484736"
   end
 
-  it "should support each" do
+  it "supports each" do
     expect(@entry).to respond_to :each
   end
 
-  it "should be able to list out all fields with each" do
+  it "is able to list out all fields with each" do
     all_fields = []
     title_value = ""
 
@@ -87,18 +87,18 @@ describe Feedjira::Parser::AtomEntry do
     expect(all_fields.sort).to eq expected_fields
   end
 
-  it "should support checking if a field exists in the entry" do
+  it "supports checking if a field exists in the entry" do
     expect(@entry).to include "author"
     expect(@entry).to include "title"
   end
 
-  it "should allow access to fields with hash syntax" do
+  it "allows access to fields with hash syntax" do
     title = "AWS Job: Architect & Designer Position in Turkey"
     expect(@entry["title"]).to eq title
     expect(@entry["author"]).to eq "AWS Editor"
   end
 
-  it "should allow setting field values with hash syntax" do
+  it "allows setting field values with hash syntax" do
     @entry["title"] = "Foobar"
     expect(@entry.title).to eq "Foobar"
   end

data/spec/feedjira/parser/atom_feed_burner_entry_spec.rb

@@ -3,7 +3,7 @@
 require "spec_helper"
 
 describe Feedjira::Parser::AtomFeedBurnerEntry do
-  before(:each) do
+  before do
     Feedjira::Parser::AtomFeedBurner.preprocess_xml = false
     # I don't really like doing it this way because these unit test should only
     # rely on AtomEntry, but this is actually how it should work. You would
@@ -12,45 +12,45 @@ describe Feedjira::Parser::AtomFeedBurnerEntry do
     @entry = feed.entries.first
   end
 
-  it "should parse the title" do
+  it "parses the title" do
     expect(@entry.title).to eq "Making a Ruby C library even faster"
   end
 
-  it "should be able to fetch a url via the 'alternate' rel if no origLink exists" do
+  it "is able to fetch a url via the 'alternate' rel if no origLink exists" do
     xml = File.read("#{File.dirname(__FILE__)}/../../sample_feeds/PaulDixExplainsNothingAlternate.xml")
     entry = Feedjira::Parser::AtomFeedBurner.parse(xml).entries.first
     expect(entry.url).to eq("http://feeds.feedburner.com/~r/PaulDixExplainsNothing/~3/519925023/making-a-ruby-c-library-even-faster.html")
   end
 
-  it "should parse the url" do
+  it "parses the url" do
     expect(@entry.url).to eq "http://www.pauldix.net/2009/01/making-a-ruby-c-library-even-faster.html"
   end
 
-  it "should parse the url when there is no alternate" do
+  it "parses the url when there is no alternate" do
     xml = File.read("#{File.dirname(__FILE__)}/../../sample_feeds/FeedBurnerUrlNoAlternate.xml")
     entry = Feedjira::Parser::AtomFeedBurner.parse(xml).entries.first
     expect(entry.url).to eq "http://example.com/QQQQ.html"
   end
 
-  it "should parse the author" do
+  it "parses the author" do
     expect(@entry.author).to eq "Paul Dix"
   end
 
-  it "should parse the content" do
+  it "parses the content" do
     expect(@entry.content).to eq sample_feedburner_atom_entry_content
   end
 
-  it "should provide a summary" do
+  it "provides a summary" do
     summary = "Last week I released the first version of a SAX based XML parsing library called SAX-Machine. It uses Nokogiri, which uses libxml, so it's pretty fast. However, I felt that it could be even faster. The only question was how..."
     expect(@entry.summary).to eq summary
   end
 
-  it "should parse the published date" do
+  it "parses the published date" do
     published = Time.parse_safely "Thu Jan 22 15:50:22 UTC 2009"
     expect(@entry.published).to eq published
   end
 
-  it "should parse the categories" do
+  it "parses the categories" do
     expect(@entry.categories).to eq ["Ruby", "Another Category"]
   end
 end

data/spec/feedjira/parser/atom_feed_burner_spec.rb

@@ -5,66 +5,66 @@ require "spec_helper"
 module Feedjira
   module Parser
     describe "#will_parse?" do
-      it "should return true for a feedburner atom feed" do
+      it "returns true for a feedburner atom feed" do
         expect(AtomFeedBurner).to be_able_to_parse(sample_feedburner_atom_feed)
       end
 
-      it "should return false for an rdf feed" do
-        expect(AtomFeedBurner).to_not be_able_to_parse(sample_rdf_feed)
+      it "returns false for an rdf feed" do
+        expect(AtomFeedBurner).not_to be_able_to_parse(sample_rdf_feed)
       end
 
-      it "should return false for a regular atom feed" do
-        expect(AtomFeedBurner).to_not be_able_to_parse(sample_atom_feed)
+      it "returns false for a regular atom feed" do
+        expect(AtomFeedBurner).not_to be_able_to_parse(sample_atom_feed)
       end
 
-      it "should return false for an rss feedburner feed" do
-        expect(AtomFeedBurner).to_not be_able_to_parse sample_rss_feed_burner_feed
+      it "returns false for an rss feedburner feed" do
+        expect(AtomFeedBurner).not_to be_able_to_parse sample_rss_feed_burner_feed
       end
     end
 
     describe "parsing old style feeds" do
-      before(:each) do
+      before do
         @feed = AtomFeedBurner.parse(sample_feedburner_atom_feed)
       end
 
-      it "should parse the title" do
+      it "parses the title" do
         expect(@feed.title).to eq "Paul Dix Explains Nothing"
       end
 
-      it "should parse the description" do
+      it "parses the description" do
         description = "Entrepreneurship, programming, software development, politics, NYC, and random thoughts."
         expect(@feed.description).to eq description
       end
 
-      it "should parse the url" do
+      it "parses the url" do
         expect(@feed.url).to eq "http://www.pauldix.net/"
       end
 
-      it "should parse the feed_url" do
+      it "parses the feed_url" do
         expect(@feed.feed_url).to eq "http://feeds.feedburner.com/PaulDixExplainsNothing"
       end
 
-      it "should parse no hub urls" do
+      it "parses no hub urls" do
         expect(@feed.hubs.count).to eq 0
       end
 
-      it "should parse hub urls" do
+      it "parses hub urls" do
         AtomFeedBurner.preprocess_xml = false
         feed_with_hub = AtomFeedBurner.parse(load_sample("TypePadNews.xml"))
         expect(feed_with_hub.hubs.count).to eq 1
       end
 
-      it "should parse entries" do
+      it "parses entries" do
         expect(@feed.entries.size).to eq 5
       end
 
-      it "should change url" do
+      it "changes url" do
         new_url = "http://some.url.com"
         expect { @feed.url = new_url }.not_to raise_error
         expect(@feed.url).to eq new_url
       end
 
-      it "should change feed_url" do
+      it "changes feed_url" do
         new_url = "http://some.url.com"
         expect { @feed.feed_url = new_url }.not_to raise_error
         expect(@feed.feed_url).to eq new_url
@@ -72,42 +72,42 @@ module Feedjira
     end
 
     describe "parsing alternate style feeds" do
-      before(:each) do
+      before do
         @feed = AtomFeedBurner.parse(sample_feedburner_atom_feed_alternate)
       end
 
-      it "should parse the title" do
+      it "parses the title" do
         expect(@feed.title).to eq "Giant Robots Smashing Into Other Giant Robots"
       end
 
-      it "should parse the description" do
+      it "parses the description" do
         description = "Written by thoughtbot"
         expect(@feed.description).to eq description
       end
 
-      it "should parse the url" do
+      it "parses the url" do
         expect(@feed.url).to eq "https://robots.thoughtbot.com"
       end
 
-      it "should parse the feed_url" do
+      it "parses the feed_url" do
         expect(@feed.feed_url).to eq "http://feeds.feedburner.com/GiantRobotsSmashingIntoOtherGiantRobots"
       end
 
-      it "should parse hub urls" do
+      it "parses hub urls" do
         expect(@feed.hubs.count).to eq 1
       end
 
-      it "should parse entries" do
+      it "parses entries" do
         expect(@feed.entries.size).to eq 3
       end
 
-      it "should change url" do
+      it "changes url" do
         new_url = "http://some.url.com"
         expect { @feed.url = new_url }.not_to raise_error
         expect(@feed.url).to eq new_url
       end
 
-      it "should change feed_url" do
+      it "changes feed_url" do
         new_url = "http://some.url.com"
         expect { @feed.feed_url = new_url }.not_to raise_error
         expect(@feed.feed_url).to eq new_url

data/spec/feedjira/parser/atom_google_alerts_entry_spec.rb

@@ -3,31 +3,31 @@
 require "spec_helper"
 
 describe Feedjira::Parser::AtomGoogleAlertsEntry do
-  before(:each) do
+  before do
     feed = Feedjira::Parser::AtomGoogleAlerts.parse sample_google_alerts_atom_feed
     @entry = feed.entries.first
   end
 
-  it "should parse the title" do
+  it "parses the title" do
     expect(@entry.title).to eq "Report offers Prediction of Automotive Slack Market by Top key players like Haldex, Meritor, Bendix ..."
     expect(@entry.raw_title).to eq "Report offers Prediction of Automotive <b>Slack</b> Market by Top key players like Haldex, Meritor, Bendix ..."
     expect(@entry.title_type).to eq "html"
   end
 
-  it "should parse the url" do
+  it "parses the url" do
     expect(@entry.url).to eq "https://www.aglobalmarketresearch.com/report-offers-prediction-of-automotive-slack-market-by-top-key-players-like-haldex-meritor-bendix-mei-wabco-accuride-stemco-tbk-febi-aydinsan/"
   end
 
-  it "should parse the content" do
+  it "parses the content" do
     expect(@entry.content).to eq "Automotive <b>Slack</b> Market reports provides a comprehensive overview of the global market size and share. It provides strategists, marketers and senior&nbsp;..."
   end
 
-  it "should parse the published date" do
+  it "parses the published date" do
     published = Time.parse_safely "2019-07-10T11:53:37Z"
     expect(@entry.published).to eq published
   end
 
-  it "should parse the updated date" do
+  it "parses the updated date" do
     updated = Time.parse_safely "2019-07-10T11:53:37Z"
     expect(@entry.updated).to eq updated
   end

data/spec/feedjira/parser/atom_google_alerts_spec.rb

@@ -5,45 +5,45 @@ require "spec_helper"
 module Feedjira
   module Parser
     describe "#able_to_parse?" do
-      it "should return true for a Google Alerts atom feed" do
+      it "returns true for a Google Alerts atom feed" do
         expect(AtomGoogleAlerts).to be_able_to_parse(sample_google_alerts_atom_feed)
       end
 
-      it "should return false for an rdf feed" do
-        expect(AtomGoogleAlerts).to_not be_able_to_parse(sample_rdf_feed)
+      it "returns false for an rdf feed" do
+        expect(AtomGoogleAlerts).not_to be_able_to_parse(sample_rdf_feed)
       end
 
-      it "should return false for a regular atom feed" do
-        expect(AtomGoogleAlerts).to_not be_able_to_parse(sample_atom_feed)
+      it "returns false for a regular atom feed" do
+        expect(AtomGoogleAlerts).not_to be_able_to_parse(sample_atom_feed)
       end
 
-      it "should return false for a feedburner atom feed" do
-        expect(AtomGoogleAlerts).to_not be_able_to_parse(sample_feedburner_atom_feed)
+      it "returns false for a feedburner atom feed" do
+        expect(AtomGoogleAlerts).not_to be_able_to_parse(sample_feedburner_atom_feed)
       end
     end
 
     describe "parsing" do
-      before(:each) do
+      before do
         @feed = AtomGoogleAlerts.parse(sample_google_alerts_atom_feed)
       end
 
-      it "should parse the title" do
+      it "parses the title" do
         expect(@feed.title).to eq "Google Alert - Slack"
       end
 
-      it "should parse the descripton" do
+      it "parses the descripton" do
         expect(@feed.description).to be_nil
       end
 
-      it "should parse the url" do
+      it "parses the url" do
         expect(@feed.url).to eq "https://www.google.com/alerts/feeds/04175468913983673025/4428013283581841004"
       end
 
-      it "should parse the feed_url" do
+      it "parses the feed_url" do
         expect(@feed.feed_url).to eq "https://www.google.com/alerts/feeds/04175468913983673025/4428013283581841004"
       end
 
-      it "should parse entries" do
+      it "parses entries" do
         expect(@feed.entries.size).to eq 20
       end
     end