feedjira 3.2.0 → 3.2.1

data/spec/feedjira/parser/atom_youtube_spec.rb

@@ -4,41 +4,41 @@ require File.join(File.dirname(__FILE__), %w[.. .. spec_helper])
 
 describe Feedjira::Parser::AtomYoutube do
   describe "#will_parse?" do
-    it "should return true for an atom youtube feed" do
-      expect(Feedjira::Parser::AtomYoutube).to be_able_to_parse(sample_youtube_atom_feed)
+    it "returns true for an atom youtube feed" do
+      expect(described_class).to be_able_to_parse(sample_youtube_atom_feed)
     end
 
-    it "should return fase for an atom feed" do
-      expect(Feedjira::Parser::AtomYoutube).to_not be_able_to_parse(sample_atom_feed)
+    it "returns fase for an atom feed" do
+      expect(described_class).not_to be_able_to_parse(sample_atom_feed)
     end
 
-    it "should return false for an rss feedburner feed" do
-      expect(Feedjira::Parser::AtomYoutube).to_not be_able_to_parse(sample_rss_feed_burner_feed)
+    it "returns false for an rss feedburner feed" do
+      expect(described_class).not_to be_able_to_parse(sample_rss_feed_burner_feed)
     end
   end
 
   describe "parsing" do
-    before(:each) do
-      @feed = Feedjira::Parser::AtomYoutube.parse(sample_youtube_atom_feed)
+    before do
+      @feed = described_class.parse(sample_youtube_atom_feed)
     end
 
-    it "should parse the title" do
+    it "parses the title" do
       expect(@feed.title).to eq "Google"
     end
 
-    it "should parse the author" do
+    it "parses the author" do
       expect(@feed.author).to eq "Google Author"
     end
 
-    it "should parse the url" do
+    it "parses the url" do
       expect(@feed.url).to eq "http://www.youtube.com/user/Google"
     end
 
-    it "should parse the feed_url" do
+    it "parses the feed_url" do
       expect(@feed.feed_url).to eq "http://www.youtube.com/feeds/videos.xml?user=google"
     end
 
-    it "should parse the YouTube channel id" do
+    it "parses the YouTube channel id" do
       expect(@feed.youtube_channel_id).to eq "UCK8sQmJBp8GCxrOtXWBpyEA"
     end
   end

data/spec/feedjira/parser/google_docs_atom_entry_spec.rb

@@ -10,15 +10,15 @@ describe Feedjira::Parser::GoogleDocsAtomEntry do
       @entry = @feed.entries.first
     end
 
-    it "should have the custom checksum element" do
+    it "has the custom checksum element" do
       expect(@entry.checksum).to eq "2b01142f7481c7b056c4b410d28f33cf"
     end
 
-    it "should have the custom filename element" do
+    it "has the custom filename element" do
       expect(@entry.original_filename).to eq "MyFile.pdf"
     end
 
-    it "should have the custom suggested filename element" do
+    it "has the custom suggested filename element" do
       expect(@entry.suggested_filename).to eq "TaxDocument.pdf"
     end
   end

data/spec/feedjira/parser/google_docs_atom_spec.rb

@@ -5,12 +5,12 @@ require "spec_helper"
 module Feedjira
   module Parser
     describe ".able_to_parser?" do
-      it "should return true for Google Docs feed" do
+      it "returns true for Google Docs feed" do
         expect(GoogleDocsAtom).to be_able_to_parse(sample_google_docs_list_feed)
       end
 
-      it "should not be able to parse another Atom feed" do
-        expect(GoogleDocsAtom).to_not be_able_to_parse(sample_atom_feed)
+      it "is not able to parse another Atom feed" do
+        expect(GoogleDocsAtom).not_to be_able_to_parse(sample_atom_feed)
       end
     end
 
@@ -19,15 +19,15 @@ module Feedjira
         @feed = GoogleDocsAtom.parse(sample_google_docs_list_feed)
       end
 
-      it "should return a bunch of objects" do
-        expect(@feed.entries).to_not be_empty
+      it "returns a bunch of objects" do
+        expect(@feed.entries).not_to be_empty
       end
 
-      it "should populate a title, interhited from the Atom entry" do
-        expect(@feed.title).to_not be_nil
+      it "populates a title, interhited from the Atom entry" do
+        expect(@feed.title).not_to be_nil
       end
 
-      it "should return a bunch of entries of type GoogleDocsAtomEntry" do
+      it "returns a bunch of entries of type GoogleDocsAtomEntry" do
         expect(@feed.entries.first).to be_a GoogleDocsAtomEntry
       end
     end

data/spec/feedjira/parser/{itunes_rss_item_spec.rb → i_tunes_rss_item_spec.rb}

@@ -3,82 +3,82 @@
 require "spec_helper"
 
 describe Feedjira::Parser::ITunesRSSItem do
-  before(:each) do
+  before do
     # I don't really like doing it this way because these unit test should only
     # rely on ITunesRssItem, but this is actually how it should work. You would
     # never just pass entry xml straight to the ITunesRssItem
     @item = Feedjira::Parser::ITunesRSS.parse(sample_itunes_feed).entries.first
   end
 
-  it "should parse the title" do
+  it "parses the title" do
     expect(@item.title).to eq "Shake Shake Shake Your Spices"
   end
 
-  it "should parse the itunes title" do
+  it "parses the itunes title" do
     expect(@item.itunes_title).to eq "Shake Shake Shake Your Spices"
   end
 
-  it "should parse the author" do
+  it "parses the author" do
     expect(@item.itunes_author).to eq "John Doe"
   end
 
-  it "should parse the subtitle" do
+  it "parses the subtitle" do
     expect(@item.itunes_subtitle).to eq "A short primer on table spices"
   end
 
-  it "should parse the summary" do
+  it "parses the summary" do
     summary = "This week we talk about salt and pepper shakers, comparing and contrasting pour rates, construction materials, and overall aesthetics. Come and join the party!"
     expect(@item.itunes_summary).to eq summary
   end
 
-  it "should parse the itunes season" do
+  it "parses the itunes season" do
     expect(@item.itunes_season).to eq "1"
   end
 
-  it "should parse the itunes episode number" do
+  it "parses the itunes episode number" do
     expect(@item.itunes_episode).to eq "3"
   end
 
-  it "should parse the itunes episode type" do
+  it "parses the itunes episode type" do
     expect(@item.itunes_episode_type).to eq "full"
   end
 
-  it "should parse the enclosure" do
+  it "parses the enclosure" do
     expect(@item.enclosure_length).to eq "8727310"
     expect(@item.enclosure_type).to eq "audio/x-m4a"
     expect(@item.enclosure_url).to eq "http://example.com/podcasts/everything/AllAboutEverythingEpisode3.m4a"
   end
 
-  it "should parse the guid as id" do
+  it "parses the guid as id" do
     expect(@item.id).to eq "http://example.com/podcasts/archive/aae20050615.m4a"
   end
 
-  it "should parse the published date" do
+  it "parses the published date" do
     published = Time.parse_safely "Wed Jun 15 19:00:00 UTC 2005"
     expect(@item.published).to eq published
   end
 
-  it "should parse the duration" do
+  it "parses the duration" do
     expect(@item.itunes_duration).to eq "7:04"
   end
 
-  it "should parse the keywords" do
+  it "parses the keywords" do
     expect(@item.itunes_keywords).to eq "salt, pepper, shaker, exciting"
   end
 
-  it "should parse the image" do
+  it "parses the image" do
     expect(@item.itunes_image).to eq "http://example.com/podcasts/everything/AllAboutEverything.jpg"
   end
 
-  it "should parse the order" do
+  it "parses the order" do
     expect(@item.itunes_order).to eq "12"
   end
 
-  it "should parse the closed captioned flag" do
+  it "parses the closed captioned flag" do
     expect(@item.itunes_closed_captioned).to eq "yes"
   end
 
-  it "should parse the encoded content" do
+  it "parses the encoded content" do
     content = "<p><strong>TOPIC</strong>: Gooseneck Options</p>"
     expect(@item.content).to eq content
   end

data/spec/feedjira/parser/{itunes_rss_owner_spec.rb → i_tunes_rss_owner_spec.rb}

@@ -3,7 +3,7 @@
 require "spec_helper"
 
 describe Feedjira::Parser::ITunesRSSOwner do
-  before(:each) do
+  before do
     # I don't really like doing it this way because these unit test should only
     # rely on RSSEntry, but this is actually how it should work. You would
     # never just pass entry xml straight to the ITunesRssOwner
@@ -11,11 +11,11 @@ describe Feedjira::Parser::ITunesRSSOwner do
     @owner = feed.itunes_owners.first
   end
 
-  it "should parse the name" do
+  it "parses the name" do
     expect(@owner.name).to eq "John Doe"
   end
 
-  it "should parse the email" do
+  it "parses the email" do
     expect(@owner.email).to eq "john.doe@example.com"
   end
 end

data/spec/feedjira/parser/itunes_rss_spec.rb

@@ -5,82 +5,82 @@ require "spec_helper"
 module Feedjira
   module Parser
     describe "#will_parse?" do
-      it "should return true for an itunes RSS feed" do
+      it "returns true for an itunes RSS feed" do
         expect(ITunesRSS).to be_able_to_parse(sample_itunes_feed)
       end
 
-      it "should return true for an itunes RSS feed with spaces between attribute names, equals sign, and values" do
+      it "returns true for an itunes RSS feed with spaces between attribute names, equals sign, and values" do
         expect(ITunesRSS).to be_able_to_parse(sample_itunes_feed_with_spaces)
       end
 
-      it "should return true for an itunes RSS feed with single-quoted attributes" do
+      it "returns true for an itunes RSS feed with single-quoted attributes" do
         expect(ITunesRSS).to be_able_to_parse(sample_itunes_feed_with_single_quotes)
       end
 
-      it "should return fase for an atom feed" do
-        expect(ITunesRSS).to_not be_able_to_parse(sample_atom_feed)
+      it "returns fase for an atom feed" do
+        expect(ITunesRSS).not_to be_able_to_parse(sample_atom_feed)
       end
 
-      it "should return false for an rss feedburner feed" do
-        expect(ITunesRSS).to_not be_able_to_parse(sample_rss_feed_burner_feed)
+      it "returns false for an rss feedburner feed" do
+        expect(ITunesRSS).not_to be_able_to_parse(sample_rss_feed_burner_feed)
       end
     end
 
     describe "parsing" do
-      before(:each) do
+      before do
         @feed = ITunesRSS.parse(sample_itunes_feed)
       end
 
-      it "should parse the ttl" do
+      it "parses the ttl" do
         expect(@feed.ttl).to eq "60"
       end
 
-      it "should parse the last build date" do
+      it "parses the last build date" do
         expect(@feed.last_built).to eq "Sat, 07 Sep 2002 09:42:31 GMT"
       end
 
-      it "should parse the subtitle" do
+      it "parses the subtitle" do
         expect(@feed.itunes_subtitle).to eq "A show about everything"
       end
 
-      it "should parse the author" do
+      it "parses the author" do
         expect(@feed.itunes_author).to eq "John Doe"
       end
 
-      it "should parse an owner" do
+      it "parses an owner" do
         expect(@feed.itunes_owners.size).to eq 1
       end
 
-      it "should parse an image" do
+      it "parses an image" do
         expect(@feed.itunes_image).to eq "http://example.com/podcasts/everything/AllAboutEverything.jpg"
       end
 
-      it "should parse the image url" do
+      it "parses the image url" do
         expect(@feed.image.url).to eq "http://example.com/podcasts/everything/AllAboutEverything.jpg"
       end
 
-      it "should parse the image title" do
+      it "parses the image title" do
         expect(@feed.image.title).to eq "All About Everything"
       end
 
-      it "should parse the image link" do
+      it "parses the image link" do
         expect(@feed.image.link).to eq "http://www.example.com/podcasts/everything/index.html"
       end
 
-      it "should parse the image width" do
+      it "parses the image width" do
         expect(@feed.image.width).to eq "88"
       end
 
-      it "should parse the image height" do
+      it "parses the image height" do
         expect(@feed.image.height).to eq "31"
       end
 
-      it "should parse the image description" do
+      it "parses the image description" do
         description = "All About Everything is a show about everything. Each week we dive into any subject known to man and talk about it as much as we can. Look for our Podcast in the iTunes Music Store"
         expect(@feed.image.description).to eq description
       end
 
-      it "should parse categories" do
+      it "parses categories" do
         expect(@feed.itunes_categories).to eq [
           "Technology",
           "Gadgets",
@@ -98,24 +98,24 @@ module Feedjira
         ]
       end
 
-      it "should parse the itunes type" do
+      it "parses the itunes type" do
         expect(@feed.itunes_type).to eq "episodic"
       end
 
-      it "should parse the summary" do
+      it "parses the summary" do
         summary = "All About Everything is a show about everything. Each week we dive into any subject known to man and talk about it as much as we can. Look for our Podcast in the iTunes Music Store"
         expect(@feed.itunes_summary).to eq summary
       end
 
-      it "should parse the complete tag" do
+      it "parses the complete tag" do
         expect(@feed.itunes_complete).to eq "yes"
       end
 
-      it "should parse entries" do
+      it "parses entries" do
         expect(@feed.entries.size).to eq 3
       end
 
-      it "should parse the new-feed-url" do
+      it "parses the new-feed-url" do
         expect(@feed.itunes_new_feed_url).to eq "http://example.com/new.xml"
       end
     end

data/spec/feedjira/parser/json_feed_item_spec.rb

@@ -3,40 +3,40 @@
 require "spec_helper"
 
 describe Feedjira::Parser::JSONFeedItem do
-  before(:each) do
+  before do
     # I don't really like doing it this way because these unit test should only
     # rely on JSONFeed, but this is actually how it should work. You would
     # never just pass entry json straight to the JSONFeedItem
     @entry = Feedjira::Parser::JSONFeed.parse(sample_json_feed).entries.first
   end
 
-  it "should parse the id" do
+  it "parses the id" do
     expect(@entry.id).to eq "http://inessential.com/2017/06/02/james_dempsey_and_the_breakpoints_benefi"
   end
 
-  it "should parse the url" do
+  it "parses the url" do
     expect(@entry.url).to eq "http://inessential.com/2017/06/02/james_dempsey_and_the_breakpoints_benefi"
   end
 
-  it "should parse the title" do
+  it "parses the title" do
     expect(@entry.title).to eq "James Dempsey and the Breakpoints Benefit App Camp for Girls"
   end
 
-  it "should parse the content" do
+  it "parses the content" do
     content = "<p>On Wednesday night I know where I’ll be — playing keyboard for a few songs at the James Dempsey and the Breakpoints concert benefitting App Camp for Girls.</p>\n\n<p><a href=\"https://www.classy.org/events/-/e126329\">You should get tickets</a>. It’s a fun time for a great cause.</p>\n\n<p>Bonus: James writes about how <a href=\"http://jamesdempsey.net/2017/06/02/wwdc-in-san-jose-full-circle/\">this concert is full circle for him</a>. It’s a special night.</p>"
     expect(@entry.content).to eq content
   end
 
-  it "should parse the published date" do
+  it "parses the published date" do
     published = Time.parse_safely "2017-06-02T22:05:47-07:00"
     expect(@entry.published).to eq published
   end
 
-  it "should support each" do
+  it "supports each" do
     expect(@entry).to respond_to :each
   end
 
-  it "should be able to list out all the fields with each" do
+  it "is able to list out all the fields with each" do
     all_fields = []
     title_value = ""
     @entry.each do |field, value|
@@ -64,17 +64,17 @@ describe Feedjira::Parser::JSONFeedItem do
     expect(all_fields).to match_array expected_fields
   end
 
-  it "should support checking if a field exists in the entry" do
+  it "supports checking if a field exists in the entry" do
     expect(@entry).to include "title"
     expect(@entry).to include "url"
   end
 
-  it "should allow access to fields with hash syntax" do
+  it "allows access to fields with hash syntax" do
     expect(@entry["title"]).to eq "James Dempsey and the Breakpoints Benefit App Camp for Girls"
     expect(@entry["url"]).to eq "http://inessential.com/2017/06/02/james_dempsey_and_the_breakpoints_benefi"
   end
 
-  it "should allow setting field values with hash syntax" do
+  it "allows setting field values with hash syntax" do
     @entry["title"] = "Foobar"
     expect(@entry.title).to eq "Foobar"
   end

data/spec/feedjira/parser/json_feed_spec.rb

@@ -5,49 +5,49 @@ require "spec_helper"
 module Feedjira
   module Parser
     describe ".able_to_parse?" do
-      it "should return true for a JSON feed" do
+      it "returns true for a JSON feed" do
         expect(JSONFeed).to be_able_to_parse(sample_json_feed)
       end
 
-      it "should return false for an RSS feed" do
-        expect(JSONFeed).to_not be_able_to_parse(sample_rss_feed)
+      it "returns false for an RSS feed" do
+        expect(JSONFeed).not_to be_able_to_parse(sample_rss_feed)
       end
 
-      it "should return false for an Atom feed" do
-        expect(JSONFeed).to_not be_able_to_parse(sample_atom_feed)
+      it "returns false for an Atom feed" do
+        expect(JSONFeed).not_to be_able_to_parse(sample_atom_feed)
       end
     end
 
     describe "parsing" do
-      before(:each) do
+      before do
         @feed = JSONFeed.parse(sample_json_feed)
       end
 
-      it "should parse the version" do
+      it "parses the version" do
         expect(@feed.version).to eq "https://jsonfeed.org/version/1"
       end
 
-      it "should parse the title" do
+      it "parses the title" do
         expect(@feed.title).to eq "inessential.com"
       end
 
-      it "should parse the url" do
+      it "parses the url" do
         expect(@feed.url).to eq "http://inessential.com/"
       end
 
-      it "should parse the feed_url" do
+      it "parses the feed_url" do
         expect(@feed.feed_url).to eq "http://inessential.com/feed.json"
       end
 
-      it "should parse the description" do
+      it "parses the description" do
         expect(@feed.description).to eq "Brent Simmons’s weblog."
       end
 
-      it "should parse expired and return default (nil)" do
+      it "parses expired and return default (nil)" do
         expect(@feed.expired).to be nil
       end
 
-      it "should parse entries" do
+      it "parses entries" do
         expect(@feed.entries.size).to eq 20
       end
     end

data/spec/feedjira/parser/podlove_chapter_spec.rb

@@ -3,20 +3,20 @@
 require "spec_helper"
 
 describe Feedjira::Parser::PodloveChapter do
-  before(:each) do
+  before do
     @item = Feedjira::Parser::ITunesRSS.parse(sample_podlove_feed).entries.first
     @chapter = @item.chapters.first
   end
 
-  it "should parse chapters" do
+  it "parses chapters" do
     expect(@item.chapters.size).to eq 15
   end
 
-  it "should sort chapters by time" do
+  it "sorts chapters by time" do
     expect(@item.chapters.last.title).to eq "Abschied"
   end
 
-  it "should parse the start time" do
+  it "parses the start time" do
     expect(@chapter.start_ntp).to eq "00:00:26.407"
     expect(@chapter.start).to eq 26.407
     expect(@item.chapters[1].start).to eq 50
@@ -25,15 +25,15 @@ describe Feedjira::Parser::PodloveChapter do
     expect(@item.chapters.last.start).to eq 5700.034
   end
 
-  it "should parse the title" do
+  it "parses the title" do
     expect(@chapter.title).to eq "Neil DeGrasse Tyson on Science"
   end
 
-  it "should parse the link" do
+  it "parses the link" do
     expect(@chapter.url).to eq "https://example.com"
   end
 
-  it "should parse the image" do
+  it "parses the image" do
     expect(@chapter.image).to eq "https://pics.example.com/pic.png"
   end
 end