feedjira 3.2.0 → 3.2.1

data/spec/feedjira/parser/atom_entry_spec.rb

@@ -3,64 +3,64 @@
 require "spec_helper"
 
 describe Feedjira::Parser::AtomEntry do
-  before(:each) do
+  before do
     # I don't really like doing it this way because these unit test should only
     # rely on AtomEntry, but this is actually how it should work. You would
     # never just pass entry xml straight to the AtomEnry
     @entry = Feedjira::Parser::Atom.parse(sample_atom_feed).entries.first
   end
 
-  it "should parse the title" do
+  it "parses the title" do
     title = "AWS Job: Architect & Designer Position in Turkey"
     expect(@entry.title).to eq title
   end
 
-  it "should parse the url" do
+  it "parses the url" do
     expect(@entry.url).to eq "http://aws.typepad.com/aws/2009/01/aws-job-architect-designer-position-in-turkey.html"
   end
 
-  it "should parse the url even when" do
+  it "parses the url even when" do
     xml = load_sample("atom_with_link_tag_for_url_unmarked.xml")
     entries = Feedjira::Parser::Atom.parse(xml).entries
     expect(entries.first.url).to eq "http://www.innoq.com/blog/phaus/2009/07/ja.html"
   end
 
-  it "should parse the author" do
+  it "parses the author" do
     expect(@entry.author).to eq "AWS Editor"
   end
 
-  it "should parse the content" do
+  it "parses the content" do
     expect(@entry.content).to eq sample_atom_entry_content
   end
 
-  it "should provide a summary" do
+  it "provides a summary" do
     summary = "Late last year an entrepreneur from Turkey visited me at Amazon HQ in Seattle. We talked about his plans to use AWS as part of his new social video portal startup. I won't spill any beans before he's ready to..."
     expect(@entry.summary).to eq summary
   end
 
-  it "should parse the published date" do
+  it "parses the published date" do
     published = Time.parse_safely "Fri Jan 16 18:21:00 UTC 2009"
     expect(@entry.published).to eq published
   end
 
-  it "should parse the categories" do
+  it "parses the categories" do
     expect(@entry.categories).to eq %w[Turkey Seattle]
   end
 
-  it "should parse the updated date" do
+  it "parses the updated date" do
     updated = Time.parse_safely "Fri Jan 16 18:21:00 UTC 2009"
     expect(@entry.updated).to eq updated
   end
 
-  it "should parse the id" do
+  it "parses the id" do
     expect(@entry.id).to eq "tag:typepad.com,2003:post-61484736"
   end
 
-  it "should support each" do
+  it "supports each" do
     expect(@entry).to respond_to :each
   end
 
-  it "should be able to list out all fields with each" do
+  it "is able to list out all fields with each" do
     all_fields = []
     title_value = ""
 
@@ -87,18 +87,18 @@ describe Feedjira::Parser::AtomEntry do
     expect(all_fields.sort).to eq expected_fields
   end
 
-  it "should support checking if a field exists in the entry" do
+  it "supports checking if a field exists in the entry" do
     expect(@entry).to include "author"
     expect(@entry).to include "title"
   end
 
-  it "should allow access to fields with hash syntax" do
+  it "allows access to fields with hash syntax" do
     title = "AWS Job: Architect & Designer Position in Turkey"
     expect(@entry["title"]).to eq title
     expect(@entry["author"]).to eq "AWS Editor"
   end
 
-  it "should allow setting field values with hash syntax" do
+  it "allows setting field values with hash syntax" do
     @entry["title"] = "Foobar"
     expect(@entry.title).to eq "Foobar"
   end

data/spec/feedjira/parser/atom_feed_burner_entry_spec.rb

@@ -3,7 +3,7 @@
 require "spec_helper"
 
 describe Feedjira::Parser::AtomFeedBurnerEntry do
-  before(:each) do
+  before do
     Feedjira::Parser::AtomFeedBurner.preprocess_xml = false
     # I don't really like doing it this way because these unit test should only
     # rely on AtomEntry, but this is actually how it should work. You would
@@ -12,45 +12,45 @@ describe Feedjira::Parser::AtomFeedBurnerEntry do
     @entry = feed.entries.first
   end
 
-  it "should parse the title" do
+  it "parses the title" do
     expect(@entry.title).to eq "Making a Ruby C library even faster"
   end
 
-  it "should be able to fetch a url via the 'alternate' rel if no origLink exists" do
+  it "is able to fetch a url via the 'alternate' rel if no origLink exists" do
     xml = File.read("#{File.dirname(__FILE__)}/../../sample_feeds/PaulDixExplainsNothingAlternate.xml")
     entry = Feedjira::Parser::AtomFeedBurner.parse(xml).entries.first
     expect(entry.url).to eq("http://feeds.feedburner.com/~r/PaulDixExplainsNothing/~3/519925023/making-a-ruby-c-library-even-faster.html")
   end
 
-  it "should parse the url" do
+  it "parses the url" do
     expect(@entry.url).to eq "http://www.pauldix.net/2009/01/making-a-ruby-c-library-even-faster.html"
   end
 
-  it "should parse the url when there is no alternate" do
+  it "parses the url when there is no alternate" do
     xml = File.read("#{File.dirname(__FILE__)}/../../sample_feeds/FeedBurnerUrlNoAlternate.xml")
     entry = Feedjira::Parser::AtomFeedBurner.parse(xml).entries.first
     expect(entry.url).to eq "http://example.com/QQQQ.html"
   end
 
-  it "should parse the author" do
+  it "parses the author" do
     expect(@entry.author).to eq "Paul Dix"
   end
 
-  it "should parse the content" do
+  it "parses the content" do
     expect(@entry.content).to eq sample_feedburner_atom_entry_content
   end
 
-  it "should provide a summary" do
+  it "provides a summary" do
     summary = "Last week I released the first version of a SAX based XML parsing library called SAX-Machine. It uses Nokogiri, which uses libxml, so it's pretty fast. However, I felt that it could be even faster. The only question was how..."
     expect(@entry.summary).to eq summary
   end
 
-  it "should parse the published date" do
+  it "parses the published date" do
     published = Time.parse_safely "Thu Jan 22 15:50:22 UTC 2009"
     expect(@entry.published).to eq published
   end
 
-  it "should parse the categories" do
+  it "parses the categories" do
     expect(@entry.categories).to eq ["Ruby", "Another Category"]
   end
 end

data/spec/feedjira/parser/atom_feed_burner_spec.rb

@@ -5,66 +5,66 @@ require "spec_helper"
 module Feedjira
   module Parser
     describe "#will_parse?" do
-      it "should return true for a feedburner atom feed" do
+      it "returns true for a feedburner atom feed" do
         expect(AtomFeedBurner).to be_able_to_parse(sample_feedburner_atom_feed)
       end
 
-      it "should return false for an rdf feed" do
-        expect(AtomFeedBurner).to_not be_able_to_parse(sample_rdf_feed)
+      it "returns false for an rdf feed" do
+        expect(AtomFeedBurner).not_to be_able_to_parse(sample_rdf_feed)
       end
 
-      it "should return false for a regular atom feed" do
-        expect(AtomFeedBurner).to_not be_able_to_parse(sample_atom_feed)
+      it "returns false for a regular atom feed" do
+        expect(AtomFeedBurner).not_to be_able_to_parse(sample_atom_feed)
       end
 
-      it "should return false for an rss feedburner feed" do
-        expect(AtomFeedBurner).to_not be_able_to_parse sample_rss_feed_burner_feed
+      it "returns false for an rss feedburner feed" do
+        expect(AtomFeedBurner).not_to be_able_to_parse sample_rss_feed_burner_feed
       end
     end
 
     describe "parsing old style feeds" do
-      before(:each) do
+      before do
         @feed = AtomFeedBurner.parse(sample_feedburner_atom_feed)
       end
 
-      it "should parse the title" do
+      it "parses the title" do
         expect(@feed.title).to eq "Paul Dix Explains Nothing"
       end
 
-      it "should parse the description" do
+      it "parses the description" do
         description = "Entrepreneurship, programming, software development, politics, NYC, and random thoughts."
         expect(@feed.description).to eq description
       end
 
-      it "should parse the url" do
+      it "parses the url" do
         expect(@feed.url).to eq "http://www.pauldix.net/"
       end
 
-      it "should parse the feed_url" do
+      it "parses the feed_url" do
         expect(@feed.feed_url).to eq "http://feeds.feedburner.com/PaulDixExplainsNothing"
       end
 
-      it "should parse no hub urls" do
+      it "parses no hub urls" do
         expect(@feed.hubs.count).to eq 0
       end
 
-      it "should parse hub urls" do
+      it "parses hub urls" do
         AtomFeedBurner.preprocess_xml = false
         feed_with_hub = AtomFeedBurner.parse(load_sample("TypePadNews.xml"))
         expect(feed_with_hub.hubs.count).to eq 1
       end
 
-      it "should parse entries" do
+      it "parses entries" do
         expect(@feed.entries.size).to eq 5
       end
 
-      it "should change url" do
+      it "changes url" do
         new_url = "http://some.url.com"
         expect { @feed.url = new_url }.not_to raise_error
         expect(@feed.url).to eq new_url
       end
 
-      it "should change feed_url" do
+      it "changes feed_url" do
         new_url = "http://some.url.com"
         expect { @feed.feed_url = new_url }.not_to raise_error
         expect(@feed.feed_url).to eq new_url
@@ -72,42 +72,42 @@ module Feedjira
     end
 
     describe "parsing alternate style feeds" do
-      before(:each) do
+      before do
         @feed = AtomFeedBurner.parse(sample_feedburner_atom_feed_alternate)
       end
 
-      it "should parse the title" do
+      it "parses the title" do
         expect(@feed.title).to eq "Giant Robots Smashing Into Other Giant Robots"
       end
 
-      it "should parse the description" do
+      it "parses the description" do
         description = "Written by thoughtbot"
         expect(@feed.description).to eq description
       end
 
-      it "should parse the url" do
+      it "parses the url" do
         expect(@feed.url).to eq "https://robots.thoughtbot.com"
       end
 
-      it "should parse the feed_url" do
+      it "parses the feed_url" do
         expect(@feed.feed_url).to eq "http://feeds.feedburner.com/GiantRobotsSmashingIntoOtherGiantRobots"
       end
 
-      it "should parse hub urls" do
+      it "parses hub urls" do
         expect(@feed.hubs.count).to eq 1
       end
 
-      it "should parse entries" do
+      it "parses entries" do
         expect(@feed.entries.size).to eq 3
       end
 
-      it "should change url" do
+      it "changes url" do
         new_url = "http://some.url.com"
         expect { @feed.url = new_url }.not_to raise_error
         expect(@feed.url).to eq new_url
       end
 
-      it "should change feed_url" do
+      it "changes feed_url" do
         new_url = "http://some.url.com"
         expect { @feed.feed_url = new_url }.not_to raise_error
         expect(@feed.feed_url).to eq new_url

data/spec/feedjira/parser/atom_google_alerts_entry_spec.rb

@@ -3,31 +3,31 @@
 require "spec_helper"
 
 describe Feedjira::Parser::AtomGoogleAlertsEntry do
-  before(:each) do
+  before do
     feed = Feedjira::Parser::AtomGoogleAlerts.parse sample_google_alerts_atom_feed
     @entry = feed.entries.first
   end
 
-  it "should parse the title" do
+  it "parses the title" do
     expect(@entry.title).to eq "Report offers Prediction of Automotive Slack Market by Top key players like Haldex, Meritor, Bendix ..."
     expect(@entry.raw_title).to eq "Report offers Prediction of Automotive <b>Slack</b> Market by Top key players like Haldex, Meritor, Bendix ..."
     expect(@entry.title_type).to eq "html"
   end
 
-  it "should parse the url" do
+  it "parses the url" do
     expect(@entry.url).to eq "https://www.aglobalmarketresearch.com/report-offers-prediction-of-automotive-slack-market-by-top-key-players-like-haldex-meritor-bendix-mei-wabco-accuride-stemco-tbk-febi-aydinsan/"
   end
 
-  it "should parse the content" do
+  it "parses the content" do
     expect(@entry.content).to eq "Automotive <b>Slack</b> Market reports provides a comprehensive overview of the global market size and share. It provides strategists, marketers and senior&nbsp;..."
   end
 
-  it "should parse the published date" do
+  it "parses the published date" do
     published = Time.parse_safely "2019-07-10T11:53:37Z"
     expect(@entry.published).to eq published
   end
 
-  it "should parse the updated date" do
+  it "parses the updated date" do
     updated = Time.parse_safely "2019-07-10T11:53:37Z"
     expect(@entry.updated).to eq updated
   end

data/spec/feedjira/parser/atom_google_alerts_spec.rb

@@ -5,45 +5,45 @@ require "spec_helper"
 module Feedjira
   module Parser
     describe "#able_to_parse?" do
-      it "should return true for a Google Alerts atom feed" do
+      it "returns true for a Google Alerts atom feed" do
         expect(AtomGoogleAlerts).to be_able_to_parse(sample_google_alerts_atom_feed)
       end
 
-      it "should return false for an rdf feed" do
-        expect(AtomGoogleAlerts).to_not be_able_to_parse(sample_rdf_feed)
+      it "returns false for an rdf feed" do
+        expect(AtomGoogleAlerts).not_to be_able_to_parse(sample_rdf_feed)
       end
 
-      it "should return false for a regular atom feed" do
-        expect(AtomGoogleAlerts).to_not be_able_to_parse(sample_atom_feed)
+      it "returns false for a regular atom feed" do
+        expect(AtomGoogleAlerts).not_to be_able_to_parse(sample_atom_feed)
       end
 
-      it "should return false for a feedburner atom feed" do
-        expect(AtomGoogleAlerts).to_not be_able_to_parse(sample_feedburner_atom_feed)
+      it "returns false for a feedburner atom feed" do
+        expect(AtomGoogleAlerts).not_to be_able_to_parse(sample_feedburner_atom_feed)
       end
     end
 
     describe "parsing" do
-      before(:each) do
+      before do
         @feed = AtomGoogleAlerts.parse(sample_google_alerts_atom_feed)
       end
 
-      it "should parse the title" do
+      it "parses the title" do
         expect(@feed.title).to eq "Google Alert - Slack"
       end
 
-      it "should parse the descripton" do
+      it "parses the descripton" do
         expect(@feed.description).to be_nil
       end
 
-      it "should parse the url" do
+      it "parses the url" do
         expect(@feed.url).to eq "https://www.google.com/alerts/feeds/04175468913983673025/4428013283581841004"
       end
 
-      it "should parse the feed_url" do
+      it "parses the feed_url" do
         expect(@feed.feed_url).to eq "https://www.google.com/alerts/feeds/04175468913983673025/4428013283581841004"
       end
 
-      it "should parse entries" do
+      it "parses entries" do
         expect(@feed.entries.size).to eq 20
       end
     end

data/spec/feedjira/parser/atom_spec.rb

@@ -5,72 +5,72 @@ require "spec_helper"
 module Feedjira
   module Parser
     describe "#will_parse?" do
-      it "should return true for an atom feed" do
+      it "returns true for an atom feed" do
         expect(Atom).to be_able_to_parse(sample_atom_feed)
       end
 
-      it "should return false for an rdf feed" do
-        expect(Atom).to_not be_able_to_parse(sample_rdf_feed)
+      it "returns false for an rdf feed" do
+        expect(Atom).not_to be_able_to_parse(sample_rdf_feed)
       end
 
-      it "should return false for an rss feedburner feed" do
-        expect(Atom).to_not be_able_to_parse(sample_rss_feed_burner_feed)
+      it "returns false for an rss feedburner feed" do
+        expect(Atom).not_to be_able_to_parse(sample_rss_feed_burner_feed)
       end
 
-      it "should return true for an atom feed that has line breaks in between attributes in the <feed> node" do
+      it "returns true for an atom feed that has line breaks in between attributes in the <feed> node" do
         expect(Atom).to be_able_to_parse(sample_atom_feed_line_breaks)
       end
     end
 
     describe "parsing" do
-      before(:each) do
+      before do
         @feed = Atom.parse(sample_atom_feed)
       end
 
-      it "should parse the title" do
+      it "parses the title" do
         expect(@feed.title).to eq "Amazon Web Services Blog"
       end
 
-      it "should parse the description" do
+      it "parses the description" do
         description = "Amazon Web Services, Products, Tools, and Developer Information..."
         expect(@feed.description).to eq description
       end
 
-      it "should parse the icon url" do
+      it "parses the icon url" do
         feed_with_icon = Atom.parse(load_sample("SamRuby.xml"))
         expect(feed_with_icon.icon).to eq "../favicon.ico"
       end
 
-      it "should parse the url" do
+      it "parses the url" do
         expect(@feed.url).to eq "http://aws.typepad.com/aws/"
       end
 
-      it "should parse the url even when it doesn't have the type='text/html' attribute" do
+      it "parses the url even when it doesn't have the type='text/html' attribute" do
         xml = load_sample "atom_with_link_tag_for_url_unmarked.xml"
         feed = Atom.parse xml
         expect(feed.url).to eq "http://www.innoq.com/planet/"
       end
 
-      it "should parse the feed_url even when it doesn't have the type='application/atom+xml' attribute" do
+      it "parses the feed_url even when it doesn't have the type='application/atom+xml' attribute" do
         feed = Atom.parse(load_sample("atom_with_link_tag_for_url_unmarked.xml"))
         expect(feed.feed_url).to eq "http://www.innoq.com/planet/atom.xml"
       end
 
-      it "should parse the feed_url" do
+      it "parses the feed_url" do
         expect(@feed.feed_url).to eq "http://aws.typepad.com/aws/atom.xml"
       end
 
-      it "should parse no hub urls" do
+      it "parses no hub urls" do
         expect(@feed.hubs.count).to eq 0
       end
 
-      it "should parse the hub urls" do
+      it "parses the hub urls" do
         feed_with_hub = Atom.parse(load_sample("SamRuby.xml"))
         expect(feed_with_hub.hubs.count).to eq 1
         expect(feed_with_hub.hubs.first).to eq "http://pubsubhubbub.appspot.com/"
       end
 
-      it "should parse entries" do
+      it "parses entries" do
         expect(@feed.entries.size).to eq 10
       end
     end
@@ -89,7 +89,7 @@ module Feedjira
         expect(entry.content).to match(/\A<p/)
       end
 
-      it "should not duplicate content when there are divs in content" do
+      it "does not duplicate content when there are divs in content" do
         Atom.preprocess_xml = true
 
         feed = Atom.parse sample_duplicate_content_atom_feed
@@ -99,25 +99,25 @@ module Feedjira
     end
 
     describe "parsing url and feed_url" do
-      before :each do
+      before do
         @feed = Atom.parse(sample_atom_middleman_feed)
       end
 
-      it "should parse url" do
+      it "parses url" do
         expect(@feed.url).to eq "http://feedjira.com/blog"
       end
 
-      it "should parse feed_url" do
+      it "parses feed_url" do
         expect(@feed.feed_url).to eq "http://feedjira.com/blog/feed.xml"
       end
 
-      it "should not parse links without the rel='self' attribute as feed_url" do
+      it "does not parse links without the rel='self' attribute as feed_url" do
         xml = load_sample "atom_simple_single_entry.xml"
         feed = Atom.parse xml
         expect(feed.feed_url).to be_nil
       end
 
-      it "should not parse links with the rel='self' attribute as url" do
+      it "does not parse links with the rel='self' attribute as url" do
         xml = load_sample "atom_simple_single_entry_link_self.xml"
         feed = Atom.parse xml
         expect(feed.url).to be_nil

data/spec/feedjira/parser/atom_youtube_entry_spec.rb

@@ -9,79 +9,79 @@ describe Feedjira::Parser::AtomYoutubeEntry do
       @entry = @feed.entries.first
     end
 
-    it "should have the title" do
+    it "has the title" do
       expect(@entry.title).to eq "The Google app: Questions Title"
     end
 
-    it "should have the url" do
+    it "has the url" do
       expect(@entry.url).to eq "http://www.youtube.com/watch?v=5shykyfmb28"
     end
 
-    it "should have the entry id" do
+    it "has the entry id" do
       expect(@entry.entry_id).to eq "yt:video:5shykyfmb28"
     end
 
-    it "should have the published date" do
+    it "has the published date" do
       expect(@entry.published).to eq Time.parse_safely("2015-05-04T00:01:27+00:00")
     end
 
-    it "should have the updated date" do
+    it "has the updated date" do
       expect(@entry.updated).to eq Time.parse_safely("2015-05-13T17:38:30+00:00")
     end
 
-    it "should have the content populated from the media:description element" do
+    it "has the content populated from the media:description element" do
       expect(@entry.content).to eq "A question is the most powerful force in the world. It can start you on an adventure or spark a connection. See where a question can take you. The Google app is available on iOS and Android. Download the app here: http://www.google.com/search/about/download"
     end
 
-    it "should have the summary but blank" do
+    it "has the summary but blank" do
       expect(@entry.summary).to be_nil
     end
 
-    it "should have the custom youtube video id" do
+    it "has the custom youtube video id" do
       expect(@entry.youtube_video_id).to eq "5shykyfmb28"
     end
 
-    it "should have the custom media title" do
+    it "has the custom media title" do
       expect(@entry.media_title).to eq "The Google app: Questions"
     end
 
-    it "should have the custom media url" do
+    it "has the custom media url" do
       expect(@entry.media_url).to eq "https://www.youtube.com/v/5shykyfmb28?version=3"
     end
 
-    it "should have the custom media type" do
+    it "has the custom media type" do
       expect(@entry.media_type).to eq "application/x-shockwave-flash"
     end
 
-    it "should have the custom media width" do
+    it "has the custom media width" do
       expect(@entry.media_width).to eq "640"
     end
 
-    it "should have the custom media height" do
+    it "has the custom media height" do
       expect(@entry.media_height).to eq "390"
     end
 
-    it "should have the custom media thumbnail url" do
+    it "has the custom media thumbnail url" do
       expect(@entry.media_thumbnail_url).to eq "https://i2.ytimg.com/vi/5shykyfmb28/hqdefault.jpg"
     end
 
-    it "should have the custom media thumbnail width" do
+    it "has the custom media thumbnail width" do
       expect(@entry.media_thumbnail_width).to eq "480"
     end
 
-    it "should have the custom media thumbnail height" do
+    it "has the custom media thumbnail height" do
       expect(@entry.media_thumbnail_height).to eq "360"
     end
 
-    it "should have the custom media star count" do
+    it "has the custom media star count" do
       expect(@entry.media_star_count).to eq "3546"
     end
 
-    it "should have the custom media star average" do
+    it "has the custom media star average" do
       expect(@entry.media_star_average).to eq "4.79"
     end
 
-    it "should have the custom media views" do
+    it "has the custom media views" do
       expect(@entry.media_views).to eq "251497"
     end
   end