feedjira 3.1.0 → 3.2.1

data/spec/feedjira/parser/itunes_rss_spec.rb

@@ -1,119 +1,121 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 module Feedjira
   module Parser
     describe "#will_parse?" do
-      it "should return true for an itunes RSS feed" do
+      it "returns true for an itunes RSS feed" do
         expect(ITunesRSS).to be_able_to_parse(sample_itunes_feed)
       end
 
-      it "should return true for an itunes RSS feed with spaces between attribute names, equals sign, and values" do # rubocop:disable Metrics/LineLength
+      it "returns true for an itunes RSS feed with spaces between attribute names, equals sign, and values" do
         expect(ITunesRSS).to be_able_to_parse(sample_itunes_feed_with_spaces)
       end
 
-      it "should return true for an itunes RSS feed with single-quoted attributes" do # rubocop:disable Metrics/LineLength
-        expect(ITunesRSS).to be_able_to_parse(sample_itunes_feed_with_single_quotes)  # rubocop:disable Metrics/LineLength
+      it "returns true for an itunes RSS feed with single-quoted attributes" do
+        expect(ITunesRSS).to be_able_to_parse(sample_itunes_feed_with_single_quotes)
       end
 
-      it "should return fase for an atom feed" do
-        expect(ITunesRSS).to_not be_able_to_parse(sample_atom_feed)
+      it "returns fase for an atom feed" do
+        expect(ITunesRSS).not_to be_able_to_parse(sample_atom_feed)
       end
 
-      it "should return false for an rss feedburner feed" do
-        expect(ITunesRSS).to_not be_able_to_parse(sample_rss_feed_burner_feed)
+      it "returns false for an rss feedburner feed" do
+        expect(ITunesRSS).not_to be_able_to_parse(sample_rss_feed_burner_feed)
       end
     end
 
     describe "parsing" do
-      before(:each) do
+      before do
         @feed = ITunesRSS.parse(sample_itunes_feed)
       end
 
-      it "should parse the ttl" do
+      it "parses the ttl" do
         expect(@feed.ttl).to eq "60"
       end
 
-      it "should parse the last build date" do
+      it "parses the last build date" do
         expect(@feed.last_built).to eq "Sat, 07 Sep 2002 09:42:31 GMT"
       end
 
-      it "should parse the subtitle" do
+      it "parses the subtitle" do
         expect(@feed.itunes_subtitle).to eq "A show about everything"
       end
 
-      it "should parse the author" do
+      it "parses the author" do
         expect(@feed.itunes_author).to eq "John Doe"
       end
 
-      it "should parse an owner" do
+      it "parses an owner" do
         expect(@feed.itunes_owners.size).to eq 1
       end
 
-      it "should parse an image" do
+      it "parses an image" do
         expect(@feed.itunes_image).to eq "http://example.com/podcasts/everything/AllAboutEverything.jpg"
       end
 
-      it "should parse the image url" do
+      it "parses the image url" do
         expect(@feed.image.url).to eq "http://example.com/podcasts/everything/AllAboutEverything.jpg"
       end
 
-      it "should parse the image title" do
+      it "parses the image title" do
         expect(@feed.image.title).to eq "All About Everything"
       end
 
-      it "should parse the image link" do
+      it "parses the image link" do
         expect(@feed.image.link).to eq "http://www.example.com/podcasts/everything/index.html"
       end
 
-      it "should parse the image width" do
+      it "parses the image width" do
         expect(@feed.image.width).to eq "88"
       end
 
-      it "should parse the image height" do
+      it "parses the image height" do
         expect(@feed.image.height).to eq "31"
       end
 
-      it "should parse the image description" do
-        description = "All About Everything is a show about everything. Each week we dive into any subject known to man and talk about it as much as we can. Look for our Podcast in the iTunes Music Store" # rubocop:disable Metrics/LineLength
+      it "parses the image description" do
+        description = "All About Everything is a show about everything. Each week we dive into any subject known to man and talk about it as much as we can. Look for our Podcast in the iTunes Music Store"
         expect(@feed.image.description).to eq description
       end
 
-      it "should parse categories" do
+      it "parses categories" do
         expect(@feed.itunes_categories).to eq [
           "Technology",
           "Gadgets",
           "TV & Film",
           "Arts",
           "Design",
-          "Food",
+          "Food"
         ]
 
         expect(@feed.itunes_category_paths).to eq [
-          %w(Technology Gadgets),
+          %w[Technology Gadgets],
           ["TV & Film"],
-          %w(Arts Design),
-          %w(Arts Food),
+          %w[Arts Design],
+          %w[Arts Food]
         ]
       end
 
-      it "should parse the itunes type" do
+      it "parses the itunes type" do
         expect(@feed.itunes_type).to eq "episodic"
       end
 
-      it "should parse the summary" do
-        summary = "All About Everything is a show about everything. Each week we dive into any subject known to man and talk about it as much as we can. Look for our Podcast in the iTunes Music Store" # rubocop:disable Metrics/LineLength
+      it "parses the summary" do
+        summary = "All About Everything is a show about everything. Each week we dive into any subject known to man and talk about it as much as we can. Look for our Podcast in the iTunes Music Store"
         expect(@feed.itunes_summary).to eq summary
       end
 
-      it "should parse the complete tag" do
+      it "parses the complete tag" do
         expect(@feed.itunes_complete).to eq "yes"
       end
 
-      it "should parse entries" do
+      it "parses entries" do
         expect(@feed.entries.size).to eq 3
       end
 
-      it "should parse the new-feed-url" do
+      it "parses the new-feed-url" do
         expect(@feed.itunes_new_feed_url).to eq "http://example.com/new.xml"
       end
     end

data/spec/feedjira/parser/json_feed_item_spec.rb

@@ -1,40 +1,42 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Feedjira::Parser::JSONFeedItem do
-  before(:each) do
+  before do
     # I don't really like doing it this way because these unit test should only
     # rely on JSONFeed, but this is actually how it should work. You would
     # never just pass entry json straight to the JSONFeedItem
     @entry = Feedjira::Parser::JSONFeed.parse(sample_json_feed).entries.first
   end
 
-  it "should parse the id" do
+  it "parses the id" do
     expect(@entry.id).to eq "http://inessential.com/2017/06/02/james_dempsey_and_the_breakpoints_benefi"
   end
 
-  it "should parse the url" do
+  it "parses the url" do
     expect(@entry.url).to eq "http://inessential.com/2017/06/02/james_dempsey_and_the_breakpoints_benefi"
   end
 
-  it "should parse the title" do
+  it "parses the title" do
     expect(@entry.title).to eq "James Dempsey and the Breakpoints Benefit App Camp for Girls"
   end
 
-  it "should parse the content" do
-    content = "<p>On Wednesday night I know where I’ll be — playing keyboard for a few songs at the James Dempsey and the Breakpoints concert benefitting App Camp for Girls.</p>\n\n<p><a href=\"https://www.classy.org/events/-/e126329\">You should get tickets</a>. It’s a fun time for a great cause.</p>\n\n<p>Bonus: James writes about how <a href=\"http://jamesdempsey.net/2017/06/02/wwdc-in-san-jose-full-circle/\">this concert is full circle for him</a>. It’s a special night.</p>" # rubocop:disable Metrics/LineLength
+  it "parses the content" do
+    content = "<p>On Wednesday night I know where I’ll be — playing keyboard for a few songs at the James Dempsey and the Breakpoints concert benefitting App Camp for Girls.</p>\n\n<p><a href=\"https://www.classy.org/events/-/e126329\">You should get tickets</a>. It’s a fun time for a great cause.</p>\n\n<p>Bonus: James writes about how <a href=\"http://jamesdempsey.net/2017/06/02/wwdc-in-san-jose-full-circle/\">this concert is full circle for him</a>. It’s a special night.</p>"
     expect(@entry.content).to eq content
   end
 
-  it "should parse the published date" do
+  it "parses the published date" do
     published = Time.parse_safely "2017-06-02T22:05:47-07:00"
     expect(@entry.published).to eq published
   end
 
-  it "should support each" do
+  it "supports each" do
     expect(@entry).to respond_to :each
   end
 
-  it "should be able to list out all the fields with each" do
+  it "is able to list out all the fields with each" do
     all_fields = []
     title_value = ""
     @entry.each do |field, value|
@@ -44,7 +46,7 @@ describe Feedjira::Parser::JSONFeedItem do
 
     expect(title_value).to eq "James Dempsey and the Breakpoints Benefit App Camp for Girls"
 
-    expected_fields = %w(
+    expected_fields = %w[
       author
       banner_image
       categories
@@ -58,21 +60,21 @@ describe Feedjira::Parser::JSONFeedItem do
       title
       updated
       url
-    )
+    ]
     expect(all_fields).to match_array expected_fields
   end
 
-  it "should support checking if a field exists in the entry" do
+  it "supports checking if a field exists in the entry" do
     expect(@entry).to include "title"
     expect(@entry).to include "url"
   end
 
-  it "should allow access to fields with hash syntax" do
+  it "allows access to fields with hash syntax" do
     expect(@entry["title"]).to eq "James Dempsey and the Breakpoints Benefit App Camp for Girls"
     expect(@entry["url"]).to eq "http://inessential.com/2017/06/02/james_dempsey_and_the_breakpoints_benefi"
   end
 
-  it "should allow setting field values with hash syntax" do
+  it "allows setting field values with hash syntax" do
     @entry["title"] = "Foobar"
     expect(@entry.title).to eq "Foobar"
   end

data/spec/feedjira/parser/json_feed_spec.rb

@@ -1,51 +1,53 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 module Feedjira
   module Parser
     describe ".able_to_parse?" do
-      it "should return true for a JSON feed" do
+      it "returns true for a JSON feed" do
         expect(JSONFeed).to be_able_to_parse(sample_json_feed)
       end
 
-      it "should return false for an RSS feed" do
-        expect(JSONFeed).to_not be_able_to_parse(sample_rss_feed)
+      it "returns false for an RSS feed" do
+        expect(JSONFeed).not_to be_able_to_parse(sample_rss_feed)
       end
 
-      it "should return false for an Atom feed" do
-        expect(JSONFeed).to_not be_able_to_parse(sample_atom_feed)
+      it "returns false for an Atom feed" do
+        expect(JSONFeed).not_to be_able_to_parse(sample_atom_feed)
       end
     end
 
     describe "parsing" do
-      before(:each) do
+      before do
         @feed = JSONFeed.parse(sample_json_feed)
       end
 
-      it "should parse the version" do
+      it "parses the version" do
         expect(@feed.version).to eq "https://jsonfeed.org/version/1"
       end
 
-      it "should parse the title" do
+      it "parses the title" do
         expect(@feed.title).to eq "inessential.com"
       end
 
-      it "should parse the url" do
+      it "parses the url" do
         expect(@feed.url).to eq "http://inessential.com/"
       end
 
-      it "should parse the feed_url" do
+      it "parses the feed_url" do
         expect(@feed.feed_url).to eq "http://inessential.com/feed.json"
       end
 
-      it "should parse the description" do
+      it "parses the description" do
         expect(@feed.description).to eq "Brent Simmons’s weblog."
       end
 
-      it "should parse expired and return default (nil)" do
+      it "parses expired and return default (nil)" do
         expect(@feed.expired).to be nil
       end
 
-      it "should parse entries" do
+      it "parses entries" do
         expect(@feed.entries.size).to eq 20
       end
     end

data/spec/feedjira/parser/podlove_chapter_spec.rb

@@ -1,20 +1,22 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Feedjira::Parser::PodloveChapter do
-  before(:each) do
+  before do
     @item = Feedjira::Parser::ITunesRSS.parse(sample_podlove_feed).entries.first
     @chapter = @item.chapters.first
   end
 
-  it "should parse chapters" do
+  it "parses chapters" do
     expect(@item.chapters.size).to eq 15
   end
 
-  it "should sort chapters by time" do
+  it "sorts chapters by time" do
     expect(@item.chapters.last.title).to eq "Abschied"
   end
 
-  it "should parse the start time" do
+  it "parses the start time" do
     expect(@chapter.start_ntp).to eq "00:00:26.407"
     expect(@chapter.start).to eq 26.407
     expect(@item.chapters[1].start).to eq 50
@@ -23,15 +25,15 @@ describe Feedjira::Parser::PodloveChapter do
     expect(@item.chapters.last.start).to eq 5700.034
   end
 
-  it "should parse the title" do
+  it "parses the title" do
     expect(@chapter.title).to eq "Neil DeGrasse Tyson on Science"
   end
 
-  it "should parse the link" do
+  it "parses the link" do
     expect(@chapter.url).to eq "https://example.com"
   end
 
-  it "should parse the image" do
+  it "parses the image" do
     expect(@chapter.image).to eq "https://pics.example.com/pic.png"
   end
 end

data/spec/feedjira/parser/rss_entry_spec.rb

@@ -1,7 +1,9 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Feedjira::Parser::RSSEntry do
-  before(:each) do
+  before do
     # I don't really like doing it this way because these unit test should only
     # rely on RSSEntry, but this is actually how it should work. You would
     # never just pass entry xml straight to the AtomEnry
@@ -10,7 +12,7 @@ describe Feedjira::Parser::RSSEntry do
     Feedjira::Feed.add_common_feed_entry_element tag, as: :comment_rss
   end
 
-  after(:each) do
+  after do
     # We change the title in one or more specs to test []=
     if @entry.title != "Nokogiri’s Slop Feature"
       feed = Feedjira::Parser::RSS.parse sample_rss_feed
@@ -18,45 +20,45 @@ describe Feedjira::Parser::RSSEntry do
     end
   end
 
-  it "should parse the title" do
+  it "parses the title" do
     expect(@entry.title).to eq "Nokogiri’s Slop Feature"
   end
 
-  it "should parse the url" do
+  it "parses the url" do
     expect(@entry.url).to eq "http://tenderlovemaking.com/2008/12/04/nokogiris-slop-feature/"
   end
 
-  it "should parse the author" do
+  it "parses the author" do
     expect(@entry.author).to eq "Aaron Patterson"
   end
 
-  it "should parse the content" do
+  it "parses the content" do
     expect(@entry.content).to eq sample_rss_entry_content
   end
 
-  it "should provide a summary" do
-    summary = "Oops!  When I released nokogiri version 1.0.7, I totally forgot to talk about Nokogiri::Slop() feature that was added.  Why is it called \"slop\"?  It lets you sloppily explore documents.  Basically, it decorates your document with method_missing() that allows you to search your document via method calls.\nGiven this document:\n\ndoc = Nokogiri::Slop(<<-eohtml)\n<html>\n  <body>\n  [...]" # rubocop:disable Metrics/LineLength
+  it "provides a summary" do
+    summary = "Oops!  When I released nokogiri version 1.0.7, I totally forgot to talk about Nokogiri::Slop() feature that was added.  Why is it called \"slop\"?  It lets you sloppily explore documents.  Basically, it decorates your document with method_missing() that allows you to search your document via method calls.\nGiven this document:\n\ndoc = Nokogiri::Slop(<<-eohtml)\n<html>\n  <body>\n  [...]"
     expect(@entry.summary).to eq summary
   end
 
-  it "should parse the published date" do
+  it "parses the published date" do
     published = Time.parse_safely "Thu Dec 04 17:17:49 UTC 2008"
     expect(@entry.published).to eq published
   end
 
-  it "should parse the categories" do
-    expect(@entry.categories).to eq %w(computadora nokogiri rails)
+  it "parses the categories" do
+    expect(@entry.categories).to eq %w[computadora nokogiri rails]
   end
 
-  it "should parse the guid as id" do
+  it "parses the guid as id" do
     expect(@entry.id).to eq "http://tenderlovemaking.com/?p=198"
   end
 
-  it "should support each" do
+  it "supports each" do
     expect(@entry).to respond_to :each
   end
 
-  it "should be able to list out all fields with each" do
+  it "is able to list out all fields with each" do
     all_fields = []
     title_value = ""
     @entry.each do |field, value|
@@ -66,7 +68,7 @@ describe Feedjira::Parser::RSSEntry do
 
     expect(title_value).to eq "Nokogiri’s Slop Feature"
 
-    expected_fields = %w(
+    expected_fields = %w[
       author
       categories
       comment_rss
@@ -76,41 +78,41 @@ describe Feedjira::Parser::RSSEntry do
       summary
       title
       url
-    )
+    ]
     expect(all_fields.sort).to eq expected_fields
   end
 
-  it "should support checking if a field exists in the entry" do
+  it "supports checking if a field exists in the entry" do
     expect(@entry).to include "title"
     expect(@entry).to include "author"
   end
 
-  it "should allow access to fields with hash syntax" do
+  it "allows access to fields with hash syntax" do
     expect(@entry["title"]).to eq "Nokogiri’s Slop Feature"
     expect(@entry["author"]).to eq "Aaron Patterson"
   end
 
-  it "should allow setting field values with hash syntax" do
+  it "allows setting field values with hash syntax" do
     @entry["title"] = "Foobar"
     expect(@entry.title).to eq "Foobar"
   end
 
-  it "should ignore urls from guids with isPermaLink='false'" do
+  it "ignores urls from guids with isPermaLink='false'" do
     feed = Feedjira.parse(sample_rss_feed_permalinks)
     expect(feed.entries[0].url).to eq nil
   end
 
-  it "should get urls from guids with isPermaLink='true'" do
+  it "gets urls from guids with isPermaLink='true'" do
     feed = Feedjira.parse(sample_rss_feed_permalinks)
     expect(feed.entries[1].url).to eq "http://example.com/2"
   end
 
-  it "should get urls from guid where isPermaLink is unspecified" do
+  it "gets urls from guid where isPermaLink is unspecified" do
     feed = Feedjira.parse(sample_rss_feed_permalinks)
     expect(feed.entries[2].url).to eq "http://example.com/3"
   end
 
-  it "should prefer urls from <link> when both guid and link are specified" do
+  it "prefers urls from <link> when both guid and link are specified" do
     feed = Feedjira.parse(sample_rss_feed_permalinks)
     expect(feed.entries[3].url).to eq "http://example.com/4"
   end

data/spec/feedjira/parser/rss_feed_burner_entry_spec.rb

@@ -1,7 +1,9 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Feedjira::Parser::RSSFeedBurnerEntry do
-  before(:each) do
+  before do
     tag = "wfw:commentRss"
     Feedjira::Feed.add_common_feed_entry_element(tag, as: :comment_rss)
     # I don't really like doing it this way because these unit test should only
@@ -11,53 +13,53 @@ describe Feedjira::Parser::RSSFeedBurnerEntry do
     @entry = feed.entries.first
   end
 
-  after(:each) do
+  after do
     # We change the title in one or more specs to test []=
-    if @entry.title != "Angie’s List Sets Price Range IPO At $11 To $13 Per Share; Valued At Over $600M" # rubocop:disable Metrics/LineLength
+    if @entry.title != "Angie’s List Sets Price Range IPO At $11 To $13 Per Share; Valued At Over $600M"
       feed = Feedjira::Parser::RSS.parse sample_rss_feed_burner_feed
       @entry.title = feed.entries.first.title
     end
   end
 
-  it "should parse the title" do
-    title = "Angie’s List Sets Price Range IPO At $11 To $13 Per Share; Valued At Over $600M" # rubocop:disable Metrics/LineLength
+  it "parses the title" do
+    title = "Angie’s List Sets Price Range IPO At $11 To $13 Per Share; Valued At Over $600M"
     expect(@entry.title).to eq title
   end
 
-  it "should parse the original url" do
-    expect(@entry.url).to eq "http://techcrunch.com/2011/11/02/angies-list-prices-ipo-at-11-to-13-per-share-valued-at-over-600m/" # rubocop:disable Metrics/LineLength
+  it "parses the original url" do
+    expect(@entry.url).to eq "http://techcrunch.com/2011/11/02/angies-list-prices-ipo-at-11-to-13-per-share-valued-at-over-600m/"
   end
 
-  it "should parse the author" do
+  it "parses the author" do
     expect(@entry.author).to eq "Leena Rao"
   end
 
-  it "should parse the content" do
+  it "parses the content" do
     expect(@entry.content).to eq sample_rss_feed_burner_entry_content
   end
 
-  it "should provide a summary" do
+  it "provides a summary" do
     expect(@entry.summary).to eq sample_rss_feed_burner_entry_description
   end
 
-  it "should parse the published date" do
+  it "parses the published date" do
     published = Time.parse_safely "Wed Nov 02 17:25:27 UTC 2011"
     expect(@entry.published).to eq published
   end
 
-  it "should parse the categories" do
+  it "parses the categories" do
     expect(@entry.categories).to eq ["TC", "angie\\'s list"]
   end
 
-  it "should parse the guid as id" do
+  it "parses the guid as id" do
     expect(@entry.id).to eq "http://techcrunch.com/?p=446154"
   end
 
-  it "should support each" do
+  it "supports each" do
     expect(@entry).to respond_to :each
   end
 
-  it "should be able to list out all fields with each" do
+  it "is able to list out all fields with each" do
     all_fields = []
     title_value = ""
 
@@ -66,10 +68,10 @@ describe Feedjira::Parser::RSSFeedBurnerEntry do
       title_value = value if field == "title"
     end
 
-    title = "Angie’s List Sets Price Range IPO At $11 To $13 Per Share; Valued At Over $600M" # rubocop:disable Metrics/LineLength
+    title = "Angie’s List Sets Price Range IPO At $11 To $13 Per Share; Valued At Over $600M"
     expect(title_value).to eq title
 
-    expected_fields = %w(
+    expected_fields = %w[
       author
       categories
       comment_rss
@@ -80,22 +82,22 @@ describe Feedjira::Parser::RSSFeedBurnerEntry do
       summary
       title
       url
-    )
+    ]
     expect(all_fields.sort).to eq expected_fields
   end
 
-  it "should support checking if a field exists in the entry" do
+  it "supports checking if a field exists in the entry" do
     expect(@entry).to include "author"
     expect(@entry).to include "title"
   end
 
-  it "should allow access to fields with hash syntax" do
+  it "allows access to fields with hash syntax" do
     expect(@entry["author"]).to eq "Leena Rao"
-    title = "Angie’s List Sets Price Range IPO At $11 To $13 Per Share; Valued At Over $600M" # rubocop:disable Metrics/LineLength
+    title = "Angie’s List Sets Price Range IPO At $11 To $13 Per Share; Valued At Over $600M"
     expect(@entry["title"]).to eq title
   end
 
-  it "should allow setting field values with hash syntax" do
+  it "allows setting field values with hash syntax" do
     @entry["title"] = "Foobar"
     expect(@entry.title).to eq "Foobar"
   end