feedjira 3.1.0 → 3.2.1

data/.rubocop_todo.yml

@@ -1,36 +1,11 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2018-10-08 04:14:19 +0900 using RuboCop version 0.59.2.
+# on 2020-09-02 20:02:06 UTC using RuboCop version 0.90.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 7
-# Cop supports --auto-correct.
-Layout/EmptyLineAfterGuardClause:
-  Exclude:
-    - 'lib/feedjira/date_time_utilities/date_time_epoch_parser.rb'
-    - 'lib/feedjira/feed_utilities.rb'
-    - 'lib/feedjira/parser/json_feed_item.rb'
-    - 'lib/feedjira/parser/podlove_chapter.rb'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-Performance/UnneededSort:
-  Exclude:
-    - 'lib/feedjira/feed_utilities.rb'
-
-# Offense count: 3
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: inline, group
-Style/AccessModifierDeclarations:
-  Exclude:
-    - 'lib/feedjira.rb'
-    - 'lib/feedjira/parser/itunes_rss.rb'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-Style/UnneededCondition:
-  Exclude:
-    - 'lib/feedjira/feed_utilities.rb'
+# Offense count: 20
+Style/Documentation:
+  Enabled: false

data/CHANGELOG.md

@@ -1,13 +1,42 @@
 # Feedjira Changelog
 
-## (Unreleased)
+## 3.2.0
+
+* Atom `feed_url` no longer falls back to `url` via https://github.com/feedjira/feedjira/pull/451 (@frederfred)
+
+* Atom feeds now have an icon field via https://github.com/feedjira/feedjira/pull/452 (@jswanner)
+
+## 3.1.2
+
+* Enhancements
+  * Alias `managingEditor` as `managing_editor` [#443][] ([@DominikAlberski][])
+  * Add support for the `a10` namespace used in RSS 2.0 feeds generated by .NET applications.  Currently `a10:link`, `a10:updated`, `a10:content` and `a10:name` are supported. [#440][] ([@knu][])
+
+[#440]: https://github.com/feedjira/feedjira/pull/440
+[#443]: https://github.com/feedjira/feedjira/pull/443
+
+## 3.1.1
+
+* Enhancements
+  * Fix warnings in Ruby 2.7 [#434][] ([@sferik][])
+
+* General
+  * Test on Ruby 2.5, 2.6 and 2.7 [#435][] ([@HParker][])
+
+[#434]: https://github.com/feedjira/feedjira/pull/434
+[#435]: https://github.com/feedjira/feedjira/pull/435
+
+## 3.1.0
 
 * Breaking Changes
-  * `title` of Atom entry classes always return a plain text even in case the entry has a title of the HTML or XML type. [#423][] (@knu)
+  * `title` of Atom entry classes always return a plain text even in case the entry has a title of the HTML or XML type. [#423][] ([@knu][])
 
 * Enhancements
-  * `raw_title` and `title_type` are added to Atom entry classes. [#423][] (@knu)
-  * AtomGoogleAlerts is now a supported parser [#424][] (@knu)
+  * `raw_title` and `title_type` are added to Atom entry classes. [#423][] ([@knu][])
+  * AtomGoogleAlerts is now a supported parser [#424][] ([@knu][])
+
+[#423]: https://github.com/feedjira/feedjira/pull/423
+[#424]: https://github.com/feedjira/feedjira/pull/424
 
 ## 3.0.0
 
@@ -26,16 +55,26 @@ configurable logging and parsing
 ## 2.1.0
 
 * Enhancements
-  * AtomYoutube is now a supported parser [#337][] (@jfiorato)
-  * Oga parsing is now supported [#331][] (@krasnoukhov)
-  * DateTime Handler now supports localized dates [#313][] (@PascalTurbo)
-  * RSS now supports language attribute [#344][] (@PascalTurbo)
+  * AtomYoutube is now a supported parser [#337][] ([@jfiorato][])
+  * Oga parsing is now supported [#331][] ([@krasnoukhov][])
+  * DateTime Handler now supports localized dates [#313][] ([@PascalTurbo][])
+  * RSS now supports language attribute [#344][] ([@PascalTurbo][])
   * ITunesRSS added support for:
-    * `ttl` and `last_built` [#343][] (@sferik)
-    * `itunes_category` and `itunes_category_paths` [#329][] (@knu)
-    * `itunes_complete` [#328][] (@knu)
-    * single quoted attributes [#326][] (@sferik)
-    * Add image attribute [#349][] (@sferik)
+    * `ttl` and `last_built` [#343][] ([@sferik][])
+    * `itunes_category` and `itunes_category_paths` [#329][] ([@knu][])
+    * `itunes_complete` [#328][] ([@knu][])
+    * single quoted attributes [#326][] ([@sferik][])
+    * Add image attribute [#349][] ([@sferik][])
+
+[#313]: https://github.com/feedjira/feedjira/pull/313
+[#326]: https://github.com/feedjira/feedjira/pull/326
+[#328]: https://github.com/feedjira/feedjira/pull/328
+[#329]: https://github.com/feedjira/feedjira/pull/329
+[#331]: https://github.com/feedjira/feedjira/pull/331
+[#337]: https://github.com/feedjira/feedjira/pull/337
+[#343]: https://github.com/feedjira/feedjira/pull/343
+[#344]: https://github.com/feedjira/feedjira/pull/344
+[#349]: https://github.com/feedjira/feedjira/pull/349
 
 ## 2.0.0
 
@@ -293,3 +332,11 @@ configurable logging and parsing
 ## 0.1.0
 
 * lower builder requirement to make it rails-3 friendly
+
+[@DominikAlberski]: https://github.com/DominikAlberski
+[@HParker]: https://github.com/HParker
+[@PascalTurbo]: https://github.com/PascalTurbo
+[@jfiorato]: https://github.com/jfiorato
+[@knu]: https://github.com/knu
+[@krasnoukhov]: https://github.com/krasnoukhov
+[@sferik]: https://github.com/sferik

data/Gemfile

@@ -1,12 +1,11 @@
+# frozen_string_literal: true
+
 source "https://rubygems.org/"
 
 gemspec
 
-gem "pry"
-gem "rubocop", "~> 0.59.2"
-
 group :test do
   gem "oga"
-  gem "ox", platforms: [:mri, :rbx]
+  gem "ox", platforms: %i[mri rbx]
   gem "rake"
 end

data/Rakefile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "rspec/core/rake_task"
 require "rubocop/rake_task"
 require "yard"
@@ -14,4 +16,4 @@ YARD::Rake::YardocTask.new do |t|
   t.files   = ["lib/**/*.rb", "-", "LICENSE"]
 end
 
-task default: [:spec, :rubocop]
+task default: %i[spec rubocop]

data/feedjira.gemspec

@@ -1,8 +1,7 @@
-# -*- encoding: utf-8 -*-
+# frozen_string_literal: true
 
 require File.expand_path("lib/feedjira/version", __dir__)
 
-# rubocop:disable Metrics/BlockLength
 Gem::Specification.new do |s|
   s.authors = [
     "Adam Hess",
@@ -11,10 +10,9 @@ Gem::Specification.new do |s|
     "Jon Allured",
     "Julien Kirch",
     "Michael Stock",
-    "Paul Dix",
+    "Paul Dix"
   ]
-  s.email    = "feedjira@gmail.com"
-  s.homepage = "http://feedjira.com"
+  s.homepage = "https://github.com/feedjira/feedjira"
   s.license  = "MIT"
   s.name     = "feedjira"
   s.platform = Gem::Platform::RUBY
@@ -22,25 +20,27 @@ Gem::Specification.new do |s|
   s.version  = Feedjira::VERSION
 
   s.metadata = {
-    "homepage_uri"    => "http://feedjira.com",
+    "homepage_uri" => "https://github.com/feedjira/feedjira",
     "source_code_uri" => "https://github.com/feedjira/feedjira",
-    "changelog_uri"   => "https://github.com/feedjira/feedjira/blob/master/CHANGELOG.md"
+    "changelog_uri" => "https://github.com/feedjira/feedjira/blob/master/CHANGELOG.md",
+    "rubygems_mfa_required" => "true"
   }
 
   s.files         = `git ls-files`.split("\n")
   s.require_paths = ["lib"]
   s.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n")
 
-  s.required_ruby_version = ">=2.2"
+  s.required_ruby_version = ">=2.5"
 
   s.add_dependency "loofah",             ">= 2.3.1"
   s.add_dependency "sax-machine",        ">= 1.0"
 
-  s.add_development_dependency "danger"
-  s.add_development_dependency "danger-commit_lint"
+  s.add_development_dependency "faraday"
+  s.add_development_dependency "pry"
   s.add_development_dependency "rspec"
   s.add_development_dependency "rubocop"
-  s.add_development_dependency "vcr"
+  s.add_development_dependency "rubocop-performance"
+  s.add_development_dependency "rubocop-rake"
+  s.add_development_dependency "rubocop-rspec"
   s.add_development_dependency "yard"
 end
-# rubocop:enable Metrics/BlockLength

data/lib/feedjira/configuration.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Feedjira::Configuration
 module Feedjira
   # Provides global configuration options for Feedjira
@@ -10,7 +12,7 @@ module Feedjira
     attr_accessor(
       :logger,
       :parsers,
-      :strip_whitespace,
+      :strip_whitespace
     )
 
     # Modify Feedjira's current configuration
@@ -48,7 +50,7 @@ module Feedjira
 
     # @private
     def default_logger
-      Logger.new(STDOUT).tap do |logger|
+      Logger.new($stdout).tap do |logger|
         logger.progname = "Feedjira"
         logger.level = Logger::WARN
       end
@@ -65,7 +67,7 @@ module Feedjira
         Feedjira::Parser::Atom,
         Feedjira::Parser::ITunesRSS,
         Feedjira::Parser::RSS,
-        Feedjira::Parser::JSONFeed,
+        Feedjira::Parser::JSONFeed
       ]
     end
   end

data/lib/feedjira/core_ext/date.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Date code pulled and adapted from:
 # Ruby Cookbook by Lucas Carlson and Leonard Richardson
 # Published by O'Reilly
@@ -15,6 +17,6 @@ class Date
 
   def feed_utils_to_time(dest, method)
     Time.send(method, dest.year, dest.month, dest.day, dest.hour, dest.min,
-      dest.sec, dest.zone)
+              dest.sec, dest.offset)
   end
 end

data/lib/feedjira/core_ext/string.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class String
   def sanitize!
     replace(sanitize)

data/lib/feedjira/core_ext/time.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "time"
 require "date"
 
@@ -27,7 +29,7 @@ class Time
   def self.parse_string_safely(string)
     return nil if string.empty?
 
-    if string =~ /\A\d{14}\z/
+    if /\A\d{14}\z/.match?(string)
       parse("#{string}Z", true)
     else
       parse(string).utc

data/lib/feedjira/core_ext.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "feedjira/core_ext/time"
 require "feedjira/core_ext/date"
 require "feedjira/core_ext/string"

data/lib/feedjira/date_time_utilities/date_time_epoch_parser.rb

@@ -1,9 +1,12 @@
+# frozen_string_literal: true
+
 module Feedjira
   module DateTimeUtilities
     class DateTimeEpochParser
       def self.parse(string)
         epoch_time = string.to_i
         return Time.at(epoch_time).to_datetime if epoch_time.to_s == string
+
         raise "#{string} is not a valid epoch time"
       end
     end

data/lib/feedjira/date_time_utilities/date_time_language_parser.rb

@@ -1,10 +1,12 @@
+# frozen_string_literal: true
+
 module Feedjira
   module DateTimeUtilities
     class DateTimeLanguageParser
       MONTHS_ENGLISH =
-        %w(Jan Feb Mar Apr May Jun Jul Aug Sep Oct Nov Dec).freeze
+        %w[Jan Feb Mar Apr May Jun Jul Aug Sep Oct Nov Dec].freeze
       MONTHS_SPANISH =
-        %w(Ene Feb Mar Abr May Jun Jul Ago Sep Oct Nov Dic).freeze
+        %w[Ene Feb Mar Abr May Jun Jul Ago Sep Oct Nov Dic].freeze
 
       def self.parse(string)
         DateTime.parse(translate(string))
@@ -13,7 +15,7 @@ module Feedjira
       def self.translate(string)
         MONTHS_SPANISH.each_with_index do |m, i|
           rgx = Regexp.new("\s#{m}\s", Regexp::IGNORECASE)
-          return string.gsub(rgx, MONTHS_ENGLISH[i]) if string =~ rgx
+          return string.gsub(rgx, MONTHS_ENGLISH[i]) if string&.match?(rgx)
         end
         raise "No translation found for #{string}"
       end

data/lib/feedjira/date_time_utilities/date_time_pattern_parser.rb

@@ -1,21 +1,21 @@
+# frozen_string_literal: true
+
 module Feedjira
   module DateTimeUtilities
     class DateTimePatternParser
       # Japanese Symbols are required for strange Date Strings like
       # '水, 31 8 2016 07:37:00 PDT'
-      JAPANESE_SYMBOLS = %w(日 月 火 水 木 金 土).freeze
+      JAPANESE_SYMBOLS = %w[日 月 火 水 木 金 土].freeze
       PATTERNS = ["%m/%d/%Y %T %p", "%d %m %Y %T %Z"].freeze
 
       def self.parse(string)
         PATTERNS.each do |p|
-          begin
-            datetime = DateTime.strptime(prepare(string), p)
-            return datetime
-          rescue StandardError => e
-            Feedjira.logger.debug("Failed to parse date #{string}")
-            Feedjira.logger.debug(e)
-            nil
-          end
+          datetime = DateTime.strptime(prepare(string), p)
+          return datetime
+        rescue StandardError => e
+          Feedjira.logger.debug("Failed to parse date #{string}")
+          Feedjira.logger.debug(e)
+          nil
         end
         raise "No pattern matched #{string}"
       end

data/lib/feedjira/date_time_utilities.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Feedjira
   module DateTimeUtilities
     # This is our date parsing heuristic.
@@ -6,20 +8,18 @@ module Feedjira
       DateTimePatternParser,
       DateTimeLanguageParser,
       DateTimeEpochParser,
-      DateTime,
+      DateTime
     ].freeze
 
     # Parse the given string starting with the most common parser (default ruby)
     # and going over all other available parsers
     def parse_datetime(string)
       res = DATE_PARSERS.detect do |parser|
-        begin
-          return parser.parse(string).feed_utils_to_gm_time
-        rescue StandardError => e
-          Feedjira.logger.debug { "Failed to parse date #{string}" }
-          Feedjira.logger.debug(e)
-          nil
-        end
+        return parser.parse(string).feed_utils_to_gm_time
+      rescue StandardError => e
+        Feedjira.logger.debug { "Failed to parse date #{string}" }
+        Feedjira.logger.debug(e)
+        nil
       end
 
       Feedjira.logger.warn { "Failed to parse date #{string}" } if res.nil?

data/lib/feedjira/feed.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Feedjira
   class Feed
     class << self
@@ -27,7 +29,7 @@ module Feedjira
         Feedjira.parsers.each do |klass|
           klass.sax_config.collection_elements.each_value do |value|
             collection_configs = value.select do |v|
-              v.accessor == "entries" && v.data_class.class == Class
+              v.accessor == "entries" && v.data_class.is_a?(Class)
             end
 
             collection_configs.each do |config|

data/lib/feedjira/feed_entry_utilities.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Feedjira
   module FeedEntryUtilities
     include Enumerable
@@ -39,9 +41,9 @@ module Feedjira
     end
 
     def sanitize!
-      %w(title author summary content image).each do |name|
+      %w[title author summary content image].each do |name|
         if respond_to?(name) && send(name).respond_to?(:sanitize!)
-          send(name).send :sanitize!
+          send(name).send(:sanitize!)
         end
       end
     end
@@ -51,7 +53,7 @@ module Feedjira
     def each
       @rss_fields ||= instance_variables.map do |ivar|
         ivar.to_s.sub("@", "")
-      end.select do |field|
+      end.select do |field| # rubocop:disable Style/MultilineBlockChain
         # select callable (public) methods only
         respond_to?(field)
       end

data/lib/feedjira/feed_utilities.rb

@@ -1,6 +1,8 @@
+# frozen_string_literal: true
+
 module Feedjira
   module FeedUtilities
-    UPDATABLE_ATTRIBUTES = %w(title feed_url url last_modified etag).freeze
+    UPDATABLE_ATTRIBUTES = %w[title feed_url url last_modified etag].freeze
 
     attr_writer   :new_entries, :updated, :last_modified
     attr_accessor :etag
@@ -41,7 +43,7 @@ module Feedjira
     def last_modified
       @last_modified ||= begin
         published = entries.reject { |e| e.published.nil? }
-        entry = published.sort_by { |e| e.published if e.published }.last
+        entry = published.max_by(&:published)
         entry ? entry.published : nil
       end
     end
@@ -73,11 +75,11 @@ module Feedjira
       old_value = send(name)
       new_value = feed.send(name)
 
-      if old_value != new_value
+      if old_value == new_value
+        false
+      else
         send("#{name}=", new_value)
         true
-      else
-        false
       end
     end
 
@@ -100,6 +102,7 @@ module Feedjira
 
       feed.entries.each do |entry|
         break unless new_entry?(entry, latest_entry)
+
         found_new_entries << entry
       end
 

data/lib/feedjira/parser/atom.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Feedjira
   module Parser
     # Parser for dealing with Atom feeds.
@@ -12,17 +14,14 @@ module Feedjira
       elements :link, as: :links, value: :href
       elements :link, as: :hubs, value: :href, with: { rel: "hub" }
       elements :entry, as: :entries, class: AtomEntry
+      element :icon
 
       def self.able_to_parse?(xml)
-        %r{\<feed[^\>]+xmlns\s?=\s?[\"\'](http://www\.w3\.org/2005/Atom|http://purl\.org/atom/ns\#)[\"\'][^\>]*\>} =~ xml # rubocop:disable Metrics/LineLength
+        %r{<feed[^>]+xmlns\s?=\s?["'](http://www\.w3\.org/2005/Atom|http://purl\.org/atom/ns\#)["'][^>]*>} =~ xml
       end
 
       def url
-        @url || (links - [feed_url]).last || links.last
-      end
-
-      def feed_url
-        @feed_url ||= links.first
+        @url || (links - [feed_url]).last
       end
 
       def self.preprocess(xml)

data/lib/feedjira/parser/atom_entry.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Feedjira
   module Parser
     # Parser for dealing with Atom feed entries.

data/lib/feedjira/parser/atom_feed_burner.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Feedjira
   module Parser
     # Parser for dealing with Feedburner Atom feeds.
@@ -10,7 +12,7 @@ module Feedjira
       element :link, as: :url_text_html, value: :href,
                      with: { type: "text/html" }
       element :link, as: :url_notype, value: :href, with: { type: nil }
-      element :link, as: :feed_url_link, value: :href, with: { type: "application/atom+xml" } # rubocop:disable Metrics/LineLength
+      element :link, as: :feed_url_link, value: :href, with: { type: "application/atom+xml" }
       element :"atom10:link", as: :feed_url_atom10_link, value: :href,
                               with: { type: "application/atom+xml" }
       elements :"atom10:link", as: :hubs, value: :href, with: { rel: "hub" }
@@ -19,7 +21,7 @@ module Feedjira
       attr_writer :url, :feed_url
 
       def self.able_to_parse?(xml)
-        ((/<feed/ =~ xml) && (/Atom/ =~ xml) && (/feedburner/ =~ xml) && !(/\<rss|\<rdf/ =~ xml)) || false # rubocop:disable Metrics/LineLength
+        (xml.include?("<feed") && xml.include?("Atom") && xml.include?("feedburner") && !(/<rss|<rdf/ =~ xml)) || false
       end
 
       # Feed url is <link> with type="text/html" if present,

data/lib/feedjira/parser/atom_feed_burner_entry.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Feedjira
   module Parser
     # Parser for dealing with Feedburner Atom feed entries.
@@ -7,9 +9,7 @@ module Feedjira
       include AtomEntryUtilities
 
       element :"feedburner:origLink", as: :orig_link
-      # rubocop:disable Style/AccessModifierDeclarations
       private :orig_link
-      # rubocop:enable Style/AccessModifierDeclarations
 
       element :"media:thumbnail", as: :image, value: :url
       element :"media:content", as: :image, value: :url

data/lib/feedjira/parser/atom_google_alerts.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Feedjira
   module Parser
     # Parser for dealing with Feedburner Atom feeds.
@@ -13,7 +15,7 @@ module Feedjira
       elements :entry, as: :entries, class: AtomGoogleAlertsEntry
 
       def self.able_to_parse?(xml)
-        Atom.able_to_parse?(xml) && (%r{<id>tag:google\.com,2005:[^<]+/com\.google/alerts/} === xml) # rubocop:disable Metrics/LineLength
+        Atom.able_to_parse?(xml) && (%r{<id>tag:google\.com,2005:[^<]+/com\.google/alerts/} === xml) # rubocop:disable Style/CaseEquality
       end
 
       def self.preprocess(xml)

data/lib/feedjira/parser/atom_google_alerts_entry.rb

@@ -1,3 +1,7 @@
+# frozen_string_literal: true
+
+require "uri"
+
 module Feedjira
   module Parser
     # Parser for dealing with Feedburner Atom feed entries.
@@ -8,12 +12,11 @@ module Feedjira
 
       def url
         url = super
+        return unless url&.start_with?("https://www.google.com/url?")
 
-        if url && url.start_with?("https://www.google.com/url?")
-          uri = URI(url)
-          cons = URI.decode_www_form(uri.query).assoc("url")
-          cons && cons[1]
-        end
+        uri = URI(url)
+        cons = URI.decode_www_form(uri.query).assoc("url")
+        cons && cons[1]
       end
     end
   end

data/lib/feedjira/parser/atom_youtube.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Feedjira
   module Parser
     # Parser for dealing with RSS feeds.
@@ -12,8 +14,8 @@ module Feedjira
 
       elements :entry, as: :entries, class: AtomYoutubeEntry
 
-      def self.able_to_parse?(xml) #:nodoc:
-        %r{xmlns:yt="http://www.youtube.com/xml/schemas/2015"} =~ xml
+      def self.able_to_parse?(xml) # :nodoc:
+        xml.include?("xmlns:yt=\"http://www.youtube.com/xml/schemas/2015\"")
       end
     end
   end

data/lib/feedjira/parser/atom_youtube_entry.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Feedjira
   module Parser
     class AtomYoutubeEntry

data/lib/feedjira/parser/globally_unique_identifier.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Feedjira
   module Parser
     class GloballyUniqueIdentifier

data/lib/feedjira/parser/google_docs_atom.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require File.expand_path("./atom", File.dirname(__FILE__))
 module Feedjira
   module Parser
@@ -7,7 +9,7 @@ module Feedjira
       element :title
       element :subtitle, as: :description
       element :link, as: :url, value: :href, with: { type: "text/html" }
-      element :link, as: :feed_url, value: :href, with: { type: "application/atom+xml" } # rubocop:disable Metrics/LineLength
+      element :link, as: :feed_url, value: :href, with: { type: "application/atom+xml" }
       elements :link, as: :links, value: :href
       elements :entry, as: :entries, class: GoogleDocsAtomEntry
 
@@ -15,8 +17,8 @@ module Feedjira
         @url ||= links.first
       end
 
-      def self.able_to_parse?(xml) #:nodoc:
-        %r{<id>https?://docs\.google\.com/.*\</id\>} =~ xml
+      def self.able_to_parse?(xml) # :nodoc:
+        %r{<id>https?://docs\.google\.com/.*</id>} =~ xml
       end
 
       def feed_url