fat_free_crm 0.18.2 → 0.19.0

data/spec/models/users/user_spec.rb

@@ -11,7 +11,7 @@
 #
 #  id                  :integer         not null, primary key
 #  username            :string(32)      default(""), not null
-#  email               :string(64)      default(""), not null
+#  email               :string(254)     default(""), not null
 #  first_name          :string(32)
 #  last_name           :string(32)
 #  title               :string(64)
@@ -23,21 +23,27 @@
 #  yahoo               :string(32)
 #  google              :string(32)
 #  skype               :string(32)
-#  password_hash       :string(255)     default(""), not null
+#  encrypted_password  :string(255)     default(""), not null
 #  password_salt       :string(255)     default(""), not null
-#  persistence_token   :string(255)     default(""), not null
-#  perishable_token    :string(255)     default(""), not null
-#  last_login_at       :datetime
-#  current_login_at    :datetime
-#  last_login_ip       :string(255)
-#  current_login_ip    :string(255)
-#  login_count         :integer         default(0), not null
+#  last_sign_in_at     :datetime
+#  current_sign_in_at  :datetime
+#  last_sign_in_ip     :string(255)
+#  current_sign_in_ip  :string(255)
+#  sign_in_count       :integer         default(0), not null
 #  deleted_at          :datetime
 #  created_at          :datetime
 #  updated_at          :datetime
 #  admin               :boolean         default(FALSE), not null
 #  suspended_at        :datetime
-#  single_access_token :string(255)
+#  unconfirmed_email   :string(254)     default(""), not null
+#  reset_password_token    :string(255)
+#  reset_password_sent_at  :datetime
+#  remember_token          :string(255)
+#  remember_created_at     :datetime
+#  authentication_token    :string(255)
+#  confirmation_token      :string(255)
+#  confirmed_at            :datetime
+#  confirmation_sent_at    :datetime
 #
 
 require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper')
@@ -75,6 +81,12 @@ describe User do
         end
       end
 
+      it "should not destroy the user if she owns a comment" do
+        account = build(:account, user: @current_user)
+        FactoryBot.create(:comment, user: @user, commentable: account)
+        expect(@user.destroyable?(@current_user)).to eq(false)
+      end
+
       it "should not destroy the current user" do
         expect(@user.destroyable?(@user)).to eq(false)
       end
@@ -202,22 +214,6 @@ describe User do
     end
   end
 
-  describe "Setting single access token" do
-    it "should update single_access_token attribute if it is not set already" do
-      @user = build(:user, single_access_token: nil)
-
-      @user.set_single_access_token
-      expect(@user.single_access_token).not_to eq(nil)
-    end
-
-    it "should not update single_access_token attribute if it is set already" do
-      @user = build(:user, single_access_token: "token")
-
-      @user.set_single_access_token
-      expect(@user.single_access_token).to eq("token")
-    end
-  end
-
   describe "serialization" do
     let(:user) { build(:user) }
 

data/spec/routing/users_routing_spec.rb

@@ -9,12 +9,38 @@ require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
 
 describe UsersController do
   describe "routing" do
-    it "doesn't recognize #index" do
-      expect(get: "/users").not_to be_routable
+    it "recognizes #index" do
+      expect(get: "/users").to route_to(controller: "users", action: "index")
     end
 
-    it "recognizes and generates #new as /signup" do
-      expect(get: "/signup").to route_to(controller: "users", action: "new")
+    it "recognizes and generates Devise registrations routes" do
+      expect(get: "/users/sign_up").to route_to(controller: "registrations", action: "new")
+      expect(get: "/users/edit").to route_to(controller: "registrations", action: "edit")
+      expect(get: "/users/cancel").to route_to(controller: "registrations", action: "cancel")
+      expect(post: "/users").to route_to(controller: "registrations", action: "create")
+      expect(put: "/users").to route_to(controller: "registrations", action: "update")
+      expect(patch: "/users").to route_to(controller: "registrations", action: "update")
+      expect(delete: "/users").to route_to(controller: "registrations", action: "destroy")
+    end
+
+    it "recognizes and generates Devise sessions routes" do
+      expect(get: "/users/sign_in").to route_to(controller: "sessions", action: "new")
+      expect(post: "/users/sign_in").to route_to(controller: "sessions", action: "create")
+      expect(delete: "/users/sign_out").to route_to(controller: "sessions", action: "destroy")
+    end
+
+    it "recognizes and generates Devise passwords routes" do
+      expect(get: "/users/password/new").to route_to(controller: "passwords", action: "new")
+      expect(get: "/users/password/edit").to route_to(controller: "passwords", action: "edit")
+      expect(post: "/users/password").to route_to(controller: "passwords", action: "create")
+      expect(put: "/users/password").to route_to(controller: "passwords", action: "update")
+      expect(patch: "/users/password").to route_to(controller: "passwords", action: "update")
+    end
+
+    it "recognizes and generates Devise confirmations routes" do
+      expect(get: "/users/confirmation/new").to route_to(controller: "confirmations", action: "new")
+      expect(get: "/users/confirmation").to route_to(controller: "confirmations", action: "show")
+      expect(post: "/users/confirmation").to route_to(controller: "confirmations", action: "create")
     end
 
     it "recognizes and generates #show as /profile" do
@@ -29,10 +55,6 @@ describe UsersController do
       expect(get: "/users/aaron/edit").not_to be_routable
     end
 
-    it "recognizes and generates #create" do
-      expect(post: "/users").to route_to(controller: "users", action: "create")
-    end
-
     it "recognizes and generates #update" do
       expect(put: "/users/1").to route_to(controller: "users", action: "update", id: "1")
     end

data/spec/shared/controllers.rb

@@ -22,9 +22,7 @@ shared_examples "auto complete" do
 
     # We don't save Admin/Users autocomplete controller in a session since Users are not
     # exposed through the Jumpbox.
-    unless controller.class.to_s.starts_with?("Admin::")
-      expect(session[:auto_complete]).to eq(@controller.controller_name.to_sym)
-    end
+    expect(session[:auto_complete]).to eq(@controller.controller_name.to_sym) unless controller.class.to_s.starts_with?("Admin::")
   end
 
   it "should render application/_auto_complete template" do
@@ -39,12 +37,8 @@ shared_examples "attach" do
     expect(@model.send(@attachment.class.name.tableize)).to include(@attachment)
     expect(assigns[:attachment]).to eq(@attachment)
     expect(assigns[:attached]).to eq([@attachment])
-    if @model.is_a?(Campaign) && (@attachment.is_a?(Lead) || @attachment.is_a?(Opportunity))
-      expect(assigns[:campaign]).to eq(@attachment.reload.campaign)
-    end
-    if @model.is_a?(Account) && @attachment.respond_to?(:account) # Skip Tasks...
-      expect(assigns[:account]).to eq(@attachment.reload.account)
-    end
+    expect(assigns[:campaign]).to eq(@attachment.reload.campaign) if @model.is_a?(Campaign) && (@attachment.is_a?(Lead) || @attachment.is_a?(Opportunity))
+    expect(assigns[:account]).to eq(@attachment.reload.account) if @model.is_a?(Account) && @attachment.respond_to?(:account) # Skip Tasks...
     expect(response).to render_template("entities/attach")
   end
 

data/spec/spec_helper.rb

@@ -8,15 +8,15 @@
 require 'rubygems'
 
 ENV["RAILS_ENV"] = 'test'
-require File.expand_path("../../config/environment", __FILE__)
+require File.expand_path('../config/environment', __dir__)
 require 'rspec/rails'
 require 'capybara/rails'
 require 'paper_trail/frameworks/rspec'
 
-require 'acts_as_fu'
 require 'factory_bot_rails'
 require 'ffaker'
 require 'timecop'
+require 'webdrivers'
 
 # Requires supporting ruby files with custom matchers and macros, etc,
 # in spec/support/ and its subdirectories.
@@ -41,6 +41,14 @@ RSpec.configure do |config|
   # RSpec configuration options for Fat Free CRM.
   config.include RSpec::Rails::Matchers
   config.include FactoryBot::Syntax::Methods
+  config.include Devise::Test::ControllerHelpers, type: :controller
+  config.include Devise::Test::ControllerHelpers, type: :view
+  config.include Devise::Test::IntegrationHelpers, type: :features
+  config.include Warden::Test::Helpers
+  config.include DeviseHelpers
+  config.include FeatureHelpers
+
+  Warden.test_mode!
 
   config.before(:each) do
     # Overwrite locale settings within "config/settings.yml" if necessary.

data/spec/support/assert_select.rb

@@ -155,6 +155,7 @@ module RSpec # :nodoc:
 
       def prepare_args(args, current_scope = nil)
         return args if current_scope.nil?
+
         defaults = current_scope.options || { strict: false, xml: false }
         args << {} unless args.last.is_a?(::Hash)
         args.last[:strict] = defaults[:strict] if args.last[:strict].nil?

data/spec/support/devise_helpers.rb

@@ -0,0 +1,28 @@
+# frozen_string_literal: true
+
+# Copyright (c) 2008-2013 Michael Dvorkin and contributors.
+#
+# Fat Free CRM is freely distributable under the terms of MIT license.
+# See MIT-LICENSE file or http://www.opensource.org/licenses/mit-license.php
+
+module DeviseHelpers
+  def login
+    user = create :user
+    perform_login(user)
+  end
+
+  def login_admin
+    admin = FactoryBot.create(:user, admin: true)
+    perform_login(admin)
+  end
+
+  def perform_login(user)
+    user.confirm
+    user.update_attribute(:suspended_at, nil)
+    sign_in user
+  end
+
+  def current_user
+    User.find_by_id(session['warden.user.user.key'][0][0])
+  end
+end

data/spec/{features/support/helpers.rb → support/feature_helpers.rb}

@@ -5,21 +5,23 @@
 # Fat Free CRM is freely distributable under the terms of MIT license.
 # See MIT-LICENSE file or http://www.opensource.org/licenses/mit-license.php
 #------------------------------------------------------------------------------
-module HelperMethods
+
+module FeatureHelpers
   # Put helper methods you need to be available in all acceptance specs here.
 
   def do_login(options = {})
     @user = create(:user, options)
-    visit '/login'
-    fill_in "authentication_username", with: @user.username
-    fill_in "authentication_password", with: @user.password
-    click_button "Login"
+    @user.confirm
+    @user.update_attribute(:suspended_at, nil)
+    login_as(@user)
   end
 
   def login_as_user(user)
-    visit '/login'
-    fill_in "authentication_username", with: user.username
-    fill_in "authentication_password", with: user.password
+    user.confirm
+    user.update_attribute(:suspended_at, nil)
+    visit '/users/sign_in'
+    fill_in "user[email]", with: user.username
+    fill_in "user[password]", with: user.password
     click_button "Login"
   end
 
@@ -28,5 +30,3 @@ module HelperMethods
     do_login(options) unless @user.present?
   end
 end
-
-RSpec.configuration.include HelperMethods, type: :feature

data/spec/support/macros.rb

@@ -24,7 +24,10 @@ end
 #----------------------------------------------------------------------------
 def stub_task_total(view = "pending")
   settings = (view == "completed" ? Setting.task_completed : Setting.task_bucket)
-  settings.each_with_object(all: 0) { |key, hash| hash[key] = 1; hash }
+  settings.each_with_object(all: 0) do |key, hash|
+    hash[key] = 1
+    hash
+  end
 end
 
 # Get current server timezone and set it (see rake time:zones:local for details).

data/spec/views/contacts/update.js.haml_spec.rb

@@ -118,7 +118,7 @@ describe "/contacts/update" do
 
       it "errors: should show disabled accounts dropdown" do
         render
-        expect(rendered).to include("crm.create_or_select_account(#{@referer =~ /\/accounts\//})")
+        expect(rendered).to include("crm.create_or_select_account(#{@referer =~ %r{/accounts/}})")
       end
 
       it "should redraw the [edit_contact] form and shake it" do

data/spec/views/opportunities/update.js.haml_spec.rb

@@ -137,7 +137,7 @@ describe "/opportunities/update" do
 
       it "should show disabled accounts dropdown when called from accounts landing page" do
         render
-        expect(rendered).to include("crm.create_or_select_account(#{@referer =~ /\/accounts\//})")
+        expect(rendered).to include("crm.create_or_select_account(#{@referer =~ %r{/accounts/}})")
       end
 
       it "should redraw the [edit_opportunity] form and shake it" do

data/vendor/gems/ransack_ui-1.3.4/.gitignore

@@ -0,0 +1,17 @@
+*.gem
+*.rbc
+.bundle
+.config
+.yardoc
+Gemfile.lock
+InstalledFiles
+_yardoc
+coverage
+doc/
+lib/bundler/man
+pkg
+rdoc
+spec/reports
+test/tmp
+test/version_tmp
+tmp

data/vendor/gems/ransack_ui-1.3.4/Gemfile

@@ -0,0 +1,7 @@
+source 'https://rubygems.org'
+
+# Include rake in Gemfile so that `bundle exec rake` doesn't raise an error
+gem 'rake', :group => :test
+
+# Specify your gem's dependencies in ransack_ui.gemspec
+gemspec

data/vendor/gems/ransack_ui-1.3.4/LICENSE.txt

@@ -0,0 +1,22 @@
+Copyright (c) 2012 Nathan Broadbent
+
+MIT License
+
+Permission is hereby granted, free of charge, to any person obtaining
+a copy of this software and associated documentation files (the
+"Software"), to deal in the Software without restriction, including
+without limitation the rights to use, copy, modify, merge, publish,
+distribute, sublicense, and/or sell copies of the Software, and to
+permit persons to whom the Software is furnished to do so, subject to
+the following conditions:
+
+The above copyright notice and this permission notice shall be
+included in all copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
+MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
+NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
+LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
+OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
+WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

data/vendor/gems/ransack_ui-1.3.4/README.md

@@ -0,0 +1,57 @@
+# Ransack UI
+
+Provides HTML templates and JavaScript to build a fully functional
+advanced search form using Ransack.
+
+Please note: this project is still in *alpha* and the following instructions are not yet complete/fully working.
+
+## Installation
+
+Add this line to your application's Gemfile:
+
+    gem 'ransack_ui'
+
+And then execute:
+
+    $ bundle
+
+Or install it yourself as:
+
+    $ gem install ransack_ui
+
+## Usage
+
+Make your model ransackable (if you name associations, it will enable you to search them aswell).
+
+```ruby
+has_ransackable_associations %w(account tags)
+ransack_can_autocomplete
+```
+
+In your controller, where you'd like to add search functionality, add the following before_filter hook. You can change the 'index' action if needed.
+
+```ruby
+before_filter :load_ransack_search, :only => :index
+```
+
+Insert the following helper call into your rails view code where you'd like the search form to appear.
+
+```ruby
+= ransack_ui_search
+```
+
+Now you can start playing with the results.
+
+## Contributing
+
+1. Fork it
+2. Create your feature branch (`git checkout -b my-new-feature`)
+3. Commit your changes (`git commit -am 'Add some feature'`)
+4. Push to the branch (`git push origin my-new-feature`)
+5. Create new Pull Request
+
+## Credits / Acknowledgements
+
+* Nathan Broadbent (ndbroadbent) - creator of ransack_ui code
+* Ernie Miller (ernie) for creating ransack - https://github.com/ernie/ransack
+* Steve Kenworthy (steveyken) - for tiny tweaks

data/vendor/gems/ransack_ui-1.3.4/Rakefile

@@ -0,0 +1 @@
+require "bundler/gem_tasks"

data/vendor/gems/ransack_ui-1.3.4/app/assets/javascripts/ransack/predicates.js.coffee

@@ -0,0 +1,41 @@
+window.Ransack ?= {}
+
+Ransack.predicates =
+  eq: 'not_eq'
+  cont: 'not_cont'
+  matches: 'does_not_match'
+  start: 'not_start'
+  end: 'not_end'
+  present: 'blank'
+  null: 'not_null'
+  lt: 'gteq'
+  gt: 'lteq'
+  in: 'not_in'
+  true: 'false'
+
+# Setup supported predicates for each column type.
+Ransack.type_predicates = {}
+((o, f) -> f.call o) Ransack.type_predicates, ->
+  @text = @string = ['eq', 'cont', 'matches', 'start', 'end', 'present', 'in']
+  @boolean = ['true', 'null']
+  @integer = @float = @decimal = ['eq', 'null', 'lt', 'gt', 'in']
+  @date = @datetime = @time = ['eq', 'null', 'lt', 'gt']
+
+# Setup input field types for each predicate
+Ransack.predicate_inputs = {}
+((o, f) -> f.call o) Ransack.predicate_inputs, ->
+  @cont = @matches = @start = @end = @in = 'string'
+  @present = @null = @true = false
+  @eq = @gt = @lt = (type) ->
+    switch type
+      when 'string','text' then 'string'
+      when 'integer','float','decimal' then 'numeric'
+      when 'date','datetime','time' then type
+      else false # Hide for unhandled types.
+
+# Setup predicates for fixed select options. Includes relevant any/all permutations
+Ransack.option_predicates = ['eq', 'eq_any', 'not_eq', 'not_eq_all', 'null', 'not_null']
+
+# Use a tags input for 'in' if Select2 is available
+if Select2?
+  Ransack.predicate_inputs.in = 'tags'