fat_free_crm 0.18.2 → 0.19.0

data/spec/helpers/admin/field_groups_helper_spec.rb

@@ -9,7 +9,7 @@ require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper')
 
 describe Admin::FieldGroupsHelper do
   it "should return the correct info text about tag restrictions and classes for groups" do
-    field_group = build(:field_group, klass_name: "Contact", label: "Test Field Group")
+    field_group = create(:field_group, klass_name: "Contact", label: "Test Field Group")
     html = helper.field_group_subtitle(field_group)
     expect(html).to include("Test Field Group")
     expect(html).to include("This field group applies to contacts tagged with")

data/spec/helpers/users_helper_spec.rb

@@ -24,16 +24,16 @@ describe UsersHelper do
 
   describe "user_select" do
     it "includes blank option" do
-      expect(user_select(:lead, [user1, user2], myself)).to match(/<option value="">Unassigned<\/option>/)
+      expect(user_select(:lead, [user1, user2], myself)).to match(%r{<option value="">Unassigned</option>})
     end
 
     it "includes myself" do
-      expect(user_select(:lead, [user1, user2], myself)).to match(/<option value="54">Myself<\/option>/)
+      expect(user_select(:lead, [user1, user2], myself)).to match(%r{<option value="54">Myself</option>})
     end
 
     it "includes other users" do
-      expect(user_select(:lead, [user1, user2], myself)).to match(/<option value="60">Bob Hope<\/option>/)
-      expect(user_select(:lead, [user1, user2], myself)).to match(/<option value="75">Billy Joel<\/option>/)
+      expect(user_select(:lead, [user1, user2], myself)).to match(%r{<option value="60">Bob Hope</option>})
+      expect(user_select(:lead, [user1, user2], myself)).to match(%r{<option value="75">Billy Joel</option>})
     end
   end
 end

data/spec/lib/comment_extensions_spec.rb

@@ -11,16 +11,22 @@ describe FatFreeCRM::CommentExtensions do
   describe "add_comment_by_user" do
     let(:user) { create(:user) }
 
-    before :each do
-      build_model(:commentable_entity) do
-        string :subscribed_users
-        serialize :subscribed_users, Set
+    before do
+      ActiveRecord::Base.connection.create_table(:commentable_entities) do |t|
+        t.string :subscribed_users
+      end
 
+      class CommentableEntity < ActiveRecord::Base
+        serialize :subscribed_users, Set
         acts_as_commentable
         uses_comment_extensions
       end
     end
 
+    after do
+      ActiveRecord::Base.connection.drop_table(:commentable_entities)
+    end
+
     it "should create a comment for user" do
       entity = CommentableEntity.create
       entity.add_comment_by_user("I will handle this one", user)

data/spec/lib/errors_spec.rb

@@ -13,7 +13,7 @@ describe 'ActiveModel Validation Errors' do
       validates_presence_of :title, message: '^Missing title'
     end
 
-    adam = Adam.create(username: 'adam', email: 'adam@example.com')
+    adam = Adam.create(username: 'adam', email: 'adam@example.com', password: 'ouchmyrib')
     expect(adam.valid?).to eq(false)
     expect(adam.errors[:title]).to eq(['^Missing title'])
     expect(adam.errors.full_messages[0]).to eq('Missing title')
@@ -24,7 +24,7 @@ describe 'ActiveModel Validation Errors' do
       validates_presence_of :title, message: 'missing'
     end
 
-    eve = Eve.create(username: 'eve', email: 'eve@example.com')
+    eve = Eve.create(username: 'eve', email: 'eve@example.com', password: 'doyoulikeapples')
     expect(eve.valid?).to eq(false)
     expect(eve.errors[:title]).to eq(['missing'])
     expect(eve.errors.full_messages[0]).to eq('Title missing')

data/spec/lib/mail_processor/dropbox_spec.rb

@@ -280,7 +280,7 @@ describe FatFreeCRM::MailProcessor::Dropbox do
     it "should extract text and strip tags from multipart text/html" do
       text = @dropbox.send(:plain_text_body, Mail.new(DROPBOX_EMAILS[:html]))
       expect(text).to be_present
-      expect(text).not_to match(/<\/?[^>]*>/)
+      expect(text).not_to match(%r{</?[^>]*>})
     end
   end
 

data/spec/lib/mail_processor/sample_emails/dropbox.rb

@@ -17,7 +17,7 @@ DROPBOX_EMAILS = {
     #{FFaker::Lorem.paragraph}
 
     Aaron
-EMAIL
+  EMAIL
 
   html: <<~EMAIL,
     From: Aaron Assembler <aaron@example.com>
@@ -34,7 +34,7 @@ EMAIL
         <p>Aaron</p>
       </body>
     </html>
-EMAIL
+  EMAIL
 
   first_line: <<~EMAIL,
     From: Aaron Assembler <aaron@example.com>
@@ -48,7 +48,7 @@ EMAIL
     #{FFaker::Lorem.paragraph}
 
     Aaron
-EMAIL
+  EMAIL
 
   first_line_lead: <<~EMAIL,
     From: Aaron Assembler <aaron@example.com>
@@ -62,7 +62,7 @@ EMAIL
     #{FFaker::Lorem.paragraph}
 
     Aaron
-EMAIL
+  EMAIL
 
   first_line_contact: <<~EMAIL,
     From: Aaron Assembler <aaron@example.com>
@@ -76,7 +76,7 @@ EMAIL
     #{FFaker::Lorem.paragraph}
 
     Aaron
-EMAIL
+  EMAIL
 
   forwarded: <<~EMAIL,
     From: Aaron Assembler <aaron@example.com>
@@ -95,9 +95,9 @@ EMAIL
     #{FFaker::Lorem.paragraph}
 
     Ben
-EMAIL
+  EMAIL
 
-  multipart: <<~EMAIL,
+  multipart: <<~EMAIL
     From: Aaron Assembler <aaron@example.com>
     To: Ben Bootloader <ben@example.com>
     Subject: Hi there
@@ -169,5 +169,5 @@ EMAIL
     ADpMhSwQ4p2Bz9o8V84oX868ufPn0KNLn64hAgA7
 
     --_006_200DA2FF7EAFC04BAD979DB9CF293BB365151E88CLEARWATERtesta_--
-EMAIL
+  EMAIL
 }

data/spec/lib/permissions_spec.rb

@@ -8,12 +8,17 @@
 require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
 
 describe FatFreeCRM::Permissions do
-  before :each do
-    build_model(:user_with_permission) do
+  before do
+    ActiveRecord::Base.connection.create_table(:user_with_permissions) do |t|
+      t.string :access
+    end
+    class UserWithPermission < ActiveRecord::Base
       uses_user_permissions
-      string :access
     end
   end
+  after do
+    ActiveRecord::Base.connection.drop_table(:user_with_permissions)
+  end
 
   describe "initialization" do
     it "should add 'has_many permissions' to the model" do

data/spec/mailers/devise_mailer_spec.rb

@@ -0,0 +1,35 @@
+# frozen_string_literal: true
+
+# Copyright (c) 2008-2013 Michael Dvorkin and contributors.
+#
+# Fat Free CRM is freely distributable under the terms of MIT license.
+# See MIT-LICENSE file or http://www.opensource.org/licenses/mit-license.php
+#------------------------------------------------------------------------------
+require 'spec_helper'
+
+describe DeviseMailer do
+  describe "reset_password_instructions" do
+    let(:user) { build(:user, email: "forgot_my_password@example.com") }
+    let(:mail) { DeviseMailer.reset_password_instructions(user, user.reset_password_token) }
+
+    before(:each) do
+      allow(user).to receive(:reset_password_token).and_return("62fe5299b45513f9d22a2e1454f35dd43d62ba50")
+    end
+
+    it "sets fatfree as the sender" do
+      expect(mail.from).to eql(["noreply@fatfreecrm.com"])
+    end
+
+    it "sets user 'forgot_my_password@example.com' as recipient" do
+      expect(mail.to).to eq(["forgot_my_password@example.com"])
+    end
+
+    it "sets the subject" do
+      expect(mail.subject).to eq("Reset password instructions")
+    end
+
+    it "includes password reset link in body" do
+      expect(mail.body.encoded).to have_link('Change my password', href: "http://www.example.com/users/password/edit?reset_password_token=#{user.reset_password_token}")
+    end
+  end
+end

data/spec/mailers/user_mailer_spec.rb

@@ -8,32 +8,6 @@
 require 'spec_helper'
 
 describe UserMailer do
-  describe "password_reset_instructions" do
-    let(:user) { build(:user, email: "forgot_my_password@example.com") }
-    let(:mail) { UserMailer.password_reset_instructions(user) }
-
-    before(:each) do
-      allow(I18n).to receive(:t).with(:password_reset_instruction).and_return("Password Reset Instructions")
-      allow(user).to receive(:perishable_token).and_return("62fe5299b45513f9d22a2e1454f35dd43d62ba50")
-    end
-
-    it "sets fatfree as the sender" do
-      expect(mail.from).to eql(["noreply@fatfreecrm.com"])
-    end
-
-    it "sets user 'forgot_my_password@example.com' as recipient" do
-      expect(mail.to).to eq(["forgot_my_password@example.com"])
-    end
-
-    it "sets the subject" do
-      expect(mail.subject).to eq("Fat Free CRM: Password Reset Instructions")
-    end
-
-    it "includes password reset link in body" do
-      expect(mail.body.encoded).to match("http://www.example.com/passwords/62fe5299b45513f9d22a2e1454f35dd43d62ba50/edit")
-    end
-  end
-
   describe "assigned_entity_notification" do
     let(:assigner) { build(:user, first_name: "Bob", last_name: "Hope") }
     let(:assignee) { build(:user, email: "assignee@example.com") }

data/spec/models/entities/account_spec.rb

@@ -34,6 +34,33 @@ describe Account do
     Account.create!(name: "Test Account")
   end
 
+  describe "Creating or selecting" do
+    it "must create a new account" do
+      @account = Account.create_or_select_for(nil, name: "Account T")
+
+      expect(Account.count).to eq(1)
+      expect(Account.first).to eq(@account)
+    end
+
+    it "must select an existing account based on id" do
+      @account = create(:account)
+
+      expect(Account.create_or_select_for(nil, id: @account.id)).to eq(@account)
+    end
+
+    it "must select an existing account based on name" do
+      @account = create(:account)
+
+      expect(Account.create_or_select_for(nil, name: @account.name)).to eq(@account)
+    end
+
+    it "must create a new account based on existing model" do
+      @contact = create(:contact)
+      @account = Account.create_or_select_for(@contact, name: "Account T")
+      expect(@account.user).to eq(@contact.user)
+    end
+  end
+
   describe "Attach" do
     before do
       @account = create(:account)

data/spec/models/entities/contact_spec.rb

@@ -41,8 +41,18 @@
 require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper')
 
 describe Contact do
+  let(:user) { create(:user) }
+
   it "should create a new instance given valid attributes" do
-    Contact.create!(first_name: "Billy", last_name: "Bones")
+    Contact.create!(first_name: "Billy", last_name: "Bones", user: user)
+  end
+
+  it "must create a new instance for a given model" do
+    lead = create(:lead)
+    account = create(:account)
+    opportunity = create(:opportunity)
+    @contact = Contact.create_for(lead, account, opportunity, account: {})
+    expect(@contact.valid?).to eq true
   end
 
   describe "Update existing contact" do
@@ -217,3 +227,88 @@ describe Contact do
     end
   end
 end
+
+describe "field validations" do
+  let(:new_record) do
+    Contact.new(
+      first_name: "ChristopherChristopherChristopherChristopherChristopherChristopherChristopher",
+      last_name: "BonesBonesBonesBonesBonesBonesBonesBonesBonesBonesBonesBonesBonesBonesBonesBones",
+      title: 'This is a really long title for the contact and it should thow an error.',
+      department: 'This is a really long name for the department and it should thow an error.',
+      email: 'bob_dillionbob_dillionbob_dillionbob_dillionbob_dillionbob_dillionbob_dillionbob_dillionbob_dillionbob_dillionbob_dillionbob_dillionbob_dillionbob_dillionbob_dillionbob_dillionbob_dillionbob_dillionbob_dillionbob_dillionbob_dillionbob_dillionbob_dillionbob_dillionbob_dillionbob_dillionbob_dillionbob_dillionbob_dillionbob_dillionbob_dillionbob_dillionbob_dillionbob_dillionbob_dillionbob_dillionbob_dillionbob_dillionbob_dillionbob_dillion@example.com',
+      alt_email: 'bob_dillionbob_dillionbob_dillionbob_dillionbob_dillionbob_dillionbob_dillionbob_dillionbob_dillionbob_dillionbob_dillionbob_dillionbob_dillionbob_dillionbob_dillionbob_dillionbob_dillionbob_dillionbob_dillionbob_dillionbob_dillionbob_dillionbob_dillionbob_dillionbob_dillionbob_dillionbob_dillionbob_dillionbob_dillionbob_dillionbob_dillionbob_dillionbob_dillionbob_dillionbob_dillionbob_dillionbob_dillionbob_dillionbob_dillionbob_dillion@example.com',
+      phone: '+1 123 456 7891 123 456 7891 123 456 7891 123 456 7891 123 456 789',
+      mobile: '+1 123 456 7891 123 456 7891 123 456 7891 123 456 7891 123 456 789',
+      fax: '+1 123 456 7891 123 456 7891 123 456 789 123 456 7891 123 456 789',
+      blog: 'This is a test of how many characters before it throws an error message.This is a test of how many characters before it throws an error message.This is a test of how many characters before it throws an error message.',
+      linkedin: 'This is my linkedin name and it is way to long. This is my linkedin name and it is way to long. This is my linkedin name and it is way to long.',
+      twitter: 'This is my twitter name and it is way to long. This is my twitter name and it is way to long. This is my twitter name and it is way to long.',
+      skype: 'This is my skype name and it is way to long. This is my skype name and it is way to long. This is my skype name and it is way to long.'
+    )
+  end
+
+  it "validate first_name max_length 64" do
+    expect(new_record).to_not be_valid
+    expect(new_record.errors.messages[:first_name]).to include("is too long (maximum is 64 characters)")
+  end
+
+  it "validate last_name max_length 64" do
+    expect(new_record).to_not be_valid
+    expect(new_record.errors.messages[:last_name]).to include("is too long (maximum is 64 characters)")
+  end
+
+  it "validate title max_length 64" do
+    expect(new_record).to_not be_valid
+    expect(new_record.errors.messages[:title]).to include("is too long (maximum is 64 characters)")
+  end
+
+  it "validate department max_length 254" do
+    expect(new_record).to_not be_valid
+    expect(new_record.errors.messages[:department]).to include("is too long (maximum is 64 characters)")
+  end
+
+  it "validate email max_length 254" do
+    expect(new_record).to_not be_valid
+    expect(new_record.errors.messages[:email]).to include("is too long (maximum is 254 characters)")
+  end
+
+  it "validate alt_email max_length 254" do
+    expect(new_record).to_not be_valid
+    expect(new_record.errors.messages[:alt_email]).to include("is too long (maximum is 254 characters)")
+  end
+
+  it "validate phone max_length 32" do
+    expect(new_record).to_not be_valid
+    expect(new_record.errors.messages[:phone]).to include("is too long (maximum is 32 characters)")
+  end
+
+  it "validate mobile max_length 32" do
+    expect(new_record).to_not be_valid
+    expect(new_record.errors.messages[:mobile]).to include("is too long (maximum is 32 characters)")
+  end
+
+  it "validate fax max_length 32" do
+    expect(new_record).to_not be_valid
+    expect(new_record.errors.messages[:fax]).to include("is too long (maximum is 32 characters)")
+  end
+
+  it "validate blog max_length 128" do
+    expect(new_record).to_not be_valid
+    expect(new_record.errors.messages[:blog]).to include("is too long (maximum is 128 characters)")
+  end
+
+  it "validate linkedin max_length 128" do
+    expect(new_record).to_not be_valid
+    expect(new_record.errors.messages[:linkedin]).to include("is too long (maximum is 128 characters)")
+  end
+
+  it "validate twitter max_length 128" do
+    expect(new_record).to_not be_valid
+    expect(new_record.errors.messages[:twitter]).to include("is too long (maximum is 128 characters)")
+  end
+
+  it "validate skype max_length 128" do
+    expect(new_record).to_not be_valid
+    expect(new_record.errors.messages[:skype]).to include("is too long (maximum is 128 characters)")
+  end
+end

data/spec/models/fields/custom_field_date_pair_spec.rb

@@ -67,7 +67,8 @@ describe CustomFieldDatePair do
 
     it "when from > to it should not be valid" do
       foo = double(cf_event_from: @today, cf_event_to: @today - 1.day)
-      err = double(:errors); allow(err).to receive(:add)
+      err = double(:errors)
+      allow(err).to receive(:add)
       expect(foo).to receive(:errors).and_return(err)
       @to.custom_validator(foo)
     end
@@ -82,7 +83,8 @@ describe CustomFieldDatePair do
     it "should call custom field validation on super class" do
       from = CustomFieldDatePair.new(name: 'cf_event_from', required: true)
       foo = double(cf_event_from: nil)
-      err = double(:errors); allow(err).to receive(:add)
+      err = double(:errors)
+      allow(err).to receive(:add)
       expect(foo).to receive(:errors).and_return(err)
       from.custom_validator(foo)
     end

data/spec/models/fields/custom_field_spec.rb

@@ -111,7 +111,8 @@ describe CustomField do
     it "should have errors if custom field is required" do
       event = CustomField.new(name: 'cf_event', required: true)
       foo = double(cf_event: nil)
-      err = double(:errors); allow(err).to receive(:add)
+      err = double(:errors)
+      allow(err).to receive(:add)
       expect(foo).to receive(:errors).and_return(err)
       event.custom_validator(foo)
     end
@@ -119,7 +120,8 @@ describe CustomField do
     it "should have errors if custom field is longer than maxlength" do
       event = CustomField.new(name: 'cf_event', maxlength: 5)
       foo = double(cf_event: "This is too long")
-      err = double(:errors); allow(err).to receive(:add)
+      err = double(:errors)
+      allow(err).to receive(:add)
       expect(foo).to receive(:errors).and_return(err)
       event.custom_validator(foo)
     end

data/spec/models/observers/entity_observer_spec.rb

@@ -10,7 +10,7 @@ require 'spec_helper'
 describe EntityObserver do
   before do
     allow(Setting).to receive(:host).and_return('http://www.example.com')
-    allow(PaperTrail).to receive(:whodunnit).and_return(assigner)
+    allow(PaperTrail.request).to receive(:whodunnit).and_return(assigner)
   end
 
   %i[account contact lead opportunity].each do |entity_type|

data/spec/models/polymorphic/version_spec.rb

@@ -24,10 +24,10 @@ require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper')
 
 describe Version, versioning: true do
   let(:current_user) { create(:user) }
-  before { PaperTrail.whodunnit = current_user.id.to_s }
+  before { PaperTrail.request.whodunnit = current_user.id.to_s }
 
   it "should create a new instance given valid attributes" do
-    create(:version, whodunnit: PaperTrail.whodunnit, item: create(:lead))
+    create(:version, whodunnit: PaperTrail.request.whodunnit, item: create(:lead))
   end
 
   describe "with multiple version records" do
@@ -35,7 +35,7 @@ describe Version, versioning: true do
       @lead = create(:lead)
 
       %w[create destroy update view].each do |event|
-        create(:version, event: event, item: @lead, whodunnit: PaperTrail.whodunnit)
+        create(:version, event: event, item: @lead, whodunnit: PaperTrail.request.whodunnit)
         create(:version, event: event, item: @lead, whodunnit: "1")
       end
     end
@@ -72,7 +72,7 @@ describe Version, versioning: true do
     describe "Create, update, and delete (#{item})" do
       before :each do
         @item = create(item.to_sym, user: current_user)
-        @conditions = { item_id: @item.id, item_type: @item.class.name, whodunnit: PaperTrail.whodunnit }
+        @conditions = { item_id: @item.id, item_type: @item.class.name, whodunnit: PaperTrail.request.whodunnit }
       end
 
       it "should add a version when creating new #{item}" do
@@ -101,7 +101,7 @@ describe Version, versioning: true do
       it "should add a version when commenting on a #{item}" do
         @comment = create(:comment, commentable: @item, user: current_user)
 
-        @version = Version.where(related_id: @item.id, related_type: @item.class.name, whodunnit: PaperTrail.whodunnit, event: 'create').first
+        @version = Version.where(related_id: @item.id, related_type: @item.class.name, whodunnit: PaperTrail.request.whodunnit, event: 'create').first
         expect(@version).not_to eq(nil)
       end
     end
@@ -129,7 +129,7 @@ describe Version, versioning: true do
   describe "Action refinements for task updates" do
     before do
       @task = create(:task, user: current_user)
-      @conditions = { item_id: @task.id, item_type: @task.class.name, whodunnit: PaperTrail.whodunnit }
+      @conditions = { item_id: @task.id, item_type: @task.class.name, whodunnit: PaperTrail.request.whodunnit }
     end
 
     it "should create 'completed' task event" do
@@ -157,7 +157,7 @@ describe Version, versioning: true do
   describe "Rejecting a lead" do
     before do
       @lead = create(:lead, user: current_user, status: "new")
-      @conditions = { item_id: @lead.id, item_type: @lead.class.name, whodunnit: PaperTrail.whodunnit }
+      @conditions = { item_id: @lead.id, item_type: @lead.class.name, whodunnit: PaperTrail.request.whodunnit }
     end
 
     it "should create 'rejected' lead event" do