fat_free_crm 0.18.1 → 0.20.0

data/spec/factories/shared_factories.rb

@@ -7,9 +7,9 @@
 #------------------------------------------------------------------------------
 FactoryBot.define do
   factory :version do
-    whodunnit ""
+    whodunnit           { "" }
     item                { raise "Please specify :item for the version" }
-    event "create"
+    event               { "create" }
     created_at          { FactoryBot.generate(:time) }
   end
 
@@ -17,9 +17,11 @@ FactoryBot.define do
     user
     commentable         { raise "Please specify :commentable for the comment" }
     title               { FactoryBot.generate(:title) }
-    private false
+
+    private             { false }
+
     comment             { FFaker::Lorem.paragraph }
-    state "Expanded"
+    state               { "Expanded" }
     updated_at          { FactoryBot.generate(:time) }
     created_at          { FactoryBot.generate(:time) }
   end
@@ -31,14 +33,14 @@ FactoryBot.define do
     sent_from           { FFaker::Internet.email }
     sent_to             { FFaker::Internet.email }
     cc                  { FFaker::Internet.email }
-    bcc nil
+    bcc                 { nil }
     subject             { FFaker::Lorem.sentence }
     body                { FFaker::Lorem.paragraph[0, 255] }
-    header nil
+    header              { nil }
     sent_at             { FactoryBot.generate(:time) }
     received_at         { FactoryBot.generate(:time) }
-    deleted_at nil
-    state "Expanded"
+    deleted_at          { nil }
+    state               { "Expanded" }
     updated_at          { FactoryBot.generate(:time) }
     created_at          { FactoryBot.generate(:time) }
   end
@@ -55,7 +57,7 @@ FactoryBot.define do
     address_type        { %w[Business Billing Shipping].sample }
     updated_at          { FactoryBot.generate(:time) }
     created_at          { FactoryBot.generate(:time) }
-    deleted_at nil
+    deleted_at          { nil }
   end
 
   factory :avatar do

data/spec/factories/task_factories.rb

@@ -8,17 +8,17 @@
 FactoryBot.define do
   factory :task do
     user
-    asset nil
-    assigned_to nil
-    completed_by nil
+    asset               { nil }
+    assigned_to         { nil }
+    completed_by        { nil }
     name                { FFaker::Lorem.sentence[0, 64] }
-    priority nil
+    priority            { nil }
     category            { %w[call email follow_up lunch meeting money presentation trip].sample }
-    bucket "due_asap"
+    bucket              { "due_asap" }
     due_at              { FactoryBot.generate(:time) }
     background_info     { FFaker::Lorem.paragraph[0, 255] }
-    completed_at nil
-    deleted_at nil
+    completed_at        { nil }
+    deleted_at          { nil }
     updated_at          { FactoryBot.generate(:time) }
     created_at          { FactoryBot.generate(:time) }
   end

data/spec/factories/user_factories.rb

@@ -7,7 +7,7 @@
 #------------------------------------------------------------------------------
 FactoryBot.define do
   factory :user do
-    username            { FactoryBot.generate(:username) }
+    username            { FFaker::InternetSE.user_name_variant_short }
     email               { FFaker::Internet.email }
     first_name          { FFaker::Name.first_name }
     last_name           { FFaker::Name.last_name }
@@ -16,31 +16,31 @@ FactoryBot.define do
     alt_email           { FFaker::Internet.email }
     phone               { FFaker::PhoneNumber.phone_number }
     mobile              { FFaker::PhoneNumber.phone_number }
-    aim nil
-    yahoo nil
-    google nil
-    skype nil
-    admin false
-    password_hash       { SecureRandom.hex(64) }
+    aim                 { nil }
+    yahoo               { nil }
+    google              { nil }
+    skype               { nil }
+    admin               { false }
+    encrypted_password  { SecureRandom.hex(64) }
     password_salt       { SecureRandom.hex(64) }
-    persistence_token   { SecureRandom.hex(64) }
-    perishable_token    { SecureRandom.hex(10) }
-    single_access_token nil
-    current_login_at    { FactoryBot.generate(:time) }
-    last_login_at       { FactoryBot.generate(:time) }
-    last_login_ip "127.0.0.1"
-    current_login_ip "127.0.0.1"
-    login_count         { rand(1..100) }
-    deleted_at nil
+    last_sign_in_at     { FactoryBot.generate(:time) }
+    current_sign_in_at  { FactoryBot.generate(:time) }
+    last_sign_in_ip     { "127.0.0.1" }
+    current_sign_in_ip  { "127.0.0.1" }
+    sign_in_count       { rand(1..100) }
+    deleted_at          { nil }
     updated_at          { FactoryBot.generate(:time) }
     created_at          { FactoryBot.generate(:time) }
-    suspended_at nil
-    password "password"
-    password_confirmation "password"
-  end
+    suspended_at        { nil }
+    password            { "password" }
+    password_confirmation { "password" }
 
+    # For unit tests, we dont need to enforce uniqueness
+    to_create { |instance| instance.save(validate: false) }
+  end
+  
   factory :admin do
-    admin true
+    admin { true }
   end
 
   factory :permission do

data/spec/features/acceptance_helper.rb

@@ -8,4 +8,4 @@
 require 'spec_helper'
 
 # Put your acceptance spec helpers inside /spec/features/support
-Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].each { |f| require f }
+Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].sort.each { |f| require f }

data/spec/features/accounts_spec.rb

@@ -31,8 +31,8 @@ feature 'Accounts', '
       click_link 'Create Account'
       expect(page).to have_selector('#account_name', visible: true)
       fill_in 'account_name', with: 'My new account'
-      select 'Affiliate', from: 'account_category'
-      select 'Myself', from: 'account_assigned_to'
+      select2 'Affiliate', from: 'Category:'
+      select2 'Myself', from: 'Assigned to:'
       click_link 'Contact Information'
       fill_in 'account_phone', with: '+1 2345 6789'
       fill_in 'account_website', with: 'http://www.example.com'

data/spec/features/admin/groups_spec.rb

@@ -5,7 +5,7 @@
 # Fat Free CRM is freely distributable under the terms of MIT license.
 # See MIT-LICENSE file or http://www.opensource.org/licenses/mit-license.php
 #------------------------------------------------------------------------------
-require File.expand_path("../../acceptance_helper.rb", __FILE__)
+require File.expand_path('../acceptance_helper.rb', __dir__)
 
 feature 'Groups tab', '
   In order to increase customer satisfaction
@@ -23,7 +23,7 @@ feature 'Groups tab', '
     click_link 'create a new group'
     expect(page).to have_selector('#group_name', visible: true)
     fill_in 'group_name', with: 'The Enterprise Bridge'
-    select 'Mr Spock', from: 'group_user_ids'
+    select2 'Mr Spock', from: 'Users'
     click_button 'Create Group'
     expect(page).to have_content('The Enterprise Bridge')
     expect(page).to have_content('members: Mr Spock')

data/spec/features/admin/users_spec.rb

@@ -5,7 +5,7 @@
 # Fat Free CRM is freely distributable under the terms of MIT license.
 # See MIT-LICENSE file or http://www.opensource.org/licenses/mit-license.php
 #------------------------------------------------------------------------------
-require File.expand_path("../../acceptance_helper.rb", __FILE__)
+require File.expand_path('../acceptance_helper.rb', __dir__)
 
 feature 'Users tab', '
   In order to increase customer satisfaction
@@ -25,9 +25,11 @@ feature 'Users tab', '
     fill_in 'user_email', with: 'lightning@example.com'
     fill_in 'user_first_name', with: 'Captain'
     fill_in 'user_last_name', with: 'Thunder'
+    fill_in 'user_password', with: 'password'
+    fill_in 'user_password_confirmation', with: 'password'
     fill_in 'user_title', with: 'Chief'
     fill_in 'user_company', with: 'Weather Inc.'
-    select 'Superheroes', from: 'user_group_ids'
+    select2 'Superheroes', from: 'Groups:'
 
     click_button 'Create User'
     expect(find('#users')).to have_content('Captain Thunder')

data/spec/features/campaigns_spec.rb

@@ -5,7 +5,7 @@
 # Fat Free CRM is freely distributable under the terms of MIT license.
 # See MIT-LICENSE file or http://www.opensource.org/licenses/mit-license.php
 #------------------------------------------------------------------------------
-require File.expand_path("../acceptance_helper.rb", __FILE__)
+require File.expand_path('acceptance_helper.rb', __dir__)
 
 feature 'Campaigns', '
   In order to increase customer satisfaction
@@ -31,7 +31,7 @@ feature 'Campaigns', '
       click_link 'Create Campaign'
       expect(page).to have_selector('#campaign_name', visible: true)
       fill_in 'campaign_name', with: 'Cool Campaign'
-      select 'On Hold', from: 'campaign_status'
+      select2 'On Hold', from: 'Status:'
       click_link 'Comment'
       fill_in 'comment_body', with: 'This campaign is very important'
       click_button 'Create Campaign'
@@ -66,7 +66,7 @@ feature 'Campaigns', '
       click_link 'My Cool Campaign'
       click_link 'Edit'
       fill_in 'campaign_name', with: 'My Even Cooler Campaign'
-      select 'Started', from: 'campaign_status'
+      select2 'Started', from: 'Status:'
       click_button 'Save Campaign'
       expect(page).to have_content('My Even Cooler Campaign')
       expect(page).to have_content('My Even Cooler Campaign')

data/spec/features/contacts_spec.rb

@@ -5,7 +5,7 @@
 # Fat Free CRM is freely distributable under the terms of MIT license.
 # See MIT-LICENSE file or http://www.opensource.org/licenses/mit-license.php
 #------------------------------------------------------------------------------
-require File.expand_path("../acceptance_helper.rb", __FILE__)
+require File.expand_path('acceptance_helper.rb', __dir__)
 
 feature 'Contacts', '
   In order to increase customer satisfaction
@@ -77,7 +77,8 @@ feature 'Contacts', '
       fill_in 'contact_last_name', with: 'Subject'
       fill_in 'contact_email', with: "test.subject@example.com"
       click_button 'Save Contact'
-      expect(summary_element).to have_content('Test Subject')
+      sleep(3) # TODO: A better ajax wait, or redirect on save
+      expect(find('#edit_contact_title')).to have_content('Test Subject')
 
       click_link 'Dashboard'
       expect(activities_element).to have_content("Bill Murray updated contact Test Subject")
@@ -115,10 +116,6 @@ feature 'Contacts', '
     find('#main')
   end
 
-  def summary_element
-    find('#summary')
-  end
-
   def menu_element
     find('#menu')
   end

data/spec/features/dashboard_spec.rb

@@ -5,7 +5,7 @@
 # Fat Free CRM is freely distributable under the terms of MIT license.
 # See MIT-LICENSE file or http://www.opensource.org/licenses/mit-license.php
 #------------------------------------------------------------------------------
-require File.expand_path("../acceptance_helper.rb", __FILE__)
+require File.expand_path('acceptance_helper.rb', __dir__)
 
 feature 'Dashboard', '
   In order to monitor activity

data/spec/features/devise/sign_in_spec.rb

@@ -0,0 +1,58 @@
+# frozen_string_literal: true
+
+# Copyright (c) 2008-2013 Michael Dvorkin and contributors.
+#
+# Fat Free CRM is freely distributable under the terms of MIT license.
+# See MIT-LICENSE file or http://www.opensource.org/licenses/mit-license.php
+#------------------------------------------------------------------------------
+require 'features/acceptance_helper'
+
+feature 'Devise Sign-in' do
+  background do
+    Setting.user_signup = :needs_approval
+    @user = create :user,
+                   username: 'john',
+                   password: 'password',
+                   password_confirmation: 'password',
+                   email: 'john@example.com',
+                   sign_in_count: 0
+  end
+
+  scenario 'without confirmation' do
+    login_process('john', 'password')
+    expect(page).to have_content("You have to confirm your email address before continuing.")
+  end
+
+  scenario 'without approval' do
+    @user.confirm
+    login_process('john', 'password')
+    expect(page).to have_content("Your account has not been approved yet.")
+  end
+
+  scenario 'with approved and confirmed account' do
+    @user.confirm
+    @user.update_attribute(:suspended_at, nil)
+    login_process('john', 'password')
+    expect(page).to have_content("Signed in successfully.")
+  end
+
+  scenario 'invalid credentials' do
+    login_process('jo', 'pass')
+    expect(current_path).to eq "/users/sign_in"
+    expect(page).to have_content("Invalid Email or password")
+  end
+
+  scenario 'login with email' do
+    @user.confirm
+    @user.update_attribute(:suspended_at, nil)
+    login_process('john@example.com', 'password')
+    expect(page).to have_content("Signed in successfully")
+  end
+
+  def login_process(username, password)
+    visit '/users/sign_in'
+    fill_in 'user[email]', with: username
+    fill_in 'user[password]', with: password
+    click_button 'Login'
+  end
+end

data/spec/features/devise/sign_up_spec.rb

@@ -0,0 +1,36 @@
+# frozen_string_literal: true
+
+# Copyright (c) 2008-2013 Michael Dvorkin and contributors.
+#
+# Fat Free CRM is freely distributable under the terms of MIT license.
+# See MIT-LICENSE file or http://www.opensource.org/licenses/mit-license.php
+#------------------------------------------------------------------------------
+require 'features/acceptance_helper'
+
+feature 'Devise Sign-up' do
+  scenario 'with valid credentials' do
+    visit "/users/sign_up"
+
+    fill_in "user[email]", with: "john@example.com"
+    fill_in "user[username]", with: "john"
+    fill_in "user[password]", with: "password"
+    fill_in "user[password_confirmation]", with: "password"
+    click_button("Sign Up")
+
+    expect(current_path).to eq "/users/sign_in"
+    expect(page).to have_content("A message with a confirmation link has been sent to your email address. Please follow the link to activate your account.")
+  end
+
+  scenario 'without credentials' do
+    visit "/users/sign_up"
+    click_button("Sign Up")
+
+    expect(page).to have_content("6 errors prohibited this User from being saved")
+    expect(page).to have_content("Please specify email address")
+    expect(page).to have_content("Email is too short (minimum is 3 characters)")
+    expect(page).to have_content("Email is invalid")
+    expect(page).to have_content("Please specify username")
+    expect(page).to have_content("Username is invalid")
+    expect(page).to have_content("Password can't be blank")
+  end
+end

data/spec/features/leads_spec.rb

@@ -5,7 +5,7 @@
 # Fat Free CRM is freely distributable under the terms of MIT license.
 # See MIT-LICENSE file or http://www.opensource.org/licenses/mit-license.php
 #------------------------------------------------------------------------------
-require File.expand_path("../acceptance_helper.rb", __FILE__)
+require File.expand_path('acceptance_helper.rb', __dir__)
 
 feature 'Leads', '
   In order to increase sales
@@ -36,13 +36,16 @@ feature 'Leads', '
       fill_in 'lead_email', with: 'mr_lead@example.com'
       fill_in 'lead_phone', with: '+44 1234 567890'
       click_link 'Status'
-      select 'Myself', from: 'lead_assigned_to'
-      select 'Contacted', from: 'lead_status'
-      select 'Campaign', from: 'lead_source'
+      select2 'Myself', from: 'Assigned to:'
+      select2 'Contacted', from: 'Status:'
+      select2 'Campaign', from: 'Source:'
       click_link 'Comment'
       fill_in 'comment_body', with: 'This is an important lead.'
-      click_link 'Status'
-      select 'Contacted', from: 'lead_status'
+
+      # TODO: Refactor to a page object
+      # This panel is already open, so clicking status again closed the div.
+      # click_link 'Status'
+      select2 'Contacted', from: 'Status:'
       click_button 'Create Lead'
       expect(leads_element).to have_content('Mr Lead')
 
@@ -79,9 +82,10 @@ feature 'Leads', '
       fill_in 'lead_first_name', with: 'Mrs'
       fill_in 'lead_phone', with: '+44 0987 654321'
       click_link('Status')
-      select 'Rejected', from: 'lead_status'
+      select2 'Rejected', from: 'Status:'
       click_button 'Save Lead'
-      expect(summary_element).to have_content('Mrs Lead')
+      sleep(3) # TODO: A better AJAX observing call, or just a redirect on save.
+      expect(find('#title')).to have_content('Mrs Lead')
 
       click_link "Dashboard"
       expect(activities_element).to have_content("Bill Murray updated lead Mrs Lead")

data/spec/features/opportunities_overview_spec.rb

@@ -5,7 +5,7 @@
 # Fat Free CRM is freely distributable under the terms of MIT license.
 # See MIT-LICENSE file or http://www.opensource.org/licenses/mit-license.php
 #------------------------------------------------------------------------------
-require File.expand_path("../acceptance_helper.rb", __FILE__)
+require File.expand_path('acceptance_helper.rb', __dir__)
 
 feature 'Opportunities Overview', "
   In order to keep track of my team's responsibilities

data/spec/features/opportunities_spec.rb

@@ -5,7 +5,7 @@
 # Fat Free CRM is freely distributable under the terms of MIT license.
 # See MIT-LICENSE file or http://www.opensource.org/licenses/mit-license.php
 #------------------------------------------------------------------------------
-require File.expand_path("../acceptance_helper.rb", __FILE__)
+require File.expand_path('acceptance_helper.rb', __dir__)
 
 feature 'Opportunities', '
   In order to increase sales
@@ -38,7 +38,7 @@ feature 'Opportunities', '
       sleep(1)
       find('li', text: 'Example Account').click
       expect(page).to have_content('Example Account')
-      select 'Prospecting', from: 'opportunity_stage'
+      select2 'Prospecting', from: 'Stage'
       click_link 'Comment'
       fill_in 'comment_body', with: 'This is a very important opportunity.'
       click_button 'Create Opportunity'
@@ -67,7 +67,7 @@ feature 'Opportunities', '
   scenario "remembers the comment field when the creation was unsuccessful", js: true do
     visit opportunities_page
     click_link 'Create Opportunity'
-    select 'Prospecting', from: 'opportunity_stage'
+    select2 'Prospecting', from: 'Stage:'
 
     click_link 'Comment'
     fill_in 'comment_body', with: 'This is a very important opportunity.'
@@ -85,8 +85,8 @@ feature 'Opportunities', '
       click_link 'A Cool Opportunity'
       click_link 'Edit'
       fill_in 'opportunity_name', with: 'An Even Cooler Opportunity'
-      select 'Other Example Account', from: 'account_id'
-      select 'Analysis', from: 'opportunity_stage'
+      select2 'Other Example Account', from: 'Account (create new or select existing):'
+      select2 'Analysis', from: 'Stage:'
       click_button 'Save Opportunity'
       expect(page).to have_content('An Even Cooler Opportunity')
       click_link "Dashboard"
@@ -120,13 +120,13 @@ feature 'Opportunities', '
     expect(find('#opportunities')).not_to have_content("Opportunity 1")
   end
 
-  scenario 'should add note to opportunity', js: true do
+  scenario 'should add comment to opportunity', js: true do
     opportunity = create(:opportunity, name: 'Awesome Opportunity')
     visit opportunities_page
     click_link 'Awesome Opportunity'
     find("#opportunity_#{opportunity.id}_post_new_note").click
     fill_in 'comment[comment]', with: 'Most awesome opportunity'
-    click_button 'Add Note'
+    click_button 'Add Comment'
     expect(page).to have_content('Most awesome opportunity')
   end
 end

data/spec/features/support/browser.rb

@@ -7,17 +7,22 @@
 #------------------------------------------------------------------------------
 Capaybara.app_host = ENV['APP_URL'] if ENV['APP_URL']
 Capybara.default_max_wait_time = 7
+Capybara.server = :webrick
 
 if ENV['BROWSER'] == 'chrome'
   Capybara.register_driver :selenium do |app|
-    capabilities = Selenium::WebDriver::Remote::Capabilities.chrome(chromeOptions: { args: ['no-sandbox', 'headless', 'disable-gpu'] })
+    capabilities = Selenium::WebDriver::Remote::Capabilities.chrome(chromeOptions: { args: %w[no-sandbox headless disable-gpu] })
     Capybara::Selenium::Driver.new(app, browser: :chrome, desired_capabilities: capabilities)
   end
 else
+  # For local testing in an environment with a display or remote X server configured
+  # such as WSL2, use NO_HEADLESS=1 bundle exec rspec spec/features
+  #
+  # For modern firefox, use MARIONETTE=1 bundle exec rspec spec/features
   Capybara.register_driver :selenium do |app|
     options = Selenium::WebDriver::Firefox::Options.new
-    options.args << '--headless'
-    capabilities = Selenium::WebDriver::Remote::Capabilities.firefox(marionette: false)
+    options.args << '--headless' unless ENV['NO_HEADLESS'].present?
+    capabilities = Selenium::WebDriver::Remote::Capabilities.firefox(marionette: ENV['MARIONETTE'].present?)
     Capybara::Selenium::Driver.new(app, browser: :firefox, options: options, desired_capabilities: capabilities)
   end
 end

data/spec/features/support/selector_helpers.rb

@@ -7,7 +7,7 @@
 #------------------------------------------------------------------------------
 module SelectorHelpers
   def click_filter_tab(filter_name)
-    tab = find(:xpath, "//div[@class='filters']//td[contains(text(), '#{filter_name}')]")
+    tab = find(:xpath, "//div[@class='filters']//a[contains(text(), '#{filter_name}')]")
     tab.click
   end
 
@@ -22,6 +22,15 @@ module SelectorHelpers
       page.execute_script "$('#task_#{task_id} a')[1].click()"
     end
   end
+
+  # See github.com/goodwill/capybara-select2
+  def select2(value, options = {})
+    select2_container = find("div.label", text: options[:from]).find(:xpath, '..').find('.select2-container')
+
+    select2_container.find(".select2-selection").click
+    drop_container = ".select2-dropdown"
+    find(:xpath, "//body").find("#{drop_container} li.select2-results__option", text: value).click
+  end
 end
 
 RSpec.configuration.include SelectorHelpers, type: :feature

data/spec/features/tasks_spec.rb

@@ -5,7 +5,7 @@
 # Fat Free CRM is freely distributable under the terms of MIT license.
 # See MIT-LICENSE file or http://www.opensource.org/licenses/mit-license.php
 #------------------------------------------------------------------------------
-require File.expand_path("../acceptance_helper.rb", __FILE__)
+require File.expand_path('acceptance_helper.rb', __dir__)
 
 feature 'Tasks', '
   In order to increase keep track of things
@@ -33,9 +33,9 @@ feature 'Tasks', '
       click_link 'Create Task'
       expect(page).to have_selector('#task_name', visible: true)
       fill_in 'task_name', with: 'Task I Need To Do'
-      select 'Tomorrow', from: 'task_bucket'
-      select 'Myself', from: 'task_assigned_to'
-      select 'Call', from: 'task_category'
+      select2 'Tomorrow', from: 'Due:'
+      select2 'Myself', from: 'Assign to:'
+      select2 'Call', from: 'Category:'
       click_button 'Create Task'
       expect(page).to have_content('Task I Need To Do')
 
@@ -51,9 +51,9 @@ feature 'Tasks', '
       click_link 'Create Task'
       expect(page).to have_selector('#task_name', visible: true)
       fill_in 'task_name', with: 'Task For Someone Else'
-      select 'Tomorrow', from: 'task_bucket'
-      select 'Another User', from: 'task_assigned_to'
-      select 'Call', from: 'task_category'
+      select2 'Tomorrow', from: 'Due:'
+      select2 'Another User', from: 'Assign to:'
+      select2 'Call', from: 'Category:'
       click_button 'Create Task'
       expect(page).to have_content('The task has been created and assigned to Another User')
 

data/spec/helpers/accounts_helper_spec.rb

@@ -8,9 +8,66 @@
 require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
 
 describe AccountsHelper do
+  let(:assignee) { create(:user) }
   # Delete this example and add some real ones or delete this file
   it "should be included in the object returned by #helper" do
     included_modules = (class << helper; self; end).send :included_modules
     expect(included_modules).to include(AccountsHelper)
   end
+  describe '#display_pipeline' do
+    context 'when the pipeline is zero' do
+      it 'returns "N/A"' do
+        expect(display_value(0)).to eq('N/A')
+      end
+    end
+    context 'when the pipeline is has 300' do
+      it 'returns "$300"' do
+        expect(display_value(300)).to eq('$300')
+      end
+    end
+  end
+  describe '#display_won' do
+    context 'when the won is zero' do
+      it 'returns "N/A"' do
+        expect(display_value(0)).to eq('N/A')
+      end
+    end
+    context 'when the won is has 300' do
+      it 'returns "$300"' do
+        expect(display_value(300)).to eq('$300')
+      end
+    end
+  end
+  describe '#display_lost' do
+    context 'when the lost is zero' do
+      it 'returns "N/A"' do
+        expect(display_value(0)).to eq('N/A')
+      end
+    end
+    context 'when the lost is has 300' do
+      it 'returns "$300"' do
+        expect(display_value(300)).to eq('$300')
+      end
+    end
+  end
+  describe '#display_assigned' do
+    context 'when the name is under 16 chars' do
+      it 'returns the name' do
+        @account = create(:account)
+        allow(@account).to receive(:assignee).and_return(assignee)
+        allow(assignee).to receive(:full_name).and_return('Abe Lincoln')
+        allow(@account).to receive(:assigned_to).and_return(1)
+        expect(display_assigned(@account)).to eq('Abe Lincoln')
+      end
+    end
+    context 'when the name is over 16 chars' do
+      it 'returns the truncated name' do
+        @account = create(:account)
+        allow(@account).to receive(:assignee).and_return(assignee)
+        allow(assignee).to receive(:full_name).and_return('Richard Milhouse Nixon')
+        allow(@account).to receive(:assigned_to).and_return(1)
+        expect(display_assigned(@account)).to eq('Richard Milho...')
+      end
+    end
+  end
 end

data/spec/helpers/admin/field_groups_helper_spec.rb

@@ -9,7 +9,7 @@ require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper')
 
 describe Admin::FieldGroupsHelper do
   it "should return the correct info text about tag restrictions and classes for groups" do
-    field_group = build(:field_group, klass_name: "Contact", label: "Test Field Group")
+    field_group = create(:field_group, klass_name: "Contact", label: "Test Field Group")
     html = helper.field_group_subtitle(field_group)
     expect(html).to include("Test Field Group")
     expect(html).to include("This field group applies to contacts tagged with")