fat_free_crm 0.18.1 → 0.20.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: bb89ae97ee3b23e349affe50ca12d56cda21689f8bb317c7b877a48bd8fe4258
-  data.tar.gz: e548f576324a2c75e7daa6fd12997880ef295a82b353a500542c33f6ac064a78
+  metadata.gz: a4b6418c618ec04984f8f8261e3121e915b57ce2b55c5787d3393a8acb47adb9
+  data.tar.gz: 362ffdc71d5d01450d0475758f794972ec77dc79755f92196f4f72917e789798
 SHA512:
-  metadata.gz: 663ff8b5e566c482cc8f9e05b4b89ed04f9567df1409593ac6de0d99305029583f1943bcf9dd616b5a00cd16ca533c1f04a421535a773db57cabfa1b3ee778a2
-  data.tar.gz: 3f95330ec40b1dbb86d25c19d3ab66f9303115668318e9a074f95e05600a448b75810d751e83acd41c827b92476c2a6f413c9843bef44e4a1f7669d3067caf25
+  metadata.gz: 3a467bdd68e941d5c426a69fd07260ec11631163a8306c2d1b524fdd2c0e0f7f2d48ee78e2ad89e773010e2b0b17f386f90fe67f9388330bb07e53aba02344d0
+  data.tar.gz: 21943a700b302f3eb2f6544ebcba0ae6e70e50ecec337f94531f08ae16522c6d6d3cd49bf315f83963b597997ed7de38c11c17ace76495e346fed0b6a3f3f8a4

data/.github/workflows/brakeman-analysis.yml

@@ -0,0 +1,46 @@
+# This workflow integrates Brakeman with GitHub's Code Scanning feature
+# Brakeman is a static analysis security vulnerability scanner for Ruby on Rails applications
+
+name: Brakeman Scan
+
+on:
+  push:
+    branches: [ master ]
+  pull_request:
+    # The branches below must be a subset of the branches above
+    branches: [ master ]
+  schedule:
+    - cron: '20 13 * * 6'
+
+jobs:
+  brakeman-scan:
+    name: Brakeman Scan
+    runs-on: ubuntu-latest
+    steps:
+    # Checkout the repository to the GitHub Actions runner
+    - name: Checkout
+      uses: actions/checkout@v2
+
+    # Customize the ruby version depending on your needs
+    - name: Setup Ruby
+      uses: actions/setup-ruby@v1
+      with:
+        ruby-version: '2.7'
+
+    - name: Setup Brakeman
+      env:
+        BRAKEMAN_VERSION: '4.10' # SARIF support is provided in Brakeman version 4.10+
+      run: |
+        gem install brakeman --version $BRAKEMAN_VERSION
+
+    # Execute Brakeman CLI and generate a SARIF output with the security issues identified during the analysis
+    - name: Scan
+      continue-on-error: true
+      run: |
+        brakeman -f sarif -o output.sarif.json .
+
+    # Upload the SARIF file generated in the previous step
+    - name: Upload SARIF
+      uses: github/codeql-action/upload-sarif@v1
+      with:
+        sarif_file: output.sarif.json

data/.github/workflows/rubocop-analysis.yml

@@ -0,0 +1,40 @@
+# pulled from repo
+name: "Rubocop"
+
+on: push
+
+jobs:
+  rubocop:
+    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+
+    steps:
+    - name: Checkout repository
+      uses: actions/checkout@v2
+
+    # If running on a self-hosted runner, check it meets the requirements
+    # listed at https://github.com/ruby/setup-ruby#using-self-hosted-runners
+    - name: Set up Ruby
+      uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: 2.6
+
+    # This step is not necessary if you add the gem to your Gemfile
+    - name: Install Code Scanning integration
+      run: bundle add code-scanning-rubocop --version 0.3.0 --skip-install
+
+    - name: Install dependencies
+      run: bundle install
+
+    - name: Rubocop run
+      run: |
+        bash -c "
+          bundle exec rubocop --require code_scanning --format CodeScanning::SarifFormatter -o rubocop.sarif
+          [[ $? -ne 2 ]]
+        "
+
+    - name: Upload Sarif output
+      uses: github/codeql-action/upload-sarif@v1
+      with:
+        sarif_file: rubocop.sarif

data/.github/workflows/ruby.yml

@@ -0,0 +1,52 @@
+# This workflow uses actions that are not certified by GitHub.
+# They are provided by a third-party and are governed by
+# separate terms of service, privacy policy, and support
+# documentation.
+# This workflow will download a prebuilt Ruby version, install dependencies and run tests with Rake
+# For more information see: https://github.com/marketplace/actions/setup-ruby-jruby-and-truffleruby
+
+name: Rspec
+
+on:
+  push:
+    branches: [ master ]
+  pull_request:
+    branches: [ master ]
+
+jobs:
+  test:
+
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        ruby-version: ['2.7'] # , '2.7', '3.0'
+
+    steps:
+    - uses: actions/checkout@v2
+    - name: Set up Ruby
+    # To automatically get bug fixes and new Ruby versions for ruby/setup-ruby,
+    # change this to (see https://github.com/ruby/setup-ruby#versioning):
+    # uses: ruby/setup-ruby@v1
+      uses: ruby/setup-ruby@473e4d8fe5dd94ee328fdfca9f8c9c7afc9dae5e
+      with:
+        ruby-version: ${{ matrix.ruby-version }}
+        # bundler-cache: true # runs 'bundle install' and caches installed gems automatically
+
+    - name: Install dependencies
+      run: bundle install
+    - name: Prepare DB
+      run: DB=sqlite RAILS_ENV=test bundle exec rake spec:preparedb
+    - name: Run model tests
+      run: DB=sqlite bundle exec rake spec:models
+    - name: Run controller tests
+      run: bundle exec rake spec:controllers
+    - name: Run view tests
+      run: bundle exec rake spec:views
+    - name: Run helper tests
+      run: bundle exec rake spec:helpers
+    - name: Run route tests
+      run: bundle exec rake spec:routing
+    - name: Run mailer tests
+      run: bundle exec rake spec:mailers
+    - name: Run lib tests
+      run: bundle exec rake spec:lib

data/.rubocop_todo.yml

@@ -1,23 +1,33 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2018-02-02 11:21:41 +0300 using RuboCop version 0.52.1.
+# on 2021-05-09 11:26:41 +0930 using RuboCop version 0.82.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 1
+# Offense count: 3
 # Configuration parameters: Include.
-# Include: **/Gemfile, **/gems.rb
+# Include: **/*.gemfile, **/Gemfile, **/gems.rb
 Bundler/DuplicatedGem:
   Exclude:
     - 'Gemfile'
 
-# Offense count: 1
+# Offense count: 21
 # Cop supports --auto-correct.
-Layout/EmptyLinesAroundArguments:
-  Exclude:
-    - 'lib/fat_free_crm/permissions.rb'
+# Configuration parameters: EnforcedStyleAlignWith, AutoCorrect, Severity.
+# SupportedStylesAlignWith: keyword, variable, start_of_line
+Layout/EndAlignment:
+  Enabled: false
+
+# Offense count: 95
+# Cop supports --auto-correct.
+# Configuration parameters: AllowMultipleStyles, EnforcedHashRocketStyle, EnforcedColonStyle, EnforcedLastArgumentHashStyle.
+# SupportedHashRocketStyles: key, separator, table
+# SupportedColonStyles: key, separator, table
+# SupportedLastArgumentHashStyles: always_inspect, always_ignore, ignore_implicit, ignore_explicit
+Layout/HashAlignment:
+  Enabled: false
 
 # Offense count: 7
 # Cop supports --auto-correct.
@@ -28,51 +38,28 @@ Layout/SpaceInsideArrayLiteralBrackets:
   Exclude:
     - 'db/seeds/fields.rb'
 
-# Offense count: 20
+# Offense count: 21
 # Configuration parameters: AllowSafeAssignment.
 Lint/AssignmentInCondition:
   Enabled: false
 
 # Offense count: 2
+# Cop supports --auto-correct.
 Lint/BooleanSymbol:
   Exclude:
     - 'config/initializers/ransack.rb'
 
-# Offense count: 1
-Lint/Debugger:
-  Exclude:
-    - 'app/controllers/entities/opportunities_controller.rb'
-
 # Offense count: 1
 Lint/DuplicateMethods:
   Exclude:
     - 'lib/gravatar_image_tag.rb'
 
-# Offense count: 22
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyleAlignWith, AutoCorrect.
-# SupportedStylesAlignWith: keyword, variable, start_of_line
-Lint/EndAlignment:
-  Enabled: false
-
-# Offense count: 2
-Lint/HandleExceptions:
-  Exclude:
-    - 'config/environments/test.rb'
-    - 'lib/fat_free_crm/gem_dependencies.rb'
-
 # Offense count: 4
 Lint/ImplicitStringConcatenation:
   Exclude:
     - 'db/migrate/20121221033947_fix_country_mapping.rb'
     - 'lib/tasks/ffcrm/update_data.rake'
 
-# Offense count: 4
-Lint/IneffectiveAccessModifier:
-  Exclude:
-    - 'db/migrate/20100928030620_remove_uuid.rb'
-    - 'lib/gravatar_image_tag.rb'
-
 # Offense count: 5
 Lint/RescueException:
   Exclude:
@@ -85,31 +72,35 @@ Lint/ReturnInVoidContext:
     - 'app/models/setting.rb'
     - 'app/models/users/preference.rb'
 
-# Offense count: 1
-Lint/UriEscapeUnescape:
+# Offense count: 2
+# Configuration parameters: AllowComments.
+Lint/SuppressedException:
   Exclude:
-    - 'lib/gravatar_image_tag.rb'
+    - 'config/environments/test.rb'
+    - 'lib/fat_free_crm/gem_dependencies.rb'
 
-# Offense count: 4
-# Configuration parameters: ContextCreatingMethods, MethodCreatingMethods.
-Lint/UselessAccessModifier:
+# Offense count: 1
+Lint/UriEscapeUnescape:
   Exclude:
-    - 'app/models/fields/field.rb'
-    - 'app/models/users/user.rb'
-    - 'db/migrate/20100928030620_remove_uuid.rb'
     - 'lib/gravatar_image_tag.rb'
 
-# Offense count: 3
+# Offense count: 2
 Lint/UselessAssignment:
   Exclude:
-    - 'app/helpers/application_helper.rb'
     - 'app/views/home/index.atom.builder'
 
-# Offense count: 131
+# Offense count: 134
+# Configuration parameters: IgnoredMethods.
 Metrics/AbcSize:
   Max: 57
 
-# Offense count: 4
+# Offense count: 1
+# Configuration parameters: CountComments, ExcludedMethods.
+# ExcludedMethods: refine
+Metrics/BlockLength:
+  Max: 298
+
+# Offense count: 3
 # Configuration parameters: CountBlocks.
 Metrics/BlockNesting:
   Max: 4
@@ -117,23 +108,25 @@ Metrics/BlockNesting:
 # Offense count: 14
 # Configuration parameters: CountComments.
 Metrics/ClassLength:
-  Max: 209
+  Max: 184
 
 # Offense count: 29
+# Configuration parameters: IgnoredMethods.
 Metrics/CyclomaticComplexity:
   Max: 14
 
-# Offense count: 102
-# Configuration parameters: CountComments.
+# Offense count: 99
+# Configuration parameters: CountComments, ExcludedMethods.
 Metrics/MethodLength:
-  Max: 38
+  Max: 36
 
 # Offense count: 2
 # Configuration parameters: CountComments.
 Metrics/ModuleLength:
-  Max: 382
+  Max: 371
 
-# Offense count: 27
+# Offense count: 25
+# Configuration parameters: IgnoredMethods.
 Metrics/PerceivedComplexity:
   Max: 15
 
@@ -153,28 +146,36 @@ Naming/AccessorMethodName:
     - 'spec/controllers/entities/opportunities_controller_spec.rb'
     - 'spec/support/macros.rb'
 
-# Offense count: 1
-# Configuration parameters: Blacklist.
-# Blacklist: END, (?-mix:EO[A-Z]{1})
-Naming/HeredocDelimiterNaming:
+# Offense count: 3
+# Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames.
+# AllowedNames: io, id, to, by, on, in, at, ip, db, os, pp
+Naming/MethodParameterName:
   Exclude:
-    - 'app/controllers/passwords_controller.rb'
+    - 'app/models/fields/field.rb'
+    - 'app/models/polymorphic/comment.rb'
+    - 'lib/missing_translation_detector.rb'
 
-# Offense count: 5
-# Configuration parameters: NamePrefix, NamePrefixBlacklist, NameWhitelist, MethodDefinitionMacros.
+# Offense count: 4
+# Configuration parameters: NamePrefix, ForbiddenPrefixes, AllowedMethods, MethodDefinitionMacros.
 # NamePrefix: is_, has_, have_
-# NamePrefixBlacklist: is_, has_, have_
-# NameWhitelist: is_a?
+# ForbiddenPrefixes: is_, has_, have_
+# AllowedMethods: is_a?
 # MethodDefinitionMacros: define_method, define_singleton_method
 Naming/PredicateName:
   Exclude:
     - 'spec/**/*'
     - 'app/inputs/date_time_input.rb'
-    - 'app/models/entities/opportunity.rb'
     - 'app/models/users/user.rb'
     - 'lib/fat_free_crm/fields.rb'
     - 'lib/fat_free_crm/mail_processor/base.rb'
 
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: PreferredName.
+Naming/RescuedExceptionsVariableName:
+  Exclude:
+    - 'spec/support/assert_select.rb'
+
 # Offense count: 12
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: snake_case, normalcase, non_integer
@@ -182,32 +183,8 @@ Naming/VariableNumber:
   Exclude:
     - 'spec/controllers/home_controller_spec.rb'
 
-# Offense count: 2
-# Cop supports --auto-correct.
-# Configuration parameters: AutoCorrect.
-Performance/HashEachMethods:
-  Exclude:
-    - 'app/controllers/entities/opportunities_controller.rb'
-    - 'lib/fat_free_crm/errors.rb'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: AutoCorrect.
-Performance/StartWith:
-  Exclude:
-    - 'app/helpers/versions_helper.rb'
-
-# Offense count: 1
-Security/Eval:
-  Exclude:
-    - 'lib/development_tasks/gem.rake'
-
-# Offense count: 1
-Security/MarshalLoad:
-  Exclude:
-    - 'app/models/users/preference.rb'
-
 # Offense count: 1
+# Configuration parameters: AllowOnConstant.
 Style/CaseEquality:
   Exclude:
     - 'app/models/fields/field.rb'
@@ -234,29 +211,28 @@ Style/ClassVars:
     - 'lib/fat_free_crm/tabs.rb'
     - 'lib/fat_free_crm/view_factory.rb'
 
-# Offense count: 2
+# Offense count: 1
 Style/CommentedKeyword:
   Exclude:
-    - 'app/models/users/authentication.rb'
     - 'db/migrate/20100928030617_drop_openid_tables.rb'
 
-# Offense count: 4
+# Offense count: 2
 Style/DoubleNegation:
   Exclude:
     - 'app/helpers/application_helper.rb'
-    - 'app/models/entities/opportunity.rb'
     - 'app/models/polymorphic/task.rb'
-    - 'lib/gravatar_image_tag.rb'
 
 # Offense count: 1
-Style/EvalWithLocation:
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: annotated, template, unannotated
+Style/FormatStringToken:
   Exclude:
-    - 'lib/fat_free_crm/permissions.rb'
+    - 'spec/factories/shared_factories.rb'
 
 # Offense count: 1
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle.
-# SupportedStyles: when_needed, always, never
+# SupportedStyles: always, always_true, never
 Style/FrozenStringLiteralComment:
   Exclude:
     - 'db/schema.rb'
@@ -268,44 +244,22 @@ Style/GlobalVars:
     - 'db/migrate/20100928030598_create_sessions.rb'
     - 'db/migrate/20120510025219_add_not_null_constraints_for_timestamp_columns.rb'
 
-# Offense count: 46
+# Offense count: 33
 # Configuration parameters: MinBodyLength.
 Style/GuardClause:
   Enabled: false
 
 # Offense count: 2
-Style/IdenticalConditionalBranches:
-  Exclude:
-    - 'app/helpers/application_helper.rb'
-
-# Offense count: 49
-# Cop supports --auto-correct.
-Style/IfUnlessModifier:
-  Enabled: false
-
-# Offense count: 16
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: line_count_dependent, lambda, literal
-Style/Lambda:
-  Exclude:
-    - 'app/models/entities/account.rb'
-    - 'app/models/entities/campaign.rb'
-    - 'app/models/entities/contact.rb'
-    - 'app/models/entities/lead.rb'
-    - 'app/models/entities/opportunity.rb'
-    - 'app/models/polymorphic/task.rb'
-    - 'app/models/users/user.rb'
-
-# Offense count: 2
-Style/MethodMissing:
+Style/MissingRespondToMissing:
   Exclude:
     - 'app/models/setting.rb'
     - 'lib/fat_free_crm/fields.rb'
 
-# Offense count: 1
+# Offense count: 3
 Style/MixinUsage:
   Exclude:
+    - 'bin/setup'
+    - 'bin/update'
     - 'spec/helpers/fields_helper_spec.rb'
 
 # Offense count: 2
@@ -314,66 +268,19 @@ Style/MultilineBlockChain:
     - 'lib/fat_free_crm/core_ext/string.rb'
     - 'lib/tasks/ffcrm/demo.rake'
 
-# Offense count: 2
-Style/MultilineTernaryOperator:
+# Offense count: 1
+Style/MultipleComparison:
   Exclude:
-    - 'app/models/users/authentication.rb'
+    - 'app/models/polymorphic/task.rb'
 
-# Offense count: 11
+# Offense count: 5
 # Cop supports --auto-correct.
-# Configuration parameters: AutoCorrect, EnforcedStyle.
+# Configuration parameters: AutoCorrect, EnforcedStyle, IgnoredMethods.
 # SupportedStyles: predicate, comparison
 Style/NumericPredicate:
   Exclude:
     - 'spec/**/*'
-    - 'app/helpers/admin/users_helper.rb'
-    - 'app/helpers/application_helper.rb'
-    - 'app/helpers/campaigns_helper.rb'
-    - 'app/helpers/tasks_helper.rb'
     - 'app/models/fields/custom_field.rb'
     - 'app/models/polymorphic/task.rb'
     - 'app/models/users/user.rb'
     - 'lib/tasks/ffcrm/demo.rake'
-
-# Offense count: 16
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, AllowInnerSlashes.
-# SupportedStyles: slashes, percent_r, mixed
-Style/RegexpLiteral:
-  Exclude:
-    - 'app/controllers/entities/contacts_controller.rb'
-    - 'app/controllers/entities/opportunities_controller.rb'
-    - 'app/helpers/application_helper.rb'
-    - 'app/models/list.rb'
-    - 'lib/development_tasks/license.rake'
-    - 'lib/fat_free_crm/core_ext/string.rb'
-    - 'spec/helpers/users_helper_spec.rb'
-    - 'spec/lib/mail_processor/dropbox_spec.rb'
-    - 'spec/views/contacts/update.js.haml_spec.rb'
-    - 'spec/views/opportunities/update.js.haml_spec.rb'
-
-# Offense count: 8
-# Cop supports --auto-correct.
-# Configuration parameters: AllowAsExpressionSeparator.
-Style/Semicolon:
-  Exclude:
-    - 'app/controllers/entities/leads_controller.rb'
-    - 'lib/fat_free_crm/permissions.rb'
-    - 'lib/tasks/ffcrm/setup.rake'
-    - 'spec/models/fields/custom_field_date_pair_spec.rb'
-    - 'spec/models/fields/custom_field_spec.rb'
-    - 'spec/support/macros.rb'
-
-# Offense count: 2
-# Cop supports --auto-correct.
-# Configuration parameters: ExactNameMatch, AllowPredicates, AllowDSLWriters, IgnoreClassMethods, Whitelist.
-# Whitelist: to_ary, to_a, to_c, to_enum, to_h, to_hash, to_i, to_int, to_io, to_open, to_path, to_proc, to_r, to_regexp, to_str, to_s, to_sym
-Style/TrivialAccessors:
-  Exclude:
-    - 'spec/support/auth_macros.rb'
-
-# Offense count: 1924
-# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
-# URISchemes: http, https
-Metrics/LineLength:
-  Max: 390

data/.travis.yml

@@ -1,35 +1,29 @@
 sudo: false
 language: ruby
 rvm:
-  - 2.4.2
-  - 2.5.0
+  - 2.6.5
+  - 2.7.1
+
+dist: bionic
 
 env:
   global:
     - BROWSER=chrome
   matrix:
-    - DB=postgres TEST_SUITE=rubocop
     - DB=postgres TEST_SUITE="rake spec:features"
     - DB=postgres TEST_SUITE="rake spec:models"
-    - DB=postgres TEST_SUITE="rake spec:controllers spec:lib spec:routing spec:mailers"
-    - DB=postgres TEST_SUITE="rake spec:views spec:helpers"
     - DB=mysql TEST_SUITE="rake spec:models"
-    - DB=sqlite TEST_SUITE="rake spec:models"
 
 matrix:
   fast_finish: true
-  exclude:
-    - rvm: 2.5.0
-      env: DB=postgres TEST_SUITE=rubocop
   allow_failures:
-    - rvm: 2.4.2
-      env: DB=mysql TEST_SUITE="rake spec:models"
-    - rvm: 2.4.2
-      env: DB=sqlite TEST_SUITE="rake spec:models"
-    - rvm: 2.5.0
+    - rvm: 2.6.5
+      env: DB=postgres TEST_SUITE="rake spec:features"
+    - rvm: 2.7.1
+      env: DB=postgres TEST_SUITE="rake spec:features"
+    - rvm: 2.7.1
       env: DB=mysql TEST_SUITE="rake spec:models"
-    - rvm: 2.5.0
-      env: DB=sqlite TEST_SUITE="rake spec:models"
+
 
 addons:
   chrome: stable
@@ -38,13 +32,10 @@ bundler_args: --path=vendor/bundle --without heroku
 
 cache: bundler
 
-before_install:
-  - "export DISPLAY=:99.0"
-  - "sh -e /etc/init.d/xvfb start"
-
 before_script:
   # gem update --system is a workaround for travis-ci/travis-ci#8978
   - "gem update --system"
+  - 'gem install bundler -v 1.17.3'
   - sh -c "cp config/database.$DB.yml config/database.yml"
   - sh -c "if [ \"$DB\" = 'postgres' ]; then psql -c 'create database fat_free_crm_test;' -U postgres; fi"
   - sh -c "if [ \"$DB\" = 'mysql' ]; then mysql -e 'create database fat_free_crm_test;'; fi"
@@ -61,3 +52,9 @@ notifications:
     on_success: change  # options: [always|never|change] default: always
     on_failure: always  # options: [always|never|change] default: always
     on_start: false     # default: false
+
+dist: xenial
+services:
+  - xvfb
+  - postgresql
+  - mysql