fat_free_crm 0.17.3 → 0.19.2

Sign up to get free protection for your applications and to get access to all the features.

Potentially problematic release.

This version of fat_free_crm might be problematic. Click here for more details.

Files changed (329) hide show
  1. checksums.yaml +4 -4
  2. data/.rubocop.yml +1 -1
  3. data/.rubocop_todo.yml +71 -148
  4. data/.travis.yml +35 -14
  5. data/CHANGELOG.md +92 -6
  6. data/CONTRIBUTORS.md +96 -53
  7. data/Dockerfile +45 -14
  8. data/Gemfile +23 -13
  9. data/Gemfile.lock +256 -248
  10. data/Procfile +1 -1
  11. data/README.md +9 -6
  12. data/Rakefile +1 -1
  13. data/app/assets/javascripts/crm.js.coffee +3 -3
  14. data/app/assets/javascripts/crm_select2.js.coffee +15 -14
  15. data/app/assets/stylesheets/common.scss +1 -1
  16. data/app/controllers/admin/application_controller.rb +1 -1
  17. data/app/controllers/admin/field_groups_controller.rb +9 -4
  18. data/app/controllers/admin/fields_controller.rb +4 -4
  19. data/app/controllers/admin/groups_controller.rb +1 -1
  20. data/app/controllers/admin/tags_controller.rb +2 -4
  21. data/app/controllers/admin/users_controller.rb +5 -8
  22. data/app/controllers/application_controller.rb +22 -45
  23. data/app/controllers/comments_controller.rb +16 -11
  24. data/{config/initializers/authlogic.rb → app/controllers/confirmations_controller.rb} +4 -2
  25. data/app/controllers/emails_controller.rb +0 -2
  26. data/app/controllers/entities/accounts_controller.rb +1 -3
  27. data/app/controllers/entities/campaigns_controller.rb +8 -5
  28. data/app/controllers/entities/contacts_controller.rb +4 -24
  29. data/app/controllers/entities/leads_controller.rb +16 -12
  30. data/app/controllers/entities/opportunities_controller.rb +17 -16
  31. data/app/controllers/entities_controller.rb +31 -12
  32. data/app/controllers/home_controller.rb +2 -4
  33. data/app/controllers/lists_controller.rb +5 -1
  34. data/app/controllers/passwords_controller.rb +3 -59
  35. data/{spec/features/support/maintain_sessions.rb → app/controllers/registrations_controller.rb} +12 -5
  36. data/{lib/development_tasks/gem.rake → app/controllers/sessions_controller.rb} +6 -6
  37. data/app/controllers/tasks_controller.rb +22 -17
  38. data/app/controllers/users_controller.rb +8 -29
  39. data/app/helpers/accounts_helper.rb +1 -1
  40. data/app/helpers/admin/users_helper.rb +1 -1
  41. data/app/helpers/application_helper.rb +28 -33
  42. data/app/helpers/campaigns_helper.rb +1 -1
  43. data/app/helpers/contacts_helper.rb +1 -3
  44. data/app/helpers/leads_helper.rb +1 -1
  45. data/app/helpers/opportunities_helper.rb +48 -3
  46. data/app/helpers/tasks_helper.rb +1 -1
  47. data/app/helpers/users_helper.rb +1 -3
  48. data/{config/initializers/paper_trail.rb → app/mailers/devise_mailer.rb} +5 -1
  49. data/app/mailers/user_mailer.rb +0 -9
  50. data/app/models/entities/account.rb +10 -10
  51. data/app/models/entities/campaign.rb +4 -6
  52. data/app/models/entities/contact.rb +24 -12
  53. data/app/models/entities/lead.rb +7 -14
  54. data/app/models/entities/opportunity.rb +10 -11
  55. data/app/models/fields/custom_field.rb +1 -0
  56. data/app/models/fields/custom_field_date_pair.rb +2 -0
  57. data/app/models/fields/field.rb +1 -3
  58. data/app/models/list.rb +1 -1
  59. data/app/models/observers/entity_observer.rb +3 -7
  60. data/app/models/observers/lead_observer.rb +2 -4
  61. data/app/models/observers/opportunity_observer.rb +5 -7
  62. data/app/models/observers/task_observer.rb +1 -1
  63. data/app/models/polymorphic/email.rb +2 -2
  64. data/app/models/polymorphic/task.rb +13 -9
  65. data/app/models/polymorphic/version.rb +3 -2
  66. data/app/models/setting.rb +2 -0
  67. data/app/models/users/ability.rb +3 -4
  68. data/app/models/users/permission.rb +3 -3
  69. data/app/models/users/preference.rb +2 -1
  70. data/app/models/users/user.rb +67 -42
  71. data/app/views/accounts/_top_section.html.haml +1 -1
  72. data/app/views/accounts/edit.js.haml +1 -1
  73. data/app/views/accounts/update.js.haml +2 -2
  74. data/app/views/admin/users/_user.html.haml +4 -4
  75. data/app/views/campaigns/_metrics.html.haml +3 -3
  76. data/app/views/contacts/_index_brief.html.haml +1 -1
  77. data/app/views/contacts/_index_full.html.haml +1 -1
  78. data/app/views/contacts/_index_long.html.haml +1 -1
  79. data/app/views/devise/confirmations/new.html.haml +9 -0
  80. data/app/views/devise/mailer/confirmation_instructions.html.haml +4 -0
  81. data/app/views/devise/mailer/password_change.html.haml +3 -0
  82. data/app/views/devise/mailer/reset_password_instructions.html.haml +6 -0
  83. data/app/views/devise/passwords/edit.html.haml +18 -0
  84. data/app/views/devise/passwords/new.html.haml +10 -0
  85. data/app/views/devise/registrations/new.html.haml +21 -0
  86. data/app/views/devise/sessions/new.html.haml +32 -0
  87. data/app/views/home/_opportunity.html.haml +4 -19
  88. data/app/views/layouts/_about.html.haml +5 -5
  89. data/app/views/layouts/_header.html.haml +3 -3
  90. data/app/views/layouts/admin/_header.html.haml +1 -1
  91. data/app/views/opportunities/_index_long.html.haml +1 -24
  92. data/app/views/opportunities/_sidebar_show.html.haml +3 -3
  93. data/app/views/opportunities/_top_section.html.haml +1 -1
  94. data/app/views/shared/_address.html.haml +5 -5
  95. data/app/views/shared/_empty.html.haml +1 -1
  96. data/app/views/shared/_paginate_with_per_page.html.haml +1 -0
  97. data/app/views/users/_avatar.html.haml +1 -1
  98. data/bin/bundle +1 -1
  99. data/bin/rails +1 -1
  100. data/bin/setup +38 -0
  101. data/bin/update +33 -0
  102. data/bin/yarn +13 -0
  103. data/config/application.rb +8 -6
  104. data/config/boot.rb +1 -1
  105. data/config/brakeman.ignore +2 -2
  106. data/config/database.postgres.docker.yml +5 -5
  107. data/config/environment.rb +1 -1
  108. data/config/environments/development.rb +1 -0
  109. data/config/environments/test.rb +7 -0
  110. data/config/initializers/action_mailer.rb +1 -3
  111. data/config/initializers/application_controller_renderer.rb +9 -0
  112. data/config/initializers/assets.rb +6 -11
  113. data/config/initializers/backtrace_silencers.rb +0 -6
  114. data/config/initializers/content_security_policy.rb +26 -0
  115. data/config/initializers/cookies_serializer.rb +3 -6
  116. data/config/initializers/devise.rb +289 -0
  117. data/config/initializers/filter_parameter_logging.rb +0 -5
  118. data/config/initializers/gravatar.rb +0 -1
  119. data/config/initializers/inflections.rb +0 -6
  120. data/config/initializers/mime_types.rb +1 -9
  121. data/config/initializers/new_framework_defaults_5_2.rb +40 -0
  122. data/config/initializers/relative_url_root.rb +1 -3
  123. data/config/initializers/session_store.rb +1 -3
  124. data/config/initializers/wrap_parameters.rb +4 -9
  125. data/config/locales/fat_free_crm.en-GB.yml +5 -5
  126. data/config/locales/fat_free_crm.en-US.yml +5 -5
  127. data/config/locales/fat_free_crm.fr.yml +1 -1
  128. data/config/locales/fat_free_crm.ru.yml +1 -0
  129. data/config/routes.rb +20 -9
  130. data/db/demo/users.yml +62 -81
  131. data/db/migrate/20100928030620_remove_uuid.rb +1 -2
  132. data/db/migrate/20120316045804_activities_to_versions.rb +1 -0
  133. data/db/migrate/20120510025219_add_not_null_constraints_for_timestamp_columns.rb +1 -0
  134. data/db/migrate/20180107082701_authlogic_to_devise.rb +58 -0
  135. data/db/schema.rb +48 -46
  136. data/docker-compose.yml +10 -0
  137. data/fat_free_crm.gemspec +12 -14
  138. data/lib/development_tasks/license.rake +2 -2
  139. data/lib/fat_free_crm/callback.rb +2 -2
  140. data/lib/fat_free_crm/comment_extensions.rb +2 -4
  141. data/lib/fat_free_crm/core_ext/string.rb +1 -1
  142. data/lib/fat_free_crm/engine.rb +2 -2
  143. data/lib/fat_free_crm/errors.rb +1 -1
  144. data/lib/fat_free_crm/export_csv.rb +1 -0
  145. data/lib/fat_free_crm/exportable.rb +1 -1
  146. data/lib/fat_free_crm/fields.rb +2 -2
  147. data/lib/fat_free_crm/gem_dependencies.rb +1 -1
  148. data/lib/fat_free_crm/gem_ext/simple_form/action_view_extensions/form_helper.rb +1 -3
  149. data/lib/fat_free_crm/i18n.rb +2 -2
  150. data/lib/fat_free_crm/mail_processor/base.rb +4 -10
  151. data/lib/fat_free_crm/mail_processor/dropbox.rb +5 -15
  152. data/lib/fat_free_crm/permissions.rb +7 -18
  153. data/lib/fat_free_crm/sortable.rb +1 -1
  154. data/lib/fat_free_crm/tabs.rb +2 -2
  155. data/lib/fat_free_crm/version.rb +2 -2
  156. data/lib/gravatar_image_tag.rb +7 -8
  157. data/lib/missing_translation_detector.rb +1 -0
  158. data/lib/tasks/ffcrm/missing_translations.rake +1 -0
  159. data/lib/tasks/ffcrm/setup.rake +13 -4
  160. data/lib/tasks/ffcrm/update_data.rake +2 -2
  161. data/script/rails +2 -2
  162. data/spec/controllers/admin/users_controller_spec.rb +25 -81
  163. data/spec/controllers/comments_controller_spec.rb +19 -19
  164. data/spec/controllers/emails_controller_spec.rb +2 -2
  165. data/spec/controllers/entities/accounts_controller_spec.rb +56 -56
  166. data/spec/controllers/entities/campaigns_controller_spec.rb +66 -66
  167. data/spec/controllers/entities/contacts_controller_spec.rb +69 -68
  168. data/spec/controllers/entities/leads_controller_spec.rb +126 -126
  169. data/spec/controllers/entities/opportunities_controller_spec.rb +101 -101
  170. data/spec/controllers/entities_controller_spec.rb +5 -0
  171. data/spec/controllers/home_controller_spec.rb +30 -30
  172. data/spec/controllers/tasks_controller_spec.rb +42 -40
  173. data/spec/controllers/users_controller_spec.rb +43 -113
  174. data/spec/factories/account_factories.rb +13 -13
  175. data/spec/factories/campaign_factories.rb +8 -8
  176. data/spec/factories/contact_factories.rb +18 -18
  177. data/spec/factories/field_factories.rb +11 -10
  178. data/spec/factories/lead_factories.rb +13 -13
  179. data/spec/factories/list_factories.rb +3 -3
  180. data/spec/factories/opportunity_factories.rb +9 -9
  181. data/spec/factories/sequences.rb +1 -1
  182. data/spec/factories/setting_factories.rb +5 -5
  183. data/spec/factories/shared_factories.rb +25 -23
  184. data/spec/factories/subscription_factories.rb +1 -1
  185. data/spec/factories/tag_factories.rb +1 -1
  186. data/spec/factories/task_factories.rb +11 -11
  187. data/spec/factories/user_factories.rb +27 -30
  188. data/spec/features/accounts_spec.rb +17 -4
  189. data/spec/features/admin/groups_spec.rb +2 -2
  190. data/spec/features/admin/users_spec.rb +4 -2
  191. data/spec/features/campaigns_spec.rb +5 -5
  192. data/spec/features/contacts_spec.rb +11 -5
  193. data/spec/features/dashboard_spec.rb +8 -8
  194. data/spec/features/devise/sign_in_spec.rb +58 -0
  195. data/spec/features/devise/sign_up_spec.rb +36 -0
  196. data/spec/features/leads_spec.rb +5 -5
  197. data/spec/features/opportunities_overview_spec.rb +16 -16
  198. data/spec/features/opportunities_spec.rb +35 -9
  199. data/spec/features/support/autocomlete_helper.rb +17 -0
  200. data/spec/features/support/browser.rb +5 -9
  201. data/spec/features/tasks_spec.rb +5 -5
  202. data/spec/helpers/admin/field_groups_helper_spec.rb +1 -1
  203. data/spec/helpers/application_helper_spec.rb +1 -1
  204. data/spec/helpers/tasks_helper_spec.rb +1 -1
  205. data/spec/helpers/users_helper_spec.rb +7 -7
  206. data/spec/lib/comment_extensions_spec.rb +11 -5
  207. data/spec/lib/errors_spec.rb +2 -2
  208. data/spec/lib/mail_processor/base_spec.rb +3 -3
  209. data/spec/lib/mail_processor/comment_replies_spec.rb +3 -3
  210. data/spec/lib/mail_processor/dropbox_spec.rb +17 -17
  211. data/spec/lib/mail_processor/sample_emails/dropbox.rb +8 -8
  212. data/spec/lib/permissions_spec.rb +15 -28
  213. data/spec/mailers/devise_mailer_spec.rb +35 -0
  214. data/spec/mailers/user_mailer_spec.rb +6 -32
  215. data/spec/models/entities/account_spec.rb +58 -32
  216. data/spec/models/entities/campaign_spec.rb +18 -25
  217. data/spec/models/entities/contact_spec.rb +113 -21
  218. data/spec/models/entities/lead_spec.rb +9 -11
  219. data/spec/models/entities/opportunity_spec.rb +45 -45
  220. data/spec/models/fields/custom_field_date_pair_spec.rb +4 -2
  221. data/spec/models/fields/custom_field_spec.rb +21 -19
  222. data/spec/models/list_spec.rb +2 -2
  223. data/spec/models/observers/entity_observer_spec.rb +7 -7
  224. data/spec/models/polymorphic/address_spec.rb +1 -1
  225. data/spec/models/polymorphic/avatar_spec.rb +5 -5
  226. data/spec/models/polymorphic/comment_spec.rb +5 -5
  227. data/spec/models/polymorphic/task_spec.rb +65 -58
  228. data/spec/models/polymorphic/version_spec.rb +31 -31
  229. data/spec/models/setting_spec.rb +2 -2
  230. data/spec/models/users/preference_spec.rb +6 -6
  231. data/spec/models/users/user_spec.rb +46 -50
  232. data/spec/routing/users_routing_spec.rb +30 -8
  233. data/spec/shared/controllers.rb +3 -9
  234. data/spec/shared/models.rb +22 -22
  235. data/spec/spec_helper.rb +12 -4
  236. data/spec/support/assert_select.rb +1 -0
  237. data/spec/support/devise_helpers.rb +28 -0
  238. data/spec/{features/support/helpers.rb → support/feature_helpers.rb} +11 -11
  239. data/spec/support/macros.rb +7 -4
  240. data/spec/views/accounts/_edit.haml_spec.rb +1 -1
  241. data/spec/views/accounts/create.js.haml_spec.rb +3 -3
  242. data/spec/views/accounts/destroy.js.haml_spec.rb +1 -1
  243. data/spec/views/accounts/edit.js.haml_spec.rb +2 -2
  244. data/spec/views/accounts/index.haml_spec.rb +2 -2
  245. data/spec/views/accounts/index.js.haml_spec.rb +1 -1
  246. data/spec/views/accounts/show.haml_spec.rb +4 -4
  247. data/spec/views/accounts/update.js.haml_spec.rb +1 -1
  248. data/spec/views/admin/field_groups/create.js.haml_spec.rb +1 -1
  249. data/spec/views/admin/field_groups/destroy.js.haml_spec.rb +1 -1
  250. data/spec/views/admin/field_groups/edit.js.haml_spec.rb +1 -1
  251. data/spec/views/admin/field_groups/new.js.haml_spec.rb +1 -1
  252. data/spec/views/admin/field_groups/update.js.haml_spec.rb +1 -1
  253. data/spec/views/admin/users/create.js.haml_spec.rb +2 -2
  254. data/spec/views/admin/users/destroy.js.haml_spec.rb +2 -2
  255. data/spec/views/admin/users/edit.js.haml_spec.rb +2 -2
  256. data/spec/views/admin/users/index.haml_spec.rb +1 -1
  257. data/spec/views/admin/users/index.js.haml_spec.rb +2 -2
  258. data/spec/views/admin/users/reactivate.js.haml_spec.rb +1 -1
  259. data/spec/views/admin/users/suspend.js.haml_spec.rb +1 -1
  260. data/spec/views/admin/users/update.js.haml_spec.rb +1 -1
  261. data/spec/views/application/auto_complete.haml_spec.rb +3 -3
  262. data/spec/views/campaigns/_edit.haml_spec.rb +1 -1
  263. data/spec/views/campaigns/create.js.haml_spec.rb +4 -4
  264. data/spec/views/campaigns/destroy.js.haml_spec.rb +1 -1
  265. data/spec/views/campaigns/edit.js.haml_spec.rb +4 -4
  266. data/spec/views/campaigns/index.haml_spec.rb +1 -1
  267. data/spec/views/campaigns/index.js.haml_spec.rb +2 -2
  268. data/spec/views/campaigns/show.haml_spec.rb +4 -4
  269. data/spec/views/campaigns/update.js.haml_spec.rb +2 -2
  270. data/spec/views/contacts/_edit.haml_spec.rb +7 -7
  271. data/spec/views/contacts/_new.haml_spec.rb +1 -1
  272. data/spec/views/contacts/create.js.haml_spec.rb +5 -5
  273. data/spec/views/contacts/destroy.js.haml_spec.rb +1 -1
  274. data/spec/views/contacts/edit.js.haml_spec.rb +4 -4
  275. data/spec/views/contacts/index.haml_spec.rb +1 -1
  276. data/spec/views/contacts/index.js.html_spec.rb +2 -2
  277. data/spec/views/contacts/new.js.haml_spec.rb +1 -1
  278. data/spec/views/contacts/show.haml_spec.rb +3 -3
  279. data/spec/views/contacts/update.js.haml_spec.rb +5 -5
  280. data/spec/views/home/index.haml_spec.rb +1 -1
  281. data/spec/views/home/index.js.haml_spec.rb +1 -1
  282. data/spec/views/home/options.js.haml_spec.rb +2 -2
  283. data/spec/views/leads/_convert.haml_spec.rb +3 -3
  284. data/spec/views/leads/_edit.haml_spec.rb +2 -2
  285. data/spec/views/leads/_new.haml_spec.rb +2 -2
  286. data/spec/views/leads/_sidebar_show.haml_spec.rb +5 -5
  287. data/spec/views/leads/convert.js.haml_spec.rb +4 -4
  288. data/spec/views/leads/create.js.haml_spec.rb +5 -5
  289. data/spec/views/leads/destroy.js.haml_spec.rb +2 -2
  290. data/spec/views/leads/edit.js.haml_spec.rb +4 -4
  291. data/spec/views/leads/index.haml_spec.rb +1 -1
  292. data/spec/views/leads/index.js.haml_spec.rb +1 -1
  293. data/spec/views/leads/new.js.haml_spec.rb +1 -1
  294. data/spec/views/leads/promote.js.haml_spec.rb +7 -7
  295. data/spec/views/leads/reject.js.haml_spec.rb +2 -2
  296. data/spec/views/leads/show.haml_spec.rb +2 -2
  297. data/spec/views/leads/update.js.haml_spec.rb +4 -4
  298. data/spec/views/opportunities/_edit.haml_spec.rb +7 -7
  299. data/spec/views/opportunities/_new.haml_spec.rb +2 -2
  300. data/spec/views/opportunities/create.js.haml_spec.rb +6 -6
  301. data/spec/views/opportunities/destroy.js.haml_spec.rb +3 -3
  302. data/spec/views/opportunities/edit.js.haml_spec.rb +3 -3
  303. data/spec/views/opportunities/index.haml_spec.rb +1 -1
  304. data/spec/views/opportunities/index.js.haml_spec.rb +1 -1
  305. data/spec/views/opportunities/new.js.haml_spec.rb +1 -1
  306. data/spec/views/opportunities/show.haml_spec.rb +3 -3
  307. data/spec/views/opportunities/update.js.haml_spec.rb +5 -5
  308. data/spec/views/tasks/_edit.haml_spec.rb +1 -1
  309. data/spec/views/tasks/complete.js.haml_spec.rb +4 -4
  310. data/spec/views/tasks/create.js.haml_spec.rb +6 -6
  311. data/spec/views/tasks/destroy.js.haml_spec.rb +2 -2
  312. data/spec/views/tasks/index.haml_spec.rb +4 -4
  313. data/spec/views/tasks/new.js.haml_spec.rb +1 -1
  314. data/spec/views/tasks/uncomplete.js.haml_spec.rb +2 -2
  315. data/spec/views/tasks/update.js.haml_spec.rb +18 -18
  316. data/spec/views/users/upload_avatar.js.haml_spec.rb +2 -2
  317. metadata +49 -71
  318. data/app/controllers/authentications_controller.rb +0 -53
  319. data/app/models/users/authentication.rb +0 -56
  320. data/app/views/authentications/new.html.haml +0 -19
  321. data/app/views/passwords/edit.html.haml +0 -15
  322. data/app/views/passwords/new.html.haml +0 -10
  323. data/app/views/user_mailer/password_reset_instructions.html.haml +0 -6
  324. data/app/views/users/new.html.haml +0 -19
  325. data/spec/controllers/authentications_controller_spec.rb +0 -150
  326. data/spec/controllers/passwords_controller_spec.rb +0 -32
  327. data/spec/models/users/authentication_spec.rb +0 -19
  328. data/spec/support/auth_macros.rb +0 -49
  329. data/spec/views/authentications/new.haml_spec.rb +0 -31
data/spec/views/authentications/new.haml_spec.rb DELETED
@@ -1,31 +0,0 @@
1
- # frozen_string_literal: true
2
-
3
- # Copyright (c) 2008-2013 Michael Dvorkin and contributors.
4
- #
5
- # Fat Free CRM is freely distributable under the terms of MIT license.
6
- # See MIT-LICENSE file or http://www.opensource.org/licenses/mit-license.php
7
- #------------------------------------------------------------------------------
8
- require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper')
9
-
10
- describe "/authentications/new" do
11
- include AuthenticationsHelper
12
-
13
- before do
14
- activate_authlogic
15
- assign(:authentication, @authentication = Authentication.new)
16
- end
17
-
18
- it "renders the login form without signup link" do
19
- expect(view).to receive(:can_signup?).and_return(false)
20
- render
21
- expect(rendered).to have_tag("form[action='#{authentication_path}'][class=new_authentication]")
22
- expect(rendered).not_to have_tag("a[href='#{signup_path}']")
23
- end
24
-
25
- it "renders the login form with signup link" do
26
- expect(view).to receive(:can_signup?).and_return(true)
27
- render
28
- expect(rendered).to have_tag("form[action='#{authentication_path}'][class=new_authentication]")
29
- expect(rendered).to have_tag("a[href='#{signup_path}']")
30
- end
31
- end