fat_free_crm 0.17.3 → 0.19.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2ca66c981de552c61f57b222cafd88bc9d34e1c2ec4a184a0bc8ffd009d4da37
-  data.tar.gz: d484f322f7594b1c821d13424d8cd9a8bce8a4912d37b7e4151ff7bdfc8d6640
+  metadata.gz: 8fa077bec8c4e6334e58d1b936d716dd2d81692fe79efc9028b7cafec8ead036
+  data.tar.gz: 3052cb09940c88d9a7ab44f70cb56c9a582e08589ea2052feaf5d6fab0a5f949
 SHA512:
-  metadata.gz: a3944df108b8ee40424ef0747b0cead3b03a6e08129b164232b8cb7be258a632469126d0d3fc2f1bfeb35066c6089b5712afc5dea8dbf9950ebe493e4dcfcd87
-  data.tar.gz: 3f4544819b61cefb933787a84c2a4ff693810378c1a66c5669aecea9683881000216002d7ad80d692de80b3cc4767e643eed8f93a3e1f421c2f993712ddf9dc8
+  metadata.gz: 8e0ff6fbe7b7e01aa769b85d597aeda05a4dc7b687fb3ce0c80af75e00a519df70d6f60005858b9e2d626b5c62d3130e46d7494db49190a53c2426ea91a6ee67
+  data.tar.gz: dca8bbad437f05b2053ce140beacab67d8d873936bd3510d5ce51434517cb4f8851cbef683bcf1d48e4df7563aa39456d28d468d05d32ce21223b0e8c63914a9

data/.rubocop.yml

@@ -1,7 +1,7 @@
 inherit_from: .rubocop_todo.yml
 
 AllCops:
-  TargetRubyVersion: 2.3
+  TargetRubyVersion: 2.4
 
 Bundler/OrderedGems:
   Enabled: false

data/.rubocop_todo.yml

@@ -1,16 +1,33 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2018-01-21 02:52:41 +1030 using RuboCop version 0.52.1.
+# on 2019-11-08 13:13:48 +1030 using RuboCop version 0.76.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 1
-# Cop supports --auto-correct.
-Layout/EmptyLinesAroundArguments:
+# Offense count: 2
+# Configuration parameters: Include.
+# Include: **/*.gemfile, **/Gemfile, **/gems.rb
+Bundler/DuplicatedGem:
   Exclude:
-    - 'lib/fat_free_crm/permissions.rb'
+    - 'Gemfile'
+
+# Offense count: 88
+# Cop supports --auto-correct.
+# Configuration parameters: AllowMultipleStyles, EnforcedHashRocketStyle, EnforcedColonStyle, EnforcedLastArgumentHashStyle.
+# SupportedHashRocketStyles: key, separator, table
+# SupportedColonStyles: key, separator, table
+# SupportedLastArgumentHashStyles: always_inspect, always_ignore, ignore_implicit, ignore_explicit
+Layout/AlignHash:
+  Enabled: false
+
+# Offense count: 22
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyleAlignWith, AutoCorrect, Severity.
+# SupportedStylesAlignWith: keyword, variable, start_of_line
+Layout/EndAlignment:
+  Enabled: false
 
 # Offense count: 7
 # Cop supports --auto-correct.
@@ -21,7 +38,7 @@ Layout/SpaceInsideArrayLiteralBrackets:
   Exclude:
     - 'db/seeds/fields.rb'
 
-# Offense count: 20
+# Offense count: 21
 # Configuration parameters: AllowSafeAssignment.
 Lint/AssignmentInCondition:
   Enabled: false
@@ -36,14 +53,8 @@ Lint/DuplicateMethods:
   Exclude:
     - 'lib/gravatar_image_tag.rb'
 
-# Offense count: 22
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyleAlignWith, AutoCorrect.
-# SupportedStylesAlignWith: keyword, variable, start_of_line
-Lint/EndAlignment:
-  Enabled: false
-
 # Offense count: 2
+# Configuration parameters: AllowComments.
 Lint/HandleExceptions:
   Exclude:
     - 'config/environments/test.rb'
@@ -55,12 +66,6 @@ Lint/ImplicitStringConcatenation:
     - 'db/migrate/20121221033947_fix_country_mapping.rb'
     - 'lib/tasks/ffcrm/update_data.rake'
 
-# Offense count: 4
-Lint/IneffectiveAccessModifier:
-  Exclude:
-    - 'db/migrate/20100928030620_remove_uuid.rb'
-    - 'lib/gravatar_image_tag.rb'
-
 # Offense count: 5
 Lint/RescueException:
   Exclude:
@@ -78,22 +83,12 @@ Lint/UriEscapeUnescape:
   Exclude:
     - 'lib/gravatar_image_tag.rb'
 
-# Offense count: 4
-# Configuration parameters: ContextCreatingMethods, MethodCreatingMethods.
-Lint/UselessAccessModifier:
-  Exclude:
-    - 'app/models/fields/field.rb'
-    - 'app/models/users/user.rb'
-    - 'db/migrate/20100928030620_remove_uuid.rb'
-    - 'lib/gravatar_image_tag.rb'
-
-# Offense count: 3
+# Offense count: 2
 Lint/UselessAssignment:
   Exclude:
-    - 'app/helpers/application_helper.rb'
     - 'app/views/home/index.atom.builder'
 
-# Offense count: 132
+# Offense count: 133
 Metrics/AbcSize:
   Max: 57
 
@@ -105,23 +100,23 @@ Metrics/BlockNesting:
 # Offense count: 14
 # Configuration parameters: CountComments.
 Metrics/ClassLength:
-  Max: 199
+  Max: 184
 
-# Offense count: 29
+# Offense count: 30
 Metrics/CyclomaticComplexity:
   Max: 14
 
 # Offense count: 100
-# Configuration parameters: CountComments.
+# Configuration parameters: CountComments, ExcludedMethods.
 Metrics/MethodLength:
-  Max: 38
+  Max: 36
 
 # Offense count: 2
 # Configuration parameters: CountComments.
 Metrics/ModuleLength:
-  Max: 382
+  Max: 373
 
-# Offense count: 27
+# Offense count: 26
 Metrics/PerceivedComplexity:
   Max: 15
 
@@ -141,13 +136,6 @@ Naming/AccessorMethodName:
     - 'spec/controllers/entities/opportunities_controller_spec.rb'
     - 'spec/support/macros.rb'
 
-# Offense count: 1
-# Configuration parameters: Blacklist.
-# Blacklist: END, (?-mix:EO[A-Z]{1})
-Naming/HeredocDelimiterNaming:
-  Exclude:
-    - 'app/controllers/passwords_controller.rb'
-
 # Offense count: 4
 # Configuration parameters: NamePrefix, NamePrefixBlacklist, NameWhitelist, MethodDefinitionMacros.
 # NamePrefix: is_, has_, have_
@@ -162,32 +150,28 @@ Naming/PredicateName:
     - 'lib/fat_free_crm/fields.rb'
     - 'lib/fat_free_crm/mail_processor/base.rb'
 
-# Offense count: 12
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: snake_case, normalcase, non_integer
-Naming/VariableNumber:
-  Exclude:
-    - 'spec/controllers/home_controller_spec.rb'
-
 # Offense count: 2
 # Cop supports --auto-correct.
-# Configuration parameters: AutoCorrect.
-Performance/HashEachMethods:
+# Configuration parameters: PreferredName.
+Naming/RescuedExceptionsVariableName:
   Exclude:
-    - 'app/controllers/entities/opportunities_controller.rb'
-    - 'lib/fat_free_crm/errors.rb'
+    - 'spec/support/assert_select.rb'
 
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: AutoCorrect.
-Performance/StartWith:
+# Offense count: 3
+# Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames.
+# AllowedNames: io, id, to, by, on, in, at, ip, db, os
+Naming/UncommunicativeMethodParamName:
   Exclude:
-    - 'app/helpers/versions_helper.rb'
+    - 'app/models/fields/field.rb'
+    - 'app/models/polymorphic/comment.rb'
+    - 'lib/missing_translation_detector.rb'
 
-# Offense count: 1
-Security/Eval:
+# Offense count: 12
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: snake_case, normalcase, non_integer
+Naming/VariableNumber:
   Exclude:
-    - 'lib/development_tasks/gem.rake'
+    - 'spec/controllers/home_controller_spec.rb'
 
 # Offense count: 1
 Security/MarshalLoad:
@@ -221,23 +205,31 @@ Style/ClassVars:
     - 'lib/fat_free_crm/tabs.rb'
     - 'lib/fat_free_crm/view_factory.rb'
 
-# Offense count: 2
+# Offense count: 1
 Style/CommentedKeyword:
   Exclude:
-    - 'app/models/users/authentication.rb'
     - 'db/migrate/20100928030617_drop_openid_tables.rb'
 
-# Offense count: 3
+# Offense count: 2
 Style/DoubleNegation:
   Exclude:
     - 'app/helpers/application_helper.rb'
     - 'app/models/polymorphic/task.rb'
-    - 'lib/gravatar_image_tag.rb'
 
 # Offense count: 1
-Style/EvalWithLocation:
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: annotated, template, unannotated
+Style/FormatStringToken:
+  Exclude:
+    - 'spec/factories/shared_factories.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: always, never
+Style/FrozenStringLiteralComment:
   Exclude:
-    - 'lib/fat_free_crm/permissions.rb'
+    - 'db/schema.rb'
 
 # Offense count: 3
 # Configuration parameters: AllowedVariables.
@@ -246,44 +238,22 @@ Style/GlobalVars:
     - 'db/migrate/20100928030598_create_sessions.rb'
     - 'db/migrate/20120510025219_add_not_null_constraints_for_timestamp_columns.rb'
 
-# Offense count: 45
+# Offense count: 28
 # Configuration parameters: MinBodyLength.
 Style/GuardClause:
   Enabled: false
 
 # Offense count: 2
-Style/IdenticalConditionalBranches:
-  Exclude:
-    - 'app/helpers/application_helper.rb'
-
-# Offense count: 49
-# Cop supports --auto-correct.
-Style/IfUnlessModifier:
-  Enabled: false
-
-# Offense count: 16
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: line_count_dependent, lambda, literal
-Style/Lambda:
-  Exclude:
-    - 'app/models/entities/account.rb'
-    - 'app/models/entities/campaign.rb'
-    - 'app/models/entities/contact.rb'
-    - 'app/models/entities/lead.rb'
-    - 'app/models/entities/opportunity.rb'
-    - 'app/models/polymorphic/task.rb'
-    - 'app/models/users/user.rb'
-
-# Offense count: 2
-Style/MethodMissing:
+Style/MissingRespondToMissing:
   Exclude:
     - 'app/models/setting.rb'
     - 'lib/fat_free_crm/fields.rb'
 
-# Offense count: 1
+# Offense count: 3
 Style/MixinUsage:
   Exclude:
+    - 'bin/setup'
+    - 'bin/update'
     - 'spec/helpers/fields_helper_spec.rb'
 
 # Offense count: 2
@@ -292,66 +262,19 @@ Style/MultilineBlockChain:
     - 'lib/fat_free_crm/core_ext/string.rb'
     - 'lib/tasks/ffcrm/demo.rake'
 
-# Offense count: 2
-Style/MultilineTernaryOperator:
+# Offense count: 1
+Style/MultipleComparison:
   Exclude:
-    - 'app/models/users/authentication.rb'
+    - 'app/models/polymorphic/task.rb'
 
-# Offense count: 11
+# Offense count: 5
 # Cop supports --auto-correct.
-# Configuration parameters: AutoCorrect, EnforcedStyle.
+# Configuration parameters: AutoCorrect, EnforcedStyle, IgnoredMethods.
 # SupportedStyles: predicate, comparison
 Style/NumericPredicate:
   Exclude:
     - 'spec/**/*'
-    - 'app/helpers/admin/users_helper.rb'
-    - 'app/helpers/application_helper.rb'
-    - 'app/helpers/campaigns_helper.rb'
-    - 'app/helpers/tasks_helper.rb'
     - 'app/models/fields/custom_field.rb'
     - 'app/models/polymorphic/task.rb'
     - 'app/models/users/user.rb'
     - 'lib/tasks/ffcrm/demo.rake'
-
-# Offense count: 16
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, AllowInnerSlashes.
-# SupportedStyles: slashes, percent_r, mixed
-Style/RegexpLiteral:
-  Exclude:
-    - 'app/controllers/entities/contacts_controller.rb'
-    - 'app/controllers/entities/opportunities_controller.rb'
-    - 'app/helpers/application_helper.rb'
-    - 'app/models/list.rb'
-    - 'lib/development_tasks/license.rake'
-    - 'lib/fat_free_crm/core_ext/string.rb'
-    - 'spec/helpers/users_helper_spec.rb'
-    - 'spec/lib/mail_processor/dropbox_spec.rb'
-    - 'spec/views/contacts/update.js.haml_spec.rb'
-    - 'spec/views/opportunities/update.js.haml_spec.rb'
-
-# Offense count: 8
-# Cop supports --auto-correct.
-# Configuration parameters: AllowAsExpressionSeparator.
-Style/Semicolon:
-  Exclude:
-    - 'app/controllers/entities/leads_controller.rb'
-    - 'lib/fat_free_crm/permissions.rb'
-    - 'lib/tasks/ffcrm/setup.rake'
-    - 'spec/models/fields/custom_field_date_pair_spec.rb'
-    - 'spec/models/fields/custom_field_spec.rb'
-    - 'spec/support/macros.rb'
-
-# Offense count: 2
-# Cop supports --auto-correct.
-# Configuration parameters: ExactNameMatch, AllowPredicates, AllowDSLWriters, IgnoreClassMethods, Whitelist.
-# Whitelist: to_ary, to_a, to_c, to_enum, to_h, to_hash, to_i, to_int, to_io, to_open, to_path, to_proc, to_r, to_regexp, to_str, to_s, to_sym
-Style/TrivialAccessors:
-  Exclude:
-    - 'spec/support/auth_macros.rb'
-
-# Offense count: 1922
-# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
-# URISchemes: http, https
-Metrics/LineLength:
-  Max: 390

data/.travis.yml

@@ -1,8 +1,11 @@
 sudo: false
 language: ruby
 rvm:
-  - 2.3.6
-  - 2.4.2
+  - 2.5.7
+  - 2.6.5
+  - 2.7.1
+
+dist: bionic
 
 env:
   global:
@@ -11,21 +14,34 @@ env:
     - DB=postgres TEST_SUITE=rubocop
     - DB=postgres TEST_SUITE="rake spec:features"
     - DB=postgres TEST_SUITE="rake spec:models"
-    - DB=postgres TEST_SUITE="rake spec:mailers"
-    - DB=postgres TEST_SUITE="rake spec:controllers"
-    - DB=postgres TEST_SUITE="rake spec:helpers"
-    - DB=postgres TEST_SUITE="rake spec:lib"
-    - DB=postgres TEST_SUITE="rake spec:routing"
-    - DB=postgres TEST_SUITE="rake spec:views"
+    - DB=postgres TEST_SUITE="rake spec:controllers spec:lib spec:routing spec:mailers"
+    - DB=postgres TEST_SUITE="rake spec:views spec:helpers"
     - DB=mysql TEST_SUITE="rake spec:models"
     - DB=sqlite TEST_SUITE="rake spec:models"
 
 matrix:
   fast_finish: true
+  exclude:
+    - rvm: 2.5.7
+      env: DB=postgres TEST_SUITE=rubocop
+    - rvm: 2.6.5
+      env: DB=postgres TEST_SUITE=rubocop
   allow_failures:
-    - rvm: 2.3.6
+    - rvm: 2.5.7
+      env: DB=postgres TEST_SUITE="rake spec:features"
+    - rvm: 2.6.5
+      env: DB=postgres TEST_SUITE="rake spec:features"
+    - rvm: 2.7.1
+      env: DB=postgres TEST_SUITE="rake spec:features"
+    - rvm: 2.5.7
+      env: DB=mysql TEST_SUITE="rake spec:models"
+    - rvm: 2.5.7
+      env: DB=sqlite TEST_SUITE="rake spec:models"
+    - rvm: 2.6.5
       env: DB=sqlite TEST_SUITE="rake spec:models"
-    - rvm: 2.4.2
+    - rvm: 2.7.1
+      env: DB=mysql TEST_SUITE="rake spec:models"
+    - rvm: 2.7.1
       env: DB=sqlite TEST_SUITE="rake spec:models"
 
 addons:
@@ -35,11 +51,10 @@ bundler_args: --path=vendor/bundle --without heroku
 
 cache: bundler
 
-before_install:
-  - "export DISPLAY=:99.0"
-  - "sh -e /etc/init.d/xvfb start"
-
 before_script:
+  # gem update --system is a workaround for travis-ci/travis-ci#8978
+  - "gem update --system"
+  - 'gem install bundler -v 1.17.3'
   - sh -c "cp config/database.$DB.yml config/database.yml"
   - sh -c "if [ \"$DB\" = 'postgres' ]; then psql -c 'create database fat_free_crm_test;' -U postgres; fi"
   - sh -c "if [ \"$DB\" = 'mysql' ]; then mysql -e 'create database fat_free_crm_test;'; fi"
@@ -56,3 +71,9 @@ notifications:
     on_success: change  # options: [always|never|change] default: always
     on_failure: always  # options: [always|never|change] default: always
     on_start: false     # default: false
+
+dist: xenial
+services:
+  - xvfb
+  - postgresql
+  - mysql