fat_free_crm 0.17.2 → 0.19.0

data/spec/views/leads/index.haml_spec.rb

@@ -19,7 +19,7 @@ describe "/leads/index" do
   end
 
   it "should render list of accounts if list of leads is not empty" do
-    assign(:leads, [FactoryGirl.build_stubbed(:lead)].paginate(page: 1, per_page: 20))
+    assign(:leads, [build_stubbed(:lead)].paginate(page: 1, per_page: 20))
 
     render
     expect(view).to render_template(partial: "_lead")

data/spec/views/leads/index.js.haml_spec.rb

@@ -15,7 +15,7 @@ describe "/leads/index" do
   end
 
   it "should render [lead] template with @leads collection if there are leads" do
-    assign(:leads, [FactoryGirl.build_stubbed(:lead, id: 42)].paginate(page: 1, per_page: 20))
+    assign(:leads, [build_stubbed(:lead, id: 42)].paginate(page: 1, per_page: 20))
 
     render template: 'leads/index', formats: [:js]
 

data/spec/views/leads/new.js.haml_spec.rb

@@ -12,7 +12,7 @@ describe "/leads/new" do
 
   before do
     login
-    @campaign = FactoryGirl.build_stubbed(:campaign)
+    @campaign = build_stubbed(:campaign)
     assign(:lead, Lead.new(user: current_user))
     assign(:users, [current_user])
     assign(:campaign, @campaign)

data/spec/views/leads/promote.js.haml_spec.rb

@@ -11,16 +11,16 @@ describe "/leads/promote" do
   before do
     login
     assign(:users, [current_user])
-    assign(:account, @account = FactoryGirl.build_stubbed(:account))
+    assign(:account, @account = build_stubbed(:account))
     assign(:accounts, [@account])
-    assign(:contact, FactoryGirl.build_stubbed(:contact))
-    assign(:opportunity, FactoryGirl.build_stubbed(:opportunity))
+    assign(:contact, build_stubbed(:contact))
+    assign(:opportunity, build_stubbed(:opportunity))
     assign(:lead_status_total, Hash.new(1))
   end
 
   describe "no errors :" do
     before do
-      assign(:lead, @lead = FactoryGirl.build_stubbed(:lead, status: "converted", user: current_user, assignee: current_user))
+      assign(:lead, @lead = build_stubbed(:lead, status: "converted", user: current_user, assignee: current_user))
     end
 
     describe "from lead landing page -" do
@@ -66,9 +66,9 @@ describe "/leads/promote" do
     describe "from related campaign page -" do
       before do
         controller.request.env["HTTP_REFERER"] = "http://localhost/campaigns/123"
-        assign(:campaign, FactoryGirl.build_stubbed(:campaign))
+        assign(:campaign, build_stubbed(:campaign))
         assign(:stage, Setting.unroll(:opportunity_stage))
-        assign(:opportunity, @opportunity = FactoryGirl.build_stubbed(:opportunity))
+        assign(:opportunity, @opportunity = build_stubbed(:opportunity))
       end
 
       it "should replace [Convert Lead] with lead partial and highlight it" do
@@ -95,7 +95,7 @@ describe "/leads/promote" do
 
   describe "validation errors:" do
     before do
-      assign(:lead, @lead = FactoryGirl.build_stubbed(:lead, status: "new", user: current_user, assignee: current_user))
+      assign(:lead, @lead = build_stubbed(:lead, status: "new", user: current_user, assignee: current_user))
     end
 
     describe "from lead landing page -" do

data/spec/views/leads/reject.js.haml_spec.rb

@@ -10,7 +10,7 @@ require 'spec_helper'
 describe "/leads/reject" do
   before do
     login
-    assign(:lead, @lead = FactoryGirl.build_stubbed(:lead, status: "new"))
+    assign(:lead, @lead = build_stubbed(:lead, status: "new"))
     assign(:lead_status_total, Hash.new(1))
   end
 
@@ -37,7 +37,7 @@ describe "/leads/reject" do
   end
 
   it "should update campaign sidebar if called from campaign landing page" do
-    assign(:campaign, campaign = FactoryGirl.build_stubbed(:campaign))
+    assign(:campaign, campaign = build_stubbed(:campaign))
     controller.request.env["HTTP_REFERER"] = "http://localhost/campaigns/#{campaign.id}"
     render
 

data/spec/views/leads/show.haml_spec.rb

@@ -12,10 +12,10 @@ describe "/leads/show" do
 
   before do
     login
-    assign(:lead, @lead = FactoryGirl.build_stubbed(:lead, id: 42))
+    assign(:lead, @lead = build_stubbed(:lead, id: 42))
     assign(:users, [current_user])
     assign(:comment, Comment.new)
-    assign(:timeline, [FactoryGirl.build_stubbed(:comment, commentable: @lead)])
+    assign(:timeline, [build_stubbed(:comment, commentable: @lead)])
 
     # controller#controller_name and controller#action_name are not set in view specs
     allow(view).to receive(:template_for_current_view).and_return(nil)

data/spec/views/leads/update.js.haml_spec.rb

@@ -10,9 +10,9 @@ require 'spec_helper'
 describe "/leads/update" do
   before do
     login
-    assign(:lead, @lead = FactoryGirl.build_stubbed(:lead, user: current_user, assignee: FactoryGirl.build_stubbed(:user)))
+    assign(:lead, @lead = build_stubbed(:lead, user: current_user, assignee: build_stubbed(:user)))
     assign(:users, [current_user])
-    assign(:campaigns, [FactoryGirl.build_stubbed(:campaign)])
+    assign(:campaigns, [build_stubbed(:campaign)])
     assign(:lead_status_total, Hash.new(1))
   end
 
@@ -58,7 +58,7 @@ describe "/leads/update" do
 
     describe "on related asset page -" do
       before do
-        assign(:campaign, FactoryGirl.build_stubbed(:campaign))
+        assign(:campaign, build_stubbed(:campaign))
         controller.request.env["HTTP_REFERER"] = "http://localhost/campaigns/123"
       end
 
@@ -69,7 +69,7 @@ describe "/leads/update" do
       end
 
       it "should update campaign sidebar" do
-        assign(:campaign, FactoryGirl.build_stubbed(:campaign))
+        assign(:campaign, build_stubbed(:campaign))
         render
 
         expect(rendered).to include("sidebar")

data/spec/views/opportunities/_edit.haml_spec.rb

@@ -12,14 +12,14 @@ describe "/opportunities/_edit" do
 
   before do
     login
-    assign(:account, @account = FactoryGirl.build_stubbed(:account))
+    assign(:account, @account = build_stubbed(:account))
     assign(:accounts, [@account])
     assign(:stage, Setting.unroll(:opportunity_stage))
   end
 
   it "should render [edit opportunity] form" do
     assign(:users, [current_user])
-    assign(:opportunity, @opportunity = FactoryGirl.build_stubbed(:opportunity, campaign: @campaign = FactoryGirl.build_stubbed(:campaign)))
+    assign(:opportunity, @opportunity = build_stubbed(:opportunity, campaign: @campaign = build_stubbed(:campaign)))
     render
 
     expect(rendered).to have_tag("form[class=edit_opportunity]") do
@@ -30,7 +30,7 @@ describe "/opportunities/_edit" do
 
   it "should pick default assignee (Myself)" do
     assign(:users, [current_user])
-    assign(:opportunity, FactoryGirl.build_stubbed(:opportunity, assignee: nil))
+    assign(:opportunity, build_stubbed(:opportunity, assignee: nil))
     render
 
     expect(rendered).to have_tag("select[id=opportunity_assigned_to]") do |options|
@@ -39,9 +39,9 @@ describe "/opportunities/_edit" do
   end
 
   it "should show correct assignee" do
-    @user = FactoryGirl.create(:user)
+    @user = create(:user)
     assign(:users, [current_user, @user])
-    assign(:opportunity, FactoryGirl.create(:opportunity, assignee: @user))
+    assign(:opportunity, create(:opportunity, assignee: @user))
     render
 
     expect(rendered).to have_tag("select[id=opportunity_assigned_to]") do |_options|
@@ -52,7 +52,7 @@ describe "/opportunities/_edit" do
 
   it "should render background info field if settings require so" do
     assign(:users, [current_user])
-    assign(:opportunity, FactoryGirl.build_stubbed(:opportunity))
+    assign(:opportunity, build_stubbed(:opportunity))
     Setting.background_info = [:opportunity]
 
     render
@@ -61,7 +61,7 @@ describe "/opportunities/_edit" do
 
   it "should not render background info field if settings do not require so" do
     assign(:users, [current_user])
-    assign(:opportunity, FactoryGirl.build_stubbed(:opportunity))
+    assign(:opportunity, build_stubbed(:opportunity))
     Setting.background_info = []
 
     render

data/spec/views/opportunities/_new.haml_spec.rb

@@ -12,8 +12,8 @@ describe "/opportunities/_new" do
 
   before do
     login
-    assign(:opportunity, FactoryGirl.build(:opportunity))
-    @account = FactoryGirl.build_stubbed(:account)
+    assign(:opportunity, build(:opportunity))
+    @account = build_stubbed(:account)
     assign(:account, @account)
     assign(:accounts, [@account])
     assign(:users, [current_user])

data/spec/views/opportunities/create.js.haml_spec.rb

@@ -15,7 +15,7 @@ describe "/opportunities/create" do
 
   describe "create success" do
     before do
-      assign(:opportunity, @opportunity = FactoryGirl.build_stubbed(:opportunity))
+      assign(:opportunity, @opportunity = build_stubbed(:opportunity))
       assign(:opportunities, [@opportunities].paginate)
       assign(:opportunity_stage_total, Hash.new(1))
     end
@@ -44,7 +44,7 @@ describe "/opportunities/create" do
     end
 
     it "should update related account sidebar when called from related account" do
-      assign(:account, account = FactoryGirl.create(:account))
+      assign(:account, account = create(:account))
       controller.request.env["HTTP_REFERER"] = "http://localhost/accounts/#{account.id}"
       render
 
@@ -53,7 +53,7 @@ describe "/opportunities/create" do
     end
 
     it "should update related campaign sidebar when called from related campaign" do
-      assign(:campaign, campaign = FactoryGirl.create(:campaign))
+      assign(:campaign, campaign = create(:campaign))
       controller.request.env["HTTP_REFERER"] = "http://localhost/campaigns/#{campaign.id}"
       render
 
@@ -72,9 +72,9 @@ describe "/opportunities/create" do
 
   describe "create failure" do
     it "should re-render [create] template in :create_opportunity div" do
-      assign(:opportunity, FactoryGirl.build(:opportunity, name: nil)) # make it invalid
-      @account = FactoryGirl.build_stubbed(:account)
-      assign(:users, [FactoryGirl.build_stubbed(:user)])
+      assign(:opportunity, build(:opportunity, name: nil)) # make it invalid
+      @account = build_stubbed(:account)
+      assign(:users, [build_stubbed(:user)])
       assign(:account, @account)
       assign(:accounts, [@account])
 

data/spec/views/opportunities/destroy.js.haml_spec.rb

@@ -10,7 +10,7 @@ require 'spec_helper'
 describe "/opportunities/destroy" do
   before do
     login
-    assign(:opportunity, @opportunity = FactoryGirl.build_stubbed(:opportunity))
+    assign(:opportunity, @opportunity = build_stubbed(:opportunity))
     assign(:stage, Setting.unroll(:opportunity_stage))
     assign(:opportunity_stage_total, Hash.new(1))
   end
@@ -39,7 +39,7 @@ describe "/opportunities/destroy" do
   end
 
   it "should update related account sidebar when called from related account" do
-    assign(:account, account = FactoryGirl.build_stubbed(:account))
+    assign(:account, account = build_stubbed(:account))
     controller.request.env["HTTP_REFERER"] = "http://localhost/accounts/#{account.id}"
     render
 
@@ -49,7 +49,7 @@ describe "/opportunities/destroy" do
   end
 
   it "should update related campaign sidebar when called from related campaign" do
-    assign(:campaign, campaign = FactoryGirl.build_stubbed(:campaign))
+    assign(:campaign, campaign = build_stubbed(:campaign))
     controller.request.env["HTTP_REFERER"] = "http://localhost/campaigns/#{campaign.id}"
     render
 

data/spec/views/opportunities/edit.js.haml_spec.rb

@@ -13,9 +13,9 @@ describe "/opportunities/edit" do
   before do
     login
 
-    assign(:opportunity, @opportunity = FactoryGirl.build_stubbed(:opportunity, user: current_user))
+    assign(:opportunity, @opportunity = build_stubbed(:opportunity, user: current_user))
     assign(:users, [current_user])
-    assign(:account, @account = FactoryGirl.build_stubbed(:account))
+    assign(:account, @account = build_stubbed(:account))
     assign(:accounts, [@account])
     assign(:stage, Setting.unroll(:opportunity_stage))
   end
@@ -37,7 +37,7 @@ describe "/opportunities/edit" do
 
   it "edit: should hide previously open [Edit Opportunity] for and replace it with opportunity partial" do
     params[:cancel] = nil
-    assign(:previous, previous = FactoryGirl.build_stubbed(:opportunity, user: current_user))
+    assign(:previous, previous = build_stubbed(:opportunity, user: current_user))
 
     render
     expect(rendered).to include("$('#opportunity_#{previous.id}').replaceWith")

data/spec/views/opportunities/index.haml_spec.rb

@@ -20,7 +20,7 @@ describe "/opportunities/index" do
   end
 
   it "should render list of accounts if list of opportunities is not empty" do
-    assign(:opportunities, [FactoryGirl.build_stubbed(:opportunity)].paginate)
+    assign(:opportunities, [build_stubbed(:opportunity)].paginate)
 
     render
     expect(view).to render_template(partial: "_opportunity")

data/spec/views/opportunities/index.js.haml_spec.rb

@@ -16,7 +16,7 @@ describe "/opportunities/index" do
   end
 
   it "should render [opportunity] template with @opportunities collection if there are opportunities" do
-    assign(:opportunities, [FactoryGirl.build_stubbed(:opportunity, id: 42)].paginate)
+    assign(:opportunities, [build_stubbed(:opportunity, id: 42)].paginate)
 
     render template: 'opportunities/index', formats: [:js]
 

data/spec/views/opportunities/new.js.haml_spec.rb

@@ -12,7 +12,7 @@ describe "/opportunities/new" do
 
   before do
     login
-    @account = FactoryGirl.build_stubbed(:account)
+    @account = build_stubbed(:account)
     assign(:opportunity, Opportunity.new(user: current_user))
     assign(:users, [current_user])
     assign(:account, @account)

data/spec/views/opportunities/show.haml_spec.rb

@@ -12,12 +12,12 @@ describe "/opportunities/show" do
 
   before do
     login
-    @opportunity = FactoryGirl.create(:opportunity, id: 42,
-                                                    contacts: [FactoryGirl.create(:contact)])
+    @opportunity = create(:opportunity, id: 42,
+                                        contacts: [create(:contact)])
     assign(:opportunity, @opportunity)
     assign(:users, [current_user])
     assign(:comment, Comment.new)
-    assign(:timeline, [FactoryGirl.create(:comment, commentable: @opportunity)])
+    assign(:timeline, [create(:comment, commentable: @opportunity)])
 
     # controller#controller_name and controller#action_name are not set in view specs
     allow(view).to receive(:template_for_current_view).and_return(nil)

data/spec/views/opportunities/update.js.haml_spec.rb

@@ -11,9 +11,9 @@ describe "/opportunities/update" do
   before do
     login
 
-    assign(:opportunity, @opportunity = FactoryGirl.build_stubbed(:opportunity, user: current_user, assignee: FactoryGirl.build_stubbed(:user)))
+    assign(:opportunity, @opportunity = build_stubbed(:opportunity, user: current_user, assignee: build_stubbed(:user)))
     assign(:users, [current_user])
-    assign(:account, @account = FactoryGirl.build_stubbed(:account))
+    assign(:account, @account = build_stubbed(:account))
     assign(:accounts, [@account])
     assign(:stage, Setting.unroll(:opportunity_stage))
     assign(:opportunity_stage_total, Hash.new(1))
@@ -62,7 +62,7 @@ describe "/opportunities/update" do
 
     describe "on related asset page -" do
       it "should update account sidebar" do
-        assign(:account, account = FactoryGirl.build_stubbed(:account))
+        assign(:account, account = build_stubbed(:account))
         controller.request.env["HTTP_REFERER"] = "http://localhost/accounts/#{account.id}"
         render
 
@@ -72,7 +72,7 @@ describe "/opportunities/update" do
       end
 
       it "should update campaign sidebar" do
-        assign(:campaign, campaign = FactoryGirl.build_stubbed(:campaign))
+        assign(:campaign, campaign = build_stubbed(:campaign))
         controller.request.env["HTTP_REFERER"] = "http://localhost/campaigns/#{campaign.id}"
         render
 
@@ -137,7 +137,7 @@ describe "/opportunities/update" do
 
       it "should show disabled accounts dropdown when called from accounts landing page" do
         render
-        expect(rendered).to include("crm.create_or_select_account(#{@referer =~ /\/accounts\//})")
+        expect(rendered).to include("crm.create_or_select_account(#{@referer =~ %r{/accounts/}})")
       end
 
       it "should redraw the [edit_opportunity] form and shake it" do

data/spec/views/tasks/_edit.haml_spec.rb

@@ -12,7 +12,7 @@ describe "/tasks/_edit" do
 
   before do
     login
-    assign(:task, FactoryGirl.build_stubbed(:task, asset: FactoryGirl.build_stubbed(:account), bucket: "due_asap"))
+    assign(:task, build_stubbed(:task, asset: build_stubbed(:account), bucket: "due_asap"))
     assign(:users, [current_user])
     assign(:bucket, %w[due_asap due_today])
     assign(:category, %w[meeting money])

data/spec/views/tasks/complete.js.haml_spec.rb

@@ -17,7 +17,7 @@ describe "/tasks/complete" do
 
   describe "complete from Tasks tab (pending view)" do
     before do
-      @task = FactoryGirl.build_stubbed(:task)
+      @task = build_stubbed(:task)
       assign(:task, @task)
       assign(:view, "pending")
       assign(:empty_bucket, :due_asap)
@@ -33,7 +33,7 @@ describe "/tasks/complete" do
     end
 
     it "should update tasks sidebar" do
-      assign(:task, FactoryGirl.build_stubbed(:task))
+      assign(:task, build_stubbed(:task))
       assign(:view, "pending")
       assign(:empty_bucket, :due_asap)
       controller.request.env["HTTP_REFERER"] = "http://localhost/tasks"
@@ -48,7 +48,7 @@ describe "/tasks/complete" do
 
   describe "complete from related asset" do
     it "should replace pending partial with the completed one" do
-      @task = FactoryGirl.build_stubbed(:task, completed_at: Time.now, completor: current_user)
+      @task = build_stubbed(:task, completed_at: Time.now, completor: current_user)
       assign(:task, @task)
 
       render
@@ -57,7 +57,7 @@ describe "/tasks/complete" do
     end
 
     it "should update recently viewed items" do
-      @task = FactoryGirl.build_stubbed(:task, completed_at: Time.now, completor: current_user)
+      @task = build_stubbed(:task, completed_at: Time.now, completor: current_user)
       assign(:task, @task)
       controller.request.env["HTTP_REFERER"] = "http://localhost/leads/123"
 

data/spec/views/tasks/create.js.haml_spec.rb

@@ -48,7 +48,7 @@ describe "/tasks/create" do
 
   it "should show flash message when assigning a task from pending tasks view" do
     assign(:view, "pending")
-    assign(:task, FactoryGirl.build_stubbed(:task, id: 42, assignee: FactoryGirl.build_stubbed(:user)))
+    assign(:task, build_stubbed(:task, id: 42, assignee: build_stubbed(:user)))
     controller.request.env["HTTP_REFERER"] = "http://localhost/tasks"
     render
 
@@ -58,7 +58,7 @@ describe "/tasks/create" do
 
   it "should update recent items when assigning a task from pending tasks view" do
     assign(:view, "pending")
-    assign(:task, FactoryGirl.build_stubbed(:task, id: 42, assignee: FactoryGirl.build_stubbed(:user)))
+    assign(:task, build_stubbed(:task, id: 42, assignee: build_stubbed(:user)))
     controller.request.env["HTTP_REFERER"] = "http://localhost/tasks"
     render
 
@@ -68,7 +68,7 @@ describe "/tasks/create" do
 
   it "should show flash message when creating a pending task from assigned tasks view" do
     assign(:view, "assigned")
-    assign(:task, FactoryGirl.build_stubbed(:task, id: 42, assignee: nil))
+    assign(:task, build_stubbed(:task, id: 42, assignee: nil))
     controller.request.env["HTTP_REFERER"] = "http://localhost/tasks?view=assigned"
     render
 
@@ -78,7 +78,7 @@ describe "/tasks/create" do
 
   it "should update recent items when creating a pending task from assigned tasks view" do
     assign(:view, "assigned")
-    assign(:task, FactoryGirl.build_stubbed(:task, id: 42, assignee: nil))
+    assign(:task, build_stubbed(:task, id: 42, assignee: nil))
     controller.request.env["HTTP_REFERER"] = "http://localhost/tasks?view=assigned"
     render
 
@@ -89,7 +89,7 @@ describe "/tasks/create" do
   (TASK_STATUSES - ['assigned']).each do |status|
     describe "create from outside the Tasks tab" do
       before do
-        @task = FactoryGirl.build_stubbed(:task, id: 42)
+        @task = build_stubbed(:task, id: 42)
         assign(:view, status)
         assign(:task, @task)
         render
@@ -112,7 +112,7 @@ describe "/tasks/create" do
   end
 
   it "create failure: should re-render [create] template in :create_task div" do
-    assign(:task, FactoryGirl.build(:task, name: nil)) # make it invalid
+    assign(:task, build(:task, name: nil)) # make it invalid
     render
 
     expect(rendered).to include(%/$('#create_task').effect("shake"/)