fat_free_crm 0.17.2 → 0.19.0

data/spec/models/entities/lead_spec.rb

@@ -41,25 +41,23 @@
 require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper')
 
 describe Lead do
-  let(:current_user) { FactoryGirl.create(:user) }
-
   it "should create a new instance given valid attributes" do
     Lead.create!(first_name: "Billy", last_name: "Bones")
   end
 
   describe "Attach" do
     before do
-      @lead = FactoryGirl.create(:lead)
+      @lead = create(:lead)
     end
 
     it "should return nil when attaching existing task" do
-      @task = FactoryGirl.create(:task, asset: @lead, user: current_user)
+      @task = create(:task, asset: @lead)
 
       expect(@lead.attach!(@task)).to eq(nil)
     end
 
     it "should return non-empty list of tasks when attaching new task" do
-      @task = FactoryGirl.create(:task, user: current_user)
+      @task = create(:task)
 
       expect(@lead.attach!(@task)).to eq([@task])
     end
@@ -67,11 +65,11 @@ describe Lead do
 
   describe "Discard" do
     before do
-      @lead = FactoryGirl.create(:lead)
+      @lead = create(:lead)
     end
 
     it "should discard a task" do
-      @task = FactoryGirl.create(:task, asset: @lead, user: current_user)
+      @task = create(:task, asset: @lead)
       expect(@lead.tasks.count).to eq(1)
 
       @lead.discard!(@task)
@@ -82,16 +80,16 @@ describe Lead do
 
   describe "Exportable" do
     describe "assigned lead" do
-      let(:lead1) { FactoryGirl.build(:lead, user: FactoryGirl.create(:user), assignee: FactoryGirl.create(:user)) }
-      let(:lead2) { FactoryGirl.build(:lead, user: FactoryGirl.create(:user, first_name: nil, last_name: nil), assignee: FactoryGirl.create(:user, first_name: nil, last_name: nil)) }
+      let(:lead1) { build(:lead, assignee: create(:user)) }
+      let(:lead2) { build(:lead, user: create(:user, first_name: nil, last_name: nil), assignee: create(:user, first_name: nil, last_name: nil)) }
       it_should_behave_like("exportable") do
         let(:exported) { [lead1, lead2] }
       end
     end
 
     describe "unassigned lead" do
-      let(:lead1) { FactoryGirl.build(:lead, user: FactoryGirl.create(:user), assignee: nil) }
-      let(:lead2) { FactoryGirl.build(:lead, user: FactoryGirl.create(:user, first_name: nil, last_name: nil), assignee: nil) }
+      let(:lead1) { build(:lead, assignee: nil) }
+      let(:lead2) { build(:lead, user: create(:user, first_name: nil, last_name: nil), assignee: nil) }
       it_should_behave_like("exportable") do
         let(:exported) { [lead1, lead2] }
       end

data/spec/models/entities/opportunity_spec.rb

@@ -35,8 +35,8 @@ describe Opportunity do
   end
 
   it "should be possible to create opportunity with the same name" do
-    FactoryGirl.create(:opportunity, name: "Hello")
-    expect { FactoryGirl.create(:opportunity, name: "Hello") }.to_not raise_error
+    create(:opportunity, name: "Hello")
+    expect { create(:opportunity, name: "Hello") }.to_not raise_error
   end
 
   it "have a default stage" do
@@ -50,8 +50,8 @@ describe Opportunity do
 
   describe "Update existing opportunity" do
     before(:each) do
-      @account = FactoryGirl.create(:account)
-      @opportunity = FactoryGirl.create(:opportunity, account: @account)
+      @account = create(:account)
+      @opportunity = create(:opportunity, account: @account)
     end
 
     it "should create new account if requested so" do
@@ -66,7 +66,7 @@ describe Opportunity do
     end
 
     it "should update the account another account was selected" do
-      @another_account = FactoryGirl.create(:account)
+      @another_account = create(:account)
       expect do
         @opportunity.update_with_account_and_permissions(
           account: { id: @another_account.id },
@@ -100,7 +100,7 @@ describe Opportunity do
     end
 
     it "should change account if entered name of another account was found" do
-      @another_account = FactoryGirl.create(:account, name: "Another name")
+      @another_account = create(:account, name: "Another name")
       expect do
         @opportunity.update_with_account_and_permissions(
           account: { name: "Another name" },
@@ -112,14 +112,14 @@ describe Opportunity do
     end
 
     it "should set the probability to 0% if opportunity has been lost" do
-      opportunity = FactoryGirl.create(:opportunity, stage: "prospecting", probability: 25)
+      opportunity = create(:opportunity, stage: "prospecting", probability: 25)
       opportunity.update_attributes(stage: 'lost')
       opportunity.reload
       expect(opportunity.probability).to eq(0)
     end
 
     it "should set the probablility to 100% if opportunity has been won" do
-      opportunity = FactoryGirl.create(:opportunity, stage: "prospecting", probability: 65)
+      opportunity = create(:opportunity, stage: "prospecting", probability: 65)
       opportunity.update_attributes(stage: 'won')
       opportunity.reload
       expect(opportunity.probability).to eq(100)
@@ -130,12 +130,12 @@ describe Opportunity do
     it "should find non-closed opportunities" do
       Opportunity.delete_all
       @opportunities = [
-        FactoryGirl.create(:opportunity, stage: "prospecting", amount: 1),
-        FactoryGirl.create(:opportunity, stage: "analysis", amount: 1),
-        FactoryGirl.create(:opportunity, stage: "won",      amount: 2),
-        FactoryGirl.create(:opportunity, stage: "won",      amount: 2),
-        FactoryGirl.create(:opportunity, stage: "lost",     amount: 3),
-        FactoryGirl.create(:opportunity, stage: "lost",     amount: 3)
+        create(:opportunity, stage: "prospecting", amount: 1),
+        create(:opportunity, stage: "analysis", amount: 1),
+        create(:opportunity, stage: "won",      amount: 2),
+        create(:opportunity, stage: "won",      amount: 2),
+        create(:opportunity, stage: "lost",     amount: 3),
+        create(:opportunity, stage: "lost",     amount: 3)
       ]
       expect(Opportunity.pipeline.sum(:amount)).to eq(2)
       expect(Opportunity.won.sum(:amount)).to eq(4)
@@ -144,8 +144,8 @@ describe Opportunity do
     end
 
     context "unassigned" do
-      let(:unassigned_opportunity) { FactoryGirl.create(:opportunity, assignee: nil) }
-      let(:assigned_opportunity) { FactoryGirl.create(:opportunity, assignee: FactoryGirl.create(:user)) }
+      let(:unassigned_opportunity) { create(:opportunity, assignee: nil) }
+      let(:assigned_opportunity) { create(:opportunity, assignee: create(:user)) }
 
       it "includes unassigned opportunities" do
         expect(Opportunity.unassigned).to include(unassigned_opportunity)
@@ -159,12 +159,12 @@ describe Opportunity do
 
   describe "Attach" do
     before do
-      @opportunity = FactoryGirl.create(:opportunity)
+      @opportunity = create(:opportunity)
     end
 
     it "should return nil when attaching existing asset" do
-      @task = FactoryGirl.create(:task, asset: @opportunity)
-      @contact = FactoryGirl.create(:contact)
+      @task = create(:task, asset: @opportunity)
+      @contact = create(:contact)
       @opportunity.contacts << @contact
 
       expect(@opportunity.attach!(@task)).to eq(nil)
@@ -172,8 +172,8 @@ describe Opportunity do
     end
 
     it "should return non-empty list of attachments when attaching new asset" do
-      @task = FactoryGirl.create(:task)
-      @contact = FactoryGirl.create(:contact)
+      @task = create(:task)
+      @contact = create(:contact)
 
       expect(@opportunity.attach!(@task)).to eq([@task])
       expect(@opportunity.attach!(@contact)).to eq([@contact])
@@ -182,11 +182,11 @@ describe Opportunity do
 
   describe "Discard" do
     before do
-      @opportunity = FactoryGirl.create(:opportunity)
+      @opportunity = create(:opportunity)
     end
 
     it "should discard a task" do
-      @task = FactoryGirl.create(:task, asset: @opportunity)
+      @task = create(:task, asset: @opportunity)
       expect(@opportunity.tasks.count).to eq(1)
 
       @opportunity.discard!(@task)
@@ -195,7 +195,7 @@ describe Opportunity do
     end
 
     it "should discard an contact" do
-      @contact = FactoryGirl.create(:contact)
+      @contact = create(:contact)
       @opportunity.contacts << @contact
       expect(@opportunity.contacts.count).to eq(1)
 
@@ -207,16 +207,16 @@ describe Opportunity do
 
   describe "Exportable" do
     describe "assigned opportunity" do
-      let(:opportunity1) { FactoryGirl.build(:opportunity, user: FactoryGirl.create(:user), assignee: FactoryGirl.create(:user)) }
-      let(:opportunity2) { FactoryGirl.build(:opportunity, user: FactoryGirl.create(:user, first_name: nil, last_name: nil), assignee: FactoryGirl.create(:user, first_name: nil, last_name: nil)) }
+      let(:opportunity1) { build(:opportunity, user: create(:user), assignee: create(:user)) }
+      let(:opportunity2) { build(:opportunity, user: create(:user, first_name: nil, last_name: nil), assignee: create(:user, first_name: nil, last_name: nil)) }
       it_should_behave_like("exportable") do
         let(:exported) { [opportunity1, opportunity2] }
       end
     end
 
     describe "unassigned opportunity" do
-      let(:opportunity1) { FactoryGirl.build(:opportunity, user: FactoryGirl.create(:user), assignee: nil) }
-      let(:opportunity2) { FactoryGirl.build(:opportunity, user: FactoryGirl.create(:user, first_name: nil, last_name: nil), assignee: nil) }
+      let(:opportunity1) { build(:opportunity, user: create(:user), assignee: nil) }
+      let(:opportunity2) { build(:opportunity, user: create(:user, first_name: nil, last_name: nil), assignee: nil) }
       it_should_behave_like("exportable") do
         let(:exported) { [opportunity1, opportunity2] }
       end
@@ -230,14 +230,14 @@ describe Opportunity do
   describe "scopes" do
     context "visible_on_dashboard" do
       before :each do
-        @user = FactoryGirl.create(:user)
-        @o1 = FactoryGirl.create(:opportunity_in_pipeline, user: @user, stage: 'prospecting')
-        @o2 = FactoryGirl.create(:opportunity_in_pipeline, user: @user, assignee: FactoryGirl.create(:user), stage: 'prospecting')
-        @o3 = FactoryGirl.create(:opportunity_in_pipeline, user: FactoryGirl.create(:user), assignee: @user, stage: 'prospecting')
-        @o4 = FactoryGirl.create(:opportunity_in_pipeline, user: FactoryGirl.create(:user), assignee: FactoryGirl.create(:user), stage: 'prospecting')
-        @o5 = FactoryGirl.create(:opportunity_in_pipeline, user: FactoryGirl.create(:user), assignee: @user, stage: 'prospecting')
-        @o6 = FactoryGirl.create(:opportunity, assignee: @user, stage: 'won')
-        @o7 = FactoryGirl.create(:opportunity, assignee: @user, stage: 'lost')
+        @user = create(:user)
+        @o1 = create(:opportunity_in_pipeline, user: @user, stage: 'prospecting')
+        @o2 = create(:opportunity_in_pipeline, user: @user, assignee: create(:user), stage: 'prospecting')
+        @o3 = create(:opportunity_in_pipeline, user: create(:user), assignee: @user, stage: 'prospecting')
+        @o4 = create(:opportunity_in_pipeline, user: create(:user), assignee: create(:user), stage: 'prospecting')
+        @o5 = create(:opportunity_in_pipeline, user: create(:user), assignee: @user, stage: 'prospecting')
+        @o6 = create(:opportunity, assignee: @user, stage: 'won')
+        @o7 = create(:opportunity, assignee: @user, stage: 'lost')
       end
 
       it "should show opportunities which have been created by the user and are unassigned" do
@@ -263,9 +263,9 @@ describe Opportunity do
     end
 
     context "by_closes_on" do
-      let(:o1) { FactoryGirl.create(:opportunity, closes_on: 3.days.from_now) }
-      let(:o2) { FactoryGirl.create(:opportunity, closes_on: 7.days.from_now) }
-      let(:o3) { FactoryGirl.create(:opportunity, closes_on: 5.days.from_now) }
+      let(:o1) { create(:opportunity, closes_on: 3.days.from_now) }
+      let(:o2) { create(:opportunity, closes_on: 7.days.from_now) }
+      let(:o3) { create(:opportunity, closes_on: 5.days.from_now) }
 
       it "should show opportunities ordered by closes on" do
         expect(Opportunity.by_closes_on).to eq([o1, o3, o2])
@@ -273,9 +273,9 @@ describe Opportunity do
     end
 
     context "by_amount" do
-      let(:o1) { FactoryGirl.create(:opportunity, amount:  50_000) }
-      let(:o2) { FactoryGirl.create(:opportunity, amount:  10_000) }
-      let(:o3) { FactoryGirl.create(:opportunity, amount: 750_000) }
+      let(:o1) { create(:opportunity, amount:  50_000) }
+      let(:o2) { create(:opportunity, amount:  10_000) }
+      let(:o3) { create(:opportunity, amount: 750_000) }
 
       it "should show opportunities ordered by amount" do
         expect(Opportunity.by_amount).to eq([o3, o1, o2])
@@ -283,9 +283,9 @@ describe Opportunity do
     end
 
     context "not lost" do
-      let(:o1) { FactoryGirl.create(:opportunity, stage: 'won') }
-      let(:o2) { FactoryGirl.create(:opportunity, stage: 'lost') }
-      let(:o3) { FactoryGirl.create(:opportunity, stage: 'analysis') }
+      let(:o1) { create(:opportunity, stage: 'won') }
+      let(:o2) { create(:opportunity, stage: 'lost') }
+      let(:o3) { create(:opportunity, stage: 'analysis') }
 
       it "should show opportunities which are not lost" do
         expect(Opportunity.not_lost).to include(o1, o3)

data/spec/models/fields/custom_field_date_pair_spec.rb

@@ -67,7 +67,8 @@ describe CustomFieldDatePair do
 
     it "when from > to it should not be valid" do
       foo = double(cf_event_from: @today, cf_event_to: @today - 1.day)
-      err = double(:errors); allow(err).to receive(:add)
+      err = double(:errors)
+      allow(err).to receive(:add)
       expect(foo).to receive(:errors).and_return(err)
       @to.custom_validator(foo)
     end
@@ -82,7 +83,8 @@ describe CustomFieldDatePair do
     it "should call custom field validation on super class" do
       from = CustomFieldDatePair.new(name: 'cf_event_from', required: true)
       foo = double(cf_event_from: nil)
-      err = double(:errors); allow(err).to receive(:add)
+      err = double(:errors)
+      allow(err).to receive(:add)
       expect(foo).to receive(:errors).and_return(err)
       from.custom_validator(foo)
     end

data/spec/models/fields/custom_field_spec.rb

@@ -35,16 +35,16 @@ describe CustomField do
     expect(Contact).to receive(:reset_column_information)
     expect(Contact).to receive(:serialize_custom_fields!)
 
-    FactoryGirl.create(:custom_field,
-                       as: "string",
-                       name: "cf_test_field",
-                       label: "Test Field",
-                       field_group: FactoryGirl.create(:field_group, klass_name: "Contact"))
+    create(:custom_field,
+           as: "string",
+           name: "cf_test_field",
+           label: "Test Field",
+           field_group: create(:field_group, klass_name: "Contact"))
   end
 
   it "should generate a unique column name for a custom field" do
-    field_group = FactoryGirl.build(:field_group, klass_name: "Contact")
-    c = FactoryGirl.build(:custom_field, label: "Test Field", field_group: field_group)
+    field_group = build(:field_group, klass_name: "Contact")
+    c = build(:custom_field, label: "Test Field", field_group: field_group)
 
     columns = []
     %w[cf_test_field cf_test_field_2 cf_test_field_3 cf_test_field_4].each do |field|
@@ -54,12 +54,12 @@ describe CustomField do
   end
 
   it "should evaluate the safety of database transitions" do
-    c = FactoryGirl.build(:custom_field, as: "string")
+    c = build(:custom_field, as: "string")
     expect(c.send(:db_transition_safety, c.as, "email")).to eq(:null)
     expect(c.send(:db_transition_safety, c.as, "text")).to eq(:safe)
     expect(c.send(:db_transition_safety, c.as, "datetime")).to eq(:unsafe)
 
-    c = FactoryGirl.build(:custom_field, as: "datetime")
+    c = build(:custom_field, as: "datetime")
     expect(c.send(:db_transition_safety, c.as, "date")).to eq(:safe)
     expect(c.send(:db_transition_safety, c.as, "url")).to eq(:unsafe)
   end
@@ -67,7 +67,7 @@ describe CustomField do
   it "should return a safe list of types for the 'as' select options" do
     { "email"   => %w[check_boxes text string email url tel select radio_buttons],
       "integer" => %w[integer float] }.each do |type, expected_arr|
-      c = FactoryGirl.build(:custom_field, as: type)
+      c = build(:custom_field, as: type)
       opts = c.available_as
       expect(opts.map(&:first)).to match_array(expected_arr)
     end
@@ -81,12 +81,12 @@ describe CustomField do
     expect(Contact).to receive(:reset_column_information).twice
     expect(Contact).to receive(:serialize_custom_fields!).twice
 
-    field_group = FactoryGirl.create(:field_group, klass_name: "Contact")
-    c = FactoryGirl.create(:custom_field,
-                           label: "Test Field",
-                           name: nil,
-                           as: "email",
-                           field_group: field_group)
+    field_group = create(:field_group, klass_name: "Contact")
+    c = create(:custom_field,
+               label: "Test Field",
+               name: nil,
+               as: "email",
+               field_group: field_group)
     c.as = "text"
     c.save
   end
@@ -102,7 +102,7 @@ describe CustomField do
       expect(Contact).to receive(:reset_column_information)
       expect(Contact).to receive(:serialize_custom_fields!)
 
-      contact = FactoryGirl.build(:contact)
+      contact = build(:contact)
       expect(contact.cf_another_new_field).to eq(nil)
     end
   end
@@ -111,7 +111,8 @@ describe CustomField do
     it "should have errors if custom field is required" do
       event = CustomField.new(name: 'cf_event', required: true)
       foo = double(cf_event: nil)
-      err = double(:errors); allow(err).to receive(:add)
+      err = double(:errors)
+      allow(err).to receive(:add)
       expect(foo).to receive(:errors).and_return(err)
       event.custom_validator(foo)
     end
@@ -119,7 +120,8 @@ describe CustomField do
     it "should have errors if custom field is longer than maxlength" do
       event = CustomField.new(name: 'cf_event', maxlength: 5)
       foo = double(cf_event: "This is too long")
-      err = double(:errors); allow(err).to receive(:add)
+      err = double(:errors)
+      allow(err).to receive(:add)
       expect(foo).to receive(:errors).and_return(err)
       event.custom_validator(foo)
     end

data/spec/models/list_spec.rb

@@ -10,10 +10,10 @@ require 'spec_helper'
 describe List do
   it "should parse the controller from the url" do
     ["/controller/action", "controller/action?utf8=%E2%9C%93"].each do |url|
-      list = FactoryGirl.build(:list, url: url)
+      list = build(:list, url: url)
       expect(list.controller).to eq("controller")
     end
-    list = FactoryGirl.build(:list, url: nil)
+    list = build(:list, url: nil)
     expect(list.controller).to eq(nil)
   end
 end

data/spec/models/observers/entity_observer_spec.rb

@@ -10,14 +10,14 @@ require 'spec_helper'
 describe EntityObserver do
   before do
     allow(Setting).to receive(:host).and_return('http://www.example.com')
-    allow(PaperTrail).to receive(:whodunnit).and_return(assigner)
+    allow(PaperTrail.request).to receive(:whodunnit).and_return(assigner)
   end
 
   %i[account contact lead opportunity].each do |entity_type|
     describe "on creation of #{entity_type}" do
-      let(:assignee) { FactoryGirl.create(:user) }
-      let(:assigner) { FactoryGirl.create(:user) }
-      let!(:entity)  { FactoryGirl.build(entity_type, user: assigner, assignee: assignee) }
+      let(:assignee) { create(:user) }
+      let(:assigner) { create(:user) }
+      let!(:entity)  { build(entity_type, user: assigner, assignee: assignee) }
       let(:mail) { double('mail', deliver_now: true) }
 
       after :each do
@@ -45,9 +45,9 @@ describe EntityObserver do
     end
 
     describe "on update of #{entity_type}" do
-      let(:assignee) { FactoryGirl.create(:user) }
-      let(:assigner) { FactoryGirl.create(:user) }
-      let!(:entity)  { FactoryGirl.create(entity_type, user: FactoryGirl.create(:user)) }
+      let(:assignee) { create(:user) }
+      let(:assigner) { create(:user) }
+      let!(:entity)  { create(entity_type, user: create(:user)) }
       let(:mail) { double('mail', deliver_now: true) }
 
       it "notifies the new owner if the entity is re-assigned" do

data/spec/models/polymorphic/address_spec.rb

@@ -29,6 +29,6 @@ require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper')
 
 describe Address do
   it "should create a new instance given valid attributes" do
-    Address.create!(street1: "street1", street2: "street2", city: "city", state: "state", zipcode: "zipcode", country: "country", full_address: "fa", address_type: "Lead", addressable: FactoryGirl.create(:lead))
+    Address.create!(street1: "street1", street2: "street2", city: "city", state: "state", zipcode: "zipcode", country: "country", full_address: "fa", address_type: "Lead", addressable: create(:lead))
   end
 end

data/spec/models/polymorphic/avatar_spec.rb

@@ -24,22 +24,22 @@ require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper')
 
 describe Avatar do
   before(:each) do
-    @user = FactoryGirl.create(:user)
+    @user = create(:user)
   end
 
   it "should create a new instance given valid attributes" do
-    expect(FactoryGirl.create(:avatar, entity: @user)).to be_valid
+    expect(create(:avatar, entity: @user)).to be_valid
   end
 
   it "user should have one avatar as entity" do
-    avatar = FactoryGirl.create(:avatar, entity: @user)
+    avatar = create(:avatar, entity: @user)
     expect(@user.avatar).to eq(avatar)
   end
 
   it "user might have many avatars as owner" do
     avatars = [
-      FactoryGirl.create(:avatar, user: @user, entity: FactoryGirl.create(:user)),
-      FactoryGirl.create(:avatar, user: @user, entity: FactoryGirl.create(:user))
+      create(:avatar, user: @user, entity: create(:user)),
+      create(:avatar, user: @user, entity: create(:user))
     ]
     expect(@user.avatars).to eq(avatars)
   end