fat_free_crm 0.11.3 → 0.11.4

data/spec/models/users/group_spec.rb

@@ -0,0 +1,5 @@
+require 'spec_helper'
+
+describe Group do
+  pending "add some examples to (or delete) #{__FILE__}"
+end

data/spec/models/users/permission_spec.rb

@@ -23,5 +23,22 @@ describe Permission do
   it "should create a new instance given valid attributes" do
     Permission.create!(@valid_attributes)
   end
+  
+  it "should validate with group_ids" do
+    p = Permission.new :group_id => 1
+    p.should be_valid
+  end
+  
+  it "should validate with user_ids" do
+    p = Permission.new :user_id => 2
+    p.should be_valid
+  end
+  
+  it "should validate not allow group_ids or user_ids to be blank" do
+    p = Permission.new
+    p.should_not be_valid
+    p.errors['user_id'].should  == ["can't be blank"]
+    p.errors['group_id'].should == ["can't be blank"]
+  end
+  
 end
-

data/spec/models/users/preference_spec.rb

@@ -42,6 +42,11 @@ describe Preference do
       @preference = FactoryGirl.create(:preference, :user => FactoryGirl.create(:user), :name => "thingymabob", :value => @magoody)
       @user.preference[:thingymabob].should == nil
     end
+    
+    it "should not fail is user is nil" do
+      @preference = FactoryGirl.create(:preference, :user => nil, :name => "thingymabob", :value => @magoody)
+      @preference[:thingymabob].should == nil
+    end
   end
 
   describe "set user preference" do
@@ -57,4 +62,3 @@ describe Preference do
     end
   end
 end
-

data/spec/models/users/user_spec.rb

@@ -69,7 +69,7 @@ describe User do
 
     it "should not destroy the user if she owns a comment" do
       login
-      account = FactoryGirl.create(:account, :user => @current_user)
+      account = FactoryGirl.create(:account, :user => current_user)
       FactoryGirl.create(:comment, :user => @user, :commentable => account)
       @user.destroy
       lambda { User.find(@user) }.should_not raise_error(ActiveRecord::RecordNotFound)
@@ -78,15 +78,15 @@ describe User do
 
     it "should not destroy the current user" do
       login
-      @current_user.destroy
-      lambda { @current_user.reload }.should_not raise_error(ActiveRecord::RecordNotFound)
-      @current_user.destroyed?.should == false
+      current_user.destroy
+      lambda { current_user.reload }.should_not raise_error(ActiveRecord::RecordNotFound)
+      current_user.should_not be_destroyed
     end
 
     it "should destroy the user" do
       @user.destroy
       lambda { User.find(@user) }.should raise_error(ActiveRecord::RecordNotFound)
-      @user.destroyed?.should == true
+      @user.should be_destroyed
     end
 
     it "once the user gets deleted all her permissions must be deleted too" do
@@ -109,13 +109,61 @@ describe User do
   it "should set suspended timestamp upon creation if signups need approval and the user is not an admin" do
     Setting.stub(:user_signup).and_return(:needs_approval)
     @user = FactoryGirl.create(:user, :suspended_at => nil)
-    @user.suspended?.should == true
+    @user.should be_suspended
   end
 
   it "should not set suspended timestamp upon creation if signups need approval and the user is an admin" do
     Setting.stub(:user_signup).and_return(:needs_approval)
     @user = FactoryGirl.create(:user, :admin => true, :suspended_at => nil)
-    @user.suspended?.should == false
+    @user.should_not be_suspended
+  end
+
+  context "scopes" do
+    describe "have_assigned_opportunities" do
+      before :each do
+        @user1 = FactoryGirl.create(:user)
+        FactoryGirl.create(:open_opportunity, :assignee => @user1)
+
+        @user2 = FactoryGirl.create(:user)
+
+        @user3 = FactoryGirl.create(:user)
+        FactoryGirl.create(:opportunity, :assignee => @user3, :stage => 'won')
+
+        @user4 = FactoryGirl.create(:user)
+        FactoryGirl.create(:opportunity, :assignee => @user4, :stage => 'lost')
+      end
+
+      it "includes users with assigned opportunities" do
+        User.have_assigned_opportunities.should include(@user1)
+      end
+
+      it "excludes users without any assigned opportunities" do
+        User.have_assigned_opportunities.should_not include(@user2)
+      end
+
+      it "excludes users with opportunities that have been won or lost" do
+        User.have_assigned_opportunities.should_not include(@user3)
+        User.have_assigned_opportunities.should_not include(@user4)
+      end
+    end
+  end
+
+  context "instance methods" do
+    describe "assigned_opportunities" do
+      before :each do
+        @user = FactoryGirl.create(:user)
+        @opportunity1 = FactoryGirl.create(:opportunity, :assignee => @user)
+        @opportunity2 = FactoryGirl.create(:opportunity, :assignee => FactoryGirl.create(:user))
+      end
+
+      it "includes opportunities assigned to user" do
+        @user.assigned_opportunities.should include(@opportunity1)
+      end
+
+      it "does not include opportunities assigned to another user" do
+        @user.assigned_opportunities.should_not include(@opportunity2)
+      end
+    end
   end
 
   describe "Setting I18n.locale" do
@@ -157,4 +205,3 @@ describe User do
     end
   end
 end
-

data/spec/shared/models.rb

@@ -59,12 +59,25 @@ module SharedModelSpecs
 
       it{ should be_able_to(:manage, asset) }
     end
+    
+    context "when private access administrator" do
+      let(:asset){ FactoryGirl.create(factory, :access => 'Private') }
+      let(:user) { FactoryGirl.create(:user, :admin => true) }
+
+      it{ should be_able_to(:manage, asset) }
+    end
 
     context "when private access not owner" do
       let(:asset){ FactoryGirl.create(factory, :access => 'Private') }
 
       it{ should_not be_able_to(:manage, asset) }
     end
+    
+    context "when private access not owner but is assigned" do
+      let(:asset){ FactoryGirl.create(factory, :access => 'Private', :assigned_to => user.id) }
+
+      it{ should be_able_to(:manage, asset) }
+    end
 
     context "when shared access with permission" do
       let(:asset){ FactoryGirl.create(factory, :access => 'Shared', :permissions => [permission]) }
@@ -79,5 +92,46 @@ module SharedModelSpecs
 
       it{ should_not be_able_to(:manage, asset) }
     end
+    
+    context "when shared access with no permission but administrator" do
+      let(:asset){ FactoryGirl.create(factory, :access => 'Shared', :permissions => [permission]) }
+      let(:permission){ Permission.new(:user => FactoryGirl.create(:user)) }
+      let(:user) { FactoryGirl.create(:user, :admin => true) }
+
+      it{ should be_able_to(:manage, asset) }
+    end
+    
+    context "when shared access with no permission but assigned" do
+      let(:asset){ FactoryGirl.create(factory, :access => 'Shared', :permissions => [permission], :assigned_to => user.id) }
+      let(:permission){ Permission.new(:user => FactoryGirl.create(:user)) }
+
+      it{ should be_able_to(:manage, asset) }
+    end
+
+    context "when shared access with group permission" do
+      let(:asset){ FactoryGirl.create(factory, :access => 'Shared', :permissions => [permission]) }
+      let(:permission){ Permission.new(:group => group) }
+      let(:group){ FactoryGirl.create(:group, :users => [user]) }
+
+      it{ should be_able_to(:manage, asset) }
+    end
+    
+    context "when shared access with several group permissions" do
+      let(:asset){ FactoryGirl.create(factory, :access => 'Shared', :permissions => permissions) }
+      let(:permissions){ [Permission.new(:group => group1), Permission.new(:group => group2)] }
+      let(:group1){ FactoryGirl.create(:group, :users => [user]) }
+      let(:group2){ FactoryGirl.create(:group, :users => [user]) }
+
+      it{ should be_able_to(:manage, asset) }
+    end
+
+    context "when shared access with no group permission" do
+      let(:asset){ FactoryGirl.create(factory, :access => 'Shared', :permissions => [permission]) }
+      let(:permission){ Permission.new(:group => group) }
+      let(:group){ FactoryGirl.create(:group) }
+
+      it{ should_not be_able_to(:manage, asset) }
+    end
+    
   end
 end

data/spec/spec_helper.rb

@@ -1,113 +1,108 @@
 require 'rubygems'
-require 'spork'
 
-Spork.prefork do
-  # Loading more in this block will cause your tests to run faster. However,
-  # if you change any configuration or code from libraries loaded here, you'll
-  # need to restart spork for it take effect.
+ENV["RAILS_ENV"] = 'test'
+require File.expand_path("../../config/environment", __FILE__)
+require 'rspec/rails'
+require 'rspec/autorun'
 
-  if ENV["COVERAGE"]
-    require 'simplecov'
-    SimpleCov.start 'rails'
-  end
-
-  # This file is copied to spec/ when you run 'rails generate rspec:install'
-  ENV["RAILS_ENV"] = 'test'
-  require File.expand_path("../../config/environment", __FILE__)
-  require 'rspec/rails'
-  require 'rspec/autorun'
-  require 'fuubar'
-
-  # Load factories
-  require 'factory_girl'
-  require 'ffaker'
+require 'acts_as_fu'
+require 'factory_girl'
+require 'ffaker'
 
-  # Requires supporting ruby files with custom matchers and macros, etc,
-  # in spec/support/ and its subdirectories.
-  Dir[Rails.root.join("spec/support/**/*.rb")].each{ |f| require File.expand_path(f) }
+# Requires supporting ruby files with custom matchers and macros, etc,
+# in spec/support/ and its subdirectories.
+Dir[Rails.root.join("spec/support/**/*.rb")].each{ |f| require File.expand_path(f) }
 
-  # Load shared behavior modules to be included by Runner config.
-  Dir[File.dirname(__FILE__) + "/shared/*.rb"].each{ |f| require File.expand_path(f) }
+# Load shared behavior modules to be included by Runner config.
+Dir[File.dirname(__FILE__) + "/shared/*.rb"].each{ |f| require File.expand_path(f) }
 
-  TASK_STATUSES = %w(pending assigned completed).freeze
+TASK_STATUSES = %w(pending assigned completed).freeze
+OPPORTUNITY_STATUSES = %w(prospecting analysis presentation proposal negotiation final_review won lost).freeze
+Setting[:opportunity_stage] = OPPORTUNITY_STATUSES
 
-  I18n.locale = 'en-US'
+I18n.locale = 'en-US'
 
-  Paperclip.options[:log] = false
+Paperclip.options[:log] = false
 
-  RSpec.configure do |config|
-    # == Mock Framework
-    #
-    # If you prefer to use mocha, flexmock or RR, uncomment the appropriate line:
-    #
-    # config.mock_with :mocha
-    # config.mock_with :flexmock
-    # config.mock_with :rr
-    config.mock_with :rspec
+RSpec.configure do |config|
+  # == Mock Framework
+  #
+  # If you prefer to use mocha, flexmock or RR, uncomment the appropriate line:
+  #
+  # config.mock_with :mocha
+  # config.mock_with :flexmock
+  # config.mock_with :rr
+  config.mock_with :rspec
 
-    config.fixture_path = "#{Rails.root}/spec/fixtures"
+  config.fixture_path = "#{Rails.root}/spec/fixtures"
 
-    # RSpec configuration options for Fat Free CRM.
-    config.include RSpec::Rails::Matchers
-    config.include(SharedControllerSpecs, :type => :controller)
-    config.include(SharedModelSpecs,      :type => :model)
+  # RSpec configuration options for Fat Free CRM.
+  config.include RSpec::Rails::Matchers
+  config.include(SharedControllerSpecs, :type => :controller)
+  config.include(SharedModelSpecs,      :type => :model)
 
-    config.before(:each) do
-      PaperTrail.enabled = false
+  config.before(:each) do
+    PaperTrail.enabled = false
 
-      # Overwrite locale settings within "config/settings.yml" if necessary.
-      # In order to ensure that test still pass if "Setting.locale" is not set to "en-US".
-      I18n.locale = 'en-US'
-      Setting.locale = 'en-US' unless Setting.locale == 'en-US'
-    end
+    # Overwrite locale settings within "config/settings.yml" if necessary.
+    # In order to ensure that test still pass if "Setting.locale" is not set to "en-US".
+    I18n.locale = 'en-US'
+    Setting.locale = 'en-US' unless Setting.locale == 'en-US'
+  end
 
-    config.after(:each, :type => :view) do
-      # detect html-quoted entities in all rendered responses
-      rendered.should_not match(/&[A-Za-z]{1,6};/) if rendered
-    end
+  # If you're not using ActiveRecord, or you'd prefer not to run each of your
+  # examples within a transaction, remove the following line or assign false
+  # instead of true.
+  config.use_transactional_fixtures = false
+  config.before :suite do
+    DatabaseCleaner.strategy = :transaction
+    DatabaseCleaner.clean_with(:truncation)
+  end
+  config.before :all, :type => :request do
+    DatabaseCleaner.clean_with(:truncation)
+  end
+  config.around :each, :type => :request do |example|
+    DatabaseCleaner.strategy = :truncation
+    example.run
+    DatabaseCleaner.strategy = :transaction
+  end
+  config.around :each do |example|
+    DatabaseCleaner.start
+    example.run
+    DatabaseCleaner.clean
+  end
 
 
-    # If you're not using ActiveRecord, or you'd prefer not to run each of your
-    # examples within a transaction, remove the following line or assign false
-    # instead of true.
-    config.use_transactional_fixtures = true
+  # config.before :all, :type => :view do
+  #   view.lookup_context.prefixes << 'entities'
+  # end
 
-    # Fuubar formatter doesn't work too well on Travis
-    config.formatter = ENV["TRAVIS"] ? :progress : "Fuubar"
+  # If true, the base class of anonymous controllers will be inferred
+  # automatically. This will be the default behavior in future versions of
+  # rspec-rails.
+  config.infer_base_class_for_anonymous_controllers = false
+end
 
-    # If true, the base class of anonymous controllers will be inferred
-    # automatically. This will be the default behavior in future versions of
-    # rspec-rails.
-    config.infer_base_class_for_anonymous_controllers = false
+ActionView::TestCase::TestController.class_eval do
+  def controller_name
+    request.path_parameters["controller"].split('/').last
   end
+end
 
-  ActionView::TestCase::TestController.class_eval do
-    def controller_name
-      request.path_parameters["controller"].split('/').last
-    end
+ActionView::Base.class_eval do
+  def controller_name
+    HashWithIndifferentAccess.new(request.path_parameters)["controller"].split('/').last
   end
 
-  ActionView::Base.class_eval do
-    def controller_name
-      HashWithIndifferentAccess.new(request.path_parameters)["controller"].split('/').last
-    end
-
-    def called_from_index_page?(controller = controller_name)
-      if controller != "tasks"
-        request.referer =~ %r(/#{controller}$)
-      else
-        request.referer =~ /tasks\?*/
-      end
-    end
-
-    def called_from_landing_page?(controller = controller_name)
-      request.referer =~ %r(/#{controller}/\w+)
+  def called_from_index_page?(controller = controller_name)
+    if controller != "tasks"
+      request.referer =~ %r(/#{controller}$)
+    else
+      request.referer =~ /tasks\?*/
     end
   end
 
-end # Spork.prefork
-
-
-Spork.each_run do
-  Dir[Rails.root.join("spec/support/**/*.rb")].each {|f| require f}
+  def called_from_landing_page?(controller = controller_name)
+    request.referer =~ %r(/#{controller}/\w+)
+  end
 end

data/spec/support/auth_macros.rb

@@ -12,7 +12,7 @@ end
 #----------------------------------------------------------------------------
 def login(user_stubs = {}, session_stubs = {})
   User.current_user = @current_user = FactoryGirl.create(:user, user_stubs)
-  @current_user_session = mock(Authentication, {:record => @current_user}.merge(session_stubs))
+  @current_user_session = mock(Authentication, {:record => current_user}.merge(session_stubs))
   Authentication.stub!(:find).and_return(@current_user_session)
   #set_timezone
 end
@@ -21,7 +21,7 @@ alias :require_user :login
 #----------------------------------------------------------------------------
 def login_and_assign(user_stubs = {}, session_stubs = {})
   login(user_stubs, session_stubs)
-  assigns[:current_user] = @current_user
+  assigns[:current_user] = current_user
 end
 
 #----------------------------------------------------------------------------
@@ -41,4 +41,3 @@ end
 def current_user_session
   @current_user_session
 end
-

data/spec/views/accounts/_edit.haml_spec.rb

@@ -6,7 +6,7 @@ describe "/accounts/_edit" do
   before do
     login_and_assign
     assign(:account, @account = FactoryGirl.create(:account))
-    assign(:users, [ @current_user ])
+    assign(:users, [ current_user ])
   end
 
   it "should render [edit account] form" do
@@ -35,4 +35,3 @@ describe "/accounts/_edit" do
     rendered.should_not have_tag("textarea[id=account_background_info]")
   end
 end
-