fat_free_crm 0.11.3 → 0.11.4

data/spec/factories/account_factories.rb

@@ -2,7 +2,7 @@ FactoryGirl.define do
   factory :account do
     user
     assigned_to         nil
-    name                { Faker::Company.name }
+    name                { Faker::Company.name + rand(100).to_s }
     access              "Public"
     website             { FactoryGirl.generate(:website) }
     email               { Faker::Internet.email }
@@ -32,4 +32,4 @@ FactoryGirl.define do
     updated_at          { FactoryGirl.generate(:time) }
     created_at          { FactoryGirl.generate(:time) }
   end
-end
+end

data/spec/factories/opportunity_factories.rb

@@ -1,13 +1,13 @@
 FactoryGirl.define do
   factory :opportunity do
-    user                
-    campaign            
+    user
+    campaign
     account             { FactoryGirl.create(:account) }
     assigned_to         nil
     name                { Faker::Lorem.sentence[0,64] }
     access              "Public"
     source              { %w(campaign cold_call conference online referral self web word_of_mouth other).sample }
-    stage               { %w(prospecting analysis presentation proposal negotiation final_review won lost).sample }
+    stage               { OPPORTUNITY_STATUSES.sample }
     probability         { rand(50) }
     amount              { rand(1000) }
     discount            { rand(100) }
@@ -17,4 +17,12 @@ FactoryGirl.define do
     updated_at          { FactoryGirl.generate(:time) }
     created_at          { FactoryGirl.generate(:time) }
   end
-end
+
+  factory :opportunity_in_pipeline, :parent => :opportunity do
+    stage { OPPORTUNITY_STATUSES.sample }
+  end
+
+  factory :open_opportunity, :parent => :opportunity do
+    stage { OPPORTUNITY_STATUSES.sample }
+  end
+end

data/spec/factories/task_factories.rb

@@ -15,4 +15,8 @@ FactoryGirl.define do
     updated_at          { FactoryGirl.generate(:time) }
     created_at          { FactoryGirl.generate(:time) }
   end
+
+  factory :completed_task, :parent => :task do
+    completed_at { Date.yesterday }
+  end
 end

data/spec/factories/user_factories.rb

@@ -40,7 +40,7 @@ FactoryGirl.define do
 
 
   factory :permission do
-    user                
+    user
     asset               { raise "Please specify :asset for the permission" }
     updated_at          { FactoryGirl.generate(:time) }
     created_at          { FactoryGirl.generate(:time) }
@@ -48,10 +48,17 @@ FactoryGirl.define do
 
 
   factory :preference do
-    user                
+    user
     name                { raise "Please specify :name for the preference" }
     value               { raise "Please specify :value for the preference" }
     updated_at          { FactoryGirl.generate(:time) }
     created_at          { FactoryGirl.generate(:time) }
   end
+
+
+  factory :group do
+    name                { Faker::Company.name }
+    updated_at          { FactoryGirl.generate(:time) }
+    created_at          { FactoryGirl.generate(:time) }
+  end
 end

data/spec/helpers/application_helper_spec.rb

@@ -63,5 +63,19 @@ describe ApplicationHelper do
       helper.shown_on_landing_page?.should == false
     end
   end
+  
+  describe "current_view_name" do
+  
+    before(:each) do
+      @user = mock_model(User)
+      helper.stub!(:current_user).and_return(@user)
+      controller.stub!(:params).and_return({'action' => 'show', 'controller' => 'contacts'})
+    end
+  
+    it "should return the contact 'show' outline stored in the user preferences" do
+      @user.should_receive(:pref).and_return({:contacts_show_view => 'long'})
+      helper.current_view_name.should == 'long'
+    end
+  
+  end
 end
-

data/spec/helpers/groups_helper_spec.rb

@@ -0,0 +1,15 @@
+require 'spec_helper'
+
+# Specs in this file have access to a helper object that includes
+# the GroupsHelper. For example:
+#
+# describe GroupsHelper do
+#   describe "string concat" do
+#     it "concats two strings with spaces" do
+#       helper.concat_strings("this","that").should == "this that"
+#     end
+#   end
+# end
+describe GroupsHelper do
+  pending "add some examples to (or delete) #{__FILE__}"
+end

data/spec/helpers/users_helper_spec.rb

@@ -2,11 +2,33 @@ require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
 
 describe UsersHelper do
 
-  #Delete this example and add some real ones or delete this file
-  it "should be included in the object returned by #helper" do
-    included_modules = (class << helper; self; end).send :included_modules
-    included_modules.should include(UsersHelper)
+  let(:myself) { FactoryGirl.create(:user, :id => 54)}
+  let(:user1) { FactoryGirl.create(:user,  :id => 60, :first_name => 'Bob', :last_name => "Hope") }
+  let(:user2) { FactoryGirl.create(:user,  :id => 75, :first_name => 'Billy', :last_name => "Joel") }
+
+  describe "user_options_for_select" do
+    it "includes 'myself'" do
+      user_options_for_select([user1, user2], myself).should include(["Myself", 54])
+    end
+
+    it "includes other users" do
+      user_options_for_select([user1, user2], myself).should include(["Bob Hope", 60], ["Billy Joel", 75])
+    end
   end
 
+  describe "user_select" do
+    it "includes blank option" do
+      user_select(:lead, [user1, user2], myself).should match(/<option value="">Unassigned<\/option>/)
+    end
+
+    it "includes myself" do
+      user_select(:lead, [user1, user2], myself).should match(/<option value="54">Myself<\/option>/)
+    end
+
+    it "includes other users" do
+      user_select(:lead, [user1, user2], myself).should match(/<option value="60">Bob Hope<\/option>/)
+      user_select(:lead, [user1, user2], myself).should match(/<option value="75">Billy Joel<\/option>/)
+    end
+  end
 end
 

data/spec/lib/comment_extensions_spec.rb

@@ -0,0 +1,29 @@
+require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
+
+describe FatFreeCRM::CommentExtensions do
+  describe "add_comment_by_user" do
+    let(:user) { FactoryGirl.create(:user)}
+
+    before :each do
+      build_model(:commentable_entity) do
+        string :subscribed_users
+        serialize :subscribed_users, Set
+
+        acts_as_commentable
+        uses_comment_extensions
+      end
+    end
+
+    it "should create a comment for user" do
+      entity = CommentableEntity.create
+      entity.add_comment_by_user("I will handle this one", user)
+      entity.reload.comments.map(&:comment).should include("I will handle this one")
+    end
+
+    it "should not create a comment if body is blank" do
+      entity = CommentableEntity.create
+      entity.add_comment_by_user("", user)
+      entity.reload.comments.should be_empty
+    end
+  end
+end

data/spec/lib/core_ext/{string.rb → string_spec.rb}

@@ -1,4 +1,3 @@
-require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper')
 require "fat_free_crm/core_ext/string"
 
 describe "String" do

data/spec/lib/fields_spec.rb

@@ -0,0 +1,104 @@
+require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
+
+describe 'FatFreeCRM::Fields' do
+
+  class Foo
+    include FatFreeCRM::Fields
+    include ActiveModel::Validations
+    has_fields
+  end
+
+  class Bar
+    include FatFreeCRM::Fields
+    include ActiveModel::Validations
+  end
+
+  it do
+    Foo.new.should respond_to(:field_groups)
+  end
+  
+  it do
+    Foo.should respond_to(:serialize_custom_fields!)
+  end
+  
+  it do
+    Foo.should respond_to(:fields)
+  end
+  
+  it "calling has_fields should invoke serialize_custom_fields!" do
+    Bar.should_receive(:serialize_custom_fields!)
+    Bar.has_fields
+  end
+  
+  describe "field_groups" do
+  
+    it "should call FieldGroup" do
+      ActiveRecord::Base.connection.should_receive(:table_exists?).with('field_groups').and_return(true)
+      dummy_scope = mock
+      dummy_scope.should_receive(:order).with(:position)
+      FieldGroup.should_receive(:where).and_return(dummy_scope)
+      Foo.new.field_groups
+    end
+    
+    it "should not call FieldGroup if table doesn't exist (migrations not yet run)" do
+      ActiveRecord::Base.connection.should_receive(:table_exists?).with('field_groups').and_return(false)
+      Foo.new.field_groups.should == []
+    end
+  
+  end
+  
+  describe "fields" do
+    
+    before(:each) do
+      @f1 = mock(Field)
+      @f2 = mock(Field)
+      @f3 = mock(Field)
+      @field_groups = [mock(FieldGroup, :fields => [@f1, @f2]), mock(FieldGroup, :fields => [@f3])]
+    end
+  
+    it "should convert field_groups into a flattened list of fields" do
+      Foo.should_receive(:field_groups).and_return(@field_groups)
+      Foo.fields.should == [@f1, @f2, @f3]
+    end
+  
+  end
+  
+  describe "serialize_custom_fields!" do
+  
+    before(:each) do
+      @f1 = mock(Field, :as => 'check_boxes', :name => 'field1')
+      @f2 = mock(Field, :as => 'date', :name => 'field2')
+    end
+    
+    it "should serialize checkbox fields as Array" do
+      Foo.stub(:serialized_attributes).and_return( {:field1 => @f1, :field2 => @f2} )
+      Foo.should_receive(:fields).and_return([@f1, @f2])
+      Foo.should_receive(:serialize).with(:field1, Array)
+      Foo.serialize_custom_fields!
+    end
+  
+  end
+  
+  it "should validate custom fields" do
+    foo = Foo.new
+    foo.should_receive(:custom_fields_validator)
+    foo.should be_valid
+  end
+  
+  describe "custom_fields_validator" do
+  
+    before(:each) do
+      @f1 = mock(Field)
+      @field_groups = [ mock(FieldGroup, :fields => [@f1]) ]
+    end
+  
+    it "should call custom_validator on each custom field" do
+      foo = Foo.new
+      @f1.should_receive(:custom_validator).with(foo)
+      foo.should_receive(:field_groups).and_return(@field_groups)
+      foo.should be_valid
+    end
+
+  end
+  
+end

data/spec/lib/permissions_spec.rb

@@ -0,0 +1,144 @@
+require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
+
+describe FatFreeCRM::Permissions do
+
+  before :each do
+    build_model(:user_with_permission) do
+      uses_user_permissions
+      string :access
+    end
+  end
+  
+  describe "initialization" do
+    it "should add 'has_many permissions' to the model" do
+      entity = UserWithPermission.new
+      entity.should respond_to(:permissions)
+    end
+    it "should add scope called 'my'" do
+      UserWithPermission.should respond_to(:my)
+    end
+  end
+
+  describe "user_ids" do
+    before(:each) do
+      @entity = UserWithPermission.create(:access => "Shared")
+    end
+    
+    it "should assign permissions to the object" do
+      @entity.permissions.size.should == 0
+      @entity.update_attribute(:user_ids, ['1','2','3'])
+      @entity.permissions.find_all_by_user_id([1,2,3]).size.should == 3
+    end
+    
+    it "should assign permissions with the 'chosen' select box format" do
+      @entity.permissions.size.should == 0
+      @entity.update_attribute(:user_ids, ['', '1,2,3'])
+      @entity.permissions.find_all_by_user_id([1,2,3]).size.should == 3
+    end
+    
+    it "should handle [] permissions" do
+      @entity.update_attribute(:user_ids, [])
+      @entity.permissions.size.should == 0
+    end
+    
+    it "should replace existing permissions" do
+      @entity.permissions << FactoryGirl.create(:permission, :user_id => 1, :asset => @entity)
+      @entity.permissions << FactoryGirl.create(:permission, :user_id => 2, :asset => @entity)
+      @entity.update_attribute(:user_ids, ['2','3'])
+      @entity.permissions.size.should == 2
+      @entity.permissions.find_all_by_user_id([1]).size.should == 0
+      @entity.permissions.find_all_by_user_id([2]).size.should == 1
+      @entity.permissions.find_all_by_user_id([3]).size.should == 1
+    end
+    
+  end
+  
+  describe "group_ids" do
+    before(:each) do
+      @entity = UserWithPermission.create(:access => "Shared")
+    end
+    it "should assign permissions to the object" do
+      @entity.permissions.size.should == 0
+      @entity.update_attribute(:group_ids, ['1','2','3'])
+      @entity.permissions.find_all_by_group_id([1,2,3]).size.should == 3
+    end
+    
+    it "should assign permissions with the 'chosen' select box format" do
+      @entity.permissions.size.should == 0
+      @entity.update_attribute(:group_ids, ['', '1,2,3'])
+      @entity.permissions.find_all_by_group_id([1,2,3]).size.should == 3
+    end
+    
+    it "should handle [] permissions" do
+      @entity.update_attribute(:group_ids, [])
+      @entity.permissions.size.should == 0
+    end
+    
+    it "should replace existing permissions" do
+      @entity.permissions << FactoryGirl.build(:permission, :group_id => 1, :user_id => nil, :asset => @entity)
+      @entity.permissions << FactoryGirl.build(:permission, :group_id => 2, :user_id => nil, :asset => @entity)
+      @entity.permissions.size.should == 2
+      @entity.update_attribute(:group_ids, ['3'])
+      @entity.permissions.size.should == 1
+      @entity.permissions.find_all_by_group_id([1,2]).size.should == 0
+      @entity.permissions.find_all_by_group_id([3]).size.should == 1
+    end
+  end
+
+  describe "access" do
+    before(:each) do
+      @entity = UserWithPermission.create
+    end
+    it "should delete all permissions if access is set to Public" do
+      perm = FactoryGirl.create(:permission, :user_id => 1, :asset => @entity)
+      perm.should_receive(:destroy)
+      Permission.should_receive(:find_all_by_asset_id_and_asset_type).with(@entity.id, @entity.class).and_return([perm])
+      @entity.update_attribute(:access, 'Public')
+    end
+    it "should delete all permissions if access is set to Private" do
+      perm = FactoryGirl.create(:permission, :user_id => 1, :asset => @entity)
+      perm.should_receive(:destroy)
+      Permission.should_receive(:find_all_by_asset_id_and_asset_type).with(@entity.id, @entity.class).and_return([perm])
+      @entity.update_attribute(:access, 'Private')
+    end
+    it "should not remove permissions if access is set to Shared" do
+      perm = FactoryGirl.create(:permission, :user_id => 1, :asset => @entity)
+      perm.should_not_receive(:destroy)
+      @entity.permissions << perm
+      Permission.should_not_receive(:find_all_by_asset_id)
+      @entity.update_attribute(:access, 'Shared')
+      @entity.permissions.size.should == 1
+    end
+  end
+
+  describe "save_with_permissions" do
+    it "should raise deprecation warning and call save" do
+      entity = UserWithPermission.new
+      ActiveSupport::Deprecation.should_receive(:warn)
+      entity.should_receive(:save)
+      entity.save_with_permissions
+    end
+  end
+  
+  describe "update_with_permissions" do
+    it "should raise deprecation warning and call update_attributes" do
+      entity = UserWithPermission.new
+      ActiveSupport::Deprecation.should_receive(:warn)
+      entity.should_receive(:update_attributes).with({})
+      entity.update_with_permissions({})
+    end
+  end
+
+  describe "save_with_model_permissions" do
+    it "should copy permissions from original model" do
+      entity = UserWithPermission.new
+      model = mock_model(Account, :access => "Shared", :user_ids => [1,2,3], :group_ids => [4,5,6])
+      entity.should_receive(:access=).with("Shared")
+      entity.should_receive(:user_ids=).with([1,2,3])
+      entity.should_receive(:group_ids=).with([4,5,6])
+      entity.should_receive(:save)
+      entity.save_with_model_permissions(model)
+    end
+  end
+    
+end