fastlane 2.28.9 → 2.29.0.beta.20170421010107

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3186c50a7d29fce28650a28f133b5612b848ec1f
-  data.tar.gz: 71c9ec36764d97635a28d1b8a1dfa4a668810e57
+  metadata.gz: 85014dfb38ec08df2e882b67dab2873104d1f82c
+  data.tar.gz: 64afaa9217e93f86628361b8725f164e8dffcf69
 SHA512:
-  metadata.gz: 2c9bfb2132277f93c86859aafd2f1121c8a8348b719262450f66a7d3e0856e01b793adb2c937b4c2aa43906e3e1341077fb229813630190a6365f1c37fe421d9
-  data.tar.gz: 447f4bb6b4fe48a593e83b1c2008fa55aa23bd94f9808387ebe3d7147589be38701f0d366786708d093e59bf28b4225586f52bd2241d1665f97249105c1a8d90
+  metadata.gz: 7d03cc1e1d52bb69d4ed64e05a28bd5917c888c419825e382e72d90df0ccb19ede70fe3e9bc43f416bdcbabe196ebfac64290a5be9c4236da0dfe8cf854868a8
+  data.tar.gz: e625dec851c79be6c9821c4a7c799b73daf3d7cdd7f9687298ca84c31cac38d25691dc817da05cc3a1fd3f9eadc242586b761fd64a4cc24c3d7807a263798d7f

data/README.md

@@ -48,7 +48,7 @@ Then to deploy a new 'beta' version of your app just run
 :ghost: | [Jenkins Integration](https://docs.fastlane.tools/best-practices/continuous-integration/#jenkins-integration): Show output directly in test results
 :book: | Automatically generate Markdown documentation of your lane configurations
 :hatching_chick: | Over 170 built-in integrations available
-:computer: | Support for iOS and Android apps
+:computer: | Support for iOS, macOS, and Android apps
 :octocat: | Full Git and Mercurial support
 
 <hr />

data/deliver/lib/assets/summary.html.erb

@@ -107,9 +107,6 @@
               margin-left: 10px;
               margin-right: 10px;
           }
-          .app-icons {
-            overflow: hidden;
-          }
           .app-icons img {
             width: 150px;
           }

data/deliver/lib/deliver/options.rb

@@ -37,7 +37,7 @@ module Deliver
                                      optional: true,
                                      env_name: "DELIVER_IPA_PATH",
                                      description: "Path to your ipa file",
-                                     default_value: Dir["*.ipa"].sort_by { |x| File.mtime(x) }.last,
+                                     default_value: Dir["*.ipa"].first,
                                      verify_block: proc do |value|
                                        UI.user_error!("Could not find ipa file at path '#{File.expand_path(value)}'") unless File.exist?(value)
                                        UI.user_error!("'#{value}' doesn't seem to be an ipa file") unless value.end_with?(".ipa")
@@ -51,7 +51,7 @@ module Deliver
                                      optional: true,
                                      env_name: "DELIVER_PKG_PATH",
                                      description: "Path to your pkg file",
-                                     default_value: Dir["*.pkg"].sort_by { |x| File.mtime(x) }.last,
+                                     default_value: Dir["*.pkg"].first,
                                      verify_block: proc do |value|
                                        UI.user_error!("Could not find pkg file at path '#{File.expand_path(value)}'") unless File.exist?(value)
                                        UI.user_error!("'#{value}' doesn't seem to be a pkg file") unless value.end_with?(".pkg")

data/deliver/lib/deliver/upload_metadata.rb

@@ -116,7 +116,7 @@ module Deliver
       end
 
       # Check folder list (an empty folder signifies a language is required)
-      Loader.language_folders(options[:metadata_path]).each do |lng_folder|
+      Dir.glob(File.join(options[:metadata_path], "*")).each do |lng_folder|
         next unless File.directory?(lng_folder) # We don't want to read txt as they are non localised
 
         language = File.basename(lng_folder)
@@ -233,7 +233,6 @@ module Deliver
         UI.error(ex.to_s)
         UI.user_error!("Error parsing JSON file at path '#{options[:app_rating_config_path]}'")
       end
-      UI.message("Setting the app's age rating...")
       v.update_rating(json)
     end
   end

data/fastlane/README.md

@@ -91,7 +91,7 @@ fastlane release
 :ghost: | [Jenkins Integration](https://docs.fastlane.tools/best-practices/continuous-integration/#jenkins-integration): Show the output directly in the Jenkins test results
 :book: | Automatically generate a markdown documentation of your lane config
 :hatching_chick: | Over 170 built-in integrations available
-:computer: | Support for iOS and Android apps
+:computer: | Support for iOS, macOS and Android apps
 :octocat: | Full git and mercurial support
 
 
@@ -138,11 +138,7 @@ The setup assistant will create all the necessary files for you, using the exist
 - Follow the setup assistant, which will set up ```fastlane``` for you
 - Further customise the ```Fastfile``` with [actions](https://docs.fastlane.tools/actions).
 
-For more details, follow our new Getting Started guides:
-
-- [Getting Started fastlane guide for iOS](https://docs.fastlane.tools/getting-started/ios/setup/)
-- [Getting Started fastlane guide for Android](https://docs.fastlane.tools/getting-started/android/setup/)
-
+For more details, please follow the [fastlane guide](https://github.com/fastlane/fastlane/blob/master/fastlane/docs/Guide.md) or [documentation](https://github.com/fastlane/fastlane/tree/master/fastlane/docs).
 
 There are also 2 Japanese fastlane guides available: [qiita](http://qiita.com/gin0606/items/a8573b582752de0c15e1) and [mercari](http://tech.mercari.com/entry/2015/07/13/143000)
 

data/fastlane/lib/fastlane/actions/artifactory.rb

@@ -1,10 +1,5 @@
 module Fastlane
   module Actions
-    module SharedValues
-      ARTIFACTORY_DOWNLOAD_URL = :ARTIFACTORY_DOWNLOAD_URL
-      ARTIFACTORY_DOWNLOAD_SIZE = :ARTIFACTORY_DOWNLOAD_SIZE
-    end
-
     class ArtifactoryAction < Action
       def self.run(params)
         Actions.verify_gem!('artifactory')
@@ -22,10 +17,6 @@ module Fastlane
           }
           UI.message("Uploading file: #{artifact.local_path} ...")
           upload = artifact.upload(params[:repo], params[:repo_path], params[:properties])
-
-          Actions.lane_context[SharedValues::ARTIFACTORY_DOWNLOAD_URL] = upload.uri
-          Actions.lane_context[SharedValues::ARTIFACTORY_DOWNLOAD_SIZE] = upload.size
-
           UI.message("Uploaded Artifact:")
           UI.message("Repo: #{upload.repo}")
           UI.message("URI: #{upload.uri}")
@@ -53,14 +44,7 @@ module Fastlane
       end
 
       def self.author
-        ["koglinjg", "tommeier"]
-      end
-
-      def self.output
-        [
-          ['ARTIFACTORY_DOWNLOAD_URL', 'The download url for file uploaded'],
-          ['ARTIFACTORY_DOWNLOAD_SIZE', 'The reported file size for file uploaded']
-        ]
+        ["koglinjg"]
       end
 
       def self.example_code

data/fastlane/lib/fastlane/actions/crashlytics.rb

@@ -65,7 +65,7 @@ module Fastlane
         platform = Actions.lane_context[Actions::SharedValues::PLATFORM_NAME]
 
         if platform == :ios or platform.nil?
-          ipa_path_default = Dir["*.ipa"].sort_by { |x| File.mtime(x) }.last
+          ipa_path_default = Dir["*.ipa"].last
         end
 
         if platform == :android

data/fastlane/lib/fastlane/actions/download_dsyms.rb

@@ -166,7 +166,7 @@ module Fastlane
       end
 
       def self.is_supported?(platform)
-        [:ios, :appletvos].include?(platform)
+        platform == :ios
       end
 
       def self.example_code

data/fastlane/lib/fastlane/actions/ensure_git_status_clean.rb

@@ -7,16 +7,13 @@ module Fastlane
     # Raises an exception and stop the lane execution if the repo is not in a clean state
     class EnsureGitStatusCleanAction < Action
       def self.run(params)
-        repo_status = Actions.sh("git status --porcelain")
-        repo_clean = repo_status.empty?
+        repo_clean = `git status --porcelain`.empty?
 
         if repo_clean
           UI.success('Git status is clean, all good! 💪')
           Actions.lane_context[SharedValues::GIT_REPO_WAS_CLEAN_ON_START] = true
         else
-          error_message = "Git repository is dirty! Please ensure the repo is in a clean state by committing/stashing/discarding all changes first."
-          error_message += "\nUncommitted changes:\n#{repo_status}" if params[:show_uncommitted_changes]
-          UI.user_error!(error_message)
+          UI.user_error!("Git repository is dirty! Please ensure the repo is in a clean state by committing/stashing/discarding all changes first.")
         end
       end
 
@@ -41,24 +38,13 @@ module Fastlane
       end
 
       def self.author
-        ["lmirosevic", "antondomashnev"]
+        "lmirosevic"
       end
 
       def self.example_code
         ['ensure_git_status_clean']
       end
 
-      def self.available_options
-        [
-          FastlaneCore::ConfigItem.new(key: :show_uncommitted_changes,
-                                       env_name: "FL_ENSURE_GIT_STATUS_CLEAN_SHOW_UNCOMMITTED_CHANGES",
-                                       description: "The flag whether to show uncommitted changes if the repo is dirty",
-                                       optional: true,
-                                       default_value: false,
-                                       is_string: false)
-        ]
-      end
-
       def self.category
         :source_control
       end

data/fastlane/lib/fastlane/actions/hockey.rb

@@ -250,7 +250,7 @@ module Fastlane
                                        default_value: "1"),
           FastlaneCore::ConfigItem.new(key: :status,
                                        env_name: "FL_HOCKEY_STATUS",
-                                       description: "Download status: \"1\" = No user can download; \"2\" = Available for download (only possible with full-access token)",
+                                       description: "Download status: \"1\" = No user can download; \"2\" = Available for download",
                                        default_value: "2"),
           FastlaneCore::ConfigItem.new(key: :notes_type,
                                       env_name: "FL_HOCKEY_NOTES_TYPE",

data/fastlane/lib/fastlane/actions/upload_symbols_to_crashlytics.rb

@@ -128,10 +128,10 @@ module Fastlane
                                        end),
           FastlaneCore::ConfigItem.new(key: :platform,
                                        env_name: "FL_UPLOAD_SYMBOLS_TO_CRASHLYTICS_PLATFORM",
-                                       description: "The platform of the app (ios, appletvos, mac)",
+                                       description: "The platform of the app (ios, tvos, mac)",
                                        default_value: "ios",
                                        verify_block: proc do |value|
-                                         available = ['ios', 'appletvos', 'mac']
+                                         available = ['ios', 'tvos', 'mac']
                                          UI.user_error!("Invalid platform '#{value}', must be #{available.join(', ')}") unless available.include?(value)
                                        end)
         ]
@@ -150,7 +150,7 @@ module Fastlane
       end
 
       def self.is_supported?(platform)
-        [:ios, :appletvos].include?(platform)
+        platform == :ios
       end
 
       def self.example_code

data/fastlane/lib/fastlane/plugins/template/.rubocop.yml

@@ -1,6 +1,6 @@
 Style/PercentLiteralDelimiters:
   Enabled: false
-
+  
 # kind_of? is a good way to check a type
 Style/ClassCheck:
   EnforcedStyle: kind_of?
@@ -16,12 +16,6 @@ Style/SafeNavigation:
 Performance/RegexpMatch:
   Enabled: false
 
-# This suggests use of `tr` instead of `gsub`. While this might be more performant,
-# these methods are not at all interchangable, and behave very differently. This can
-# lead to people making the substitution without considering the differences.
-Performance/StringReplacement:
-  Enabled: false
-
 # .length == 0 is also good, we don't always want .zero?
 Style/NumericPredicate:
   Enabled: false
@@ -29,7 +23,7 @@ Style/NumericPredicate:
 # this would cause errors with long lanes
 Metrics/BlockLength:
   Enabled: false
-
+  
 # this is a bit buggy
 Metrics/ModuleLength:
   Enabled: false
@@ -42,23 +36,23 @@ Style/VariableNumber:
 Style/MethodMissing:
   Enabled: false
 
-#
+# 
 #   File.chmod(0777, f)
-#
+# 
 # is easier to read than
-#
+# 
 #   File.chmod(0o777, f)
-#
+# 
 Style/NumericLiteralPrefix:
   Enabled: false
 
-#
+# 
 # command = (!clean_expired.nil? || !clean_pattern.nil?) ? CLEANUP : LIST
-#
+# 
 # is easier to read than
-#
+# 
 # command = !clean_expired.nil? || !clean_pattern.nil? ? CLEANUP : LIST
-#
+# 
 Style/TernaryParentheses:
   Enabled: false
 

data/fastlane/lib/fastlane/version.rb

@@ -1,4 +1,4 @@
 module Fastlane
-  VERSION = '2.28.9'.freeze
+  VERSION = '2.29.0.beta.20170421010107'.freeze
   DESCRIPTION = "The easiest way to automate beta deployments and releases for your iOS and Android apps".freeze
 end

data/fastlane_core/lib/fastlane_core/build_watcher.rb

@@ -1,54 +1,36 @@
 module FastlaneCore
   class BuildWatcher
-    class << self
-      # @return The build we waited for. This method will always return a build
-      def wait_for_build_processing_to_be_complete(app_id: nil, platform: nil)
-        # First, find the train and build version we want to watch for
-        watched_build = watching_build(app_id: app_id, platform: platform)
-        UI.crash!("Could not find a build for app: #{app_id} on platform: #{platform}") if watched_build.nil?
+    # @return The build we waited for. This method will always return a build
+    def self.wait_for_build_processing_to_be_complete(app_id: nil, platform: nil)
+      # First, find the train and build version we want to watch for
+      processing_builds = Spaceship::TestFlight::Build.all_processing_builds(app_id: app_id, platform: platform)
 
-        loop do
-          matched_build = matching_build(watched_build: watched_build, app_id: app_id, platform: platform)
+      watching_build = processing_builds.sort_by(&:upload_date).last # either it's still processing
+      watching_build ||= Spaceship::TestFlight::Build.latest(app_id: app_id, platform: platform) # or we fallback to the most recent uplaod
 
-          report_status(build: matched_build)
+      loop do
+        UI.message("Waiting for iTunes Connect to finish processing the new build (#{watching_build.train_version} - #{watching_build.build_version})")
 
-          if matched_build && matched_build.processed?
-            return matched_build
-          end
-
-          sleep 10
-        end
-      end
-
-      private
-
-      def watching_build(app_id: nil, platform: nil)
-        processing_builds = Spaceship::TestFlight::Build.all_processing_builds(app_id: app_id, platform: platform)
-
-        watched_build = processing_builds.sort_by(&:upload_date).last
-        watched_build || Spaceship::TestFlight::Build.latest(app_id: app_id, platform: platform)
-      end
-
-      def matching_build(watched_build: nil, app_id: nil, platform: nil)
-        matched_builds = Spaceship::TestFlight::Build.builds_for_train(app_id: app_id, platform: platform, train_version: watched_build.train_version)
-        matched_builds.find { |build| build.build_version == watched_build.build_version }
-      end
-
-      def report_status(build: nil)
         # Due to iTunes Connect, builds disappear from the build list alltogether
         # after they finished processing. Before returning this build, we have to
         # wait for the build to appear in the build list again
         # As this method is very often used to wait for a build, and then do something
         # with it, we have to be sure that the build actually is ready
-        if build.nil?
+
+        matching_builds = Spaceship::TestFlight::Build.builds_for_train(app_id: app_id, platform: platform, train_version: watching_build.train_version)
+        matching_build = matching_builds.find { |build| build.build_version == watching_build.build_version }
+
+        if matching_build.nil?
           UI.message("Build doesn't show up in the build list any more, waiting for it to appear again")
-        elsif build.active?
-          UI.success("Build #{build.train_version} - #{build.build_version} is already being tested")
-        elsif build.ready_to_submit? || build.export_compliance_missing?
-          UI.success("Successfully finished processing the build #{build.train_version} - #{build.build_version}")
-        else
-          UI.message("Waiting for iTunes Connect to finish processing the new build (#{build.train_version} - #{build.build_version})")
+        elsif matching_build.active?
+          UI.success("Build #{matching_build.train_version} - #{matching_build.build_version} is already being tested")
+          return matching_build
+        elsif matching_build.ready_to_submit?
+          UI.success("Successfully finished processing the build #{matching_build.train_version} - #{matching_build.build_version}")
+          return matching_build
         end
+
+        sleep 10
       end
     end
   end

data/fastlane_core/lib/fastlane_core/helper.rb

@@ -118,6 +118,11 @@ module FastlaneCore
       FastlaneCore::Env.truthy?("TERM_PROGRAM_VERSION")
     end
 
+    # Does the user use iTerm?
+    def self.iterm?
+      FastlaneCore::Env.truthy?("ITERM_SESSION_ID")
+    end
+
     # Logs base directory
     def self.buildlog_path
       return ENV["FL_BUILDLOG_PATH"] || "~/Library/Logs"
@@ -208,13 +213,6 @@ module FastlaneCore
       keychain_path
     end
 
-    # @return true if XCode version is higher than 8.3
-    def self.xcode_at_least?(version)
-      FastlaneCore::UI.user_error!("Unable to locate Xcode. Please make sure to have Xcode installed on your machine") if xcode_version.nil?
-      v = xcode_version
-      Gem::Version.new(v) >= Gem::Version.new(version)
-    end
-
     # @return the full path to the iTMSTransporter executable
     def self.itms_path
       return ENV["FASTLANE_ITUNES_TRANSPORTER_PATH"] if FastlaneCore::Env.truthy?("FASTLANE_ITUNES_TRANSPORTER_PATH")

data/fastlane_core/lib/fastlane_core/itunes_transporter.rb

@@ -376,10 +376,7 @@ module FastlaneCore
     def load_password_for_transporter
       # 3 different sources for the password
       #   1) ENV variable for application specific password
-      if ENV[TWO_FACTOR_ENV_VARIABLE].to_s.length > 0
-        UI.message("Fetching password for transporter from environment variable named `#{TWO_FACTOR_ENV_VARIABLE}`")
-        return ENV[TWO_FACTOR_ENV_VARIABLE]
-      end
+      return ENV[TWO_FACTOR_ENV_VARIABLE] if ENV[TWO_FACTOR_ENV_VARIABLE].to_s.length > 0
       #   2) TWO_STEP_HOST_PREFIX from keychain
       account_manager = CredentialsManager::AccountManager.new(user: @user,
                                                              prefix: TWO_STEP_HOST_PREFIX,

data/fastlane_core/lib/fastlane_core/print_table.rb

@@ -44,7 +44,7 @@ module FastlaneCore
         value = ""
         array.each do  |l|
           colored_line = l
-          colored_line = "#{colors.first}#{l}#{colors.last}" if colors.length > 0
+          colored_line = "#{colors.first[0]}#{l}#{colors.last[0]}" if colors.length > 0
           value << colored_line
           value << "\n"
         end
@@ -68,10 +68,15 @@ module FastlaneCore
           return value.middle_truncate(max_value_length)
         elsif transform == :newline
           # remove all fixed newlines as it may mess up the output
-          value.gsub!("\n", " ") if value.kind_of?(String)
+          value.tr!("\n", " ") if value.kind_of?(String)
           if value.length >= max_value_length
-            colors = value.scan(/\e\[.*?m/)
-            colors.each { |color| value.gsub!(color, '') }
+            colors = value.scan(/(\e\[.*?m)/)
+            if colors && colors.length > 0
+              colors.each do |color|
+                value.delete!(color.first)
+                value.delete!(color.last)
+              end
+            end
             lines = value.wordwrap(max_value_length)
             return  colorize_array(lines, colors)
           end

data/fastlane_core/lib/fastlane_core/project.rb

@@ -279,14 +279,9 @@ module FastlaneCore
     def build_xcodebuild_showbuildsettings_command
       # We also need to pass the workspace and scheme to this command.
       #
-      # The 'clean' portion of this command was a workaround for an xcodebuild bug with Core Data projects.
-      # This xcodebuild bug is fixed in Xcode 8.3 so 'clean' it's not necessary anymore
+      # The 'clean' portion of this command is a workaround for an xcodebuild bug with Core Data projects.
       # See: https://github.com/fastlane/fastlane/pull/5626
-      if FastlaneCore::Helper.xcode_at_least?('8.3')
-        command = "xcodebuild -showBuildSettings #{xcodebuild_parameters.join(' ')}"
-      else
-        command = "xcodebuild clean -showBuildSettings #{xcodebuild_parameters.join(' ')}"
-      end
+      command = "xcodebuild clean -showBuildSettings #{xcodebuild_parameters.join(' ')}"
       command += " 2> /dev/null" if xcodebuild_suppress_stderr
       command
     end
@@ -296,16 +291,9 @@ module FastlaneCore
     # @param [String] The key of which we want the value for (e.g. "PRODUCT_NAME")
     def build_settings(key: nil, optional: true)
       unless @build_settings
-        if is_workspace
-          if schemes.count == 0
-            UI.user_error!("Could not find any schemes for Xcode workspace at path '#{self.path}'. Please make sure that the schemes you want to use are marked as `Shared` from Xcode.")
-          end
-          options[:scheme] ||= schemes.first
-        end
-
         command = build_xcodebuild_showbuildsettings_command
 
-        # Xcode might hang here and retrying fixes the problem, see fastlane#4059
+        # xcode might hang here and retrying fixes the problem, see fastlane#4059
         begin
           timeout = FastlaneCore::Project.xcode_build_settings_timeout
           retries = FastlaneCore::Project.xcode_build_settings_retries
@@ -339,7 +327,7 @@ module FastlaneCore
 
     # Returns the build settings and sets the default scheme to the options hash
     def default_build_settings(key: nil, optional: true)
-      options[:scheme] ||= schemes.first if is_workspace
+      options[:scheme] = schemes.first if is_workspace
       build_settings(key: key, optional: optional)
     end